mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-14 08:53:19 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat eval catalog runs real chat journeys against real agents and grades saved product state > - Full cohort 3 failed six cases where the product behaved correctly and the eval was wrong > - A wrong failure hides real product failures in the noise, so each check must accept valid behavior > - Each check must still fail the broken product behavior it exists to catch > - This pull request replaces those checks with checks of saved state, read receipts and rendered links > - The benefit is fewer false failures, with no case made easier ## Linked Issues or Issue Description Refs #21000 **What happened?** - `projects.project-work`, `tasks.private-task`, `status-cards.other-authors-card` and part of `task-coordination.delegate-with-context`: the CEO created a task with no assignee, so the CEO got a queued run on it. The CEO then reassigned the task. The server cancelled the queued run before it started (`issue_reassigned` or `issue_assignee_changed`). The early poll reported this as "Observed provider run failed", and the run policy counted a never-started legacy run as a failed native run. - `budgets-costs.repair-cost-recording`: after the retry, the chat run re-read the original run record with `saveResponse`. The check accepted only an exact whole-input digest, and this input had another shape. - `secrets.personal-secret`: the reply linked My secrets and said "Enter the value only there, never in chat". `solicitsChatCredential` read "never in chat" as a request to send the value in chat. - `companies.import-preview`: the reply linked `/COM/agents/morgan-package`. The check accepted only `/agents/<uuid>`. - `cases.close-case`: the closure was correct. The result turn said "Case COM-C1 is saved as closed". A keyword pattern did not match that sentence. **Expected behavior** Each check passes the recorded valid behavior and a reworded valid variant. Each check fails the broken behavior. **Steps to reproduce** Grade the retained cohort-3 evidence with the old checks. They fail. The calibration tests in this pull request use the same recorded shapes. ## What Changed - Run policy: a new rule admits a queued run that the server retired before it started because its task changed assignee. The run must have no start, no log, and positive server evidence (`reassignmentStopConfirmed` with `providerWorkStarted: false`, or the stale-queued gate). The task must not be the source chat. A later run by another agent on the same task must exist. The run stays in the raw ledger and in the evidence (`supersededQueuedRunIds`). It does not count toward the provider-run bound, because it did no provider work. A case can have at most one such run (`catalog-superseded-queued-runs`). The early poll defers it to the grade instead of failing at once. Cases read the ledger without it. Other cancellations stay failures. - `budgets-costs.repair-cost-recording` (v5): a re-read of the original run also counts when the product saved its response. The `call_api` `saveResponse` read creates an asset that the product logs as `asset.created` by that run. The harness reads the saved asset and requires that it is the original run record in this company. - `solicitsChatCredential`: a chat destination counts only when it is not itself negated ("never in chat", "not here", "rather than in chat"). This is a scope rule, not a new phrase exception. "Paste it here" and mixed requests still fail. `secrets.personal-secret` is v18. - `companies.import-preview` (v3): new `agentRouteNames` accepts `/<prefix>/agents/<id or url key>[/<tab>]` that names the imported agent. It rejects the existing Morgan, other companies and other origins. - `cases.close-case` (v2): the result turn is graded on its own saved replies. Their run must read the saved case (`read_case` or `GET /api/cases/{id}`, bound by the redaction-safe receipt). The reply must render a link to that case. The case must be done. The wording is not matched. `api-read-receipts` now binds the dedicated `read_case` tool. - The four reassignment cases get new oracle versions. Descriptors are updated. No scenario yaml changed, so the TestOps manifest does not change. ## Verification - `npx vitest run --config tests/runner-e2e/vitest.config.ts` on the 17 affected test files: 516 tests pass. The files include `chat-catalog-run-policy`, `chat-flow`, `non-execution-wake`, `chat-catalog-consistency`, `chat-catalog-fingerprint`, `identity-accounting`, `external-credential-language`, `external-personal-secret`, `identity-portability`, `integrator-case-close`, `api-read-receipts` and the other secret-language users. - Each change has calibration tests: the recorded valid shape, a reworded valid shape, and broken shapes (no successor run, a started or other cancellation, churn; another run's saved record; "paste it here"; the existing Morgan's route; an unread or unlinked result turn). - `npx tsc -p tests/runner-e2e/tsconfig.json --noEmit` passes. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check` reports no change. - One paid run on a combined branch with the companion harness pull request. The result is in a comment on this pull request. ## Risks - The superseded-run rule trusts the successor run as proof of reassignment. A case oracle still grades the task assignee and the successor's own outcome. - The close-case result turn no longer checks the reply's words. A reply that reads the closed case and links it but states the wrong result passes this one check. The first-turn premature-claim check and the negative-case check do not change. - The credential grader change also affects other secret cases. It only removes the negated-destination false positive. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, with tool use and code execution in Claude Code. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
150 lines
12 KiB
TypeScript
150 lines
12 KiB
TypeScript
import type { ChatCatalogCase, ChatCatalogGrade } from "./chat-catalog-contract.js";
|
|
import type { ChatIssue, ChatRun } from "./chat-flow.js";
|
|
import { isAssigneeChangedUnstartedRun } from "./non-execution-wake.js";
|
|
type CancellationCase = Pick<ChatCatalogCase, "runPolicy"> & Partial<Pick<ChatCatalogCase, "scenarioId" | "expectedCancelledWorkerRun">>;
|
|
export function assertExpectedWorkerCancellation(implementation: CancellationCase) {
|
|
const flag = implementation.runPolicy?.kind === "source-settled-with-active-work"
|
|
? implementation.runPolicy.expectedWorkerCancellation : undefined;
|
|
if (flag === undefined ? implementation.expectedCancelledWorkerRun !== undefined
|
|
: flag !== "owned-task-reassignment" || implementation.scenarioId !== "tasks.edit-properties" || typeof implementation.expectedCancelledWorkerRun !== "function")
|
|
throw new Error("Missing or undeclared exact task-reassignment cancellation proof");
|
|
}
|
|
function permitsReassignment(implementation: CancellationCase) {
|
|
return implementation.scenarioId === "tasks.edit-properties" && implementation.runPolicy?.kind === "source-settled-with-active-work"
|
|
&& implementation.runPolicy.expectedWorkerCancellation === "owned-task-reassignment" && typeof implementation.expectedCancelledWorkerRun === "function";
|
|
}
|
|
export function chatCatalogAllowedRunStatuses(implementation: CancellationCase): string[] {
|
|
const policy = implementation.runPolicy;
|
|
return policy?.kind === "terminal-counts" ? Object.keys(policy.terminalStatusCounts)
|
|
: policy?.kind === "source-settled-with-active-work" ? ["queued", "running", "succeeded", ...(permitsReassignment(implementation) ? ["cancelled"] : [])] : ["succeeded"];
|
|
}
|
|
const taskId = (run: ChatRun) => (run as ChatRun & { nativeIssueId?: string }).nativeIssueId ?? run.contextSnapshot?.issueId;
|
|
const record = (value: unknown) => value && typeof value === "object" ? value as Record<string, unknown> : {};
|
|
/** Early polling can defer only the saved, independently held worker, never a source or unrelated cancellation. */
|
|
export function chatCatalogRunStatusAllowed(input: {
|
|
implementation: CancellationCase; run: ChatRun; companyId: string; leadId: string; source?: ChatIssue; observation?: unknown;
|
|
}): boolean {
|
|
const { implementation, run } = input;
|
|
if (run.status !== "cancelled" || !permitsReassignment(implementation)) return chatCatalogAllowedRunStatuses(implementation).includes(run.status);
|
|
const state = record(record(input.observation).state), held = record(state.heldRun), task = record(state.heldTask), worker = record(state.riley);
|
|
return held.id === run.id && held.status === "running" && held.companyId === input.companyId && held.agentId === worker.id
|
|
&& run.companyId === input.companyId && run.agentId === worker.id && run.agentId !== input.leadId
|
|
&& task.companyId === input.companyId && task.assigneeAgentId === worker.id && task.executionRunId === run.id
|
|
&& task.id === taskId(run) && task.id !== input.source?.id && run.errorCode === "issue_reassigned";
|
|
}
|
|
/**
|
|
* A queued run that never started and that the server cancelled because its own
|
|
* non-source task reached a terminal status is a task lifecycle event, not a
|
|
* provider failure. Early polling must not stop on it; the run stays in the
|
|
* ledger, and the run-bound and case checks still grade it.
|
|
*/
|
|
export function chatCatalogNeverStartedTerminalTaskRun(run: ChatRun, source?: ChatIssue): boolean {
|
|
const issueId = taskId(run);
|
|
return run.status === "cancelled" && run.errorCode === "issue_terminal_status" && !run.startedAt
|
|
&& record(run.resultJson).stopReason === "issue_terminal_status"
|
|
&& typeof issueId === "string" && issueId.length > 0 && issueId !== source?.id;
|
|
}
|
|
/**
|
|
* A queued run on a non-source task that the server retired because the task
|
|
* changed assignee before the run started. Early polling defers it to the grade
|
|
* instead of reporting a provider failure; it is admitted there only with a
|
|
* successor (see chatCatalogSupersededQueuedRuns). Other cancellations stay failures.
|
|
*/
|
|
export function chatCatalogReassignedQueuedRun(run: ChatRun, source?: ChatIssue): boolean {
|
|
const issueId = taskId(run);
|
|
return isAssigneeChangedUnstartedRun(run) && typeof issueId === "string" && issueId.length > 0 && issueId !== source?.id;
|
|
}
|
|
/**
|
|
* The superseded queued run did no provider work, so it is not counted toward
|
|
* the declared provider-run bound. It stays in the raw ledger and evidence, and
|
|
* a case may have at most this many, so create-then-reassign churn still fails.
|
|
*/
|
|
export const CHAT_CATALOG_MAX_SUPERSEDED_QUEUED_RUNS = 1;
|
|
/** Retired queued runs whose task's new assignee actually received a later run on that task. */
|
|
export function chatCatalogSupersededQueuedRuns(runs: ChatRun[], source?: ChatIssue): ChatRun[] {
|
|
return runs.filter(run => {
|
|
const created = Date.parse(run.createdAt ?? "");
|
|
return chatCatalogReassignedQueuedRun(run, source) && Number.isFinite(created) && runs.some(other => other.id !== run.id
|
|
&& taskId(other) === taskId(run) && other.companyId === run.companyId && other.agentId !== run.agentId
|
|
&& !chatCatalogReassignedQueuedRun(other, source) && Date.parse(other.createdAt ?? "") >= created);
|
|
});
|
|
}
|
|
/** The raw ledger without superseded queued runs: the runs that count as provider work. */
|
|
export function chatCatalogProviderRuns(runs: ChatRun[], source?: ChatIssue): ChatRun[] {
|
|
const superseded = new Set(chatCatalogSupersededQueuedRuns(runs, source).map(run => run.id));
|
|
return runs.filter(run => !superseded.has(run.id));
|
|
}
|
|
export function gradeChatCatalogRuns(input: {
|
|
implementation: Pick<ChatCatalogCase, "expectedRunCount" | "minimumRunCount" | "runPolicy"> & CancellationCase;
|
|
companyId: string; leadId: string; source?: ChatIssue; runs: ChatRun[];
|
|
observation?: unknown;
|
|
}): ChatCatalogGrade {
|
|
const { implementation: c, source } = input;
|
|
const superseded = chatCatalogSupersededQueuedRuns(input.runs, source);
|
|
const runs = chatCatalogProviderRuns(input.runs, source);
|
|
const checks = [
|
|
{ id: "catalog-bounded-native-runs", passed: runs.length >= (c.minimumRunCount ?? c.expectedRunCount) && runs.length <= c.expectedRunCount
|
|
&& runs.every(run => run.companyId === input.companyId && run.runtimeMode === "native" && chatCatalogAllowedRunStatuses(c).includes(run.status)),
|
|
detail: "Observed provider runs satisfy declared count, company, native runtime and allowed outcome bounds." },
|
|
];
|
|
if (superseded.length) checks.push({ id: "catalog-superseded-queued-runs", passed: superseded.length <= CHAT_CATALOG_MAX_SUPERSEDED_QUEUED_RUNS,
|
|
detail: "A queued run retired before it started because its task changed assignee is lifecycle, not provider work, only when the new assignee ran on that task; at most one per case." });
|
|
if (c.expectedCancelledWorkerRun !== undefined || c.runPolicy?.kind === "source-settled-with-active-work" && c.runPolicy.expectedWorkerCancellation !== undefined) {
|
|
let valid = true; try { assertExpectedWorkerCancellation(c); } catch { valid = false; }
|
|
checks.push({ id: "catalog-worker-cancellation-declaration", passed: valid,
|
|
detail: "Only edit-properties may declare the exact independently proved worker reassignment cancellation." });
|
|
}
|
|
if (c.runPolicy?.kind === "terminal-counts") {
|
|
const policy = c.runPolicy, maximum = policy.maximumTerminalStatusCounts ?? {};
|
|
checks.push({ id: "catalog-exact-run-outcomes", passed: Object.entries(policy.terminalStatusCounts).every(([status, count]) => {
|
|
const actual = runs.filter(run => run.status === status).length, upper = maximum[status as keyof typeof maximum] ?? count;
|
|
return actual >= count! && actual <= Math.max(count!, upper);
|
|
}) && Object.keys(maximum).every(status => status in policy.terminalStatusCounts),
|
|
detail: "The independently observed ledger matches every declared successful/cancelled/failed terminal outcome count (or its declared role-bound range)." });
|
|
} else if (c.runPolicy?.kind === "source-settled-with-active-work") {
|
|
const sourceRuns = runs.filter(run => taskId(run) === source?.id);
|
|
const handbacks = runs.filter(run => taskId(run) !== source?.id && run.agentId === input.leadId && run.contextSnapshot?.wakeReason === "case_handoff");
|
|
const workers = runs.filter(run => taskId(run) !== source?.id && !handbacks.includes(run));
|
|
const cancelled = runs.filter(run => run.status === "cancelled");
|
|
const declared = permitsReassignment(c);
|
|
let expected: ReturnType<NonNullable<ChatCatalogCase["expectedCancelledWorkerRun"]>>;
|
|
try { expected = declared ? c.expectedCancelledWorkerRun!(input.observation) : undefined; } catch { expected = undefined; }
|
|
const actual = expected && workers.find(run => run.id === expected.runId);
|
|
const acknowledgement = actual?.resultJson?.nativeCancellation as Record<string, unknown> | undefined;
|
|
const exact = !!expected && cancelled.length === 1 && cancelled[0]?.id === expected.runId && !!actual
|
|
&& chatCatalogRunStatusAllowed({ ...input, run: actual })
|
|
&& actual.companyId === input.companyId && actual.agentId === expected.workerId && actual.agentId !== input.leadId
|
|
&& taskId(actual) === expected.taskId && expected.taskId !== source?.id && actual.errorCode === "issue_reassigned"
|
|
&& actual.resultJson?.reassignmentStopConfirmed === true
|
|
&& acknowledgement?.schema === "paperclip.native-cancellation.v1" && acknowledgement.runId === actual.id
|
|
&& acknowledgement.issueId === expected.taskId && acknowledgement.companyId === input.companyId
|
|
&& acknowledgement.dispatchState === "acknowledged" && typeof acknowledgement.acknowledgedAt === "string" && Number.isFinite(Date.parse(acknowledgement.acknowledgedAt))
|
|
&& typeof acknowledgement.intentAuditId === "string" && acknowledgement.intentAuditId.length > 0
|
|
&& typeof acknowledgement.acknowledgementAuditId === "string" && acknowledgement.acknowledgementAuditId.length > 0
|
|
&& sourceRuns.some(run => run.id === expected.sourceRunId && run.agentId === input.leadId && run.status === "succeeded");
|
|
checks.push({ id: "catalog-exact-owned-worker-cancellation", passed: cancelled.length === 0 ? expected === undefined : declared && exact,
|
|
detail: "Only the exact independently proved task-reassignment cancellation is accepted; final actor, chronology and saved-state proof remains mandatory in the case callback." });
|
|
checks.push({ id: "catalog-settled-source-separate-work", passed: !!source && source.companyId === input.companyId
|
|
&& source.conversationState === "waiting" && sourceRuns.length > 0 && sourceRuns.every(run => run.agentId === input.leadId && run.status === "succeeded")
|
|
&& workers.every(run => typeof taskId(run) === "string" && run.agentId !== input.leadId)
|
|
&& workers.filter(run => ["queued", "running"].includes(run.status)).length <= c.runPolicy.maximumActiveWorkerRuns
|
|
&& handbacks.length <= (c.runPolicy.maximumLeadCaseHandbackRuns ?? 0) && handbacks.every(run => typeof taskId(run) === "string"),
|
|
detail: "The CEO source is settled; unfinished worker runs are separately task-bound and bounded, and any CEO run outside the source is a declared case handback. The case oracle must additionally bind their exact task and assignee." });
|
|
}
|
|
return { passed: checks.every(check => check.passed), checks };
|
|
}
|
|
|
|
|
|
export type ChatCatalogFinalRunVerifier = (source: ChatIssue | undefined, runs: ChatRun[]) => ChatCatalogGrade;
|
|
|
|
/** Preserve the loaded case's proof callback for a fresh outer ledger read. */
|
|
export function createChatCatalogFinalRunVerifier(input: {
|
|
implementation: Parameters<typeof gradeChatCatalogRuns>[0]["implementation"];
|
|
companyId: string;
|
|
leadId: string;
|
|
observation: unknown;
|
|
}): ChatCatalogFinalRunVerifier {
|
|
assertExpectedWorkerCancellation(input.implementation);
|
|
return (source, runs) => gradeChatCatalogRuns({ ...input, source, runs });
|
|
}
|