mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-10 01:50:13 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Its UI is governed by a design system (`DESIGN.md` + the token layer in `ui/src/index.css`, merged in #9134) whose first principle is "one way to say each thing" — one Card, one Badge, one nav row > - After the token extraction landed, ~35 files still hand-rolled card containers, ~45 files hand-rolled pill spans, the sidebar agents section duplicated the nav-row chrome, and the inbox and tasks lists rendered the same task rows two subtly different ways > - Each divergence is a place where a future design change (radius, hover language, status vocabulary) silently misses surfaces, defeating the "edit tokens + run checks" model the design system exists for > - This pull request converges those surfaces onto the shared primitives, codifies the radius scale as the modern multiplicative shadcn ladder, and unifies the row/hover/tree-guide language across the inbox and tasks lists — every visible delta was human-reviewed screen-by-screen against a live instance across nine feedback rounds > - The benefit is that the app's look is now steerable from single knobs (one `--radius` anchor, one Card, one Badge, one row component), and the visual regression suite covers the result (514 snapshots including a new AgentDetail page story) ## Linked Issues or Issue Description No public GitHub issue exists for this work; describing per the feature template: - **Problem**: after the design-token foundation (#9134), component-level drift remained — hand-rolled cards/pills, duplicated sidebar row chrome, and two different renderings of task rows (inbox vs tasks list) meant design changes had to be applied per-surface and frequently missed spots (e.g. status glyphs rendered 16px in the inbox but 20px in the tasks list because a slot override silently beat the component default). - **Proposed behavior**: all card-shaped containers render via `Card`, all label pills via `Badge`, sidebar rows via `SidebarNavItem`, and both task-list surfaces via one `IssueRow` configuration; the radius scale is a single multiplicative ladder anchored at `--radius: 0.5rem`. - **Alternatives considered**: converting interactive `<button>`/`<Link>` cards to `Card` divs (rejected — breaks semantics; documented inline with `design-allow` comments instead); keeping the legacy additive radius ladder (rejected in favor of the standard shadcn multiplicative mapping). ## What Changed - `Card` adoption across ~35 files (settings pages, auth/board flows, dashboards, list containers, KPI tiles); non-adoptable sites (interactive cards, `<li>` rows, class-string props, chart tooltip) carry documented `design-allow(card-pattern)` comments - `Card` gains an `interactive` prop — one quiet hover affordance for clickable cards (cursor, border darken, shadow lift, focus ring), applied to skills tiles, artifact cards, and the company selector; cards carry no resting shadow - `Badge` adoption for 113 hand-rolled pill spans across ~45 files; `PropertyChip` wraps `Badge` internally; `StatusBadge`, external-object chips, and match chips stay bespoke by documented decision (WCAG-tuned status mechanics) - Radius ladder becomes the multiplicative shadcn mapping (`sm/md/lg/xl/2xl/3xl/4xl = 0.6/0.8/1.0/1.4/1.8/2.2/2.6 × --radius`, anchor `0.5rem`); every card surface unifies on `rounded-lg`; the orphaned 8px literal token is deleted - Sidebar: agent rows render via `SidebarNavItem` (new additive props: `iconNode`, `active`, `trailing`, `liveAccessory`); live dots use `--status-agent-running`; one row rhythm and inset rounded pill highlight; right-aligned trailing badges; every labeled section is collapsible - Inbox + tasks lists unified: md status glyphs, `accent/50` rounded row hovers, vertical tree guides under parent rows (opaque underlay so dark-mode translucent borders don't stack), no horizontal dividers under expanded parents; the swipe-to-archive reveal layer shows only mid-swipe; board toggle uses the `SquareKanban` glyph - Kanban: every column carries a status-hued tint; lanes default expanded (including empty); compact mode collapses empty lanes to labeled rails (fixes a clipped, label-less empty-column state) - Storybook: new AgentDetail page story (realistic fixtures, light+dark) joins the visual suite; suite captures with `reducedMotion: 'reduce'` and the ux-lab reasoning ticker honors `prefers-reduced-motion`; a stale lexical alias in `storybook/main.ts` is fixed (build was broken since the lexical 0.46 bump) - Keyboard navigation, from live review of the unified lists: inbox navigation keys work on every tab (archive keys stay scoped to the archivable tab); keyboard-driven scrolling no longer hands the selection to whatever row lands under the stationary cursor (hover selects only after real pointer movement); the tasks list view gains the same j/k / arrows / Enter selection model as the inbox; and the `g` then `i` go-to-inbox chord works app-wide instead of only on the issue detail page - Token gates restored to 3/3 CLEAN (tokenized a post-#9134 regression in the recovery card); decisions recorded in `doc/design/DECISION-SHEET.md` and `doc/design/COMPONENT-INVENTORY.md` (investigation verdicts: FileTree vs WorkspaceFileBrowser and the four entity pickers stay separate — evidence included) ## Verification - `pnpm check:token-gates` → 3/3 CLEAN - `pnpm typecheck` → green (all packages) - `cd ui && npx vitest run` → 2106/2106 (assertions updated in lockstep where they documented superseded decisions; new tests for the global go-to-inbox chord) - `pnpm --filter @paperclipai/ui build` → exit 0 - `pnpm build-storybook` → succeeds (also fixes the lexical-alias break on master) - Visual regression: 514-snapshot Playwright suite green against the updated baseline (zero diffs from the keyboard-navigation round — those changes are purely behavioral). Note: baselines live outside git per the suite design and the baseline-manifest archive is not yet published, so CI cannot run this suite — it was run locally throughout; every visible delta was reviewed screen-by-screen in a live instance across nine review rounds. Review evidence (before/after triplets) intentionally kept out of the repo for size; available on request. - Manual: exercised dashboard, tasks (list + board), inbox, agents, skills, costs, settings, and artifact surfaces in light and dark themes ## Risks - Wide but shallow visual surface: most changes are class-string substitutions with behavior preserved (props, handlers, roles, test ids). The riskiest areas — dnd-kit card refs (React 19 ref-as-prop), inbox swipe-to-archive, and sidebar overlays — are covered by existing unit tests (all green) and were manually exercised. - Intentional visual deltas (rounded cards, tinted kanban columns, md status glyphs, unified hovers) are design decisions recorded in `doc/design/DECISION-SHEET.md`; each maps to a re-baselined snapshot set locally. - The visual suite cannot yet run in CI (unpublished baseline archive — pre-existing condition from #9134); until that lands, snapshot coverage is local-only. ## Model Used - Claude Fable 5 (`claude-fable-5`, Anthropic) via Claude Code — agentic coding with tool use (file editing, test execution, Playwright screenshot verification); extended thinking enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green (will confirm once CI runs) - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups (pending first review) - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
237 lines
9.0 KiB
TypeScript
237 lines
9.0 KiB
TypeScript
import type { ReactNode } from "react";
|
|
import { ResponsibleUserDenialNotice } from "@/components/ResponsibleUserDenialNotice";
|
|
import { cn } from "@/lib/utils";
|
|
import { Card } from "@/components/ui/card";
|
|
|
|
/**
|
|
* UX lab for PAP-12462 (P7): run "on behalf of {user}" surfacing + responsible-user
|
|
* denial copy. Renders before/after of both surfaces with real design tokens so the
|
|
* states can be captured for UX review. Route: /ux-lab/responsible-user-denial
|
|
*/
|
|
|
|
function LabSection({
|
|
title,
|
|
description,
|
|
children,
|
|
}: {
|
|
title: string;
|
|
description: string;
|
|
children: ReactNode;
|
|
}) {
|
|
return (
|
|
<section className="rounded-2xl border border-border/70 bg-background/85 p-5 shadow-sm">
|
|
<div className="mb-4">
|
|
<h2 className="text-base font-semibold text-foreground">{title}</h2>
|
|
<p className="mt-1 text-sm text-muted-foreground">{description}</p>
|
|
</div>
|
|
<div className="grid gap-4 lg:grid-cols-2">{children}</div>
|
|
</section>
|
|
);
|
|
}
|
|
|
|
function BeforeAfter({ label, children }: { label: string; children: ReactNode }) {
|
|
return (
|
|
<div className="space-y-2">
|
|
<div className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-caps) text-muted-foreground">
|
|
{label}
|
|
</div>
|
|
<Card className="block border-border/60 p-3">{children}</Card>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
/** A faithful copy of a run ledger row header (see IssueRunLedger.tsx). */
|
|
function RunLedgerRow({
|
|
onBehalfOf,
|
|
denial,
|
|
}: {
|
|
onBehalfOf?: string | null;
|
|
denial?: ReactNode;
|
|
}) {
|
|
return (
|
|
<article className="space-y-1.5 rounded-lg border border-border/60 px-3 py-2 text-xs text-muted-foreground">
|
|
<div className="flex flex-wrap items-center gap-1.5">
|
|
<span className="font-medium text-foreground">Run</span>
|
|
<span className="min-w-0 max-w-full truncate font-mono text-foreground">a1b2c3d4</span>
|
|
<span>by CodexCoder</span>
|
|
{onBehalfOf ? (
|
|
<span className="min-w-0 max-w-full truncate text-muted-foreground">
|
|
on behalf of <span className="text-foreground">{onBehalfOf}</span>
|
|
</span>
|
|
) : null}
|
|
<span className="rounded-md border border-border px-1.5 py-0.5 text-(length:--text-micro) capitalize text-muted-foreground">
|
|
{denial ? "Failed" : "Succeeded"}
|
|
</span>
|
|
<span className="ml-auto shrink-0">2m ago</span>
|
|
</div>
|
|
<div className="grid gap-2 text-xs text-muted-foreground sm:grid-cols-3">
|
|
<div className="min-w-0">
|
|
<span className="text-foreground">Elapsed</span> 1m 4s
|
|
</div>
|
|
<div className="min-w-0">
|
|
<span className="text-foreground">Last useful action</span> 2m ago
|
|
</div>
|
|
<div className="min-w-0">
|
|
<span className="text-foreground">Stop</span> {denial ? "Denied" : "Completed"}
|
|
</div>
|
|
</div>
|
|
{denial}
|
|
</article>
|
|
);
|
|
}
|
|
|
|
/** A faithful copy of the run-detail header identity block (see AgentDetail.tsx RunDetail). */
|
|
function RunDetailHeader({ onBehalfOf, denial }: { onBehalfOf?: string | null; denial?: ReactNode }) {
|
|
return (
|
|
<div className="space-y-2">
|
|
<div className="flex items-center gap-2">
|
|
<span className="text-lg font-semibold text-foreground">Run a1b2c3d4</span>
|
|
<span className="rounded-md border border-border px-1.5 py-0.5 text-(length:--text-micro) capitalize text-muted-foreground">
|
|
{denial ? "failed" : "succeeded"}
|
|
</span>
|
|
</div>
|
|
<div className="flex flex-wrap items-center gap-1.5 font-mono text-(length:--text-micro) text-muted-foreground">
|
|
<span className="rounded bg-muted px-1.5 py-0.5 text-(length:--text-nano) font-medium uppercase tracking-wide">
|
|
codex local
|
|
</span>
|
|
<span>anthropic/claude-opus-4-8</span>
|
|
</div>
|
|
{onBehalfOf ? (
|
|
<div className="text-xs text-muted-foreground">
|
|
On behalf of <span className="text-foreground">{onBehalfOf}</span>
|
|
</div>
|
|
) : null}
|
|
{denial}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export function ResponsibleUserDenialUxLab() {
|
|
return (
|
|
<div className="min-h-screen bg-muted/20 p-6">
|
|
<div className="mx-auto max-w-5xl space-y-6">
|
|
<header>
|
|
<div className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-caps) text-muted-foreground">
|
|
PAP-12462 · P7
|
|
</div>
|
|
<h1 className="mt-1 text-xl font-semibold text-foreground">
|
|
Run "on behalf of" surfacing + denial copy
|
|
</h1>
|
|
<p className="mt-1 text-sm text-muted-foreground">
|
|
Before/after of the two run surfaces and the four denial-related states.
|
|
</p>
|
|
</header>
|
|
|
|
<LabSection
|
|
title="1 · Run identity — “on behalf of {user}”"
|
|
description="A run acting for a human now names that user on both the issue run ledger and the run detail header."
|
|
>
|
|
<BeforeAfter label="Before — run ledger">
|
|
<RunLedgerRow />
|
|
</BeforeAfter>
|
|
<BeforeAfter label="After — run ledger">
|
|
<RunLedgerRow onBehalfOf="Ada Lovelace" />
|
|
</BeforeAfter>
|
|
<BeforeAfter label="Before — run detail">
|
|
<RunDetailHeader />
|
|
</BeforeAfter>
|
|
<BeforeAfter label="After — run detail">
|
|
<RunDetailHeader onBehalfOf="Ada Lovelace" />
|
|
</BeforeAfter>
|
|
</LabSection>
|
|
|
|
<LabSection
|
|
title="2 · Denial state — responsible user not authorized"
|
|
description="The agent is allowed, but the user the run acts for is not. Distinct from a plain agent-lacks-permission failure."
|
|
>
|
|
<BeforeAfter label="Before — generic failure text">
|
|
<div className="text-xs">
|
|
<span className="text-red-600 dark:text-red-400">
|
|
Forbidden: action not permitted
|
|
</span>
|
|
<span className="ml-1 text-muted-foreground">(RESPONSIBLE_USER_UNAUTHORIZED)</span>
|
|
</div>
|
|
</BeforeAfter>
|
|
<BeforeAfter label="After — actionable denial copy">
|
|
<ResponsibleUserDenialNotice
|
|
code="RESPONSIBLE_USER_UNAUTHORIZED"
|
|
userName="Ada Lovelace"
|
|
/>
|
|
</BeforeAfter>
|
|
</LabSection>
|
|
|
|
<LabSection
|
|
title="3 · Denial state — agent lacks permission (unchanged)"
|
|
description="A denial that is NOT a responsible-user code keeps the existing generic error copy — no responsible-user notice."
|
|
>
|
|
<BeforeAfter label="Agent-lacks-permission failure">
|
|
<div className="text-xs">
|
|
<span className="text-red-600 dark:text-red-400">
|
|
Forbidden: agent is not permitted to perform this action
|
|
</span>
|
|
<span className="ml-1 text-muted-foreground">(deny_missing_membership)</span>
|
|
</div>
|
|
</BeforeAfter>
|
|
<BeforeAfter label="No responsible-user notice rendered">
|
|
<div className="text-xs text-muted-foreground">
|
|
Responsible-user denial notice intentionally absent for non-responsible-user codes.
|
|
</div>
|
|
</BeforeAfter>
|
|
</LabSection>
|
|
|
|
<LabSection
|
|
title="4 · Denial state — responsible user unavailable"
|
|
description="The user this run acts for was removed or deactivated. Steers the agent to mark work blocked."
|
|
>
|
|
<BeforeAfter label="Before — generic failure text">
|
|
<div className="text-xs">
|
|
<span className="text-red-600 dark:text-red-400">
|
|
Forbidden: responsible user unavailable
|
|
</span>
|
|
<span className="ml-1 text-muted-foreground">(RESPONSIBLE_USER_UNAVAILABLE)</span>
|
|
</div>
|
|
</BeforeAfter>
|
|
<BeforeAfter label="After — actionable denial copy">
|
|
<ResponsibleUserDenialNotice
|
|
code="RESPONSIBLE_USER_UNAVAILABLE"
|
|
userName="Grace Hopper"
|
|
/>
|
|
</BeforeAfter>
|
|
</LabSection>
|
|
|
|
<LabSection
|
|
title="In-context — denial inside a failed run ledger row"
|
|
description="How the notice reads within a run row on the issue timeline."
|
|
>
|
|
<BeforeAfter label="Unauthorized">
|
|
<RunLedgerRow
|
|
onBehalfOf="Ada Lovelace"
|
|
denial={
|
|
<ResponsibleUserDenialNotice
|
|
code="RESPONSIBLE_USER_UNAUTHORIZED"
|
|
userName="Ada Lovelace"
|
|
/>
|
|
}
|
|
/>
|
|
</BeforeAfter>
|
|
<BeforeAfter label="Unavailable">
|
|
<RunLedgerRow
|
|
onBehalfOf="Grace Hopper"
|
|
denial={
|
|
<ResponsibleUserDenialNotice
|
|
code="RESPONSIBLE_USER_UNAVAILABLE"
|
|
userName="Grace Hopper"
|
|
/>
|
|
}
|
|
/>
|
|
</BeforeAfter>
|
|
</LabSection>
|
|
|
|
<p className={cn("text-center text-(length:--text-micro) text-muted-foreground")}>
|
|
Copy is sourced from the shared <code>describeResponsibleUserDenial</code> contract.
|
|
</p>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|