Files
PaperClipAI/packages/google-sheets-mcp-server/src/config.test.ts
T
DottaandPaperclip 7b35de65aa feat(mcp) [split 1/8]: add fixture demo servers (#9556)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - Governed MCP access spans contracts, runtime enforcement, adapters,
UI surfaces, and operator verification
> - The parity reference PR #9534 is too large for effective automated
or human review
> - The feature therefore needs a linear stack whose individual diffs
stay below the 100-file review limit
> - This pull request is split 1/8 and focuses on fixture and demo MCP
servers
> - The benefit is a standalone, testable review boundary while
preserving byte-for-byte parity at the top of the stack

## Linked Issues or Issue Description

- Related parity reference: #9534
- Problem: Developers need deterministic local MCP fixtures and visible
demo servers without pulling in the governed production runtime.
- Proposed solution: Adds the Google Sheets and KV demo MCP packages,
fixture catalog/servers, smoke harness, guide, and the root
smoke/typecheck registration hunks.
- Alternatives considered: keeping #9534 as one 403-file review, or
rewriting the feature to manufacture seams; both were rejected in favor
of path extraction plus compile-driven boundary moves.
- Roadmap alignment: this advances the existing governed MCP/tool-access
work already represented by #9534; it does not introduce a separate
roadmap initiative.
- Stack position: base branch is `master`.
- Merge policy: merge bottom-up, in order, only after the complete
eight-PR stack has been reviewed and the top-of-stack parity gate
remains empty.
- Requested review: QA for fixture and smoke coverage; Greptile on every
PR.

## What Changed

- Adds the Google Sheets and KV demo MCP packages, fixture
catalog/servers, smoke harness, guide, and the root smoke/typecheck
registration hunks.
- Keeps this PR below 100 changed files and independently typecheckable.
- Preserves the final tree from #9534 when combined with the other seven
stack levels.

## Verification

- `pnpm typecheck`
- `pnpm --filter @paperclipai/google-sheets-mcp-server test` — 27 tests
passed
- `pnpm --filter @paperclipai/kv-demo-mcp-server test` — 12 tests passed

## Risks

- The new packages add dependencies that are intentionally not committed
to `pnpm-lock.yaml`, per repository policy.
- Stack risk: merging out of order can expose incomplete layers;
mitigate by following the documented bottom-up merge policy.
- Parity risk: later edits to an intermediate branch can drift from
#9534; mitigate by re-running the empty top-of-stack diff before merge.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context
window; medium reasoning with repository, shell, Git, GitHub CLI, and
code-execution tools enabled.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] Internal references are omitted except the execution-plan link
explicitly required for this coordinated split stack
- [x] My branch name describes the change and contains no internal
Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge


## Stack Coordination

- Internal execution plan:
[PAP-13874](/PAP/issues/PAP-13874#document-plan)
- Parity reference: #9534
- Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563
- Merge bottom-up only after full-stack review and an empty parity diff
at #9563.

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-07-14 12:56:21 -05:00

116 lines
3.9 KiB
TypeScript

import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { describe, expect, it } from "vitest";
import { createGoogleSheetsMcpConfig, readConfigFromEnv, readHttpConfigFromEnv } from "./config.js";
const serviceAccount = {
client_email: "service@example.test",
private_key: "-----BEGIN PRIVATE KEY-----\nfake\n-----END PRIVATE KEY-----",
project_id: "project-1",
};
describe("Google Sheets MCP config", () => {
it("reads inline service-account JSON and de-duplicates allowed spreadsheet IDs", () => {
const config = createGoogleSheetsMcpConfig({
serviceAccountJson: JSON.stringify(serviceAccount),
allowedSpreadsheetIds: "sheet-1,sheet-2\nsheet-1",
});
expect(config.serviceAccount.client_email).toBe("service@example.test");
expect(config.allowedSpreadsheetIds).toEqual(["sheet-1", "sheet-2"]);
expect(config.secretRedactions).toContain(serviceAccount.private_key);
});
it("reads service-account JSON from a path", () => {
const dir = mkdtempSync(join(tmpdir(), "paperclip-sheets-mcp-"));
try {
const file = join(dir, "service-account.json");
writeFileSync(file, JSON.stringify(serviceAccount));
const config = readConfigFromEnv(
{
GOOGLE_SHEETS_SERVICE_ACCOUNT_JSON_PATH: file,
GOOGLE_SHEETS_ALLOWED_SPREADSHEET_IDS: "sheet-1",
} as NodeJS.ProcessEnv,
[],
);
expect(config.serviceAccount.project_id).toBe("project-1");
expect(config.allowedSpreadsheetIds).toEqual(["sheet-1"]);
} finally {
rmSync(dir, { recursive: true, force: true });
}
});
it("requires an allowlist", () => {
expect(() =>
createGoogleSheetsMcpConfig({
serviceAccountJson: JSON.stringify(serviceAccount),
allowedSpreadsheetIds: "",
})
).toThrow("At least one allowed spreadsheet ID is required.");
});
it("reads HTTP host, port, and token while reusing MCP config env", () => {
const config = readHttpConfigFromEnv(
{
GOOGLE_SHEETS_SERVICE_ACCOUNT_JSON: JSON.stringify(serviceAccount),
GOOGLE_SHEETS_ALLOWED_SPREADSHEET_IDS: "sheet-1",
GOOGLE_SHEETS_MCP_PORT: "9911",
GOOGLE_SHEETS_MCP_HOST: "0.0.0.0",
GOOGLE_SHEETS_MCP_TOKEN: " local-token ",
} as NodeJS.ProcessEnv,
[],
);
expect(config.port).toBe(9911);
expect(config.host).toBe("0.0.0.0");
expect(config.token).toBe("local-token");
expect(config.mcpConfig.allowedSpreadsheetIds).toEqual(["sheet-1"]);
});
it("lets PORT override GOOGLE_SHEETS_MCP_PORT for platform hosts", () => {
const config = readHttpConfigFromEnv(
{
GOOGLE_SHEETS_SERVICE_ACCOUNT_JSON: JSON.stringify(serviceAccount),
GOOGLE_SHEETS_ALLOWED_SPREADSHEET_IDS: "sheet-1",
PORT: "8080",
GOOGLE_SHEETS_MCP_PORT: "9911",
} as NodeJS.ProcessEnv,
[],
);
expect(config.port).toBe(8080);
expect(config.host).toBe("127.0.0.1");
expect(config.token).toBeNull();
});
it("requires a token for non-loopback HTTP binds", () => {
expect(() =>
readHttpConfigFromEnv(
{
GOOGLE_SHEETS_SERVICE_ACCOUNT_JSON: JSON.stringify(serviceAccount),
GOOGLE_SHEETS_ALLOWED_SPREADSHEET_IDS: "sheet-1",
GOOGLE_SHEETS_MCP_HOST: "0.0.0.0",
} as NodeJS.ProcessEnv,
[],
)
).toThrow("GOOGLE_SHEETS_MCP_TOKEN is required when GOOGLE_SHEETS_MCP_HOST is not loopback.");
});
it("allows loopback HTTP binds without a token", () => {
const config = readHttpConfigFromEnv(
{
GOOGLE_SHEETS_SERVICE_ACCOUNT_JSON: JSON.stringify(serviceAccount),
GOOGLE_SHEETS_ALLOWED_SPREADSHEET_IDS: "sheet-1",
GOOGLE_SHEETS_MCP_HOST: "::1",
} as NodeJS.ProcessEnv,
[],
);
expect(config.host).toBe("::1");
expect(config.token).toBeNull();
});
});