Files
PaperClipAI/ui/src/pages/apps/AppDetail.tsx
T
TonioandPaperclip 56517dda6c fix(ui): bundle connector, toolbar, empty-state and agent roster fixes (#18716)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Operators use connector setup, collection headers, empty states, and
agent lists to manage that work.
> - Provider redirects replace the setup page, and collection controls
use different sizes.
> - Agent selection inserts a bar above the list. The row link
highlights only part of the row.
> - This pull request keeps sign-in in a separate window and applies the
Tasks control sizes to collection and audit headers.
> - It also reuses artifact artwork for empty collections and gives
agent selection a fixed action card.
> - These changes preserve the operator's place and keep controls and
rows stable.

## Linked Issues or Issue Description

**What happened?**

Connector sign-in replaced the current page. Inline collection controls
had different heights. Projects and Artifacts used small placeholder
empty states. Agent selection moved the list, hover covered only the
identity cell, and chat/status shared that cell without matching
headings.

**Expected behavior**

Provider sign-in opens in a new tab or window. Collection controls match
Tasks. Empty collections use the large artifact graphics. Agent actions
float above the page while rows remain aligned.

**Steps to reproduce**

Start connector sign-in from a page or dialog. Compare collection and
Audit headers. Open an empty Projects or Artifacts collection. Select an
agent, then hover across its row.

Related public work: #13584 covers an earlier connector new-tab
implementation, including same-page fallbacks that this bundle does not
use. #8528 covers Tasks toggle sizing. #17742 covers scoped agent Audit
sections. This bundle does not change server callback or audit
authorization contracts.

## What Changed

- Reserve a separate authorization window during the click. Use
validated sign-in URLs, retain a new-tab fallback, and close blank
windows after failed requests. Store Cloud reauthentication state in the
destination window.
- Use the Tasks 44px control foundation for shared collection headers
and Audit, Costs, Timeline, Secrets, Teams, Gateways, and agent skill
controls.
- Use a large artifact stack with an off-white Paperclip image with a
dark icon for Projects and artifact Tasks empty states. Use one matching
artifact for other types. Set 20px gaps and use the label “Create
project”. Action hover and keyboard focus animate the artwork.
- Portal agent bulk actions to a fixed card 48px above the bottom safe
area. Use quintic entry/exit motion and respect reduced motion. Retain
card contents during exit.
- Give chat and status separate cells, add a Status heading, use the
MessagesSquare chat action with a hover tooltip, and highlight the
entire row.
- Add linked agent chips and a manager picker to the agent profile.
Block self and descendant manager choices. Keep the name crown and
custom title inline during edits.
- Update design guidance, the connection maps, regression tests, and
empty-state Storybook fixtures.

## Verification

- Final commit `a41a6c6494a839deaaec1ef7cc50c90078ab6381`: all 55 checks
passed, three skipped. [Canonical CI
run](https://github.com/paperclipai/paperclip/actions/runs/41999792769)
includes all eight browser shards and all server/runner/workspace
groups. Greptile: 5/5, zero unresolved review findings.
- Workspace typecheck/build passed. Local UI suite passed 11,006 tests
in 880 files, plus 542 CLI tests. Subsequent connector callback changes
passed all 245 AppsConnect tests, UI typecheck, token gates, and
query-error policy checks. Manager cache/error regressions passed four
tests. Map checks passed.
- Local connector browser suite: 20 passed. All six chat integration
shards: 1,931 passed. Workspace B groups passed; database tests passed
313 cases across 72 files with one worker.
- Browser preview verified agent manager changes, overview links, inline
name/title geometry, empty-state colors, row actions and the chat
tooltip. Live provider consent and post-deployment feature verification
remain separate from these fixtures.
- Preserved failures: ten bulk-roster tests initially missed the
portaled action card; their selectors were fixed and all twelve roster
tests passed. A nested fixture selected pnpm 11 and removed local
dependencies; the local shim now pins pnpm 9. Embedded PostgreSQL native
links were restored. A Python 3.9 fixture failure passed all 19 tests
with the current runtime. Concurrent local database startup failures
passed on the one-worker rerun.
- The broad local serialized server run passed 3,791 tests with one
scheduling assertion failure, which passed in isolation. The local
general-server run reproduced a native recovery provider/model fixture
failure and has not completed. These server sources are unchanged by
this bundle; all final canonical CI server shards passed. This is not a
claim that every broad local run passed.
- [Earlier CI
run](https://github.com/paperclipai/paperclip/actions/runs/41995119880)
failed a browser test during cleanup when heartbeat-run cancellation hit
a PostgreSQL lock timeout. All final browser shards passed without
weakening that test.
- Review follow-ups cover Slack popup/fallback recovery, a single
artwork hover transform, shared manager error rendering, detached
standalone OAuth windows, and verified task-bound callbacks in both
hosts.

## Risks

- Browser popup policy and provider callback behavior can affect sign-in
completion. The original setup page stays open; blocked windows have an
explicit recovery path.
- Shared toolbar styles affect several surfaces. Menu content remains in
its existing portals; canonical label tabs and search clear buttons
retain their own geometry.
- No schema, server, API authorization, or migration change.
- Required CI and review are complete. Deployment provenance and hosted
feature verification are checked separately after merge.

## Model Used

OpenAI Codex, GPT-6 family, with reasoning, repository tools, test
execution, and browser inspection. The exact model ID and context-window
size were not exposed in this session.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run relevant tests locally and they pass (broader local
exceptions are recorded above)
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-05 01:23:53 -08:00

989 lines
46 KiB
TypeScript

import { AppNotFound, AppReadError } from "./app-detail/AppReadError";
import { AiConnectionPoolConnector } from "@/components/ai-connections/AiConnectionPoolConnector";
import { aiConnectionRouterPluginKey } from "@paperclipai/shared";
import { ConnectionInstructionsSettings } from "@/features/connections/ConnectionInstructions";
import { HonchoWorkspaceSettings } from "@/features/connections/HonchoWorkspaceSettings";
import { BrowserUseSettingsPanel } from "./app-detail/BrowserUseSettingsPanel";
import { isRetiredComposioConnection, RETIRED_COMPOSIO_MESSAGE, isRemoteMcpConnectorId, isRemoteMcpConnectorMethod } from "@paperclipai/shared";
import { RemoteMcpManagement } from "@/features/connections/remote-mcp/RemoteMcpManagement";
import { remoteMcpProviders } from "@/features/connections/remote-mcp/providers";
import { ManagedAiConnectionDetails } from "@/components/ai-connections/ManagedAiConnectionDetails";
import { useEffect, useMemo, useRef, useState, type ReactNode } from "react";
import { EmailConnectionAccess } from "@/components/EmailConnectionAccess";
import { EmailConnectionInboxes } from "./chat/EmailEndpointSetup";
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
import { Check, Loader2, Pencil } from "lucide-react";
import type {
ToolConnection,
ToolPolicy,
ToolProfileConfiguration,
} from "@paperclipai/shared";
import {
connectionDisplaySecondaryHint,
humanizeConnectionDisplayName,
aiSubscriptionNeedsIsolatedLogin,
isToolConnectionAttentionHealth as isAttentionHealthStatus,
} from "@paperclipai/shared";
import { Navigate, useParams, useNavigate, useSearchParams } from "@/lib/router";
import { useCompany } from "@/context/CompanyContext";
import { useBreadcrumbs } from "@/context/BreadcrumbContext";
import { useToast } from "@/context/ToastContext";
import { queryKeys } from "@/lib/queryKeys";
import { retryTransientOnly } from "@/lib/query-client";
import { consumeSkillSourceReturn } from "@/lib/skill-source-connect-return";
import { toolsApi } from "@/api/tools";
import { agentsApi } from "@/api/agents";
import { accessApi } from "@/api/access";
import { buildCompanyUserProfileMap } from "@/lib/company-members";
import { installStateFrom, type InstallState } from "@/lib/tool-installs";
import { useAuthorizationWindow } from "@/hooks/useAuthorizationWindow";
import { QueryErrorState, useQueryView } from "@/components/QueryView";
import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
import { Skeleton } from "@/components/ui/skeleton";
import { cn } from "@/lib/utils";
import { AppLogo } from "./AppLogo";
import { UnverifiedServerBadge } from "./UnverifiedServerBadge";
import {
appApplicationSourceSlug,
appConnectionSourceSlug,
appDefinitionDarkLogoUrl,
appDefinitionLogoUrl,
appDefinitionName,
appDefinitionSlug,
galleryEntryFor,
type AppGalleryDisplayEntry,
} from "./app-definition-display";
import { appTabHref, appTabLabel, isAppTabKey, type AppTabKey } from "./app-tabs";
import { ConnectionProvenanceChip } from "./ConnectionProvenanceChip";
import { IdentitiesSection } from "./app-detail/IdentitiesSection";
import { PermissionsPanel } from "./app-detail/PermissionsPanel";
import { AgentConnectionAccess } from "./app-detail/AgentConnectionAccess";
import { ConnectedAggregatorApps } from "./app-detail/ConnectedAggregatorApps";
import { isAppAggregator } from "@paperclipai/shared/aggregator-apps";
import { actionPermissionMutation } from "./app-detail/action-permissions";
import { RailwayAccessPanel } from "./app-detail/RailwayAccessPanel";
import { ReviewPanel } from "./app-detail/ReviewPanel";
import { AccessRetryBanner } from "./app-detail/AccessRetryBanner";
import {
ReconnectCard,
DangerZone,
connectionAddress,
connectionTransportLabel,
} from "./app-detail/AdvancedPanel";
import type { AccessDraft } from "./app-detail/types";
import {
connectionDisplayNameForOwner,
connectionOwnerProfile,
} from "./connection-owner";
import { describeError } from "@/api/errors";
export { connectionAddress, connectionTransportLabel };
export function AppDetail(props: { renderActions?: (connection: ToolConnection) => ReactNode; renderAgentSettings?: (connection: ToolConnection) => ReactNode; renderConnectionSettings?: (connection: ToolConnection) => ReactNode; onReconnect?: (connection: ToolConnection) => void } = {}) {
const { connectionId = "" } = useParams<{ connectionId: string }>();
const connection = useQuery({ queryKey: queryKeys.tools.connection(connectionId), queryFn: () => toolsApi.getConnection(connectionId), enabled: !!connectionId });
const view = useQueryView(connection);
if (connection.isPending || view.kind === "reconnecting") return <p role="status">Loading connection…</p>;
if (view.kind === "error" && view.errorKind === "not_found") return <AppNotFound />;
if (view.kind === "error") {
return <QueryErrorState size="page" error={connection.error} action="load the connection" onRetry={view.retry} retrying={view.isFetching} />;
}
const pluginKey = connection.data && aiConnectionRouterPluginKey(connection.data);
// Keyed so page state, such as a failed refresh's recovery link, never carries over to another connection.
return pluginKey ? <AiConnectionPoolConnector pluginKey={pluginKey} connection={connection.data} /> : <StandardAppDetail key={connectionId} {...props} />;
}
function StandardAppDetail({ renderActions, renderAgentSettings, renderConnectionSettings, onReconnect }: {
renderActions?: (connection: ToolConnection) => ReactNode;
/** Optional agent settings within Permissions, following the access controls. */
renderAgentSettings?: (connection: ToolConnection) => ReactNode;
/** Provider prerequisites shown before identity and agent access. */
renderConnectionSettings?: (connection: ToolConnection) => ReactNode;
onReconnect?: (connection: ToolConnection) => void;
} = {}) {
const { connectionId = "", tab } = useParams<{ connectionId: string; tab?: string }>();
const navigate = useNavigate();
const [searchParams] = useSearchParams();
const queryClient = useQueryClient();
const { pushToast } = useToast();
const { selectedCompanyId } = useCompany();
const { setBreadcrumbs } = useBreadcrumbs();
const activeTab: AppTabKey | null = isAppTabKey(tab) ? tab : null;
const needsCatalog = activeTab === "review" || activeTab === "permissions";
const connectionQuery = useQuery({
queryKey: queryKeys.tools.connection(connectionId),
queryFn: () => toolsApi.getConnection(connectionId),
enabled: !!connectionId && !!activeTab,
});
const applicationsQuery = useQuery({
queryKey: queryKeys.tools.applications(selectedCompanyId ?? "__none__"),
queryFn: () => toolsApi.listApplications(selectedCompanyId!),
enabled: !!selectedCompanyId && !!activeTab,
});
const installsQuery = useQuery({
queryKey: queryKeys.tools.connectionInstalls(connectionId),
queryFn: () => toolsApi.getConnectionInstalls(connectionId),
enabled: !!connectionId && activeTab === "permissions",
});
const galleryQuery = useQuery({
queryKey: queryKeys.apps.gallery(selectedCompanyId ?? "__none__"),
queryFn: () => toolsApi.listGallery(selectedCompanyId!),
enabled: !!selectedCompanyId && !!activeTab,
});
const catalogQuery = useQuery({
queryKey: queryKeys.tools.catalog(connectionId),
queryFn: () => toolsApi.listCatalog(connectionId),
enabled: !!connectionId && needsCatalog,
});
const profilesQuery = useQuery({
queryKey: queryKeys.tools.connectionProfileConfiguration(selectedCompanyId ?? "__none__", connectionId),
queryFn: () => toolsApi.listConnectionProfileConfiguration(connectionId),
enabled: !!selectedCompanyId && !!connectionId && (activeTab === "review" || activeTab === "permissions"),
});
const policiesQuery = useQuery({
queryKey: queryKeys.tools.policies(selectedCompanyId ?? "__none__"),
queryFn: () => toolsApi.listPolicies(selectedCompanyId!),
enabled: !!selectedCompanyId && (activeTab === "review" || activeTab === "permissions"),
});
const agentsQuery = useQuery({
queryKey: queryKeys.agents.list(selectedCompanyId ?? "__none__"),
queryFn: () => agentsApi.list(selectedCompanyId!),
enabled: !!selectedCompanyId && activeTab === "permissions",
});
const userDirectoryQuery = useQuery({
queryKey: queryKeys.access.companyUserDirectory(selectedCompanyId ?? "__none__"),
queryFn: () => accessApi.listUserDirectory(selectedCompanyId!),
enabled: !!selectedCompanyId && !!activeTab,
});
// Identity grants drive reconnect authorization on every tab as well as the
// Permissions controls. A personal reconnect belongs to one fixed user, so
// the banner must not offer that action to anyone else.
const grantsQuery = useQuery({
queryKey: queryKeys.tools.connectionGrants(connectionId),
queryFn: ({ signal }) => toolsApi.listConnectionGrants(connectionId, { signal }),
retry: retryTransientOnly(1),
enabled: !!connectionId && !!activeTab,
});
const connectionView = useQueryView(connectionQuery);
const installsView = useQueryView(installsQuery);
const catalogView = useQueryView(catalogQuery);
const profilesView = useQueryView(profilesQuery);
const policiesView = useQueryView(policiesQuery);
const agentsView = useQueryView(agentsQuery);
const grantsView = useQueryView(grantsQuery);
const connection = connectionQuery.data;
const application = connection
? (applicationsQuery.data?.applications ?? []).find((candidate) => candidate.id === connection.applicationId)
: undefined;
const grantRows = grantsQuery.data?.grants ?? [];
const retainedPersonalGrant = connection?.credentialPolicy === "per_user"
? grantRows.find((grant) => (
grant.kind === "user" && grant.subjectUserId === connection.createdByUserId
))
?? grantRows.find((grant) => grant.kind === "user" && grant.status === "active")
?? grantRows.find((grant) => grant.kind === "user")
?? null
: null;
const currentUserPersonalGrant = grantRows.find((grant) => (
grant.kind === "user" && grant.subjectUserId === grantsQuery.data?.currentUserId
)) ?? null;
const retainedAgentGrant = connection?.credentialPolicy === "per_agent"
? grantRows.find((grant) => grant.kind === "agent" && grant.status === "active")
?? grantRows.find((grant) => grant.kind === "agent")
?? null
: null;
const retainedOrganizationGrant = grantRows.find((grant) => (
grant.kind === "organization" && grant.isDefault
)) ?? grantRows.find((grant) => grant.kind === "organization") ?? null;
const managedIdentityGrant = connection?.credentialPolicy === "per_user"
? currentUserPersonalGrant ?? retainedPersonalGrant
: connection?.credentialPolicy === "per_agent"
? retainedAgentGrant
: connection?.credentialPolicy === "per_user_with_fallback"
? currentUserPersonalGrant ?? retainedOrganizationGrant
: retainedOrganizationGrant;
const managedPersonalUserId = managedIdentityGrant?.kind === "user"
? managedIdentityGrant.subjectUserId ?? connection?.createdByUserId ?? null
: null;
const canReconnect = managedIdentityGrant?.kind === "user"
? Boolean(
managedPersonalUserId
&& managedPersonalUserId === grantsQuery.data?.currentUserId
&& grantsQuery.data?.capabilities.canConnectAsCurrentUser,
)
: grantsQuery.data?.capabilities.canConfigure === true;
const grantsPending = grantsQuery.isLoading || grantsView.kind === "reconnecting";
const reconnectUnavailableMessage = grantsPending
? "Checking who can reconnect this identity…"
: grantsView.kind === "error"
? "We couldn't verify who can reconnect this identity. Reload the page to try again."
: managedIdentityGrant?.kind === "user"
&& managedPersonalUserId !== grantsQuery.data?.currentUserId
? "The person this connection belongs to must reconnect it."
: "You don't have permission to reconnect this identity.";
const logoEntry = useMemo(
() => galleryEntryFor((galleryQuery.data?.apps ?? []) as AppGalleryDisplayEntry[], connection, application),
[galleryQuery.data, connection, application],
);
const brandKey = appApplicationSourceSlug(application)
?? appConnectionSourceSlug(connection)
?? (logoEntry ? appDefinitionSlug(logoEntry) : null);
const userProfileById = useMemo(
() => buildCompanyUserProfileMap(userDirectoryQuery.data?.users),
[userDirectoryQuery.data],
);
const owner = connection ? connectionOwnerProfile(connection, userProfileById) : null;
const baseAppName = connection
? logoEntry ? appDefinitionName(logoEntry) : humanizeConnectionDisplayName(connection)
: "App";
const appName = connection
? connectionDisplayNameForOwner(connection, baseAppName, owner)
: "App";
const successNoticeShownFor = useRef<string | null>(null);
useEffect(() => {
if (
activeTab !== "permissions"
|| searchParams.get("success") !== "1"
|| !connection
|| successNoticeShownFor.current === connection.id
) return;
successNoticeShownFor.current = connection.id;
const skillSourcePath = selectedCompanyId === connection.companyId
&& connection.status === "active"
&& appConnectionSourceSlug(connection) === "github"
? consumeSkillSourceReturn(connection.companyId)
: null;
pushToast({
title: `${appName} connected`,
body: skillSourcePath ? "Choose a repository to import your skills." : "The connection is ready. Review permissions or test an action below.",
tone: "success",
});
navigate(skillSourcePath ?? appTabHref(connection.id, "permissions"), { replace: true });
}, [activeTab, appName, connection, navigate, pushToast, searchParams, selectedCompanyId]);
useEffect(() => {
if (!activeTab) return;
setBreadcrumbs([
{ label: "Connectors", href: "/apps" },
{ label: appName, href: appTabHref(connectionId, "permissions") },
{ label: appTabLabel(activeTab) },
]);
return () => setBreadcrumbs([]);
}, [setBreadcrumbs, appName, connectionId, activeTab]);
const catalog = catalogQuery.data?.catalog ?? [];
const profile = useMemo(
() => (profilesQuery.data?.profiles ?? []).find((p) => p.profileKey === `app:${connectionId}`),
[profilesQuery.data, connectionId],
);
const enabledIds = useMemo(() => enabledCatalogIds(profile), [profile]);
const askFirstIds = useMemo(
() => askFirstCatalogIds(policiesQuery.data?.policies ?? [], connectionId),
[policiesQuery.data, connectionId],
);
const install = useMemo(
() => installStateFrom(installsQuery.data?.installs ?? connection?.installs),
[connection?.installs, installsQuery.data?.installs],
);
const access = useMemo(() => accessFrom(connection?.connectionPurpose === "ai" ? undefined : profile, install), [connection?.connectionPurpose, profile, install]);
const managesRemoteMcpAccess = isRemoteMcpConnectorMethod(connection?.config?.sourceTemplateKey, connection?.config?.connectionMethodKey);
const agents = agentsQuery.data ?? [];
const disconnectRemote = useMutation({
mutationFn: () => toolsApi.archiveConnection(connectionId),
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connections(selectedCompanyId!) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connection(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.applications(selectedCompanyId!) });
queryClient.invalidateQueries({ queryKey: queryKeys.apps.attention(selectedCompanyId!) });
navigate("/apps");
},
onError: (error) => pushToast({ title: "Couldn't disconnect", body: describeError(error).body, tone: "error" }),
});
const [pending, setPending] = useState(false);
const persist = useMutation({
mutationFn: async (next: {
enabled: Set<string>;
askFirst: Set<string>;
access: AccessDraft;
reviewed?: Set<string>;
}) => {
return connection?.connectionPurpose === "ai"
? toolsApi.putConnectionInstalls(connectionId, next.access.mode === "all" ? [{ targetType: "company", targetId: selectedCompanyId! }] : [...next.access.agentIds].map(targetId => ({ targetType: "agent" as const, targetId })))
: toolsApi.finishApp(selectedCompanyId!, connectionId, {
enabledCatalogEntryIds: [...next.enabled],
askFirstCatalogEntryIds: [...next.askFirst].filter((id) => next.enabled.has(id)),
...(next.reviewed ? { reviewedCatalogEntryIds: [...next.reviewed] } : {}),
access: next.access.mode === "all" ? "all_agents" : { agentIds: [...next.access.agentIds] },
});
},
onMutate: () => setPending(true),
onSuccess: () => {
void installsQuery.refetch();
queryClient.invalidateQueries({ queryKey: queryKeys.tools.testAgentAccessesForConnection(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connection(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.catalog(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.profiles(selectedCompanyId!) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.policies(selectedCompanyId!) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connections(selectedCompanyId!) });
queryClient.invalidateQueries({ queryKey: queryKeys.apps.attention(selectedCompanyId!) });
},
onError: (error) =>
pushToast({
title: "Couldn't save that",
body: describeError(error).body,
tone: "error",
}),
onSettled: () => setPending(false),
});
const [renaming, setRenaming] = useState(false);
const [nameDraft, setNameDraft] = useState("");
const rename = useMutation({
mutationFn: (name: string) => toolsApi.updateConnection(connectionId, { name }),
onSuccess: () => {
setRenaming(false);
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connection(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connections(selectedCompanyId!) });
queryClient.invalidateQueries({ queryKey: queryKeys.apps.attention(selectedCompanyId!) });
},
onError: (error) =>
pushToast({
title: "Couldn't rename the app",
body: describeError(error).body,
tone: "error",
}),
});
const authorization = useAuthorizationWindow();
const startOAuth = useMutation({
mutationFn: (input?: { asAgentId?: string }) => toolsApi.startOAuth(connectionId, input),
onSuccess: async (start) => {
try {
await authorization.open(start);
} catch (error) {
pushToast({
title: "Couldn't start sign-in",
body: describeError(error).body,
tone: "error",
});
}
},
onError: (error) => {
authorization.cancel();
pushToast({
title: "Couldn't start sign-in",
body: describeError(error).body,
tone: "error",
});
},
});
const invalidateGrants = () => {
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connectionGrants(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connection(connectionId) });
};
/**
* "Connect as me" and "Reconnect" for the signed-in user's own identity. The
* subject is always the caller — the server refuses any other subject — so
* there is no path here to start consent on a coworker's behalf.
*/
const startPersonalAuth = useMutation({
mutationFn: () => {
const subjectUserId = grantsQuery.data?.currentUserId;
if (!subjectUserId) throw new Error("Sign in again to connect your own account.");
return toolsApi.startPersonalAuthorization(selectedCompanyId!, connectionId, {
subjectUserId,
returnTo: appTabHref(connectionId, "permissions"),
});
},
onSuccess: async ({ url, handoff }) => {
try {
await authorization.open({ authorizationUrl: url, handoff });
} catch (error) {
pushToast({
title: "Couldn't start sign-in",
body: describeError(error).body,
tone: "error",
});
}
},
onError: (error) => {
authorization.cancel();
pushToast({
title: "Couldn't start sign-in",
body: describeError(error).body,
tone: "error",
});
},
});
// A denied or conflicting audience save keeps the dialog open with the
// selection intact, so the error is surfaced inline rather than as a toast.
const [audienceError, setAudienceError] = useState<string | null>(null);
const [audienceOpenGrantId, setAudienceOpenGrantId] = useState<string | null>(null);
const replaceAudience = useMutation({
mutationFn: ({ grantId, memberUserIds }: { grantId: string; memberUserIds: string[] }) =>
toolsApi.replaceConnectionGrantMembers(connectionId, grantId, memberUserIds),
onMutate: () => setAudienceError(null),
onSuccess: (grant) => {
invalidateGrants();
setAudienceOpenGrantId(null);
pushToast({
title: "Audience saved",
body: (grant.members?.length ?? 0) === 0
? "Every organization member can use this identity."
: `${grant.members?.length} ${grant.members?.length === 1 ? "member" : "members"} can use this identity.`,
tone: "success",
});
},
onError: (error) =>
setAudienceError(describeError(error).body),
});
const refreshTools = useMutation({
mutationFn: () => toolsApi.refreshCatalog(connectionId),
onSuccess: (result) => {
// Discovery extends the app profile for new actions as well as the catalog.
queryClient.invalidateQueries({ queryKey: queryKeys.tools.profiles(selectedCompanyId!) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.policies(selectedCompanyId!) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.testAgentAccessesForConnection(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connection(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.catalog(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connections(selectedCompanyId!) });
queryClient.invalidateQueries({ queryKey: queryKeys.apps.attention(selectedCompanyId!) });
pushToast({
title: `Found ${result.discoveredCount} ${result.discoveredCount === 1 ? "action" : "actions"}`,
body: result.quarantinedCount > 0
? `${result.quarantinedCount} new ${result.quarantinedCount === 1 ? "action needs" : "actions need"} your OK.`
: undefined,
tone: "success",
});
},
onError: (error) =>
pushToast({
title: "Couldn't refresh actions",
body: describeError(error).body,
tone: "error",
}),
});
const refreshGitHubAccess = useMutation({
mutationFn: () => toolsApi.checkConnectionHealth(connectionId),
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connection(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connectionGrants(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.apps.attention(selectedCompanyId!) });
pushToast({
title: "GitHub access refreshed",
body: "Account, installation, and repository access are current.",
tone: "success",
});
},
onError: (error) => {
// The failed check is saved on the connection; refetch so the banner
// shows it next to any GitHub recovery link.
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connection(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.apps.attention(selectedCompanyId!) });
pushToast({
title: "Couldn't refresh GitHub access",
body: describeError(error).body,
tone: "error",
});
},
});
const apply = (mutate: {
enabled?: Set<string>;
askFirst?: Set<string>;
access?: AccessDraft;
reviewed?: Set<string>;
}) =>
persist.mutate({
enabled: mutate.enabled ?? new Set(enabledIds),
askFirst: mutate.askFirst ?? new Set(askFirstIds),
access: mutate.access ?? access,
reviewed: mutate.reviewed,
});
const reviewQuarantined = (allowedIds: string[]) => {
const quarantinedIds = new Set(quarantined.map((entry) => entry.id));
const nextEnabled = new Set([...enabledIds].filter((id) => !quarantinedIds.has(id)));
for (const id of allowedIds) nextEnabled.add(id);
apply({ enabled: nextEnabled, reviewed: quarantinedIds });
};
// Keep old bookmarks and OAuth return URLs working after Setup and Test were
// consolidated into Permissions, and Activity moved to the company feed.
if (connectionId && (tab === "setup" || tab === "test")) {
const query = searchParams.toString();
return <Navigate replace to={`${appTabHref(connectionId, "permissions")}${query ? `?${query}` : ""}`} />;
}
if (tab === "activity") {
return <Navigate replace to="/activity?action=tool_" />;
}
if (!connectionId || !activeTab) {
return <Navigate replace to={connectionId ? appTabHref(connectionId, "permissions") : "/apps"} />;
}
if (!selectedCompanyId) {
return <div className="p-6 text-sm text-muted-foreground">Select an organization to manage apps.</div>;
}
if (connectionQuery.isLoading || connectionView.kind === "reconnecting") {
return (
<div className="max-w-3xl space-y-4">
<Skeleton className="h-10 w-56" />
<Skeleton className="h-48 w-full" />
<Skeleton className="h-40 w-full" />
</div>
);
}
if (connectionView.kind === "error" && connectionView.errorKind === "not_found") return <AppNotFound />;
if (connectionView.kind === "error") {
return <AppReadError size="page" action="load the connection" failure={connectionView} />;
}
if (!connection) return <AppNotFound />;
if (isRetiredComposioConnection(connection)) {
return <div className="max-w-4xl space-y-6 pb-12">
<h1 className="text-xl font-semibold">{appName}</h1>
<section role="status" className="space-y-3 rounded-lg border border-border bg-muted p-4">
<h2 className="text-sm font-semibold">Connection retired</h2>
<p className="text-sm text-muted-foreground">{RETIRED_COMPOSIO_MESSAGE}</p>
<p className="text-sm text-muted-foreground">Remove each obsolete connection separately. Removing this one does not remove other connections.</p>
<Button variant="outline" onClick={() => navigate("/apps/connect?source=composio")}>Add Composio MCP connection</Button>
</section>
{grantsQuery.data?.capabilities.canConfigure === true && <DangerZone
appName={appName}
removing={disconnectRemote.isPending}
onRemove={() => disconnectRemote.mutate()}
/>}
</div>;
}
const aiGrantRevoked = connection.connectionPurpose === "ai"
&& grantRows.length > 0 && grantRows.every((grant) => grant.status === "revoked");
const status: StatusInfo = aiGrantRevoked ? { label: "Revoked", tone: "attention" } : statusFor(connection);
const needsReconnect = connection.requiresReauthorization
?? (status.tone === "attention" && connection.healthStatus !== "unknown");
const quarantined = catalog.filter((e) => e.status === "quarantined");
const active = catalog.filter((e) => e.status === "active");
const readOnly = active.filter((e) => e.isReadOnly);
const canChange = active.filter((e) => !e.isReadOnly);
const actionsContent = renderActions?.(connection) ?? (connection.connectionPurpose === "ai" ? <ManagedAiConnectionDetails connection={connection} /> : undefined);
const actionCount = actionsContent !== undefined ? null : catalogQuery.data ? active.length : null;
const reviewViews = [catalogView, profilesView, policiesView];
const permissionsViews = [...reviewViews, installsView, agentsView];
const reviewLoading = catalogQuery.isLoading || profilesQuery.isLoading || policiesQuery.isLoading
|| reviewViews.some((view) => view.kind === "reconnecting");
const permissionsLoading = reviewLoading || installsQuery.isLoading || agentsQuery.isLoading
|| permissionsViews.some((view) => view.kind === "reconnecting");
// Only a real failure replaces the panel; a transient refetch failure keeps the loaded tools.
const reviewFailure = reviewViews.find((view) => view.kind === "error");
const permissionsFailure = permissionsViews.find((view) => view.kind === "error");
return (
<div className="max-w-4xl space-y-10 pb-12">
{authorization.fallback}
<AppDetailHeader
appName={appName}
connection={connection}
logoEntry={logoEntry}
brandKey={brandKey}
allowRemoteLogo={!applicationsQuery.isPending}
status={status}
actionCount={actionCount}
renaming={renaming}
nameDraft={nameDraft}
renamePending={rename.isPending}
onNameDraftChange={setNameDraft}
onRenameStart={() => {
setNameDraft(appName);
setRenaming(true);
}}
onRenameCancel={() => setRenaming(false)}
onRenameSubmit={(next) => {
if (next && next !== appName) rename.mutate(next);
else setRenaming(false);
}}
/>
{status.tone === "attention" && connection.requiresReauthorization === false && (
<AccessRetryBanner
message={connection.healthMessage}
error={refreshGitHubAccess.error}
pending={refreshGitHubAccess.isPending}
onRetry={() => refreshGitHubAccess.mutate()}
/>
)}
{needsReconnect && (
<ReconnectCard
connection={connection}
galleryEntry={logoEntry}
canReconnect={canReconnect}
reconnectUnavailableMessage={reconnectUnavailableMessage}
onReconnect={onReconnect ? () => onReconnect(connection) : (connection.connectionPurpose === "ai" || isRemoteMcpConnectorMethod(connection.config?.sourceTemplateKey, connection.config?.connectionMethodKey)) ? () => navigate(`/apps/connect?source=${connection.config?.sourceTemplateKey}&reconnect=${connection.id}`) : undefined}
onReconnected={() => {
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connection(connectionId) });
queryClient.invalidateQueries({ queryKey: queryKeys.tools.connections(selectedCompanyId) });
queryClient.invalidateQueries({ queryKey: queryKeys.apps.attention(selectedCompanyId) });
}}
/>
)}
{activeTab === "review" && (
reviewFailure
? <AppReadError failure={reviewFailure} onRetry={() => {
void catalogQuery.refetch();
void profilesQuery.refetch();
void policiesQuery.refetch();
}} />
: reviewLoading
? <ToolsLoading />
: <ReviewPanel
connectionId={connectionId}
quarantined={quarantined}
pending={pending}
onReviewQuarantined={reviewQuarantined}
/>
)}
{activeTab === "permissions" && (
permissionsFailure
? <AppReadError failure={permissionsFailure} onRetry={() => {
void catalogQuery.refetch();
void profilesQuery.refetch();
void policiesQuery.refetch();
void installsQuery.refetch();
void agentsQuery.refetch();
}} />
: permissionsLoading
? <ToolsLoading />
: <div className="space-y-10">
{isAppAggregator(brandKey) && grantsQuery.data?.capabilities.canConfigure === true
? <ConnectedAggregatorApps key={connection.id} connection={connection} /> : null}
{connection.config?.sourceTemplateKey === "honcho" && <HonchoWorkspaceSettings key={connection.id} connection={connection} canConfigure={grantsQuery.data?.capabilities?.canConfigure ?? false} />}
{renderConnectionSettings?.(connection)}
{connection.config?.sourceTemplateKey === "browser-use-cloud" && <BrowserUseSettingsPanel connection={connection} grants={grantsQuery.data} />}
{connection.config?.sourceTemplateKey === "railway" && <RailwayAccessPanel connection={connection} grants={grantsQuery.data} />}
{connection.config?.provider === "agentmail" && <EmailConnectionInboxes companyId={connection.companyId} connectionId={connection.id} canConfigure={grantsQuery.data?.capabilities?.canConfigure ?? false} />}
{connection.config?.provider === "agentmail" ? <EmailConnectionAccess companyId={connection.companyId} connectionId={connection.id} agents={agents} /> : <>
<IdentitiesSection
appName={appName}
credentialPolicy={connection.credentialPolicy}
ownerUserId={connection.createdByUserId}
connectedUser={owner}
dedicatedAgent={managedIdentityGrant?.kind === "agent"
? agents.find((agent) => agent.id === managedIdentityGrant.subjectAgentId) ?? null
: null}
grantsQuery={grantsQuery.data}
loading={grantsPending}
error={grantsView.kind === "error"}
connectPending={startPersonalAuth.isPending || startOAuth.isPending}
audiencePending={replaceAudience.isPending}
audienceError={audienceError}
audienceGrantId={audienceOpenGrantId}
onOpenAudience={(grantId) => {
setAudienceError(null);
setAudienceOpenGrantId(grantId);
}}
onCloseAudience={() => {
setAudienceOpenGrantId(null);
setAudienceError(null);
}}
onConnectAsMe={() => { if (onReconnect) onReconnect(connection); else { authorization.reserve(); startPersonalAuth.mutate(); } }}
onConnectOrganization={() => { if (onReconnect) onReconnect(connection); else { authorization.reserve(); startOAuth.mutate(); } }}
onConnectAgent={(agentId) => { authorization.reserve(); startOAuth.mutate({ asAgentId: agentId }); }}
onRefreshAccess={() => refreshGitHubAccess.mutate()}
refreshAccessPending={refreshGitHubAccess.isPending}
onReplaceAudience={(grant, memberUserIds) =>
replaceAudience.mutate({ grantId: grant.id, memberUserIds })}
/>
{connection.config?.sourceTemplateKey === "composio" ? <p className="text-sm text-muted-foreground">
These permissions apply to all apps available through this Composio connection. Manage app accounts and sign-in in Composio.
</p> : null}
{connection.config?.sourceTemplateKey !== "composio" && isRemoteMcpConnectorMethod(connection.config?.sourceTemplateKey, connection.config?.connectionMethodKey) && <p className="text-sm text-muted-foreground">Paperclip controls access to the tools listed here. App and action permissions inside these tools are managed in {baseAppName}.</p>}
<PermissionsPanel
afterAgentAccess={<>{logoEntry?.agentInstructions && <ConnectionInstructionsSettings key={connection.id} connection={connection} provider={logoEntry.name} template={logoEntry.agentInstructions} canConfigure={grantsQuery.data?.capabilities?.canConfigure ?? false} />}{renderAgentSettings?.(connection)}</>}
actions={actionsContent}
connectionId={connectionId}
capabilities={grantsQuery.data?.capabilities}
appName={appName}
agents={agents}
access={access}
install={connection.connectionPurpose === "ai" || managesRemoteMcpAccess ? installStateFrom([]) : install}
readOnly={readOnly}
canChange={canChange}
quarantined={quarantined}
enabledIds={enabledIds}
askFirstIds={askFirstIds}
pending={pending}
refreshPending={refreshTools.isPending}
permissionChangeWarning={
connection.credentialPolicy === "per_agent" && managedIdentityGrant?.providerTenant?.github
? "Shell Git and gh use this account for the run and are not constrained by per-tool Ask-first controls."
: undefined
}
onSaveAccess={(next) => apply({ access: connection.connectionPurpose === "ai" || managesRemoteMcpAccess ? next : accessIncludingInstalls(next, install) })}
onRefreshActions={() => refreshTools.mutate()}
onSetActionPermission={(ids, next) => apply(actionPermissionMutation(ids, next, enabledIds, askFirstIds))}
onReviewQuarantined={reviewQuarantined}
/>
<AgentConnectionAccess
connectionId={connectionId}
profiles={profilesQuery.data?.profiles ?? []}
policies={policiesQuery.data?.policies ?? []}
catalog={catalog}
agents={agents}
canManage={grantsQuery.data?.capabilities.canConfigure === true}
onRemove={async (profileId) => {
await toolsApi.deleteProfile(profileId);
await profilesQuery.refetch();
queryClient.invalidateQueries({ queryKey: queryKeys.tools.testAgentAccessesForConnection(connectionId) });
}}
/>
{managesRemoteMcpAccess && isRemoteMcpConnectorId(connection.config?.sourceTemplateKey) && <RemoteMcpManagement
providerName={baseAppName} canReconnect={canReconnect} canDisconnect={grantsQuery.data?.capabilities.canConfigure === true}
busy={disconnectRemote.isPending}
onReconnect={() => navigate(`/apps/connect?source=${connection.config?.sourceTemplateKey}&reconnect=${connection.id}`)}
onManage={() => window.open(remoteMcpProviders[connection.config?.sourceTemplateKey as keyof typeof remoteMcpProviders].dashboardUrl, "_blank", "noopener,noreferrer")}
onDisconnect={() => disconnectRemote.mutateAsync()}
/>}
</>}
</div>
)}
</div>
);
}
export function AppDetailHeader({
appName,
connection,
logoEntry,
brandKey,
allowRemoteLogo,
status,
actionCount,
canRename = true,
renaming,
nameDraft,
renamePending,
onNameDraftChange,
onRenameStart,
onRenameCancel,
onRenameSubmit,
}: {
appName: string;
connection: ToolConnection;
logoEntry: AppGalleryDisplayEntry | null;
brandKey: string | null;
allowRemoteLogo: boolean;
status: StatusInfo;
actionCount: number | null;
canRename?: boolean;
renaming: boolean;
nameDraft: string;
renamePending: boolean;
onNameDraftChange: (value: string) => void;
onRenameStart: () => void;
onRenameCancel: () => void;
onRenameSubmit: (value: string) => void;
}) {
const unverifiedHost = unverifiedRemoteHost(connection);
return (
<header>
<div className="flex items-center gap-3">
<AppLogo
name={appName}
brandKey={brandKey}
logoUrl={appDefinitionLogoUrl(logoEntry)}
darkLogoUrl={appDefinitionDarkLogoUrl(logoEntry)}
allowRemoteFallback={allowRemoteLogo}
size={44}
/>
<div className="min-w-0">
{renaming ? (
<form
className="flex items-center gap-2"
onSubmit={(event) => {
event.preventDefault();
onRenameSubmit(nameDraft.trim());
}}
>
<Input
aria-label="App name"
value={nameDraft}
onChange={(event) => onNameDraftChange(event.target.value)}
className="h-9 w-64 text-lg font-bold"
autoFocus
/>
<Button type="submit" size="sm" disabled={renamePending || !nameDraft.trim()}>
{renamePending ? <Loader2 className="h-3.5 w-3.5 animate-spin" /> : "Save"}
</Button>
<Button type="button" size="sm" variant="ghost" onClick={onRenameCancel} disabled={renamePending}>
Cancel
</Button>
</form>
) : (
<div className="flex items-center gap-1.5">
<h1 className="truncate text-xl font-bold">{appName}</h1>
<Button
variant="ghost"
size="icon"
className="h-7 w-7 text-muted-foreground"
aria-label="Rename app"
disabled={!canRename}
onClick={onRenameStart}
>
<Pencil className="h-3.5 w-3.5" />
</Button>
</div>
)}
<div className="mt-2 flex flex-wrap items-center gap-2">
<StatusBadge status={status} />
{connection.config?.provider !== "agentmail" && actionCount !== null && (
<span className="text-xs text-muted-foreground">
{actionCount} {actionCount === 1 ? "action" : "actions"} available
</span>
)}
{connectionDisplaySecondaryHint(connection) ? (
<span className="text-xs text-muted-foreground">
{connectionDisplaySecondaryHint(connection)}
</span>
) : null}
{unverifiedHost ? <UnverifiedServerBadge host={unverifiedHost} /> : null}
<ConnectionProvenanceChip connection={connection} />
</div>
</div>
</div>
</header>
);
}
function ToolsLoading({ mcpActions = false }: { mcpActions?: boolean }) {
return (
<div className="flex items-center gap-2 py-8 text-sm text-muted-foreground" role="status">
<Loader2 className="h-4 w-4 animate-spin" />
{mcpActions ? "Loading MCP actions, this may take a minute." : "Loading tools…"}
</div>
);
}
function unverifiedRemoteHost(connection: ToolConnection): string | null {
const sourceTemplateKey = connection.config?.sourceTemplateKey ?? connection.transportConfig.sourceTemplateKey;
if (
connection.transport !== "mcp_remote"
|| (typeof sourceTemplateKey === "string" && sourceTemplateKey.trim())
) return null;
const value = connection.config?.url
?? connection.config?.endpoint
?? connection.config?.remoteUrl
?? connection.transportConfig.url
?? connection.transportConfig.endpoint
?? connection.transportConfig.remoteUrl;
if (typeof value !== "string") return null;
try {
return new URL(value).host || null;
} catch {
return null;
}
}
type StatusInfo = { label: string; tone: "connected" | "attention" | "paused" };
function statusFor(connection: ToolConnection): StatusInfo {
if (connection.enabled === false || connection.status === "disabled") {
return { label: "Paused", tone: "paused" };
}
if (isAttentionHealthStatus(connection.healthStatus) || (connection.connectionPurpose === "ai" && (connection.healthStatus !== "ok" || aiSubscriptionNeedsIsolatedLogin(connection.config)))) {
return { label: "Needs attention", tone: "attention" };
}
return { label: "Connected", tone: "connected" };
}
function StatusBadge({ status }: { status: StatusInfo }) {
const klass: Record<StatusInfo["tone"], string> = {
connected: "border-emerald-500/40 bg-emerald-500/10 text-emerald-700 dark:text-emerald-300",
attention: "border-amber-500/40 bg-amber-500/10 text-amber-700 dark:text-amber-300",
paused: "border-border bg-muted text-muted-foreground",
};
return (
<span
className={cn(
"inline-flex items-center gap-1 rounded-full border px-2 py-0.5 text-xs font-medium",
klass[status.tone],
)}
>
{status.tone === "connected" && <Check className="h-3 w-3" />}
{status.label}
</span>
);
}
function enabledCatalogIds(profile: ToolProfileConfiguration | undefined): Set<string> {
const ids = new Set<string>();
for (const entry of profile?.entries ?? []) {
if (entry.effect === "include" && entry.catalogEntryId) ids.add(entry.catalogEntryId);
}
return ids;
}
function askFirstCatalogIds(policies: ToolPolicy[], connectionId: string): Set<string> {
const ids = new Set<string>();
for (const policy of policies) {
if (policy.policyType !== "require_approval" || policy.enabled === false) continue;
const config = (policy.config ?? {}) as { source?: unknown; connectionId?: unknown; catalogEntryId?: unknown };
if (config.source === "app_gallery_finish" && config.connectionId === connectionId && typeof config.catalogEntryId === "string") {
ids.add(config.catalogEntryId);
}
}
return ids;
}
/**
* Who may use this connection, read back from the app profile's bindings.
*
* `finishApp` replaces a profile's whole binding set, so every save from this
* page — including an action-permission toggle — has to restate this. The
* Permissions tab exposes the bindings as Agent access, while installs remain
* a separate "always loaded" choice. If the profile has no bindings yet, the
* install state remains the safest legacy fallback.
*
* That fallback is the important part. It used to return "all agents" for an
* unbound profile, which turned any unrelated save into a silent company-wide
* grant from a control the reader could not see. Installs authorize their
* targets, so mirroring the install state is both the truthful reading and the
* one that agrees with what the tab displays.
*/
function accessFrom(
profile: ToolProfileConfiguration | undefined,
install: InstallState,
): AccessDraft {
const bindings = profile?.bindings ?? [];
if (bindings.some((b) => b.targetType === "company")) {
return { mode: "all", agentIds: new Set() };
}
const agentIds = new Set(bindings.filter((b) => b.targetType === "agent").map((b) => b.targetId));
if (agentIds.size > 0) return { mode: "specific", agentIds };
return install.onAll
? { mode: "all", agentIds: new Set() }
: { mode: "specific", agentIds: new Set(install.agentIds) };
}
function accessIncludingInstalls(next: AccessDraft, install: InstallState): AccessDraft {
if (install.onAll || next.mode === "all") {
return { mode: "all", agentIds: new Set() };
}
return {
mode: "specific",
agentIds: new Set([...next.agentIds, ...install.agentIds]),
};
}