mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 16:27:18 +02:00
DottaandPaperclip
f554d67377
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Issues use `in_review` to request a final decision from an authorized writer > - The server rejected an assignee agent that tried to close its own review, even when the issue had no independent-review rule > - This rejection stopped the default agent workflow and did not represent the configured execution-stage rules > - Paperclip needs an open default and explicit issue-level constraints for teams that require an independent or human verdict > - This pull request removes the unconditional rejection and adds `anyone`, `not_creator`, and `human_only` review policies > - The benefit is a working default path with opt-in, authenticated verdict controls ## Linked Issues or Issue Description Refs #10635, #4429, and #10671. The related public work covers execution-stage independence, self-approval fallback behavior, and durable review paths. This change is distinct. It controls who can resolve an issue review verdict. It keeps configured execution stages active. ## What Changed - Added a nullable `review_policy` issue column. Null has the same meaning as `anyone`. The migration does not backfill existing issues. - Added shared create, update, response, and compact issue contracts for `anyone`, `not_creator`, and `human_only`. - Removed the unconditional agent self-approval rejection for `in_review` issues. - Added one reusable verdict-actor check for terminal status changes and pending interaction accept or reject actions. - Used the authenticated principal type for `human_only`. Agent keys and run tokens remain agent principals. - Used the latest transition into `in_review` to identify the requester for `not_creator`. - Added actionable 403 responses that name the policy, the allowed actor, and the next step. - Kept the configured execution-stage transition and signoff behavior. - Added focused contract, helper, status-route, interaction-route, and execution-stage regression tests. - Updated the implementation specification for the new issue field. ## Verification - `pnpm exec vitest run packages/shared/src/validators/issue.test.ts server/src/__tests__/issue-review-policy.test.ts server/src/__tests__/issue-stalled-review-decision-routes.test.ts --reporter=dot` passed: 42 tests. - `pnpm --filter @paperclipai/shared typecheck` passed. - `pnpm --filter @paperclipai/db typecheck` passed, including migration numbering and safety checks. - `pnpm --filter @paperclipai/server typecheck` passed. - `pnpm run typecheck:build-gaps` passed across server, CLI, plugin SDK/examples, plugin wiki, and UI. - `git diff --check origin/master...HEAD` passed. - SecurityEngineer review approved the authenticated-principal checks and accepted policy-relaxation tradeoff with no required changes. - Greptile reviewed the latest head at 5/5 with zero inline comments or follow-ups. - The latest-head GitHub rollup passed build, typecheck, server/workspace tests, serialized suites, canary, e2e, and external security checks. ## Risks - The migration adds one nullable text column. It has no default and no backfill. - `not_creator` reads the latest recorded transition into `in_review`. It denies the verdict when it cannot identify the requester. - Agents can change or relax `reviewPolicy` when they have issue write access. This is intentional for this issue-level control. - Null and `anyone` do not add a database query to the verdict path. - Configured execution-stage checks still run after the issue-level policy check. > This work aligns with the completed "Agent Reviews and Approvals" and "Enforced Outcomes" roadmap items. It does not add a new roadmap capability. ## Model Used - OpenAI Codex, GPT-5. The exact deployment ID and context-window size are not exposed to the agent. The run used reasoning, repository tools, code execution, and GitHub CLI access. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
958 lines
29 KiB
TypeScript
958 lines
29 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import {
|
|
applyLocalQueuedIssueCommentState,
|
|
applyOptimisticIssueFieldUpdate,
|
|
applyOptimisticIssueFieldUpdateToCollection,
|
|
applyOptimisticIssueCommentUpdate,
|
|
createOptimisticIssueComment,
|
|
flattenIssueCommentPages,
|
|
getNextIssueCommentPageParam,
|
|
isQueuedIssueComment,
|
|
loadRemainingIssueCommentPages,
|
|
matchesIssueRef,
|
|
mergeIssueComments,
|
|
removeIssueCommentFromPages,
|
|
shouldAutoloadOlderIssueComments,
|
|
takeOptimisticIssueComment,
|
|
upsertIssueComment,
|
|
upsertIssueCommentInPages,
|
|
} from "./optimistic-issue-comments";
|
|
|
|
describe("optimistic issue comments", () => {
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it("creates a pending optimistic comment for the current user", () => {
|
|
const comment = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Working on it",
|
|
authorUserId: "board-1",
|
|
});
|
|
|
|
expect(comment.id).toMatch(/^optimistic-/);
|
|
expect(comment.clientId).toBe(comment.id);
|
|
expect(comment.clientStatus).toBe("pending");
|
|
expect(comment.authorUserId).toBe("board-1");
|
|
expect(comment.authorAgentId).toBeNull();
|
|
});
|
|
|
|
it("falls back when crypto.randomUUID is unavailable", () => {
|
|
vi.stubGlobal("crypto", {});
|
|
const nowSpy = vi.spyOn(Date, "now").mockReturnValue(1_746_000_000_000);
|
|
const mathSpy = vi.spyOn(Math, "random").mockReturnValue(0.123456789);
|
|
|
|
const comment = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Working on it",
|
|
authorUserId: "board-1",
|
|
});
|
|
|
|
expect(comment.id).toBe("optimistic-1746000000000-4fzzzxjy");
|
|
expect(comment.clientId).toBe(comment.id);
|
|
|
|
nowSpy.mockRestore();
|
|
mathSpy.mockRestore();
|
|
});
|
|
|
|
it("supports queued optimistic comments for active-run follow-ups", () => {
|
|
const comment = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Queue this",
|
|
authorUserId: "board-1",
|
|
clientStatus: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
|
|
expect(comment.clientStatus).toBe("queued");
|
|
expect(comment.queueTargetRunId).toBe("run-1");
|
|
});
|
|
|
|
it("merges optimistic comments into the server thread in chronological order", () => {
|
|
const merged = mergeIssueComments(
|
|
[
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Second",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "optimistic-1",
|
|
clientId: "optimistic-1",
|
|
clientStatus: "pending",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "First",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
);
|
|
|
|
expect(merged.map((comment) => comment.id)).toEqual(["optimistic-1", "comment-2"]);
|
|
});
|
|
|
|
it("can take one optimistic queued comment back out of the queue", () => {
|
|
const first = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "First",
|
|
authorUserId: "board-1",
|
|
clientStatus: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
const second = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Second",
|
|
authorUserId: "board-1",
|
|
clientStatus: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
|
|
const result = takeOptimisticIssueComment([first, second], first.clientId);
|
|
|
|
expect(result.comment?.body).toBe("First");
|
|
expect(result.comments.map((comment) => comment.clientId)).toEqual([second.clientId]);
|
|
});
|
|
|
|
it("upserts confirmed comments without creating duplicates", () => {
|
|
const next = upsertIssueComment(
|
|
[
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Original",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
],
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Updated",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:05.000Z"),
|
|
},
|
|
);
|
|
|
|
expect(next).toHaveLength(1);
|
|
expect(next[0]?.body).toBe("Updated");
|
|
});
|
|
|
|
it("flattens paged comments into one chronological thread", () => {
|
|
const flattened = flattenIssueCommentPages([
|
|
[
|
|
{
|
|
id: "comment-3",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Newest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Oldest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Middle",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
],
|
|
]);
|
|
|
|
expect(flattened.map((comment) => comment.id)).toEqual(["comment-1", "comment-2", "comment-3"]);
|
|
});
|
|
|
|
it("returns no next page param when the last page is missing", () => {
|
|
expect(getNextIssueCommentPageParam(undefined, 50)).toBeUndefined();
|
|
});
|
|
|
|
it("returns the oldest id when the last page is full", () => {
|
|
expect(
|
|
getNextIssueCommentPageParam(
|
|
[
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Second",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "First",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
2,
|
|
),
|
|
).toBe("comment-1");
|
|
});
|
|
|
|
it("loads remaining comment pages until the terminal partial page", async () => {
|
|
const fetchPage = vi.fn(async (afterCommentId: string) => {
|
|
if (afterCommentId === "comment-3") return [{ id: "comment-2" }, { id: "comment-1" }];
|
|
if (afterCommentId === "comment-1") return [{ id: "comment-0" }];
|
|
return [];
|
|
});
|
|
|
|
const loaded = await loadRemainingIssueCommentPages({
|
|
pages: [[{ id: "comment-4" }, { id: "comment-3" }]],
|
|
pageParams: [null],
|
|
pageSize: 2,
|
|
fetchPage,
|
|
});
|
|
|
|
expect(fetchPage).toHaveBeenCalledTimes(2);
|
|
expect(fetchPage).toHaveBeenNthCalledWith(1, "comment-3");
|
|
expect(fetchPage).toHaveBeenNthCalledWith(2, "comment-1");
|
|
expect(loaded.pages.map((page) => page.map((comment) => comment.id))).toEqual([
|
|
["comment-4", "comment-3"],
|
|
["comment-2", "comment-1"],
|
|
["comment-0"],
|
|
]);
|
|
expect(loaded.pageParams).toEqual([null, "comment-3", "comment-1"]);
|
|
});
|
|
|
|
it("autoloads older chat comments while the initial thread is still under the threshold", () => {
|
|
expect(
|
|
shouldAutoloadOlderIssueComments({
|
|
activeDetailTab: "chat",
|
|
hasOlderComments: true,
|
|
loadedCommentCount: 50,
|
|
initialPageLoading: false,
|
|
olderPageLoading: false,
|
|
autoLoadLimit: 150,
|
|
}),
|
|
).toBe(true);
|
|
});
|
|
|
|
it("does not autoload older comments outside the chat tab", () => {
|
|
expect(
|
|
shouldAutoloadOlderIssueComments({
|
|
activeDetailTab: "activity",
|
|
hasOlderComments: true,
|
|
loadedCommentCount: 50,
|
|
initialPageLoading: false,
|
|
olderPageLoading: false,
|
|
autoLoadLimit: 150,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("stops autoloading once the initial comment window reaches the cap", () => {
|
|
expect(
|
|
shouldAutoloadOlderIssueComments({
|
|
activeDetailTab: "chat",
|
|
hasOlderComments: true,
|
|
loadedCommentCount: 150,
|
|
initialPageLoading: false,
|
|
olderPageLoading: false,
|
|
autoLoadLimit: 150,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("upserts paged comments without dropping older pages", () => {
|
|
const nextPages = upsertIssueCommentInPages(
|
|
[
|
|
[
|
|
{
|
|
id: "comment-3",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Newest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Oldest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
],
|
|
{
|
|
id: "comment-4",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Brand new",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:04.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:04.000Z"),
|
|
},
|
|
);
|
|
|
|
expect(nextPages[0]?.map((comment) => comment.id)).toEqual(["comment-4", "comment-3"]);
|
|
expect(nextPages[1]?.map((comment) => comment.id)).toEqual(["comment-1"]);
|
|
});
|
|
|
|
it("removes a confirmed queued comment from paged caches", () => {
|
|
const nextPages = removeIssueCommentFromPages(
|
|
[
|
|
[
|
|
{
|
|
id: "comment-3",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Newest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Middle",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Oldest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
],
|
|
"comment-2",
|
|
);
|
|
|
|
expect(nextPages).toHaveLength(2);
|
|
expect(nextPages[0]?.map((comment) => comment.id)).toEqual(["comment-3"]);
|
|
expect(nextPages[1]?.map((comment) => comment.id)).toEqual(["comment-1"]);
|
|
});
|
|
|
|
it("applies optimistic reopen and reassignment updates to the issue cache", () => {
|
|
const next = applyOptimisticIssueCommentUpdate(
|
|
{
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Fix comment flow",
|
|
description: null,
|
|
status: "done",
|
|
workMode: "standard",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 1,
|
|
identifier: "PAP-1",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
reopen: true,
|
|
reassignment: {
|
|
assigneeAgentId: null,
|
|
assigneeUserId: "board-2",
|
|
},
|
|
},
|
|
);
|
|
|
|
expect(next?.status).toBe("todo");
|
|
expect(next?.assigneeAgentId).toBeNull();
|
|
expect(next?.assigneeUserId).toBe("board-2");
|
|
});
|
|
|
|
it("applies optimistic field updates for issue property edits", () => {
|
|
const next = applyOptimisticIssueFieldUpdate(
|
|
{
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: "project-1",
|
|
projectWorkspaceId: "workspace-1",
|
|
goalId: null,
|
|
parentId: null,
|
|
ancestors: [
|
|
{
|
|
id: "issue-9",
|
|
identifier: "PAP-9",
|
|
title: "Old parent",
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
projectId: null,
|
|
goalId: null,
|
|
project: null,
|
|
goal: null,
|
|
},
|
|
],
|
|
title: "Fix property pane",
|
|
description: null,
|
|
status: "todo",
|
|
workMode: "standard",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 1,
|
|
identifier: "PAP-1",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: "exec-1",
|
|
executionWorkspacePreference: "shared_workspace",
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
labelIds: ["label-1", "label-2"],
|
|
labels: [
|
|
{
|
|
id: "label-1",
|
|
companyId: "company-1",
|
|
name: "One",
|
|
color: "#111111",
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
id: "label-2",
|
|
companyId: "company-1",
|
|
name: "Two",
|
|
color: "#222222",
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
],
|
|
blockedBy: [
|
|
{
|
|
id: "issue-2",
|
|
identifier: "PAP-2",
|
|
title: "First blocker",
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
},
|
|
{
|
|
id: "issue-3",
|
|
identifier: "PAP-3",
|
|
title: "Second blocker",
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
},
|
|
],
|
|
blocks: [],
|
|
project: {
|
|
id: "project-1",
|
|
companyId: "company-1",
|
|
urlKey: "project-one",
|
|
goalId: null,
|
|
goalIds: [],
|
|
goals: [],
|
|
name: "Project one",
|
|
description: null,
|
|
status: "in_progress",
|
|
leadAgentId: null,
|
|
targetDate: null,
|
|
color: null,
|
|
icon: null,
|
|
env: null,
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
executionWorkspacePolicy: null,
|
|
codebase: {
|
|
workspaceId: null,
|
|
repoUrl: null,
|
|
repoRef: null,
|
|
defaultRef: null,
|
|
repoName: null,
|
|
localFolder: null,
|
|
managedFolder: "/tmp/paperclip",
|
|
effectiveLocalFolder: "/tmp/paperclip",
|
|
origin: "local_folder",
|
|
},
|
|
workspaces: [],
|
|
primaryWorkspace: null,
|
|
archivedAt: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
currentExecutionWorkspace: {
|
|
id: "exec-1",
|
|
companyId: "company-1",
|
|
projectId: "project-1",
|
|
projectWorkspaceId: null,
|
|
sourceIssueId: "issue-1",
|
|
mode: "shared_workspace",
|
|
strategyType: "project_primary",
|
|
branchName: null,
|
|
status: "active",
|
|
deliveryState: "unknown",
|
|
name: "Execution workspace",
|
|
cwd: "/tmp/paperclip",
|
|
repoUrl: null,
|
|
baseRef: null,
|
|
providerType: "local_fs",
|
|
providerRef: null,
|
|
derivedFromExecutionWorkspaceId: null,
|
|
lastUsedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
cleanupEligibleAt: null,
|
|
cleanupReason: null,
|
|
config: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
openedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
closedAt: null,
|
|
},
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
status: "in_review",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: "board-2",
|
|
labelIds: ["label-2"],
|
|
blockedByIssueIds: ["issue-3"],
|
|
parentId: "issue-4",
|
|
projectId: "project-2",
|
|
executionWorkspaceId: "exec-2",
|
|
},
|
|
);
|
|
|
|
expect(next?.status).toBe("in_review");
|
|
expect(next?.assigneeAgentId).toBeNull();
|
|
expect(next?.assigneeUserId).toBe("board-2");
|
|
expect(next?.labelIds).toEqual(["label-2"]);
|
|
expect(next?.labels?.map((label) => label.id)).toEqual(["label-2"]);
|
|
expect(next?.blockedBy?.map((relation) => relation.id)).toEqual(["issue-3"]);
|
|
expect(next?.parentId).toBe("issue-4");
|
|
expect(next?.ancestors).toBeUndefined();
|
|
expect(next?.projectId).toBe("project-2");
|
|
expect(next?.project).toBeNull();
|
|
expect(next?.executionWorkspaceId).toBe("exec-2");
|
|
expect(next?.currentExecutionWorkspace).toBeNull();
|
|
});
|
|
|
|
it("matches issues by either uuid or identifier reference", () => {
|
|
expect(matchesIssueRef({ id: "issue-1", identifier: "PAP-1" } as const, ["issue-1"])).toBe(true);
|
|
expect(matchesIssueRef({ id: "issue-1", identifier: "PAP-1" } as const, ["PAP-1"])).toBe(true);
|
|
expect(matchesIssueRef({ id: "issue-1", identifier: "PAP-1" } as const, ["issue-2", "PAP-2"])).toBe(false);
|
|
});
|
|
|
|
it("applies optimistic field updates across cached issue collections", () => {
|
|
const issues: Issue[] = [
|
|
{
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Fix property pane",
|
|
description: null,
|
|
status: "todo",
|
|
workMode: "standard",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 1,
|
|
identifier: "PAP-1",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
labelIds: [],
|
|
labels: [],
|
|
blockedBy: [],
|
|
blocks: [],
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
id: "issue-2",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Leave me alone",
|
|
description: null,
|
|
status: "todo",
|
|
workMode: "standard",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: "agent-2",
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 2,
|
|
identifier: "PAP-2",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
labelIds: [],
|
|
labels: [],
|
|
blockedBy: [],
|
|
blocks: [],
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
];
|
|
|
|
const next = applyOptimisticIssueFieldUpdateToCollection(issues, ["PAP-1"], { assigneeAgentId: "agent-9" });
|
|
|
|
expect(next?.[0]?.assigneeAgentId).toBe("agent-9");
|
|
expect(next?.[1]?.assigneeAgentId).toBe("agent-2");
|
|
});
|
|
|
|
it("treats comments without a run id as queued when they arrive during an active run", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
id: "comment-2",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunWakeCommentId: "comment-1",
|
|
runId: null,
|
|
}),
|
|
).toBe(true);
|
|
});
|
|
|
|
it("does not mark the comment that triggered the active run as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
id: "comment-1",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunCommentId: "comment-1",
|
|
activeRunWakeCommentId: "comment-1",
|
|
runId: null,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark the active run context comment as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
id: "context-comment",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunCommentId: "context-comment",
|
|
activeRunWakeCommentId: "wake-comment",
|
|
runId: null,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark the active run wake comment as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
id: "wake-comment",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunCommentId: "context-comment",
|
|
activeRunWakeCommentId: "wake-comment",
|
|
runId: null,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark comments with an associated run as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
runId: "run-1",
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark interrupt comments as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
interruptedRunId: "run-1",
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark comments from the active run agent as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
authorAgentId: "agent-1",
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunAgentId: "agent-1",
|
|
runId: null,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("keeps a confirmed queued comment queued while the target run is still live", () => {
|
|
const comment = {
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Follow up after the active run",
|
|
authorType: "user" as const,
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
updatedAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
};
|
|
|
|
const result = applyLocalQueuedIssueCommentState(comment, {
|
|
queuedTargetRunId: "run-1",
|
|
targetRunIsLive: true,
|
|
runningRunId: "run-1",
|
|
});
|
|
|
|
expect(result).toMatchObject({
|
|
id: "comment-1",
|
|
clientStatus: "queued",
|
|
queueState: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
});
|
|
|
|
it("does not keep local queued state after the target run is no longer live", () => {
|
|
const comment = {
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Follow up after the active run",
|
|
authorType: "user" as const,
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
updatedAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
};
|
|
|
|
const result = applyLocalQueuedIssueCommentState(comment, {
|
|
queuedTargetRunId: "run-1",
|
|
targetRunIsLive: false,
|
|
runningRunId: null,
|
|
});
|
|
|
|
expect(result).toBe(comment);
|
|
});
|
|
|
|
it("does not keep local queued state when a different run is live", () => {
|
|
const comment = {
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Follow up after the active run",
|
|
authorType: "user" as const,
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
updatedAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
};
|
|
|
|
const result = applyLocalQueuedIssueCommentState(comment, {
|
|
queuedTargetRunId: "run-1",
|
|
targetRunIsLive: true,
|
|
runningRunId: "run-2",
|
|
});
|
|
|
|
expect(result).toBe(comment);
|
|
});
|
|
});
|