Files
PaperClipAI/tests/runner-e2e/controller-outage.ts
T
DottaandClaude Opus 5.5 9cc3760552 test(runner-e2e): allow controller outages up to ten minutes (#19797)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The restart chaos harness and the runner-e2e recover-controller
cells stop the control plane with `replaceController`
(`tests/runner-e2e/controller-outage.ts`), hold it down, then start it
again
> - `parseControllerOutage` refuses holds longer than 300000 ms
> - Restart chaos needs longer holds. One example is proving that a
Daytona sandbox survives an outage longer than its old 5-minute
auto-stop but inside the 7-minute runner reconnect grace (RC-54)
> - With the cap, such a fault errors before the controller stops, so
the scenario cannot run
> - This pull request raises the test-harness cap to 600000 ms
> - The benefit is that chaos runs can now inject 5–10 minute outages;
production code and qualification contracts are unchanged

## Linked Issues or Issue Description

**Bug description**
A restart chaos replay with a 360000 ms K4 hold failed with "Controller
outage requires SIGTERM/SIGKILL and 0..300000 integer milliseconds". The
controller was never stopped.

**Expected behavior**
The test harness accepts outages of up to 10 minutes. The
recover-controller receipt check keeps its own readiness limit
(`readyAfterMs < 420000`).

Refs #19544

## What Changed

- `tests/runner-e2e/controller-outage.ts`: adds
`MAX_CONTROLLER_OUTAGE_MS = 600_000` and uses it in
`parseControllerOutage` and its error message.
`validControllerOutageReceipt` is unchanged and still requires readiness
inside the 7-minute grace.
- `tests/runner-e2e/controller-outage.test.ts`: the rejection cases now
use 600001. A new test accepts 360000 (SIGKILL) and 600000 (SIGTERM).
The existing five-minute contract test is unchanged.

## Verification

- `vitest run tests/runner-e2e/controller-outage.test.ts
tests/runner-e2e/server-restart-request.test.ts`: 52/52 pass.
- `server-restart-request.test.ts` now uses 600001 as its out-of-range
`controllerOutage`. The separate restart-request `controllerDowntimeMs`
limit (five minutes) is unchanged.

## Risks

- This change is test-only. No product or server code changes.
- A suite that sets `PAPERCLIP_RUNNER_E2E_CONTROLLER_OUTAGE_MS` above
300000 now runs instead of being refused. The recover-controller receipt
check still fails any receipt whose readiness is outside the grace.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, in Claude Code with
tool use (shell, file edits, GitHub CLI). Default context window,
extended thinking.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 03:11:10 -06:00

172 lines
9.0 KiB
TypeScript

import { lstat, rename } from "node:fs/promises";
import type { ServingArtifact } from "./upgrade-artifacts.js";
import type { ControllerRecoveryReceipt } from "./controller-recovery-observer.js";
import { setTimeout as delay } from "node:timers/promises";
import type { MatrixExecution } from "./types.js";
import { isRollingWebDeployment } from "./controller-rolling-deployment.js";
export interface ControllerOutage {
signal: "SIGTERM" | "SIGKILL";
holdMs: number;
}
export interface ControllerOutageReceipt extends ControllerOutage {
schema: "paperclip.e2e.controller-outage/v1";
requestId: string;
previousPid: number;
replacementPid?: number;
startedAt: string;
stoppedAfterMs?: number;
cacheDiscarded?: boolean;
replacementStartedAfterMs?: number;
readyAfterMs?: number;
previousArtifact?: ServingArtifact;
replacementArtifact?: ServingArtifact;
recovery?: ControllerRecoveryReceipt;
recoveryProgress?: Partial<ControllerRecoveryReceipt>;
}
/**
* Longest controller outage a harness may inject. Ten minutes lets chaos
* holds pass Daytona's sandbox auto-stop and the 7-minute runner reconnect
* grace. The recover-controller receipt check below still requires readiness
* inside that grace, so this does not loosen the qualification contract.
*/
export const MAX_CONTROLLER_OUTAGE_MS = 600_000;
export function parseControllerOutage(value: unknown): ControllerOutage {
if (!value || typeof value !== "object" || Array.isArray(value)) throw new Error("Invalid controller outage");
const { signal, holdMs } = value as Record<string, unknown>;
if ((signal !== "SIGTERM" && signal !== "SIGKILL") || !Number.isSafeInteger(holdMs)
|| Number(holdMs) < 0 || Number(holdMs) > MAX_CONTROLLER_OUTAGE_MS) {
throw new Error(`Controller outage requires SIGTERM/SIGKILL and 0..${MAX_CONTROLLER_OUTAGE_MS} integer milliseconds`);
}
return { signal, holdMs: Number(holdMs) };
}
export function configuredControllerOutage(env: NodeJS.ProcessEnv, defaultHoldMs = 1_000): ControllerOutage {
const raw = env.PAPERCLIP_RUNNER_E2E_CONTROLLER_OUTAGE_MS ?? String(defaultHoldMs);
if (!/^\d+$/.test(raw)) throw new Error("Invalid PAPERCLIP_RUNNER_E2E_CONTROLLER_OUTAGE_MS");
return parseControllerOutage({ signal: env.PAPERCLIP_RUNNER_E2E_CONTROLLER_STOP_SIGNAL ?? "SIGKILL", holdMs: Number(raw) });
}
export function controllerOutageForExecution(execution: MatrixExecution, env: NodeJS.ProcessEnv): ControllerOutage | undefined {
if (isRollingWebDeployment(execution)) return undefined;
if (execution.task.flow !== "everyday_workflow" || execution.task.id !== "recover-controller"
|| execution.environment.id !== "daytona" || execution.profile.generation !== "native"
|| (execution.profile.provider !== "codex" && execution.profile.provider !== "acpx")) return undefined;
const declaredHoldMs = execution.suite.definitionMetadata?.controllerDowntimeMs;
if (typeof declaredHoldMs !== "number") throw new Error("Controller recovery suite must declare its outage duration");
const outage = configuredControllerOutage(env, declaredHoldMs);
if (["daytona-restart-continuity", "remote-workspace-storage"].includes(execution.suite.id) && outage.holdMs < declaredHoldMs) {
throw new Error("Controller outage is shorter than the dedicated continuity contract");
}
return outage;
}
/** A fault receipt is required in addition to the runner's continuity receipts. */
export function validControllerOutageReceipt(value: unknown, expected?: ControllerOutage, requestId?: string,
expectedArtifacts?: { previous: Pick<ServingArtifact, "revision" | "treeSha256">;
replacement: Pick<ServingArtifact, "revision" | "treeSha256"> }): value is ControllerOutageReceipt {
if (!value || typeof value !== "object" || Array.isArray(value)) return false;
const r = value as ControllerOutageReceipt;
try { parseControllerOutage(r); } catch { return false; }
const durations = [r.stoppedAfterMs, r.replacementStartedAfterMs, r.readyAfterMs];
return r.schema === "paperclip.e2e.controller-outage/v1"
&& typeof r.requestId === "string" && /^[A-Za-z0-9._:-]{1,200}$/.test(r.requestId)
&& typeof r.startedAt === "string" && Number.isFinite(Date.parse(r.startedAt))
&& Number.isSafeInteger(r.previousPid) && r.previousPid > 0
&& Number.isSafeInteger(r.replacementPid) && Number(r.replacementPid) > 0 && r.previousPid !== r.replacementPid
&& r.cacheDiscarded === true
&& durations.every(ms => typeof ms === "number" && Number.isFinite(ms) && ms >= 0)
&& r.replacementStartedAfterMs! - r.stoppedAfterMs! >= r.holdMs
&& r.readyAfterMs! >= r.replacementStartedAfterMs!
&& r.readyAfterMs! < 420_000
&& ((!r.previousArtifact && !r.replacementArtifact) || Boolean(r.previousArtifact && r.replacementArtifact
&& [r.previousArtifact, r.replacementArtifact].every(a => /^[a-f0-9]{40}$/.test(a.revision)
&& /^[a-f0-9]{64}$/.test(a.treeSha256) && typeof a.version === "string"
&& ["released", "development-build"].includes(a.evidence))
&& r.previousArtifact.revision !== r.replacementArtifact.revision
&& r.previousArtifact.treeSha256 !== r.replacementArtifact.treeSha256))
&& (!expectedArtifacts || Boolean(r.previousArtifact && r.replacementArtifact
&& r.previousArtifact.revision === expectedArtifacts.previous.revision
&& r.previousArtifact.treeSha256 === expectedArtifacts.previous.treeSha256
&& r.replacementArtifact.revision === expectedArtifacts.replacement.revision
&& r.replacementArtifact.treeSha256 === expectedArtifacts.replacement.treeSha256))
&& (requestId === undefined || r.requestId === requestId)
&& (!expected || (r.signal === expected.signal && r.holdMs === expected.holdMs));
}
/** Test harness only. Owners supply process cleanup, HTTP probing and cache paths.
* No database mutation, runner command or production recovery hook is involved.
*/
export async function replaceController<T extends { pid?: number }>(input: {
requestId: string; previousPid: number; outage: ControllerOutage;
stop: (signal: ControllerOutage["signal"]) => Promise<void>;
waitForUnhealthy: () => Promise<void>;
discardCache: () => Promise<void>;
start: () => Promise<T>;
waitForReady: (replacement: T) => Promise<void>;
cancelled: () => boolean;
record: (receipt: ControllerOutageReceipt) => Promise<void>;
previousArtifact?: ServingArtifact;
replacementArtifact?: () => ServingArtifact | undefined;
afterStopped?: (receipt: ControllerOutageReceipt) => Promise<void>;
afterReady?: (receipt: ControllerOutageReceipt, record: () => Promise<void>) => Promise<void>;
}): Promise<ControllerOutageReceipt> {
const outage = parseControllerOutage(input.outage);
const started = performance.now();
const receipt: ControllerOutageReceipt = { schema: "paperclip.e2e.controller-outage/v1",
requestId: input.requestId, previousPid: input.previousPid, startedAt: new Date().toISOString(), ...outage,
...(input.previousArtifact ? { previousArtifact: input.previousArtifact } : {}) };
const check = () => { if (input.cancelled()) throw new Error("Wrapper shutdown interrupted the controller outage"); };
const record = () => input.record({ ...receipt });
check();
await record(); // Failed attempts retain the boundary they actually reached.
await input.stop(outage.signal);
await input.waitForUnhealthy();
receipt.stoppedAfterMs = performance.now() - started;
await input.afterStopped?.(receipt);
await record();
await input.discardCache();
receipt.cacheDiscarded = true;
await record();
while (performance.now() - started - receipt.stoppedAfterMs < outage.holdMs) {
check();
await delay(Math.min(100, outage.holdMs - (performance.now() - started - receipt.stoppedAfterMs)));
}
check();
receipt.replacementStartedAfterMs = performance.now() - started;
await record();
const replacement = await input.start();
receipt.replacementPid = replacement.pid;
await record();
await input.waitForReady(replacement);
check();
receipt.readyAfterMs = performance.now() - started;
if (input.previousArtifact) {
receipt.replacementArtifact = input.replacementArtifact?.();
if (!receipt.replacementArtifact) throw new Error("Replacement has no verified serving artifact");
}
await record();
if (!validControllerOutageReceipt(receipt, outage, input.requestId)) throw new Error("Controller outage did not produce a qualifying replacement receipt");
await input.afterReady?.(receipt, record);
return receipt;
}
/** Retire only the controller-owned cache; this is not Runner state. */
export async function retireControllerCache(cache: string, retired: string): Promise<void> {
try { await rename(cache, retired); }
catch (error) {
if ((error as NodeJS.ErrnoException).code !== "ENOENT") throw error;
// ENOENT can also mean the destination parent is missing. Only absence of
// the old cache satisfies retirement; preserve every other failure.
try { await lstat(cache); }
catch (missing) {
if ((missing as NodeJS.ErrnoException).code === "ENOENT") return;
throw missing;
}
throw error;
}
}