mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-17 13:01:05 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Agents use connected apps through Paperclip's MCP client in the tool gateway > - Some provider actions run for minutes: CI runs, deploys, batch jobs > - Today such a call is lost if it outlives the tool timeout or if Paperclip restarts or deploys mid-call, and a retry can start the work a second time > - Recovery must just work, and the target rate of runs that need a manual retry is 0% > - This pull request implements the MCP Tasks extension (`io.modelcontextprotocol/tasks`, 2026-07-28) in the MCP client > - The benefit is that a long provider call becomes a durable task: it survives timeouts, restarts, and deploys, and it is never started twice ## Linked Issues or Issue Description **Problem** A long provider tool call holds an HTTP request open. When it passes the tool timeout, or when Paperclip restarts or deploys during the call, the result is lost. The agent then often repeats the call, and the provider does the work again. **Proposed solution** Implement the client side of the MCP Tasks extension. Declare it on stateless tool calls. Store each returned task durably, wait on it during the call, keep polling it in the background after the call ends, and let the same call attach to the stored task instead of sending `tools/call` again. **Why it matters** CI, deploy, and batch actions are where agents lose the most work today. A durable task handle makes these actions safe across timeouts, restarts, and deploys, without a person. Refs #21119, Refs #21140, Refs #21219 (the MCP Apps, stateless MCP client, and MCP Skills work this builds on). ## What Changed - **Off by default:** MCP Tasks are behind the new instance experimental setting `enableMcpTasks` ("Durable app actions (MCP Tasks)"), default off. When it is off, Paperclip never declares the extension, nothing attaches to or polls tasks, pending rows do not block idle sleep, and behavior matches master. A test covers the off state. - `mcp-http.ts`: the tasks extension is declared per request, only on HTTP `tools/call` and `tasks/*`. Discovery, listings, and stdio servers do not declare it. `tasks/*` requests put the task ID in `Mcp-Name`. - New `mcp-tasks.ts`: parses task results, bounds the server's timing hints, sends `tasks/get`, `tasks/update`, and `tasks/cancel`, and seals task IDs at rest (AES-256-GCM, bound to company and connection; a keyed hash gives uniqueness). - New company-scoped table `tool_mcp_tasks` (migration `0475`, online-compatible). It links the task to the call, run, task, connection, and grant. It stores no provider result. - `tool-gateway.ts`: - A returned task is recorded, then polled up to the normal tool timeout. Its result goes through the same validation, redaction, and recording as a direct result. - Past the timeout, or when the caller disconnects, the agent gets `provider_task_pending` ("call again with the same arguments"). The task stays durable. - A call with the same endpoint, tool, full arguments, grant, agent, task, and actor attaches to the undelivered task. A retry with the same idempotency key also attaches, and it can never start different work under that key. - Input: URL requests show the provider link (Paperclip never answers them). Form requests become a question card; only the person's answer is sent with `tasks/update`. Other requests stop with a clear "needs input" error. - Stopping the run sends `tasks/cancel` and marks the task cancelled. A caller that only disconnects keeps the task. - `failed` becomes a tool error with the provider's message. An unknown task or a passed TTL becomes `provider_task_expired`. Every task stops being tracked at its TTL, or after 7 days at most. - Audit entries: `tool_gateway.task_started`, `task_input_sent`, `task_cancelled`. - New `mcp-task-work.ts`, registered at startup with the shared deadline scheduler: it resumes polling pending tasks after a restart, cancels tasks whose task closed or run was stopped, and wakes the assignee once when a task settles after its run ended. - Docs: `doc/connections/MCP-TASKS.md`, linked from `doc/connections/README.md`. Background work (per `rules/sleep-aware-background-work.mdc`): trigger is a task row write or release (`mcp-tasks` queue) and one startup pass. The deadline is the earliest `next_poll_at`. Cadence is the server's `pollIntervalMs` within 5 s – 5 min, with backoff; 5 min while waiting for a person. It is quiet when no row has a next poll. This is the narrow external-source exception: providers give no wake Paperclip can receive, and polling stops with the task. ## Verification - `server/src/__tests__/mcp-tasks.test.ts`: 20 tests with a fake 2026-07-28 server that returns tasks only to a client that declares the extension and checks `Mcp-Name`. They cover: - polling to completion, with the result identical to a synchronous call; - timeout, then an attaching call with no second `tools/call`; - a keyed retry, and a reused key with different arguments (refused); - restart mid-task: a fresh gateway with no in-memory state polls the row, wakes the agent once, and the recovered run gets the result once with no second `tools/call`; - no wake while the run is still going; - URL input (link, never answered), and form input (question card, then `tasks/update` with the answer); - cancellation by the run, by closing the task, and no cancellation when only the caller leaves; - failure, an unknown task, and TTL expiry (ends in under 3 s, no hang); - another agent never attaches; - synchronous calls unchanged and older servers never see the extension. - Red/green: with attach disabled, the timeout, keyed-retry, and restart tests fail (3). With `tasks/cancel` disabled, both cancellation tests fail (2). Before `tools/call` declared the extension, 13 end-to-end tests failed. All pass with the change. - Existing suites pass: `mcp-protocol-versions`, `mcp-http`, `mcp-apps`, `mcp-skills`, `server-startup-feedback-export`, `tool-gateway`, `tool-gateway-discovery-http`, `remote-mcp-connectors` (342 tests). - `tsc --noEmit -p server` is clean. `pnpm --filter @paperclipai/db check:migrations` passes (the migration is classified online-compatible). Snapshots pruned to five. - Agent boot and time-to-first-token: no change in the boot or first-turn path. The only new per-call cost is one indexed lookup on stateless tool calls. - Not run: a live provider that returns tasks. No public MCP server that returns tasks was available without new credentials. ## Risks - Shipped off by default. Review findings that only affect the setting-on path after this merge are tracked as follow-ups. - Migration: a new table with indexes and foreign keys to `companies`, `tool_invocations`, and `tool_connections`. Online-compatible. - Behaviour change only for servers that return tasks, which they may do only to clients that declare the extension. Older servers and stdio servers are unchanged. - A task that settles while nobody is waiting stays attachable for 1 hour, so a deliberate repeat of the same call within that hour collects the earlier result instead of starting new work. - The wake after a background task settles uses the generic task wake; the agent must call the tool again to collect the result. - Follow-ups: `notifications/tasks` via `subscriptions/listen`; sampling and roots input requests; showing a long action's progress in the task chat. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, in Claude Code with tool use (shell, file edits, local test runs). ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [ ] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1335 lines
52 KiB
TypeScript
1335 lines
52 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { flushSync } from "react-dom";
|
|
import { MemoryRouter } from "react-router-dom";
|
|
import { createRoot, type Root } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { INSTANCE_FEATURE_KEYS } from "@paperclipai/shared";
|
|
import type {
|
|
InstanceExperimentalSettings as InstanceExperimentalSettingsPayload,
|
|
InstanceExperimentalSettingsWithManaged,
|
|
} from "@paperclipai/shared";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { ApiError } from "@/api/client";
|
|
import { InstanceExperimentalSettings } from "./InstanceExperimentalSettings";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
|
|
const mockInstanceSettingsApi = vi.hoisted(() => ({
|
|
getExperimental: vi.fn(),
|
|
updateExperimental: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("@/api/instanceSettings", () => ({
|
|
instanceSettingsApi: mockInstanceSettingsApi,
|
|
}));
|
|
|
|
vi.mock("@/components/ClassicWorkspaceSetting", () => ({ ClassicWorkspaceSetting: () => null }));
|
|
|
|
vi.mock("@/context/CompanyContext", () => ({
|
|
useCompany: () => ({ selectedCompany: { id: "butter", issuePrefix: "BUT" } }),
|
|
}));
|
|
|
|
vi.mock("../context/BreadcrumbContext", () => ({
|
|
useBreadcrumbs: () => ({ setBreadcrumbs: vi.fn() }),
|
|
}));
|
|
|
|
async function act(callback: () => void | Promise<void>) {
|
|
let result: void | Promise<void> = undefined;
|
|
flushSync(() => {
|
|
result = callback();
|
|
});
|
|
await result;
|
|
}
|
|
|
|
async function flushReact() {
|
|
for (let index = 0; index < 5; index += 1) {
|
|
await Promise.resolve();
|
|
await new Promise((resolve) => window.setTimeout(resolve, 0));
|
|
}
|
|
flushSync(() => {});
|
|
}
|
|
|
|
const CONFERENCE_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle conference room chat experimental setting"]';
|
|
const STREAMLINED_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle Streamlined UI experimental setting"]';
|
|
const TASK_WATCHDOGS_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle task watchdogs experimental setting"]';
|
|
const CLASSIC_TASK_INTERFACE_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle classic task interface experimental setting"]';
|
|
const GOALS_SIDEBAR_LINK_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle goals sidebar link experimental setting"]';
|
|
const DECISIONS_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle decisions experimental setting"]';
|
|
const SERVER_INFO_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle server info debug view experimental setting"]';
|
|
const PAPERCLIP_DEVELOPER_MODE_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle Paperclip developer mode experimental setting"]';
|
|
const BUILT_IN_AGENTS_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle built-in agents experimental setting"]';
|
|
const BETA_SKILLS_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle beta skills experimental setting"]';
|
|
const SUMMARIES_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle summaries experimental setting"]';
|
|
const STATUS_CARDS_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle status cards experimental setting"]';
|
|
const PAPERCLIP_RUNNER_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle Paperclip Runner experimental setting"]';
|
|
|
|
function defaultExperimentalSettings(): InstanceExperimentalSettingsPayload {
|
|
return {
|
|
enableEnvironments: false,
|
|
enableNativeRunner: false,
|
|
remoteWorkspaceStorageEnabled: false,
|
|
enableAiConnectionRouters: false,
|
|
enableManagedSandboxOnly: false,
|
|
enableIsolatedWorkspaces: false,
|
|
enableIsolatedWorkspacesByDefault: false,
|
|
enableStreamlinedLeftNavigation: true,
|
|
enableStreamlinedUi: true,
|
|
enableApps: true,
|
|
enableMcpAggregators: true,
|
|
enablePublicMcp: false,
|
|
enableOpenAiDot: false,
|
|
enableGrokBot: false,
|
|
enableMuse: false,
|
|
enableChatConnectors: false,
|
|
enableGitHubReviewBots: false,
|
|
enableMemoryConnectors: false,
|
|
enableGoogleWorkspaceConnector: false,
|
|
enablePaperclipNotebook: false,
|
|
enableCases: false,
|
|
enableAgentChat: false,
|
|
enableCombinedInboxTasks: false,
|
|
enableArtifactsV1: false,
|
|
enableConferenceRoomChat: false,
|
|
enableClassicTaskInterface: false,
|
|
enableLegacyComposerSubmit: false,
|
|
enableIssuePlanDecompositions: false,
|
|
enableExperimentalFileViewer: false,
|
|
enableExternalObjects: false,
|
|
enableBuiltInAgents: false,
|
|
enableBetaSkills: false,
|
|
enableSummaries: false,
|
|
enableStatusCards: false,
|
|
enableDecisions: false,
|
|
enableFastResponses: false,
|
|
enableGoalsSidebarLink: false,
|
|
enableServerInfoDebugView: false,
|
|
enablePaperclipDeveloperMode: false,
|
|
enableSimplifiedEnglishInteractions: false,
|
|
enableFirstTaskPlanProposal: false,
|
|
enableSmokeLab: false,
|
|
autoRestartDevServerWhenIdle: false,
|
|
enableWorkspaceBranchReconcileForward: true,
|
|
enableWorkspaceDirtyQuarantineRepair: true,
|
|
enableOwnerInstanceAdmin: false,
|
|
enableSandboxDuplexBridge: false,
|
|
enableMcpTasks: false,
|
|
enableRunnerPreviewIngress: false,
|
|
enableWorktreeRunExecution: false,
|
|
worktreeRunExecutionActivatedAt: null,
|
|
worktreeRunExecutionActivationInstanceId: null,
|
|
};
|
|
}
|
|
|
|
const WORKTREE_RUN_EXECUTION_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle worktree run execution setting"]';
|
|
|
|
const ISOLATED_WORKSPACES_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle isolated workspaces experimental setting"]';
|
|
|
|
const ISOLATED_WORKSPACES_BY_DEFAULT_TOGGLE_SELECTOR =
|
|
'button[aria-label="Toggle isolated workspaces by default experimental setting"]';
|
|
|
|
function setWorktreeRuntimeMeta(enabled: boolean) {
|
|
const name = "paperclip-worktree-enabled";
|
|
let meta = document.querySelector<HTMLMetaElement>(`meta[name="${name}"]`);
|
|
if (enabled) {
|
|
if (!meta) {
|
|
meta = document.createElement("meta");
|
|
meta.setAttribute("name", name);
|
|
document.head.appendChild(meta);
|
|
}
|
|
meta.setAttribute("content", "true");
|
|
} else if (meta) {
|
|
meta.remove();
|
|
}
|
|
}
|
|
|
|
function setWorktreeInstanceIdMeta(instanceId: string | null) {
|
|
const name = "paperclip-instance-id";
|
|
let meta = document.querySelector<HTMLMetaElement>(`meta[name="${name}"]`);
|
|
if (instanceId) {
|
|
if (!meta) {
|
|
meta = document.createElement("meta");
|
|
meta.setAttribute("name", name);
|
|
document.head.appendChild(meta);
|
|
}
|
|
meta.setAttribute("content", instanceId);
|
|
} else if (meta) {
|
|
meta.remove();
|
|
}
|
|
}
|
|
|
|
describe("InstanceExperimentalSettings — Conference Room Chat card (PAP-11233)", () => {
|
|
let container: HTMLDivElement;
|
|
let root: Root | null = null;
|
|
let currentExperimentalSettings: InstanceExperimentalSettingsPayload;
|
|
|
|
async function renderPage() {
|
|
root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: { queries: { retry: false } },
|
|
});
|
|
flushSync(() => {
|
|
root!.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<MemoryRouter initialEntries={["/BUT/company/settings/instance/experimental"]}>
|
|
<InstanceExperimentalSettings />
|
|
</MemoryRouter>
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flushReact();
|
|
}
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
currentExperimentalSettings = defaultExperimentalSettings();
|
|
mockInstanceSettingsApi.getExperimental.mockImplementation(async () => ({
|
|
...currentExperimentalSettings,
|
|
}));
|
|
mockInstanceSettingsApi.updateExperimental.mockImplementation(async (patch) => {
|
|
currentExperimentalSettings = { ...currentExperimentalSettings, ...patch };
|
|
return { ...currentExperimentalSettings };
|
|
});
|
|
});
|
|
|
|
afterEach(() => {
|
|
flushSync(() => {
|
|
root?.unmount();
|
|
});
|
|
root = null;
|
|
container.remove();
|
|
setWorktreeRuntimeMeta(false);
|
|
setWorktreeInstanceIdMeta(null);
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("renders a page-level warning about instability and lack of guarantees", async () => {
|
|
await renderPage();
|
|
|
|
const warning = [...container.querySelectorAll('[role="alert"]')].find((alert) =>
|
|
alert.textContent?.includes("Experimental features may break at any time."),
|
|
);
|
|
expect(warning?.textContent).toContain("Experimental features may break at any time.");
|
|
expect(warning?.textContent).toContain("no compatibility guarantees");
|
|
});
|
|
|
|
it("does not render an Apps experimental setting", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.querySelector('button[aria-label="Toggle apps experimental setting"]')).toBeNull();
|
|
expect(container.textContent).not.toContain("Show the Apps navigation");
|
|
});
|
|
|
|
it("defaults memory connectors off and persists an explicit toggle in both directions", async () => {
|
|
await renderPage();
|
|
const selector = 'button[aria-label="Toggle memory connectors experimental setting"]';
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe("false");
|
|
expect(container.textContent).toContain("Existing connections keep running.");
|
|
for (const enabled of [true, false]) {
|
|
await act(() => container.querySelector<HTMLButtonElement>(selector)!.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({ enableMemoryConnectors: enabled });
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe(String(enabled));
|
|
}
|
|
});
|
|
|
|
it("defaults the Paperclip Google Workspace connector off and persists an explicit toggle in both directions", async () => {
|
|
await renderPage();
|
|
const selector = 'button[aria-label="Toggle Paperclip Google Workspace connector experimental setting"]';
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe("false");
|
|
for (const enabled of [true, false]) {
|
|
await act(() => container.querySelector<HTMLButtonElement>(selector)!.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({ enableGoogleWorkspaceConnector: enabled });
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe(String(enabled));
|
|
}
|
|
});
|
|
|
|
it("defaults Combined Inbox + Task List off and persists an explicit toggle in both directions", async () => {
|
|
await renderPage();
|
|
const selector = 'button[aria-label="Toggle combined inbox and task list experimental setting"]';
|
|
expect(container.textContent).toContain("Combined Inbox + Task List");
|
|
expect(container.textContent).not.toContain("Agent Chat v2");
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe("false");
|
|
for (const enabled of [true, false]) {
|
|
await act(() => container.querySelector<HTMLButtonElement>(selector)!.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({ enableCombinedInboxTasks: enabled });
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe(String(enabled));
|
|
}
|
|
});
|
|
|
|
it("does not offer a retired MCP aggregators toggle", async () => {
|
|
await renderPage();
|
|
expect(container.querySelector('button[aria-label="Toggle MCP aggregators experimental setting"]')).toBeNull();
|
|
expect(container.textContent).not.toContain("MCP aggregators");
|
|
});
|
|
|
|
it("defaults assistant connections off and persists an explicit toggle in both directions", async () => {
|
|
await renderPage();
|
|
const selector = 'button[aria-label="Toggle assistant connections experimental setting"]';
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe("false");
|
|
expect(container.textContent).toContain("work already delegated continues");
|
|
for (const enabled of [true, false]) {
|
|
await act(() => container.querySelector<HTMLButtonElement>(selector)!.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({ enablePublicMcp: enabled });
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe(String(enabled));
|
|
expect(Boolean(container.querySelector('a[href="/BUT/apps/assistant-connection"]'))).toBe(enabled);
|
|
}
|
|
});
|
|
|
|
it("saves the personal Muse opt-in separately and names independent readiness evidence", async () => {
|
|
await renderPage();
|
|
expect(container.textContent).toContain("Muse — Personal agent");
|
|
expect(container.textContent).toContain("independent background reply");
|
|
expect(container.textContent).toContain("Provider usage and cost are unavailable");
|
|
const toggle = container.querySelector<HTMLButtonElement>('button[aria-label="Toggle Muse experimental setting"]')!;
|
|
await act(() => toggle.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({ enableMuse: true });
|
|
});
|
|
|
|
it("names Dot prerequisites and saves its opt-in independently in both directions", async () => {
|
|
await renderPage();
|
|
const selector = 'button[aria-label="Toggle OpenAI Dot experimental setting"]';
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe("false");
|
|
expect(container.textContent).toContain("Requires Assistant connections (MCP) and an authenticated instance with a public HTTPS URL");
|
|
for (const enabled of [true, false]) {
|
|
await act(() => container.querySelector<HTMLButtonElement>(selector)!.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({ enableOpenAiDot: enabled });
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe(String(enabled));
|
|
}
|
|
});
|
|
|
|
it("defaults chat connectors off and persists an explicit toggle in both directions", async () => {
|
|
await renderPage();
|
|
const selector = 'button[aria-label="Toggle chat connectors experimental setting"]';
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe("false");
|
|
expect(container.textContent).toContain("Existing chat connections keep running");
|
|
for (const enabled of [true, false]) {
|
|
await act(() => container.querySelector<HTMLButtonElement>(selector)!.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({ enableChatConnectors: enabled });
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe(String(enabled));
|
|
expect(currentExperimentalSettings.enableApps).toBe(true);
|
|
}
|
|
});
|
|
|
|
it("toggles GitHub review bots without enabling chat connectors", async () => {
|
|
await renderPage();
|
|
const selector = 'button[aria-label="Toggle GitHub review bots experimental setting"]';
|
|
expect(container.querySelector(selector)?.getAttribute("aria-checked")).toBe("false");
|
|
for (const enabled of [true, false]) {
|
|
await act(() => container.querySelector<HTMLButtonElement>(selector)!.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({ enableGitHubReviewBots: enabled });
|
|
expect(currentExperimentalSettings.enableChatConnectors).toBe(false);
|
|
}
|
|
});
|
|
|
|
it("does not render the Conference Room Chat experimental setting for now", async () => {
|
|
await renderPage();
|
|
|
|
const headings = [...container.querySelectorAll("section h2")].map((h) => h.textContent);
|
|
|
|
expect(headings).not.toContain("Pipelines");
|
|
expect(container.querySelector('button[aria-label="Toggle pipelines experimental setting"]')).toBeNull();
|
|
expect(headings).not.toContain("Conference Room Chat");
|
|
expect(container.querySelector(CONFERENCE_TOGGLE_SELECTOR)).toBeNull();
|
|
});
|
|
|
|
it("does not render the toggle even when the stored flag is currently enabled", async () => {
|
|
currentExperimentalSettings = {
|
|
...currentExperimentalSettings,
|
|
enableConferenceRoomChat: true,
|
|
};
|
|
await renderPage();
|
|
|
|
const toggle = container.querySelector(CONFERENCE_TOGGLE_SELECTOR);
|
|
expect(toggle).toBeNull();
|
|
expect(mockInstanceSettingsApi.updateExperimental).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("renders and patches the Streamlined UI experimental toggle on and off", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Streamlined UI");
|
|
expect(container.textContent).toContain(
|
|
"Use the simplified main sidebar, shared Tasks and Inbox presentation, focused task detail layout, and contextual navigation across Agents, Routines, Skills, and Settings.",
|
|
);
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(STREAMLINED_TOGGLE_SELECTOR);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
|
|
await act(() => toggle?.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({
|
|
enableStreamlinedUi: false,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(() => toggle?.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({
|
|
enableStreamlinedUi: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("does not render a Task Watchdogs toggle because watchdogs are always enabled", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).not.toContain("Task Watchdogs");
|
|
expect(container.querySelector('button[aria-label="Toggle task watchdogs experimental setting"]')).toBeNull();
|
|
});
|
|
|
|
it("does not expose the retired Runner Preview Ingress setting separately", async () => {
|
|
currentExperimentalSettings.enableRunnerPreviewIngress = true;
|
|
await renderPage();
|
|
|
|
expect(container.textContent).not.toContain("Runner Preview Ingress");
|
|
expect(container.querySelector(
|
|
'button[aria-label="Toggle runner preview ingress experimental setting"]',
|
|
)).toBeNull();
|
|
});
|
|
|
|
it("keeps Paperclip Runner default-off and exposes an explicit opt-in", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Paperclip Runner");
|
|
expect(container.textContent).toContain("First-run setup offers qualified GitHub Copilot");
|
|
const toggle = container.querySelector<HTMLButtonElement>(
|
|
PAPERCLIP_RUNNER_TOGGLE_SELECTOR,
|
|
);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableNativeRunner: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("renders and patches the Classic Task Interface experimental toggle on and off", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Classic Task Interface");
|
|
expect(container.textContent).toContain(
|
|
"Restores the previous task detail page",
|
|
);
|
|
expect(container.textContent).toContain(
|
|
"Switching takes effect immediately. No task data is affected.",
|
|
);
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(
|
|
CLASSIC_TASK_INTERFACE_TOGGLE_SELECTOR,
|
|
);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableClassicTaskInterface: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
|
|
flushSync(() => {
|
|
root?.unmount();
|
|
});
|
|
root = null;
|
|
container.textContent = "";
|
|
await renderPage();
|
|
|
|
const enabledToggle = container.querySelector<HTMLButtonElement>(
|
|
CLASSIC_TASK_INTERFACE_TOGGLE_SELECTOR,
|
|
);
|
|
expect(enabledToggle?.getAttribute("aria-checked")).toBe("true");
|
|
|
|
await act(async () => {
|
|
enabledToggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({
|
|
enableClassicTaskInterface: false,
|
|
});
|
|
});
|
|
|
|
it("saves and restores the legacy composer shortcut", async () => {
|
|
await renderPage();
|
|
const selector = 'button[aria-label="Toggle Command/Ctrl+Enter to submit"]';
|
|
const toggle = container.querySelector<HTMLButtonElement>(selector)!;
|
|
expect(toggle.getAttribute("aria-checked")).toBe("false");
|
|
await act(async () => { toggle.click(); });
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({ enableLegacyComposerSubmit: true });
|
|
|
|
flushSync(() => { root?.unmount(); });
|
|
root = null;
|
|
await renderPage();
|
|
const restored = container.querySelector<HTMLButtonElement>(selector)!;
|
|
expect(restored.getAttribute("aria-checked")).toBe("true");
|
|
await act(async () => { restored.click(); });
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({ enableLegacyComposerSubmit: false });
|
|
});
|
|
|
|
it("renders and patches the Decisions experimental toggle", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Decisions");
|
|
expect(container.textContent).toContain(
|
|
"Show the Decisions item in the main sidebar",
|
|
);
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(DECISIONS_TOGGLE_SELECTOR);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableDecisions: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("renders and patches the fast responses experimental toggle", async () => {
|
|
await renderPage();
|
|
expect(container.textContent).toContain("Experimental fast responses");
|
|
const toggle = container.querySelector<HTMLButtonElement>('[aria-label="Toggle fast responses experimental setting"]');
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
await act(async () => { toggle?.click(); });
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({ enableFastResponses: true });
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("renders and patches the Goals Sidebar Link experimental toggle", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Goals Sidebar Link");
|
|
expect(container.textContent).toContain(
|
|
"Restore the Goals item in the main sidebar while the goals surface is being evaluated.",
|
|
);
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(GOALS_SIDEBAR_LINK_TOGGLE_SELECTOR);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableGoalsSidebarLink: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("hides the isolated-workspaces-by-default toggle while isolated workspaces are off", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.querySelector(ISOLATED_WORKSPACES_TOGGLE_SELECTOR)).not.toBeNull();
|
|
expect(
|
|
container.querySelector(ISOLATED_WORKSPACES_BY_DEFAULT_TOGGLE_SELECTOR),
|
|
).toBeNull();
|
|
expect(container.textContent).not.toContain("Use Isolated Workspaces By Default");
|
|
});
|
|
|
|
it("keeps the dependent toggle hidden even when its stored flag is already on", async () => {
|
|
// The operator default is inert without isolated workspaces, so the server
|
|
// ignores a stored `true`. The control must not imply otherwise.
|
|
currentExperimentalSettings = {
|
|
...currentExperimentalSettings,
|
|
enableIsolatedWorkspaces: false,
|
|
enableIsolatedWorkspacesByDefault: true,
|
|
};
|
|
await renderPage();
|
|
|
|
expect(
|
|
container.querySelector(ISOLATED_WORKSPACES_BY_DEFAULT_TOGGLE_SELECTOR),
|
|
).toBeNull();
|
|
expect(mockInstanceSettingsApi.updateExperimental).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("renders and patches the isolated-workspaces-by-default toggle on and off", async () => {
|
|
currentExperimentalSettings = {
|
|
...currentExperimentalSettings,
|
|
enableIsolatedWorkspaces: true,
|
|
};
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Use Isolated Workspaces By Default");
|
|
expect(container.textContent).toContain("per-task worktree");
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(
|
|
ISOLATED_WORKSPACES_BY_DEFAULT_TOGGLE_SELECTOR,
|
|
);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableIsolatedWorkspacesByDefault: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenLastCalledWith({
|
|
enableIsolatedWorkspacesByDefault: false,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
});
|
|
|
|
it("reflects a stored isolated-workspaces-by-default value as checked", async () => {
|
|
currentExperimentalSettings = {
|
|
...currentExperimentalSettings,
|
|
enableIsolatedWorkspaces: true,
|
|
enableIsolatedWorkspacesByDefault: true,
|
|
};
|
|
await renderPage();
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(
|
|
ISOLATED_WORKSPACES_BY_DEFAULT_TOGGLE_SELECTOR,
|
|
);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("hides the worktree run-execution toggle when not running in a worktree", async () => {
|
|
setWorktreeRuntimeMeta(false);
|
|
await renderPage();
|
|
|
|
const headings = [...container.querySelectorAll("section h2")].map((h) => h.textContent);
|
|
expect(headings).not.toContain("Run tasks in this worktree");
|
|
expect(container.querySelector(WORKTREE_RUN_EXECUTION_TOGGLE_SELECTOR)).toBeNull();
|
|
});
|
|
|
|
it("renders and patches the worktree run-execution toggle when in a worktree", async () => {
|
|
setWorktreeRuntimeMeta(true);
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain(
|
|
"Only tasks created after enabling will run automatically",
|
|
);
|
|
expect(container.textContent).toContain("Toggling off and on resets the cutoff.");
|
|
// Off => no armed banner and no fail-closed hint.
|
|
expect(container.textContent).not.toContain("Running tasks created after");
|
|
expect(container.textContent).not.toContain("Execution is suppressed");
|
|
|
|
expect(container.textContent).toContain("Run tasks in this worktree");
|
|
expect(container.textContent).toContain(
|
|
"isolated git-worktree preview instance",
|
|
);
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(WORKTREE_RUN_EXECUTION_TOGGLE_SELECTOR);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableWorktreeRunExecution: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("shows the armed timestamp when the flag matches the current instance", async () => {
|
|
setWorktreeRuntimeMeta(true);
|
|
setWorktreeInstanceIdMeta("inst-current");
|
|
currentExperimentalSettings = {
|
|
...currentExperimentalSettings,
|
|
enableWorktreeRunExecution: true,
|
|
worktreeRunExecutionActivatedAt: "2026-07-10T18:34:00.000Z",
|
|
worktreeRunExecutionActivationInstanceId: "inst-current",
|
|
};
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Running tasks created after");
|
|
expect(container.textContent).not.toContain("Execution is suppressed");
|
|
const toggle = container.querySelector<HTMLButtonElement>(WORKTREE_RUN_EXECUTION_TOGGLE_SELECTOR);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("fails closed with a re-enable hint when the flag was armed in another instance", async () => {
|
|
setWorktreeRuntimeMeta(true);
|
|
setWorktreeInstanceIdMeta("inst-current");
|
|
currentExperimentalSettings = {
|
|
...currentExperimentalSettings,
|
|
enableWorktreeRunExecution: true,
|
|
worktreeRunExecutionActivatedAt: "2026-07-10T18:34:00.000Z",
|
|
worktreeRunExecutionActivationInstanceId: "inst-other",
|
|
};
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Execution is suppressed");
|
|
expect(container.textContent).toContain("armed in a different instance");
|
|
expect(container.textContent).toContain("Toggle it off and back on");
|
|
expect(container.textContent).not.toContain("Running tasks created after");
|
|
});
|
|
|
|
it("fails closed with a re-enable hint when the activation cutoff is missing", async () => {
|
|
setWorktreeRuntimeMeta(true);
|
|
setWorktreeInstanceIdMeta("inst-current");
|
|
currentExperimentalSettings = {
|
|
...currentExperimentalSettings,
|
|
enableWorktreeRunExecution: true,
|
|
worktreeRunExecutionActivatedAt: null,
|
|
worktreeRunExecutionActivationInstanceId: null,
|
|
};
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Execution is suppressed");
|
|
expect(container.textContent).toContain("missing its activation cutoff");
|
|
expect(container.textContent).not.toContain("Running tasks created after");
|
|
});
|
|
|
|
it("renders and patches the Built-in Agents experimental toggle", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Built-in Agents");
|
|
expect(container.textContent).toContain("Show Paperclip-managed built-in agent surfaces");
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(BUILT_IN_AGENTS_TOGGLE_SELECTOR);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableBuiltInAgents: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("renders and patches the Beta skills experimental toggle", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Beta skills");
|
|
expect(container.textContent).toContain("pin beta releases of the Paperclip core skill");
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(BETA_SKILLS_TOGGLE_SELECTOR);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableBetaSkills: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("renders and patches the Summaries experimental toggle", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Summaries");
|
|
expect(container.textContent).toContain("Show Summarizer-generated status slots");
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(SUMMARIES_TOGGLE_SELECTOR);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableSummaries: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("enables Summaries when enabling the Status Cards experimental toggle", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Status Cards");
|
|
expect(container.textContent).toContain("experimental shared status-card board");
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(STATUS_CARDS_TOGGLE_SELECTOR);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableSummaries: true,
|
|
enableStatusCards: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
expect(
|
|
container.querySelector<HTMLButtonElement>(SUMMARIES_TOGGLE_SELECTOR)?.getAttribute("aria-checked"),
|
|
).toBe("true");
|
|
});
|
|
|
|
it("disables Status Cards when disabling Summaries", async () => {
|
|
currentExperimentalSettings = {
|
|
...currentExperimentalSettings,
|
|
enableSummaries: true,
|
|
enableStatusCards: true,
|
|
};
|
|
await renderPage();
|
|
|
|
const summariesToggle = container.querySelector<HTMLButtonElement>(SUMMARIES_TOGGLE_SELECTOR);
|
|
await act(async () => {
|
|
summariesToggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableSummaries: false,
|
|
enableStatusCards: false,
|
|
});
|
|
expect(summariesToggle?.getAttribute("aria-checked")).toBe("false");
|
|
expect(
|
|
container.querySelector<HTMLButtonElement>(STATUS_CARDS_TOGGLE_SELECTOR)?.getAttribute("aria-checked"),
|
|
).toBe("false");
|
|
});
|
|
|
|
it("renders and patches the Server Info Debug View experimental toggle", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Server Info Debug View");
|
|
expect(container.textContent).toContain(
|
|
'Show a "Server" section in the account drawer with the current server restart time and running commit.',
|
|
);
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(SERVER_INFO_TOGGLE_SELECTOR);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableServerInfoDebugView: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("renders and patches Paperclip Developer Mode", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Paperclip Developer Mode");
|
|
expect(container.textContent).toContain("including Honeycomb trace queries on run pages");
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(
|
|
PAPERCLIP_DEVELOPER_MODE_TOGGLE_SELECTOR,
|
|
);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
await act(async () => {
|
|
toggle?.click();
|
|
});
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enablePaperclipDeveloperMode: true,
|
|
});
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
});
|
|
|
|
describe("InstanceExperimentalSettings — cloud-managed keys", () => {
|
|
const MANAGED_BADGE_TEXT = "Managed by Paperclip Cloud";
|
|
|
|
let container: HTMLDivElement;
|
|
let root: Root | null = null;
|
|
let queryClient: QueryClient;
|
|
|
|
async function renderPage(settings: InstanceExperimentalSettingsWithManaged) {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ ...settings });
|
|
root = createRoot(container);
|
|
queryClient = new QueryClient({
|
|
defaultOptions: { queries: { retry: false } },
|
|
});
|
|
flushSync(() => {
|
|
root!.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<MemoryRouter initialEntries={["/BUT/company/settings/instance/experimental"]}>
|
|
<InstanceExperimentalSettings />
|
|
</MemoryRouter>
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flushReact();
|
|
}
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
mockInstanceSettingsApi.updateExperimental.mockImplementation(async (patch) => ({
|
|
...defaultExperimentalSettings(),
|
|
...patch,
|
|
}));
|
|
});
|
|
|
|
afterEach(() => {
|
|
flushSync(() => {
|
|
root?.unmount();
|
|
});
|
|
root = null;
|
|
queryClient?.clear();
|
|
container.remove();
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("renders a managed key locked with the badge while unmanaged keys stay editable", async () => {
|
|
await renderPage({
|
|
...defaultExperimentalSettings(),
|
|
enableBuiltInAgents: true,
|
|
managedKeys: {
|
|
enableBuiltInAgents: { managed: true, managedBy: "paperclip-cloud" },
|
|
},
|
|
});
|
|
|
|
expect(container.textContent).toContain(MANAGED_BADGE_TEXT);
|
|
|
|
const builtInAgentsToggle = container.querySelector<HTMLButtonElement>(BUILT_IN_AGENTS_TOGGLE_SELECTOR);
|
|
expect(builtInAgentsToggle?.getAttribute("aria-checked")).toBe("true");
|
|
expect(builtInAgentsToggle?.disabled).toBe(true);
|
|
|
|
await act(() => builtInAgentsToggle?.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).not.toHaveBeenCalled();
|
|
|
|
const summariesToggle = container.querySelector<HTMLButtonElement>(SUMMARIES_TOGGLE_SELECTOR);
|
|
expect(summariesToggle?.disabled).toBe(false);
|
|
|
|
await act(() => summariesToggle?.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({
|
|
enableSummaries: true,
|
|
});
|
|
});
|
|
|
|
it("keeps a managed isolated-workspaces-by-default setting locked", async () => {
|
|
// The cloud overlay owns this key, so the tenant sees its value but cannot
|
|
// write it back and have the overlay immediately override the write.
|
|
await renderPage({
|
|
...defaultExperimentalSettings(),
|
|
enableIsolatedWorkspaces: true,
|
|
enableIsolatedWorkspacesByDefault: true,
|
|
managedKeys: {
|
|
enableIsolatedWorkspacesByDefault: { managed: true, managedBy: "paperclip-cloud" },
|
|
},
|
|
});
|
|
|
|
const toggle = container.querySelector<HTMLButtonElement>(
|
|
ISOLATED_WORKSPACES_BY_DEFAULT_TOGGLE_SELECTOR,
|
|
);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("true");
|
|
expect(toggle?.disabled).toBe(true);
|
|
expect(container.textContent).toContain(MANAGED_BADGE_TEXT);
|
|
|
|
await act(() => toggle?.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("keeps a managed chat connectors setting locked", async () => {
|
|
await renderPage({
|
|
...defaultExperimentalSettings(),
|
|
managedKeys: { enableChatConnectors: { managed: true, managedBy: "paperclip-cloud" } },
|
|
});
|
|
const toggle = container.querySelector<HTMLButtonElement>('button[aria-label="Toggle chat connectors experimental setting"]');
|
|
expect(toggle?.disabled).toBe(true);
|
|
expect(toggle?.getAttribute("aria-checked")).toBe("false");
|
|
expect(container.textContent).toContain(MANAGED_BADGE_TEXT);
|
|
await act(() => toggle?.click());
|
|
expect(mockInstanceSettingsApi.updateExperimental).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("locks Status Cards when managed Summaries is disabled", async () => {
|
|
await renderPage({
|
|
...defaultExperimentalSettings(),
|
|
managedKeys: {
|
|
enableSummaries: { managed: true, managedBy: "paperclip-cloud" },
|
|
},
|
|
});
|
|
|
|
const statusCardsToggle = container.querySelector<HTMLButtonElement>(STATUS_CARDS_TOGGLE_SELECTOR);
|
|
expect(statusCardsToggle?.disabled).toBe(true);
|
|
|
|
await act(() => statusCardsToggle?.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("locks Summaries on when managed Status Cards is enabled", async () => {
|
|
await renderPage({
|
|
...defaultExperimentalSettings(),
|
|
enableSummaries: true,
|
|
enableStatusCards: true,
|
|
managedKeys: {
|
|
enableStatusCards: { managed: true, managedBy: "paperclip-cloud" },
|
|
},
|
|
});
|
|
|
|
const summariesToggle = container.querySelector<HTMLButtonElement>(SUMMARIES_TOGGLE_SELECTOR);
|
|
expect(summariesToggle?.disabled).toBe(true);
|
|
|
|
await act(() => summariesToggle?.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("renders no managed badge and keeps toggles editable without managedKeys (self-hosted)", async () => {
|
|
await renderPage(defaultExperimentalSettings());
|
|
|
|
expect(container.textContent).not.toContain(MANAGED_BADGE_TEXT);
|
|
|
|
const builtInAgentsToggle = container.querySelector<HTMLButtonElement>(BUILT_IN_AGENTS_TOGGLE_SELECTOR);
|
|
expect(builtInAgentsToggle?.disabled).toBe(false);
|
|
|
|
await act(() => builtInAgentsToggle?.click());
|
|
await flushReact();
|
|
expect(mockInstanceSettingsApi.updateExperimental).toHaveBeenCalledWith({ enableBuiltInAgents: true });
|
|
});
|
|
});
|
|
|
|
describe("InstanceExperimentalSettings — card ordering and headings (PAP-393)", () => {
|
|
let container: HTMLDivElement;
|
|
let root: Root | null = null;
|
|
|
|
async function renderPage(settings: InstanceExperimentalSettingsWithManaged) {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ ...settings });
|
|
root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: { queries: { retry: false } },
|
|
});
|
|
flushSync(() => {
|
|
root!.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<MemoryRouter initialEntries={["/BUT/company/settings/instance/experimental"]}>
|
|
<InstanceExperimentalSettings />
|
|
</MemoryRouter>
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flushReact();
|
|
}
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
mockInstanceSettingsApi.updateExperimental.mockImplementation(async (patch) => ({
|
|
...defaultExperimentalSettings(),
|
|
...patch,
|
|
}));
|
|
});
|
|
|
|
afterEach(() => {
|
|
flushSync(() => {
|
|
root?.unmount();
|
|
});
|
|
root = null;
|
|
container.remove();
|
|
setWorktreeRuntimeMeta(false);
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("groups developer and legacy settings into sections", async () => {
|
|
setWorktreeRuntimeMeta(true);
|
|
await renderPage(defaultExperimentalSettings());
|
|
|
|
const headings = [...container.querySelectorAll("section > div > h2")].map(
|
|
(heading) => heading.textContent ?? "",
|
|
);
|
|
expect(headings).toEqual([
|
|
"Experimental features",
|
|
"Paperclip Developer Mode",
|
|
"Legacy",
|
|
]);
|
|
|
|
const sections = [...container.querySelectorAll("section")];
|
|
expect(sections.at(0)?.textContent).not.toContain("Run tasks in this worktree");
|
|
expect(sections.at(0)?.textContent).not.toContain("Managed Environment Only");
|
|
expect(sections.at(-2)?.textContent).toContain("Run tasks in this worktree");
|
|
expect(sections.at(-2)?.textContent).toContain("Managed Environment Only");
|
|
expect(sections.at(-2)?.textContent).toContain("Auto-Restart Dev Server When Idle");
|
|
expect(sections.at(-2)?.textContent).toContain("Server Info Debug View");
|
|
expect(sections.at(-2)?.textContent).toContain("Smoke Lab");
|
|
expect(sections.at(-2)?.textContent).toContain("Task Plan Decomposition");
|
|
expect(sections.at(-1)?.textContent).toContain("These features are going to be removed.");
|
|
expect(sections.at(-1)?.textContent).toContain("Classic Task Interface");
|
|
expect(sections.at(-1)?.textContent).toContain("Goals Sidebar Link");
|
|
});
|
|
|
|
it("alphabetizes cards by their displayed title within each section", async () => {
|
|
setWorktreeRuntimeMeta(true);
|
|
await renderPage({ ...defaultExperimentalSettings(), enableIsolatedWorkspaces: true });
|
|
|
|
for (const section of container.querySelectorAll("section")) {
|
|
const titles = [...section.querySelectorAll("h3")].map((heading) => heading.textContent ?? "");
|
|
expect(titles.length).toBeGreaterThan(1);
|
|
expect(titles).toEqual([...titles].sort((a, b) => a.localeCompare(b, "en", { sensitivity: "base" })));
|
|
}
|
|
});
|
|
|
|
it("renders setting cards without a background color", async () => {
|
|
await renderPage(defaultExperimentalSettings());
|
|
|
|
const cards = [...container.querySelectorAll('[data-slot="card"]')];
|
|
expect(cards.length).toBeGreaterThan(10);
|
|
expect(cards.every((card) => card.classList.contains("bg-transparent"))).toBe(true);
|
|
});
|
|
|
|
it("no longer renders an 'Experimental' secondary badge on any card", async () => {
|
|
await renderPage(defaultExperimentalSettings());
|
|
|
|
const badges = [...container.querySelectorAll('[data-slot="badge"]')].map(
|
|
(badge) => badge.textContent?.trim(),
|
|
);
|
|
expect(badges).not.toContain("Experimental");
|
|
});
|
|
});
|
|
|
|
describe("InstanceExperimentalSettings — operator-hidden cards", () => {
|
|
let container: HTMLDivElement;
|
|
let root: Root | null = null;
|
|
let queryClient: QueryClient;
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
});
|
|
|
|
afterEach(() => {
|
|
flushSync(() => root?.unmount());
|
|
root = null;
|
|
queryClient?.clear();
|
|
container.remove();
|
|
setWorktreeRuntimeMeta(false);
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
async function renderPage(
|
|
hiddenSettings?: string[],
|
|
settings: InstanceExperimentalSettingsWithManaged = defaultExperimentalSettings(),
|
|
) {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue(settings);
|
|
root = createRoot(container);
|
|
queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
queryClient.setQueryData(queryKeys.health, {
|
|
status: "ok",
|
|
...(hiddenSettings ? { hiddenSettings } : {}),
|
|
});
|
|
flushSync(() => {
|
|
root!.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<MemoryRouter initialEntries={["/BUT/company/settings/instance/experimental"]}>
|
|
<InstanceExperimentalSettings />
|
|
</MemoryRouter>
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flushReact();
|
|
}
|
|
|
|
it.each([
|
|
{ cloud: false, enabled: false },
|
|
{ cloud: false, enabled: true },
|
|
{ cloud: true, enabled: false },
|
|
{ cloud: true, enabled: true },
|
|
])("offers no AI routing control with cloud=$cloud and enabled=$enabled", async ({ cloud, enabled }) => {
|
|
await renderPage(undefined, {
|
|
...defaultExperimentalSettings(),
|
|
enableAiConnectionRouters: enabled,
|
|
...(cloud ? { managedKeys: { enableAiConnectionRouters: { managed: true, managedBy: "paperclip-cloud" as const } } } : {}),
|
|
});
|
|
|
|
expect(container.textContent).toContain("Experimental features");
|
|
expect(container.textContent).not.toContain("AI connection routers");
|
|
expect(container.querySelector('button[aria-label="Toggle AI connection routers experimental setting"]')).toBeNull();
|
|
expect(mockInstanceSettingsApi.updateExperimental).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.each([
|
|
{ enabled: false, developerMode: false }, { enabled: true, developerMode: false },
|
|
{ enabled: false, developerMode: true }, { enabled: true, developerMode: true },
|
|
])("never offers a Notebook control with enabled=$enabled and developerMode=$developerMode", async ({ enabled, developerMode }) => {
|
|
await renderPage(undefined, { ...defaultExperimentalSettings(), enablePaperclipNotebook: enabled,
|
|
enablePaperclipDeveloperMode: developerMode,
|
|
managedKeys: { enablePaperclipNotebook: { managed: true, managedBy: "paperclip-cloud" } },
|
|
});
|
|
expect(container.textContent).toContain("Experimental features");
|
|
expect(container.textContent).not.toContain("Paperclip Notebook");
|
|
expect(container.querySelector('button[aria-label="Toggle Paperclip Notebook experimental setting"]')).toBeNull();
|
|
expect(mockInstanceSettingsApi.updateExperimental).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("renders nothing for an operator-hidden toggle and keeps the rest", async () => {
|
|
await renderPage(["instance.experimental.enableEnvironments"]);
|
|
|
|
expect(container.textContent).not.toContain("Enable Environments");
|
|
expect(container.textContent).toContain("Beta skills");
|
|
expect(container.textContent).not.toContain("Show the Apps navigation");
|
|
});
|
|
|
|
it("offers no Artifacts V1 toggle", async () => {
|
|
await renderPage([]);
|
|
expect(container.textContent).toContain("Beta skills");
|
|
expect(container.textContent).not.toContain("Artifacts V1");
|
|
});
|
|
|
|
it("keeps only permitted controls in alphabetical order, including when hidden features are enabled", async () => {
|
|
setWorktreeRuntimeMeta(true);
|
|
const visible = new Set(["enableExternalObjects", "enableMemoryConnectors", "enableSimplifiedEnglishInteractions"]);
|
|
await renderPage(
|
|
INSTANCE_FEATURE_KEYS.filter((key) => !visible.has(key)).map((key) => `instance.experimental.${key}`),
|
|
{
|
|
...defaultExperimentalSettings(),
|
|
enableIsolatedWorkspaces: true,
|
|
enableIsolatedWorkspacesByDefault: true,
|
|
enablePaperclipDeveloperMode: true,
|
|
managedKeys: {
|
|
enableIsolatedWorkspacesByDefault: { managed: true, managedBy: "paperclip-cloud" },
|
|
},
|
|
},
|
|
);
|
|
|
|
expect([...container.querySelectorAll("h3")].map((heading) => heading.textContent)).toEqual([
|
|
"Enable External Objects",
|
|
"Memory connectors",
|
|
"Simplified English Interactions",
|
|
]);
|
|
expect([...container.querySelectorAll("section h2")].map((heading) => heading.textContent)).toEqual([
|
|
"Experimental features",
|
|
]);
|
|
expect(container.querySelectorAll('button[role="switch"]')).toHaveLength(3);
|
|
expect(mockInstanceSettingsApi.updateExperimental).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("retains a section when one of its controls is visible", async () => {
|
|
const visible = new Set(["enablePaperclipDeveloperMode", "enableGoalsSidebarLink"]);
|
|
await renderPage(INSTANCE_FEATURE_KEYS.filter((key) => !visible.has(key)).map((key) => `instance.experimental.${key}`));
|
|
expect(container.querySelector('[aria-labelledby="developer-mode-heading"] h3')?.textContent).toBe("Paperclip Developer Mode");
|
|
expect(container.querySelector('[aria-labelledby="legacy-heading"] h3')?.textContent).toBe("Goals Sidebar Link");
|
|
});
|
|
|
|
it("shows every toggle when nothing is hidden", async () => {
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Enable Environments");
|
|
expect(container.textContent).toContain("Beta skills");
|
|
});
|
|
});
|
|
|
|
describe("InstanceExperimentalSettings — read resilience", () => {
|
|
let container: HTMLDivElement;
|
|
let root: Root | null = null;
|
|
let queryClient: QueryClient;
|
|
|
|
async function renderPage() {
|
|
root = createRoot(container);
|
|
queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
flushSync(() => {
|
|
root!.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<MemoryRouter initialEntries={["/BUT/company/settings/instance/experimental"]}>
|
|
<InstanceExperimentalSettings />
|
|
</MemoryRouter>
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flushReact();
|
|
}
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue(defaultExperimentalSettings());
|
|
});
|
|
|
|
afterEach(() => {
|
|
flushSync(() => {
|
|
root?.unmount();
|
|
});
|
|
root = null;
|
|
queryClient.clear();
|
|
container.remove();
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("keeps loaded toggles on screen when a refetch fails transiently", async () => {
|
|
await renderPage();
|
|
expect(container.textContent).toContain("Enable Environments");
|
|
|
|
mockInstanceSettingsApi.getExperimental.mockRejectedValue(
|
|
new ApiError("Paperclip is restarting.", 503, { error: "tenant_app_unavailable" }),
|
|
);
|
|
await queryClient.invalidateQueries({ queryKey: queryKeys.instance.experimentalSettings });
|
|
await flushReact();
|
|
|
|
expect(mockInstanceSettingsApi.getExperimental).toHaveBeenCalledTimes(2);
|
|
expect(queryClient.getQueryState(queryKeys.instance.experimentalSettings)?.status).toBe("error");
|
|
expect(container.textContent).toContain("Enable Environments");
|
|
expect(container.querySelector('[data-query-view="error"]')).toBeNull();
|
|
expect(container.textContent).not.toContain("Paperclip is restarting.");
|
|
expect(container.textContent).not.toContain("tenant_app_unavailable");
|
|
});
|
|
|
|
it("shows readable copy and a Retry button when settings fail to load", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockRejectedValueOnce(new ApiError("Boom", 500, { error: "Boom" }));
|
|
await renderPage();
|
|
|
|
expect(container.textContent).toContain("Couldn't load experimental settings");
|
|
expect(container.querySelector('[data-query-view="error"]')).not.toBeNull();
|
|
expect(container.textContent).not.toContain("Enable Environments");
|
|
|
|
const retryButton = [...container.querySelectorAll("button")].find(
|
|
(button) => button.textContent?.trim() === "Retry",
|
|
);
|
|
expect(retryButton).toBeDefined();
|
|
await act(() => retryButton!.click());
|
|
await flushReact();
|
|
|
|
expect(container.textContent).toContain("Enable Environments");
|
|
expect(container.querySelector('[data-query-view="error"]')).toBeNull();
|
|
});
|
|
});
|