mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-09 16:02:36 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Coordinator gives people navigation for conversations, tasks, and decisions. > - The decision entry is called Needs you, while a separate Inbox remains under More. > - Coordinator's personal task filter does not retain the full behavior of the original Mine view. > - This pull request names the decision entry Inbox and hosts the original personal work views inside Tasks. > - People keep their triage tools and saved choices without moving between two task destinations. ## Linked Issues or Issue Description **What existing behavior does this improve?** Coordinator navigation and the personal Mine view in Tasks. **Subsystem affected** UI navigation, task view routing, task collection preferences, and browser coverage. **Current behavior** Needs you opens the decision feed. More contains another Inbox destination. The default Coordinator task filter matches task creators and assignees. It does not use the full personal participation rules, archive behavior, shortcuts, grouping, or saved columns of the original Mine view. The organization task table also resets its column choices on reload. **Proposed behavior** Inbox opens the same decision feed with the inbox icon. Tasks defaults to Mine and remembers a person's selected view per company. Mine uses the existing personal Inbox implementation and preferences. It retains read/unread title weights, keyboard navigation, read/unread shortcuts, archive and undo, mobile swipe-to-archive, grouping, and saved columns. Old Inbox links open the matching task view. The organization task table saves its columns and order per person and company. **Reason and benefit** People get Chat, Tasks, and Inbox as distinct navigation entries. Personal work remains a view within Tasks without losing the existing triage behavior. **Breaking changes** Coordinator no longer offers the previous Inbox destination under More. Old Inbox URLs redirect into Tasks and retain query parameters and fragments. The Needs you label becomes Inbox; its decision feed, count, history, and resolution paths stay in place. Classic retains its separate optional combined-list setting. **Additional context** Refs: #19360, the workspace-defaults PR now integrated from master. Refs: #10620, related Inbox attention ordering. Duplicate searches found no open PR for this navigation and Mine integration. Roadmap review found no separate new execution feature in this scope. ## What Changed - Rename Coordinator's desktop and mobile decision entry and page to Inbox. Use the inbox icon. Remove the old Inbox item under More. Clarify that the combined-list experiment applies only to Classic. - Add one Coordinator task-view router. Host Mine, Unread, Recent, Blocked, and Everything through the existing Inbox owner. Keep organization views in the task table and board. Normalize legacy filtered URLs before mounting a collection so clearing the last filter preserves the current layout and local filters. - Reuse the existing Mine API, participation, read state, archive cache, undo, keyboard, mobile gesture, grouping, and preference paths. Existing personal column choices carry over. - Save organization task-table columns and order per person and company. Keep controls usable if browser storage fails. - Update navigation tests, routing and persistence regressions, exact-run retry browser coverage for each workspace variant, product documentation, and the affected Storybook notes. Keep existing story IDs. ## Verification - Preference, routing, navigation, task table, and inherited Inbox regression tests pass in focused runs. After integrating master and addressing the review finding, all 187 focused tests, UI typecheck, and token gates pass. - Full build and repository typecheck pass after integrating master. The full UI suite previously passed: 894 files, 11,169 tests passed, and one skipped. All 14 desktop/mobile triage and exact-run retry browser cases, including a fresh production UI build, pass after integrating master. - The full repository test suite was not run locally for this UI-only change; full PR CI is running. - Browser checks use a fresh isolated local instance and a deterministic process agent for real run-attributed unread activity. They exercise legacy URLs, title weights, saved grouping and columns, read/unread shortcuts, archive/undo, and a real mobile touch gesture. - Earlier browser fixtures were corrected: own activity is read, agent comments need valid run attribution, and undo uses `u` after the archive refresh completes. The Inbox content heading is scoped separately from the layout heading. - The final settings wording correction passes all 63 settings tests. - The [next CI browser run](https://github.com/paperclipai/paperclip/actions/runs/42137377960/job/127629100535) caught an old URL assertion for denied run retries. The test now pins each workspace variant and covers Coordinator Tasks explicitly. The old expectation fails deterministically for Coordinator; all 12 retry cases pass with the corrected destination, preserving exact run identity and truthful queued, deferred, and denied feedback. - Token gates, map checks, and Storybook catalog checks pass. All 30 map/catalog script tests pass. Storybook play tests were not run. - Greptile reviewed [the final commit](https://github.com/paperclipai/paperclip/commit/5f2f3789b83af259f694f379afb769465688fb72) at **5/5** with no new actionable findings. Its sort-only link finding is fixed and resolved: three cases fail before the fix and pass after it. `sortField` and `sortDir` keep organization links on the organization table. [Current-head CI](https://github.com/paperclipai/paperclip/actions/runs/42139668774) is running. - [CI exposed a routing race](https://github.com/paperclipai/paperclip/actions/runs/42135293421/job/127621981587) when removing the last label from a legacy Everything link. Four deterministic regressions failed before the fix and now pass: collections only mount after URL normalization. The existing end-to-end component cases confirm local filters, board layout, fragments, and history survive the change. - The [initial server shard 4 run](https://github.com/paperclipai/paperclip/actions/runs/42131163087/job/127608751620) failed an unchanged monitor-drain idleness assertion: two active operations remained instead of zero. The complete scheduling suite passes locally (54 tests). One isolated CI retry passed, including its dependent verification gate. The original timing failure's root cause is not established. ## Risks - Mine includes the existing tasks, approvals, failed runs, and join requests, preserving the original personal participation and attention rules. - Shared URLs with organization filters or table sort parameters still open the organization task collection. Task back-links retain their original fragments. - Saved preferences are browser-local. Mine keeps its existing storage keys; the organization table and selected Coordinator view use person/company scopes. - No database or server API contract changes are included. Existing company access, personal participation, and decision permissions retain their owners. ## Model Used OpenAI Codex, based on GPT-6, with reasoning, repository tools, code execution, and browser automation. The exact serving revision and context-window size are not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Scott Tong <scott@scottsmbpm5max.lan> Co-authored-by: Paperclip <noreply@paperclip.ing>
171 lines
9.8 KiB
TypeScript
171 lines
9.8 KiB
TypeScript
import { expect, test } from "@playwright/test";
|
|
import { collectionFixture, coordinatorPreference, type CollectionFixture } from "./fixture";
|
|
|
|
let fixture: CollectionFixture;
|
|
let otherCompanyId: string;
|
|
test.beforeAll(async ({ request }) => {
|
|
fixture = await collectionFixture(request);
|
|
expect(fixture.otherCompanyId).toBeTruthy();
|
|
otherCompanyId = fixture.otherCompanyId!;
|
|
});
|
|
|
|
test("repeated fixture setup retains both companies without growing the instance", async ({ request }) => {
|
|
const before = await (await request.get("/api/companies")).json();
|
|
const again = await collectionFixture(request);
|
|
const after = await (await request.get("/api/companies")).json();
|
|
expect(again.company.id).toBe(fixture.company.id);
|
|
expect(again.otherCompanyId).toBe(otherCompanyId);
|
|
expect(after.map((company: { id: string }) => company.id).sort()).toEqual(before.map((company: { id: string }) => company.id).sort());
|
|
});
|
|
for (const route of ["issues", "inbox/mine"]) test(`${route} leaves task-detail code out of collection startup`, async ({ page }) => {
|
|
await coordinatorPreference(page);
|
|
await page.addInitScript(id => localStorage.setItem("paperclip.selectedCompanyId", id), otherCompanyId);
|
|
const detailReads: string[] = [];
|
|
const companyReads: string[] = [];
|
|
page.on("request", request => {
|
|
if (/\/assets\/issue-detail-[^/]+\.js$/.test(request.url())) detailReads.push(request.url());
|
|
const companyId = new URL(request.url()).pathname.match(/^\/api\/companies\/([^/]+)\//)?.[1];
|
|
if (companyId) companyReads.push(companyId);
|
|
});
|
|
let release!: () => void;
|
|
const held = new Promise<void>(resolve => { release = resolve; });
|
|
const isCollectionSource = (url: URL) => route === "inbox/mine"
|
|
? url.pathname === `/api/companies/${fixture.company.id}/inbox/mine`
|
|
: url.pathname === `/api/companies/${fixture.company.id}/issues` && url.searchParams.get("view") === "index";
|
|
await page.route(isCollectionSource, async request => { await held; await request.continue(); });
|
|
const sourceRequest = page.waitForRequest(request => isCollectionSource(new URL(request.url())));
|
|
const warmed = page.waitForResponse(response => /\/assets\/issue-detail-[^/]+\.js$/.test(response.url()));
|
|
try {
|
|
await page.goto(`/${fixture.company.issuePrefix}/${route}`);
|
|
await sourceRequest;
|
|
expect(detailReads).toEqual([]);
|
|
await expect(page.getByRole("main").locator("[data-inbox-issue-link]")).toHaveCount(0);
|
|
} finally { release(); }
|
|
const first = page.getByRole("main").locator("[data-inbox-issue-link]").first();
|
|
await expect(first).toBeVisible();
|
|
const node = await first.elementHandle();
|
|
const before = await first.boundingBox();
|
|
await (await warmed).finished();
|
|
const after = await first.boundingBox();
|
|
expect(await node!.evaluate(element => element.isConnected)).toBe(true);
|
|
expect(Math.abs(before!.y - after!.y)).toBeLessThan(1);
|
|
expect(Math.abs(before!.height - after!.height)).toBeLessThan(1);
|
|
expect(new Set(companyReads)).toEqual(new Set([fixture.company.id]));
|
|
await first.focus();
|
|
await first.press("Enter");
|
|
await expect(page.getByTestId("task-chat-thread").locator(':scope > [aria-busy="false"]')).toBeVisible();
|
|
await expect(page.getByTestId("issue-detail-header")).toBeVisible();
|
|
await expect(page.getByTestId("task-chat-composer-stack").locator('[contenteditable="true"]')).toBeEditable();
|
|
});
|
|
|
|
for (const mobile of [false, true]) test(`Tasks use a bounded render and a shared count on ${mobile ? "mobile" : "desktop"}`, async ({ page }) => {
|
|
if (mobile) await page.setViewportSize({ width: 390, height: 844 });
|
|
await coordinatorPreference(page);
|
|
const reads: string[] = [];
|
|
page.on("request", request => { if (request.url().includes("/api/")) reads.push(request.url()); });
|
|
await page.goto(`/${fixture.company.issuePrefix}/issues`);
|
|
const rows = page.locator('[data-slot="task-row"][data-issue-id]');
|
|
await expect(rows).toHaveCount(100);
|
|
await expect(page.getByText("Rendering 100 of 200 tasks")).toBeVisible();
|
|
await expect.poll(() => reads.filter(url => url.includes("/attention/summary")).length).toBe(1);
|
|
expect(reads.filter(url => /\/attention\?/.test(url))).toEqual([]);
|
|
const first = await rows.first().elementHandle();
|
|
const before = await rows.first().boundingBox();
|
|
// Reaching the sentinel loads the next batch before a button click is needed.
|
|
await page.getByRole("button", { name: "Show more tasks", exact: true }).scrollIntoViewIfNeeded();
|
|
await expect(rows).toHaveCount(200);
|
|
expect(await first!.evaluate(node => node.isConnected)).toBe(true);
|
|
await rows.first().scrollIntoViewIfNeeded();
|
|
const after = await rows.first().boundingBox();
|
|
expect(Math.abs(before!.height - after!.height)).toBeLessThan(1);
|
|
await page.screenshot({ path: test.info().outputPath("tasks.png") });
|
|
});
|
|
|
|
test("a failed speculative preload keeps the collection usable and permits task navigation", async ({ page }) => {
|
|
await coordinatorPreference(page);
|
|
let navigations = 0;
|
|
page.on("request", request => { if (request.isNavigationRequest() && request.frame() === page.mainFrame()) navigations++; });
|
|
const pattern = /\/assets\/issue-detail-[^/]+\.js$/;
|
|
await page.route(pattern, route => route.abort("failed"));
|
|
const failure = page.waitForEvent("requestfailed", request => pattern.test(request.url()));
|
|
await page.goto(`/${fixture.company.issuePrefix}/issues`);
|
|
const first = page.getByRole("main").locator("[data-inbox-issue-link]").first();
|
|
await expect(first).toBeVisible();
|
|
await first.focus();
|
|
await failure;
|
|
await expect(page.getByRole("textbox", { name: "Search tasks", exact: true })).toBeEditable();
|
|
expect(navigations).toBe(1);
|
|
await page.unroute(pattern);
|
|
await first.press("Enter");
|
|
await expect(page.getByTestId("task-chat-composer-stack").locator('[contenteditable="true"]')).toBeEditable();
|
|
expect(navigations).toBe(1);
|
|
});
|
|
|
|
test("direct task opens preload their code while identity is still loading", async ({ page }) => {
|
|
await coordinatorPreference(page);
|
|
let release!: () => void;
|
|
const held = new Promise<void>(resolve => { release = resolve; });
|
|
await page.route("**/api/auth/get-session", async route => { await held; await route.continue(); });
|
|
try {
|
|
const detailRequest = page.waitForRequest(request => /\/assets\/issue-detail-[^/]+\.js$/.test(request.url()));
|
|
await page.goto(`/${fixture.company.issuePrefix}/issues/${fixture.taskIds[0]}`);
|
|
await detailRequest;
|
|
} finally { release(); }
|
|
await expect(page.getByTestId("task-chat-composer-stack").locator('[contenteditable="true"]')).toBeEditable();
|
|
});
|
|
|
|
test("Coordinator Inbox retains aggregate Mine reads when Streamlined UI is disabled", async ({ page }) => {
|
|
await coordinatorPreference(page, false);
|
|
const reads: URL[] = [];
|
|
page.on("request", request => { if (request.url().includes("/api/")) reads.push(new URL(request.url())); });
|
|
await page.goto(`/${fixture.company.issuePrefix}/inbox/mine`);
|
|
await expect(page.locator("[data-inbox-issue-link]").first()).toBeVisible();
|
|
expect(reads.filter(url => url.pathname === `/api/companies/${fixture.company.id}/inbox/mine`)).toHaveLength(1);
|
|
expect(reads.filter(url => /\/companies\/[^/]+\/issues$/.test(url.pathname) && url.searchParams.get("view") !== "rows")).toEqual([]);
|
|
expect(reads.filter(url => url.pathname.endsWith("/dashboard"))).toEqual([]);
|
|
expect(reads.filter(url => url.pathname.endsWith("/attention") && url.searchParams.get("all") === "true")).toEqual([]);
|
|
});
|
|
|
|
test("Inbox owns one complete feed and no redundant summary read", async ({ page }) => {
|
|
await coordinatorPreference(page);
|
|
const reads: URL[] = [];
|
|
page.on("request", request => { if (request.url().includes("/api/")) reads.push(new URL(request.url())); });
|
|
await page.goto(`/${fixture.company.issuePrefix}/decisions`);
|
|
await expect(page.getByRole("main").getByRole("heading", { name: "Inbox", exact: true })).toBeVisible();
|
|
await expect.poll(() => reads.filter(url => url.pathname.endsWith("/attention") && url.searchParams.get("all") === "true").length).toBe(1);
|
|
expect(reads.filter(url => url.pathname.endsWith("/attention/summary"))).toEqual([]);
|
|
});
|
|
|
|
test("Needs attention reads task membership without downloading decision cards", async ({ page }) => {
|
|
await coordinatorPreference(page);
|
|
const reads: URL[] = [];
|
|
page.on("request", request => { if (request.url().includes("/api/")) reads.push(new URL(request.url())); });
|
|
await page.goto(`/${fixture.company.issuePrefix}/issues?view=needs_attention`);
|
|
await expect(page.getByText("No tasks need a decision.", { exact: true })).toBeVisible();
|
|
expect(reads.filter(url => url.pathname.endsWith("/attention/tasks"))).toHaveLength(1);
|
|
expect(reads.filter(url => url.pathname.endsWith("/attention/summary"))).toEqual([]);
|
|
expect(reads.filter(url => url.pathname.endsWith("/attention") && url.searchParams.get("all") === "true")).toEqual([]);
|
|
});
|
|
|
|
test("older pages and Back keep revealed task rows and the reading position", async ({ page }) => {
|
|
await coordinatorPreference(page);
|
|
await page.goto(`/${fixture.company.issuePrefix}/issues`);
|
|
const rows = page.locator('[data-slot="task-row"][data-issue-id]');
|
|
await expect(rows).toHaveCount(100);
|
|
const loadPage = page.getByRole("button", { name: "Load more tasks", exact: true });
|
|
await loadPage.scrollIntoViewIfNeeded();
|
|
await expect(rows).toHaveCount(200);
|
|
const retained = await rows.last().elementHandle();
|
|
await loadPage.click();
|
|
await expect(rows).toHaveCount(220);
|
|
expect(await retained!.evaluate(node => node.isConnected)).toBe(true);
|
|
await rows.last().scrollIntoViewIfNeeded();
|
|
const before = await rows.last().boundingBox();
|
|
await rows.last().locator("[data-inbox-issue-link]").click();
|
|
await expect(page.getByTestId("issue-detail-header")).toBeVisible();
|
|
await page.goBack();
|
|
await expect(rows).toHaveCount(220);
|
|
const after = await rows.last().boundingBox();
|
|
expect(Math.abs(before!.y - after!.y)).toBeLessThan(2);
|
|
});
|