mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-06 10:48:12 +02:00
## Thinking Path > - Paperclip manages AI agents that perform work. > - Paperclip Runner connects durable task runs to local provider processes. > - The full-stack paid matrix exposed failures after the runner integrity repair. > - Verified JavaScript entrypoints lost their relative module graph when Linux executed them through descriptor paths. > - Returned provider startup errors also remained pending and became indeterminate after recovery. > - Sparse Codex tool lifecycle events lost the `write_document` identity before task transcript projection. > - This pull request repairs those three boundaries and makes the structured-question fixture deterministic. > - The benefit is repeatable provider startup, exact failure replay, and correct inline Plan placement. ## Linked Issues or Issue Description Refs #12721 and #12700. **What happened?** The paid runner matrix failed ACPX and OpenCode startup before provider session creation. The runner journal then replaced the original startup error with an indeterminate recovery result. Native Codex saved a Plan but rendered it only as a fallback card. A legacy Claude waiting reply could also echo the reserved terminal marker before the answer arrived. **Expected behavior** Verified JavaScript providers must start from immutable descriptor-backed artifacts. Returned startup failures must persist as terminal failed command results. Native tool lifecycle updates must preserve the `write_document` boundary. Pre-answer fixture output must not contain the reserved terminal marker. **Steps to reproduce** 1. Run the local provider cells in the Runner Full-Stack E2E workflow. 2. Observe ACPX and OpenCode fail during `session.open` before provider execution. 3. Observe recovery report `execution_indeterminate` instead of the original startup error. 4. Run the native Codex Plan cell and observe the fallback Plan card after the tool activity row. 5. Run the legacy Claude structured-question resume cell and observe an early marker echo in waiting prose. **Paperclip version or commit** `0f9452101740835ce0b1488a204bf48acd5bafc3` **Deployment mode** Local development with the paid GitHub Actions acceptance workflow. ## What Changed - Bundle the ACPX sidecar and OpenCode proxy as self-contained Node ESM entrypoints before hashing and verified descriptor launch. - Anchor ACPX dynamic provider package resolution at a controller-derived provider-pack root and keep that root out of the provider child environment. - Persist executor-returned startup errors as redacted durable failed command results while retaining indeterminate recovery for true process death. - Coalesce sparse native tool items by stable ID so a late `write_document` name, input, and result reach the transcript boundary once. - Forbid the structured-question fixture from spelling or announcing its reserved terminal marker before the user answers. ## Verification - Rust and TypeScript regression tests cover durable failed replay, true crash ambiguity, bundle closure, package-root derivation, environment filtering, exact Codex tool lifecycle coalescing, and prompt determinism. - Local execution is intentionally limited to formatters and static diff checks. GitHub Actions will run tests, type checks, builds, and security checks. - After ordinary CI is green, scoped paid cells will validate one ACPX launch, one OpenCode launch, native Codex Plan projection, and legacy Claude structured resume before a complete matrix rerun. - Prior failing matrix: https://github.com/paperclipai/paperclip/actions/runs/33682434315 ## Risks - Bundling changes the bytes covered by provider launch hashes. Provider-pack generation already hashes the final built files. - ACPX still loads qualified provider packages dynamically. The controller supplies a normalized package root, while existing version, digest, path, and descriptor checks remain active. - Durable `failed` is terminal. Replays return the same redacted result and do not execute the provider effect twice. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex based on GPT-5 with agentic reasoning, repository inspection, code editing, Git, parallel subagents, and GitHub Actions coordination. The exact deployed snapshot and context-window size are not exposed to this task. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either linked related public work or described the bug in this PR - [x] I have not referenced internal or instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal ticket id - [ ] I have run tests locally and they pass (intentionally deferred to GitHub Actions) - [x] I have added or updated tests where applicable - [x] No documentation change is required for this runtime repair - [x] I have considered and documented the risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
89 lines
3.1 KiB
TypeScript
89 lines
3.1 KiB
TypeScript
import path from "node:path";
|
|
import { defineConfig } from "@playwright/test";
|
|
import { runnerE2EWebServerCommand } from "./web-server-command.js";
|
|
|
|
function required(name: string) {
|
|
const value = process.env[name]?.trim();
|
|
if (!value) throw new Error(`${name} is required`);
|
|
return value;
|
|
}
|
|
|
|
const port = Number(required("PAPERCLIP_RUNNER_E2E_PORT"));
|
|
const temporaryRoot = required("PAPERCLIP_RUNNER_E2E_TEMP_ROOT");
|
|
const privateDir = required("PAPERCLIP_RUNNER_E2E_PRIVATE_DIR");
|
|
const paperclipHome = required("PAPERCLIP_HOME");
|
|
const configPath = required("PAPERCLIP_CONFIG");
|
|
const baseURL = `http://127.0.0.1:${port}`;
|
|
const playwrightChannel = process.env.PAPERCLIP_PLAYWRIGHT_CHANNEL?.trim();
|
|
const chromiumExecutable =
|
|
process.env.PAPERCLIP_RUNNER_E2E_CHROMIUM_EXECUTABLE?.trim();
|
|
if (playwrightChannel && chromiumExecutable) {
|
|
throw new Error(
|
|
"PAPERCLIP_PLAYWRIGHT_CHANNEL and PAPERCLIP_RUNNER_E2E_CHROMIUM_EXECUTABLE are mutually exclusive",
|
|
);
|
|
}
|
|
if (chromiumExecutable && !path.isAbsolute(chromiumExecutable)) {
|
|
throw new Error(
|
|
"PAPERCLIP_RUNNER_E2E_CHROMIUM_EXECUTABLE must be an absolute path",
|
|
);
|
|
}
|
|
required("PAPERCLIP_INSTANCE_ID");
|
|
required("PAPERCLIP_AGENT_JWT_SECRET");
|
|
required("PAPERCLIP_DECISION_SIGNING_SECRET");
|
|
required("PAPERCLIP_TOOL_ACTION_SIGNING_SECRET");
|
|
required("BETTER_AUTH_SECRET");
|
|
if (
|
|
!paperclipHome.startsWith(`${temporaryRoot}${path.sep}`) ||
|
|
!configPath.startsWith(`${temporaryRoot}${path.sep}`)
|
|
) {
|
|
throw new Error("Paperclip server paths escape the isolated temporary root");
|
|
}
|
|
const repositoryRoot = path.resolve(import.meta.dirname, "../..");
|
|
|
|
export default defineConfig({
|
|
testDir: ".",
|
|
testMatch: "runner.spec.ts",
|
|
timeout: Number(process.env.PAPERCLIP_RUNNER_E2E_TEST_TIMEOUT_MS ?? 600_000),
|
|
expect: { timeout: 30_000 },
|
|
fullyParallel: false,
|
|
workers: 1,
|
|
retries: 0,
|
|
use: {
|
|
baseURL,
|
|
browserName: "chromium",
|
|
...(playwrightChannel ? { channel: playwrightChannel } : {}),
|
|
...(chromiumExecutable
|
|
? { launchOptions: { executablePath: chromiumExecutable } }
|
|
: {}),
|
|
headless: true,
|
|
actionTimeout: 30_000,
|
|
navigationTimeout: 30_000,
|
|
screenshot: "only-on-failure",
|
|
trace: "retain-on-failure",
|
|
// A developer-supplied system Chromium keeps the local smoke loop
|
|
// installation-free; CI's managed browser retains failure video as usual.
|
|
video: chromiumExecutable ? "off" : "retain-on-failure",
|
|
},
|
|
webServer: {
|
|
// Do not put an env object here: Playwright serializes webServer config in
|
|
// blob reports. The wrapper inherits the test process and strips provider
|
|
// keys before spawning the real Paperclip process.
|
|
command: runnerE2EWebServerCommand(repositoryRoot),
|
|
url: `${baseURL}/api/health`,
|
|
reuseExistingServer: false,
|
|
timeout: 180_000,
|
|
stdout: "pipe",
|
|
stderr: "pipe",
|
|
},
|
|
outputDir: path.join(privateDir, "playwright-output"),
|
|
reporter: [
|
|
["list"],
|
|
["blob", { outputDir: path.join(privateDir, "blob-report") }],
|
|
["junit", { outputFile: path.join(privateDir, "junit.xml") }],
|
|
[
|
|
"html",
|
|
{ open: "never", outputFolder: path.join(privateDir, "html-report") },
|
|
],
|
|
],
|
|
});
|