mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-30 21:49:18 +01:00
## Thinking Path > - Paperclip's board should open a task quickly while keeping its conversation and composer stable. > - The browser currently downloads unrelated screens and unopened dialog implementations before task content appears. > - Splitting routes alone creates many shared requests and did not improve measured cold loading. > - This change groups the startup and task dependency trees, preloads the task chunk, and defers optional routes and dialogs. > - Existing coordinated history reveal stays intact so late data does not insert content above the reader. > - Hidden routes must not overwrite saved scroll positions with zero-height geometry. > - Repeated browser measurements and delayed-response tests establish the result independently of bundle-file size. ## Linked Issues or Issue Description Refs #14758. Related prior work: #10463 and #14727. **What existing behavior does this improve?** Cold task-page opening downloads and evaluates code for other screens and globally mounted, unopened dialogs. A direct task link should reach its saved conversation sooner without moving already-visible messages or the composer. **Subsystem affected** Board UI startup, route boundaries, dialog loading, task scroll restoration, and the issue-detail performance harness. **Proposed behavior** Load optional screens and dialogs when needed, keep startup requests bounded, and preload the task route. Preserve the current history reveal policy. Keep the shell mounted during route loading and preserve the reader's position when a route is temporarily hidden. **Additional context** The older bundle-splitting attempt in #10463 is still open from August. This implementation targets current master and deliberately preserves today's editor, composer, and transcript reveal behavior. It does not implement the alternative transcript-row design discussed in #14758. ROADMAP.md does not describe overlapping startup-bundle work. ## What Changed - Lazy-load board routes, standalone screens, the legacy layout, onboarding, and unopened create dialogs. - Keep activated dialogs mounted across close/reopen to retain their existing draft lifecycle. - Group startup and issue dependencies and preload the emitted issue chunk from the production HTML. - Contain route loading within the shell and retain existing chunk-error recovery. - Contain dialog import failures locally, support cancellation, and keep setup dismissed after a late download. Warm the task module from task lists and keep the small chat redirect eager. - Wait for task-creation dialog fields in the browser fixture before filling an explicit title. - Ignore zero-height scroll geometry while a route is hidden. - Reuse the same persisted performance fixture between builds, record actual network spans, and distinguish concealed loading content from the ready thread in browser assertions. ## Verification - Production UI build and UI TypeScript check passed. - Recovery follow-up: 74 focused UI tests passed; the cancellation change passed 23 focused tests plus all 131 onboarding tests (the latter with a 15-second per-test timeout on the contended local host). - Setup cancellation was reproduced against the prior production build and verified fixed after releasing the held real wizard download. - 91 focused UI tests passed; the final route registrations were checked again after making standalone screens lazy (33 routing tests passed). - All eight real-browser layout scenarios passed: delayed comments, late media, properties changes, growing drafts, older history, Back navigation, deep links, desktop/mobile same-task links, request failure/retry, and stalled native/log reads. - Browser walkthrough: read a populated task, submit one reply, refresh, navigate to Projects, and return. The reply persisted once and the normal composer remained usable. - Token design gates passed. The separate repository-wide publish-token scan fails on pre-existing references to the local maintainer username in unchanged files; this change adds none. - Production-build measurements use the same persisted task, local API/database, fresh browser contexts for cold opens, and five samples per scenario/profile. These measurements do not establish deployed staging latency. - Final head `076466816a`, consecutive before/after production builds: five samples per scenario/profile, same saved task and server. Cold Fast 4G/4x CPU content paint: **5,775 → 4,248 ms (26%)**; issue API server timing was 23 ms in both sets. Warm Fast 4G: 989 → 971 ms. JavaScript transferred before content: **2,596 → 1,722 KiB (34%)**. - Unthrottled cold content paint: 1,306 → 676 ms; warm: 269 → 224 ms. These local timings vary with host load. Earlier measurements showed about 20% cold improvement, and a contended intermediate run had substantially higher API latency; those runs are retained in the local evidence. The final matched pair meets the proposed 25% target, but it does not establish a guaranteed 25% improvement across environments. - All four browser scenarios that failed on the first CI run passed locally after the readiness fixes; the subsequent CI run passed all eight browser shards. - Fault-injection browser checks: delayed route loading preserves shell geometry; a failed route recovers through Back; cancelled or failed dialog loading preserves an unsent reply; Back dismisses pending setup and contains its late failure. - Final head `076466816a`: all CI gates green (55 successful checks, no pending or failed checks); Greptile 5/5 with no actionable findings and all review threads resolved. ## Risks - Dynamic chunks add a loading state on first entry to optional screens and dialogs. Route failures use the existing error boundary. Optional dialog failures are dismissible without unmounting the board; retrying a rejected import requires a reload. - The task preload prioritizes the primary board journey, including when another screen is opened first. - Chunk grouping should be revisited when the dependency graph changes; bundle size alone does not establish a speedup. - No API, authorization, migration, editor semantics, or transcript-reveal policy changes. ## Model Used OpenAI Codex, GPT-6, with reasoning, repository tools, code execution, and browser verification. The runtime does not expose a more precise model identifier or context-window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
306 lines
12 KiB
TypeScript
306 lines
12 KiB
TypeScript
import { useCallback, useEffect, useLayoutEffect, useRef, useState, type ReactNode } from "react";
|
|
import { readThreadScrollAnchor, threadScrollAnchorDelta, type ThreadScrollAnchor } from "./scroll-anchor";
|
|
import { cn } from "@/lib/utils";
|
|
import { useStreamlinedTaskChatPresentation } from "./presentation-mode";
|
|
import { ArrowDown } from "lucide-react";
|
|
import { parseCssTimeMs } from "./motion-tokens";
|
|
import { useTaskChatScrollNavigation } from "./scroll-navigation";
|
|
|
|
const PIN_THRESHOLD_PX = 48;
|
|
|
|
/** Visibility lifecycle of the scroll-to-latest pill. */
|
|
type PillPhase = "hidden" | "in" | "out";
|
|
|
|
/**
|
|
* True when animations are disabled (prefers-reduced-motion, or environments
|
|
* without matchMedia such as jsdom). In that case the pill's exit animation
|
|
* never fires animationend, so we must unmount immediately.
|
|
*/
|
|
function motionDisabled(): boolean {
|
|
if (typeof window === "undefined" || typeof window.matchMedia !== "function") return true;
|
|
return window.matchMedia("(prefers-reduced-motion: reduce)").matches;
|
|
}
|
|
|
|
interface TaskMessageScrollerProps {
|
|
children: ReactNode;
|
|
/** Value that changes whenever content that could grow the thread updates. */
|
|
contentKey: unknown;
|
|
className?: string;
|
|
}
|
|
|
|
/**
|
|
* Scroll container that owns the redesign's auto-follow vs. hold-position rule.
|
|
*
|
|
* Explicit rule: while the viewport is pinned to the bottom (within a small
|
|
* threshold) new content auto-follows with INSTANT scroll; the moment the user
|
|
* scrolls up we hold their position and surface a scroll-to-latest pill
|
|
* instead of yanking them down.
|
|
*
|
|
* Re-follow is easing-aware: clicking the pill glides down smoothly, and while
|
|
* that glide is in flight (`easingRef`) the scroll handler must not unpin —
|
|
* the smooth scroll fires intermediate scroll events that would otherwise
|
|
* re-show the pill mid-glide (the known stick-to-bottom failure mode). Arrival
|
|
* within the pin threshold re-pins and hides the pill; a wheel/touch during
|
|
* the glide cancels it and treats the user as unpinned. Content-driven follow
|
|
* while pinned stays instant, so no reflow/jump happens during streaming.
|
|
*/
|
|
export function TaskMessageScroller({ children, contentKey, className }: TaskMessageScrollerProps) {
|
|
const streamlined = useStreamlinedTaskChatPresentation();
|
|
const navigation = useTaskChatScrollNavigation();
|
|
const initialPositionApplied = useRef(false);
|
|
const appliedNavigation = useRef({ key: navigation.key, hash: navigation.hash });
|
|
const ref = useRef<HTMLDivElement>(null);
|
|
const anchorRef = useRef<ThreadScrollAnchor | null>(null);
|
|
const pinnedRef = useRef(true);
|
|
const easingRef = useRef(false);
|
|
const clientHeightRef = useRef<number | null>(null);
|
|
const scrollbarIdleTimerRef = useRef<number | null>(null);
|
|
const scrollbarIdleDelayRef = useRef<number | null>(null);
|
|
const [pillPhase, setPillPhase] = useState<PillPhase>("hidden");
|
|
|
|
const showScrollbarWhileScrolling = useCallback(() => {
|
|
const el = ref.current;
|
|
if (!el) return;
|
|
el.dataset.scrollActive = "true";
|
|
if (scrollbarIdleTimerRef.current !== null) {
|
|
window.clearTimeout(scrollbarIdleTimerRef.current);
|
|
}
|
|
const idleDelay = scrollbarIdleDelayRef.current ?? parseCssTimeMs(
|
|
getComputedStyle(document.documentElement).getPropertyValue("--motion-scrollbar-idle-delay"),
|
|
);
|
|
scrollbarIdleDelayRef.current = idleDelay;
|
|
scrollbarIdleTimerRef.current = window.setTimeout(() => {
|
|
delete el.dataset.scrollActive;
|
|
scrollbarIdleTimerRef.current = null;
|
|
scrollbarIdleDelayRef.current = null;
|
|
}, idleDelay);
|
|
}, []);
|
|
|
|
const showPill = useCallback(() => {
|
|
setPillPhase("in");
|
|
}, []);
|
|
|
|
const hidePill = useCallback(() => {
|
|
// Keep rendering through the exit animation; unmount on animationend.
|
|
// Without animations (reduced motion / no matchMedia) unmount immediately.
|
|
setPillPhase((phase) => (phase === "hidden" ? phase : motionDisabled() ? "hidden" : "out"));
|
|
}, []);
|
|
|
|
const isPinned = useCallback(() => {
|
|
const el = ref.current;
|
|
if (!el) return true;
|
|
return el.scrollHeight - el.scrollTop - el.clientHeight <= PIN_THRESHOLD_PX;
|
|
}, []);
|
|
|
|
const scrollToBottom = useCallback(() => {
|
|
const el = ref.current;
|
|
if (!el) return;
|
|
el.scrollTop = el.scrollHeight; // instant, never smooth
|
|
}, []);
|
|
|
|
const followViewportResize = useCallback(() => {
|
|
const el = ref.current;
|
|
if (!el) return false;
|
|
const previousClientHeight = clientHeightRef.current;
|
|
const nextClientHeight = el.clientHeight;
|
|
clientHeightRef.current = nextClientHeight;
|
|
if (
|
|
previousClientHeight == null ||
|
|
previousClientHeight <= 0 ||
|
|
previousClientHeight === nextClientHeight ||
|
|
!pinnedRef.current
|
|
) {
|
|
return false;
|
|
}
|
|
scrollToBottom();
|
|
return true;
|
|
}, [scrollToBottom]);
|
|
|
|
const rememberAnchor = useCallback(() => {
|
|
const el = ref.current;
|
|
if (!el || el.clientHeight === 0) return;
|
|
const rect = el.getBoundingClientRect();
|
|
anchorRef.current = readThreadScrollAnchor(el, rect.top, rect.bottom);
|
|
if (initialPositionApplied.current) navigation.remember(el.scrollTop, anchorRef.current);
|
|
}, [navigation.key, navigation.hash, navigation.ready]);
|
|
|
|
const reconcileContent = useCallback(() => {
|
|
const el = ref.current;
|
|
if (!el || el.clientHeight === 0) return;
|
|
// Clicking latest is an explicit follow intent. If content or the composer
|
|
// changes during its glide, finish at the new bottom instead of restoring
|
|
// the old reading anchor and cancelling the browser's smooth scroll.
|
|
if (easingRef.current) {
|
|
easingRef.current = false;
|
|
pinnedRef.current = true;
|
|
hidePill();
|
|
}
|
|
if (pinnedRef.current) scrollToBottom();
|
|
else {
|
|
const delta = threadScrollAnchorDelta(el, anchorRef.current, el.getBoundingClientRect().top);
|
|
if (delta) el.scrollTop += delta;
|
|
}
|
|
rememberAnchor();
|
|
}, [rememberAnchor, scrollToBottom, hidePill]);
|
|
|
|
const handleScroll = useCallback(() => {
|
|
if (!ref.current?.clientHeight) return;
|
|
rememberAnchor();
|
|
showScrollbarWhileScrolling();
|
|
// A growing composer shrinks this viewport. Some browsers dispatch the
|
|
// resulting scroll event before ResizeObserver, so preserve the previous
|
|
// pinned state here instead of mistaking the layout change for a user
|
|
// scroll away from the bottom.
|
|
if (followViewportResize()) {
|
|
hidePill();
|
|
return;
|
|
}
|
|
const pinned = isPinned();
|
|
if (easingRef.current) {
|
|
// Smooth re-follow in flight: intermediate scroll events must not
|
|
// unpin/re-show the pill. Only act once we arrive within the threshold.
|
|
if (pinned) {
|
|
easingRef.current = false;
|
|
pinnedRef.current = true;
|
|
hidePill();
|
|
}
|
|
return;
|
|
}
|
|
pinnedRef.current = pinned;
|
|
if (pinned) hidePill();
|
|
else showPill();
|
|
}, [
|
|
rememberAnchor,
|
|
followViewportResize,
|
|
isPinned,
|
|
hidePill,
|
|
showPill,
|
|
showScrollbarWhileScrolling,
|
|
]);
|
|
|
|
const handleJumpToLatest = useCallback(() => {
|
|
const el = ref.current;
|
|
if (!el) return;
|
|
if (isPinned()) {
|
|
// Already at (or within threshold of) the bottom: no glide needed.
|
|
pinnedRef.current = true;
|
|
hidePill();
|
|
return;
|
|
}
|
|
easingRef.current = true;
|
|
if (typeof el.scrollTo === "function" && !motionDisabled()) {
|
|
el.scrollTo({ top: el.scrollHeight, behavior: "smooth" });
|
|
} else {
|
|
// Environments without scrollTo (older jsdom): fall back to instant.
|
|
el.scrollTop = el.scrollHeight;
|
|
easingRef.current = false;
|
|
pinnedRef.current = true;
|
|
hidePill();
|
|
}
|
|
}, [isPinned, hidePill]);
|
|
|
|
// A user gesture during the smooth glide cancels the re-follow: stop
|
|
// treating scroll events as easing and consider the user unpinned.
|
|
useEffect(() => {
|
|
const el = ref.current;
|
|
if (!el) return;
|
|
const cancelEasing = () => {
|
|
if (!easingRef.current) return;
|
|
easingRef.current = false;
|
|
pinnedRef.current = false;
|
|
showPill();
|
|
};
|
|
el.addEventListener("wheel", cancelEasing, { passive: true });
|
|
el.addEventListener("touchstart", cancelEasing, { passive: true });
|
|
return () => {
|
|
el.removeEventListener("wheel", cancelEasing);
|
|
el.removeEventListener("touchstart", cancelEasing);
|
|
};
|
|
}, [showPill]);
|
|
|
|
useEffect(() => () => {
|
|
if (scrollbarIdleTimerRef.current !== null) {
|
|
window.clearTimeout(scrollbarIdleTimerRef.current);
|
|
}
|
|
}, []);
|
|
|
|
useLayoutEffect(() => {
|
|
const el = ref.current;
|
|
if (!el) return;
|
|
clientHeightRef.current = el.clientHeight;
|
|
if (typeof ResizeObserver === "undefined") return;
|
|
const observer = new ResizeObserver(() => {
|
|
if (followViewportResize()) hidePill();
|
|
reconcileContent();
|
|
});
|
|
observer.observe(el);
|
|
// The viewport itself does not resize when an image or historical row
|
|
// grows. Observe the content box too, before the browser paints it.
|
|
if (el.firstElementChild) observer.observe(el.firstElementChild);
|
|
return () => observer.disconnect();
|
|
}, [followViewportResize, hidePill, reconcileContent]);
|
|
|
|
// Follow new content only when already pinned; otherwise hold position.
|
|
useLayoutEffect(() => {
|
|
const el = ref.current;
|
|
if (appliedNavigation.current.key !== navigation.key || appliedNavigation.current.hash !== navigation.hash) {
|
|
appliedNavigation.current = { key: navigation.key, hash: navigation.hash };
|
|
initialPositionApplied.current = false;
|
|
}
|
|
if (el && el.clientHeight > 0 && navigation.ready && !initialPositionApplied.current) {
|
|
const top = navigation.initialPosition(el, el.getBoundingClientRect().top, el.scrollTop);
|
|
if (top !== null) {
|
|
el.scrollTop = top;
|
|
pinnedRef.current = isPinned();
|
|
rememberAnchor();
|
|
}
|
|
initialPositionApplied.current = true;
|
|
}
|
|
reconcileContent();
|
|
}, [contentKey, reconcileContent, navigation.key, navigation.hash, navigation.ready]);
|
|
|
|
return (
|
|
<div className="relative min-h-0 flex-1">
|
|
<div
|
|
ref={ref}
|
|
onScroll={handleScroll}
|
|
// Keep the viewport tied to the flex-sized wrapper vertically —
|
|
// percentage heights don't reliably resolve against flex-determined
|
|
// block heights, which let the thread overflow the page. In the
|
|
// streamlined shell, extend only the scroll box through the page's
|
|
// right gutter; matching padding preserves the message column while
|
|
// placing the scrollbar against the properties-panel boundary.
|
|
className={cn(
|
|
"task-chat-scroll-viewport scrollbar-while-scrolling absolute inset-y-0 left-0 overflow-y-auto",
|
|
streamlined
|
|
? "-right-4 overflow-x-hidden pr-4 md:-right-6 md:pr-6"
|
|
: "right-0",
|
|
className,
|
|
)}
|
|
data-testid="task-chat-scroller"
|
|
>
|
|
{children}
|
|
</div>
|
|
{pillPhase !== "hidden" ? (
|
|
<button
|
|
type="button"
|
|
aria-label="Scroll to latest"
|
|
onClick={handleJumpToLatest}
|
|
onAnimationEnd={() => {
|
|
if (pillPhase === "out") setPillPhase("hidden");
|
|
}}
|
|
// The tc-scroll-pill-* keyframes carry the translate(-50%) X-centering
|
|
// (fill: both keeps it after the animation) — no -translate-x-1/2 here.
|
|
className={cn(
|
|
"absolute left-1/2 flex size-8 items-center justify-center rounded-full border border-border bg-background shadow-sm hover:bg-muted",
|
|
streamlined ? "bottom-7" : "bottom-3",
|
|
pillPhase === "out" ? "tc-scroll-pill-out" : "tc-scroll-pill-in",
|
|
)}
|
|
>
|
|
<ArrowDown className="h-4 w-4" />
|
|
</button>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|