Files
PaperClipAI/ui/src/components/IssueAttachmentsSection.tsx
T
DottaandPaperclip e912f0df53 fix(ui): open text attachments in task tabs (#14297)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Agent work often ends with a Markdown or plain-text file.
> - Task attachments currently open outside the task panel.
> - Users need to inspect those files while keeping the task
conversation in view.
> - This pull request opens text attachments in task tabs and adds
rendered, raw, and download controls.
> - The same controls work in the mobile task drawer.

## Linked Issues or Issue Description

**What happened?**
Opening a text attachment did not put its content in a task tab.
Markdown files had no in-task rendered/raw toggle.

**Expected behavior**
Open Markdown and text attachments in one reusable task tab. Show
Markdown as rendered content or raw text. Download the original file.

**Steps to reproduce**
1. Upload a Markdown file and a plain-text file to a task comment.
2. Open each attachment from the task conversation or artifact list.
3. Switch Markdown between Rendered and Raw. Download both files.
4. Repeat at a mobile viewport width.

Related work: #14193 controls artifact tab arrival. This change adds
text attachment content tabs.

## What Changed

- Route text attachment opens from conversation and artifact cards into
task tabs.
- Add a text attachment panel with accessible Rendered, Raw, and
Download controls.
- Preserve ordinary links for other file types.
- Support the selected attachment in the mobile drawer.
- Keep text-tab actions on the current rich artifact cards, including
CSV previews.
- Render attachment image references and diagram source without loading
media URLs.
- Add browser regression tests, component tests, Storybook examples, and
usage documentation.

## Verification

- Full workspace typecheck, production build, Storybook build, and UI
token gates pass locally.
- All 6,960 UI tests pass. The additional media regression passes
against the real Markdown renderer and fails before the fix. CSV
coverage verifies direct downloads and text tabs after preview.
- Both desktop and mobile browser cases pass locally. They check
rendered/raw Markdown, literal plain text, reusable tabs, review
controls, and exact original download bytes. The local fixture used a
separate database port because an existing socket occupied the default
range.
- The full CI test matrix passes on
`82be5efbef26927b237a031725bb3d7fa79f637f`. The duplicate local `pnpm
test:run` was stopped after this CI result; it did not complete locally.
- Greptile is 5/5 on the final commit. All review threads are resolved,
and the security scan passes.
- All 54 final-head checks pass, including the canary dry run. The two
optional Storybook jobs are skipped.

## Risks

- Text attachment links now open in the task panel. Other content types
keep their existing link behavior.
- File display still depends on the existing authenticated attachment
route. There are no API or database changes.
- Raw text is displayed as text, including strings that look like HTML.
Rendered Markdown keeps media references inert.

## Model Used

OpenAI Codex, based on GPT-6, with code execution, browser testing, and
subagent tool use. The runtime does not expose an exact serving model
variant or context-window size. Recovered earlier implementation changes
were reviewed and tested; their exact model metadata is unavailable.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-09-29 16:40:10 -05:00

413 lines
15 KiB
TypeScript

import { TextAttachmentContext } from "@/context/TextAttachmentContext";
import { isTextAttachment } from "@/lib/issue-attachments";
import { useContext, useMemo, useState, type DragEvent, type ReactNode } from "react";
import { useQuery } from "@tanstack/react-query";
import type { IssueAttachment } from "@paperclipai/shared";
import { Download, ExternalLink, FileText, Maximize2, Paperclip, Trash2 } from "lucide-react";
import { Button } from "@/components/ui/button";
import { FoldCurtain } from "./FoldCurtain";
import { MarkdownBody } from "./MarkdownBody";
import { OutputFileTile } from "./issue-output/OutputFileTile";
import { OutputVideoPlayer } from "./issue-output/OutputVideoPlayer";
import { formatBytes } from "@/lib/issue-output";
import {
attachmentDownloadPath,
attachmentFilename,
attachmentOpenPath,
isImageAttachment,
isMarkdownAttachment,
isVideoAttachment,
} from "@/lib/issue-attachments";
import { queryKeys } from "@/lib/queryKeys";
import { cn } from "@/lib/utils";
import { Card } from "@/components/ui/card";
interface IssueAttachmentsSectionProps {
attachments: IssueAttachment[];
uploadButton?: ReactNode;
error?: string | null;
dragActive?: boolean;
deletePending?: boolean;
onDelete?: (attachmentId: string) => void;
onImageClick: (attachment: IssueAttachment) => void;
onDragEnter?: (evt: DragEvent<HTMLDivElement>) => void;
onDragOver?: (evt: DragEvent<HTMLDivElement>) => void;
onDragLeave?: (evt: DragEvent<HTMLDivElement>) => void;
onDrop?: (evt: DragEvent<HTMLDivElement>) => void;
}
async function fetchAttachmentText(attachment: IssueAttachment) {
const response = await fetch(attachment.contentPath, {
headers: { Accept: "text/markdown,text/plain;q=0.9,*/*;q=0.1" },
});
if (!response.ok) {
throw new Error(`Unable to load attachment preview (${response.status})`);
}
return response.text();
}
function AttachmentActions({
attachment,
onDelete,
deletePending,
onPreview,
}: {
attachment: IssueAttachment;
onDelete?: (attachmentId: string) => void;
deletePending?: boolean;
onPreview?: (attachment: IssueAttachment) => void;
}) {
const openText = useContext(TextAttachmentContext);
const openInPanel = (event: React.MouseEvent) => {
if (openText && isTextAttachment(attachment) && !event.metaKey && !event.ctrlKey && !event.shiftKey && !event.altKey) { event.preventDefault(); openText(attachment.id, attachmentFilename(attachment)); }
};
const filename = attachmentFilename(attachment);
return (
<div className="flex shrink-0 items-center gap-1">
{onPreview ? (
<Button
variant="ghost"
size="icon-sm"
title="Browse gallery"
aria-label={`Browse ${filename} in gallery`}
onClick={() => onPreview(attachment)}
>
<Maximize2 className="h-4 w-4" />
</Button>
) : null}
<Button asChild variant="ghost" size="icon-sm" title="Open in new tab">
<a href={attachmentOpenPath(attachment)} onClick={openInPanel} target="_blank" rel="noreferrer" aria-label={`Open ${filename}`}>
<ExternalLink className="h-4 w-4" />
</a>
</Button>
<Button asChild variant="ghost" size="icon-sm" title="Download">
<a href={attachmentDownloadPath(attachment)} aria-label={`Download ${filename}`}>
<Download className="h-4 w-4" />
</a>
</Button>
{onDelete ? (
<Button
variant="ghost"
size="icon-sm"
title="Delete attachment"
className="text-muted-foreground hover:text-destructive"
onClick={() => onDelete(attachment.id)}
disabled={deletePending}
>
<Trash2 className="h-4 w-4" />
</Button>
) : null}
</div>
);
}
function AttachmentMeta({ attachment }: { attachment: IssueAttachment }) {
return (
<p className="mt-0.5 text-(length:--text-micro) text-muted-foreground">
Attachment · {attachment.contentType} · {formatBytes(attachment.byteSize)}
</p>
);
}
function MarkdownAttachmentCard({
attachment,
onDelete,
deletePending,
}: {
attachment: IssueAttachment;
onDelete?: (attachmentId: string) => void;
deletePending?: boolean;
}) {
const openText = useContext(TextAttachmentContext);
const openInPanel = (event: React.MouseEvent) => {
if (openText && isTextAttachment(attachment) && !event.metaKey && !event.ctrlKey && !event.shiftKey && !event.altKey) { event.preventDefault(); openText(attachment.id, attachmentFilename(attachment)); }
};
const filename = attachmentFilename(attachment);
const { data, isLoading, error } = useQuery({
queryKey: queryKeys.issues.attachmentPreview(attachment.id),
queryFn: () => fetchAttachmentText(attachment),
});
return (
<div id={`attachment-${attachment.id}`} className="scroll-mt-20 rounded-lg border border-border p-3">
<div className="flex items-start justify-between gap-3">
<div className="min-w-0">
<div className="flex min-w-0 items-center gap-2">
<FileText className="h-4 w-4 shrink-0 text-muted-foreground" />
<a href={attachmentOpenPath(attachment)} onClick={openInPanel} className="truncate text-sm font-medium hover:underline" title={filename}>{filename}</a>
</div>
<AttachmentMeta attachment={attachment} />
</div>
<AttachmentActions attachment={attachment} onDelete={onDelete} deletePending={deletePending} />
</div>
<div className="mt-3 rounded-md hover:bg-accent/10">
{isLoading ? (
<p className="px-1 py-2 text-xs text-muted-foreground">Loading preview...</p>
) : error ? (
<p className="px-1 py-2 text-xs text-destructive">Could not load markdown preview.</p>
) : (
<FoldCurtain>
<MarkdownBody className="paperclip-edit-in-place-content min-h-(--sz-220px) text-sm leading-7" softBreaks={false}>
{data ?? ""}
</MarkdownBody>
</FoldCurtain>
)}
</div>
</div>
);
}
function VideoAttachmentCard({
attachment,
onDelete,
deletePending,
onPreview,
}: {
attachment: IssueAttachment;
onDelete?: (attachmentId: string) => void;
deletePending?: boolean;
onPreview?: (attachment: IssueAttachment) => void;
}) {
const filename = attachmentFilename(attachment);
return (
<Card id={`attachment-${attachment.id}`} className="block scroll-mt-20 overflow-hidden py-0">
<OutputVideoPlayer src={attachment.contentPath} title={filename} />
<div className="flex flex-col gap-2 p-3 md:flex-row md:items-center md:justify-between">
<div className="min-w-0">
<p className="break-words text-sm font-semibold text-foreground">{filename}</p>
<AttachmentMeta attachment={attachment} />
</div>
<AttachmentActions
attachment={attachment}
onDelete={onDelete}
deletePending={deletePending}
onPreview={onPreview}
/>
</div>
</Card>
);
}
function GenericAttachmentRow({
attachment,
onDelete,
deletePending,
}: {
attachment: IssueAttachment;
onDelete?: (attachmentId: string) => void;
deletePending?: boolean;
}) {
const openText = useContext(TextAttachmentContext);
const openInPanel = (event: React.MouseEvent) => {
if (openText && isTextAttachment(attachment) && !event.metaKey && !event.ctrlKey && !event.shiftKey && !event.altKey) { event.preventDefault(); openText(attachment.id, attachmentFilename(attachment)); }
};
const filename = attachmentFilename(attachment);
return (
<Card id={`attachment-${attachment.id}`} className="flex-row scroll-mt-20 items-center gap-2.5 p-2">
<OutputFileTile contentType={attachment.contentType} />
<div className="min-w-0 flex-1">
<a
href={attachmentOpenPath(attachment)} onClick={openInPanel}
target="_blank"
rel="noreferrer"
className="block truncate text-sm font-medium text-foreground hover:underline"
title={filename}
>
{filename}
</a>
<p className="truncate text-(length:--text-micro) text-muted-foreground">
Attachment · {attachment.contentType} · {formatBytes(attachment.byteSize)}
</p>
</div>
<AttachmentActions attachment={attachment} onDelete={onDelete} deletePending={deletePending} />
</Card>
);
}
export function IssueAttachmentsSection({
attachments,
uploadButton,
error,
dragActive = false,
deletePending = false,
onDelete,
onImageClick,
onDragEnter,
onDragOver,
onDragLeave,
onDrop,
}: IssueAttachmentsSectionProps) {
const [confirmDeleteId, setConfirmDeleteId] = useState<string | null>(null);
const { imageAttachments, markdownAttachments, videoAttachments, genericAttachments } = useMemo(() => {
const images: IssueAttachment[] = [];
const markdown: IssueAttachment[] = [];
const videos: IssueAttachment[] = [];
const generic: IssueAttachment[] = [];
for (const attachment of attachments) {
if (isImageAttachment(attachment)) images.push(attachment);
else if (isMarkdownAttachment(attachment)) markdown.push(attachment);
else if (isVideoAttachment(attachment)) videos.push(attachment);
else generic.push(attachment);
}
return {
imageAttachments: images,
markdownAttachments: markdown,
videoAttachments: videos,
genericAttachments: generic,
};
}, [attachments]);
const requestDelete = (attachmentId: string) => setConfirmDeleteId(attachmentId);
const confirmDelete = (attachmentId: string) => {
if (!onDelete) return;
onDelete(attachmentId);
setConfirmDeleteId(null);
};
return (
<div
className={cn(
"space-y-3 rounded-lg transition-colors",
dragActive && "bg-primary/5",
)}
onDragEnter={onDragEnter}
onDragOver={onDragOver}
onDragLeave={onDragLeave}
onDrop={onDrop}
>
<div className="flex items-center justify-between gap-2">
<div className="flex items-center gap-2">
<Paperclip className="h-3.5 w-3.5 text-muted-foreground" aria-hidden="true" />
<h3 className="text-sm font-medium text-muted-foreground">Attachments</h3>
<span className="text-xs text-muted-foreground">{attachments.length}</span>
</div>
{uploadButton}
</div>
{error && (
<p className="text-xs text-destructive">{error}</p>
)}
{imageAttachments.length > 0 && (
<div className="grid grid-cols-4 gap-2">
{imageAttachments.map((attachment) => (
<div
key={attachment.id}
id={`attachment-${attachment.id}`}
className="group relative aspect-square cursor-pointer scroll-mt-20 overflow-hidden rounded-lg border border-border bg-accent/10"
onClick={() => onImageClick(attachment)}
>
<img
src={attachment.contentPath}
alt={attachment.originalFilename ?? "attachment"}
className="h-full w-full object-cover"
loading="lazy"
/>
<div className="absolute inset-0 bg-black/0 transition-colors group-hover:bg-black/30" />
{onDelete && confirmDeleteId === attachment.id ? (
<div
className="absolute inset-0 flex flex-col items-center justify-center gap-1.5 bg-black/60"
onClick={(event) => event.stopPropagation()}
>
<p className="text-xs font-medium text-white">Delete?</p>
<div className="flex gap-1.5">
<button
type="button"
className="rounded bg-destructive px-2 py-0.5 text-xs text-white hover:bg-destructive/80"
onClick={(event) => {
event.stopPropagation();
confirmDelete(attachment.id);
}}
disabled={deletePending}
>
Yes
</button>
<button
type="button"
className="rounded bg-muted px-2 py-0.5 text-xs hover:bg-muted/80"
onClick={(event) => {
event.stopPropagation();
setConfirmDeleteId(null);
}}
>
No
</button>
</div>
</div>
) : onDelete ? (
<button
type="button"
className="absolute right-1.5 top-1.5 rounded-md bg-black/50 p-1 text-white opacity-0 transition-opacity hover:bg-destructive group-hover:opacity-100"
onClick={(event) => {
event.stopPropagation();
requestDelete(attachment.id);
}}
title="Delete attachment"
>
<Trash2 className="h-3.5 w-3.5" />
</button>
) : null}
</div>
))}
</div>
)}
{markdownAttachments.length > 0 && (
<div className="space-y-3">
{markdownAttachments.map((attachment) => (
<MarkdownAttachmentCard
key={attachment.id}
attachment={attachment}
onDelete={onDelete ? requestDelete : undefined}
deletePending={deletePending}
/>
))}
</div>
)}
{videoAttachments.length > 0 && (
<div className="space-y-3">
{videoAttachments.map((attachment) => (
<VideoAttachmentCard
key={attachment.id}
attachment={attachment}
onDelete={onDelete ? requestDelete : undefined}
deletePending={deletePending}
onPreview={onImageClick}
/>
))}
</div>
)}
{genericAttachments.length > 0 && (
<div className="space-y-2">
{genericAttachments.map((attachment) => (
<GenericAttachmentRow
key={attachment.id}
attachment={attachment}
onDelete={onDelete ? requestDelete : undefined}
deletePending={deletePending}
/>
))}
</div>
)}
{onDelete && confirmDeleteId && !imageAttachments.some((attachment) => attachment.id === confirmDeleteId) ? (
<div className="flex items-center justify-between gap-3 rounded-md border border-destructive/20 bg-destructive/5 px-4 py-3">
<p className="text-sm font-medium text-destructive">Delete this attachment? This cannot be undone.</p>
<div className="flex shrink-0 items-center gap-2">
<Button variant="ghost" size="sm" onClick={() => setConfirmDeleteId(null)} disabled={deletePending}>
Cancel
</Button>
<Button variant="destructive" size="sm" onClick={() => confirmDelete(confirmDeleteId)} disabled={deletePending}>
{deletePending ? "Deleting..." : "Delete"}
</Button>
</div>
</div>
) : null}
</div>
);
}