mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-20 15:09:57 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The board UI is the operator surface where users create, assign, monitor, and review work items. > - The product language is moving toward "tasks" for user-facing work items while the internal API and database still use "issues". > - PR #7543 bundled this copy migration with broader information-architecture work, which made the branch too large for Greptile review. > - This pull request peels the Issue-to-Task copy migration into a smaller, independently reviewable change. > - The benefit is clearer user-facing terminology, less agent confusion via the Paperclip skill note, and a smaller PR that Greptile can review. ## Linked Issues or Issue Description Refs #7645 Refs #7543 Refs PAP-10430 This PR was split out of #7543 so the Issue-to-Task copy migration can be reviewed separately and the remaining IA PR can fall under Greptile's file limit. ## What Changed - Preserves Scott Tong's original `PAP-57` copy-only commit, with author and co-author credit intact, to rename user-facing "Issues" copy to "Tasks" across the UI while keeping routes/API/internal symbols as `issue`. - Updates onboarding and release-smoke browser selectors from `Create & Open Issue` to `Create & Open Task`. - Adds a terminology note to `skills/paperclip/SKILL.md` clarifying that task and issue refer to the same Paperclip work item. - Resolves the only cherry-pick conflict by keeping current search artifacts support and changing visible search copy to "tasks". ## Verification - `pnpm --filter @paperclipai/ui build` passed. - `NODE_ENV=test pnpm exec vitest run ui/src/components/IssuesList.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/NewIssueDialog.test.tsx ui/src/pages/IssueDetail.test.tsx` passed: 4 files, 66 tests. - `git diff --check origin/master...HEAD` passed. - Diff is 80 files, below Greptile's 100-file limit. - Before/after UI copy examples: "Issues" -> "Tasks", "New Issue" -> "New Task", "Create & Open Issue" -> "Create & Open Task". ## Risks - Medium copy-risk: this intentionally changes user-facing terminology broadly while keeping internal issue identifiers and routes unchanged. - Some docs and APIs still say `issue`; the skill note clarifies this so agents do not treat task and issue as separate entities. - Browser-level visual validation is expected from CI because this local container is missing usable browser dependencies. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Scott Tong authored the original `PAP-57` copy migration, assisted by Claude Opus 4.8 and Paperclip agents per the preserved commit metadata. Codex / GPT-5-class coding agent with shell, GitHub CLI, and repository access performed the PR split, conflict resolution, skill note, and verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: scotttong <scott.tong@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
144 lines
5.8 KiB
TypeScript
144 lines
5.8 KiB
TypeScript
import { useState } from "react";
|
|
import type { IssueBlockerAttention } from "@paperclipai/shared";
|
|
import { cn } from "../lib/utils";
|
|
import { issueStatusIcon, issueStatusIconDefault } from "../lib/status-colors";
|
|
import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover";
|
|
import { Button } from "@/components/ui/button";
|
|
|
|
const allStatuses = ["backlog", "todo", "in_progress", "in_review", "done", "cancelled", "blocked"];
|
|
|
|
function statusLabel(status: string): string {
|
|
return status.replace(/_/g, " ").replace(/\b\w/g, (c) => c.toUpperCase());
|
|
}
|
|
|
|
interface StatusIconProps {
|
|
status: string;
|
|
blockerAttention?: IssueBlockerAttention | null;
|
|
onChange?: (status: string) => void;
|
|
className?: string;
|
|
showLabel?: boolean;
|
|
}
|
|
|
|
function blockedAttentionLabel(blockerAttention: IssueBlockerAttention | null | undefined) {
|
|
if (!blockerAttention || blockerAttention.state === "none") return "Blocked";
|
|
|
|
if (blockerAttention.reason === "active_child") {
|
|
const count = blockerAttention.coveredBlockerCount;
|
|
if (count === 1 && blockerAttention.sampleBlockerIdentifier) {
|
|
return `Blocked · waiting on active sub-task ${blockerAttention.sampleBlockerIdentifier}`;
|
|
}
|
|
if (count === 1) return "Blocked · waiting on 1 active sub-task";
|
|
return `Blocked · waiting on ${count} active sub-tasks`;
|
|
}
|
|
|
|
if (blockerAttention.reason === "active_dependency") {
|
|
const count = blockerAttention.coveredBlockerCount;
|
|
if (count === 1 && blockerAttention.sampleBlockerIdentifier) {
|
|
return `Blocked · covered by active dependency ${blockerAttention.sampleBlockerIdentifier}`;
|
|
}
|
|
if (count === 1) return "Blocked · covered by 1 active dependency";
|
|
return `Blocked · covered by ${count} active dependencies`;
|
|
}
|
|
|
|
if (blockerAttention.reason === "stalled_review") {
|
|
const count = blockerAttention.stalledBlockerCount;
|
|
const leaf = blockerAttention.sampleStalledBlockerIdentifier ?? blockerAttention.sampleBlockerIdentifier;
|
|
if (count === 1 && leaf) return `Blocked · review stalled on ${leaf}`;
|
|
if (count === 1) return "Blocked · review stalled with no clear next step";
|
|
return `Blocked · ${count} reviews stalled with no clear next step`;
|
|
}
|
|
|
|
if (blockerAttention.reason === "attention_required") {
|
|
const count = blockerAttention.attentionBlockerCount || blockerAttention.unresolvedBlockerCount;
|
|
const attentionCopy = `${count} ${count === 1 ? "blocker needs" : "blockers need"} attention`;
|
|
const coveredCount = blockerAttention.coveredBlockerCount;
|
|
if (coveredCount > 0) {
|
|
return `Blocked · ${attentionCopy}; ${coveredCount} covered by active work`;
|
|
}
|
|
return `Blocked · ${attentionCopy}`;
|
|
}
|
|
|
|
return "Blocked";
|
|
}
|
|
|
|
export function StatusIcon({ status, blockerAttention, onChange, className, showLabel }: StatusIconProps) {
|
|
const [open, setOpen] = useState(false);
|
|
const isCoveredBlocked = status === "blocked" && blockerAttention?.state === "covered";
|
|
const isStalledBlocked = status === "blocked" && blockerAttention?.state === "stalled";
|
|
const isAttentionBlocked = status === "blocked" && blockerAttention?.state === "needs_attention";
|
|
const hasCoveredBlockedWork = isAttentionBlocked && (blockerAttention?.coveredBlockerCount ?? 0) > 0;
|
|
const colorClass = isCoveredBlocked
|
|
? "text-cyan-600 border-cyan-600 dark:text-cyan-400 dark:border-cyan-400"
|
|
: isStalledBlocked
|
|
? "text-amber-600 border-amber-600 dark:text-amber-400 dark:border-amber-400"
|
|
: issueStatusIcon[status] ?? issueStatusIconDefault;
|
|
const isDone = status === "done";
|
|
const ariaLabel = status === "blocked" ? blockedAttentionLabel(blockerAttention) : statusLabel(status);
|
|
const blockerAttentionState = isCoveredBlocked
|
|
? "covered"
|
|
: isStalledBlocked
|
|
? "stalled"
|
|
: isAttentionBlocked
|
|
? "needs_attention"
|
|
: undefined;
|
|
|
|
const circle = (
|
|
<span
|
|
className={cn(
|
|
"relative inline-flex h-4 w-4 rounded-full border-2 shrink-0",
|
|
colorClass,
|
|
onChange && !showLabel && "cursor-pointer",
|
|
className
|
|
)}
|
|
data-blocker-attention-state={blockerAttentionState}
|
|
aria-label={ariaLabel}
|
|
title={ariaLabel}
|
|
>
|
|
{isDone && (
|
|
<span className="absolute inset-0 m-auto h-2 w-2 rounded-full bg-current" />
|
|
)}
|
|
{isCoveredBlocked && (
|
|
<span className="absolute -bottom-0.5 -right-0.5 h-2 w-2 rounded-full border border-background bg-current" />
|
|
)}
|
|
{hasCoveredBlockedWork && (
|
|
<span className="absolute -bottom-0.5 -right-0.5 h-2 w-2 rounded-full border border-background bg-cyan-600 dark:bg-cyan-400" />
|
|
)}
|
|
{isStalledBlocked && (
|
|
<span className="absolute inset-0 m-auto h-1.5 w-1.5 rounded-full bg-current" />
|
|
)}
|
|
</span>
|
|
);
|
|
|
|
if (!onChange) return showLabel ? <span className="inline-flex items-center gap-1.5">{circle}<span className="text-sm">{statusLabel(status)}</span></span> : circle;
|
|
|
|
const trigger = showLabel ? (
|
|
<button className="inline-flex items-center gap-1.5 cursor-pointer hover:bg-accent/50 rounded px-1 -mx-1 py-0.5 transition-colors">
|
|
{circle}
|
|
<span className="text-sm">{statusLabel(status)}</span>
|
|
</button>
|
|
) : circle;
|
|
|
|
return (
|
|
<Popover open={open} onOpenChange={setOpen}>
|
|
<PopoverTrigger asChild>{trigger}</PopoverTrigger>
|
|
<PopoverContent className="w-40 p-1" align="start">
|
|
{allStatuses.map((s) => (
|
|
<Button
|
|
key={s}
|
|
variant="ghost"
|
|
size="sm"
|
|
className={cn("w-full justify-start gap-2 text-xs", s === status && "bg-accent")}
|
|
onClick={() => {
|
|
onChange(s);
|
|
setOpen(false);
|
|
}}
|
|
>
|
|
<StatusIcon status={s} />
|
|
{statusLabel(s)}
|
|
</Button>
|
|
))}
|
|
</PopoverContent>
|
|
</Popover>
|
|
);
|
|
}
|