Files
PaperClipAI/ui/src/components/ProjectWorkspaceSummaryCard.test.tsx
T
2e74d32871 PAP-10430: split Issue-to-Task copy migration (#7651)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - The board UI is the operator surface where users create, assign,
monitor, and review work items.
> - The product language is moving toward "tasks" for user-facing work
items while the internal API and database still use "issues".
> - PR #7543 bundled this copy migration with broader
information-architecture work, which made the branch too large for
Greptile review.
> - This pull request peels the Issue-to-Task copy migration into a
smaller, independently reviewable change.
> - The benefit is clearer user-facing terminology, less agent confusion
via the Paperclip skill note, and a smaller PR that Greptile can review.

## Linked Issues or Issue Description

Refs #7645
Refs #7543
Refs PAP-10430

This PR was split out of #7543 so the Issue-to-Task copy migration can
be reviewed separately and the remaining IA PR can fall under Greptile's
file limit.

## What Changed

- Preserves Scott Tong's original `PAP-57` copy-only commit, with author
and co-author credit intact, to rename user-facing "Issues" copy to
"Tasks" across the UI while keeping routes/API/internal symbols as
`issue`.
- Updates onboarding and release-smoke browser selectors from `Create &
Open Issue` to `Create & Open Task`.
- Adds a terminology note to `skills/paperclip/SKILL.md` clarifying that
task and issue refer to the same Paperclip work item.
- Resolves the only cherry-pick conflict by keeping current search
artifacts support and changing visible search copy to "tasks".

## Verification

- `pnpm --filter @paperclipai/ui build` passed.
- `NODE_ENV=test pnpm exec vitest run
ui/src/components/IssuesList.test.tsx ui/src/components/Sidebar.test.tsx
ui/src/components/NewIssueDialog.test.tsx
ui/src/pages/IssueDetail.test.tsx` passed: 4 files, 66 tests.
- `git diff --check origin/master...HEAD` passed.
- Diff is 80 files, below Greptile's 100-file limit.
- Before/after UI copy examples: "Issues" -> "Tasks", "New Issue" ->
"New Task", "Create & Open Issue" -> "Create & Open Task".

## Risks

- Medium copy-risk: this intentionally changes user-facing terminology
broadly while keeping internal issue identifiers and routes unchanged.
- Some docs and APIs still say `issue`; the skill note clarifies this so
agents do not treat task and issue as separate entities.
- Browser-level visual validation is expected from CI because this local
container is missing usable browser dependencies.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

Scott Tong authored the original `PAP-57` copy migration, assisted by
Claude Opus 4.8 and Paperclip agents per the preserved commit metadata.
Codex / GPT-5-class coding agent with shell, GitHub CLI, and repository
access performed the PR split, conflict resolution, skill note, and
verification.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: scotttong <scott.tong@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-06-06 10:10:01 -05:00

285 lines
10 KiB
TypeScript

// @vitest-environment jsdom
import { act } from "react";
import type { ComponentProps, ReactNode } from "react";
import { createRoot } from "react-dom/client";
import type { ExecutionWorkspace, Issue } from "@paperclipai/shared";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { ProjectWorkspaceSummary } from "../lib/project-workspaces-tab";
import { ProjectWorkspaceSummaryCard } from "./ProjectWorkspaceSummaryCard";
vi.mock("@/lib/router", () => ({
Link: ({ children, to, ...props }: ComponentProps<"a"> & { to: string }) => <a href={to} {...props}>{children}</a>,
}));
vi.mock("./IssuesQuicklook", () => ({
IssuesQuicklook: ({ children }: { children: ReactNode }) => <>{children}</>,
}));
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
function createIssue(overrides: Partial<Issue> = {}): Issue {
return {
id: overrides.id ?? "issue-1",
companyId: overrides.companyId ?? "company-1",
projectId: overrides.projectId ?? "project-1",
projectWorkspaceId: overrides.projectWorkspaceId ?? null,
goalId: overrides.goalId ?? null,
parentId: overrides.parentId ?? null,
title: overrides.title ?? "Issue",
description: overrides.description ?? null,
status: overrides.status ?? "todo",
priority: overrides.priority ?? "medium",
assigneeAgentId: overrides.assigneeAgentId ?? null,
assigneeUserId: overrides.assigneeUserId ?? null,
checkoutRunId: overrides.checkoutRunId ?? null,
executionRunId: overrides.executionRunId ?? null,
executionAgentNameKey: overrides.executionAgentNameKey ?? null,
executionLockedAt: overrides.executionLockedAt ?? null,
createdByAgentId: overrides.createdByAgentId ?? null,
createdByUserId: overrides.createdByUserId ?? null,
issueNumber: overrides.issueNumber ?? 1,
identifier: overrides.identifier ?? "PAP-1",
requestDepth: overrides.requestDepth ?? 0,
billingCode: overrides.billingCode ?? null,
assigneeAdapterOverrides: overrides.assigneeAdapterOverrides ?? null,
executionWorkspaceId: overrides.executionWorkspaceId ?? null,
executionWorkspacePreference: overrides.executionWorkspacePreference ?? null,
executionWorkspaceSettings: overrides.executionWorkspaceSettings ?? null,
startedAt: overrides.startedAt ?? null,
completedAt: overrides.completedAt ?? null,
cancelledAt: overrides.cancelledAt ?? null,
hiddenAt: overrides.hiddenAt ?? null,
createdAt: overrides.createdAt ?? new Date("2026-04-12T00:00:00Z"),
updatedAt: overrides.updatedAt ?? new Date("2026-04-12T00:00:00Z"),
} as Issue;
}
function createSummary(overrides: Partial<ProjectWorkspaceSummary> = {}): ProjectWorkspaceSummary {
return {
key: overrides.key ?? "execution:workspace-1",
kind: overrides.kind ?? "execution_workspace",
workspaceId: overrides.workspaceId ?? "workspace-1",
workspaceName: overrides.workspaceName ?? "PAP-989-multi-user-implementation",
cwd: overrides.cwd ?? "/worktrees/PAP-989-multi-user-implementation",
branchName: overrides.branchName ?? "PAP-989-multi-user-implementation",
lastUpdatedAt: overrides.lastUpdatedAt ?? new Date("2026-04-12T00:00:00Z"),
projectWorkspaceId: overrides.projectWorkspaceId ?? "project-workspace-1",
executionWorkspaceId: overrides.executionWorkspaceId ?? "workspace-1",
executionWorkspaceStatus: overrides.executionWorkspaceStatus ?? "active",
serviceCount: overrides.serviceCount ?? 2,
runningServiceCount: overrides.runningServiceCount ?? 0,
primaryServiceUrl: overrides.primaryServiceUrl ?? "http://127.0.0.1:62474",
primaryServiceUrlRunning: overrides.primaryServiceUrlRunning ?? false,
hasRuntimeConfig: overrides.hasRuntimeConfig ?? true,
issues: overrides.issues ?? [
createIssue({ id: "issue-1", identifier: "PAP-1364" }),
createIssue({ id: "issue-2", identifier: "PAP-1367" }),
createIssue({ id: "issue-3", identifier: "PAP-1362" }),
createIssue({ id: "issue-4", identifier: "PAP-1363" }),
createIssue({ id: "issue-5", identifier: "PAP-1340" }),
],
};
}
describe("ProjectWorkspaceSummaryCard", () => {
let container: HTMLDivElement;
let writeClipboard: ReturnType<typeof vi.fn>;
beforeEach(() => {
container = document.createElement("div");
document.body.appendChild(container);
writeClipboard = vi.fn().mockResolvedValue(undefined);
Object.defineProperty(navigator, "clipboard", {
configurable: true,
value: { writeText: writeClipboard },
});
Object.defineProperty(window, "isSecureContext", {
configurable: true,
value: true,
});
});
afterEach(() => {
document.body.innerHTML = "";
});
it("renders a stacked mobile-friendly summary with metadata labels and compact issue pills", () => {
const root = createRoot(container);
act(() => {
root.render(
<ProjectWorkspaceSummaryCard
projectRef="paperclip-app"
summary={createSummary()}
runtimeActionKey={null}
runtimeActionPending={false}
onRuntimeAction={() => {}}
onCloseWorkspace={() => {}}
/>,
);
});
expect(container.textContent).toContain("Execution workspace");
expect(container.textContent).toContain("Branch");
expect(container.textContent).toContain("Path");
expect(container.textContent).toContain("Service");
expect(container.textContent).toContain("Linked tasks");
expect(container.textContent).toContain("Start services");
expect(container.textContent).toContain("Close workspace");
expect(container.textContent).toContain("+1 more");
const actions = container.querySelector('[data-testid="workspace-summary-actions"]');
expect(actions?.className).toContain("flex-col");
const card = container.firstElementChild;
expect(card?.className).toContain("rounded-lg");
expect(card?.className).toContain("border");
act(() => {
root.unmount();
});
});
it("uses project workspace routes and omits close controls for project workspaces", () => {
const runtimeSpy = vi.fn();
const closeSpy = vi.fn();
const root = createRoot(container);
act(() => {
root.render(
<ProjectWorkspaceSummaryCard
projectRef="paperclip-app"
summary={createSummary({
key: "project:workspace-2",
kind: "project_workspace",
executionWorkspaceId: null,
executionWorkspaceStatus: null,
hasRuntimeConfig: false,
issues: [createIssue({ id: "issue-6", identifier: "PAP-1400" })],
})}
runtimeActionKey={null}
runtimeActionPending={false}
onRuntimeAction={runtimeSpy}
onCloseWorkspace={closeSpy}
/>,
);
});
const titleLink = container.querySelector("a[href='/projects/paperclip-app/workspaces/workspace-1']");
expect(titleLink).not.toBeNull();
expect(container.textContent).not.toContain("Close workspace");
expect(container.textContent).not.toContain("Start services");
act(() => {
root.unmount();
});
});
it("shows retry close for cleanup failures", () => {
const root = createRoot(container);
act(() => {
root.render(
<ProjectWorkspaceSummaryCard
projectRef="paperclip-app"
summary={createSummary({
executionWorkspaceStatus: "cleanup_failed" as ExecutionWorkspace["status"],
})}
runtimeActionKey={null}
runtimeActionPending={false}
onRuntimeAction={() => {}}
onCloseWorkspace={() => {}}
/>,
);
});
expect(container.textContent).toContain("Retry close");
act(() => {
root.unmount();
});
});
it("copies branch and path from both text and icon controls with feedback", async () => {
const root = createRoot(container);
const summary = createSummary({
branchName: "PAP-1552-workspace-polish",
cwd: "/Users/dotta/paperclip/.worktrees/PAP-1552-workspace-polish",
});
await act(async () => {
root.render(
<ProjectWorkspaceSummaryCard
projectRef="paperclip-app"
summary={summary}
runtimeActionKey={null}
runtimeActionPending={false}
onRuntimeAction={() => {}}
onCloseWorkspace={() => {}}
/>,
);
});
const branchTextButton = Array.from(container.querySelectorAll("button"))
.find((button) => button.textContent === summary.branchName);
const pathTextButton = container.querySelector(`button[title="${summary.cwd}"]`);
const branchIconButton = container.querySelector('button[aria-label="Copy branch"]');
const pathIconButton = container.querySelector('button[aria-label="Copy path"]');
expect(branchTextButton).not.toBeNull();
expect(pathTextButton).not.toBeNull();
expect(branchIconButton).not.toBeNull();
expect(pathIconButton).not.toBeNull();
await act(async () => {
branchTextButton!.click();
});
expect(writeClipboard).toHaveBeenLastCalledWith(summary.branchName);
expect(branchTextButton?.nextElementSibling?.className).toContain("opacity-100");
await act(async () => {
pathTextButton!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
});
expect(writeClipboard).toHaveBeenLastCalledWith(summary.cwd);
expect(pathTextButton?.nextElementSibling?.className).toContain("opacity-100");
await act(async () => {
branchIconButton!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
pathIconButton!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
});
expect(writeClipboard).toHaveBeenCalledWith(summary.branchName);
expect(writeClipboard).toHaveBeenCalledWith(summary.cwd);
act(() => {
root.unmount();
});
});
it("colors live service urls green", () => {
const root = createRoot(container);
act(() => {
root.render(
<ProjectWorkspaceSummaryCard
projectRef="paperclip-app"
summary={createSummary({
primaryServiceUrl: "http://127.0.0.1:62475",
primaryServiceUrlRunning: true,
runningServiceCount: 1,
})}
runtimeActionKey={null}
runtimeActionPending={false}
onRuntimeAction={() => {}}
onCloseWorkspace={() => {}}
/>,
);
});
const serviceLink = container.querySelector("a[href='http://127.0.0.1:62475']");
expect(serviceLink?.className).toContain("text-emerald");
act(() => {
root.unmount();
});
});
});