mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-28 12:04:41 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The board UI is the operator surface where users create, assign, monitor, and review work items. > - The product language is moving toward "tasks" for user-facing work items while the internal API and database still use "issues". > - PR #7543 bundled this copy migration with broader information-architecture work, which made the branch too large for Greptile review. > - This pull request peels the Issue-to-Task copy migration into a smaller, independently reviewable change. > - The benefit is clearer user-facing terminology, less agent confusion via the Paperclip skill note, and a smaller PR that Greptile can review. ## Linked Issues or Issue Description Refs #7645 Refs #7543 Refs PAP-10430 This PR was split out of #7543 so the Issue-to-Task copy migration can be reviewed separately and the remaining IA PR can fall under Greptile's file limit. ## What Changed - Preserves Scott Tong's original `PAP-57` copy-only commit, with author and co-author credit intact, to rename user-facing "Issues" copy to "Tasks" across the UI while keeping routes/API/internal symbols as `issue`. - Updates onboarding and release-smoke browser selectors from `Create & Open Issue` to `Create & Open Task`. - Adds a terminology note to `skills/paperclip/SKILL.md` clarifying that task and issue refer to the same Paperclip work item. - Resolves the only cherry-pick conflict by keeping current search artifacts support and changing visible search copy to "tasks". ## Verification - `pnpm --filter @paperclipai/ui build` passed. - `NODE_ENV=test pnpm exec vitest run ui/src/components/IssuesList.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/NewIssueDialog.test.tsx ui/src/pages/IssueDetail.test.tsx` passed: 4 files, 66 tests. - `git diff --check origin/master...HEAD` passed. - Diff is 80 files, below Greptile's 100-file limit. - Before/after UI copy examples: "Issues" -> "Tasks", "New Issue" -> "New Task", "Create & Open Issue" -> "Create & Open Task". ## Risks - Medium copy-risk: this intentionally changes user-facing terminology broadly while keeping internal issue identifiers and routes unchanged. - Some docs and APIs still say `issue`; the skill note clarifies this so agents do not treat task and issue as separate entities. - Browser-level visual validation is expected from CI because this local container is missing usable browser dependencies. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Scott Tong authored the original `PAP-57` copy migration, assisted by Claude Opus 4.8 and Paperclip agents per the preserved commit metadata. Codex / GPT-5-class coding agent with shell, GitHub CLI, and repository access performed the PR split, conflict resolution, skill note, and verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: scotttong <scott.tong@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
126 lines
3.8 KiB
TypeScript
126 lines
3.8 KiB
TypeScript
import type {
|
|
IssueCommentMetadata,
|
|
IssueCommentMetadataRow,
|
|
IssueCommentPresentation,
|
|
} from "@paperclipai/shared";
|
|
import type {
|
|
SystemNoticeMetadataRow,
|
|
SystemNoticeMetadataSection,
|
|
SystemNoticeProps,
|
|
SystemNoticeTone,
|
|
} from "../components/SystemNotice";
|
|
|
|
const TONE_LABEL: Record<SystemNoticeTone, string> = {
|
|
neutral: "System notice",
|
|
info: "System notice",
|
|
success: "System notice",
|
|
warning: "System warning",
|
|
danger: "System alert",
|
|
};
|
|
|
|
function metadataRowText(row: { label?: string | null }, fallback: string) {
|
|
const label = row.label?.trim();
|
|
return label && label.length > 0 ? label : fallback;
|
|
}
|
|
|
|
function mapMetadataRow(
|
|
row: IssueCommentMetadataRow,
|
|
ctx: { runAgentId?: string | null },
|
|
): SystemNoticeMetadataRow | null {
|
|
switch (row.type) {
|
|
case "text":
|
|
return { kind: "text", label: metadataRowText(row, "Detail"), value: row.text };
|
|
case "code":
|
|
return { kind: "code", label: metadataRowText(row, "Code"), value: row.code };
|
|
case "key_value":
|
|
return { kind: "text", label: row.label, value: row.value };
|
|
case "issue_link": {
|
|
const identifier = row.identifier ?? null;
|
|
if (!identifier) {
|
|
return { kind: "text", label: metadataRowText(row, "Task"), value: row.title ?? "unknown" };
|
|
}
|
|
return {
|
|
kind: "issue",
|
|
label: metadataRowText(row, "Task"),
|
|
identifier,
|
|
href: `/issues/${identifier}`,
|
|
title: row.title ?? undefined,
|
|
};
|
|
}
|
|
case "agent_link": {
|
|
const name = row.name?.trim() || row.agentId.slice(0, 8);
|
|
return {
|
|
kind: "agent",
|
|
label: metadataRowText(row, "Agent"),
|
|
name,
|
|
href: `/agents/${row.agentId}`,
|
|
};
|
|
}
|
|
case "run_link": {
|
|
const runAgentId = ctx.runAgentId ?? null;
|
|
const href = runAgentId ? `/agents/${runAgentId}/runs/${row.runId}` : undefined;
|
|
return {
|
|
kind: "run",
|
|
label: metadataRowText(row, "Run"),
|
|
runId: row.runId,
|
|
href,
|
|
status: row.title ?? undefined,
|
|
};
|
|
}
|
|
default:
|
|
return null;
|
|
}
|
|
}
|
|
|
|
export function mapCommentMetadataToSystemNoticeSections(
|
|
metadata: IssueCommentMetadata | null | undefined,
|
|
ctx: { runAgentId?: string | null } = {},
|
|
): SystemNoticeMetadataSection[] {
|
|
if (!metadata || !Array.isArray(metadata.sections)) return [];
|
|
return metadata.sections
|
|
.map((section) => {
|
|
const rows = section.rows
|
|
.map((row) => mapMetadataRow(row, ctx))
|
|
.filter((r): r is SystemNoticeMetadataRow => r !== null);
|
|
if (rows.length === 0) return null;
|
|
const out: SystemNoticeMetadataSection = { rows };
|
|
if (section.title) out.title = section.title;
|
|
return out;
|
|
})
|
|
.filter((s): s is SystemNoticeMetadataSection => s !== null);
|
|
}
|
|
|
|
export function systemNoticeLabelForTone(
|
|
tone: SystemNoticeTone,
|
|
presentationTitle?: string | null,
|
|
): string {
|
|
const trimmed = presentationTitle?.trim();
|
|
if (trimmed && trimmed.length > 0) return trimmed;
|
|
return TONE_LABEL[tone];
|
|
}
|
|
|
|
export function buildSystemNoticeProps(input: {
|
|
presentation: IssueCommentPresentation | null;
|
|
metadata: IssueCommentMetadata | null;
|
|
body: import("react").ReactNode;
|
|
timestamp?: string;
|
|
source?: SystemNoticeProps["source"];
|
|
runAgentId?: string | null;
|
|
}): SystemNoticeProps {
|
|
const tone: SystemNoticeTone = input.presentation?.tone ?? "neutral";
|
|
const label = systemNoticeLabelForTone(tone, input.presentation?.title);
|
|
const detailsDefaultOpen = Boolean(input.presentation?.detailsDefaultOpen);
|
|
const sections = mapCommentMetadataToSystemNoticeSections(input.metadata, {
|
|
runAgentId: input.runAgentId ?? null,
|
|
});
|
|
return {
|
|
tone,
|
|
label,
|
|
body: input.body,
|
|
metadata: sections.length > 0 ? sections : undefined,
|
|
detailsDefaultOpen,
|
|
timestamp: input.timestamp,
|
|
source: input.source,
|
|
};
|
|
}
|