mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-27 11:20:42 +01:00
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, where operators need a reliable way to find and act on work awaiting their input. > - The attention and issue-thread interaction subsystems expose those decision points across server APIs and the board UI. > - The previous navigation and interaction presentation left these actions fragmented and did not offer a controlled rollout for the Decisions surface. > - This branch adds the attention feed, richer interaction cards, grouping, dismiss/snooze behavior, and a gated Decisions sidebar entry. > - It also keeps experimental settings and API contracts synchronized, with an idempotent migration for the new dismissal state. > - This pull request delivers the complete, tested attention/Decisions experience as one reviewable unit. ## Linked Issues or Issue Description - Adds an operator-focused attention queue and Decisions experience: grouped decision cards, semantic interaction actions, dismiss/snooze handling, resilient interaction states, and an experimental flag to control the Decisions navigation entry. ## Feature Context ### Problem or Motivation Operators currently have to hunt across approvals, interactions, failed runs, and budget alerts to find decisions that need their action. ### Proposed Solution Provide a gated Decisions attention queue that groups actionable items, supports direct resolution, and preserves operator control through dismiss and snooze actions. ### Alternatives Considered Keep separate, source-specific views only; this leaves cross-cutting operator decisions fragmented and harder to prioritize. ### Roadmap Alignment This improves the V1 control-plane operator workflow by making pending governed actions discoverable in one company-scoped surface. ## What Changed - Added server attention-feed services, routes, interaction handling, dismiss/snooze support, and an idempotent `0145` inbox-dismissal migration. - Added shared attention, inbox-dismissal, and experimental-settings contracts. - Added Decisions/attention UI, interaction-card states, sidebar badge/navigation integration, grouping, keyboard support, and Storybook coverage. - Added tests for attention behavior, thread interactions, settings normalization, dismissals, and API behavior. - Removed generated screenshots from the final PR diff and rebased the branch onto current `master`. ## Verification - `pnpm check:token-gates` — passed. - `pnpm exec vitest run packages/shared/src/issue-thread-interactions.test.ts server/src/__tests__/attention-service.test.ts server/src/__tests__/inbox-dismissals.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts server/src/__tests__/issue-thread-interaction-routes.test.ts ui/src/lib/attention.test.ts ui/src/components/AttentionQueueRow.test.tsx ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/pages/InstanceExperimentalSettings.test.tsx` — passed: 158 tests across 9 focused files. - GitHub Actions for `ad636f560`: build and typecheck/release-registry have passed; remaining general-server and Greptile checks are in progress. ## Risks - Moderate: this is a cross-layer attention/interaction feature with a new migration and navigation behavior. - The `enableDecisions` experimental setting defaults to off, limiting rollout impact. - Existing dismissal data is backfilled to `dismiss`; the migration is idempotent and uses guarded constraint creation. > ROADMAP.md was checked; no duplicate planned core feature was identified. Related open pull requests were searched before opening this PR. ## Model Used - OpenAI GPT-5.5 via Codex CLI, with tool use and local code execution. Context-window size unavailable in this environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My public PR branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally; focused tests pass and the remaining unrelated AWS test failure is documented above - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
201 lines
5.1 KiB
TypeScript
201 lines
5.1 KiB
TypeScript
import {
|
|
createContext,
|
|
useCallback,
|
|
useContext,
|
|
useEffect,
|
|
useMemo,
|
|
useRef,
|
|
useState,
|
|
type ReactNode,
|
|
} from "react";
|
|
|
|
export type ToastTone = "info" | "success" | "warn" | "error";
|
|
|
|
export interface ToastAction {
|
|
label: string;
|
|
/** Navigate on click (mutually exclusive with `onClick`). */
|
|
href?: string;
|
|
/** Run a callback on click, e.g. an undo (mutually exclusive with `href`). */
|
|
onClick?: () => void;
|
|
}
|
|
|
|
export interface ToastInput {
|
|
id?: string;
|
|
dedupeKey?: string;
|
|
title: string;
|
|
body?: string;
|
|
tone?: ToastTone;
|
|
ttlMs?: number;
|
|
action?: ToastAction;
|
|
}
|
|
|
|
export interface ToastItem {
|
|
id: string;
|
|
title: string;
|
|
body?: string;
|
|
tone: ToastTone;
|
|
ttlMs: number;
|
|
action?: ToastAction;
|
|
createdAt: number;
|
|
}
|
|
|
|
interface ToastActionsContextValue {
|
|
pushToast: (input: ToastInput) => string | null;
|
|
dismissToast: (id: string) => void;
|
|
clearToasts: () => void;
|
|
}
|
|
|
|
interface ToastContextValue extends ToastActionsContextValue {
|
|
toasts: ToastItem[];
|
|
}
|
|
|
|
const DEFAULT_TTL_BY_TONE: Record<ToastTone, number> = {
|
|
info: 4000,
|
|
success: 3500,
|
|
warn: 8000,
|
|
error: 10000,
|
|
};
|
|
const MIN_TTL_MS = 1500;
|
|
const MAX_TTL_MS = 15000;
|
|
const MAX_TOASTS = 5;
|
|
const DEDUPE_WINDOW_MS = 3500;
|
|
const DEDUPE_MAX_AGE_MS = 20000;
|
|
|
|
const ToastStateContext = createContext<ToastItem[] | null>(null);
|
|
const ToastActionsContext = createContext<ToastActionsContextValue | null>(null);
|
|
|
|
function normalizeTtl(value: number | undefined, tone: ToastTone) {
|
|
const fallback = DEFAULT_TTL_BY_TONE[tone];
|
|
if (typeof value !== "number" || !Number.isFinite(value)) return fallback;
|
|
return Math.max(MIN_TTL_MS, Math.min(MAX_TTL_MS, Math.floor(value)));
|
|
}
|
|
|
|
function generateToastId() {
|
|
return `toast_${Date.now()}_${Math.random().toString(36).slice(2, 8)}`;
|
|
}
|
|
|
|
export function ToastProvider({ children }: { children: ReactNode }) {
|
|
const [toasts, setToasts] = useState<ToastItem[]>([]);
|
|
const timersRef = useRef(new Map<string, number>());
|
|
const dedupeRef = useRef(new Map<string, number>());
|
|
|
|
const clearTimer = useCallback((id: string) => {
|
|
const handle = timersRef.current.get(id);
|
|
if (handle !== undefined) {
|
|
window.clearTimeout(handle);
|
|
timersRef.current.delete(id);
|
|
}
|
|
}, []);
|
|
|
|
const dismissToast = useCallback(
|
|
(id: string) => {
|
|
clearTimer(id);
|
|
setToasts((prev) => prev.filter((toast) => toast.id !== id));
|
|
},
|
|
[clearTimer],
|
|
);
|
|
|
|
const clearToasts = useCallback(() => {
|
|
for (const handle of timersRef.current.values()) {
|
|
window.clearTimeout(handle);
|
|
}
|
|
timersRef.current.clear();
|
|
setToasts([]);
|
|
}, []);
|
|
|
|
const pushToast = useCallback(
|
|
(input: ToastInput) => {
|
|
const now = Date.now();
|
|
const tone = input.tone ?? "info";
|
|
const ttlMs = normalizeTtl(input.ttlMs, tone);
|
|
const dedupeKey =
|
|
input.dedupeKey ?? input.id ?? `${tone}|${input.title}|${input.body ?? ""}|${input.action?.href ?? ""}`;
|
|
|
|
for (const [key, ts] of dedupeRef.current.entries()) {
|
|
if (now - ts > DEDUPE_MAX_AGE_MS) {
|
|
dedupeRef.current.delete(key);
|
|
}
|
|
}
|
|
|
|
const lastSeen = dedupeRef.current.get(dedupeKey);
|
|
if (lastSeen && now - lastSeen < DEDUPE_WINDOW_MS) {
|
|
return null;
|
|
}
|
|
dedupeRef.current.set(dedupeKey, now);
|
|
|
|
const id = input.id ?? generateToastId();
|
|
clearTimer(id);
|
|
|
|
setToasts((prev) => {
|
|
const nextToast: ToastItem = {
|
|
id,
|
|
title: input.title,
|
|
body: input.body,
|
|
tone,
|
|
ttlMs,
|
|
action: input.action,
|
|
createdAt: now,
|
|
};
|
|
|
|
const withoutCurrent = prev.filter((toast) => toast.id !== id);
|
|
return [nextToast, ...withoutCurrent].slice(0, MAX_TOASTS);
|
|
});
|
|
|
|
const timeout = window.setTimeout(() => {
|
|
dismissToast(id);
|
|
}, ttlMs);
|
|
timersRef.current.set(id, timeout);
|
|
return id;
|
|
},
|
|
[clearTimer, dismissToast],
|
|
);
|
|
|
|
useEffect(() => () => {
|
|
for (const handle of timersRef.current.values()) {
|
|
window.clearTimeout(handle);
|
|
}
|
|
timersRef.current.clear();
|
|
}, []);
|
|
|
|
const actions = useMemo<ToastActionsContextValue>(
|
|
() => ({
|
|
pushToast,
|
|
dismissToast,
|
|
clearToasts,
|
|
}),
|
|
[pushToast, dismissToast, clearToasts],
|
|
);
|
|
|
|
return (
|
|
<ToastActionsContext.Provider value={actions}>
|
|
<ToastStateContext.Provider value={toasts}>{children}</ToastStateContext.Provider>
|
|
</ToastActionsContext.Provider>
|
|
);
|
|
}
|
|
|
|
export function useToastState() {
|
|
const context = useContext(ToastStateContext);
|
|
if (!context) {
|
|
throw new Error("useToastState must be used within a ToastProvider");
|
|
}
|
|
return context;
|
|
}
|
|
|
|
export function useToastActions() {
|
|
const context = useContext(ToastActionsContext);
|
|
if (!context) {
|
|
throw new Error("useToastActions must be used within a ToastProvider");
|
|
}
|
|
return context;
|
|
}
|
|
|
|
export function useOptionalToastActions() {
|
|
return useContext(ToastActionsContext);
|
|
}
|
|
|
|
export function useToast() {
|
|
const toasts = useToastState();
|
|
const actions = useToastActions();
|
|
return useMemo<ToastContextValue>(() => ({ toasts, ...actions }), [toasts, actions]);
|
|
}
|