mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-16 05:17:41 +02:00
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, where operators need a reliable way to find and act on work awaiting their input. > - The attention and issue-thread interaction subsystems expose those decision points across server APIs and the board UI. > - The previous navigation and interaction presentation left these actions fragmented and did not offer a controlled rollout for the Decisions surface. > - This branch adds the attention feed, richer interaction cards, grouping, dismiss/snooze behavior, and a gated Decisions sidebar entry. > - It also keeps experimental settings and API contracts synchronized, with an idempotent migration for the new dismissal state. > - This pull request delivers the complete, tested attention/Decisions experience as one reviewable unit. ## Linked Issues or Issue Description - Adds an operator-focused attention queue and Decisions experience: grouped decision cards, semantic interaction actions, dismiss/snooze handling, resilient interaction states, and an experimental flag to control the Decisions navigation entry. ## Feature Context ### Problem or Motivation Operators currently have to hunt across approvals, interactions, failed runs, and budget alerts to find decisions that need their action. ### Proposed Solution Provide a gated Decisions attention queue that groups actionable items, supports direct resolution, and preserves operator control through dismiss and snooze actions. ### Alternatives Considered Keep separate, source-specific views only; this leaves cross-cutting operator decisions fragmented and harder to prioritize. ### Roadmap Alignment This improves the V1 control-plane operator workflow by making pending governed actions discoverable in one company-scoped surface. ## What Changed - Added server attention-feed services, routes, interaction handling, dismiss/snooze support, and an idempotent `0145` inbox-dismissal migration. - Added shared attention, inbox-dismissal, and experimental-settings contracts. - Added Decisions/attention UI, interaction-card states, sidebar badge/navigation integration, grouping, keyboard support, and Storybook coverage. - Added tests for attention behavior, thread interactions, settings normalization, dismissals, and API behavior. - Removed generated screenshots from the final PR diff and rebased the branch onto current `master`. ## Verification - `pnpm check:token-gates` — passed. - `pnpm exec vitest run packages/shared/src/issue-thread-interactions.test.ts server/src/__tests__/attention-service.test.ts server/src/__tests__/inbox-dismissals.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts server/src/__tests__/issue-thread-interaction-routes.test.ts ui/src/lib/attention.test.ts ui/src/components/AttentionQueueRow.test.tsx ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/pages/InstanceExperimentalSettings.test.tsx` — passed: 158 tests across 9 focused files. - GitHub Actions for `ad636f560`: build and typecheck/release-registry have passed; remaining general-server and Greptile checks are in progress. ## Risks - Moderate: this is a cross-layer attention/interaction feature with a new migration and navigation behavior. - The `enableDecisions` experimental setting defaults to off, limiting rollout impact. - Existing dismissal data is backfilled to `dismiss`; the migration is idempotent and uses guarded constraint creation. > ROADMAP.md was checked; no duplicate planned core feature was identified. Related open pull requests were searched before opening this PR. ## Model Used - OpenAI GPT-5.5 via Codex CLI, with tool use and local code execution. Context-window size unavailable in this environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My public PR branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally; focused tests pass and the remaining unrelated AWS test failure is documented above - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
214 lines
5.9 KiB
TypeScript
214 lines
5.9 KiB
TypeScript
export const KEYBOARD_SHORTCUT_TEXT_INPUT_SELECTOR = [
|
|
"input",
|
|
"textarea",
|
|
"select",
|
|
"[contenteditable='true']",
|
|
"[contenteditable='plaintext-only']",
|
|
"[role='textbox']",
|
|
"[role='combobox']",
|
|
].join(", ");
|
|
|
|
const PAGE_SEARCH_SHORTCUT_SELECTOR = "[data-page-search-target='true']";
|
|
const MODIFIER_ONLY_KEYS = new Set(["Shift", "Meta", "Control", "Alt"]);
|
|
|
|
export type InboxQuickArchiveKeyAction = "ignore" | "archive" | "disarm";
|
|
export type InboxUndoArchiveKeyAction = "ignore" | "undo_archive";
|
|
export type IssueDetailGoKeyAction =
|
|
| "ignore"
|
|
| "arm"
|
|
| "navigate_inbox"
|
|
| "focus_comment"
|
|
| "open_file_viewer"
|
|
| "disarm";
|
|
export type AttentionQueueKeyAction = "ignore" | "next" | "previous" | "toggle" | "dismiss";
|
|
|
|
export function isKeyboardShortcutTextInputTarget(target: EventTarget | null): boolean {
|
|
if (!(target instanceof HTMLElement)) return false;
|
|
if (target.isContentEditable) return true;
|
|
return !!target.closest(KEYBOARD_SHORTCUT_TEXT_INPUT_SELECTOR);
|
|
}
|
|
|
|
export function hasBlockingShortcutDialog(root: ParentNode = document): boolean {
|
|
return !!root.querySelector("[role='dialog'][aria-modal='true']");
|
|
}
|
|
|
|
function isVisibleShortcutTarget(element: HTMLElement): boolean {
|
|
if (!element.isConnected) return false;
|
|
if ("disabled" in element && typeof element.disabled === "boolean" && element.disabled) return false;
|
|
if (element.closest("[hidden], [aria-hidden='true'], [inert]")) return false;
|
|
if (element.closest("[role='dialog'][aria-modal='true']")) return false;
|
|
|
|
const style = window.getComputedStyle(element);
|
|
if (style.display === "none" || style.visibility === "hidden") return false;
|
|
|
|
return element.getClientRects().length > 0 || element === document.activeElement;
|
|
}
|
|
|
|
export function findPageSearchShortcutTarget(root: ParentNode = document): HTMLElement | null {
|
|
const candidates = Array.from(root.querySelectorAll<HTMLElement>(PAGE_SEARCH_SHORTCUT_SELECTOR));
|
|
return candidates.find((candidate) => isVisibleShortcutTarget(candidate)) ?? null;
|
|
}
|
|
|
|
export function focusPageSearchShortcutTarget(root: ParentNode = document): boolean {
|
|
const target = findPageSearchShortcutTarget(root);
|
|
if (!target) return false;
|
|
|
|
target.focus();
|
|
if (target instanceof HTMLInputElement || target instanceof HTMLTextAreaElement) {
|
|
target.select();
|
|
}
|
|
return true;
|
|
}
|
|
|
|
export function shouldBlurPageSearchOnEnter({
|
|
key,
|
|
isComposing,
|
|
}: {
|
|
key: string;
|
|
isComposing: boolean;
|
|
}): boolean {
|
|
return key === "Enter" && !isComposing;
|
|
}
|
|
|
|
export function shouldBlurPageSearchOnEscape({
|
|
key,
|
|
isComposing,
|
|
currentValue,
|
|
}: {
|
|
key: string;
|
|
isComposing: boolean;
|
|
currentValue: string;
|
|
}): boolean {
|
|
return key === "Escape" && !isComposing && currentValue.length === 0;
|
|
}
|
|
|
|
export function isModifierOnlyKey(key: string): boolean {
|
|
return MODIFIER_ONLY_KEYS.has(key);
|
|
}
|
|
|
|
export function resolveAttentionQueueKeyAction({
|
|
defaultPrevented,
|
|
key,
|
|
metaKey,
|
|
ctrlKey,
|
|
altKey,
|
|
target,
|
|
hasOpenDialog,
|
|
hasSelection,
|
|
}: {
|
|
defaultPrevented: boolean;
|
|
key: string;
|
|
metaKey: boolean;
|
|
ctrlKey: boolean;
|
|
altKey: boolean;
|
|
target: EventTarget | null;
|
|
hasOpenDialog: boolean;
|
|
hasSelection: boolean;
|
|
}): AttentionQueueKeyAction {
|
|
if (defaultPrevented || metaKey || ctrlKey || altKey || isModifierOnlyKey(key)) return "ignore";
|
|
if (hasOpenDialog || isKeyboardShortcutTextInputTarget(target)) return "ignore";
|
|
|
|
switch (key) {
|
|
case "j":
|
|
case "ArrowDown":
|
|
return "next";
|
|
case "k":
|
|
case "ArrowUp":
|
|
return "previous";
|
|
case "Enter":
|
|
return hasSelection ? "toggle" : "ignore";
|
|
case "x":
|
|
return hasSelection ? "dismiss" : "ignore";
|
|
default:
|
|
return "ignore";
|
|
}
|
|
}
|
|
|
|
export function resolveInboxQuickArchiveKeyAction({
|
|
armed,
|
|
defaultPrevented,
|
|
key,
|
|
metaKey,
|
|
ctrlKey,
|
|
altKey,
|
|
target,
|
|
hasOpenDialog,
|
|
}: {
|
|
armed: boolean;
|
|
defaultPrevented: boolean;
|
|
key: string;
|
|
metaKey: boolean;
|
|
ctrlKey: boolean;
|
|
altKey: boolean;
|
|
target: EventTarget | null;
|
|
hasOpenDialog: boolean;
|
|
}): InboxQuickArchiveKeyAction {
|
|
if (!armed) return "ignore";
|
|
if (defaultPrevented) return "ignore";
|
|
if (metaKey || ctrlKey || altKey || isModifierOnlyKey(key)) return "ignore";
|
|
if (hasOpenDialog || isKeyboardShortcutTextInputTarget(target)) return "ignore";
|
|
if (key.toLowerCase() === "y") return "archive";
|
|
return "ignore";
|
|
}
|
|
|
|
export function resolveInboxUndoArchiveKeyAction({
|
|
hasUndoableArchive,
|
|
defaultPrevented,
|
|
key,
|
|
metaKey,
|
|
ctrlKey,
|
|
altKey,
|
|
target,
|
|
hasOpenDialog,
|
|
}: {
|
|
hasUndoableArchive: boolean;
|
|
defaultPrevented: boolean;
|
|
key: string;
|
|
metaKey: boolean;
|
|
ctrlKey: boolean;
|
|
altKey: boolean;
|
|
target: EventTarget | null;
|
|
hasOpenDialog: boolean;
|
|
}): InboxUndoArchiveKeyAction {
|
|
if (!hasUndoableArchive) return "ignore";
|
|
if (defaultPrevented) return "ignore";
|
|
if (metaKey || ctrlKey || altKey || isModifierOnlyKey(key)) return "ignore";
|
|
if (hasOpenDialog || isKeyboardShortcutTextInputTarget(target)) return "ignore";
|
|
if (key === "u") return "undo_archive";
|
|
return "ignore";
|
|
}
|
|
|
|
export function resolveIssueDetailGoKeyAction({
|
|
armed,
|
|
defaultPrevented,
|
|
key,
|
|
metaKey,
|
|
ctrlKey,
|
|
altKey,
|
|
target,
|
|
hasOpenDialog,
|
|
}: {
|
|
armed: boolean;
|
|
defaultPrevented: boolean;
|
|
key: string;
|
|
metaKey: boolean;
|
|
ctrlKey: boolean;
|
|
altKey: boolean;
|
|
target: EventTarget | null;
|
|
hasOpenDialog: boolean;
|
|
}): IssueDetailGoKeyAction {
|
|
if (defaultPrevented) return armed ? "disarm" : "ignore";
|
|
if (metaKey || ctrlKey || altKey || isModifierOnlyKey(key)) return "ignore";
|
|
if (hasOpenDialog || isKeyboardShortcutTextInputTarget(target)) {
|
|
return armed ? "disarm" : "ignore";
|
|
}
|
|
|
|
const normalizedKey = key.toLowerCase();
|
|
if (!armed) return normalizedKey === "g" ? "arm" : "ignore";
|
|
if (normalizedKey === "i") return "navigate_inbox";
|
|
if (normalizedKey === "c") return "focus_comment";
|
|
if (normalizedKey === "f") return "open_file_viewer";
|
|
if (normalizedKey === "g") return "arm";
|
|
return "disarm";
|
|
}
|