mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
DottaandPaperclip
bf0220d34a
## Thinking Path > - Paperclip coordinates agents and keeps their workspace files. > - A legacy workspace must move from a local volume to object storage. > - The importer creates an archive, downloads and restores it, and captures the source again. > - Parent imports also download and recapture children that already have committed snapshots. > - This repeated work makes the one-time migration slow. > - This change copies each source file once and trusts the upload acknowledgement. > - Existing source locks and atomic publication still own the migration. ## Linked Issues or Issue Description **What existing behavior does this improve?** The one-time migration of legacy local and Git workspaces to durable snapshots. **Current behavior** Each workspace is captured twice and restored as a test during migration. Parent imports also read back already imported child snapshots. Capture hashes source files before writing them and scans them again afterward. **Proposed behavior** Build one archive from one source-file read, encrypt it, upload it, and publish its reference. Trust the upload acknowledgement. Reuse journaled uploads after an interrupted process. Retain committed child snapshots by database reference. **Reason and benefit** Remove repeated source reads, temporary copies, complete downloads, and recursive child verification. The tests assert one capture, one upload, and zero migration downloads. **Breaking changes** The archive format stays compatible. File hashes required by current readers are computed inline during the copy. There is no preliminary file-hashing pass. Existing readers can cold-restore the result. Related work: #19817 and #20447. ## What Changed - Add single-pass capture that fills fixed-length checksum fields in the existing archive header after copying. - Remove migration readback, test extraction, fresh-source recapture, and Git integrity scans. - Compute the encrypted archive checksum while writing it. - Reuse acknowledged and journaled uploads without rebuilding or downloading them. - Retain already imported children through their database bindings. Remove the recursive payload verification cache. - Keep company checks, source and writer locks, recovery bindings, journal identities, cancellation, and atomic publication. - Bind archived repository intent paths to the operation without reconstructing an archive to check them. - Update the migration contract and the affected tests. ## Verification - Node 24.22.2 and pnpm 9.15.4 on macOS arm64. - Ate876dbdc: focused capture, migration, lost-acknowledgement, and frozen old-reader compatibility checks: 11 passed. - Real source-file open counts prove one read per file. The single-pass archive matches the existing archive bytes and manifest. - Cold restore preserves staged and unstaged Git work, untracked files, executable modes, and confined symlinks. - Ate876dbdc: full archive and cohort suites: 147 passed. - Ate876dbdc: server layered typecheck passed. - At58e5c229: four review fixes add Git source-root confinement, archived lost-acknowledgement reuse, old-journal intent binding, and wrapped-key readability. New focused regressions are included; current-revision CI is pending. - Post-review local runs were inconclusive: Git cases timed out in both existing strict and single-pass modes, and DB tests stalled before assertions. The unchanged earlier passes are not presented as final-revision passes. Required CI will verify the final revision. - Earlier full migration, snapshot storage, and nested-reference suites passed before the compatibility refinement. Required CI supplies fresh broad coverage for the final revision. - Initial compatibility checks exposed the need to retain the existing file-hash header. Inline checksums fixed that failure without another source-file pass. - Initial tests that required repeated verification were updated to the requested copy-once contract. Upload-time database mutations still test the retained business-state guards. ## Risks - Migration now trusts the storage acknowledgement and cooperating writer fences. It does not prove the uploaded bytes with a download or detect later local edits with a second capture. - Already imported child objects are trusted without another object read. Their database bindings remain checked. - Original source files remain available for recovery. - This adds no automatic migration, server pin, or serving deployment. Ordinary run capture and authenticated restore retain their existing behavior. ## Model Used OpenAI Codex, GPT-6 family, with code editing and terminal tools. The exact runtime model revision and context window are not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used, including the runtime details available to this session - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked related work above - [x] I have described the issue in-PR following the enhancement issue template - [x] I have not referenced internal or instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal ticket ID - [x] I have run relevant tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation - [x] I have considered and documented risks - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open follow-ups - [x] I will address reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>