Files
PaperClipAI/tests/e2e/smoke-lab.catalog.ts
T
DottaandPaperclip 7e00f67138 feat(connections): add v3 schema core (#9958)
## Thinking Path

> - Paperclip is the open source control plane people use to manage
AI-agent companies and their governed access to external systems.
> - Connected Apps build on the existing Apps and MCP gateway substrate
so companies can configure reusable, auditable integrations.
> - The current connection record does not yet have a stable public
address, explicit ownership/auth method fields, or subject-specific
credential grants.
> - Without that schema core, later OAuth, per-user authorization, token
brokering, triggers, and connector-service phases cannot enforce tenant
and subject boundaries consistently.
> - This pull request adds the forward-compatible Connections v3 schema
core while preserving the existing connection lifecycle and directly
migrating the remote MCP transport name.
> - The benefit is a company-scoped, least-privilege foundation for
one-click integrations without bypassing Paperclip secrets, profiles,
rules, or audit controls.

## Linked Issues or Issue Description

No matching public issue was found.

**Problem**

Paperclip's current app connections need a durable identity and
authorization substrate before Connected Apps can safely support
multiple setup methods, per-user credentials, provider tenants, and
managed connector services. The existing schema only models a single
connection-level credential set and uses legacy transport terminology.

**Proposed solution**

Add a stable company-scoped connection UID, explicit
ownership/auth/transport fields, a subject-aware `connection_grants`
table, and multi-key credential annotations. Backfill existing
connections and workspace grants in a reversible migration, then update
shared/server/UI contracts to the new `mcp_remote` transport name.

**Related work**

- Related foundation: #9534
- Roadmap: Connected Apps (one-click integrations)

## What Changed

- Added company-scoped connection `uid`, `ownership`, `authKind`, and
canonical transport fields across database, shared contracts,
validators, services, and UI fixtures.
- Added `connection_grants` with workspace/user subject rules, provider
tenant metadata, credential secret refs, revocation state, company
scoping, and uniqueness constraints.
- Added migration `0182_connections_v3_schema_core` to backfill stable
UIDs, rename `remote_http` to `mcp_remote`, infer auth kinds, create
default workspace grants, and support rollback coverage.
- Added multi-key credential annotations and updated gateway/access
services without changing the existing lifecycle behavior.
- Updated the connection glossary, connector playbook, and security
threat model for the new identity, grant, and relay boundaries.
- Added explicit test UIDs to direct database fixtures so the new
non-null invariant is exercised across affected server suites.

## Verification

- `pnpm --filter @paperclipai/shared typecheck`
- `pnpm --filter @paperclipai/db typecheck`
- `pnpm --filter @paperclipai/server typecheck`
- `pnpm --filter @paperclipai/ui typecheck`
- `pnpm exec vitest run server/src/__tests__/tool-access-service.test.ts
server/src/__tests__/tool-gateway-service.test.ts
server/src/__tests__/tool-gateway.test.ts
server/src/__tests__/heartbeat-runtime-skills.test.ts
server/src/__tests__/tool-oauth-legacy-backfill.test.ts
server/src/__tests__/tool-access-policy-service.test.ts
server/src/__tests__/heartbeat-runtime-mcp-servers.test.ts
packages/db/src/connections-v3-schema-core-migration.test.ts
packages/shared/src/validators/tool-access.test.ts --config
vitest.config.ts` — 9 files, 218 tests passed.
- Latest-head GitHub Actions: build, typecheck, general/serialized
suites, backup/worktree restore coverage, both e2e shards, canary,
policy, and security scans pass.
- Greptile: 5/5 with zero unresolved threads.
- `pnpm check:token-gates` remains red only on five pre-existing `#9627`
color literals outside this change.

## Risks

- **Migration risk:** UID backfill and default-grant creation touch
every existing connection. The migration uses company-scoped uniqueness,
deterministic legacy UIDs with ID suffixes, and seeded up/rollback
coverage.
- **Authorization risk:** Grant rows carry credential references.
Constraints enforce workspace-vs-user subject shape, company/connection
lookup indexes, one default grant per connection, and one user grant per
connection/subject. Security review is requested specifically for this
design.
- **Compatibility risk:** `remote_http` is renamed directly to
`mcp_remote`; all repository call sites and fixtures are updated in the
same change.
- **Future-phase risk:** Subject-bound token issuance, triggers, and
connector-service relay verification remain fail-closed requirements
documented for later phases; this PR does not expose those capabilities.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

OpenAI Codex CLI coding agent. The runtime did not expose an exact
underlying model ID or context-window size; capabilities used include
repository inspection, code editing, shell execution, test execution,
Git/GitHub CLI operations, and structured reasoning.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-07-21 15:16:26 -05:00

176 lines
6.7 KiB
TypeScript

export type SmokeRunStepPath = "P1" | "P2" | "P3" | "P4" | "P5" | "P6" | "P7";
export type SmokeLabScenarioStatus = "ci_safe" | "headed_full";
export type SmokeLabTransport = "mcp_remote" | "local_stdio" | "plugin" | "prosumer_import" | "gateway_session" | "governance";
export interface SmokeLabLifecycleTool {
name: string;
parameters: Record<string, unknown>;
}
export interface SmokeLabScenario {
path: SmokeRunStepPath;
title: string;
transport: SmokeLabTransport;
authMode: "oauth" | "api_key" | "none" | "plugin_install" | "config_import" | "run_scoped_token" | "policy";
smokeService: string;
status: SmokeLabScenarioStatus;
ciSafe: boolean;
uiEntryPath: "apps" | "advanced" | "review" | "activity" | "attention";
lifecycle: {
connect: string;
discoverCatalog: string;
allowedRead: SmokeLabLifecycleTool;
askFirstWrite: SmokeLabLifecycleTool;
deniedCall: SmokeLabLifecycleTool;
schemaChangeQuarantine: SmokeLabLifecycleTool;
revoke: string;
auditEvidence: string;
};
}
const httpLifecycle = {
allowedRead: { name: "todo.list", parameters: {} },
askFirstWrite: { name: "todo.add", parameters: { title: "Smoke Lab approved write" } },
deniedCall: { name: "email.send", parameters: { to: "smoke@example.test", subject: "Denied", body: "Denied smoke call" } },
schemaChangeQuarantine: { name: "fixture.schemaFlip", parameters: { toolName: "kv.set" } },
};
const stdioLifecycle = {
allowedRead: { name: "time.now", parameters: {} },
askFirstWrite: { name: "slow.ping", parameters: { delayMs: 1 } },
deniedCall: { name: "crash.now", parameters: {} },
schemaChangeQuarantine: { name: "malicious.metadata", parameters: {} },
};
export const smokeLabScenarios: SmokeLabScenario[] = [
{
path: "P1",
title: "Remote HTTP MCP connection, OAuth",
transport: "mcp_remote",
authMode: "oauth",
smokeService: "HTTP MCP fixture + fake OAuth provider",
status: "ci_safe",
ciSafe: true,
uiEntryPath: "apps",
lifecycle: {
connect: "Start fake OAuth and HTTP MCP fixture services, then use the installed HTTP fixture connection as the OAuth-backed remote MCP path.",
discoverCatalog: "Verify the HTTP fixture catalog is visible through Paperclip.",
...httpLifecycle,
revoke: "Disable the active fixture connection and re-enable it for subsequent catalog paths.",
auditEvidence: "Activity and gateway audit rows show the allowed, approved, denied, quarantine, and revoke decisions.",
},
},
{
path: "P2",
title: "Remote HTTP MCP connection, API key",
transport: "mcp_remote",
authMode: "api_key",
smokeService: "HTTP MCP fixture with static fixture credential",
status: "ci_safe",
ciSafe: true,
uiEntryPath: "apps",
lifecycle: {
connect: "Install the HTTP fixture with fixture credential metadata.",
discoverCatalog: "Verify API-key-backed HTTP fixture catalog entries.",
...httpLifecycle,
revoke: "Disable the active fixture connection and re-enable it for subsequent catalog paths.",
auditEvidence: "Audit rows preserve API-key path decisions without exposing the credential.",
},
},
{
path: "P3",
title: "Local stdio MCP template",
transport: "local_stdio",
authMode: "none",
smokeService: "stdio MCP fixture template",
status: "ci_safe",
ciSafe: true,
uiEntryPath: "advanced",
lifecycle: {
connect: "Install the approved stdio template fixture.",
discoverCatalog: "Verify template catalog entries are visible.",
...stdioLifecycle,
revoke: "Disable the stdio fixture connection and re-enable it for subsequent catalog paths.",
auditEvidence: "Runtime/activity evidence attributes stdio fixture decisions.",
},
},
{
path: "P4",
title: "Plugin-provided integration",
transport: "plugin",
authMode: "plugin_install",
smokeService: "Smoke Lab fixture application standing in for plugin-provided catalog",
status: "ci_safe",
ciSafe: true,
uiEntryPath: "apps",
lifecycle: {
connect: "Exercise the catalog-backed app install path used by plugin-provided integrations.",
discoverCatalog: "Verify plugin-style application catalog entries are visible.",
...stdioLifecycle,
revoke: "Disable the plugin-style fixture connection and re-enable it for subsequent catalog paths.",
auditEvidence: "Activity rows preserve app install and lifecycle decisions.",
},
},
{
path: "P5",
title: "Paste-a-config / run-your-own import",
transport: "prosumer_import",
authMode: "config_import",
smokeService: "HTTP MCP fixture imported through advanced configuration",
status: "ci_safe",
ciSafe: true,
uiEntryPath: "advanced",
lifecycle: {
connect: "Exercise the advanced run-your-own configuration surface with the HTTP fixture.",
discoverCatalog: "Verify imported configuration catalog entries.",
...httpLifecycle,
revoke: "Disable the imported fixture connection and re-enable it for subsequent catalog paths.",
auditEvidence: "Advanced activity rows show import and governed calls.",
},
},
{
path: "P6",
title: "Token broker / gateway session",
transport: "gateway_session",
authMode: "run_scoped_token",
smokeService: "Tool gateway session over Smoke Lab HTTP fixture",
status: "ci_safe",
ciSafe: true,
uiEntryPath: "activity",
lifecycle: {
connect: "Create a run-scoped gateway session for a smoke agent.",
discoverCatalog: "List gateway-visible tools through the session token.",
...httpLifecycle,
revoke: "Revoke the gateway session and verify the token is cut off.",
auditEvidence: "Gateway audit rows show session creation, discovery, calls, and revocation.",
},
},
{
path: "P7",
title: "Governance surfaces",
transport: "governance",
authMode: "policy",
smokeService: "Profiles, ask-first policies, block policies, and quarantine fixtures",
status: "ci_safe",
ciSafe: true,
uiEntryPath: "review",
lifecycle: {
connect: "Install fixture connections and profile bindings.",
discoverCatalog: "Verify profile-governed catalog entries.",
...httpLifecycle,
revoke: "Revoke the temporary trust/policy changes.",
auditEvidence: "Review and Activity expose ask-first, block, quarantine, and revoke evidence.",
},
},
];
export function smokeLabScenarioByPath(path: SmokeRunStepPath): SmokeLabScenario {
const scenario = smokeLabScenarios.find((candidate) => candidate.path === path);
if (!scenario) throw new Error(`Unknown Smoke Lab scenario path: ${path}`);
return scenario;
}
export const ciSmokeLabScenarios = smokeLabScenarios.filter((scenario) => scenario.ciSafe);