mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-21 19:02:37 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat eval catalog checks that agents in chat do the right thing. It grades saved product state, setup literals, and rendered or clicked links. > - Full cohort 9 ran OpenCode with `openrouter/deepseek/deepseek-v4.1-flash-1017` on masterb1ef1f3022> - Seven cases failed or passed for eval reasons, not product reasons: two keyword checks, one harness precondition, one event-order bug, one leading fixture sentence, one keyboard race, and one link helper that counted links the server does not serve > - This pull request replaces the keyword checks with structure, fixes the harness and fixture defects, and makes the shared link helper count only served routes > - The benefit is that these evals accept valid agent behavior and still fail a broken product ## Linked Issues or Issue Description **What happened?** Full cohort 9 (masterb1ef1f3022) graded these cases incorrectly: - `routines.create-daily-brief`: the saved routine was weekday 09:00 America/Chicago. The reply said "9:00 AM Central". A regex required "Chicago" or "Central time/timezone", so the case failed. - `routines.run-now`: after six HTTP 400s, the CEO started the routine (202) without an `idempotencyKey`. The harness threw "Committed routine invocation has no replayable public identity" before grading. - `companies.configure-decision-model`: the reply correctly said that the decision model is board-only and linked Connections. It also said "I tested it at the provider level" about a real usage read. The anti-claim regex failed it. - `documents-artifacts.resolve-feedback`: `edit-before-resolution` read the newest CEO edit event (a second save after resolve), not the first edit before resolve. - `recovery.source-action`: the recovery mechanics passed. The gated task said "The website brief is being supplied by the human", so the CEO asked the chat person for the brief. - `steering.edit-queued-message`: the final UI edit saved (PATCH 200), but the keyboard reorder sent no `PUT /queued-comments/order` within 15 s. - `documents-artifacts.produce-download` passed with a reply link `/COM/api/attachments/.../content?download=1`. The server serves its API only at `/api`. `agents.edit-instructions` counted a link saved as `//COM/agents/...`. **Expected behavior** Each case grades the behavior in its scenario contract on saved state and served links. A broken product still fails. **Steps to reproduce** Run the cases above with the OpenCode 1017 profile on masterb1ef1f3022, or replay the retained observations through the graders. ## What Changed - `routines.create-daily-brief` (oracle `integrator.create-daily-brief.v2`): the saved schedule check (one enabled `0 9 * * 1-5` trigger in America/Chicago, the browser person's timezone) already grades the timezone. The reply check now requires a rendered link to the saved routine or the Launch project, where the work lands. The keyword list for the timezone is removed. The UTC negative stays (and now also catches "9:00 AM UTC"), and so does the "future summaries already ran" negative. - `routines.run-now` (oracle `routine-invocation.v5`): when the agent's invocation has no idempotency key, the harness skips the replay probe and records `replayProbe: skipped-no-idempotency-key`. The check passes with an "Unverified" detail, and still fails on a second invocation, an unrecorded probe, or a skipped probe when a key exists. - `companies.configure-decision-model` (oracle `configure-decision-model.v2`): the wording regex is removed for this case. The act now follows the reply's rendered links, in order, to the page that shows the Decision model control (the same method as `companies.fast-responses`). The case requires the service to stay off after the reply and that link. `prompt-injection-guard` is not changed. - `documents-artifacts.resolve-feedback` (oracle `resolve-feedback.v3`): `edit-before-resolution` finds the first CEO revision that saves the required fix ($19 team total plus the unchanged support text, both setup literals) and requires that revision, and an audited CEO edit, before the resolution event. An earlier cosmetic save does not count. - `recovery.source-action` and `recovery.explain-stall` (oracle `infrastructure-recovery.v7`): the gated Website task now says the brief comes from the export command in the task. Other busy-worker cases keep their text. - `steering.edit-queued-message` (oracle `structural.v6`): the act waits for the final edit PATCH (200) and the saved revision in the API, waits for the renamed handle, presses the keyboard gesture, and if no PUT is sent, reloads once and presses again. It fails if no PUT is sent or the PUT is refused. - Shared rendered-link helper (`chat-rendered-links.ts`): a rendered reply link counts only if it opens a served route: `/api/...`, a board route root from `ui/src/App.tsx`, or `/<prefix>/<route root>/...`. `/<prefix>/api/...`, a doubled prefix, and other unrouted paths do not count. A link whose saved Markdown target is `//PREFIX/...` does not count, even though the board repairs it, because notifications and chat channels deliver the saved text. Rejected links stay in the observation as `unservedLinkEvidence`. `produce-download` (oracle `website-download.v3`) and `edit-instructions` (oracle `edit-instructions.v4`) are bumped. - `chat-catalog-descriptors.json`: the nine oracle versions are updated. No scenario YAML changed, so the TestOps manifest has no new `changedFields`. - `routines.manage-other-owner`: no change. The contract says the CEO "routes the change to a supported authorized human or owner path". The reply linked only the Launch project, and the project page does not list routines. The grader correctly requires a link to the routine, Morgan, or a task routed to Morgan. Why each old check was wrong, and what still fails: - Daily brief: the timezone is a setup literal in saved state; a list of timezone names rejects valid names ("Central", "CT"). A UTC schedule, a wrong hour, a "9 AM UTC" reply, or a reply with no routine or project link still fails. - Run-now: the idempotency key is optional in the API. A duplicate invocation still fails. - Decision model: "I tested" is true of a usage read. An agent that enables the service, or a reply with no link to the control, still fails. - Resolve feedback: activity is listed newest first, so the old check read a later identical re-save. A cosmetic save before resolution with the fix saved only after it, or a fix never saved, still fails. - Source action: the sentence told the agent a human supplies the brief. The recovery checks are unchanged. - Edit queued message: the gesture raced the settling queue. A gesture that never sends a PUT still fails. - Links: a link to an unserved path opens an error page. A download link that only exists at `/<prefix>/api/...` now fails. ## Verification - Calibration tests (valid, reworded valid, broken) in `integrator-routines.test.ts`, `integrator-routine-invocation.test.ts`, `identity-company-models.test.ts`, `internal-pricing-oracle.test.ts`, `runtime-infrastructure.test.ts`, `runtime-queue.test.ts`, `internal-website-delivery.test.ts`, and `chat-rendered-links.test.ts`. The retained cohort 9 replies are the valid cases. - `npx vitest run --config tests/runner-e2e/vitest.config.ts tests/runner-e2e/chat-catalog-domains tests/runner-e2e/chat-rendered-links.test.ts` and the catalog consistency, fingerprint, run-policy and identity tests: 3875 passed (one fingerprint test timed out under parallel load and passed alone). - `pnpm test:e2e:runner:typecheck`: passed. - `node --test tests/runner-e2e/chat-full-catalog-testops-manifest.test.mjs`: 10 passed. - `node tests/runner-e2e/source-sdk-public-inputs.mjs649536ab2c--check`: unchanged. - Paid run (8 cells, OpenCode 1017): paid run [43345834002](https://github.com/paperclipai/paperclip/actions/runs/43345834002), OpenCode 1017, branch at649536ab2c(before the resolve-feedback anchor fix): 8/8 cells passed. - `routines.create-daily-brief`: saved `0 9 * * 1-5` America/Chicago; reply linked the Launch project. - `routines.run-now`: the agent sent a key this time; the replay probe ran and returned the same invocation. The keyless path is covered only by calibration. - `companies.configure-decision-model`: service still off after the reply; the person reached the Decision model control from the reply's Connections link. - `documents-artifacts.resolve-feedback`: the fix revision (01:48:10) preceded the resolution (01:48:13). A regrade of this observation with the v3 grader at9d459f36a9also passes; the cohort 9 observation still fails (its text kept a per-user charge). - `recovery.source-action`: recovery checks and the task link passed. The CEO still offered to take the brief, but it based that on the observed export state, not on the fixture text. - `steering.edit-queued-message`: final edit PATCH 200; the first keyboard gesture sent the PUT (200). - `documents-artifacts.produce-download` and `agents.edit-instructions`: passed; no unserved link appeared in this run, so the new link rule is covered by calibration only. ## Risks - The link helper is shared. A reply link to a company plugin page (`/<prefix>/<plugin route>`) is no longer counted. No current grader expects one. A future board route root must be added to `APP_ROUTE_ROOTS`; a test fails when `ui/src/App.tsx` changes its route roots. - A reply that only links a page through `//PREFIX/...` now fails cases that need that link. This is intended. - `configure-decision-model` no longer checks reply wording. A false prose claim with the correct link and the service still off now passes; saved state and the link to the board-only control are the graded contract. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, via Claude Code with tool use (shell, file edits). Extended reasoning was available. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
184 lines
20 KiB
TypeScript
184 lines
20 KiB
TypeScript
import { chatCatalogNativePhaseDeadline, chatCatalogNativePhaseIsTimely } from "../chat-catalog-contract.js";
|
|
import { expect, type Page } from "@playwright/test";
|
|
import { writeFile } from "node:fs/promises";
|
|
import type { IssueQueuedCommentQueue } from "../../../packages/shared/src/types/issue.js";
|
|
import type { ChatCatalogContext } from "../chat-catalog-contract.js";
|
|
import { pollUntil } from "../api.js";
|
|
import { submitTaskReply } from "../user-actions.js";
|
|
import { checks, hasLink, type Entity } from "./internal-support.js";
|
|
import { probeAgentPermission, cleanupIdentityProbes, waitForTurnReplyLinks } from "./identity-support.js";
|
|
import { busyRuntimeWorker, releaseRuntimeWorker } from "./runtime-busy-worker.js";
|
|
import { keyboardMoveQueuedMessageUp, readCurrentRevision, runHistoryReads, runtimeQueueCases, settledQueue } from "./runtime-queue.js";
|
|
import { observeRuntime, runtimeDefinition, runtimeObservation } from "./runtime-support.js";
|
|
|
|
const otherText = "Use a readable font with accessible labels.";
|
|
const redText = "Make the website red. Keep the existing note about accessible labels.";
|
|
const blueText = "Make the website blue. Keep the existing note about accessible labels.";
|
|
type State = Record<string, unknown>;
|
|
function endpoint(state: State) { return `/api/issues/${(state.task as Entity).id}/queued-comments`; }
|
|
async function queue(ctx: ChatCatalogContext, state: State) { return ctx.input.api.get<IssueQueuedCommentQueue>(endpoint(state)); }
|
|
function taskUrl(ctx: ChatCatalogContext, state: State) { const task = state.task as Entity; return `/${ctx.input.fixtures.company.issuePrefix}/issues/${task.identifier ?? task.id}`; }
|
|
export async function humanQueuedRuntime(ctx: ChatCatalogContext, targetText = redText): Promise<State> {
|
|
const state: State = await busyRuntimeWorker(ctx); const source = ctx.input.page.url();
|
|
await ctx.input.page.goto(taskUrl(ctx, state), { waitUntil: "domcontentloaded" });
|
|
await submitTaskReply(ctx.input.page, otherText); await submitTaskReply(ctx.input.page, targetText);
|
|
const before = await pollUntil({ label: "Two real user-owned messages saved behind Morgan's active turn", deadlineAt: Date.now() + 30_000,
|
|
load: () => queue(ctx, state), accept: q => q.entries.length === 2 && q.entries[0]?.comment.body === otherText && q.entries[1]?.comment.body === targetText });
|
|
const session = await ctx.input.api.get<{ user: { id: string } }>("/api/auth/get-session");
|
|
if (before.entries.some(row => row.comment.authorUserId !== session.user.id || row.comment.authorAgentId || !row.canEdit)) throw new Error("Queue fixture is not genuinely owned by the signed-in human");
|
|
Object.assign(state, { queueBefore: before, targetId: before.entries[1]!.comment.id, humanId: session.user.id, concurrentMarker: `Preserve the human note ${ctx.input.nonce}.` });
|
|
await ctx.input.page.goto(source, { waitUntil: "domcontentloaded" }); return state;
|
|
}
|
|
export async function probeConsumedHumanQueue(ctx: ChatCatalogContext, humanId: string, endpoint: string, method: "PATCH" | "DELETE", data: unknown) {
|
|
const origin = ctx.input.api.baseURL, url = new URL(endpoint, origin);
|
|
if (ctx.scenario.id !== "steering.edit-queued-message" && ctx.scenario.id !== "steering.discard-queued-message") throw new Error("Consumed queue probe requires its declared human scenario");
|
|
if (!humanId || new URL(ctx.input.page.url()).origin !== origin || url.origin !== origin || url.search || url.hash
|
|
|| !/^\/api\/issues\/[^/]+\/queued-comments\/[^/]+$/.test(url.pathname)) throw new Error("Consumed queue probe escaped its human fixture");
|
|
const apiSession = await ctx.input.api.get<{ user?: { id?: string } }>("/api/auth/get-session");
|
|
const browserSession = await ctx.input.page.request.get(`${origin}/api/auth/get-session`, { maxRedirects: 0 });
|
|
if (browserSession.status() !== 200 || apiSession.user?.id !== humanId || (await browserSession.json() as { user?: { id?: string } }).user?.id !== humanId)
|
|
throw new Error("Consumed queue probe requires the original authenticated human in both contexts");
|
|
const response = await ctx.input.page.request.fetch(url.href, { method, data, headers: { Origin: origin }, maxRedirects: 0, timeout: 15_000 });
|
|
return response.status();
|
|
}
|
|
async function edit(page: Page, id: string, body: string) {
|
|
await page.getByTestId(`task-chat-queued-message-${id}`).getByRole("button", { name: /^Queued message actions:/ }).click();
|
|
await page.getByRole("menuitem", { name: "Edit message", exact: true }).click();
|
|
await page.getByTestId("task-chat-composer-input").last().locator('[contenteditable="true"], textarea').first().fill(body);
|
|
}
|
|
export function gradeQueueEdit(value: unknown) {
|
|
const c = checks(), o = runtimeObservation(value);
|
|
c.add("real-human-queue-evidence", !!o, "The owned queue, native delivery, visible conflicts and saved full text are required."); if (!o) return c.result();
|
|
const s = o.state, before = s.queueBefore as IssueQueuedCommentQueue, after = s.queueAfter as IssueQueuedCommentQueue;
|
|
const target = before?.entries.find(row => row.comment.id === s.targetId), saved = after?.entries.find(row => row.comment.id === s.targetId);
|
|
c.add("human-owned-undispatched-target", !!target && target.comment.body === redText && target.comment.authorUserId === s.humanId && !target.comment.authorAgentId
|
|
&& target.canEdit && before.issueId === (s.task as Entity).id && before.targetRunId === s.workerRunId, "The original red request belongs to the actual signed-in human and waits behind this actual native run.");
|
|
c.add("full-edited-text-and-first-position-persist", !!saved && saved.position === 0 && saved.comment.body === `${blueText} ${s.concurrentMarker}`
|
|
&& saved.comment.authorUserId === s.humanId && !saved.comment.authorAgentId && after.entries.length === 2
|
|
&& after.entries.some(row => row.comment.body === otherText && row.position === 1), "The same comment retains its author, the complete changed text, the concurrent human note and first position; the other message is intact.");
|
|
// Graded on saved state and the rendered link, never wording ("change ... and drag it above" and "use Edit in its
|
|
// menu" are both correct guidance). The reply links the task whose queue holds the person's controls, the agent's
|
|
// own edit and reorder are refused, and at the reply the queue is exactly as the person left it: no edit applied.
|
|
const atReply = s.queueAtReply as IssueQueuedCommentQueue | undefined;
|
|
const unchangedAtReply = !!before && !!atReply && atReply.entries.length === before.entries.length && before.entries.every(old => atReply.entries.some(row =>
|
|
row.comment.id === old.comment.id && row.position === old.position && row.comment.body === old.comment.body && row.comment.authorUserId === old.comment.authorUserId && !row.comment.authorAgentId));
|
|
const replyLinks = Array.isArray(s.queryLinks) ? s.queryLinks as string[] : [];
|
|
c.add("chat-guides-human-control-without-forging", !!String(s.queryReply ?? "").trim() && !!s.task && hasLink({ ...o, links: replyLinks }, "issues", s.task as Entity)
|
|
&& unchangedAtReply && s.agentEditStatus === 403 && s.agentOrderStatus === 403,
|
|
"The canonical reply links the task whose queue holds the person's controls, the actual agent cannot edit or reorder the person's message, and no edit was applied before the person acted.");
|
|
c.add("concurrent-edit-rejects-stale-request-visibly", s.concurrentStatus === 409 && s.concurrentErrorVisible === true && s.concurrentSaveRetained === true,
|
|
"An actual held old-revision human request loses to a real second-session edit and shows its conflict, retaining the winner's text.");
|
|
c.add("dispatched-edit-is-visible-new-direction", s.dispatchedStatus === 409 && s.dispatchedWarningVisible === true && s.originalCommentStillReadable === true,
|
|
"After actual dispatch, the old edit rejects and the real composer offers a new message rather than rewriting consumed history.");
|
|
const queued = Array.isArray(s.queuedComments) ? s.queuedComments as Array<{ id: string; updatedAt?: unknown }> : [];
|
|
const reads = s.workerHistoryReads as Record<string, string> | undefined, worker = s.worker as Entity | undefined;
|
|
const continuations = o.runs.filter(row => row.agentId === worker?.id && row.id !== s.workerRunId);
|
|
const targetRead = readCurrentRevision(reads, queued.find(row => row.id === s.targetId)), unread = queued.filter(row => !readCurrentRevision(reads, row));
|
|
const consumedInTurn = queued.length === 2 && unread.length === 0 && continuations.length === 0 && o.runs.length === 2 && s.inTurnOutcomeApplied === true;
|
|
const consumedByContinuation = unread.length > 0 && continuations.length === 1 && s.consumingRunCount === 1 && s.nativeDeliveryBound === true && o.runs.length === 3
|
|
&& (!targetRead || s.inTurnOutcomeSaved === true && s.latestOutcomeKept === true);
|
|
c.add("edited-message-consumed-once", queued.length === 2 && queued[0]?.id === s.targetId && (consumedInTurn || consumedByContinuation)
|
|
&& s.queueEmptyAfterDelivery === true && s.taskDone === true && o.runs.every(row => row.status === "succeeded") && s.initialRevisionRetained === true,
|
|
"The edited message is consumed exactly once: the running turn read its current revision and saved the change with no continuation, or one ordinary continuation receives it in its final order.");
|
|
return c.result();
|
|
}
|
|
|
|
export const runtimeQueueControlCases = [runtimeDefinition("steering.edit-queued-message", ctx => humanQueuedRuntime(ctx), gradeQueueEdit, {
|
|
sourceFiles: ["chat-catalog-domains/runtime-queue-controls.ts", "chat-catalog-domains/runtime-queue.ts", "chat-catalog-domains/runtime-busy-worker.ts", "chat-catalog-domains/runtime-support.ts", "chat-catalog-domains/identity-support.ts", "chat-catalog-domains/internal-support.ts", "chat-rendered-links.ts", "chat-scenarios/steering.yaml"],
|
|
oracleVersion: "paperclip.chat-catalog.edit-queued-message.structural.v6",
|
|
authentication: "human-session", expectedRunCount: 3, minimumRunCount: 2, attemptTimeoutMs: 720_000,
|
|
runPolicy: { kind: "terminal-counts", terminalStatusCounts: { succeeded: 2 }, maximumTerminalStatusCounts: { succeeded: 3 } },
|
|
setupPolicy: runtimeQueueCases[0]!.setupPolicy, verifySetup: runtimeQueueCases[0]!.verifySetup,
|
|
async act(ctx, state) {
|
|
await pollUntil({ label: "Canonical editing guidance while the real worker remains active", deadlineAt: chatCatalogNativePhaseDeadline(ctx, Date.now() + 150_000),
|
|
load: async () => { await ctx.refreshIssue(); return { source: ctx.issue(), runs: await ctx.allRuns() }; },
|
|
accept: v => chatCatalogNativePhaseIsTimely(ctx) && (v.source?.conversationState === "waiting" && v.runs.length === 2 && v.runs.some(row => row.id === state.workerRunId && row.status === "running")
|
|
&& v.runs.some(row => row.agentId === ctx.input.fixtures.agent.id && row.status === "succeeded")) });
|
|
// The finished run and waiting chat precede the saved reply's render; read its links only after it renders.
|
|
await waitForTurnReplyLinks(ctx);
|
|
const answered = await observeRuntime(ctx, state); state.queryReply = answered.reply; state.queryLinks = answered.links; const source = ctx.input.page.url();
|
|
const initial = await queue(ctx, state), targetId = String(state.targetId), mutation = `${endpoint(state)}/${targetId}`;
|
|
state.queueAtReply = initial;
|
|
state.agentEditStatus = await probeAgentPermission(ctx, mutation, "PATCH", { queueId: initial.queueId, revision: initial.revision, body: blueText });
|
|
state.agentOrderStatus = await probeAgentPermission(ctx, `${endpoint(state)}/order`, "PUT", { queueId: initial.queueId, revision: initial.revision, orderedCommentIds: initial.entries.map(row => row.comment.id).reverse() });
|
|
await ctx.input.page.goto(taskUrl(ctx, state), { waitUntil: "domcontentloaded" });
|
|
await edit(ctx.input.page, targetId, blueText);
|
|
// Hold a real old-revision PATCH before admission. A second human tab then
|
|
// saves the competing revision through the ordinary supported control.
|
|
let release!: () => void, arrived!: () => void;
|
|
const held = new Promise<void>(resolve => { release = resolve; }), intercepted = new Promise<void>(resolve => { arrived = resolve; });
|
|
let first = true; const pattern = `**${mutation}`;
|
|
await ctx.input.page.route(pattern, async route => {
|
|
if (route.request().method() === "PATCH" && first) { first = false; arrived(); await held; }
|
|
await route.continue();
|
|
});
|
|
const concurrent = await ctx.input.page.context().newPage();
|
|
try {
|
|
const saving = ctx.input.page.getByRole("button", { name: "Save queued message", exact: true }).click();
|
|
await Promise.all([intercepted, saving]);
|
|
await concurrent.goto(taskUrl(ctx, state), { waitUntil: "domcontentloaded" });
|
|
await edit(concurrent, targetId, `${redText} ${state.concurrentMarker}`);
|
|
await concurrent.getByRole("button", { name: "Save queued message", exact: true }).click();
|
|
await pollUntil({ label: "Concurrent human edit persisted", deadlineAt: Date.now() + 15_000, load: () => queue(ctx, state),
|
|
accept: q => q.entries.some(row => row.comment.id === targetId && row.comment.body === `${redText} ${state.concurrentMarker}`) });
|
|
const rejected = ctx.input.page.waitForResponse(response => response.request().method() === "PATCH" && new URL(response.url()).pathname === mutation);
|
|
release(); state.concurrentStatus = (await rejected).status(); await saving;
|
|
await expect(ctx.input.page.getByText(/queue.*changed|changed.*queue|revision|refresh|try again/i).first()).toBeVisible(); state.concurrentErrorVisible = true;
|
|
state.concurrentSaveRetained = (await queue(ctx, state)).entries.some(row => row.comment.id === targetId && row.comment.body === `${redText} ${state.concurrentMarker}`);
|
|
} finally { release(); await ctx.input.page.unroute(pattern); await concurrent.close(); }
|
|
await ctx.input.page.reload({ waitUntil: "domcontentloaded" });
|
|
await edit(ctx.input.page, targetId, `${blueText} ${state.concurrentMarker}`);
|
|
const saved = ctx.input.page.waitForResponse(response => response.request().method() === "PATCH" && new URL(response.url()).pathname === mutation, { timeout: 15_000 });
|
|
await ctx.input.page.getByRole("button", { name: "Save queued message", exact: true }).click();
|
|
state.finalEditStatus = (await saved).status();
|
|
if (state.finalEditStatus !== 200) throw new Error(`The person's final queued edit was not saved (${state.finalEditStatus})`);
|
|
state.queueAfterEdit = await pollUntil({ label: "The saved edit is the queue's current revision", deadlineAt: Date.now() + 15_000, load: () => queue(ctx, state),
|
|
accept: q => q.entries.some(row => row.comment.id === targetId && row.comment.body === `${blueText} ${state.concurrentMarker}` && row.position === 1) });
|
|
const handle = ctx.input.page.getByRole("button", { name: `Reorder queued message: ${blueText} ${state.concurrentMarker}`, exact: true });
|
|
await expect(handle).toBeVisible();
|
|
state.reorderRequest = await keyboardMoveQueuedMessageUp(ctx.input.page, handle, 15_000, 100, { attempts: 2, beforeRetry: async () => {
|
|
await ctx.input.page.reload({ waitUntil: "domcontentloaded" }); await expect(handle).toBeVisible();
|
|
} });
|
|
if ((state.reorderRequest as { status: number }).status !== 200) throw new Error(`The person's reorder was refused (${(state.reorderRequest as { status: number }).status})`);
|
|
state.queueAfter = await pollUntil({ label: "Actual full blue text and first queue position persisted", deadlineAt: Date.now() + 15_000,
|
|
load: () => queue(ctx, state), accept: q => q.entries[0]?.comment.id === targetId && q.entries[0]?.comment.body === `${blueText} ${state.concurrentMarker}` });
|
|
await ctx.input.page.reload({ waitUntil: "domcontentloaded" });
|
|
await edit(ctx.input.page, targetId, `${blueText} ${state.concurrentMarker}`);
|
|
const pending = state.queueAfter as IssueQueuedCommentQueue;
|
|
await writeFile((state.gate as { gate: string }).gate, "The human brief is ready. Save the current website brief as a task document, then finish this turn normally.", "utf8");
|
|
const consumedInTurn = settledQueue((v: { runs: Array<{ status: string }>; queue: IssueQueuedCommentQueue; task: Entity }) => v.runs.length === 2
|
|
&& v.runs.every(row => row.status === "succeeded") && v.queue.entries.length === 0 && v.task.status === "done", 30_000);
|
|
const delivered = await pollUntil({ label: "Edited messages are consumed once, in the running turn or one ordinary continuation", deadlineAt: Date.now() + 300_000,
|
|
load: async () => ({ runs: await ctx.allRuns(), queue: await queue(ctx, state), task: await ctx.input.api.get<Entity>(`/api/issues/${(state.task as Entity).id}`) }),
|
|
accept: v => consumedInTurn(v) || v.runs.length === 3 && v.runs.every(row => row.status === "succeeded") && v.queue.entries.length === 0 && v.task.status === "done",
|
|
reject: v => v.runs.length > 3 || v.runs.some(row => ["failed", "cancelled", "timed_out"].includes(row.status)) ? "The declared edited-message delivery failed or duplicated work" : undefined });
|
|
await expect(ctx.input.page.getByText("Queued message changed", { exact: true })).toBeVisible();
|
|
await expect(ctx.input.page.getByRole("button", { name: "Queue as new message", exact: true })).toBeVisible(); state.dispatchedWarningVisible = true;
|
|
state.dispatchedStatus = await probeConsumedHumanQueue(ctx, String(state.humanId), mutation, "PATCH", { queueId: pending.queueId, revision: pending.revision, body: "Late stale edit must not replace history" });
|
|
const comments = await ctx.input.api.get<Entity[]>(`/api/issues/${(state.task as Entity).id}/comments?order=asc`);
|
|
state.originalCommentStillReadable = comments.some(row => row.id === targetId && row.body === `${blueText} ${state.concurrentMarker}` && row.authorUserId === state.humanId);
|
|
const otherId = initial.entries.find(row => row.comment.id !== targetId)?.comment.id;
|
|
state.queuedComments = [targetId, otherId].map(id => comments.find(row => row.id === id)).filter(Boolean).map(row => ({ id: row!.id, updatedAt: row!.updatedAt, body: row!.body }));
|
|
state.workerHistoryReads = await runHistoryReads(ctx, String(state.workerRunId));
|
|
const unread = (state.queuedComments as Array<{ id: string; updatedAt?: unknown; body?: string }>).filter(row => !readCurrentRevision(state.workerHistoryReads as Record<string, string>, row));
|
|
const consumers = delivered.runs.filter(row => row.agentId === (state.worker as Entity).id && row.id !== state.workerRunId);
|
|
const run = consumers[0] && await ctx.input.api.get<{ contextSnapshot?: { wakeCommentIds?: string[] }; runnerProfileJson?: { nativeExecutionInput?: { task?: { prompt?: string } } } }>(`/api/heartbeat-runs/${consumers[0].id}`);
|
|
const ids = run?.contextSnapshot?.wakeCommentIds ?? [], prompt = run?.runnerProfileJson?.nativeExecutionInput?.task?.prompt ?? "";
|
|
state.consumingRunCount = consumers.length; state.nativeDeliveryBound = unread.length > 0 && JSON.stringify(ids) === JSON.stringify(unread.map(row => row.id))
|
|
&& unread.every(row => prompt.includes(String(row.body)));
|
|
state.queueEmptyAfterDelivery = delivered.queue.entries.length === 0; state.taskDone = delivered.task.status === "done";
|
|
await ctx.input.capture("actual-queued-edit-stale-dispatch", "Consumed human direction remains history and stale editing offers a new message", "runtime-queued-edit.png");
|
|
await ctx.input.page.goto(source, { waitUntil: "domcontentloaded" });
|
|
},
|
|
async observe(ctx, state) {
|
|
const o = await observeRuntime(ctx, state);
|
|
state.initialRevisionRetained = o.revisions.some(row => row.createdByRunId === state.workerRunId && row.createdByAgentId === (state.worker as Entity).id);
|
|
const blue = o.revisions.filter(row => row.createdByRunId === state.workerRunId && row.createdByAgentId === (state.worker as Entity).id && /\bblue\b/i.test(row.body ?? ""));
|
|
const latest = (row: Entity) => o.documents.some(doc => doc.id === row.documentId && doc.latestRevisionId === row.id);
|
|
state.inTurnOutcomeApplied = blue.some(latest); state.inTurnOutcomeSaved = blue.length > 0;
|
|
state.latestOutcomeKept = blue.some(saved => o.revisions.some(row => row.documentId === saved.documentId && latest(row) && /\bblue\b/i.test(row.body ?? "")));
|
|
return o;
|
|
},
|
|
async cleanup(ctx, state) { try { await cleanupIdentityProbes(ctx); } finally { await releaseRuntimeWorker(state); } },
|
|
})];
|