Files
PaperClipAI/packages/paperclip-runner/scripts/runner-protocol-eval-workflow-security.test.mjs
T
DottaandPaperclip 3f91d58dd5 fix(ci): provide Copilot auth only to protected paid eval cells (#17743)
## Thinking Path

> - Paperclip manages AI agents and their work.
> - Paid runner evals test real provider integrations.
> - Copilot cells use the saved-token connection path.
> - The two trusted workflows did not pass the Copilot credential to
those cells.
> - This PR supplies it only when the selected cell needs it.
> - Existing environment and actor gates protect access in this public
repository.

## Linked Issues or Issue Description

Related: #15705 and #15706. A search found no open PR that adds this
workflow credential binding.

**Describe the bug**

Copilot Product and direct-protocol eval cells require
`COPILOT_GITHUB_TOKEN`. The protected paid workflows do not currently
pass that environment secret to the selected execution step.

**Expected behavior**

Only a selected Copilot cell receives this credential. Ordinary PR,
build, catalog, image and reporting jobs receive none.

**Steps to reproduce**

Dispatch the trusted full-stack workflow for one Copilot cell.
Credential validation fails before the task starts, although the
protected environment can hold a valid token.

**Environment**

GitHub Actions in the public `paperclipai/paperclip` repository, with
the reviewed workflow on `master` and the `runner-e2e-paid` environment.

## What Changed

- Pass `COPILOT_GITHUB_TOKEN` in the paid Product and direct-protocol
execution steps, only when `matrix.credentialName` selects it.
- Add the missing Copilot protocol-catalog credential mapping and verify
it reaches the selected execution matrix.
- Add security checks for the selected-cell binding and bounded
protected-job scope. Extend the scan that rejects provider credentials
in unrelated workflows.
- Document the Copilot credential scope. No secret values, account data
or private test evidence are in this PR.

## Verification

- Product workflow security: 16 tests passed on this head.
- Protocol catalog and workflow security: 21 tests passed, including the
Copilot matrix regression reproduced red before its fix.
- Current-head required `ci / verify` and `ci / e2e` are green. Greptile
is 5/5 with zero unresolved review threads.
- The first CI attempt retained runner-shutdown failures; one failed-job
retry passed on the unchanged head. Both attempts remain in [the CI
run](https://github.com/paperclipai/paperclip/actions/runs/40342429106).
- `git diff --check` passed.
- A selected-credential scan found zero matching secret values in the
seven changed files.
- The environment setting was separately checked: `master` only,
required approval from existing allowlisted code owners, and
administrator bypass disabled. The new secret exists only at environment
scope; no repository-wide duplicate was created.
- The packaged Copilot runtime verified the selected token and the
explicit model without a model prompt. A fresh local UI journey then
created an agent, completed its first task and verified the downloaded
artifact and cleanup.

## Risks

The selected paid cells gain access to one additional environment
credential. Missing credentials still fail closed. Default-branch
checks, initiating/rerunning actor checks, protected environment access
and per-cell credential selection remain in place. This PR adds no
trigger and gives no credential to builds or ordinary PR checks.

## Model Used

OpenAI Codex, based on GPT-6, with repository tools and browser
regression tests. The exact runtime model identifier is not exposed in
this session.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either linked existing issues or described the issue in-PR
following the relevant issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links
- [x] My branch name describes the change and contains no internal
ticket id
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-10-26 10:17:14 -05:00

294 lines
13 KiB
JavaScript

import assert from "node:assert/strict";
import { mkdtemp, mkdir, readFile, rm, writeFile } from "node:fs/promises";
import { spawnSync } from "node:child_process";
import { tmpdir } from "node:os";
import { resolve } from "node:path";
import test from "node:test";
const repositoryRoot = resolve(import.meta.dirname, "../../..");
const workflowPath = resolve(
repositoryRoot,
".github/workflows/runner-protocol-live-evals.yml",
);
const trustedPrWorkflowPath = resolve(
repositoryRoot,
".github/workflows/pr-trusted.yml",
);
test("Grok subscription credentials require explicit catalog selection and observed auth evidence", async () => {
const workflow = await readFile(workflowPath, "utf8");
const paid = workflow.slice(workflow.indexOf(" steps: &direct_eval_steps"), workflow.indexOf(" eval_shard_1:"));
assert.match(workflow, /grok_authentication:\n[\s\S]*?type: choice\n[\s\S]*?default: api_key/u);
assert.match(workflow, /--grok-authentication "\$GROK_AUTHENTICATION"/u);
assert.ok(paid.includes("PAPERCLIP_ACPX_GROK_AUTH_JSON_SECRET: ${{ matrix.credentialName == 'PAPERCLIP_ACPX_GROK_AUTH_JSON_SECRET' && secrets.GROK_AUTH_JSON || '' }}"));
assert.ok(paid.includes("XAI_API_KEY: ${{ matrix.credentialName == 'XAI_API_KEY' && secrets.XAI_API_KEY || '' }}"));
assert.match(paid, /--summary-path cell-output\/roster-summary\.json/u);
assert.match(paid, /JSON\.parse\(readFileSync\("cell-output\/roster-summary\.json", "utf8"\)\)\.authenticationMode/u);
assert.match(paid, /authenticationMode !== expected/u);
for (const job of [workflow.slice(0, workflow.indexOf(" eval_shard_0:")), workflow.slice(workflow.indexOf(" report:"))]) {
assert.doesNotMatch(job, /secrets\.GROK_AUTH_JSON/u);
}
});
test("direct live eval workflow keeps paid execution behind stable actor authorization", async () => {
const workflow = await readFile(workflowPath, "utf8");
assert.match(workflow, /^\s{2}authorize:/mu);
assert.match(workflow, /RUNNER_E2E_ALLOWED_ACTOR_IDS/u);
assert.match(workflow, /github\.actor_id/u);
assert.match(workflow, /github\.triggering_actor/u);
assert.match(workflow, /refs\/heads\/\$DEFAULT_BRANCH/u);
assert.match(workflow, /Reauthorize paid execution before provider access/u);
const copilotCredential = "COPILOT_GITHUB_TOKEN: ${{ matrix.credentialName == 'COPILOT_GITHUB_TOKEN' && secrets.COPILOT_GITHUB_TOKEN || '' }}";
assert.equal(workflow.split(copilotCredential).length - 1, 1);
const paid = workflow.slice(workflow.indexOf(" eval_shard_0:"), workflow.indexOf(" eval_shard_1:"));
assert.ok(paid.includes("name: runner-e2e-paid"));
assert.ok(paid.includes(copilotCredential));
const reauthorizationIndex = paid.indexOf("Reauthorize paid execution before provider access");
assert.ok(reauthorizationIndex >= 0);
assert.ok(reauthorizationIndex < paid.indexOf(copilotCredential));
assert.match(
workflow,
/Reauthorize paid execution before provider access[\s\S]*actions\/checkout@[0-9a-f]{40}[\s\S]*Run one immutable direct protocol cell/u,
);
assert.doesNotMatch(
workflow,
/^\s{2}(?:pull_request|pull_request_target|push|workflow_call|workflow_run):/mu,
);
const actions = [
...workflow.matchAll(/^\s*(?:-\s*)?uses:\s*([^\s#]+)/gmu),
].map((match) => match[1]);
assert.ok(actions.length > 0);
for (const action of actions) assert.match(action, /^[^@]+@[0-9a-f]{40}$/u);
});
test("pull request CI builds the canonical Evalbook viewer", async () => {
const workflow = await readFile(trustedPrWorkflowPath, "utf8");
const buildJob = workflow.slice(
workflow.indexOf(" build:"),
workflow.indexOf(" verify_serialized_server:"),
);
assert.match(
buildJob,
/name: Build Runner Evalbook viewer[\s\S]*pnpm --filter @paperclipai\/paperclip-runner build:issue-thread/u,
);
});
test("resolves both repositories immutably and bounds total matrix concurrency", async () => {
const workflow = await readFile(workflowPath, "utf8");
const targetLock = workflow.slice(
workflow.indexOf(" target_lock:"),
workflow.indexOf(" catalog:"),
);
assert.match(targetLock, /ref: \$\{\{ needs\.authorize\.outputs\.target_sha \}\}/u);
assert.match(targetLock, /pnpm install --ignore-scripts --no-frozen-lockfile --lockfile-only/u);
assert.match(targetLock, /Upload resolved target lockfile/u);
const build = workflow.slice(
workflow.indexOf(" build_runner:"),
workflow.indexOf(" eval_shard_0:"),
);
assert.match(build, /Download resolved target lockfile/u);
assert.match(build, /Restore resolved target lockfile/u);
const authorize = workflow.slice(
workflow.indexOf(" authorize:"),
workflow.indexOf(" catalog:"),
);
assert.match(authorize, /repos\/\$REPOSITORY\/branches\/\$encoded_branch/u);
assert.match(authorize, /\^\[0-9a-f\]\{40\}\$/u);
assert.match(
authorize,
/repos\/paperclipai\/paperclip-evals\/commits\/\$EVALS_SHA/u,
);
assert.match(authorize, /COMMITPERCLIP_KEY/u);
assert.match(authorize, /GH_REPO: paperclipai\/paperclip-evals/u);
assert.match(
authorize,
/GH_TOKEN: \$\{\{ steps\.evals_token\.outputs\.value \}\}/u,
);
assert.match(authorize, /test "\$resolved" = "\$EVALS_SHA"/u);
const catalog = workflow.slice(
workflow.indexOf(" catalog:"),
workflow.indexOf(" build_runner:"),
);
assert.match(
catalog,
/ref: \$\{\{ needs\.authorize\.outputs\.evals_sha \}\}/u,
);
assert.match(catalog, /RUNNER_E2E_MAX_PARALLEL/u);
assert.match(catalog, /max_parallel_per_shard/u);
const privateCheckouts = [
...workflow.matchAll(
/repository: paperclipai\/paperclip-evals[\s\S]*?persist-credentials: false/gmu,
),
];
assert.equal(privateCheckouts.length, 3);
const privateTokenSteps = [
...workflow.matchAll(
/^ - name: Generate private eval-repository token\n(?<body>(?:^ {8,}.*\n?)*)/gmu,
),
];
assert.equal(privateTokenSteps.length, 4);
for (const tokenStep of privateTokenSteps) {
assert.match(
tokenStep.groups.body,
/^ {10}GH_REPO: paperclipai\/paperclip-evals$/mu,
"every private-eval token must be minted from the eval repository installation",
);
}
for (const checkout of privateCheckouts) {
assert.match(
checkout[0],
/token: \$\{\{ steps\.evals_token\.outputs\.value \}\}/u,
);
}
assert.match(workflow, /matrix_0/u);
assert.match(workflow, /matrix_1/u);
assert.match(
workflow,
/pnpm --filter @paperclipai\/paperclip-runner deploy --prod/u,
);
assert.match(
workflow,
/--runner-cli runner-protocol-build\/extracted\/portable\/dist\/cli\/eval-session\.js/u,
);
assert.doesNotMatch(workflow, /npm install --prefix/u);
});
test("publishes only the separately sanitized Evalbook through trusted OIDC code", async () => {
const workflow = await readFile(workflowPath, "utf8");
const report = workflow.slice(
workflow.indexOf(" report:"),
workflow.indexOf(" publish_history:"),
);
assert.match(
report,
/Render the access-controlled canonical Evalbook report/u,
);
assert.match(
report,
/--viewer-root runner-protocol-build\/extracted\/dist-issue-thread/u,
);
assert.match(report, /runner-protocol-eval-campaign\.mjs sanitize/u);
assert.match(
report,
/Upload access-controlled canonical Evalbook and raw attempts/u,
);
assert.match(report, /Upload publisher-only sanitized Evalbook/u);
assert.match(
report,
/verify-runner-evalbook-viewer\.mjs --report-root runner-protocol-merged\/public-report/u,
);
assert.match(
report,
/verify-runner-evalbook-viewer\.mjs --report-root runner-protocol-merged\/report/u,
);
assert.match(
report,
/--viewer-root runner-protocol-build\/extracted\/dist-issue-thread\s*\\\n\s*--public-viewer/u,
);
assert.equal([...report.matchAll(/--viewer-root /gu)].length, 2);
const publisher = workflow.slice(workflow.indexOf(" publish_history:"));
assert.match(publisher, /ref: \$\{\{ github\.sha \}\}/u);
assert.match(publisher, /id-token: write/u);
assert.match(publisher, /runner-protocol-eval-public-/u);
assert.match(publisher, /publish-runner-protocol-eval-history\.mjs/u);
assert.match(publisher, /runner-protocol-evals/u);
assert.match(publisher, /runner-protocol-viewer-/u);
assert.match(publisher, /PAPERCLIP_RUNNER_PROTOCOL_EVAL_VIEWER_DIR/u);
assert.match(publisher, /url: \$\{\{ steps\.publish\.outputs\.report_url \}\}/u);
assert.match(publisher, /Publish versioned report and refresh the root index\n\s+id: publish/u);
assert.doesNotMatch(publisher, /(?:OPENAI|ANTHROPIC|OPENROUTER)_API_KEY/u);
assert.doesNotMatch(publisher, /paperclipai\/paperclip-evals/u);
assert.doesNotMatch(publisher, /downloaded-runner-protocol-evals/u);
});
test("provisions the Codex userns profile before any provider credentials", async () => {
const workflow = await readFile(workflowPath, "utf8");
const direct = workflow.slice(
workflow.indexOf(" steps: &direct_eval_steps"),
workflow.indexOf(" eval_shard_1:"),
);
const profile = direct.indexOf("Provision Codex sandbox on the disposable trusted runner");
const credentials = direct.indexOf("Prepare short-lived AgentCore web identity");
assert.ok(profile >= 0 && credentials >= 0 && profile < credentials);
assert.match(direct, /apparmor_restrict_unprivileged_userns/u);
assert.match(direct, /apparmor_parser/u);
assert.match(direct, /userns,/u);
assert.match(direct, /runner-protocol-build\/extracted\/portable/u);
assert.match(direct, /matrix\.provider == 'codex'/u);
assert.match(direct, /matrix\.rosterId == 'protocol-live-acpx-codex-control'/u);
assert.doesNotMatch(direct, /matrix\.profileId/u);
const build = workflow.slice(
workflow.indexOf(" build_runner:"),
workflow.indexOf(" eval_shard_0:"),
);
assert.match(build, /Materialize the pinned OpenCode executable before packaging/u);
assert.match(build, /materialize-opencode-binary\.mjs/u);
});
test("report preparation stays on the trusted lock and install mode", async () => {
const workflow = await readFile(workflowPath, "utf8");
const report = workflow.slice(
workflow.indexOf(" report:"),
workflow.indexOf(" publish_history:"),
);
assert.match(report, /ref: \$\{\{ github\.sha \}\}/u);
assert.doesNotMatch(report, /Download resolved target lockfile/u);
assert.doesNotMatch(report, /Restore resolved target lockfile/u);
assert.match(report, /Resolve trusted report lockfile without lifecycle scripts/u);
assert.match(report, /pnpm install --ignore-scripts --no-frozen-lockfile --lockfile-only/u);
assert.match(report, /pnpm install --frozen-lockfile --ignore-scripts\n/u);
});
test("trusted catalog, direct eval, and report orchestration stay on workflow revision", async () => {
const workflow = await readFile(workflowPath, "utf8");
for (const [job, next] of [
[" catalog:", " build_runner:"],
[" eval_shard_0:", " eval_shard_1:"],
[" report:", " publish_history:"],
]) {
const section = workflow.slice(workflow.indexOf(job), workflow.indexOf(next));
assert.match(section, /ref: \$\{\{ github\.sha \}\}/u, `${job} must use the trusted workflow revision`);
assert.doesNotMatch(section, /ref: \$\{\{ needs\.authorize\.outputs\.target_sha \}\}/u, `${job} must not execute target orchestration code`);
}
});
test("authentication failures retain cell metadata without leaking malformed summary content", async () => {
const workflow = await readFile(workflowPath, "utf8");
const script = workflow.match(/CELL_EXIT_CODE="\$status" node --input-type=module <<'NODE'\n([\s\S]*?) NODE/u)?.[1];
assert.ok(script);
const root = await mkdtemp(resolve(tmpdir(), "grok-cell-evidence-"));
try {
await mkdir(resolve(root, "cell-output"));
const summary = resolve(root, "cell-output/roster-summary.json");
for (const [content, expectedFailure, expectedMode] of [
[undefined, "grok_authentication_evidence_unreadable", undefined],
["{SENSITIVE_SENTINEL", "grok_authentication_evidence_unreadable", undefined],
["null", "grok_authentication_evidence_unreadable", undefined],
['{"authenticationMode":"SENSITIVE_SENTINEL"}', "grok_authentication_evidence_mismatch", undefined],
['{"authenticationMode":"api_key"}', "grok_authentication_evidence_mismatch", "api_key"],
['{"authenticationMode":"subscription"}', undefined, "subscription"],
]) {
if (content === undefined) await rm(summary, { force: true });
else await writeFile(summary, content);
const result = spawnSync(process.execPath, ["--input-type=module", "-e", script], {
cwd: root, encoding: "utf8",
env: { CREDENTIAL_NAME: "PAPERCLIP_ACPX_GROK_AUTH_JSON_SECRET", CELL_ID: "cell-1", CASE_ID: "context", ROSTER_FILE: "grok.json", CELL_EXIT_CODE: "7" },
});
assert.equal(result.status, expectedFailure ? 1 : 0);
const retained = await readFile(resolve(root, "cell-output/cell.json"), "utf8");
const metadata = JSON.parse(retained);
assert.equal(metadata.cellId, "cell-1");
assert.equal(metadata.caseId, "context");
assert.equal(metadata.exitCode, 7);
assert.equal(metadata.authenticationEvidenceFailure, expectedFailure);
assert.equal(metadata.authenticationMode, expectedMode);
assert.doesNotMatch(retained + result.stdout + result.stderr, /SENSITIVE_SENTINEL/u);
}
} finally {
await rm(root, { recursive: true, force: true });
}
});