mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-01 15:35:12 +01:00
## Thinking Path > - Paperclip must run the selected agent on its selected host. > - Claude needs verified packages for each supported target. > - A Mac controller must select the correct Linux provider pack. > - New defaults must follow package and execution evidence. > - This PR adds Claude platform packaging and target-specific pack selection. > - Existing Codex Linux ARM64 behavior remains intact. ## Linked Issues or Issue Description Refs #15683. This PR depends on #15993 and #15994. Related scope: #15422 and #15224. ## What Changed - Reuse the merged four-target daemon producer/consumer matrix. Add target-owned Linux provider packs and carry their immutable identities through release assembly and vendoring. - Reuse master’s landed pinned Claude SDK ARM64 executable admission and retain package-integrity, architecture and no-follow admission. - Select target-specific remote packs so Mac controllers can use Linux hosts without a development pack override. - Preserve read-only runtime context on SSH startup and resume without accepting unverified old content. - Check ordinary installed Claude readiness without injected package authority. Retain Codex and Linux x64 consumer checks. - Extend Claude automatic target selection for the remaining qualified package targets. Retain unsupported-platform and external-override behavior. - Qualify managed Daytona snapshot names through provider IDs during Claude Connect. Pin native acquisition to the measured ID. Preserve a revocation marker after failed probes or target edits, and block native acquisition until requalification instead of falling back to a mutable name. Preserve immutable-image proof, company and account boundaries, and Legacy acquisition. ## Verification - Reconciled with master `9179d8dcc3e908c217fde4f63c9d08ccf8132eeb` through the prerequisite stack, retaining the merged startup fix and latest Codex Linux ARM64 behavior. - [Four-target exact-source package qualification](https://github.com/paperclipai/paperclip/actions/runs/39267321383) passed on source `04e0202ca81387b17cbe7fd094a8338648356fe9`: all four native builds, public-package assembly, Linux x64 verification and clean installed consumers on Apple Silicon, Intel Mac and Linux ARM64. The later master reconciliation adds shared OpenRouter attribution and changes runtime source. This historical result keeps its original source identity; [later qualification](https://github.com/paperclipai/paperclip/actions/runs/39281100929) passed at `dca62c7aeb4b45f0dd91a8e18d386a16a2658ef8`. It predates the subsequent TypeScript startup fix. - Fresh local product acceptance on integrated source `b2c9fe43f9cd3bc5dd9d22552da0148845ba71a4` completed a useful file and follow-up through native Claude/Opus 5.5, High effort and the API-key connection. Both actual browser downloads were independently checked; the revision preserves the original body and session continuity. Total task estimates: $0.518432800. Ordinary web and API creation saved defaults with the native experiment disabled. - Local focused verification passed 993 startup/session tests, 243 UI tests, 12 workflow security tests, direct server/UI TypeScript checks, and token/palette gates before the last review changes. Initial DB-backed snapshot pin/revocation coverage passed 18 cases; the final serial route suites pass 122 credential/permission and 232 snapshot/environment cases after correcting a test hook timeout. Current-head cloud suites pass. - Preserved the failed pre-provider local fixture and its full pending reservation. The successful fixture has no unpriced or pending usage. Historical failed Cloud journeys, accounting holds, source identities and subscription limitations remain in the dated plan. - All Docker/Rust release production was performed in cloud CI. No local Docker image was built. An inadvertently invoked local Rust prerequisite was stopped. - Current-head cloud CI is green. All three stack PRs have fresh Greptile 5/5 reviews and zero unresolved review threads. Required typecheck, test and build gates ran in cloud CI; Docker work stayed remote. Earlier failed checks remain in their original runs. - The final master merge preserves task-loading, permission, skill-retention and OpenRouter changes. Pi uses a fresh combined profile 27, preserving both historical profile-24 declarations; Copilot remains profile 22. Focused protocol checks passed 155 cases (one skipped), the updated Pi attestation check passed 18 (one skipped), and 91 evaluation/catalog checks passed. - Latest-application manual continuation passed in 37.942 seconds on `695e5c005a85bddc8711d3fcddcaf6b7e1fb64d0`, with High effort, native Opus 5.5, Anthropic API attribution, the same resumed Claude session, an independently checked 635-byte file and persisted Done status. It uses the earlier verified Mac daemon; the preceding-source package qualification passed at `dca62c7aeb4b45f0dd91a8e18d386a16a2658ef8`. That package run predates the small TypeScript startup fix and is not relabeled as qualification for it. - Upgrade limitation: changed compiled sidecar identity rejected old durable launch state and recovery hit session-open bounds before eventually resuming. That attempt was operator-cancelled and retained; the successful manual continuation does not qualify seamless upgrades. - Local latency profile, Opus 5.5/High unchanged: three alternating real-ACP loopback samples per variant reduce median provider-ready time from 5.081s to 4.034s. The matched real API task startup improves from 5.533s to 4.348s, but total reply time changes from 17.933s to 20.221s because agent work varies. This establishes a startup saving of about one second, not a consistent total-reply speedup. A real candidate follow-up passed in 20.146s and resumed the same saved session. The loopback fixture makes no external model requests; failed initial probes remain retained. - The startup change passes 107 focused runtime/effort/lease tests, 53 profile checks (one skipped), TypeScript checking and the TypeScript-only runtime build. Native hire fixture checks pass 70 tests; their first local run retained a socket-hangup failure and stale OpenCode expectation, both accounted for before the passing rerun. Broader required checks run in cloud CI. ## Risks - **Experience needs improvement:** successful connection setup still shows “Connection needs attention” because runtime checks are deferred. Cold provider-pack upload took 122–126 seconds per run while the task mainly showed “Thinking.” The tested Core-only preview excludes private Cloud UI plugins; this is not full Cloud distribution or subscription qualification. Desktop dark theme was tested; mobile and comprehensive accessibility were not. The portable report validates, but gallery interaction could not be inspected because host preview was queued. - The optional supply-chain scan returned neutral/inconclusive because GitHub Actions package coverage and infrastructure parsing are unavailable. It is not counted as a successful supply-chain qualification. Exact package, daemon and image integrity checks passed. - A stale, missing or wrong-architecture pack must fail admission. It must not change runner or target silently. - Provider-pack source changes invalidate affected earlier execution results. Existing unknown-cost and cleanup holds remain intact. - Live subscription execution remains unverified under the API-key qualification direction. Built-in authentication flows are retained. ARM64 cloud-image production is deferred. Merge and production deployment remain separate. ## Model Used OpenAI Codex, GPT-6 family, with reasoning, repository tools, code execution and browser testing. The exact serving model ID and context-window size are not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [ ] Focused local tests and final cloud verification pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
259 lines
13 KiB
TypeScript
259 lines
13 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { assertValidAdapterLoginCapability } from "@paperclipai/adapter-utils";
|
|
import { listServerAdapters, requireServerAdapter } from "./registry.js";
|
|
import * as executionTarget from "@paperclipai/adapter-utils/execution-target";
|
|
import { BUILTIN_ADAPTER_TYPES } from "./builtin-adapter-types.js";
|
|
|
|
const { probeInstallation, probeGrokInstallation, probePiInstallation, verifyApiKey } = vi.hoisted(() => ({
|
|
verifyApiKey: vi.fn(),
|
|
probeInstallation: vi.fn(),
|
|
probeGrokInstallation: vi.fn(),
|
|
probePiInstallation: vi.fn(),
|
|
}));
|
|
vi.mock("../services/ai-api-key-test.js", () => ({ validateAiApiKey: verifyApiKey }));
|
|
vi.mock("../vendor/paperclip-runner/live/index.js", () => ({
|
|
probeAcpxClaudeInstallation: probeInstallation,
|
|
probeAcpxGrokInstallation: probeGrokInstallation,
|
|
probeAcpxPiInstallation: probePiInstallation,
|
|
probeAcpxCursorInstallation: vi.fn(async () => undefined),
|
|
}));
|
|
|
|
// The registry registers a login capability for the two built-in interactive
|
|
// adapters. The test checks the scalar values and the presence of the required
|
|
// callbacks. It also runs the shared validator, so the built-in capabilities
|
|
// obey the same fail-closed contract as an external adapter.
|
|
|
|
describe("built-in adapter login capabilities", () => {
|
|
it("registers the Codex device-login capability", () => {
|
|
const capability = requireServerAdapter("codex_local").loginCapability;
|
|
expect(capability).toBeDefined();
|
|
if (!capability) return;
|
|
expect(capability.panelMode).toBe("displayed_code");
|
|
expect(capability.timeoutPolicy).toBe("caller_bounded");
|
|
expect(capability.completionClaim).toBeUndefined();
|
|
expect(typeof capability.getCommand).toBe("function");
|
|
expect(typeof capability.parsePrompt).toBe("function");
|
|
expect(() => assertValidAdapterLoginCapability(capability, "codex_local")).not.toThrow();
|
|
});
|
|
|
|
it("registers the Grok device-login capability", () => {
|
|
const capability = requireServerAdapter("grok_local").loginCapability;
|
|
expect(capability).toBeDefined();
|
|
if (!capability) return;
|
|
expect(capability.panelMode).toBe("displayed_code");
|
|
expect(capability.timeoutPolicy).toBe("caller_bounded");
|
|
expect(capability.completionClaim).toBeUndefined();
|
|
expect(typeof capability.getCommand).toBe("function");
|
|
expect(typeof capability.parsePrompt).toBe("function");
|
|
expect(() => assertValidAdapterLoginCapability(capability, "grok_local")).not.toThrow();
|
|
});
|
|
|
|
it("registers the Claude setup-token capability", () => {
|
|
const capability = requireServerAdapter("claude_local").loginCapability;
|
|
expect(capability).toBeDefined();
|
|
if (!capability) return;
|
|
expect(capability.panelMode).toBe("submitted_browser_code");
|
|
expect(capability.timeoutPolicy).toBe("fixed");
|
|
expect(capability.completionClaim).toBe("storedSessionId");
|
|
expect(typeof capability.getCommand).toBe("function");
|
|
expect(typeof capability.parsePrompt).toBe("function");
|
|
expect(typeof capability.captureCredential).toBe("function");
|
|
expect(() => assertValidAdapterLoginCapability(capability, "claude_local")).not.toThrow();
|
|
});
|
|
});
|
|
|
|
describe("built-in runtime connection tool delivery", () => {
|
|
const expectedStrategies = new Map([
|
|
["acpx_local", "environment"],
|
|
["claude_local", "native_mcp"],
|
|
["codex_local", "native_mcp"],
|
|
["cursor_cloud", "invocation_context"],
|
|
["cursor", "environment"],
|
|
["gemini_local", "environment"],
|
|
["grok_local", "environment"],
|
|
["hermes_gateway", "invocation_context"],
|
|
["hermes_local", "environment"],
|
|
["kimi_local", "environment"],
|
|
["openclaw_gateway", "invocation_context"],
|
|
["opencode_local", "environment"],
|
|
["paperclip_runner", "environment"],
|
|
["pi_local", "environment"],
|
|
["process", "environment"],
|
|
["http", "invocation_context"],
|
|
] as const);
|
|
|
|
it("requires every built-in adapter to declare its expected delivery strategy", () => {
|
|
const builtIns = listServerAdapters().filter((adapter) => BUILTIN_ADAPTER_TYPES.has(adapter.type));
|
|
expect(new Set(builtIns.map((adapter) => adapter.type))).toEqual(BUILTIN_ADAPTER_TYPES);
|
|
expect(new Map(builtIns.map((adapter) => [adapter.type, adapter.runtimeToolDelivery]))).toEqual(
|
|
expectedStrategies,
|
|
);
|
|
});
|
|
|
|
it.each([...expectedStrategies])("delivers %s runtime tools through %s", (type, strategy) => {
|
|
expect(requireServerAdapter(type).runtimeToolDelivery).toBe(strategy);
|
|
});
|
|
});
|
|
|
|
|
|
describe("native ACPX environment checks", () => {
|
|
beforeEach(() => {
|
|
verifyApiKey.mockReset().mockResolvedValue(undefined);
|
|
probeInstallation.mockReset().mockResolvedValue(undefined);
|
|
probeGrokInstallation.mockReset().mockResolvedValue(undefined);
|
|
probePiInstallation.mockReset().mockResolvedValue(undefined);
|
|
});
|
|
afterEach(() => vi.restoreAllMocks());
|
|
|
|
const context = {
|
|
companyId: "company-test",
|
|
adapterType: "paperclip_runner",
|
|
config: { provider: "acpx", acpxAgent: "claude", model: "claude-sonnet-5" },
|
|
};
|
|
|
|
it("verifies a native Claude key without the global CLI or a model prompt", async () => {
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!({ ...context,
|
|
config: { ...context.config, env: { ANTHROPIC_API_KEY: "test-key" } },
|
|
});
|
|
expect(result.status).toBe("pass");
|
|
expect(verifyApiKey).toHaveBeenCalledExactlyOnceWith("anthropic", "test-key");
|
|
expect(result.checks.map(check => check.code)).toEqual(["acpx_runtime_ready", "ai_connection_api_key_reverified"]);
|
|
});
|
|
|
|
it.each(["ai_connection_api_key_rejected", "ai_connection_verification_failed"])("fails setup on %s", async code => {
|
|
verifyApiKey.mockRejectedValue({ details: { code } });
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!({ ...context,
|
|
config: { ...context.config, env: { ANTHROPIC_API_KEY: "test-key" } },
|
|
});
|
|
expect(result.status).toBe("fail");
|
|
expect(result.checks.at(-1)).toMatchObject({ code, level: "error" });
|
|
});
|
|
|
|
it.each(["ANTHROPIC_BASE_URL", "ANTHROPIC_AUTH_TOKEN", "CLAUDE_CODE_USE_BEDROCK", "CLAUDE_CODE_USE_VERTEX", "CLAUDE_CODE_USE_FOUNDRY"])("preserves the supplementary probe for custom routing via %s", async name => {
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!({ ...context,
|
|
config: { ...context.config, env: { ANTHROPIC_API_KEY: "test-key", [name]: "configured" } },
|
|
});
|
|
expect(verifyApiKey).not.toHaveBeenCalled();
|
|
expect(result.checks.some(check => check.code === "ai_connection_api_key_reverified")).toBe(false);
|
|
});
|
|
|
|
it("reports unsupported local platforms before a successful CLI login can mask them", async () => {
|
|
probeInstallation.mockRejectedValue(new Error("ACPX Claude requires a supported runtime platform"));
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!(context);
|
|
expect(result.status).toBe("fail");
|
|
expect(result.checks).toEqual([expect.objectContaining({
|
|
code: "acpx_runtime_unavailable",
|
|
level: "error",
|
|
})]);
|
|
});
|
|
|
|
it.each([
|
|
["claude", "claude-opus-5-5", "aarch64", "warn"],
|
|
["claude", "claude-opus-5-5", "arm64", "warn"],
|
|
["claude", "claude-opus-5-5", "armv7l", "fail"],
|
|
["grok", "grok-4.7", "aarch64", "fail"],
|
|
["pi", "openrouter/deepseek/deepseek-v4-flash-0731", "aarch64", "fail"],
|
|
])("checks the selected remote %s architecture %s without widening other providers", async (agent, model, architecture, status) => {
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!({ ...context,
|
|
config: { provider: "acpx", acpxAgent: agent, model },
|
|
executionTarget: { kind: "remote", transport: "sandbox", remoteCwd: "/workspace", providerKey: "test",
|
|
runner: { execute: vi.fn().mockResolvedValue({ exitCode: 0, timedOut: false, stdout: `Linux\n${architecture}\n` }) } },
|
|
});
|
|
expect(result.status).toBe(status);
|
|
expect(result.checks[0].code).toBe(status === "warn" ? "acpx_remote_runtime_unverified" : "acpx_runtime_unavailable");
|
|
expect(probeInstallation).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("identifies an incomplete installation and gives the operator a repair", async () => {
|
|
probeInstallation.mockRejectedValue(Object.assign(new Error("The Claude ACP runtime package is missing. Reinstall or rebuild Paperclip."), { code: "ACPX_RUNTIME_PACKAGE_MISSING" }));
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!(context);
|
|
expect(result.status).toBe("fail");
|
|
expect(result.checks[0]).toMatchObject({ code: "acpx_runtime_package_missing", message: expect.stringContaining("Reinstall or rebuild") });
|
|
});
|
|
|
|
it("requires a successful installed runtime probe", async () => {
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!(context);
|
|
expect(result.status).toBe("pass");
|
|
expect(probeInstallation).toHaveBeenCalledWith(context.config.model);
|
|
});
|
|
|
|
it.each([true, false])("checks Grok's own installation readiness (%s)", async (ready) => {
|
|
if (!ready) probeGrokInstallation.mockRejectedValueOnce(new Error("Grok executable digest mismatch"));
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!({
|
|
...context,
|
|
config: { provider: "acpx", acpxAgent: "grok", model: "grok-4.7" },
|
|
});
|
|
expect(result.status).toBe(ready ? "pass" : "fail");
|
|
expect(probeGrokInstallation).toHaveBeenCalledWith("grok-4.7");
|
|
expect(probeInstallation).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.each([true, false])("checks qualified Pi's own installation readiness (%s)", async (ready) => {
|
|
if (!ready) probePiInstallation.mockRejectedValueOnce(new Error("Pi installation integrity mismatch"));
|
|
const model = "openrouter/deepseek/deepseek-v4-flash-0731";
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!({
|
|
...context,
|
|
config: { provider: "acpx", acpxAgent: "pi", model },
|
|
});
|
|
expect(result.status).toBe(ready ? "pass" : "fail");
|
|
expect(probePiInstallation).toHaveBeenCalledWith(model);
|
|
expect(probeInstallation).not.toHaveBeenCalled();
|
|
expect(probeGrokInstallation).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("does not use the host platform to reject a remote environment", async () => {
|
|
vi.spyOn(process, "platform", "get").mockReturnValue("darwin");
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!({
|
|
...context,
|
|
executionTarget: {
|
|
kind: "remote", transport: "sandbox", remoteCwd: "/workspace", providerKey: "test",
|
|
runner: { execute: vi.fn().mockResolvedValue({ exitCode: 0, timedOut: false, stdout: "Linux\nx86_64\n" }) },
|
|
},
|
|
});
|
|
expect(result.status).toBe("warn");
|
|
expect(result.checks[0].code).toBe("acpx_remote_runtime_unverified");
|
|
expect(probeInstallation).not.toHaveBeenCalled();
|
|
});
|
|
|
|
const sshTarget = {
|
|
kind: "remote" as const, transport: "ssh" as const, remoteCwd: "/workspace",
|
|
spec: {
|
|
host: "example.test", port: 22, username: "tester", remoteCwd: "/workspace",
|
|
remoteWorkspacePath: "/workspace", privateKey: null, knownHosts: null, strictHostKeyChecking: true,
|
|
},
|
|
};
|
|
|
|
it.each([
|
|
["Linux\nx86_64\n", "warn"],
|
|
["Darwin\nx86_64\n", "warn"],
|
|
["Darwin\narm64\n", "warn"],
|
|
["Linux\naarch64\n", "warn"],
|
|
["Linux\narm64\n", "warn"],
|
|
["Linux\narmv7l\n", "fail"],
|
|
["", "fail"],
|
|
])("qualifies the SSH platform from its own uname output %j", async (stdout, status) => {
|
|
vi.spyOn(process, "platform", "get").mockReturnValue("linux");
|
|
vi.spyOn(process, "arch", "get").mockReturnValue("x64");
|
|
const probe = vi.spyOn(executionTarget, "runAdapterExecutionTargetShellCommand").mockResolvedValue({
|
|
exitCode: 0, timedOut: false, stdout, stderr: "", signal: null, pid: null, startedAt: new Date(0).toISOString(),
|
|
});
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!({ ...context, executionTarget: sshTarget });
|
|
expect(result.status).toBe(status);
|
|
expect(probe).toHaveBeenCalledWith(expect.any(String), sshTarget, "uname -s && uname -m", {
|
|
cwd: "/workspace", env: {}, timeoutSec: 15,
|
|
});
|
|
});
|
|
|
|
it.each(["timeout", "exit", "exception"])("does not qualify an SSH target after a probe %s", async (failure) => {
|
|
const probe = vi.spyOn(executionTarget, "runAdapterExecutionTargetShellCommand");
|
|
if (failure === "exception") probe.mockRejectedValue(new Error("connection unavailable"));
|
|
else probe.mockResolvedValue({
|
|
exitCode: failure === "exit" ? 1 : 0, timedOut: failure === "timeout",
|
|
stdout: "Linux\nx86_64\n", stderr: "", signal: null, pid: null, startedAt: new Date(0).toISOString(),
|
|
});
|
|
const result = await requireServerAdapter("paperclip_runner").testEnvironment!({ ...context, executionTarget: sshTarget });
|
|
expect(result.status).toBe("fail");
|
|
expect(result.checks[0].code).toBe("acpx_runtime_unavailable");
|
|
});
|
|
});
|