mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-20 15:09:57 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Agent runs need credentials for a specific provider and sign-in method. > - Connections already owns accounts, grants, and access permissions. > - AI authentication should use those same boundaries. > - This pull request adds the storage, API, adoption, and runtime foundation. > - Legacy agents keep their authentication until they explicitly adopt a managed connection. ## Linked Issues or Issue Description **Problem or motivation** AI credentials are configured separately from Connections. Agents cannot consistently reuse a responsible user's account or a permitted shared account. **Proposed solution** Manage AI accounts with the existing Connections grants and permissions. Keep model and harness selection independent from credential selection. Preserve legacy authentication until validated adoption. **Alternatives considered** A separate credential registry would duplicate ownership and access policy. Automatic fallback would risk using the wrong account. **Roadmap alignment** This extends the shipped Apps, multi-user, secrets, and agent-runtime capabilities. The maintainer requested the feature and reviewed the UI. Related groundwork: #11899 (connection permissions), #10910 (connection wizard), #11692 (Claude subscription profiles), and #11854 (Codex account rotation). ## What Changed - Add AI-purpose/runtime-auth contracts and an additive, idempotent migration. - Add Claude, OpenAI, OpenRouter, and Grok provider capabilities and catalog entries. - Store credentials on grants. Resolve responsible-user defaults or explicit permitted grants. - Isolate managed credentials and provider sessions across accounts. Block missing credentials without ambient fallback. - Keep imported legacy secrets unchanged during reconnect. Use independent local Codex/Grok sign-in attempts for rotating credentials. - Add authorization, migration, concurrent refresh, retry, cancellation, and legacy-compatibility tests. This is part 1 of a two-PR stack. The app UI follows in #13248. Merge the foundation first. ## Verification - Updated against master `04e364236`, preserving upstream provider login and connector workflows. - Full workspace typecheck, production build, Storybook build, and token gates passed on the integrated branch. Final local-login changes passed 59 focused tests; new-agent and inbox regression suites passed 63 tests. - Browser checks verified automatic local Claude account detection, resumable Codex login commands, retry, focus restoration, and desktop/phone layouts. Commands create their isolated directory before invoking the CLI. - All current-head CI checks passed on `2a996560a`, including all server/workspace tests, browser shards, runner verification, typecheck, build, and canary dry run. Greptile reviewed that commit at 5/5 with no unresolved threads. Earlier local full-suite attempts hit the Mac PostgreSQL shared-memory limit; the complete suites passed in CI. - Renumbered the additive AI migration to `0276` after upstream migrations and regenerated its snapshot. Existing legacy agents retain their configuration. - Added local login status checks, owner-scoped retry, managed OpenCode remote homes, credential-aware model discovery, and task connection-repair delivery. ## Risks - Managed credential failures intentionally block execution. They do not restore legacy fallback. - Preview-era copied Codex/Grok subscriptions require independent reconnect. - The integrated branch has live provider acceptance coverage. This update verifies local Claude detection and Codex API-key task repair; it does not add a new subscription authorization/refresh or Daytona stress pass. - Runtime-auth connections must stay excluded from tool and channel handling. ## Model Used OpenAI GPT-6 through Codex, with reasoning, repository tools, code execution, and browser testing. The exact runtime model identifier and context-window size are not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
52 lines
2.3 KiB
TypeScript
52 lines
2.3 KiB
TypeScript
import { aiConnectionLoginIntentSchema } from "../ai-connections.js";
|
|
import { z } from "zod";
|
|
import { AGENT_ADAPTER_TYPES } from "../constants.js";
|
|
import { ADAPTER_AUTH_SESSION_STATUSES } from "../types/agent.js";
|
|
|
|
const isoDateTime = z.union([z.date(), z.string().datetime()]);
|
|
|
|
// The public status schema. It accepts only the six public statuses. It rejects
|
|
// an unknown status and both internal states (`promoting`, `cleanup_pending`).
|
|
export const adapterAuthSessionStatusSchema = z.enum(ADAPTER_AUTH_SESSION_STATUSES);
|
|
export type AdapterAuthSessionStatus = z.infer<typeof adapterAuthSessionStatusSchema>;
|
|
|
|
export const adapterAuthSessionFailureSchema = z.object({
|
|
reason: z.string().min(1).max(200),
|
|
message: z.string().min(1).max(1000).nullable(),
|
|
}).strict();
|
|
export type AdapterAuthSessionFailure = z.infer<typeof adapterAuthSessionFailureSchema>;
|
|
|
|
// The public response schema. `.strict()` rejects an extra field, so a prompt, a
|
|
// token, an account identifier, or a provider lease identifier never validates.
|
|
export const adapterAuthSessionResponseSchema = z.object({
|
|
sessionId: z.string().guid(),
|
|
environmentId: z.string().guid(),
|
|
status: adapterAuthSessionStatusSchema,
|
|
expiresAt: isoDateTime.nullable(),
|
|
failure: adapterAuthSessionFailureSchema.nullable(),
|
|
}).strict();
|
|
export type AdapterAuthSessionResponse = z.infer<typeof adapterAuthSessionResponseSchema>;
|
|
|
|
export const adapterAuthSessionPromptSchema = z.object({
|
|
url: z.string().min(1),
|
|
code: z.string().min(1),
|
|
}).strict();
|
|
export type AdapterAuthSessionPrompt = z.infer<typeof adapterAuthSessionPromptSchema>;
|
|
|
|
// The owner read schema. It adds the one-time prompt to the public response.
|
|
export const adapterAuthSessionOwnerResponseSchema = adapterAuthSessionResponseSchema.extend({
|
|
prompt: adapterAuthSessionPromptSchema.nullable(),
|
|
aiConnection: aiConnectionLoginIntentSchema.optional(),
|
|
}).strict();
|
|
export type AdapterAuthSessionOwnerResponse =
|
|
z.infer<typeof adapterAuthSessionOwnerResponseSchema>;
|
|
|
|
export const startAdapterAuthSessionRequestSchema = z.object({
|
|
aiConnection: aiConnectionLoginIntentSchema.optional(),
|
|
environmentId: z.string().guid(),
|
|
adapterType: z.enum(AGENT_ADAPTER_TYPES),
|
|
ttlSeconds: z.number().int().min(60).max(24 * 60 * 60).optional(),
|
|
}).strict();
|
|
export type StartAdapterAuthSessionRequest =
|
|
z.infer<typeof startAdapterAuthSessionRequestSchema>;
|