mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-28 12:04:41 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - A stopped run can leave useful files in its original sandbox. > - The server keeps that sandbox when it cannot confirm file copyback. > - The task can then save new user input but offers no safe way to recover the files. > - A retry of the old agent turn can repeat work that already finished. > - This pull request recovers files through the existing workspace owner and delivers only saved human input. > - The user can recover a task without certifying infrastructure facts or losing completed work. ## Linked Issues or Issue Description Refs #16883 and #16835 for publication receipts and verified process termination. Related: #16478 clears stale holds after copyback already succeeded. This change performs the missing export and records its proof. #16901 manages the main GitHub response comment and does not perform workspace repair. **What happened?** A failed run retained its workspace. A later user message stayed saved behind a file-repair hold. The task asked the user to verify process termination and file recovery but offered no repair control. Sending a message could show an optimistic Working state and move the task to Todo before admission succeeded. **Expected behavior** The harness should recover the original files when it can prove ownership and termination. It should preserve newer edits and completed operations. Only waiting user input may start another turn. Missing evidence must keep the source held with a specific explanation. **Steps to reproduce** 1. Interrupt a sandbox run before workspace finalization succeeds. 2. Retain its exact allocation and save a user follow-up. 3. Observe the file-repair hold and missing end-user repair path. ## What Changed - Add source-bound background recovery for native and legacy runs. An accepted native result is not required. - Share the physical copyback lock and durable owner. Resume only the exact stopped allocation, export files, verify persistence and obtain a fresh stop receipt. - Persist retry limits and idempotent requests on the existing recovery record. Limit each server to two background exports. Add an indexed candidate scan and a separate cleanup obligation. - Add a task-editor recovery endpoint. Deny agents and viewers. Reject caller-supplied stop or repair claims. - Deliver waiting human input once through ordinary admission. Preserve pause, approval, budget and assignment gates. Require historical conversational-adapter evidence for legacy-to-Runner continuation. - Include exact GitHub publication receipts in continuation context. Preserve unknown effects and the original failed run. - Show observed recovery progress, a transient-failure retry action and specific service blockers. Keep saved messages visible. Suppress false startup feedback and implicit Todo promotion behind a file hold. Hide unavailable workspace links. - Update execution semantics, capability maps and production-component stories. ## Verification - Red: the original read model failed the new recovery-progress assertion; the other 23 checks in that file passed. - Passed: recovery regressions with 28 cases with real PostgreSQL, files, tar and Git operations. Lifecycle provider calls are controlled test boundaries. Coverage includes native/legacy export, concurrent owners, rollback after export, interrupted archive export with a new database connection, lost replies, historical discovery, durable retry limits, separate cleanup and saved-input delivery. The actual candidate query uses its partial index with 3,000 unrelated history rows. A first automatic repair can bind verified old-controller stop proof without an accepted native result. Review also reproduced and fixed export-only continuation and cleanup lost after a committed repair. Cleanup remains discoverable without waiting input and after task reconciliation. - Passed: two GitHub integration cases verify that continuation context carries the existing publication receipt and does not write another response. Company and task boundaries are checked. - Passed: 293 continuation, workspace-sync, platform-receipt and OpenAPI checks. After file repair, actual dispatch retains pause, cancellation, approval, real budget-policy and assignment gates. - Passed: 174 route checks, including editor admission, agent/viewer denial and rejection of fabricated repair claims. - Passed: 351 task detail, workspace properties and comment-reopen checks after updating the new read boundaries and asynchronous workspace-link expectations. Two new route cases keep held tasks Blocked when a comment is saved. - Passed: 265 task-thread and recovery-notice checks. The broader continuation suite also passed; its new legacy migration case first exposed a gap that the focused recovery suite now covers. - Passed after rebase: `pnpm -r typecheck` and `pnpm build`. The later master merge adds an unrelated permission migration; recovery migration generation and safety checks passed after the merge. - Passed: token gates, module boundaries, map structure and migration checks. The recovery index is migration 0360 after current master. - Browser: inspected the production recovery component and its retry-to-queued transition with fixture data. The first dev dependency load failed; a reload after optimization resolved it. This is UI evidence, not a live provider recovery claim. - Every test shard passed on final commit `bbbc09efb4`. The older local `pnpm test:run` was stopped after the complete CI test matrix passed. Local full typecheck and production build passed. The first CI build compiled and booted, then lost its runner during the clean public npm-install check. An isolated retry passed the build, production boot and clean public npm-install verification. - Greptile reviewed final commit `bbbc09efb4` at 5/5. All review threads are resolved. - The change is not deployed. Hosted recovery remains unverified until the served revision includes this change. ## Risks - Recovery crosses process, provider and persistence boundaries. Missing or mismatched ownership, stop, descriptor or file evidence keeps the hold. It never selects a replacement allocation or silently starts over. - File recovery does not certify external action outcomes or authorize replay. New input still uses normal execution admission. - Historical sources without sufficient durable evidence can remain blocked. Destructive reconstruction stays separate. - The index migration is idempotent. It changes no task data. Snapshot pruning follows repository policy. ## Model Used OpenAI Codex, `gpt-6.1-sol`, with code execution and browser tools. `gpt-6-astra` assisted earlier investigation. The runtime does not expose the context-window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
1022 lines
31 KiB
TypeScript
1022 lines
31 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import {
|
|
applyLocalQueuedIssueCommentState,
|
|
applyOptimisticIssueFieldUpdate,
|
|
applyOptimisticIssueFieldUpdateToCollection,
|
|
applyOptimisticIssueCommentUpdate,
|
|
createOptimisticIssueComment,
|
|
flattenIssueCommentPages,
|
|
getNextIssueCommentPageParam,
|
|
isQueuedIssueComment,
|
|
loadRemainingIssueCommentPages,
|
|
matchesIssueRef,
|
|
mergeIssueComments,
|
|
removeIssueCommentFromPages,
|
|
shouldAutoloadOlderIssueComments,
|
|
takeOptimisticIssueComment,
|
|
upsertIssueComment,
|
|
upsertIssueCommentInPages,
|
|
} from "./optimistic-issue-comments";
|
|
|
|
describe("optimistic issue comments", () => {
|
|
it("keeps a workspace-held task blocked when a follow-up is sent", () => {
|
|
const issue = { status: "blocked", executionBlocker: { workspaceRepairRequired: true } } as Issue;
|
|
expect(applyOptimisticIssueCommentUpdate(issue, { reopen: true })?.status).toBe("blocked");
|
|
});
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it("creates a pending optimistic comment for the current user", () => {
|
|
const comment = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Working on it",
|
|
authorUserId: "board-1",
|
|
});
|
|
|
|
expect(comment.id).toMatch(/^optimistic-/);
|
|
expect(comment.clientId).toBe(comment.id);
|
|
expect(comment.clientStatus).toBe("pending");
|
|
expect(comment.authorUserId).toBe("board-1");
|
|
expect(comment.authorAgentId).toBeNull();
|
|
});
|
|
|
|
it("falls back when crypto.randomUUID is unavailable", () => {
|
|
vi.stubGlobal("crypto", {});
|
|
const nowSpy = vi.spyOn(Date, "now").mockReturnValue(1_746_000_000_000);
|
|
const mathSpy = vi.spyOn(Math, "random").mockReturnValue(0.123456789);
|
|
|
|
const comment = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Working on it",
|
|
authorUserId: "board-1",
|
|
});
|
|
|
|
expect(comment.id).toBe("optimistic-1746000000000-4fzzzxjy");
|
|
expect(comment.clientId).toBe(comment.id);
|
|
|
|
nowSpy.mockRestore();
|
|
mathSpy.mockRestore();
|
|
});
|
|
|
|
it("supports queued optimistic comments for active-run follow-ups", () => {
|
|
const comment = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Queue this",
|
|
authorUserId: "board-1",
|
|
clientStatus: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
|
|
expect(comment.clientStatus).toBe("queued");
|
|
expect(comment.queueTargetRunId).toBe("run-1");
|
|
});
|
|
|
|
it("merges optimistic comments into the server thread in chronological order", () => {
|
|
const merged = mergeIssueComments(
|
|
[
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Second",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "optimistic-1",
|
|
clientId: "optimistic-1",
|
|
clientStatus: "pending",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "First",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
);
|
|
|
|
expect(merged.map((comment) => comment.id)).toEqual(["optimistic-1", "comment-2"]);
|
|
});
|
|
|
|
it("reconciles an optimistic comment with its canonical server copy", () => {
|
|
const optimistic = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Do not flash twice",
|
|
authorUserId: "board-1",
|
|
});
|
|
const { clientId: _clientId, clientStatus: _clientStatus, queueTargetRunId: _queueTargetRunId, ...persisted } = optimistic;
|
|
|
|
const merged = mergeIssueComments(
|
|
[{ ...persisted, id: "comment-1" }],
|
|
[optimistic],
|
|
);
|
|
|
|
expect(merged.map((comment) => comment.id)).toEqual(["comment-1"]);
|
|
expect(merged[0]).toMatchObject({ clientId: optimistic.clientId });
|
|
});
|
|
|
|
it("reconciles repeated identical comments one-for-one", () => {
|
|
const first = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Same text",
|
|
authorUserId: "board-1",
|
|
});
|
|
const second = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Same text",
|
|
authorUserId: "board-1",
|
|
});
|
|
const { clientId: _clientId, clientStatus: _clientStatus, queueTargetRunId: _queueTargetRunId, ...persisted } = first;
|
|
|
|
const merged = mergeIssueComments(
|
|
[{ ...persisted, id: "comment-1" }],
|
|
[first, second],
|
|
);
|
|
|
|
expect(merged).toHaveLength(2);
|
|
expect(merged.map((comment) => comment.id)).toContain("comment-1");
|
|
expect(merged.map((comment) => comment.id)).toContain(second.id);
|
|
});
|
|
|
|
it("keeps repeated identical optimistic comments when neither is persisted", () => {
|
|
const first = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Same pending text",
|
|
authorUserId: "board-1",
|
|
});
|
|
const second = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Same pending text",
|
|
authorUserId: "board-1",
|
|
});
|
|
|
|
expect(mergeIssueComments([], [first, second])).toHaveLength(2);
|
|
});
|
|
|
|
it("can take one optimistic queued comment back out of the queue", () => {
|
|
const first = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "First",
|
|
authorUserId: "board-1",
|
|
clientStatus: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
const second = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Second",
|
|
authorUserId: "board-1",
|
|
clientStatus: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
|
|
const result = takeOptimisticIssueComment([first, second], first.clientId);
|
|
|
|
expect(result.comment?.body).toBe("First");
|
|
expect(result.comments.map((comment) => comment.clientId)).toEqual([second.clientId]);
|
|
});
|
|
|
|
it("upserts confirmed comments without creating duplicates", () => {
|
|
const next = upsertIssueComment(
|
|
[
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Original",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
],
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Updated",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:05.000Z"),
|
|
},
|
|
);
|
|
|
|
expect(next).toHaveLength(1);
|
|
expect(next[0]?.body).toBe("Updated");
|
|
});
|
|
|
|
it("flattens paged comments into one chronological thread", () => {
|
|
const flattened = flattenIssueCommentPages([
|
|
[
|
|
{
|
|
id: "comment-3",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Newest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Oldest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Middle",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
],
|
|
]);
|
|
|
|
expect(flattened.map((comment) => comment.id)).toEqual(["comment-1", "comment-2", "comment-3"]);
|
|
});
|
|
|
|
it("returns no next page param when the last page is missing", () => {
|
|
expect(getNextIssueCommentPageParam(undefined, 50)).toBeUndefined();
|
|
});
|
|
|
|
it("returns the oldest id when the last page is full", () => {
|
|
expect(
|
|
getNextIssueCommentPageParam(
|
|
[
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Second",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "First",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
2,
|
|
),
|
|
).toBe("comment-1");
|
|
});
|
|
|
|
it("loads remaining comment pages until the terminal partial page", async () => {
|
|
const fetchPage = vi.fn(async (afterCommentId: string) => {
|
|
if (afterCommentId === "comment-3") return [{ id: "comment-2" }, { id: "comment-1" }];
|
|
if (afterCommentId === "comment-1") return [{ id: "comment-0" }];
|
|
return [];
|
|
});
|
|
|
|
const loaded = await loadRemainingIssueCommentPages({
|
|
pages: [[{ id: "comment-4" }, { id: "comment-3" }]],
|
|
pageParams: [null],
|
|
pageSize: 2,
|
|
fetchPage,
|
|
});
|
|
|
|
expect(fetchPage).toHaveBeenCalledTimes(2);
|
|
expect(fetchPage).toHaveBeenNthCalledWith(1, "comment-3");
|
|
expect(fetchPage).toHaveBeenNthCalledWith(2, "comment-1");
|
|
expect(loaded.pages.map((page) => page.map((comment) => comment.id))).toEqual([
|
|
["comment-4", "comment-3"],
|
|
["comment-2", "comment-1"],
|
|
["comment-0"],
|
|
]);
|
|
expect(loaded.pageParams).toEqual([null, "comment-3", "comment-1"]);
|
|
});
|
|
|
|
it("autoloads older chat comments while the initial thread is still under the threshold", () => {
|
|
expect(
|
|
shouldAutoloadOlderIssueComments({
|
|
activeDetailTab: "chat",
|
|
hasOlderComments: true,
|
|
loadedCommentCount: 50,
|
|
initialPageLoading: false,
|
|
olderPageLoading: false,
|
|
autoLoadLimit: 150,
|
|
}),
|
|
).toBe(true);
|
|
});
|
|
|
|
it("does not autoload older comments outside the chat tab", () => {
|
|
expect(
|
|
shouldAutoloadOlderIssueComments({
|
|
activeDetailTab: "activity",
|
|
hasOlderComments: true,
|
|
loadedCommentCount: 50,
|
|
initialPageLoading: false,
|
|
olderPageLoading: false,
|
|
autoLoadLimit: 150,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("stops autoloading once the initial comment window reaches the cap", () => {
|
|
expect(
|
|
shouldAutoloadOlderIssueComments({
|
|
activeDetailTab: "chat",
|
|
hasOlderComments: true,
|
|
loadedCommentCount: 150,
|
|
initialPageLoading: false,
|
|
olderPageLoading: false,
|
|
autoLoadLimit: 150,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("upserts paged comments without dropping older pages", () => {
|
|
const nextPages = upsertIssueCommentInPages(
|
|
[
|
|
[
|
|
{
|
|
id: "comment-3",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Newest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Oldest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
],
|
|
{
|
|
id: "comment-4",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Brand new",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:04.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:04.000Z"),
|
|
},
|
|
);
|
|
|
|
expect(nextPages[0]?.map((comment) => comment.id)).toEqual(["comment-4", "comment-3"]);
|
|
expect(nextPages[1]?.map((comment) => comment.id)).toEqual(["comment-1"]);
|
|
});
|
|
|
|
it("removes a confirmed queued comment from paged caches", () => {
|
|
const nextPages = removeIssueCommentFromPages(
|
|
[
|
|
[
|
|
{
|
|
id: "comment-3",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Newest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Middle",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Oldest",
|
|
authorType: "user",
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
],
|
|
"comment-2",
|
|
);
|
|
|
|
expect(nextPages).toHaveLength(2);
|
|
expect(nextPages[0]?.map((comment) => comment.id)).toEqual(["comment-3"]);
|
|
expect(nextPages[1]?.map((comment) => comment.id)).toEqual(["comment-1"]);
|
|
});
|
|
|
|
it("applies optimistic reopen and reassignment updates to the issue cache", () => {
|
|
const next = applyOptimisticIssueCommentUpdate(
|
|
{
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Fix comment flow",
|
|
description: null,
|
|
status: "done",
|
|
workMode: "standard",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 1,
|
|
identifier: "PAP-1",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
reopen: true,
|
|
reassignment: {
|
|
assigneeAgentId: null,
|
|
assigneeUserId: "board-2",
|
|
},
|
|
},
|
|
);
|
|
|
|
expect(next?.status).toBe("todo");
|
|
expect(next?.assigneeAgentId).toBeNull();
|
|
expect(next?.assigneeUserId).toBe("board-2");
|
|
});
|
|
|
|
it("applies optimistic field updates for issue property edits", () => {
|
|
const next = applyOptimisticIssueFieldUpdate(
|
|
{
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: "project-1",
|
|
projectWorkspaceId: "workspace-1",
|
|
goalId: null,
|
|
parentId: null,
|
|
ancestors: [
|
|
{
|
|
id: "issue-9",
|
|
identifier: "PAP-9",
|
|
title: "Old parent",
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
projectId: null,
|
|
goalId: null,
|
|
project: null,
|
|
goal: null,
|
|
},
|
|
],
|
|
title: "Fix property pane",
|
|
description: null,
|
|
status: "todo",
|
|
workMode: "standard",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 1,
|
|
identifier: "PAP-1",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: "exec-1",
|
|
executionWorkspacePreference: "shared_workspace",
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
labelIds: ["label-1", "label-2"],
|
|
labels: [
|
|
{
|
|
id: "label-1",
|
|
companyId: "company-1",
|
|
name: "One",
|
|
color: "#111111",
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
id: "label-2",
|
|
companyId: "company-1",
|
|
name: "Two",
|
|
color: "#222222",
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
],
|
|
blockedBy: [
|
|
{
|
|
id: "issue-2",
|
|
identifier: "PAP-2",
|
|
title: "First blocker",
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
},
|
|
{
|
|
id: "issue-3",
|
|
identifier: "PAP-3",
|
|
title: "Second blocker",
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
},
|
|
],
|
|
blocks: [],
|
|
project: {
|
|
id: "project-1",
|
|
companyId: "company-1",
|
|
urlKey: "project-one",
|
|
goalId: null,
|
|
goalIds: [],
|
|
goals: [],
|
|
name: "Project one",
|
|
description: null,
|
|
status: "in_progress",
|
|
leadAgentId: null,
|
|
targetDate: null,
|
|
color: null,
|
|
icon: null,
|
|
env: null,
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
executionWorkspacePolicy: null,
|
|
codebase: {
|
|
workspaceId: null,
|
|
repoUrl: null,
|
|
repoRef: null,
|
|
defaultRef: null,
|
|
repoName: null,
|
|
localFolder: null,
|
|
managedFolder: "/tmp/paperclip",
|
|
effectiveLocalFolder: "/tmp/paperclip",
|
|
origin: "local_folder",
|
|
},
|
|
workspaces: [],
|
|
primaryWorkspace: null,
|
|
archivedAt: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
currentExecutionWorkspace: {
|
|
id: "exec-1",
|
|
companyId: "company-1",
|
|
projectId: "project-1",
|
|
projectWorkspaceId: null,
|
|
sourceIssueId: "issue-1",
|
|
mode: "shared_workspace",
|
|
strategyType: "project_primary",
|
|
branchName: null,
|
|
status: "active",
|
|
deliveryState: "unknown",
|
|
name: "Execution workspace",
|
|
cwd: "/tmp/paperclip",
|
|
repoUrl: null,
|
|
baseRef: null,
|
|
providerType: "local_fs",
|
|
providerRef: null,
|
|
derivedFromExecutionWorkspaceId: null,
|
|
lastUsedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
cleanupEligibleAt: null,
|
|
cleanupReason: null,
|
|
config: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
openedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
closedAt: null,
|
|
},
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
status: "in_review",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: "board-2",
|
|
labelIds: ["label-2"],
|
|
blockedByIssueIds: ["issue-3"],
|
|
parentId: "issue-4",
|
|
projectId: "project-2",
|
|
executionWorkspaceId: "exec-2",
|
|
},
|
|
);
|
|
|
|
expect(next?.status).toBe("in_review");
|
|
expect(next?.assigneeAgentId).toBeNull();
|
|
expect(next?.assigneeUserId).toBe("board-2");
|
|
expect(next?.labelIds).toEqual(["label-2"]);
|
|
expect(next?.labels?.map((label) => label.id)).toEqual(["label-2"]);
|
|
expect(next?.blockedBy?.map((relation) => relation.id)).toEqual(["issue-3"]);
|
|
expect(next?.parentId).toBe("issue-4");
|
|
expect(next?.ancestors).toBeUndefined();
|
|
expect(next?.projectId).toBe("project-2");
|
|
expect(next?.project).toBeNull();
|
|
expect(next?.executionWorkspaceId).toBe("exec-2");
|
|
expect(next?.currentExecutionWorkspace).toBeNull();
|
|
});
|
|
|
|
it("matches issues by either uuid or identifier reference", () => {
|
|
expect(matchesIssueRef({ id: "issue-1", identifier: "PAP-1" } as const, ["issue-1"])).toBe(true);
|
|
expect(matchesIssueRef({ id: "issue-1", identifier: "PAP-1" } as const, ["PAP-1"])).toBe(true);
|
|
expect(matchesIssueRef({ id: "issue-1", identifier: "PAP-1" } as const, ["issue-2", "PAP-2"])).toBe(false);
|
|
});
|
|
|
|
it("applies optimistic field updates across cached issue collections", () => {
|
|
const issues: Issue[] = [
|
|
{
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Fix property pane",
|
|
description: null,
|
|
status: "todo",
|
|
workMode: "standard",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 1,
|
|
identifier: "PAP-1",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
labelIds: [],
|
|
labels: [],
|
|
blockedBy: [],
|
|
blocks: [],
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
id: "issue-2",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Leave me alone",
|
|
description: null,
|
|
status: "todo",
|
|
workMode: "standard",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: "agent-2",
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 2,
|
|
identifier: "PAP-2",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
labelIds: [],
|
|
labels: [],
|
|
blockedBy: [],
|
|
blocks: [],
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
];
|
|
|
|
const next = applyOptimisticIssueFieldUpdateToCollection(issues, ["PAP-1"], { assigneeAgentId: "agent-9" });
|
|
|
|
expect(next?.[0]?.assigneeAgentId).toBe("agent-9");
|
|
expect(next?.[1]?.assigneeAgentId).toBe("agent-2");
|
|
});
|
|
|
|
it("treats comments without a run id as queued when they arrive during an active run", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
id: "comment-2",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunWakeCommentId: "comment-1",
|
|
runId: null,
|
|
}),
|
|
).toBe(true);
|
|
});
|
|
|
|
it("does not mark the comment that triggered the active run as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
id: "comment-1",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunCommentId: "comment-1",
|
|
activeRunWakeCommentId: "comment-1",
|
|
runId: null,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark the active run context comment as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
id: "context-comment",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunCommentId: "context-comment",
|
|
activeRunWakeCommentId: "wake-comment",
|
|
runId: null,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark the active run wake comment as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
id: "wake-comment",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunCommentId: "context-comment",
|
|
activeRunWakeCommentId: "wake-comment",
|
|
runId: null,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark comments with an associated run as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
runId: "run-1",
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark interrupt comments as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
interruptedRunId: "run-1",
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark comments from the active run agent as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
authorAgentId: "agent-1",
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunAgentId: "agent-1",
|
|
runId: null,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("keeps a confirmed queued comment queued while the target run is still live", () => {
|
|
const comment = {
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Follow up after the active run",
|
|
authorType: "user" as const,
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
updatedAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
};
|
|
|
|
const result = applyLocalQueuedIssueCommentState(comment, {
|
|
queuedTargetRunId: "run-1",
|
|
targetRunIsLive: true,
|
|
runningRunId: "run-1",
|
|
});
|
|
|
|
expect(result).toMatchObject({
|
|
id: "comment-1",
|
|
clientStatus: "queued",
|
|
queueState: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
});
|
|
|
|
it("does not keep local queued state after the target run is no longer live", () => {
|
|
const comment = {
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Follow up after the active run",
|
|
authorType: "user" as const,
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
updatedAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
};
|
|
|
|
const result = applyLocalQueuedIssueCommentState(comment, {
|
|
queuedTargetRunId: "run-1",
|
|
targetRunIsLive: false,
|
|
runningRunId: null,
|
|
});
|
|
|
|
expect(result).toBe(comment);
|
|
});
|
|
|
|
it("does not keep local queued state when a different run is live", () => {
|
|
const comment = {
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Follow up after the active run",
|
|
authorType: "user" as const,
|
|
presentation: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
updatedAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
};
|
|
|
|
const result = applyLocalQueuedIssueCommentState(comment, {
|
|
queuedTargetRunId: "run-1",
|
|
targetRunIsLive: true,
|
|
runningRunId: "run-2",
|
|
});
|
|
|
|
expect(result).toBe(comment);
|
|
});
|
|
});
|