mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-24 10:13:11 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Product E2E campaigns include model, setup, storage and observability costs. > - Some billing windows close after the tests and reports finish. > - Requiring settled receipts for retained storage can block a good campaign for weeks. > - A reservation alone does not prove that a pending charge has an upper bound. > - This change permits provisional completion only with reviewed evidence for the exact cost configuration. > - Reports preserve unknown amounts and holds until later reconciliation. ## Linked Issues or Issue Description Refs: #17360, #17354 **What existing behavior does this improve?** The Product E2E scheduled accounting gate and its retained cost reports. **Current behavior** Every pending receipt fails finalization. A completed test can wait through the retained-storage billing window. The journal has dollar reservations but no explicit qualification of their bounds. **Proposed behavior** Permit provisional completion when all pending charges have reviewed full-lifecycle bounds, no requests remain in flight, no receipts conflict, and known costs plus held amounts fit the campaign limit. Keep all existing holds and receipt-finality rules. Missing evidence still fails. **Reason and benefit** An operator can distinguish delayed but bounded billing from unbounded or missing costs. The campaign can finish without claiming that its invoice is settled. **Breaking changes** The journal accepts optional bound metadata and an invalidation record. New reports add an optional bounded-pending count. Current readers retain old journals and reports without granting them bounds. Older code must not read new bound-bearing journals. The existing daily/weekly enable gates and budget amounts stay unchanged. **Additional context** This implements the operator-approved provisional-cost policy for the existing eval harness. It does not change product budgets or the agent-eval roadmap. A targeted GitHub search found no duplicate open PR. ## What Changed - Accounting owns a narrow evidence contract: a reviewed audit hash, exact configuration hash and full-lifecycle scope. - Gateway reservations retain that evidence before dispatch. Changed limits or rates fail before dispatch. Unexpected routing, model identity or excessive usage invalidates a bound durably. - Operating allowances can carry separately reviewed bounds for each cost component, including its full storage lifetime. No existing allowance becomes qualified by default. - Reports and Braintrust experiment metadata distinguish provisional accounting, complete receipts, blocked accounting and unavailable evidence. Public output omits private audit hashes. - Scheduled finalization allows qualified provisional costs and explicitly rejects spending overruns, including overruns with complete receipts. - Add regressions for legacy data, restarts, late reconciliation, conflicts, malformed evidence, routing uncertainty and exceeded limits. Document the evidence and migration boundaries. ## Verification - Full offline eval-support suite: 4,062 Vitest tests passed, two existing tests skipped; 137 Node tests passed. - `pnpm test:e2e:runner:typecheck`: passed. - `git diff --check`: passed. - Read the retained hosted qualification journal with the new policy. All six legacy pending charges remain unqualified. Known cost `$0.421245200`, held `$19.327680000`, and committed `$19.748925200` remain unchanged. The journal's SHA-256 is unchanged. The original failed workflow remains failed. - No paid models, network provider calls, receipt imports or reservation releases were used for this verification. - Rebased onto master `4d90634f74`; 142 targeted tests and typecheck passed. - Review reproduced a lost OpenAI input-total limit check when cache details were missing (1 failed, 47 passed). Fix `5fef9ba7c149951a51eae468614a4b89f0b3d6db` preserves unpriced provider usage bounds. Then 178 focused tests, full offline support and typecheck passed. - Current-head hosted CI passed: https://github.com/paperclipai/paperclip/actions/runs/40020746585 (attempt 2). Typecheck, build, all general/Runner/serialized tests and browser gates are green. - CI attempt 1 hit a PostgreSQL deadlock in unchanged chat-test cleanup; its skipped flag restoration caused a second assertion failure. One failed-jobs-only retry passed. Original failure evidence is preserved in attempt 1. No paid eval campaign was rerun. - Greptile reviewed exact head `5fef9ba7c149951a51eae468614a4b89f0b3d6db` at 5/5; its one finding is fixed and resolved. The optional Paperclip review is paused and supplied no assessment. ## Risks - Evidence hashes bind an audit to a configuration; they do not prove the audit is true. Operators must review real provider limits, all price tiers, full resource lifetimes and enforceable infrastructure limits before configuring bounds. - Provisional completion is not invoice settlement. Later billing can reveal overruns, which must be reconciled and inspected. The ledger cannot stop external billing. - Existing pilot journals, configured allowances and price cards have no new bound approval. This PR alone does not qualify or enable recurring paid work. - The gateway cannot qualify a canceled Braintrust request without route confirmation. It preserves that unknown hold. - No new dependency, secret, repository variable, workflow, schedule or cloud resource changes. ## Model Used OpenAI Codex, GPT-6 family. The exact deployment ID and context-window size are not exposed in this session. Used reasoning, repository tools and code execution. No paid evaluation model calls were made for this change. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
129 lines
10 KiB
TypeScript
129 lines
10 KiB
TypeScript
import { expect, it } from "vitest";
|
|
import { estimateProviderCost, normalizeProviderUsage, ProviderUsageAccumulator, type EvalModelPrice } from "./provider-usage.js";
|
|
const price: EvalModelPrice = { provider: "openai", model: "fixture", version: "fixture-1", sourceUrl: "https://provider.test/prices", inputUsdPerMillion: "2.5", cachedReadUsdPerMillion: "0.25", outputUsdPerMillion: "10", cacheWrite30mUsdPerMillion: "2", cacheWrite12hUsdPerMillion: "2" };
|
|
|
|
it("excludes cached reads from OpenAI input and treats reasoning as a subset of output", () => {
|
|
const usage = normalizeProviderUsage("openai", { id: "response", model: "fixture", usage: { input_tokens: 100, input_tokens_details: { cache_write_tokens: 0, cached_tokens: 40 }, output_tokens: 20, output_tokens_details: { reasoning_tokens: 15 } } });
|
|
expect(usage).toMatchObject({ complete: true, tokens: { input: 60, cachedRead: 40, cachedWrite: 0, output: 20, reasoning: 15 } });
|
|
expect(estimateProviderCost(usage, price)).toBe("0.000360000");
|
|
});
|
|
it("never turns missing usage or incompatible model/pricing into a free charge", () => {
|
|
const absent = normalizeProviderUsage("openai", { model: "fixture", usage: { input_tokens: 0, output_tokens: 0 } });
|
|
expect(absent.complete).toBe(false);
|
|
expect(estimateProviderCost(absent, price)).toBeNull();
|
|
const zero = normalizeProviderUsage("openai", { model: "fixture", usage: { input_tokens: 0, input_tokens_details: { cache_write_tokens: 0, cached_tokens: 0 }, output_tokens: 0 } });
|
|
expect(estimateProviderCost(zero, price)).toBe("0.000000000");
|
|
expect(estimateProviderCost(zero, { ...price, model: "other" })).toBeNull();
|
|
});
|
|
it("does not add Anthropic cumulative output counters and prices cache writes by TTL", () => {
|
|
const stream = new ProviderUsageAccumulator("anthropic");
|
|
stream.observe({ type: "message_start", message: { id: "message", model: "fixture", usage: { input_tokens: 10, output_tokens: 1, cache_read_input_tokens: 20, cache_creation_input_tokens: 30, cache_creation: { ephemeral_5m_input_tokens: 20, ephemeral_1h_input_tokens: 10 } } } });
|
|
stream.observe({ type: "message_delta", usage: { output_tokens: 5 } });
|
|
stream.observe({ type: "message_delta", usage: { output_tokens: 8 } });
|
|
expect(stream.receipt().final).toBe(false);
|
|
stream.observe({ type: "message_stop" });
|
|
expect(stream.receipt()).toMatchObject({ final: true, complete: true, tokens: { input: 10, cachedRead: 20, cachedWrite: 30, output: 8 } });
|
|
expect(estimateProviderCost(stream.receipt(), { ...price, provider: "anthropic", cacheWrite5mUsdPerMillion: "3.125", cacheWrite1hUsdPerMillion: "5" })).toBe("0.000222500");
|
|
});
|
|
it("retains missing cache TTL and malformed token subsets as unknown", () => {
|
|
const write = normalizeProviderUsage("anthropic", { model: "fixture", usage: { input_tokens: 1, cache_read_input_tokens: 0, cache_creation_input_tokens: 4, output_tokens: 1 } });
|
|
expect(estimateProviderCost(write, { ...price, provider: "anthropic" })).toBeNull();
|
|
expect(normalizeProviderUsage("openai", { usage: { input_tokens: 1, input_tokens_details: { cache_write_tokens: 0, cached_tokens: 2 }, output_tokens: 1 } }).complete).toBe(false);
|
|
expect(normalizeProviderUsage("openai", { usage: { input_tokens: 1, input_tokens_details: { cache_write_tokens: 0, cached_tokens: 0 }, output_tokens: 1, output_tokens_details: { reasoning_tokens: 2 } } }).complete).toBe(false);
|
|
});
|
|
it("uses one terminal Responses usage receipt regardless of streamed text or repeat notifications", () => {
|
|
const stream = new ProviderUsageAccumulator("openai");
|
|
stream.observe({ type: "response.output_text.delta", delta: "not a usage receipt" });
|
|
expect(stream.receipt().complete).toBe(false);
|
|
const terminal = { type: "response.completed", response: { id: "response", model: "fixture", usage: { input_tokens: 1, input_tokens_details: { cache_write_tokens: 0, cached_tokens: 0 }, output_tokens: 1 } } };
|
|
stream.observe(terminal); stream.observe(terminal);
|
|
expect(stream.receipt()).toMatchObject({ final: true, complete: true, tokens: { input: 1, output: 1 } });
|
|
expect(estimateProviderCost(stream.receipt(), price)).toBe("0.000012500");
|
|
});
|
|
|
|
const modernPrice: EvalModelPrice = { ...price, inputUsdPerMillion: "4", cachedReadUsdPerMillion: "0.4", outputUsdPerMillion: "20",
|
|
cacheWrite30mUsdPerMillion: "5", cacheWrite12hUsdPerMillion: "10",
|
|
longContext: { aboveInputTokens: 272_000, rates: { inputUsdPerMillion: "8", cachedReadUsdPerMillion: "0.8", outputUsdPerMillion: "30", cacheWrite30mUsdPerMillion: "10", cacheWrite12hUsdPerMillion: "20" } } };
|
|
const modernUsage = (total = 12_000, read = 4000, shortWrite = 3000, longWrite = 4000) => ({ model: "fixture", usage: {
|
|
input_tokens: total, input_tokens_details: { cached_tokens: read, cache_write_tokens: shortWrite + longWrite,
|
|
cache_write_tokens_details: { ttl_30m_tokens: shortWrite, ttl_12h_tokens: longWrite } }, output_tokens: 100,
|
|
} });
|
|
it("separates modern OpenAI ordinary input and mixed-TTL writes without adding the base rate twice", () => {
|
|
const receipt = normalizeProviderUsage("openai", modernUsage());
|
|
expect(receipt).toMatchObject({ complete: true, tokens: { input: 1000, cachedRead: 4000, cachedWrite: 7000 }, cacheWrite30m: 3000, cacheWrite12h: 4000 });
|
|
expect(estimateProviderCost(receipt, modernPrice)).toBe("0.062600000");
|
|
});
|
|
it("applies long-context pricing to the entire request using total input including cache", () => {
|
|
expect(estimateProviderCost(normalizeProviderUsage("openai", modernUsage(272_000, 270_000, 0, 1000)), modernPrice)).toBe("0.124000000");
|
|
expect(estimateProviderCost(normalizeProviderUsage("openai", modernUsage(272_001, 270_000, 0, 1000)), modernPrice)).toBe("0.247008000");
|
|
});
|
|
it("keeps missing modern write counters or missing/inconsistent TTL splits unknown", () => {
|
|
const missing = modernUsage(); delete (missing.usage.input_tokens_details as any).cache_write_tokens;
|
|
expect(normalizeProviderUsage("openai", missing).complete).toBe(false);
|
|
expect(estimateProviderCost(normalizeProviderUsage("openai", missing), modernPrice)).toBeNull();
|
|
const noTtl = modernUsage(); delete (noTtl.usage.input_tokens_details as any).cache_write_tokens_details;
|
|
expect(estimateProviderCost(normalizeProviderUsage("openai", noTtl), modernPrice)).toBeNull();
|
|
const mismatch = modernUsage(); mismatch.usage.input_tokens_details.cache_write_tokens_details.ttl_12h_tokens++;
|
|
expect(normalizeProviderUsage("openai", mismatch).complete).toBe(false);
|
|
});
|
|
|
|
const policyPrice = { ...modernPrice, model: "gpt-5.6-sol" };
|
|
function requestPolicyReceipt(request: Record<string, unknown> = {}, details: Record<string, unknown> = {}) {
|
|
const stream = new ProviderUsageAccumulator("openai", { model: policyPrice.model, input: "hello", ...request });
|
|
stream.observe({ type: "response.completed", response: { model: policyPrice.model, usage: {
|
|
input_tokens: 12_000, input_tokens_details: { cached_tokens: 4000, cache_write_tokens: 7000, ...details }, output_tokens: 100,
|
|
} } });
|
|
return stream.receipt();
|
|
}
|
|
it.each([
|
|
[{}, "30m", "0.042600000"],
|
|
[{ prompt_cache_retention: "24h" }, "30m", "0.042600000"],
|
|
[{ prompt_cache_options: { mode: "implicit", ttl: "12h" } }, "12h", "0.077600000"],
|
|
] as const)("prices omitted write TTLs from a documented visible request policy: %j", (request, ttl, cost) => {
|
|
const receipt = requestPolicyReceipt(request);
|
|
expect(receipt).toMatchObject({ final: true, complete: true, cacheWriteAttribution: {
|
|
source: "request_policy", version: "openai-prompt-cache-2026-10-20", ttl,
|
|
} });
|
|
expect(estimateProviderCost(receipt, policyPrice)).toBe(cost);
|
|
});
|
|
it.each([
|
|
{ model: "unqualified-model" }, { previous_response_id: "stored-response" }, { conversation: "stored-conversation" },
|
|
{ prompt: { id: "stored-prompt" } }, { context_management: [] },
|
|
{ input: [{ type: "item_reference", id: "stored-item" }] },
|
|
{ input: [{ type: "compaction", encrypted_content: "opaque" }] },
|
|
{ input: [{ role: "user", content: [{ type: "input_text", text: "hello", prompt_cache_breakpoint: { mode: "explicit", ttl: "12h" } }] }] },
|
|
{ prompt_cache_options: { mode: "explicit" } }, { prompt_cache_options: { ttl: "unknown" } },
|
|
{ prompt_cache_options: { ttl: null } }, { prompt_cache_options: null },
|
|
{ prompt_cache_options: { future_option: true } },
|
|
])("keeps hidden, explicit, or unqualified cache policies unknown: %j", request => {
|
|
const receipt = requestPolicyReceipt(request);
|
|
expect(receipt.cacheWriteAttribution).toBeUndefined();
|
|
expect(estimateProviderCost(receipt, policyPrice)).toBeNull();
|
|
});
|
|
it("prefers provider TTL splits and never repairs malformed or partial provider counters", () => {
|
|
const reported = requestPolicyReceipt({}, { cache_write_tokens_details: { ttl_30m_tokens: 3000, ttl_12h_tokens: 4000 } });
|
|
expect(reported.cacheWriteAttribution).toBeUndefined();
|
|
expect(estimateProviderCost(reported, policyPrice)).toBe("0.062600000");
|
|
for (const details of [{ cache_write_tokens: undefined }, { cache_write_tokens_details: null },
|
|
{ cache_write_tokens_details: { ttl_30m_tokens: 7000 } }, { cache_write_tokens_details: { ttl_30m_tokens: 7000, ttl_12h_tokens: 1 } }]) {
|
|
const receipt = requestPolicyReceipt({}, details);
|
|
expect(receipt.cacheWriteAttribution).toBeUndefined();
|
|
expect(estimateProviderCost(receipt, policyPrice)).toBeNull();
|
|
}
|
|
});
|
|
|
|
it.each([
|
|
["openai", { input_tokens: 1001, output_tokens: 1 }, 1001],
|
|
["openai", { input_tokens_details: { cached_tokens: 1001 } }, 1001],
|
|
["anthropic", { input_tokens: 1, cache_read_input_tokens: 2, cache_creation_input_tokens: 1000,
|
|
cache_creation: { ephemeral_5m_input_tokens: 999, ephemeral_1h_input_tokens: 0 } }, 1003],
|
|
["anthropic", { input_tokens: 1, cache_creation: { ephemeral_5m_input_tokens: 900, ephemeral_1h_input_tokens: 100 } }, 1001],
|
|
] as const)("retains %s input bounds independently of incomplete or contradictory price counters", (provider, usage, input) => {
|
|
const receipt = normalizeProviderUsage(provider, { usage });
|
|
expect(receipt).toMatchObject({ complete: false, tokenBounds: { input, valid: true } });
|
|
expect(estimateProviderCost(receipt, { ...price, provider })).toBeNull();
|
|
});
|
|
it.each([null, -1, 1.5, "1001", Number.MAX_SAFE_INTEGER + 1])("marks malformed input evidence %j ineligible for a bound", input_tokens => {
|
|
expect(normalizeProviderUsage("openai", { usage: { input_tokens } }).tokenBounds?.valid).toBe(false);
|
|
});
|