mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-24 18:19:05 +02:00
## Thinking Path > - Paperclip manages agents and the work they perform. > - Product E2E tests exercise real agents, tools, setup and cleanup. > - Repeated runs need retained costs and traces, including failed attempts. > - A passing retry must not hide earlier spending or feedback. > - Recurring work also needs admission limits, private reports and failure detection. > - This change supplies those controls while keeping paid activation behind existing gates. ## Linked Issues or Issue Description Refs #16996 and #17158. This is the consolidated landing of the reviewed eval operations stack: #17019, #17024, #17025, #17027, #17030, #17033, #17035, #17038, #17043, #17044, #17048, #17050, #17051, #17092, #17096, #17100, #17107, #17109, #17112, #17115, #17117, #17121, #17123, #17127, #17130, #17133, #17134, #17137, #17140, #17143, #17154. The repository permits squash merges only. A local rehearsal showed that squashing each slice into master causes repeated conflicts in dependent slices. This PR preserves their commits and lands their combined implementation in one reviewed integration. Superseded slices will close after this merge. ## What Changed - Retain every attempt's cost receipt, including setup, failures, interruptions and retries. Separate reported amounts, estimates, missing costs and reserved capacity in reports and dashboards. - Add bounded request admission, exact model pricecards, gateway error accounting, cache policy and reconciliation evidence. Refuse unsupported routes and requests that cannot fit the allowance. - Integrate Braintrust gateway traces and OTLP correlation, with secret filtering and experiment imports. Record phase timing, including setup, feedback capture and cleanup. - Collect complaint and suggestion evidence after each attempt, including recovery after failures. Retain explicit review dispositions independently from the product grade. - Add gated daily and weekly selections, measured forecasts, setup/readiness checks, wall-time limits and retained monitor notifications. Include declared non-model overhead in admission while reporting the existing subscription separately. - Keep recurring history private, bound uploads and retention, and use isolated archive environments. Keep public publication an explicit operation. Report and publication jobs install only the committed lockfile, with scripts disabled and isolated stores; stale pins fail closed. - Integrate current master, preserve its Product E2E journey billing and privacy checks, and test that shared setup receipts do not double-count estimated agent usage. Preserve upstream fixture repairs. ## Verification - Complete integration baseline `0649a5ce7544ab20825c2183d2f421157db49f24` includes master `a3e1d915a7110a4e115b46396a3f79e6dfb4d05e` and every original stack head as ancestors. - On that integration baseline, `pnpm test:e2e:runner:unit`: 4,012 Vitest tests passed, two skipped, across 193 files; all 137 Node source-contract tests passed. - Focused billing and Product E2E journey contract checks: 24 tests passed. They cover estimates, unknown receipts, single-owner setup costs, browser-only execution and private publication guards. - Monitor and workflow wiring: all 96 Node tests passed. `node scripts/check-token-gates.mjs`: all gates clean. - `pnpm test:e2e:runner:typecheck` passes after the standard Runner TypeScript build refreshed local declarations. The first attempt rejected the new master `runner_prepared_launch` union member because this checkout retained an older generated declaration; the source union already contained that member. - Current head `492b0708a1c531a023d9ac10f0f3dc6383cc1754` removes dependency re-resolution from archive-authorized reporting jobs after the security scan flagged it. All 15 workflow-security tests pass after updating the old two-install assertion. - Hosted [CI run 39965460180](https://github.com/paperclipai/paperclip/actions/runs/39965460180) passes on the current repaired head, including typecheck, build, general tests, Runner checks, browser shards and canary dry run. Greptile is 5/5 on this exact head with no unresolved threads. The security scan passes after the fixed lockfile-resolution thread was resolved. - Paperclip Review returned a terminal neutral check but an incomplete 0-file assessment on the repaired head: its platform blocked both diff responses as prompt-injection content. This is not a successful code review. No bypass or fabricated pass was attempted; current-head Greptile, security and hosted CI are independent gates. - No paid test, reservation release or recurring-run activation accompanies this landing. Live route qualification and invoice reconciliation remain separate evidence. <details> <summary>Retained earlier validation failures</summary> Earlier broad local runs had two 15-second test timeouts (CLI poll cadence and Retry validation), one embedded-database setup timeout, and later PostgreSQL semaphore exhaustion. The exact timed-out tests passed separately without larger timeouts; the broad-run causes were not established. Those local failures remain distinct from subsequent hosted CI results. The independent #17158 fix records its Muse fixture collision, its UUID correction and hosted verification. Local Muse execution was also blocked by macOS embedded-PostgreSQL startup. No historical failure is treated as a successful paid qualification. </details> ## Risks - Admission is a local control, not a provider invoice cap. Missing provider receipts or resource charges retain unknown amounts and holds; estimates do not become billed dollars. - The bounded path admits only documented local suites and provider routes. Ordinary legacy or separate Runner protocol campaigns have different controls. Merging this code does not qualify additional routes. - Recurrence still needs the existing enable gates and current qualification/allowance evidence. Archive permissions and resources must match the documented private-environment contract. - Legacy reports may lack complete attempt or phase evidence. Reports preserve that limitation and do not infer zero usage from missing data. ## Model Used OpenAI GPT-6 through Codex, with reasoning, repository tools and code execution. The exact deployment variant and context-window size are not exposed by this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass (targeted checks; full-suite host limitation disclosed above) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
198 lines
12 KiB
TypeScript
198 lines
12 KiB
TypeScript
import { afterEach, expect, it, vi } from "vitest";
|
|
import { mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { EvalSpendState, openEvalCostLedger, readEvalCostLedger, type EvalCostObservation, type EvalSpendLimits } from "./cost-ledger.js";
|
|
|
|
const roots: string[] = [];
|
|
afterEach(async () => { await Promise.all(roots.splice(0).map(root => rm(root, { recursive: true, force: true }))); });
|
|
const limits = (overrides: Partial<EvalSpendLimits> = {}): EvalSpendLimits => ({ campaignId: "pilot", maxUsd: "1", deadlineAt: "2099-01-01T00:00:00Z", maxRequests: 10, maxConcurrent: 2, ...overrides });
|
|
const identity = { executionId: "codex.local.fixture", attemptId: "attempt-1", phase: "setup" as const };
|
|
const observation = (overrides: Partial<EvalCostObservation> = {}): EvalCostObservation => ({ observationId: "receipt", requestId: "request", source: "provider", provider: "openai", model: "fixture", providerRequestId: "provider-request", currency: "USD", route: "direct", classification: "reported", costUsd: "0.000000123", final: true, ...overrides });
|
|
async function fixture(overrides: Partial<EvalSpendLimits> = {}) {
|
|
const root = await mkdtemp(path.join(os.tmpdir(), "eval-cost-ledger-")); roots.push(root);
|
|
const file = path.join(root, "costs.jsonl");
|
|
return { file, ledger: await openEvalCostLedger(file, limits(overrides)) };
|
|
}
|
|
|
|
it("persists a reservation before dispatch and counts setup spending with nanodollar precision", async () => {
|
|
const { file, ledger } = await fixture();
|
|
try {
|
|
await ledger.reserve("request", identity, "0.1");
|
|
const beforeDispatch = (await readEvalCostLedger(file)).state.snapshot();
|
|
expect(beforeDispatch).toMatchObject({ committedUsd: "0.100000000", heldUsd: "0.100000000", unknownRequests: 1 });
|
|
await ledger.observe(observation());
|
|
await ledger.finish("request", "succeeded");
|
|
expect(ledger.snapshot()).toMatchObject({ knownUsd: "0.000000123", committedUsd: "0.000000123", heldUsd: "0.000000000",
|
|
requests: [{ phase: "setup", receiptComplete: true }] });
|
|
} finally { await ledger.close(); }
|
|
expect((await readEvalCostLedger(file)).state.snapshot().knownUsd).toBe("0.000000123");
|
|
});
|
|
|
|
it("serializes competing admissions so concurrent requests cannot oversubscribe a cap", async () => {
|
|
const { ledger } = await fixture();
|
|
try {
|
|
const admitted = await Promise.allSettled([ledger.reserve("one", identity, "0.6"), ledger.reserve("two", identity, "0.6")]);
|
|
expect(admitted.map(value => value.status)).toEqual(["fulfilled", "rejected"]);
|
|
expect(ledger.snapshot().committedUsd).toBe("0.600000000");
|
|
} finally { await ledger.close(); }
|
|
});
|
|
|
|
it("durably caps attempts including zero-request failures and rejects unadmitted requests", async () => {
|
|
const cap = limits({ maxAttemptsPerExecution: 2 });
|
|
const { file, ledger } = await fixture({ maxAttemptsPerExecution: 2 });
|
|
await expect(ledger.reserve("request", identity, "0.1")).rejects.toThrow("no admitted attempt");
|
|
await ledger.admitAttempt(identity.executionId, "attempt-1");
|
|
await ledger.close();
|
|
const resumed = await openEvalCostLedger(file, cap);
|
|
try {
|
|
await expect(resumed.admitAttempt(identity.executionId, "attempt-1")).rejects.toThrow("already admitted");
|
|
const competing = await Promise.allSettled([
|
|
resumed.admitAttempt(identity.executionId, "attempt-2"),
|
|
resumed.admitAttempt(identity.executionId, "attempt-3"),
|
|
]);
|
|
expect(competing.map(result => result.status)).toEqual(["fulfilled", "rejected"]);
|
|
await resumed.reserve("request", { ...identity, attemptId: "attempt-2" }, "0.1");
|
|
await resumed.admitAttempt("another.cell", "another-attempt");
|
|
await expect(resumed.reserve("wrong-cell", { ...identity, attemptId: "another-attempt" }, "0.1")).rejects.toThrow("no admitted attempt");
|
|
expect((await readEvalCostLedger(file)).state.snapshot().admittedAttempts).toHaveLength(3);
|
|
} finally { await resumed.close(); }
|
|
await expect(openEvalCostLedger(file, limits({ maxAttemptsPerExecution: 3 }))).rejects.toThrow("limits changed");
|
|
});
|
|
|
|
it("holds unknown/cancelled charges after restart and counts failed retries independently", async () => {
|
|
const { file, ledger } = await fixture();
|
|
await ledger.reserve("request", identity, "0.5");
|
|
await ledger.finish("request", "cancelled");
|
|
await ledger.close();
|
|
const resumed = await openEvalCostLedger(file, limits());
|
|
try {
|
|
expect(resumed.snapshot()).toMatchObject({ inflight: 0, unknownRequests: 1, committedUsd: "0.500000000" });
|
|
await resumed.reserve("retry", { ...identity, attemptId: "attempt-2" }, "0.5");
|
|
await resumed.observe(observation({ observationId: "retry-cost", requestId: "retry", providerRequestId: "provider-retry", costUsd: "0.2" }));
|
|
await resumed.finish("retry", "failed");
|
|
expect(resumed.snapshot()).toMatchObject({ knownUsd: "0.200000000", heldUsd: "0.500000000", committedUsd: "0.700000000" });
|
|
await resumed.observe(observation({ costUsd: "0.3" }));
|
|
expect(resumed.snapshot()).toMatchObject({ knownUsd: "0.500000000", heldUsd: "0.000000000" });
|
|
} finally { await resumed.close(); }
|
|
});
|
|
|
|
it("deduplicates provider/gateway/native observations and preserves invoice adjustments", async () => {
|
|
const { ledger } = await fixture();
|
|
try {
|
|
await ledger.reserve("request", identity, "1");
|
|
await ledger.observe(observation({ source: "gateway", classification: "estimated", pricingVersion: "2026-10-20", costUsd: "0.3" }));
|
|
await ledger.observe(observation({ source: "gateway", classification: "estimated", pricingVersion: "2026-10-20", costUsd: "0.3" }));
|
|
await ledger.observe(observation({ observationId: "native", source: "native_otlp", costUsd: "0.2" }));
|
|
await ledger.observe(observation({ observationId: "invoice", source: "invoice", classification: "reconciled", costUsd: "0.15" }));
|
|
await ledger.finish("request", "succeeded");
|
|
expect(ledger.snapshot()).toMatchObject({ knownUsd: "0.150000000", breakdown: { estimated: "0.000000000", reported: "0.000000000", reconciled: "0.150000000" } });
|
|
await expect(ledger.observe(observation({ costUsd: "0.7" }))).rejects.toThrow("identity conflict");
|
|
} finally { await ledger.close(); }
|
|
});
|
|
|
|
it("retains partial costs and contradictory receipts without freeing their reservations", async () => {
|
|
const { ledger } = await fixture();
|
|
try {
|
|
await ledger.reserve("request", identity, "0.5");
|
|
await ledger.observe(observation({ final: false, costUsd: "0.2" }));
|
|
await ledger.finish("request", "failed");
|
|
expect(ledger.snapshot()).toMatchObject({ knownUsd: "0.200000000", heldUsd: "0.300000000", unknownRequests: 1 });
|
|
await ledger.observe(observation({ observationId: "final1", costUsd: "0.3" }));
|
|
await ledger.observe(observation({ observationId: "final2", costUsd: "0.4" }));
|
|
expect(ledger.snapshot()).toMatchObject({ knownUsd: "0.400000000", heldUsd: "0.100000000", conflictingRequests: 1 });
|
|
await expect(ledger.reserve("later", identity, "0.1")).rejects.toThrow("receipts conflict");
|
|
} finally { await ledger.close(); }
|
|
});
|
|
|
|
it("rejects ambiguous request joins and stops on measured overshoot", async () => {
|
|
const { ledger } = await fixture();
|
|
try {
|
|
await ledger.reserve("request", identity, "0.1");
|
|
await ledger.reserve("another", identity, "0.1");
|
|
await ledger.observe(observation({ costUsd: "1.1" }));
|
|
await expect(ledger.observe(observation({ observationId: "duplicate-request", requestId: "another" }))).rejects.toThrow("another reservation");
|
|
expect(ledger.snapshot().overBudget).toBe(true);
|
|
await ledger.finish("request", "succeeded");
|
|
await expect(ledger.reserve("later", identity, "0.1")).rejects.toThrow("spending cap");
|
|
} finally { await ledger.close(); }
|
|
});
|
|
|
|
it("enforces deadlines, request count, concurrency, and explicit pricing/usage invariants", async () => {
|
|
const expired = await fixture({ deadlineAt: "2000-01-01T00:00:00Z" });
|
|
await expect(expired.ledger.reserve("request", identity, "0.1")).rejects.toThrow("deadline");
|
|
await expired.ledger.close();
|
|
const { ledger } = await fixture({ maxRequests: 2, maxConcurrent: 1 });
|
|
try {
|
|
await ledger.reserve("request", identity, "0.1");
|
|
await expect(ledger.reserve("two", identity, "0.1")).rejects.toThrow("concurrency");
|
|
await expect(ledger.observe(observation({ classification: "estimated" }))).rejects.toThrow("pricing provenance");
|
|
await expect(ledger.observe(observation({ tokens: { output: 1, reasoning: 2 } }))).rejects.toThrow("token usage");
|
|
await ledger.finish("request", "failed");
|
|
await ledger.reserve("two", identity, "0.1");
|
|
await ledger.finish("two", "failed");
|
|
await expect(ledger.reserve("three", identity, "0.1")).rejects.toThrow("request cap");
|
|
} finally { await ledger.close(); }
|
|
});
|
|
|
|
it("fails closed on concurrent writers, changed limits, incomplete writes, and tampering", async () => {
|
|
const { file, ledger } = await fixture();
|
|
await expect(openEvalCostLedger(file, limits())).rejects.toThrow("writer lock");
|
|
await ledger.reserve("request", identity, "0.1");
|
|
await ledger.close();
|
|
await expect(openEvalCostLedger(file, limits({ maxUsd: "2" }))).rejects.toThrow("limits changed");
|
|
const contents = await readFile(file, "utf8");
|
|
await writeFile(file, contents.slice(0, -1));
|
|
await expect(readEvalCostLedger(file)).rejects.toThrow("incomplete");
|
|
await writeFile(file, contents.replace('"maxUsd":"1"', '"maxUsd":"2"'));
|
|
await expect(readEvalCostLedger(file)).rejects.toThrow("integrity");
|
|
});
|
|
|
|
it("rejects accidental raw payload fields and accepts equivalent receipt key order", async () => {
|
|
const { file, ledger } = await fixture();
|
|
try {
|
|
await ledger.reserve("request", identity, "0.1");
|
|
await expect(ledger.observe({ ...observation(), rawResponse: "private response" } as EvalCostObservation)).rejects.toThrow("Unknown ledger field");
|
|
await ledger.observe(observation());
|
|
await ledger.observe(Object.fromEntries(Object.entries(observation()).reverse()) as unknown as EvalCostObservation);
|
|
expect(await readFile(file, "utf8")).not.toContain("private response");
|
|
} finally { await ledger.close(); }
|
|
});
|
|
|
|
it("does not let a terminal estimate erase a stronger partial provider charge", async () => {
|
|
const { ledger } = await fixture();
|
|
try {
|
|
await ledger.reserve("request", identity, "0.8");
|
|
await ledger.observe(observation({ observationId: "provider-partial", final: false, costUsd: "0.6" }));
|
|
await ledger.observe(observation({ observationId: "gateway-final", source: "gateway", classification: "estimated", pricingVersion: "fixture", costUsd: "0.1" }));
|
|
await ledger.finish("request", "succeeded");
|
|
expect(ledger.snapshot()).toMatchObject({ knownUsd: "0.600000000", heldUsd: "0.200000000", unknownRequests: 1, breakdown: { reported: "0.600000000", estimated: "0.000000000" } });
|
|
await expect(ledger.reserve("next", identity, "0.3")).rejects.toThrow("spending cap");
|
|
await ledger.observe(observation({ observationId: "provider-final", costUsd: "0.65" }));
|
|
expect(ledger.snapshot()).toMatchObject({ knownUsd: "0.650000000", heldUsd: "0.000000000", unknownRequests: 0 });
|
|
} finally { await ledger.close(); }
|
|
});
|
|
|
|
it("replays admissions when the deadline crosses between validation and journal writing", async () => {
|
|
const admittedAt = Date.parse("2098-12-31T23:59:59.999Z");
|
|
vi.useFakeTimers({ toFake: ["Date"] });
|
|
vi.setSystemTime(admittedAt);
|
|
const { file, ledger } = await fixture();
|
|
const validate = EvalSpendState.prototype.validate;
|
|
const validation = vi.spyOn(EvalSpendState.prototype, "validate").mockImplementation(function (this: EvalSpendState, event, now) {
|
|
validate.call(this, event, now);
|
|
vi.setSystemTime(admittedAt + 2);
|
|
});
|
|
try {
|
|
await ledger.reserve("request", identity, "0.1");
|
|
validation.mockRestore();
|
|
expect((await readEvalCostLedger(file)).state.snapshot().committedUsd).toBe("0.100000000");
|
|
const records = (await readFile(file, "utf8")).trim().split("\n").map(line => JSON.parse(line));
|
|
expect(records[1].at).toBe(new Date(admittedAt).toISOString());
|
|
} finally {
|
|
validation.mockRestore();
|
|
vi.useRealTimers();
|
|
await ledger.close();
|
|
}
|
|
});
|