mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 16:27:18 +02:00
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Operators sign in via the `/auth` page, which renders before any session exists > - The signed-in app has a theme toggle inside `SidebarAccountMenu`, but the signed-out `/auth` page has none — first-time visitors are stuck in whichever theme was hardcoded at boot > - Master's existing toggle was inline inside `SidebarAccountMenu.tsx` as a `MenuAction` row, not exported as a reusable widget; round-1 of this PR added a standalone `ThemeToggle` but punted on unifying the two surfaces > - This pull request makes `ThemeToggle` the canonical theme widget (one source of truth for label, icon, and toggle behaviour), used both as a compact icon button on `/auth` and as a full-width menu row in `SidebarAccountMenu` > - The benefit is a working pre-auth theme switch and zero risk of the two call sites drifting out of sync as the theme model evolves ## Linked Issues or Issue Description No existing issue covers this directly — problem described in-PR (feature-gap shape): - The signed-in app has a theme toggle inside `SidebarAccountMenu`, but the signed-out `/auth` page has none — first-time visitors are stuck in whichever theme was hardcoded at boot. - The existing toggle lived inline in `SidebarAccountMenu.tsx` as a `MenuAction` row, not exported as a reusable widget, so the two surfaces could drift apart as the theme model evolves. - This PR supersedes part of PR #3732 (the auth-page toggle slice); no standalone issue was filed for it. Duplicate-PR search: related open theme PRs #2769 and #4666 add in-app three-state system-theme toggles — different surface from this PR (unauthenticated auth page); sibling PR in this series: #5873. ## What Changed - **`ui/src/components/ThemeToggle.tsx`** — accepts `variant: "icon" | "menu-action"` (default `"icon"`) and an `onAfterToggle` callback. Both variants share `useTheme` and the same label/icon derivation. The `menu-action` variant matches the existing `MenuAction` row styling. - **`ui/src/components/SidebarAccountMenu.tsx`** — drops its inline `useTheme()` + `MenuAction`-for-the-theme-row in favor of `<ThemeToggle variant="menu-action" onAfterToggle={() => setOpen(false)} />`. Sun/Moon icon imports and theme state move with it. - **`ui/src/pages/Auth.tsx`** — unchanged from round 0; renders `<ThemeToggle />` at top-right of the `/auth` page (already using the default `icon` variant). - **`ui/src/components/ThemeToggle.test.tsx`** (new) — covers both variants, the `onAfterToggle` callback, and the label/icon flip across themes. - **`ui/src/components/SidebarAccountMenu.test.tsx`** — unchanged; its `ThemeContext` mock still works because `ThemeToggle` uses the same hook. ## Verification - `pnpm --filter @paperclipai/ui run typecheck` — clean. - `npx vitest run src/components/ThemeToggle.test.tsx src/components/SidebarAccountMenu.test.tsx` — 5 passed (4 new + 1 existing). - Manual: launched `pnpm dev` for the UI, mocked `/api/auth/get-session` 401, navigated to `/auth` — toggle is visible top-right, click flips light/dark. Screenshots committed. ## Risks Low. The change is structural — both call sites render the same widget that already worked on each surface independently. `SidebarAccountMenu`'s popover behaviour is preserved via `onAfterToggle`, and `ThemeContext` is untouched. ## Model Used Claude Opus 4.7 (1M context), extended thinking mode. ## Checklist - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] Thinking path traces from project context to this change - [x] Model used specified - [x] Checked ROADMAP.md — not in conflict with planned core work - [x] Tests run locally and pass - [x] Added tests for the new ThemeToggle component (both variants) - [x] UI change — before/after screenshots in `docs/pr-screenshots/pr-5874/` - [x] No documentation updates required (purely internal refactor + new component) - [x] Documented risks above - [x] Will address all Greptile and reviewer comments before merge Supersedes part of #3732. --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Devin Foley <devin@paperclip.ing>
81 lines
2.4 KiB
TypeScript
81 lines
2.4 KiB
TypeScript
import { Moon, Sun } from "lucide-react";
|
|
|
|
import { Button } from "@/components/ui/button";
|
|
import { cn } from "@/lib/utils";
|
|
import { useTheme } from "../context/ThemeContext";
|
|
|
|
type ThemeToggleVariant = "icon" | "menu-action";
|
|
|
|
interface ThemeToggleProps {
|
|
className?: string;
|
|
/**
|
|
* `icon` (default): compact icon button — suitable for headers,
|
|
* floating chrome (e.g. the unauthenticated `/auth` page), and any
|
|
* other surface that just wants a toggle affordance.
|
|
*
|
|
* `menu-action`: full-width row with label + description + icon —
|
|
* matches the surrounding `MenuAction` rows in `SidebarAccountMenu`.
|
|
*/
|
|
variant?: ThemeToggleVariant;
|
|
/**
|
|
* Called after `toggleTheme` runs. Surfaces like a popover menu use
|
|
* this to dismiss the menu once the user has acted.
|
|
*/
|
|
onAfterToggle?: () => void;
|
|
}
|
|
|
|
const MENU_ACTION_DESCRIPTION = "Toggle the app appearance.";
|
|
|
|
/**
|
|
* Canonical theme-toggle widget. Both the signed-out `/auth` chrome and
|
|
* the in-app account menu render through this component so the label,
|
|
* icon, and toggle behaviour stay in sync as the theme model evolves.
|
|
*/
|
|
export function ThemeToggle({ className, variant = "icon", onAfterToggle }: ThemeToggleProps) {
|
|
const { theme, toggleTheme } = useTheme();
|
|
const isDark = theme === "dark";
|
|
const label = isDark ? "Switch to light mode" : "Switch to dark mode";
|
|
const Icon = isDark ? Sun : Moon;
|
|
|
|
function handleClick() {
|
|
toggleTheme();
|
|
onAfterToggle?.();
|
|
}
|
|
|
|
if (variant === "menu-action") {
|
|
return (
|
|
<button
|
|
type="button"
|
|
className={cn(
|
|
"flex w-full items-start gap-3 rounded-xl px-3 py-3 text-left transition-colors hover:bg-accent/60",
|
|
className,
|
|
)}
|
|
onClick={handleClick}
|
|
aria-label={label}
|
|
>
|
|
<span className="mt-0.5 rounded-lg border border-border bg-background/70 p-2 text-muted-foreground">
|
|
<Icon className="size-4" />
|
|
</span>
|
|
<span className="min-w-0 flex-1">
|
|
<span className="block text-sm font-medium text-foreground">{label}</span>
|
|
<span className="block text-xs text-muted-foreground">{MENU_ACTION_DESCRIPTION}</span>
|
|
</span>
|
|
</button>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<Button
|
|
type="button"
|
|
variant="ghost"
|
|
size="icon-sm"
|
|
onClick={handleClick}
|
|
aria-label={label}
|
|
title={label}
|
|
className={cn("text-muted-foreground", className)}
|
|
>
|
|
<Icon />
|
|
</Button>
|
|
);
|
|
}
|