mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 16:27:18 +02:00
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, where operators need a reliable way to find and act on work awaiting their input. > - The attention and issue-thread interaction subsystems expose those decision points across server APIs and the board UI. > - The previous navigation and interaction presentation left these actions fragmented and did not offer a controlled rollout for the Decisions surface. > - This branch adds the attention feed, richer interaction cards, grouping, dismiss/snooze behavior, and a gated Decisions sidebar entry. > - It also keeps experimental settings and API contracts synchronized, with an idempotent migration for the new dismissal state. > - This pull request delivers the complete, tested attention/Decisions experience as one reviewable unit. ## Linked Issues or Issue Description - Adds an operator-focused attention queue and Decisions experience: grouped decision cards, semantic interaction actions, dismiss/snooze handling, resilient interaction states, and an experimental flag to control the Decisions navigation entry. ## Feature Context ### Problem or Motivation Operators currently have to hunt across approvals, interactions, failed runs, and budget alerts to find decisions that need their action. ### Proposed Solution Provide a gated Decisions attention queue that groups actionable items, supports direct resolution, and preserves operator control through dismiss and snooze actions. ### Alternatives Considered Keep separate, source-specific views only; this leaves cross-cutting operator decisions fragmented and harder to prioritize. ### Roadmap Alignment This improves the V1 control-plane operator workflow by making pending governed actions discoverable in one company-scoped surface. ## What Changed - Added server attention-feed services, routes, interaction handling, dismiss/snooze support, and an idempotent `0145` inbox-dismissal migration. - Added shared attention, inbox-dismissal, and experimental-settings contracts. - Added Decisions/attention UI, interaction-card states, sidebar badge/navigation integration, grouping, keyboard support, and Storybook coverage. - Added tests for attention behavior, thread interactions, settings normalization, dismissals, and API behavior. - Removed generated screenshots from the final PR diff and rebased the branch onto current `master`. ## Verification - `pnpm check:token-gates` — passed. - `pnpm exec vitest run packages/shared/src/issue-thread-interactions.test.ts server/src/__tests__/attention-service.test.ts server/src/__tests__/inbox-dismissals.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts server/src/__tests__/issue-thread-interaction-routes.test.ts ui/src/lib/attention.test.ts ui/src/components/AttentionQueueRow.test.tsx ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/pages/InstanceExperimentalSettings.test.tsx` — passed: 158 tests across 9 focused files. - GitHub Actions for `ad636f560`: build and typecheck/release-registry have passed; remaining general-server and Greptile checks are in progress. ## Risks - Moderate: this is a cross-layer attention/interaction feature with a new migration and navigation behavior. - The `enableDecisions` experimental setting defaults to off, limiting rollout impact. - Existing dismissal data is backfilled to `dismiss`; the migration is idempotent and uses guarded constraint creation. > ROADMAP.md was checked; no duplicate planned core feature was identified. Related open pull requests were searched before opening this PR. ## Model Used - OpenAI GPT-5.5 via Codex CLI, with tool use and local code execution. Context-window size unavailable in this environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My public PR branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally; focused tests pass and the remaining unrelated AWS test failure is documented above - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
145 lines
4.9 KiB
TypeScript
145 lines
4.9 KiB
TypeScript
import { Dialog, DialogContent, DialogHeader, DialogTitle } from "@/components/ui/dialog";
|
|
|
|
interface ShortcutEntry {
|
|
keys: string[];
|
|
label: string;
|
|
/** Render keys as a simultaneous chord (joined with "+") rather than a
|
|
* "then" sequence. */
|
|
combo?: boolean;
|
|
}
|
|
|
|
// Platform-appropriate label for the Cmd/Ctrl modifier so the cheatsheet shows
|
|
// the same key the user actually presses (re-pointed in the collapsible sidebar
|
|
// work — Cmd/Ctrl+B toggles the rail).
|
|
function getPlatformLabel() {
|
|
if (typeof navigator === "undefined") return "";
|
|
const nav = navigator as Navigator & { userAgentData?: { platform?: string } };
|
|
return nav.userAgentData?.platform || navigator.userAgent || "";
|
|
}
|
|
|
|
const META_KEY = /Mac|iPhone|iPad|iPod/.test(getPlatformLabel()) ? "⌘" : "Ctrl";
|
|
|
|
interface ShortcutSection {
|
|
title: string;
|
|
shortcuts: ShortcutEntry[];
|
|
}
|
|
|
|
const sections: ShortcutSection[] = [
|
|
{
|
|
title: "Inbox",
|
|
shortcuts: [
|
|
{ keys: ["j"], label: "Move down" },
|
|
{ keys: ["↓"], label: "Move down" },
|
|
{ keys: ["k"], label: "Move up" },
|
|
{ keys: ["↑"], label: "Move up" },
|
|
{ keys: ["←"], label: "Collapse selected group" },
|
|
{ keys: ["→"], label: "Expand selected group" },
|
|
{ keys: ["Enter"], label: "Open selected item" },
|
|
{ keys: ["a"], label: "Archive item" },
|
|
{ keys: ["y"], label: "Archive item" },
|
|
{ keys: ["r"], label: "Mark as read" },
|
|
{ keys: ["U"], label: "Mark as unread" },
|
|
],
|
|
},
|
|
{
|
|
title: "Task detail",
|
|
shortcuts: [
|
|
{ keys: ["y"], label: "Quick-archive back to inbox" },
|
|
{ keys: ["g", "i"], label: "Go to inbox" },
|
|
{ keys: ["g", "c"], label: "Focus comment composer" },
|
|
],
|
|
},
|
|
{
|
|
title: "Decisions",
|
|
shortcuts: [
|
|
{ keys: ["j"], label: "Move down" },
|
|
{ keys: ["↓"], label: "Move down" },
|
|
{ keys: ["k"], label: "Move up" },
|
|
{ keys: ["↑"], label: "Move up" },
|
|
{ keys: ["Enter"], label: "Open or close selected decision" },
|
|
{ keys: ["x"], label: "Dismiss selected decision" },
|
|
],
|
|
},
|
|
{
|
|
title: "Global",
|
|
shortcuts: [
|
|
{ keys: ["/"], label: "Search current page or quick search" },
|
|
{ keys: ["c"], label: "New task" },
|
|
{ keys: ["["], label: "Toggle sidebar" },
|
|
{ keys: [META_KEY, "B"], label: "Collapse or expand sidebar", combo: true },
|
|
{ keys: ["]"], label: "Toggle panel" },
|
|
{ keys: ["?"], label: "Show keyboard shortcuts" },
|
|
],
|
|
},
|
|
];
|
|
|
|
function KeyCap({ children }: { children: string }) {
|
|
return (
|
|
<kbd className="inline-flex h-6 min-w-6 items-center justify-center rounded border border-border bg-muted px-1.5 font-mono text-xs font-medium text-foreground shadow-(--shadow-extract-10)">
|
|
{children}
|
|
</kbd>
|
|
);
|
|
}
|
|
|
|
export function KeyboardShortcutsCheatsheetContent() {
|
|
return (
|
|
<>
|
|
<div className="divide-y divide-border border-t border-border">
|
|
{sections.map((section) => (
|
|
<div key={section.title} className="px-5 py-3">
|
|
<h3 className="mb-2 text-(length:--text-micro) font-semibold uppercase tracking-wider text-muted-foreground">
|
|
{section.title}
|
|
</h3>
|
|
<div className="space-y-1.5">
|
|
{section.shortcuts.map((shortcut) => (
|
|
<div
|
|
key={shortcut.label + shortcut.keys.join()}
|
|
className="flex items-center justify-between gap-4"
|
|
>
|
|
<span className="text-sm text-foreground/90">{shortcut.label}</span>
|
|
<div className="flex items-center gap-1">
|
|
{shortcut.keys.map((key, i) => (
|
|
<span key={key} className="flex items-center gap-1">
|
|
{i > 0 && (
|
|
<span className="text-xs text-muted-foreground">
|
|
{shortcut.combo ? "+" : "then"}
|
|
</span>
|
|
)}
|
|
<KeyCap>{key}</KeyCap>
|
|
</span>
|
|
))}
|
|
</div>
|
|
</div>
|
|
))}
|
|
</div>
|
|
</div>
|
|
))}
|
|
</div>
|
|
<div className="border-t border-border px-5 py-3">
|
|
<p className="text-xs text-muted-foreground">
|
|
Press <KeyCap>Esc</KeyCap> to close · Shortcuts are disabled in text fields
|
|
</p>
|
|
</div>
|
|
</>
|
|
);
|
|
}
|
|
|
|
export function KeyboardShortcutsCheatsheet({
|
|
open,
|
|
onOpenChange,
|
|
}: {
|
|
open: boolean;
|
|
onOpenChange: (open: boolean) => void;
|
|
}) {
|
|
return (
|
|
<Dialog open={open} onOpenChange={onOpenChange}>
|
|
<DialogContent className="sm:max-w-md gap-0 p-0 overflow-hidden" showCloseButton={false}>
|
|
<DialogHeader className="px-5 pt-5 pb-3">
|
|
<DialogTitle className="text-base">Keyboard shortcuts</DialogTitle>
|
|
</DialogHeader>
|
|
<KeyboardShortcutsCheatsheetContent />
|
|
</DialogContent>
|
|
</Dialog>
|
|
);
|
|
}
|