mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 09:07:46 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Agents need a governed way to request app connections during issue work. > - The catalog now describes the available providers and setup methods. > - A request must become a durable, company-scoped intent before an operator acts on it. > - This pull request adds that intent runtime across server, agent, CLI, and shared contracts. > - The benefit is a safe bridge from agent need to operator-approved setup. ## Linked Issues or Issue Description Refs #11965 This is stack 7 of 11. It depends on stack 6 and replaces another reviewable part of #11965. ## What Changed - Add connection intent types, validation, service logic, and routes. - Add agent runtime tools and CLI support for connection requests. - Add issue-thread interaction support for connection intents. - Add runtime, route, adapter, and contract tests. - Hold the final resolved-continuation row lock through asynchronous adapter preparation until an actual process spawn, so parking or reassignment cannot cross that boundary. - Report Hermes Gateway's first remote run request through the shared dispatch hook so the resolved-intent lock is released at the true dispatch boundary. - Revalidate the addressed user's live non-viewer membership and connection-management authority for every intent mutation, including OAuth completion. ## Verification - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/server exec vitest run src/__tests__/tool-access-service.test.ts` - Result: 176 tests passed. - `pnpm build` - `pnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-stale-queue-invalidation.test.ts` (32 passed; includes non-process dispatch lock-release coverage) - `pnpm exec vitest run --project @paperclipai/server server/src/__tests__/connection-intents-service.test.ts -t "addressed-user mutation"` (1 passed) - `pnpm exec vitest run --project @paperclipai/server server/src/__tests__/tool-access-service.test.ts -t "binds OAuth callback completion to the initiating board session"` (1 passed) - `pnpm --filter @paperclipai/hermes-paperclip-adapter test -- src/gateway/server/execute.test.ts` (23 passed; includes dispatch-hook ordering and exactly-once coverage) - `pnpm --filter @paperclipai/hermes-paperclip-adapter typecheck` ## Risks - A malformed intent could create an unusable operator request. - Validators and company checks reject invalid or cross-company requests. - The final continuation gate holds the issue row lock through adapter preparation until process or remote dispatch; later operator changes use the normal active-run interruption path. - The change does not add a database migration. > I checked `ROADMAP.md`. This stack continues the existing app connection work from #11965 and does not duplicate another planned item. ## Model Used OpenAI Codex, GPT-5. The runtime model ID and context window were not exposed. The model used reasoning, tool use, and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have linked the public source pull request with `Refs #` - [x] I have not referenced internal or instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
106 lines
3.2 KiB
TypeScript
106 lines
3.2 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { CONNECTION_INTENT_AGENT_GUIDANCE } from "@paperclipai/shared";
|
|
import { execute } from "./execute.js";
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals();
|
|
});
|
|
|
|
describe("http adapter execute", () => {
|
|
it("delivers the complete runtime connection descriptor and shared guidance", async () => {
|
|
const onDispatch = vi.fn();
|
|
const fetchMock = vi.fn(async (_url: string, init?: RequestInit) => {
|
|
expect(onDispatch).toHaveBeenCalledOnce();
|
|
const body = JSON.parse(String(init?.body)) as Record<string, unknown>;
|
|
expect(body.paperclipRuntimeTools).toEqual({
|
|
version: 1,
|
|
guidance: CONNECTION_INTENT_AGENT_GUIDANCE,
|
|
mcpEndpoint: "https://paperclip.test/mcp/runtime-tools",
|
|
rest: {
|
|
connectionsSearch: "https://paperclip.test/runtime-tools/connections/search",
|
|
connectionRequest: "https://paperclip.test/runtime-tools/connections/request",
|
|
},
|
|
bearerToken: "run-token",
|
|
expiresAt: "2026-08-26T15:00:00.000Z",
|
|
tools: ["connections_search", "connection_request"],
|
|
});
|
|
return new Response(null, { status: 204 });
|
|
});
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
|
|
await execute({
|
|
runId: "run-1",
|
|
agent: {
|
|
id: "agent-1",
|
|
companyId: "company-1",
|
|
name: "Agent",
|
|
adapterType: "http",
|
|
adapterConfig: {},
|
|
},
|
|
runtime: {
|
|
sessionId: null,
|
|
sessionParams: null,
|
|
sessionDisplayId: null,
|
|
taskKey: null,
|
|
},
|
|
config: { url: "https://example.test/webhook" },
|
|
context: {},
|
|
runtimeTools: {
|
|
version: 1,
|
|
guidance: CONNECTION_INTENT_AGENT_GUIDANCE,
|
|
mcpEndpoint: "https://paperclip.test/mcp/runtime-tools",
|
|
rest: {
|
|
connectionsSearch: "https://paperclip.test/runtime-tools/connections/search",
|
|
connectionRequest: "https://paperclip.test/runtime-tools/connections/request",
|
|
},
|
|
bearerToken: "run-token",
|
|
expiresAt: "2026-08-26T15:00:00.000Z",
|
|
tools: ["connections_search", "connection_request"],
|
|
},
|
|
onLog: async () => {},
|
|
onDispatch,
|
|
});
|
|
|
|
expect(fetchMock).toHaveBeenCalledOnce();
|
|
expect(onDispatch).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("reports configured request timeout as timed_out", async () => {
|
|
vi.stubGlobal(
|
|
"fetch",
|
|
vi.fn((_url: string, init?: RequestInit) => new Promise((_resolve, reject) => {
|
|
init?.signal?.addEventListener("abort", () => {
|
|
reject(new DOMException("Aborted", "AbortError"));
|
|
});
|
|
})),
|
|
);
|
|
|
|
const result = await execute({
|
|
runId: "run-1",
|
|
agent: {
|
|
id: "agent-1",
|
|
companyId: "company-1",
|
|
name: "Agent",
|
|
adapterType: "http",
|
|
adapterConfig: {},
|
|
},
|
|
runtime: {
|
|
sessionId: null,
|
|
sessionParams: null,
|
|
sessionDisplayId: null,
|
|
taskKey: null,
|
|
},
|
|
config: {
|
|
url: "https://example.test/webhook",
|
|
timeoutMs: 1,
|
|
},
|
|
context: {},
|
|
onLog: async () => {},
|
|
});
|
|
|
|
expect(result.timedOut).toBe(true);
|
|
expect(result.errorCode).toBe("timeout");
|
|
expect(result.errorMessage).toContain("timed out after 1ms");
|
|
});
|
|
});
|