mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-08 22:13:59 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The server has about 1,100 test and helper files in `server/src/__tests__` > - `server/tsconfig.json` excludes that directory, Vitest does not check types, and no script runs the tsconfig in that directory > - So a test can call a function with the wrong arguments and still pass, and no tool reports it > - This gap hid 2,168 real type errors, and some of them hid tests that did not test what they claim > - This pull request fixes all of these errors and adds the directory to the server layers from paperclipai/paperclip#18737 > - The benefit is that a type error in a server test now fails the typecheck, with no baseline and no backlog ## Linked Issues or Issue Description Refs paperclipai/paperclip#18737, which is merged and added the server layers. Refs paperclipai/paperclip#18738, which is merged and checks the test projects outside `pnpm -r`, so it is not a duplicate. Refs paperclipai/paperclip#18137, which records that this directory has no check. **What happened?** No tool checked the types of 1,074 of the 1,101 files in `server/src/__tests__`. I searched `package.json`, the workflows, and all tsconfig files. 27 files are in the program of another tsconfig, and these 27 have 0 errors. 11 of the 27 are in `helpers/maintenance/tsconfig.json`. No script ran that project when I measured this. paperclipai/paperclip#18738 now runs it. **Expected behavior** The server typecheck checks these files, and a type error fails the check. **Steps to reproduce** 1. On the base commit, run `tsc -p server/src/__tests__/tsconfig.json --noEmit`. It reports 6,536 errors and needs 12.3 GiB. 2. Add a type error to any file in `server/src/__tests__`. 3. Run `pnpm --filter @paperclipai/server typecheck`. It passes. **Paperclip version or commit** I measured the error breakdown below on commit `8dfd632452`, with TypeScript 7.0.2. The branch now includes master up to paperclipai/paperclip#18865. **Deployment mode** Not applicable. This issue applies to development and CI. No production source file in the server changes. ### Error breakdown Each row adds one change to the row above. | Step | Total errors | Change | Cause | | --- | --- | --- | --- | | Config as committed | 6,536 | | | | Add `src/types/*.d.ts` | 4,447 | -2,089 | Config. The Express request types were missing. | | Set `rootDir` to the repository root | 2,436 | -2,011 | Config. | | Set `allowImportingTsExtensions` | 2,181 | -255 | Config. Vitest accepts `.ts` imports. | | Add `ES2024.Promise` to `lib` | 2,138 | -43 | Config. Node 24 has `Promise.withResolvers`. | | Set `allowJs` for `.mjs` imports | 2,148 | +10 | Config. It removes 8 `TS7016` errors and shows new real errors. | | Set `declaration` to false | 2,142 | -6 | Config. Tests emit nothing. | | Count only files in `server/src` | 2,058 | -84 | Other packages: 53 Daytona, 29 Runner test, 2 UI. | So 4,478 of the 6,536 errors (69%) came from config or scope, and 2,058 are real type errors in 314 files. The 29 Runner test errors are also real, which gives 2,087 errors. Tests that master added after this measurement had 81 more errors, so this pull request fixes 2,168 errors. This table classifies the first 2,058 errors. | Kind of real error | Errors | | --- | --- | | Wrong argument or assignment type | 1,023 | | Stale or partial fixture objects | 525 | | Property that the type does not have | 317 | | Missing narrowing of null or unknown | 101 | | Implicit any | 60 | | Missing name or module | 16 | | Other | 16 | ### What the type errors hid Most errors were stale fixtures and loose mocks. These errors hid real test problems, and this pull request fixes them: - **A test that never ran.** `instrumentation.test.ts` required `sdk-trace-base`, which is not installed. So 3 span tests were skipped. They now run and pass. - **Assertions that could not fail.** - `issue-thread-interactions-service` used a company ID as an issue ID. - `status-card-evaluation-work` compared `[]` with `[]` in a rollback check. - `slack-conversation-lifecycle` read `item.issueId`, which does not exist. - `email-channels` used a permission key that does not exist. - `heartbeat-project-env` imported `LOW_TRUST_REVIEW_PRESET`, which is not exported. The value was undefined. - **Postgres processes that did not stop.** 11 test files called `stop` on the test database helper. That method does not exist, and the helper method is `cleanup`. - **Arguments that the service ignored.** - `methodKey` is now `connectionMethodKey` in the Daytona, Unikraft, 1Password, and Railway tests. - 108 calls passed `"owner-user"` to a parameter that expects an options object. - 9 chat wizard fixtures passed `managementContext` as `source`, so they ran `existing_app` and not `manifest`. - 2 tests passed a `{ userId }` actor that the function ignores. - Inserts into `environments` passed a `companyId` column that the table does not have. - **Problems in tests that master added during this work.** - `sandbox-creation-operations` read `database.connectionString` when an external test database was set. In that mode `database` is undefined, so the fixture would stop with a TypeError. It now uses the external URL. - `idle-completed-history` set a Dot operation to `dispatched`. That is a Muse status, and the Dot type does not have it. The fixture now uses `admitted`, which is a real in-flight Dot status. ### Possible product problems, not changed These may be real problems in production code or types. I did not change them, because this pull request does not change production behavior: - `decisions-service` `service.create` does not validate the lenient `cancel_issue_tree` input. - `createConnection` ignores `input.connectionPurpose`. - The `createConnection` route schema default stores `{}` for `transportConfig`. - `prepareManagedAiRuntime` accepted the invalid value `mode: "connection"`. - `createBinding` accepts invalid `projectionClass` strings outside class 3. - `ensureManagedProjectWorkspace` forwards an untyped `repoRef` by spread. - `routineVariableSchema.label` is optional, but `RoutineVariable.label` is required. - `ToolRunContext.projectId` may be too strict. - `withdrawInteraction` reads `issue.status`, which its type omits. - `issueService.list` and `reconcileNativeFinalizations` omit fields that they return at runtime. - `createGitHubExternalObjectProvider` handles `tokenProvider: null`, but its type forbids this value. ## What Changed - Fixed the 2,168 type errors. The diff changes 322 test and helper files. - Corrected `server/src/__tests__/tsconfig.json`. Editors and the typecheck now read the same options and report the same errors. - Added three `test-tree` layers to `server/scripts/typecheck-layers.mjs`. They read the server layers as declarations, and any error fails them. A hash of the path selects the shard, so a new file does not move other files. - Added `server/scripts/typecheck-stubs/daytona-sdk.d.ts`. Server tests reach Daytona plugin source, and the root install does not have `@daytonaio/sdk`. - Changed two imports in `ui/src/lib/issue-execution-policy.ts` to use `.js` extensions, because server tests import this file. - Made `declarationsConfig` and `--declarations-only` skip the `test-tree` layers, because these layers emit nothing. Other projects read only the source layers. Added a test for this. - Updated `doc/DEVELOPING.md`. ## Verification Run these commands: ```sh pnpm --filter @paperclipai/server typecheck pnpm exec vitest run server/scripts/typecheck-layers.test.mjs ``` Results on macOS (arm64), Node 24, 16 cores. Each check ran after the merge of paperclipai/paperclip#18738 unless the row says otherwise: | Check | Commit | Result | | --- | --- | --- | | Server typecheck, `PAPERCLIP_TYPECHECK_LOW_MEMORY=1`, all 7 layers | `6e45a08573` | Exit 0, 0 errors, 62 seconds, peak 3.52 GiB | | `node scripts/typecheck-test-projects.mjs --low-memory` | `a3306bd13e` | Exit 0, 0 errors, 42 seconds, peak 3.25 GiB | | The same script with `--reuse-declarations` | `1b878aabc0` | Exit 0, 0 errors | | `typecheck-layers.test.mjs` and `live-recovery-work.test.ts` | `01db5634e4` | 90 passed. These include real compiler runs for a pass, a type error, and an invalid tsconfig. | | `tsconfig.declarations.json` after a full server typecheck | `0fb1e4fb0a` | It references only `below`, `cycle`, and `above`. No generated config names a `tsconfig.layers.json` file. | | Owned runtime test in `idle-completed-history` | `e8f2f448ac` | Passed, with the fix that master later replaced | | `idle-incoming-wake`, `plugin-idle-manager`, and the changed `chat-channels` test | `6e45a08573` | 30 passed | | Runner `native-execution.test.ts` | `eab4dcc1f4` | 114 passed | | The 19 server test files that changed since `eab4dcc1f4`, and `typecheck-layers.test.mjs` | `259737b700` | 4,275 of 4,277 passed. The 2 failures are in `chat-channels` and are in the list of 7 below. | The peak is the largest single process, from `/usr/bin/time -l`. Peaks for the server typecheck were between 3.42 GiB and 3.56 GiB across 8 runs. Peaks for the test projects were 3.25 GiB and 3.37 GiB across 2 runs. I did not measure a cgroup. **Runtime check of the fixes.** Types do not prove that a test still works. So I ran all 309 changed server test files, 11,929 tests, before the rebase onto paperclipai/paperclip#18737: | Result | Tests | Detail | | --- | --- | --- | | Passed | 11,913 | Includes the 2 tests and the 54 `dot-runner` tests that passed in a later run, as described below. | | Failed | 7 | The same 7 tests also fail on the commit before the fixes. | | Skipped | 9 | These tests have their own skip conditions: `sentry` 5, and 1 each in `bundled-plugin-registration`, `customer-success-cloud`, `onepassword-connection`, and `workspace-runtime-https-live-exercise`. | The 7 tests that fail with and without this change, on my machine: - 3 tests in `chat-channels` and `email-channels` stop with `ENOENT` on a `SKILL.md` file. The path is in the parent checkout, above the git worktree that I used, so I expect that the worktree is the cause. I did not prove this. - `workspace-instance-cleanup` compares `/private/var/...` with `/var/...`. This is a macOS symlink difference. - 2 tests in `git-reproducible-managed-checkouts` get `unknown_base_git_files` and expect `unpushed_managed_checkout`. I did not find the cause. - 1 more test in `chat-channels`, `materializes direct external-chat finals once`, gets `undefined`. I did not find the cause. CI is the check for these 7 tests. `ci / verify` passed on `eab4dcc1f4`. Failures during this work: - My fix to `agent-runtime-connector-access` changed an invalid permission key in the setup, but not in the assertion. The runtime check found this. I corrected the assertion, and the file passes. - `heartbeat-plugin-environment` failed one wait in the full run. It passed three times alone, so I think that load caused the failure. It can fail again under load. - `dot-runner` skipped all 54 tests in the full run because `cargo` was not on my `PATH`. It then passed 54 of 54 with the toolchain on the `PATH`. - My first `lib` value removed the default DOM types, and the error count went up by 375. I added the DOM libraries. - My Daytona stub with bare `any` left 48 errors, because generic helpers then inferred `unknown`. I added shapes that return promises. - One fix to `agent-secrets-routes` used `class_3_static_lease`, and the test failed. That class allows only specific paths. I reverted to `unclassified`. - `ci / General tests (server (8/12))` failed on `259737b700` because of the flaky port in `idle-completed-history`. paperclipai/paperclip#18853 fixed this test on master, so this pull request keeps that fix. **Audit of the diff.** I counted these patterns in added and removed lines, to find fixes that only hide an error: | Pattern | Added | Removed | | --- | --- | --- | | `@ts-ignore` | 0 | 0 | | `@ts-expect-error` | 0 | 1 | | `.skip` | 0 | 0 | | `as any` | 9 | 9 | | `: any` | 11 | 2 | | `as never` | 8 | 2 | | `as unknown as` | 35 | 4 | | `Promise<unknown>` | 16 | 5 | | `expect(` | 128 | 113 | No hunk removes more `expect(` calls than it adds. Three removals of test content were intentional, and I checked each one: - `muse-control` removed `signalToken`. Line 1012 already asserts that it is absent. - `merged-pr-confirmation-sweep` removed legacy aliases. Other tests cover them. - `heartbeat-workspace-branch-containment` removed a `finalize` branch that no test row can reach. Some partial fixtures stay unchecked through `as unknown as` and `Promise<unknown>`, mostly in `issue-agent-mutation-ownership-routes` and `issue-comment-reopen-routes`. **Accuracy of the check.** One program over the tree and the three shards reported the same errors at the same positions. Memory, as the peak of the largest process on one thread, was 3.93 GiB for one program and 2.43 GiB for the largest shard. I measured these two values before the fixes. Not run or not proven: - I did not run the full `pnpm test:run`, or a root `pnpm build`. I expect CI to run the full suites. - I did not run the 4 GiB container check, or the full `scripts/typecheck-low-memory.mjs`. The peaks above come from macOS, so they are not a Linux cgroup measurement. - I did not run the UI typecheck after the merges. - `workspace-runtime-https-live-exercise` is skipped, so its `cleanup` fix did not run. ## Risks - **A large diff in test files.** 328 files change. A pull request that edits the same tests can get merge conflicts. New tests on master can also add type errors before this merges. Any such error fails this check and needs a fix here. - **A higher cost for changes to source types.** A change to a type can add errors in test files that the author did not touch. The author must then fix them. This is the purpose of the check, but it is new work. - **Changed test behavior.** Some tests now run paths that they did not run before, such as the 9 chat wizard fixtures and the 3 span tests. They pass here, but they can be more sensitive to timing or to the environment. - **The Daytona stub can go stale.** The stub is written by hand. If the plugin uses a new SDK member, the typecheck reports an error until someone updates the stub. - **The release path.** `release-verify.yml` and `scripts/release.sh` run `pnpm -r typecheck`, so they now run this check. - **The tsconfig change.** The test transform reads `server/src/__tests__/tsconfig.json`. The options that I changed are for type checks, and the runs above passed. - **A gap that remains.** Tsconfigs in `packages/paperclip-runner` and in most sandbox provider plugins exclude `*.test.ts`. This check does not read most of those test files, so they can still drift. That work is separate from this pull request. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`) through Claude Code, with reasoning, tool use, code execution, and subagents. The runtime does not show the context window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [ ] I have run tests locally and they pass (7 tests fail locally, with and without this change. See Verification.) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1451 lines
52 KiB
TypeScript
1451 lines
52 KiB
TypeScript
import { EMBEDDED_POSTGRES_TEST_TIMEOUT_MS } from "@paperclipai/db";
|
|
import { randomUUID } from "node:crypto";
|
|
import { and, eq } from "drizzle-orm";
|
|
import {
|
|
afterAll,
|
|
afterEach,
|
|
beforeAll,
|
|
describe,
|
|
expect,
|
|
it,
|
|
vi,
|
|
} from "vitest";
|
|
import {
|
|
agents,
|
|
companies,
|
|
authUsers,
|
|
companyMemberships,
|
|
createDb,
|
|
heartbeatRuns,
|
|
agentWakeupRequests,
|
|
chatConversations,
|
|
chatActions,
|
|
chatDeliveries,
|
|
chatEndpoints,
|
|
chatMessageLinks,
|
|
chatPublications,
|
|
issueComments,
|
|
issueRecoveryActions,
|
|
issues,
|
|
toolApplications,
|
|
toolConnections,
|
|
} from "@paperclipai/db";
|
|
import { startEmbeddedPostgresTestDatabase } from "./helpers/embedded-postgres.js";
|
|
import { heartbeatService } from "../services/heartbeat.js";
|
|
import {
|
|
authorizeFailedChatRunRetryWake,
|
|
authorizeCommittedChatResponse,
|
|
CommittedChatResponseAuthorizationError,
|
|
registerCommittedChatResponseAuthority,
|
|
createDurableChatWakeupRequest,
|
|
FailedChatRunRetryAuthorizationError,
|
|
registerFailedChatRunRetryAuthority,
|
|
} from "../services/durable-chat-wakeup.js";
|
|
import { conflict } from "../errors.js";
|
|
import type { ServerAdapterModule } from "../adapters/index.js";
|
|
import { queueIssueAssignmentWakeup } from "../services/issue-assignment-wakeup.js";
|
|
import {
|
|
registerServerAdapter,
|
|
runningProcesses,
|
|
unregisterServerAdapter,
|
|
} from "../adapters/index.js";
|
|
|
|
describe("durable inbound chat scheduler receipts", () => {
|
|
let temporary: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>>;
|
|
let db: ReturnType<typeof createDb>;
|
|
const liveRunIds = new Set<string>();
|
|
const unregisterAuthorities: Array<() => void> = [];
|
|
const execute = vi.fn<ServerAdapterModule["execute"]>(async (input) => {
|
|
const issueId = String(input.context.issueId);
|
|
await db.insert(issueComments).values({
|
|
companyId: input.agent.companyId,
|
|
issueId,
|
|
authorAgentId: input.agent.id,
|
|
createdByRunId: input.runId,
|
|
body: "Exact retry dispatched",
|
|
});
|
|
await db
|
|
.update(issues)
|
|
.set({ status: "done" })
|
|
.where(eq(issues.id, issueId));
|
|
return {
|
|
exitCode: 0,
|
|
signal: null,
|
|
timedOut: false,
|
|
summary: "Exact retry dispatched",
|
|
};
|
|
});
|
|
beforeAll(async () => {
|
|
temporary = await startEmbeddedPostgresTestDatabase(
|
|
"chat-wakeup-receipts-",
|
|
);
|
|
db = createDb(temporary.connectionString);
|
|
registerServerAdapter({
|
|
type: "durable_chat_retry_test",
|
|
execute,
|
|
testEnvironment: async () => ({
|
|
adapterType: "durable_chat_retry_test",
|
|
status: "pass",
|
|
checks: [],
|
|
testedAt: new Date(0).toISOString(),
|
|
}),
|
|
});
|
|
}, EMBEDDED_POSTGRES_TEST_TIMEOUT_MS);
|
|
afterEach(() => {
|
|
execute.mockClear();
|
|
for (const unregister of unregisterAuthorities.splice(0)) unregister();
|
|
for (const runId of liveRunIds) runningProcesses.delete(runId);
|
|
liveRunIds.clear();
|
|
});
|
|
afterAll(async () => {
|
|
unregisterServerAdapter("durable_chat_retry_test");
|
|
await temporary.cleanup();
|
|
});
|
|
|
|
async function fixture(deferred = false) {
|
|
const companyId = randomUUID(),
|
|
agentId = randomUUID(),
|
|
issueId = randomUUID(),
|
|
activeRunId = randomUUID();
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Durable wake",
|
|
issuePrefix: `D${companyId.slice(0, 7)}`,
|
|
defaultResponsibleUserId: "board-user",
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
await db.insert(authUsers).values({ id: "board-user", name: "Fixture user", email: "board-user@example.test", createdAt: new Date(), updatedAt: new Date() }).onConflictDoNothing();
|
|
await db.insert(companyMemberships).values({ companyId, principalType: "user", principalId: "board-user", status: "active", membershipRole: "member" });
|
|
await db.insert(agents).values({
|
|
id: agentId,
|
|
companyId,
|
|
name: "Maya",
|
|
role: "ceo",
|
|
status: "running",
|
|
adapterType: "process",
|
|
adapterConfig: {},
|
|
runtimeConfig: { heartbeat: { maxConcurrentRuns: 1 } },
|
|
});
|
|
await db.insert(heartbeatRuns).values({
|
|
id: activeRunId,
|
|
companyId,
|
|
agentId,
|
|
status: "running",
|
|
// This fixture-owned slot has no provider process/work. Its retirement
|
|
// must not impersonate an ambiguous legacy provider failure.
|
|
resultJson: { executionRecovery: { kind: "bootstrap", providerWorkStarted: false } },
|
|
contextSnapshot: { issueId: deferred ? issueId : randomUUID() },
|
|
});
|
|
runningProcesses.set(activeRunId, {
|
|
child: {} as never,
|
|
graceSec: 0,
|
|
processGroupId: null,
|
|
});
|
|
liveRunIds.add(activeRunId);
|
|
await db.insert(issues).values({
|
|
id: issueId,
|
|
companyId,
|
|
title: "Bound chat task",
|
|
status: "in_progress",
|
|
assigneeAgentId: agentId,
|
|
responsibleUserId: "board-user",
|
|
...(deferred
|
|
? {
|
|
executionRunId: activeRunId,
|
|
executionAgentNameKey: "maya",
|
|
executionLockedAt: new Date(),
|
|
}
|
|
: {}),
|
|
});
|
|
const heartbeat = heartbeatService(db);
|
|
const authorize = vi.fn(async () => {});
|
|
const request = (commentId = randomUUID(), actor = "board-user") =>
|
|
createDurableChatWakeupRequest({
|
|
id: randomUUID(),
|
|
companyId,
|
|
agentId,
|
|
issueId,
|
|
commentId,
|
|
requestedByActorType: "user",
|
|
requestedByActorId: actor,
|
|
requestedAt: new Date(),
|
|
authorize,
|
|
});
|
|
const wake = (durableChatRequest: ReturnType<typeof request>) =>
|
|
queueIssueAssignmentWakeup({
|
|
heartbeat,
|
|
issue: { id: issueId, assigneeAgentId: agentId, status: "in_progress" },
|
|
reason: "External chat message received",
|
|
mutation: "chat_message_received",
|
|
contextSource: "chat:slack",
|
|
requestedByActorType: "user",
|
|
requestedByActorId: durableChatRequest.requestedByActorId,
|
|
wakeCommentId: durableChatRequest.commentId,
|
|
durableChatRequest,
|
|
rethrowOnError: true,
|
|
}) as Promise<Awaited<ReturnType<typeof heartbeat.wakeup>>> | undefined;
|
|
return {
|
|
companyId,
|
|
agentId,
|
|
issueId,
|
|
activeRunId,
|
|
heartbeat,
|
|
authorize,
|
|
request,
|
|
wake,
|
|
};
|
|
}
|
|
|
|
it.each([
|
|
...["unmentioned", "mentioned", "coalesced", "recovery", "deferred"].map((scenario) => ({ scenario, isDM: false })),
|
|
...["unmentioned", "coalesced"].map((scenario) => ({ scenario, isDM: true })),
|
|
])("checks Slack channel mentions after a real heartbeat queue wait ($scenario, DM=$isDM)", async ({ scenario, isDM }) => {
|
|
const mentioned = scenario === "mentioned" || scenario === "coalesced";
|
|
const allowed = isDM || scenario === "mentioned" || scenario === "recovery";
|
|
const f = await fixture();
|
|
await db.update(agents).set({ adapterType: "durable_chat_retry_test" }).where(eq(agents.id, f.agentId));
|
|
const applicationId = randomUUID(), connectionId = randomUUID(), endpointId = randomUUID();
|
|
await db.insert(toolApplications).values({ id: applicationId, companyId: f.companyId, name: "Mention gate", type: "chat" });
|
|
await db.insert(toolConnections).values({ id: connectionId, companyId: f.companyId, applicationId,
|
|
name: "Mention gate", uid: randomUUID(), connectionPurpose: "channel", transport: "chat_sdk", status: "active" });
|
|
await db.insert(chatEndpoints).values({ id: endpointId, companyId: f.companyId, connectionId,
|
|
provider: "slack", publicId: randomUUID(), assignedAgentId: f.agentId, status: "active" });
|
|
const request = f.request();
|
|
await db.insert(issueComments).values({ id: request.commentId, companyId: f.companyId, issueId: f.issueId,
|
|
authorUserId: "board-user", body: mentioned ? "@bot work" : "Work" });
|
|
const [delivery] = await db.insert(chatDeliveries).values({ companyId: f.companyId, endpointId,
|
|
providerEventId: randomUUID(), deduplicationKey: randomUUID(), eventKind: isDM ? "direct_message" : "message", state: "processed",
|
|
normalizedEvent: { trigger: isDM ? "direct_message" : "subscribed_message", conversation: { isDirectMessage: isDM }, message: { mentionedBot: mentioned } } }).returning();
|
|
await db.insert(chatActions).values({ id: request.id, companyId: f.companyId, endpointId,
|
|
deliveryId: delivery.id, kind: "inbound_wakeup", providerActionId: randomUUID(), status: "processed",
|
|
payload: { issueId: f.issueId, commentId: request.commentId } });
|
|
await f.wake(request);
|
|
const [receipt] = await db.select().from(agentWakeupRequests).where(eq(agentWakeupRequests.id, request.id));
|
|
expect(receipt.status).toBe("queued");
|
|
const [queuedRun] = await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, receipt.runId!));
|
|
expect(queuedRun.startedAt).toBeNull();
|
|
const originalStartedAt = new Date(Date.now() - 60_000);
|
|
if (scenario === "recovery") {
|
|
// Same-run retries retain their first claim time, even when queued again.
|
|
await db.update(heartbeatRuns).set({ startedAt: originalStartedAt })
|
|
.where(eq(heartbeatRuns.id, receipt.runId!));
|
|
}
|
|
let deferredRequestId: string | undefined;
|
|
if (scenario === "coalesced" || scenario === "deferred") {
|
|
const second = f.request();
|
|
await db.insert(issueComments).values({ id: second.commentId, companyId: f.companyId, issueId: f.issueId,
|
|
authorUserId: "board-user", body: scenario === "deferred" ? "@bot follow-up" : "Unmentioned follow-up" });
|
|
const [secondDelivery] = await db.insert(chatDeliveries).values({ companyId: f.companyId, endpointId,
|
|
providerEventId: randomUUID(), deduplicationKey: randomUUID(), eventKind: isDM ? "direct_message" : "message", state: "processed",
|
|
normalizedEvent: { trigger: isDM ? "direct_message" : "subscribed_message", conversation: { isDirectMessage: isDM }, message: { mentionedBot: scenario === "deferred" } } }).returning();
|
|
await db.insert(chatActions).values({ id: second.id, companyId: f.companyId, endpointId,
|
|
deliveryId: secondDelivery.id, kind: "inbound_wakeup", providerActionId: randomUUID(), status: "processed",
|
|
payload: { issueId: f.issueId, commentId: second.commentId } });
|
|
await db.update(issues).set({ executionRunId: receipt.runId, executionAgentNameKey: "maya", executionLockedAt: new Date() })
|
|
.where(eq(issues.id, f.issueId));
|
|
if (scenario === "deferred") {
|
|
// Seed the persisted queue state left by a deferred follow-up before
|
|
// its predecessor is returned to the unstarted queue.
|
|
await db.update(heartbeatRuns).set({ status: "running" }).where(eq(heartbeatRuns.id, receipt.runId!));
|
|
runningProcesses.set(receipt.runId!, { child: {} as never, graceSec: 0, processGroupId: null });
|
|
liveRunIds.add(receipt.runId!);
|
|
}
|
|
await f.wake(second);
|
|
const [coalesced] = await db.select().from(agentWakeupRequests).where(eq(agentWakeupRequests.id, second.id));
|
|
if (scenario === "deferred") {
|
|
expect(coalesced).toMatchObject({ status: "deferred_issue_execution", runId: null });
|
|
deferredRequestId = second.id;
|
|
runningProcesses.delete(receipt.runId!);
|
|
liveRunIds.delete(receipt.runId!);
|
|
await db.update(heartbeatRuns).set({ status: "queued" }).where(eq(heartbeatRuns.id, receipt.runId!));
|
|
} else {
|
|
expect(coalesced).toMatchObject({ status: "coalesced", runId: receipt.runId });
|
|
}
|
|
}
|
|
await db.update(chatEndpoints).set({ requireAtMention: true }).where(eq(chatEndpoints.id, endpointId));
|
|
await f.heartbeat.cancelRun(f.activeRunId, "Fixture slot released", { suppressImmediateRecovery: true });
|
|
await f.heartbeat.drainActiveRunExecutions();
|
|
const [run] = await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, receipt.runId!));
|
|
expect(run.status).toBe(allowed ? "succeeded" : "cancelled");
|
|
expect(execute).toHaveBeenCalledTimes(allowed || scenario === "deferred" ? 1 : 0);
|
|
if (deferredRequestId) {
|
|
const [promoted] = await db.select().from(agentWakeupRequests).where(eq(agentWakeupRequests.id, deferredRequestId));
|
|
const [followup] = await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, promoted.runId!));
|
|
expect(followup.status).toBe("succeeded");
|
|
}
|
|
if (!allowed) expect(run.errorCode).toBe("chat_mention_required");
|
|
if (scenario === "recovery") expect(run.startedAt).toEqual(originalStartedAt);
|
|
});
|
|
|
|
async function executionHold(f: { companyId: string; issueId: string; agentId: string }) {
|
|
const [action] = await db.insert(issueRecoveryActions).values({
|
|
companyId: f.companyId, sourceIssueId: f.issueId, kind: "active_run_watchdog",
|
|
ownerType: "board", returnOwnerAgentId: f.agentId,
|
|
cause: "legacy_execution_requires_reconciliation", status: "resolved",
|
|
fingerprint: randomUUID(), evidence: { automaticRecovery: { replay: "blocked" } },
|
|
nextAction: "Check the stopped execution.",
|
|
}).returning();
|
|
return () => db.update(issueRecoveryActions).set({ evidence: {} }).where(eq(issueRecoveryActions.id, action!.id));
|
|
}
|
|
|
|
it("defers held inbound chat exactly once and keeps its authority separate from a generic wake", async () => {
|
|
const f = await fixture();
|
|
const clearHold = await executionHold(f);
|
|
const request = f.request();
|
|
const wake = () => f.heartbeat.wakeup(f.agentId, {
|
|
source: "on_demand", triggerDetail: "manual", reason: "issue_commented",
|
|
payload: { issueId: f.issueId, commentId: request.commentId },
|
|
contextSnapshot: { issueId: f.issueId, source: "chat:slack", wakeCommentId: request.commentId },
|
|
requestedByActorType: "user", requestedByActorId: request.requestedByActorId,
|
|
durableChatRequest: request,
|
|
});
|
|
for (let i = 0; i < 3; i++) expect(await wake()).toBeNull();
|
|
const receipts = await db.select().from(agentWakeupRequests).where(eq(agentWakeupRequests.agentId, f.agentId));
|
|
expect(receipts).toHaveLength(1);
|
|
expect(receipts[0]).toMatchObject({
|
|
id: request.id, idempotencyKey: request.idempotencyKey, requestedAt: request.requestedAt,
|
|
status: "deferred_issue_execution", runId: null, requestedByActorId: request.requestedByActorId,
|
|
payload: { _paperclipWakeContext: { source: "chat:slack", wakeCommentIds: [request.commentId] } },
|
|
});
|
|
expect(f.authorize).toHaveBeenCalledTimes(1);
|
|
expect(await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.wakeupRequestId, request.id))).toHaveLength(0);
|
|
await clearHold();
|
|
const generic = await f.heartbeat.wakeup(f.agentId, {
|
|
source: "on_demand", triggerDetail: "manual", reason: "issue_resumed",
|
|
payload: { issueId: f.issueId }, requestedByActorType: "user", requestedByActorId: "board-user",
|
|
});
|
|
expect(generic?.status).toBe("queued");
|
|
expect(generic?.contextSnapshot?.wakeCommentIds).toBeUndefined();
|
|
expect((await db.select().from(agentWakeupRequests).where(eq(agentWakeupRequests.id, request.id)))[0]).toMatchObject({
|
|
status: "deferred_issue_execution", runId: null,
|
|
});
|
|
});
|
|
|
|
it("reconsiders the same held inbound receipt only through its live durable owner", async () => {
|
|
const f = await fixture();
|
|
const clearHold = await executionHold(f);
|
|
const request = f.request();
|
|
expect(await f.wake(request)).toBeNull();
|
|
await clearHold();
|
|
const reconsidered = createDurableChatWakeupRequest({ ...request, resumeDeferred: true });
|
|
const [first, second] = await Promise.all([f.wake(reconsidered), f.wake(reconsidered)]);
|
|
const receipts = await db.select().from(agentWakeupRequests).where(eq(agentWakeupRequests.agentId, f.agentId));
|
|
expect(receipts).toHaveLength(1);
|
|
expect(receipts[0]).toMatchObject({ id: request.id, status: "queued", requestedAt: request.requestedAt });
|
|
expect(await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.wakeupRequestId, request.id))).toHaveLength(1);
|
|
expect(first?.id ?? second?.id).toBe(receipts[0].runId);
|
|
expect(f.authorize.mock.calls.length).toBeGreaterThan(1);
|
|
});
|
|
|
|
async function retryFixture(deferred = false) {
|
|
const f = await fixture(deferred);
|
|
const applicationId = randomUUID(),
|
|
connectionId = randomUUID(),
|
|
endpointId = randomUUID();
|
|
const failedRunId = randomUUID(),
|
|
actionId = randomUUID();
|
|
const commentIds = [randomUUID(), randomUUID()];
|
|
const taskKey = `D${f.companyId.slice(0, 7)}-1`;
|
|
await db
|
|
.update(issues)
|
|
.set({ identifier: taskKey })
|
|
.where(eq(issues.id, f.issueId));
|
|
await db.insert(toolApplications).values({
|
|
id: applicationId,
|
|
companyId: f.companyId,
|
|
name: "Retry authority",
|
|
type: "chat",
|
|
});
|
|
await db.insert(toolConnections).values({
|
|
id: connectionId,
|
|
companyId: f.companyId,
|
|
applicationId,
|
|
name: "Retry",
|
|
uid: `retry-${connectionId}`,
|
|
connectionPurpose: "channel",
|
|
transport: "chat_sdk",
|
|
status: "active",
|
|
});
|
|
await db.insert(chatEndpoints).values({
|
|
id: endpointId,
|
|
companyId: f.companyId,
|
|
connectionId,
|
|
provider: "slack",
|
|
publicId: randomUUID(),
|
|
assignedAgentId: f.agentId,
|
|
status: "active",
|
|
});
|
|
await db.insert(heartbeatRuns).values({
|
|
id: failedRunId,
|
|
companyId: f.companyId,
|
|
agentId: f.agentId,
|
|
status: "failed",
|
|
finishedAt: new Date(),
|
|
contextSnapshot: {
|
|
issueId: f.issueId,
|
|
taskKey,
|
|
source: "chat:slack",
|
|
wakeCommentIds: commentIds,
|
|
},
|
|
});
|
|
await db.insert(issueComments).values(
|
|
commentIds.map((id) => ({
|
|
id,
|
|
companyId: f.companyId,
|
|
issueId: f.issueId,
|
|
authorUserId: "board-user",
|
|
body: "Exact original request",
|
|
})),
|
|
);
|
|
await db.insert(chatActions).values({
|
|
id: actionId,
|
|
companyId: f.companyId,
|
|
endpointId,
|
|
kind: "failed_run_retry",
|
|
providerActionId: `failed_run_retry:${failedRunId}`,
|
|
status: "issued",
|
|
payload: { issueId: f.issueId, failedRunId },
|
|
});
|
|
const context = {
|
|
issueId: f.issueId,
|
|
source: "chat:slack",
|
|
taskKey,
|
|
wakeCommentId: commentIds[1],
|
|
wakeCommentIds: commentIds,
|
|
retryOfRunId: failedRunId,
|
|
chatFailedRunRetry: { version: 1, actionId, failedRunId },
|
|
};
|
|
const request = createDurableChatWakeupRequest({
|
|
...f.request(commentIds[1]),
|
|
id: actionId,
|
|
failedRunRetry: { failedRunId },
|
|
});
|
|
const authority = vi.fn(
|
|
async (
|
|
_tx: unknown,
|
|
input: { contextSnapshot: Record<string, unknown>; phase: string },
|
|
) => {
|
|
expect(input.contextSnapshot).toMatchObject(context);
|
|
},
|
|
);
|
|
const register = () => {
|
|
const dispose = registerFailedChatRunRetryAuthority(db, authority);
|
|
unregisterAuthorities.push(dispose);
|
|
return dispose;
|
|
};
|
|
const wake = (options: Record<string, unknown> = {}) =>
|
|
f.heartbeat.wakeup(f.agentId, {
|
|
source: "assignment",
|
|
triggerDetail: "system",
|
|
reason: "retry_failed_chat_run",
|
|
payload: { ...context },
|
|
contextSnapshot: { ...context },
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "board-user",
|
|
durableChatRequest: request,
|
|
allowRunCoalescing: true,
|
|
...options,
|
|
});
|
|
return {
|
|
...f,
|
|
failedRunId,
|
|
actionId,
|
|
context,
|
|
commentIds,
|
|
request,
|
|
authority,
|
|
register,
|
|
wake,
|
|
};
|
|
}
|
|
|
|
it("fails closed for a persisted retry when its live authority is unavailable", async () => {
|
|
const f = await retryFixture();
|
|
await expect(f.wake()).rejects.toBeInstanceOf(
|
|
FailedChatRunRetryAuthorizationError,
|
|
);
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, f.actionId)),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it("does not turn a forged retry selector into authority", async () => {
|
|
const f = await fixture();
|
|
await expect(
|
|
f.heartbeat.wakeup(f.agentId, {
|
|
payload: { issueId: f.issueId },
|
|
contextSnapshot: {
|
|
chatFailedRunRetry: {
|
|
version: 1,
|
|
actionId: randomUUID(),
|
|
failedRunId: randomUUID(),
|
|
},
|
|
},
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "board-user",
|
|
}),
|
|
).rejects.toBeInstanceOf(FailedChatRunRetryAuthorizationError);
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.agentId, f.agentId)),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it("preserves exact retry provenance and a deeply frozen server-only selector", async () => {
|
|
const f = await retryFixture();
|
|
f.register();
|
|
expect(Object.isFrozen(f.request.failedRunRetry)).toBe(true);
|
|
const run = await f.wake();
|
|
expect(run).toMatchObject({
|
|
status: "queued",
|
|
retryOfRunId: f.failedRunId,
|
|
wakeupRequestId: f.actionId,
|
|
contextSnapshot: f.context,
|
|
});
|
|
expect(f.authority).toHaveBeenCalledTimes(1);
|
|
expect(f.authority.mock.calls[0][1]).toMatchObject({ phase: "admission" });
|
|
await f.wake();
|
|
expect(f.authority).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("cannot coalesce an exact retry into active or deferred ordinary work", async () => {
|
|
const f = await retryFixture(true);
|
|
const ordinary = f.request;
|
|
await queueIssueAssignmentWakeup({
|
|
heartbeat: f.heartbeat,
|
|
issue: {
|
|
id: f.issueId,
|
|
assigneeAgentId: f.agentId,
|
|
status: "in_progress",
|
|
},
|
|
reason: "External chat message received",
|
|
mutation: "chat_message_received",
|
|
contextSource: "chat:slack",
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "board-user",
|
|
wakeCommentId: f.commentIds[0],
|
|
durableChatRequest: createDurableChatWakeupRequest({
|
|
...ordinary,
|
|
id: randomUUID(),
|
|
commentId: f.commentIds[0],
|
|
failedRunRetry: undefined,
|
|
}),
|
|
rethrowOnError: true,
|
|
});
|
|
f.register();
|
|
await f.wake();
|
|
const receipts = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.agentId, f.agentId));
|
|
expect(receipts).toHaveLength(2);
|
|
expect(
|
|
receipts.every(
|
|
(row) =>
|
|
row.status === "deferred_issue_execution" && row.coalescedCount === 0,
|
|
),
|
|
).toBe(true);
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.wakeupRequestId, f.actionId)),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it("rediscovers a retry from durable provenance even if its hint was stripped", async () => {
|
|
const f = await retryFixture();
|
|
const { chatFailedRunRetry: _selector, ...contextSnapshot } = f.context;
|
|
await expect(
|
|
authorizeFailedChatRunRetryWake(db, db, {
|
|
phase: "execution",
|
|
wakeupRequestId: f.actionId,
|
|
companyId: f.companyId,
|
|
agentId: f.agentId,
|
|
issueId: f.issueId,
|
|
contextSnapshot,
|
|
}),
|
|
).rejects.toBeInstanceOf(FailedChatRunRetryAuthorizationError);
|
|
});
|
|
|
|
it("an older service disposer cannot remove a newer retry authority", async () => {
|
|
const f = await retryFixture();
|
|
const oldDispose = f.register();
|
|
const replacement = vi.fn(async () => {});
|
|
unregisterAuthorities.push(
|
|
registerFailedChatRunRetryAuthority(db, replacement),
|
|
);
|
|
oldDispose();
|
|
await f.wake();
|
|
expect(replacement).toHaveBeenCalledTimes(1);
|
|
expect(f.authority).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.each([false, true])("cancels a revoked deferred retry without reopening its batch (execution hold=%s)", async (held) => {
|
|
const f = await retryFixture(true);
|
|
const clearHold = held ? await executionHold(f) : null;
|
|
f.register();
|
|
await f.wake();
|
|
await clearHold?.();
|
|
f.authority.mockImplementation(async (_tx, input) => {
|
|
if (input.phase === "promotion")
|
|
throw conflict("Current chat access was revoked");
|
|
});
|
|
await db
|
|
.update(issues)
|
|
.set({ status: "done" })
|
|
.where(eq(issues.id, f.issueId));
|
|
await f.heartbeat.cancelRun(f.activeRunId, "Fixture predecessor finished", {
|
|
suppressImmediateRecovery: true,
|
|
});
|
|
await f.heartbeat.drainActiveRunExecutions();
|
|
const [receipt] = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, f.actionId));
|
|
expect(receipt).toMatchObject({ status: "cancelled", runId: null });
|
|
expect(receipt.payload).toMatchObject({ wakeCommentIds: f.commentIds });
|
|
const [issue] = await db
|
|
.select()
|
|
.from(issues)
|
|
.where(eq(issues.id, f.issueId));
|
|
expect(issue).toMatchObject({ status: "done", executionRunId: null });
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.wakeupRequestId, f.actionId)),
|
|
).toEqual([]);
|
|
expect(f.authority.mock.calls.map((call) => call[1].phase)).toEqual([
|
|
"admission",
|
|
"promotion",
|
|
]);
|
|
});
|
|
|
|
it("denies a queued retry at execution when current authority is revoked", async () => {
|
|
const f = await retryFixture();
|
|
f.register();
|
|
const queued = await f.wake();
|
|
f.authority.mockImplementation(async (_tx, input) => {
|
|
if (input.phase === "execution")
|
|
throw conflict("Current chat access was revoked", {
|
|
code: "chat_failed_run_retry_not_authorized",
|
|
});
|
|
});
|
|
await f.heartbeat.cancelRun(
|
|
f.activeRunId,
|
|
"Fixture execution slot released",
|
|
{ suppressImmediateRecovery: true },
|
|
);
|
|
await f.heartbeat.drainActiveRunExecutions();
|
|
const [run] = await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.id, queued!.id));
|
|
expect(run).toMatchObject({
|
|
status: "failed",
|
|
retryOfRunId: f.failedRunId,
|
|
nativeSessionId: null,
|
|
errorCode: "chat_failed_run_retry_not_authorized",
|
|
});
|
|
expect(run.error).toContain("Current chat access was revoked");
|
|
const [issue] = await db
|
|
.select()
|
|
.from(issues)
|
|
.where(eq(issues.id, f.issueId));
|
|
expect(issue).toMatchObject({ status: "blocked", executionRunId: null });
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.agentId, f.agentId)),
|
|
).toHaveLength(3);
|
|
expect(f.authority.mock.calls.map((call) => call[1].phase)).toEqual([
|
|
"admission",
|
|
"execution",
|
|
]);
|
|
});
|
|
|
|
it.each([false, true])("preserves the exact retry column and comment batch during promotion (execution hold=%s)", async (held) => {
|
|
const f = await retryFixture(true);
|
|
const clearHold = held ? await executionHold(f) : null;
|
|
f.register();
|
|
await f.wake();
|
|
await clearHold?.();
|
|
// A separate fixture-owned run occupies the agent slot after the issue's
|
|
// predecessor releases it, so this asserts promotion before execution.
|
|
const blockerId = randomUUID();
|
|
await db.insert(heartbeatRuns).values({
|
|
id: blockerId,
|
|
companyId: f.companyId,
|
|
agentId: f.agentId,
|
|
status: "running",
|
|
contextSnapshot: { issueId: randomUUID() },
|
|
});
|
|
runningProcesses.set(blockerId, {
|
|
child: {} as never,
|
|
graceSec: 0,
|
|
processGroupId: null,
|
|
});
|
|
liveRunIds.add(blockerId);
|
|
await f.heartbeat.cancelRun(f.activeRunId, "Fixture predecessor finished", {
|
|
suppressImmediateRecovery: true,
|
|
});
|
|
await f.heartbeat.drainActiveRunExecutions();
|
|
const [run] = await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.wakeupRequestId, f.actionId));
|
|
expect(run).toMatchObject({
|
|
status: "queued",
|
|
retryOfRunId: f.failedRunId,
|
|
contextSnapshot: f.context,
|
|
});
|
|
const [receipt] = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, f.actionId));
|
|
expect(receipt).toMatchObject({ status: "queued", runId: run.id });
|
|
expect(f.authority.mock.calls.map((call) => call[1].phase)).toEqual([
|
|
"admission",
|
|
"promotion",
|
|
]);
|
|
});
|
|
|
|
it.each([false, true])(
|
|
"rechecks current retry authority immediately before dispatch (revoked=%s)",
|
|
async (revoked) => {
|
|
const f = await retryFixture();
|
|
await db
|
|
.update(agents)
|
|
.set({ adapterType: "durable_chat_retry_test" })
|
|
.where(eq(agents.id, f.agentId));
|
|
f.register();
|
|
const queued = await f.wake();
|
|
let executionChecks = 0;
|
|
f.authority.mockImplementation(async (_tx, input) => {
|
|
if (input.phase === "execution" && ++executionChecks === 2 && revoked) {
|
|
throw conflict("Current chat access was revoked before dispatch", {
|
|
code: "chat_failed_run_retry_not_authorized",
|
|
});
|
|
}
|
|
});
|
|
await f.heartbeat.cancelRun(
|
|
f.activeRunId,
|
|
"Fixture execution slot released",
|
|
{ suppressImmediateRecovery: true },
|
|
);
|
|
await f.heartbeat.drainActiveRunExecutions();
|
|
const [run] = await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.id, queued!.id));
|
|
expect(executionChecks).toBe(2);
|
|
expect(execute).toHaveBeenCalledTimes(revoked ? 0 : 1);
|
|
expect(run).toMatchObject({
|
|
status: revoked ? "failed" : "succeeded",
|
|
retryOfRunId: f.failedRunId,
|
|
nativeSessionId: null,
|
|
});
|
|
if (revoked)
|
|
expect(run.errorCode).toBe("chat_failed_run_retry_not_authorized");
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.agentId, f.agentId)),
|
|
).toHaveLength(3);
|
|
expect(f.authority.mock.calls.map((call) => call[1].phase)).toEqual([
|
|
"admission",
|
|
"execution",
|
|
"execution",
|
|
]);
|
|
},
|
|
);
|
|
|
|
it.each([
|
|
{ forceFreshSession: true },
|
|
{ resumeFromRunId: randomUUID() },
|
|
{ resumeSessionParams: { sessionId: "unrelated-provider-session" } },
|
|
{ resumeSessionDisplayId: "unrelated-provider-session" },
|
|
])(
|
|
"does not admit routing overrides on an exact retry (%j)",
|
|
async (override) => {
|
|
const f = await retryFixture();
|
|
f.register();
|
|
await expect(
|
|
f.wake({ contextSnapshot: { ...f.context, ...override } }),
|
|
).rejects.toBeInstanceOf(FailedChatRunRetryAuthorizationError);
|
|
expect(f.authority).not.toHaveBeenCalled();
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, f.actionId)),
|
|
).toEqual([]);
|
|
},
|
|
);
|
|
|
|
it.each([
|
|
{ withDeferredInput: false, sourceKind: "inbound_wakeup" },
|
|
{ withDeferredInput: true, sourceKind: "inbound_wakeup" },
|
|
{ withDeferredInput: false, sourceKind: "unrelated_action" },
|
|
{ withDeferredInput: false, sourceKind: "missing" },
|
|
].flatMap((scope) => [false, true].map((preProvider) => ({ ...scope, preProvider }))))(
|
|
"fences generic recovery by actual original chat ownership ($sourceKind, deferred=$withDeferredInput, pre-provider=$preProvider)",
|
|
async ({ withDeferredInput, sourceKind, preProvider }) => {
|
|
const f = await retryFixture();
|
|
await db
|
|
.update(agents)
|
|
.set({ adapterType: "durable_chat_retry_test" })
|
|
.where(eq(agents.id, f.agentId));
|
|
await db
|
|
.update(chatActions)
|
|
.set({ kind: sourceKind, payload: { issueId: f.issueId } })
|
|
.where(eq(chatActions.id, f.actionId));
|
|
if (sourceKind === "missing")
|
|
await db.delete(chatActions).where(eq(chatActions.id, f.actionId));
|
|
const genericRecoveryExpected = preProvider && sourceKind !== "inbound_wakeup";
|
|
const nextExecutionExpected = preProvider && (withDeferredInput || genericRecoveryExpected);
|
|
const { failedRunRetry: _retry, ...ordinaryRequest } = f.request;
|
|
const wakeOriginal = (id: string, commentId: string) =>
|
|
f.heartbeat.wakeup(f.agentId, {
|
|
source: "assignment",
|
|
triggerDetail: "system",
|
|
reason: "chat_message_received",
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "board-user",
|
|
payload: {
|
|
issueId: f.issueId,
|
|
wakeCommentId: commentId,
|
|
wakeCommentIds: [commentId],
|
|
},
|
|
contextSnapshot: {
|
|
issueId: f.issueId,
|
|
taskKey: f.context.taskKey,
|
|
source: "chat:slack",
|
|
wakeCommentId: commentId,
|
|
wakeCommentIds: [commentId],
|
|
},
|
|
durableChatRequest: createDurableChatWakeupRequest({
|
|
...ordinaryRequest,
|
|
id,
|
|
commentId,
|
|
}),
|
|
allowRunCoalescing: false,
|
|
});
|
|
if (preProvider) {
|
|
execute.mockResolvedValueOnce({
|
|
exitCode: 1, signal: null, timedOut: false,
|
|
summary: "Fixture failed before provider work",
|
|
resultJson: { executionRecovery: { kind: "bootstrap", providerWorkStarted: false } },
|
|
});
|
|
} else {
|
|
execute.mockRejectedValueOnce(new Error("Original chat provider outcome is unknown"));
|
|
}
|
|
const original = await wakeOriginal(f.actionId, f.commentIds[1]);
|
|
const deferredId = randomUUID();
|
|
if (withDeferredInput) {
|
|
const [owner] = await db
|
|
.select()
|
|
.from(chatActions)
|
|
.where(eq(chatActions.id, f.actionId));
|
|
await db.insert(chatActions).values({
|
|
...owner,
|
|
id: deferredId,
|
|
providerActionId: `wakeup:${deferredId}`,
|
|
});
|
|
expect(await wakeOriginal(deferredId, f.commentIds[0])).toBeNull();
|
|
const [receipt] = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, deferredId));
|
|
expect(receipt.status).toBe("deferred_issue_execution");
|
|
}
|
|
await f.heartbeat.cancelRun(
|
|
f.activeRunId,
|
|
"Fixture execution slot released",
|
|
{ suppressImmediateRecovery: true },
|
|
);
|
|
await f.heartbeat.drainActiveRunExecutions();
|
|
const [run] = await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.id, original!.id));
|
|
expect(run).toMatchObject({
|
|
status: "failed",
|
|
retryOfRunId: null,
|
|
wakeupRequestId: f.actionId,
|
|
});
|
|
expect(execute).toHaveBeenCalledTimes(
|
|
nextExecutionExpected ? 2 : 1,
|
|
);
|
|
const runs = await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.agentId, f.agentId));
|
|
expect(runs).toHaveLength(
|
|
nextExecutionExpected ? 4 : 3,
|
|
);
|
|
expect(
|
|
runs.some(
|
|
(entry) =>
|
|
(entry.contextSnapshot as Record<string, unknown>)?.source ===
|
|
"issue.continuation_recovery",
|
|
),
|
|
).toBe(genericRecoveryExpected);
|
|
const [issue] = await db
|
|
.select()
|
|
.from(issues)
|
|
.where(eq(issues.id, f.issueId));
|
|
expect(issue).toMatchObject({
|
|
status:
|
|
nextExecutionExpected ? "done" : preProvider ? "blocked" : "in_progress",
|
|
executionRunId: null,
|
|
});
|
|
if (withDeferredInput) {
|
|
const [receipt] = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, deferredId));
|
|
const next = runs.find((entry) => entry.id === receipt.runId);
|
|
if (!preProvider) {
|
|
// Unknown earlier effects require reconciliation. Preserve the
|
|
// separate user's durable cause, without dispatching it on this
|
|
// cancellation/failure path or relabeling it as an automatic retry.
|
|
expect(receipt).toMatchObject({ status: "deferred_issue_execution", runId: null });
|
|
expect(next).toBeUndefined();
|
|
return;
|
|
}
|
|
expect(next).toMatchObject({
|
|
status: "succeeded",
|
|
retryOfRunId: null,
|
|
wakeupRequestId: deferredId,
|
|
contextSnapshot: {
|
|
source: "chat:slack",
|
|
wakeCommentIds: [f.commentIds[0]],
|
|
},
|
|
});
|
|
}
|
|
},
|
|
);
|
|
|
|
it("keeps committed-response authority exact-Db scoped and separate from retry hints", async () => {
|
|
const input = {
|
|
companyId: randomUUID(),
|
|
issueId: randomUUID(),
|
|
agentId: randomUUID(),
|
|
runId: randomUUID(),
|
|
resultId: randomUUID(),
|
|
};
|
|
const otherDb = {} as typeof db;
|
|
const authority = vi.fn(async () => undefined);
|
|
const dispose = registerCommittedChatResponseAuthority(db, authority);
|
|
try {
|
|
await expect(
|
|
authorizeCommittedChatResponse(otherDb, db, input),
|
|
).rejects.toBeInstanceOf(CommittedChatResponseAuthorizationError);
|
|
expect(authority).not.toHaveBeenCalled();
|
|
await authorizeCommittedChatResponse(db, db, input);
|
|
expect(authority).toHaveBeenCalledExactlyOnceWith(db, input);
|
|
} finally {
|
|
dispose();
|
|
}
|
|
await expect(
|
|
authorizeCommittedChatResponse(db, db, input),
|
|
).rejects.toBeInstanceOf(CommittedChatResponseAuthorizationError);
|
|
});
|
|
|
|
it("preserves the current committed-response authority and exact transient failure", async () => {
|
|
const input = {
|
|
companyId: randomUUID(),
|
|
issueId: randomUUID(),
|
|
agentId: randomUUID(),
|
|
runId: randomUUID(),
|
|
resultId: randomUUID(),
|
|
};
|
|
const first = registerCommittedChatResponseAuthority(
|
|
db,
|
|
async () => undefined,
|
|
);
|
|
const storageFailure = new Error("temporary source storage failure");
|
|
const second = registerCommittedChatResponseAuthority(db, async () => {
|
|
throw storageFailure;
|
|
});
|
|
try {
|
|
first();
|
|
await expect(authorizeCommittedChatResponse(db, db, input)).rejects.toBe(
|
|
storageFailure,
|
|
);
|
|
} finally {
|
|
second();
|
|
}
|
|
});
|
|
|
|
it("does not discard a deferred retry on transient authority storage failure", async () => {
|
|
const f = await retryFixture(true);
|
|
f.register();
|
|
await f.wake();
|
|
const failure = new Error("Fixture authorization store unavailable");
|
|
f.authority.mockRejectedValueOnce(failure);
|
|
await expect(
|
|
f.heartbeat.cancelRun(f.activeRunId, "Fixture predecessor finished", {
|
|
suppressImmediateRecovery: true,
|
|
}),
|
|
).rejects.toBe(failure);
|
|
const [receipt] = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, f.actionId));
|
|
expect(receipt).toMatchObject({
|
|
status: "deferred_issue_execution",
|
|
runId: null,
|
|
});
|
|
expect(receipt.payload).toMatchObject({ wakeCommentIds: f.commentIds });
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.wakeupRequestId, f.actionId)),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it("retries and competing workers create one queued receipt and one run", async () => {
|
|
const f = await fixture();
|
|
const request = f.request();
|
|
await Promise.all([f.wake(request), f.wake(request)]);
|
|
await f.wake(request);
|
|
const receipts = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, request.id));
|
|
expect(receipts).toHaveLength(1);
|
|
expect(receipts[0]).toMatchObject({
|
|
status: "queued",
|
|
idempotencyKey: request.idempotencyKey,
|
|
});
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(
|
|
and(
|
|
eq(heartbeatRuns.agentId, f.agentId),
|
|
eq(heartbeatRuns.wakeupRequestId, request.id),
|
|
),
|
|
),
|
|
).toHaveLength(1);
|
|
expect(f.authorize).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("records a stable receipt when merging into a deferred wake and never merges the replay twice", async () => {
|
|
const f = await fixture(true);
|
|
const first = f.request(),
|
|
second = f.request();
|
|
await f.wake(first);
|
|
await f.wake(second);
|
|
await f.wake(second);
|
|
const rows = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.agentId, f.agentId));
|
|
expect(rows).toHaveLength(2);
|
|
expect(rows.find((row) => row.id === first.id)).toMatchObject({
|
|
status: "deferred_issue_execution",
|
|
coalescedCount: 1,
|
|
});
|
|
expect(rows.find((row) => row.id === second.id)).toMatchObject({
|
|
status: "coalesced",
|
|
payload: { coalescedIntoWakeupRequestId: first.id },
|
|
});
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.agentId, f.agentId)),
|
|
).toHaveLength(1);
|
|
});
|
|
|
|
it("keeps different actors in separate deferred receipts", async () => {
|
|
const f = await fixture(true);
|
|
await f.wake(f.request());
|
|
await f.wake(f.request(randomUUID(), "another-user"));
|
|
const rows = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.agentId, f.agentId));
|
|
expect(rows).toHaveLength(2);
|
|
expect(
|
|
rows.every(
|
|
(row) =>
|
|
row.status === "deferred_issue_execution" && row.coalescedCount === 0,
|
|
),
|
|
).toBe(true);
|
|
});
|
|
|
|
it("records queued-run coalescence once with the stable receipt ID", async () => {
|
|
const f = await fixture();
|
|
const first = f.request(),
|
|
second = f.request();
|
|
await f.wake(first);
|
|
const [firstReceipt] = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, first.id));
|
|
await db
|
|
.update(issues)
|
|
.set({
|
|
executionRunId: firstReceipt.runId,
|
|
executionAgentNameKey: "maya",
|
|
executionLockedAt: new Date(),
|
|
})
|
|
.where(eq(issues.id, f.issueId));
|
|
await f.wake(second);
|
|
await f.wake(second);
|
|
const [receipt] = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, second.id));
|
|
expect(receipt).toMatchObject({
|
|
status: "coalesced",
|
|
runId: firstReceipt.runId,
|
|
coalescedCount: 1,
|
|
});
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.agentId, f.agentId)),
|
|
).toHaveLength(2);
|
|
});
|
|
|
|
it("rejects a stable receipt ID reused for a different authenticated actor", async () => {
|
|
const f = await fixture();
|
|
const first = f.request();
|
|
await f.wake(first);
|
|
const conflicting = createDurableChatWakeupRequest({
|
|
...first,
|
|
requestedByActorId: "different-user",
|
|
});
|
|
await expect(f.wake(conflicting)).rejects.toThrow(
|
|
"chat_inbound_wakeup_receipt_conflict",
|
|
);
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.agentId, f.agentId)),
|
|
).toHaveLength(1);
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.agentId, f.agentId)),
|
|
).toHaveLength(2);
|
|
});
|
|
|
|
it("never readmits or dispatches a cancelled receipt on replay", async () => {
|
|
const f = await fixture();
|
|
const request = f.request();
|
|
await f.wake(request);
|
|
const [receipt] = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.id, request.id));
|
|
await db
|
|
.update(agentWakeupRequests)
|
|
.set({ status: "cancelled" })
|
|
.where(eq(agentWakeupRequests.id, request.id));
|
|
await db
|
|
.update(heartbeatRuns)
|
|
.set({ status: "cancelled", finishedAt: new Date() })
|
|
.where(eq(heartbeatRuns.id, receipt.runId!));
|
|
await f.wake(request);
|
|
expect(f.authorize).toHaveBeenCalledTimes(1);
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.agentId, f.agentId)),
|
|
).toHaveLength(2);
|
|
});
|
|
|
|
it("does not accept a JSON copy of the internal scheduling capability", async () => {
|
|
const f = await fixture();
|
|
const request = f.request();
|
|
await expect(f.wake(JSON.parse(JSON.stringify(request)))).rejects.toThrow(
|
|
"chat_inbound_wakeup_binding_denied",
|
|
);
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.agentId, f.agentId)),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it("rechecks current authorization in the scheduling transaction", async () => {
|
|
const f = await fixture();
|
|
f.authorize.mockRejectedValueOnce(new Error("reach revoked"));
|
|
await expect(f.wake(f.request())).rejects.toThrow("reach revoked");
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.agentId, f.agentId)),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it.each([
|
|
{ provider: "slack", state: "active", callerMarkers: false },
|
|
{ provider: "telegram", state: "completed", callerMarkers: false },
|
|
{ provider: "slack", state: "active", callerMarkers: true },
|
|
] as const)(
|
|
"rejects generic failed-chat retry before admission ($provider/$state; caller markers: $callerMarkers)",
|
|
async ({ provider, state, callerMarkers }) => {
|
|
// Keep the fixture-owned unrelated run occupying the only execution slot.
|
|
// This exercises real heartbeat admission without starting an adapter.
|
|
const f = await fixture();
|
|
const applicationId = randomUUID();
|
|
const connectionId = randomUUID();
|
|
const endpointId = randomUUID();
|
|
const conversationId = randomUUID();
|
|
const originalCommentId = randomUUID();
|
|
const failedCommentId = randomUUID();
|
|
const taskKey = `D${f.companyId.slice(0, 7)}-1`;
|
|
await db
|
|
.update(issues)
|
|
.set({
|
|
identifier: taskKey,
|
|
description: "Original request A: describe the original photo.",
|
|
})
|
|
.where(eq(issues.id, f.issueId));
|
|
await db.insert(toolApplications).values({
|
|
id: applicationId,
|
|
companyId: f.companyId,
|
|
name: "Failed chat retry",
|
|
type: "chat",
|
|
});
|
|
await db.insert(toolConnections).values({
|
|
id: connectionId,
|
|
companyId: f.companyId,
|
|
applicationId,
|
|
name: `${provider} failed chat retry`,
|
|
uid: `chat-retry-${connectionId}`,
|
|
connectionPurpose: "channel",
|
|
transport: "chat_sdk",
|
|
enabled: true,
|
|
status: "active",
|
|
});
|
|
await db.insert(chatEndpoints).values({
|
|
id: endpointId,
|
|
companyId: f.companyId,
|
|
connectionId,
|
|
provider,
|
|
publicId: randomUUID(),
|
|
assignedAgentId: f.agentId,
|
|
status: "active",
|
|
});
|
|
await db.insert(chatConversations).values({
|
|
id: conversationId,
|
|
companyId: f.companyId,
|
|
endpointId,
|
|
issueId: f.issueId,
|
|
externalConversationId: `${provider}-retry-dm`,
|
|
externalThreadId: `${provider}-retry-thread`,
|
|
externalLabel: `${provider} retry fixture`,
|
|
sessionGeneration: 1,
|
|
isDirectMessage: true,
|
|
state: "active",
|
|
});
|
|
await db.insert(issueComments).values([
|
|
{
|
|
id: originalCommentId,
|
|
companyId: f.companyId,
|
|
issueId: f.issueId,
|
|
authorUserId: "board-user",
|
|
body: "Original request A: describe the original photo.",
|
|
},
|
|
{
|
|
id: failedCommentId,
|
|
companyId: f.companyId,
|
|
issueId: f.issueId,
|
|
authorUserId: "board-user",
|
|
body: "Later request B: explain the new queue behavior, not the photo.",
|
|
},
|
|
]);
|
|
await db.insert(chatMessageLinks).values(
|
|
[originalCommentId, failedCommentId].map((commentId, index) => ({
|
|
companyId: f.companyId,
|
|
endpointId,
|
|
conversationId,
|
|
commentId,
|
|
providerMessageId: `${provider}-retry-${index}`,
|
|
direction: "inbound",
|
|
})),
|
|
);
|
|
const request = f.request(failedCommentId);
|
|
await queueIssueAssignmentWakeup({
|
|
heartbeat: f.heartbeat,
|
|
issue: {
|
|
id: f.issueId,
|
|
assigneeAgentId: f.agentId,
|
|
status: "in_progress",
|
|
},
|
|
reason: "External chat message received",
|
|
mutation: "chat_message_received",
|
|
contextSource: `chat:${provider}`,
|
|
taskKey,
|
|
requestedByActorType: request.requestedByActorType,
|
|
requestedByActorId: request.requestedByActorId,
|
|
wakeCommentId: failedCommentId,
|
|
durableChatRequest: request,
|
|
rethrowOnError: true,
|
|
});
|
|
const [admitted] = await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.wakeupRequestId, request.id));
|
|
expect(admitted).toMatchObject({
|
|
status: "queued",
|
|
contextSnapshot: {
|
|
taskKey,
|
|
source: `chat:${provider}`,
|
|
wakeCommentId: failedCommentId,
|
|
wakeCommentIds: [failedCommentId],
|
|
},
|
|
});
|
|
// Simulate a transient execution failure, not an integrity fault or a
|
|
// manual edit to any live runner root. The admitted request stays intact.
|
|
await db
|
|
.update(heartbeatRuns)
|
|
.set({ status: "failed", finishedAt: new Date() })
|
|
.where(eq(heartbeatRuns.id, admitted.id));
|
|
await db
|
|
.update(agentWakeupRequests)
|
|
.set({ status: "failed", finishedAt: new Date() })
|
|
.where(eq(agentWakeupRequests.id, request.id));
|
|
await db
|
|
.update(issues)
|
|
.set({
|
|
status: "blocked",
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
})
|
|
.where(eq(issues.id, f.issueId));
|
|
if (state === "completed") {
|
|
await db
|
|
.update(chatConversations)
|
|
.set({ state: "completed" })
|
|
.where(eq(chatConversations.id, conversationId));
|
|
}
|
|
const snapshot = async () => ({
|
|
runs: await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.agentId, f.agentId))
|
|
.orderBy(heartbeatRuns.id),
|
|
receipts: await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.agentId, f.agentId))
|
|
.orderBy(agentWakeupRequests.id),
|
|
issue: await db.select().from(issues).where(eq(issues.id, f.issueId)),
|
|
conversation: await db
|
|
.select()
|
|
.from(chatConversations)
|
|
.where(eq(chatConversations.id, conversationId)),
|
|
publications: await db
|
|
.select()
|
|
.from(chatPublications)
|
|
.where(eq(chatPublications.conversationId, conversationId)),
|
|
});
|
|
const before = await snapshot();
|
|
// This is the existing IssueDetail/Inbox generic wakeup API, deliberately
|
|
// lacking a failed-run ID. It must not silently retry A in a UUID-keyed
|
|
// session after losing B's exact chat comment and admission authority.
|
|
const rejection = await f.heartbeat
|
|
.wakeup(f.agentId, {
|
|
source: "on_demand",
|
|
triggerDetail: "manual",
|
|
reason: "retry_failed_run",
|
|
payload: {
|
|
issueId: f.issueId,
|
|
...(callerMarkers
|
|
? {
|
|
retryOfRunId: admitted.id,
|
|
taskKey,
|
|
commentId: failedCommentId,
|
|
}
|
|
: {}),
|
|
},
|
|
...(callerMarkers
|
|
? {
|
|
contextSnapshot: {
|
|
source: `chat:${provider}`,
|
|
retryOfRunId: admitted.id,
|
|
wakeCommentId: failedCommentId,
|
|
wakeCommentIds: [failedCommentId],
|
|
},
|
|
}
|
|
: {}),
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "board-user",
|
|
})
|
|
.then(
|
|
() => null,
|
|
(error: unknown) => error,
|
|
);
|
|
expect.soft(rejection).toMatchObject({
|
|
status: 409,
|
|
details: { code: "chat_failed_run_retry_requires_authorized_context" },
|
|
});
|
|
const after = await snapshot();
|
|
expect.soft(after.receipts).toEqual(before.receipts);
|
|
expect.soft(after.runs).toEqual(before.runs);
|
|
expect.soft(after.issue).toEqual(before.issue);
|
|
expect.soft(after.conversation).toEqual(before.conversation);
|
|
expect.soft(after.publications).toEqual(before.publications);
|
|
expect(f.authorize).toHaveBeenCalledTimes(1);
|
|
},
|
|
);
|
|
|
|
it("preserves ordinary non-chat manual retry admission", async () => {
|
|
const f = await fixture();
|
|
const retry = await f.heartbeat.wakeup(f.agentId, {
|
|
source: "on_demand",
|
|
triggerDetail: "manual",
|
|
reason: "retry_failed_run",
|
|
payload: { issueId: f.issueId },
|
|
requestedByActorType: "user",
|
|
requestedByActorId: "board-user",
|
|
});
|
|
expect(retry).toMatchObject({
|
|
status: "queued",
|
|
contextSnapshot: {
|
|
issueId: f.issueId,
|
|
taskKey: f.issueId,
|
|
wakeReason: "retry_failed_run",
|
|
},
|
|
});
|
|
const receipts = await db
|
|
.select()
|
|
.from(agentWakeupRequests)
|
|
.where(eq(agentWakeupRequests.agentId, f.agentId));
|
|
expect(receipts).toHaveLength(1);
|
|
expect(receipts[0]).toMatchObject({ status: "queued", runId: retry!.id });
|
|
expect(
|
|
await db
|
|
.select()
|
|
.from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.agentId, f.agentId)),
|
|
).toHaveLength(2);
|
|
});
|
|
});
|