Dotta
89703c3ff7
## Thinking Path > - Paperclip helps people manage AI agents and their work. > - The Coordinator sidebar gives people access to workspace pages. > - People can pin pages from the More menu. > - The sidebar puts these links below More in a separate Pinned section. > - This change puts pinned links above More in the main navigation. > - People can reach their saved pages without an extra section heading. ## Linked Issues or Issue Description **What existing behavior does this improve?** The placement of pinned pages in the Coordinator sidebar. **Subsystem affected** ui/ — React board UI. **Current behavior** Pinned pages appear below More with a Pinned heading and extra space. **Proposed behavior** Pinned pages appear after Needs you and before More. They use the same row spacing as the main links. **Reason and benefit** Saved pages belong with the main navigation. This placement keeps them visible above the menu that contains the other pages. **Breaking changes** The Pinned section and its heading are removed. Saved pin data, link order, routes, and pin controls use the existing code. ## What Changed - Move pinned links into the primary navigation above More. - Remove the separate section, heading, and extra space. - Correct the feature guide to state that pinned pages appear above More. - Update sidebar tests to check placement, saved order, account changes, restore, and pin removal. ## Verification - `pnpm exec vitest run ui/src/components/CoordinatorSidebar.test.tsx`: 15 tests pass. - `pnpm check:token-gates`: pass. - `node scripts/check-maps.mjs`: pass after the guide correction. - `pnpm --filter @paperclipai/ui typecheck`: pass. - Browser checks pass in Chromium against the production Coordinator sidebar in Storybook with fixture data. Screenshots cover saved pins and pinning from More. No page errors occurred. This does not test a live API. - The full workspace typecheck and build stop because this host has no Rust `cargo` command. - The first UI build was killed and the browser crashed while checks ran together. The host recorded OOM kills at its 8 GB limit. The browser check then passed after the full-suite process was stopped. The UI production build passed after the Storybook server was stopped. - `NODE_OPTIONS=--max-old-space-size=4096 pnpm --filter @paperclipai/ui build`: pass. - `pnpm test:run`: stopped during the first chat integration shard after memory exhaustion affected other checks. It has no full-suite result. The CI run passed the test lanes on the latest head. - [CI run](https://github.com/paperclipai/paperclip/actions/runs/41768881396) passed on `a836fc1320c363e0fbb5591312c6726026b6f151`. The required `ci / verify` and `ci / e2e` checks pass. Build, typecheck, Rust checks, test lanes, and all eight browser shards pass. - Greptile: 5/5 on this head. The documentation finding is fixed and its thread is resolved. - The additional Paperclip review is paused and queued. It is not a required branch check. ## Risks Low risk. This change moves existing links. It does not change storage or API behavior. The tests check expanded and collapsed rendering, the empty state, stored order, unknown routes, user changes, and changes from another browser tab. ## Model Used OpenAI GPT-6 through the Codex agent. The session supports reasoning, tool use, code edits, and command execution. The runtime does not expose a more specific model ID or context window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
9.9 KiB
navigation
| navigation | ||||||
|---|---|---|---|---|---|---|
|
Navigation, profile, and announcements
People organize their sidebar, move between company resources, maintain their profile, and dismiss product announcements with the correct persistence and identity scope.
Feature ID: navigation-preferences.
Implementation: sidebar, profile, announcements.
Agent access: companion.
Sub-features
navigation:navigation-preferences/navigation— use current sidebar links, favorites, recents, and available layout controls.preferences:navigation-preferences/preferences— persist supported ordering/collapse choices for the intended user/company, and the personal experimental workspace choice.profile:navigation-preferences/profile— edit personal identity and inspect public profile links.announcements:navigation-preferences/announcements— inspect and dismiss an announcement with its intended instance-wide user scope.fallbacks:navigation-preferences/fallbacks— handle missing resources and old deep links without presenting another resource as the target.command-palette:navigation-preferences/command-palette— open quick search and creation actions with keyboard shortcuts, then carry query/filter intent into full search.
How to get to it (user POV)
sidebar-deep-links
Use starred/recent/sidebar links and direct company-prefixed URLs.
profile-announcements
Use Settings → Profile, /u/:userSlug, and the announcement well when a publication is available.
palette-shortcuts
Press Cmd/Ctrl+K to open the command palette. / focuses the current page search or opens quick search; ? opens shortcut help. Outside an input or modal, c starts New task and g then i opens Inbox/My work. In the palette, use Search all or Cmd/Ctrl+Enter for the full results page.
Driving it with Playwright and the Paperclip CLI
Preconditions: follow the baseline. Use two test users and companies; record the selected UI shell and any client-local preference storage.
sidebar-deep-links
Automated: sidebar and sidebar preference routes cover UI/server behavior.
Manual: Star and reorder supported resources, collapse a section, navigate and reload. Switch company/user and inspect the intended preference scope. Open an unavailable resource and a legacy route; verify clear fallback or correct redirect without leaking another company’s state.
Record persistence separately: section collapse is in-memory and reopens after reload; global sidebar collapse is disabled. Streamlined starred projects sort alphabetically. Recents are browser-local by user/company; stars and supported ordering are saved server-side. Local-trusted mode does not prove two-user isolation.
profile-announcements
Automated: profile page, announcement hook, and announcement routes cover separate UI/persistence layers.
Manual: Change a disposable user’s display details, reload, and inspect an attributed profile link. Dismiss a fixture announcement, switch companies, and verify it remains dismissed for that user; check another user still has their own dismissal state.
palette-shortcuts
Automated: Command palette, shortcut hook, shortcut rules, and cheatsheet test components and keyboard rules. Company search covers search contracts; browser focus and identity transitions still need a live check.
Manual: Use uniquely named visible and private task/project fixtures. Open the palette, find a permitted result, follow it, and reload the destination. Enter text with quick-filter chips such as assignee:me, is:open, and updated:>7d; use Search all and Cmd/Ctrl+Enter in separate attempts and verify the resulting query and filters. Switch person/company and confirm private results do not leak. Test / on a page with search and a page without it; inspect ?, c, and g i. Type those keys inside an editor and a modal: they must not unexpectedly navigate or create work. Test a create action through its normal dialog and inspect the actual saved resource separately.
Sources: Command palette, shortcut hook, query parser, and search routes.
Gotchas
-
Cmd/Ctrl+B is not a supported global sidebar shortcut. Use the current shortcut help and verify that typing and modal focus suppress navigation chords.
-
Announcement dismissals are intentionally instance-wide user preferences, unlike company-scoped domain data.
-
Legacy/production shells need their own navigation check when affected.
-
A route redirect is part of the journey; do not document a removed screen as if it still renders.
Storybook verification
preferences
Capability ID: navigation-preferences/preferences.
Scope: ui Storybook: Mount Sidebar using real preference boundary with stars/order/collapse/recents state. Clearly distinguish in-memory section collapse, browser-local recents and server-saved stars/order. Production: GET/PUT /sidebar-preferences/me and /companies/{id}/sidebar-preferences/me plus stars must retain intended user/company isolation across reload and switch. Section collapse reopens after reload; global collapse is disabled. Sources: Source: Sidebar.tsx, sidebar-preferences.ts, sidebar-preferences.ts. Tests: Sidebar.test.tsx, sidebar-preferences-routes.test.ts
fallbacks
Capability ID: navigation-preferences/fallbacks.
Scope: browser Storybook: A NotFound rendering story can help polish, but missing-resource/legacy-deep-link capability principally needs real App/router/browser scenarios preserving company and query intent. Production: Cold-open invalid company/resource and retired URL; verify explicit fallback or correct canonical redirect without silently targeting a different resource/company. Sources: Source: NotFound.tsx, App.tsx, company-routes.ts. Tests: App.activity-routing.test.tsx, App.cases-routing.test.tsx, App.test.tsx, company-routes.test.ts
Recent task refresh performance
Saved recent tasks render immediately. One summary batch refreshes at most five IDs per company/account without passive full-detail or workspace inspection. Successful omissions remove unavailable entries; failed reads preserve history. Verify rename, inbox archive, pause/restart, reload, cross-tab updates and account switches. Inbox archive does not remove the task from recent history.
Personal Coordinator workspace
Settings → Experimental → Coordinator workspace opts the current person into the experimental shell; off restores classic. The server saves the choice by user across companies, separate from instance feature flags. The local-trusted identity is shared Local Board, not evidence of multi-user isolation. Agent Chat remains an independent instance prerequisite. When it is off, the personal card explains the dependency and links eligible instance administrators to the existing Agent Chat control. Hidden or Cloud-managed controls are not presented as editable. Disabled Chat routes link back to Experimental settings. Enabling the personal workspace never changes the instance capability.
Automated: preference hook, prerequisite settings card, authorization, and database persistence. Manual: toggle on/off, reload, switch companies/accounts, and simulate failed reads and saves. Confirm existing work is unchanged and a failed save keeps the current choice. The Settings card story uses the production component with simulated API responses; it does not establish real persistence or permission behavior.
Coordinator More exposes a pin/unpin button beside every destination. Pinned pages appear above More in pinning order and retain the existing company-aware routes. Unpin from either the flyout or the pinned row. The list is personal to the current user in this browser, shared across companies; it does not sync across devices. Only known route names are rendered. Storage failures show a save error. The pin hook owns browser persistence; sidebar tests cover pin/unpin, remount persistence, account separation, unknown routes and cross-tab updates. Manual: pin with mouse and keyboard, reload, follow a pinned link, unpin from both locations, and check the mobile drawer. Local-trusted checks do not prove two-user authenticated browser isolation.