Files
PaperClipAI/server/src/services/native-runtime/runtime-mode.test.ts
T
Dotta 28a02f1853 Reconcile Claude defaults with merged Codex source
Co-Authored-By: Paperclip <noreply@paperclip.ing>

* codex/claude-runner-protocol: (84 commits)
  feat: default new Codex agents to Paperclip Runner on Linux and macOS (#15683)
  docs(skills): add slow-query diagnosis and fix skill (#16303)
  feat(sentry): add opt-in run failure reporting with saved run references (#16300)
  refactor(server): isolate provider message admission and runtime policies (#16289)
  refactor(server): isolate provider webhook lifecycle decisions (#16283)
  fix(workspaces): keep cleanup Git scans fresh and dedupe page reads (#16302)
  fix(sentry): keep provider-rejected Grok wakes out of run failure reports (#16297)
  fix(runner): report Runner disconnect age when a Dot bridge exits (#16296)
  refactor(server): isolate chat conversation and control policies (#16276)
  perf(recovery): use indexed execution identity lookups (#16291)
  perf(runs): bound history and reduce repeated context reads (#16286)
  fix(native-runtime): report which close barrier failed (#16298)
  feat(skills): select and validate tracked GitHub branches (#16288)
  fix(observability): sample native runs independently of triggers (#16285)
  fix(github): retry and recover review publication (#16284)
  perf(workspaces): wake terminal cleanup from committed changes (#16282)
  fix(mcp): deduplicate discovered tool descriptors (#16281)
  perf: remove history scans from task and chat queries (#16278)
  docs(skills): add maintenance bot setup workflow (#16279)
  fix(observability): time execution configuration steps (#16236)
  ...

# Conflicts:
#	maps/feature-map/onboarding.md
#	maps/storybook-map/INDEX.md
#	maps/storybook-map/REVIEW.md
#	maps/storybook-map/catalog.json
#	packages/shared/src/agent-runner.ts
#	server/src/routes/agents.ts
#	server/src/services/agent-runner-selection.ts
#	server/src/services/company-portability.ts
#	server/src/services/native-runtime/native-execution-input.ts
#	server/src/services/native-runtime/provider-profile.ts
#	server/src/services/native-runtime/runtime-mode.test.ts
#	server/src/services/native-runtime/runtime-mode.ts
#	ui/src/adapters/adapter-display-registry.ts
#	ui/src/components/AgentConfigForm.render.test.tsx
#	ui/src/components/AgentRunnerSelect.tsx
#	ui/src/components/OnboardingWizard.test.tsx
#	ui/src/components/OnboardingWizard.tsx
#	ui/src/pages/CompanyImport.tsx
#	ui/storybook/stories/agents/codex-runner-creation.stories.tsx
#	ui/storybook/stories/agents/codex-runner/creation.stories.tsx
#	ui/storybook/stories/codex-runner/creation.stories.tsx
2026-10-14 12:11:07 -05:00

509 lines
17 KiB
TypeScript

import { describe, expect, it } from "vitest";
import { BUILTIN_ADAPTER_TYPES } from "../../adapters/builtin-adapter-types.js";
import {
NativeRunnerSelectionError,
NativeRuntimeEligibilityError,
isRunnerIngressAuthorized,
resolveHeartbeatNativeRuntimeMode,
resolveHeartbeatRuntimeMode,
resolveNativeRuntimeMode,
} from "./runtime-mode.js";
const eligible = {
enabled: true,
runtimeConfig: {},
adapterConfig: { provider: "codex" },
agent: { status: "running", adapterType: "paperclip_runner" },
issue: { id: "issue", workMode: "standard" },
target: { kind: "local" },
workspaceId: "workspace",
} as const;
describe("resolveNativeRuntimeMode", () => {
it("keeps every direct built-in adapter outside native arbitration", () => {
for (const adapterType of BUILTIN_ADAPTER_TYPES) {
if (adapterType === "paperclip_runner") continue;
expect(resolveNativeRuntimeMode({
...eligible,
enabled: false,
runtimeConfig: {
nativeRunner: {
mode: "native",
backend: "codex_app_server",
protocolVersion: 1,
},
},
agent: { ...eligible.agent, adapterType },
})).toEqual({
kind: "legacy",
resolverVersion: "phase6-v1",
reason: "direct_adapter",
});
}
});
it("admits fresh native Codex when the experimental rollout is disabled", () => {
expect(resolveNativeRuntimeMode({
...eligible,
enabled: false,
})).toMatchObject({ kind: "native", profile: { backend: "codex_app_server" } });
});
it.each([
[false, false],
[false, true],
[true, false],
])("retains the Grok Bot gate with runner enabled=%s and Grok enabled=%s", (enabled, grokEnabled) => {
expect(() => resolveNativeRuntimeMode({
...eligible,
enabled,
grokEnabled,
adapterConfig: {
provider: "grok_bot",
externalBindingId: "00000000-0000-4000-8000-000000000001",
allowUnmeteredProvider: true,
},
})).toThrow(expect.objectContaining({ code: "paperclip_runner_grok_disabled" }));
});
it("admits a bound Grok Bot when its existing experimental gates are enabled", () => {
expect(resolveNativeRuntimeMode({
...eligible,
grokEnabled: true,
adapterConfig: {
provider: "grok_bot",
externalBindingId: "00000000-0000-4000-8000-000000000001",
allowUnmeteredProvider: true,
},
})).toMatchObject({ kind: "native", profile: { backend: "grok_bot_mcp" } });
});
it("still rejects experimental providers while the rollout flag is disabled", () => {
expect(() => resolveNativeRuntimeMode({
...eligible,
enabled: false,
adapterConfig: { provider: "opencode", model: "openrouter/deepseek/deepseek-v4-flash-0731" },
})).toThrow(expect.objectContaining({
code: "paperclip_runner_rollout_disabled",
}));
});
it("rejects unknown Paperclip Runner providers", () => {
expect(() => resolveNativeRuntimeMode({
...eligible,
runtimeConfig: {},
adapterConfig: { provider: "claude" },
agent: { ...eligible.agent, adapterType: "paperclip_runner" },
})).toThrow(expect.objectContaining({
code: "paperclip_runner_provider_unsupported",
}));
});
it("admits fresh local, managed, and qualified ACPX profiles", () => {
expect(resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "opencode", model: "openrouter/deepseek/deepseek-v4-flash-0731" },
})).toMatchObject({
kind: "native",
profile: { backend: "opencode_server" },
});
expect(resolveNativeRuntimeMode({
...eligible,
adapterConfig: {
provider: "claude_managed",
managedProfileId: "managed-primary",
managedAgentsRetentionAcknowledged: true,
},
})).toMatchObject({
kind: "native",
profile: { backend: "claude_managed_agents_api" },
});
expect(resolveNativeRuntimeMode({
...eligible,
adapterConfig: {
provider: "aws_agentcore",
agentCoreProfileId: "agentcore-primary",
agentCoreRetentionAcknowledged: true,
},
})).toMatchObject({
kind: "native",
profile: { backend: "aws_agentcore_harness_api" },
});
expect(resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "acpx", acpxAgent: "claude", model: "claude-sonnet-5" },
})).toMatchObject({
kind: "native",
profile: { backend: "acpx_runtime" },
});
expect(resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "acpx", acpxAgent: "codex", model: "gpt-5.6-sol" },
})).toMatchObject({
kind: "native",
profile: { backend: "acpx_runtime" },
});
});
it("rejects malformed OpenCode and unqualified ACPX profiles", () => {
expect(() => resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "opencode", model: "gpt-5.6-sol" },
})).toThrow(expect.objectContaining({
code: "paperclip_runner_opencode_model_invalid",
}));
for (const acpxAgent of ["copilot"]) {
expect(() => resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "acpx", acpxAgent, model: "explicit-provider-model" },
})).toThrow(expect.objectContaining({
code: "paperclip_runner_acpx_agent_unavailable",
}));
}
expect(() => resolveNativeRuntimeMode({
...eligible,
adapterConfig: { provider: "acpx", acpxAgent: "claude", model: "claude-opus-5" },
})).not.toThrow();
});
it("rejects incomplete managed-provider selections before a run is persisted", () => {
expect(() => resolveNativeRuntimeMode({
...eligible,
adapterConfig: {
provider: "claude_managed",
managedProfileId: "managed-primary",
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_claude_managed_retention_required",
}));
expect(() => resolveNativeRuntimeMode({
...eligible,
adapterConfig: {
provider: "aws_agentcore",
agentCoreRetentionAcknowledged: true,
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_aws_agentcore_profile_required",
}));
});
it("uses adapterConfig as the fresh provider authority", () => {
expect(resolveNativeRuntimeMode({
...eligible,
runtimeConfig: {
nativeRunner: { provider: "opencode" },
},
adapterConfig: { provider: "codex" },
})).toMatchObject({
kind: "native",
profile: { backend: "codex_app_server" },
});
});
it("preserves legacy as the default and as the kill-switch behavior", () => {
const direct = {
...eligible,
agent: { ...eligible.agent, adapterType: "codex_local" },
runtimeConfig: { nativeRunner: { mode: "native", backend: "codex_app_server", protocolVersion: 1 } },
};
expect(resolveNativeRuntimeMode(direct)).toEqual(expect.objectContaining({
kind: "legacy",
reason: "direct_adapter",
}));
expect(resolveNativeRuntimeMode({ ...direct, enabled: false })).toEqual(expect.objectContaining({
kind: "legacy",
reason: "direct_adapter",
}));
});
it("selects native only for an eligible explicit profile", () => {
expect(resolveNativeRuntimeMode(eligible)).toEqual(expect.objectContaining({
kind: "native",
reason: "eligible_opt_in",
}));
});
it("keeps a persisted experimental run native while the flag rejects a fresh start", () => {
const disabled = { ...eligible, enabled: false,
adapterConfig: { provider: "opencode", model: "openrouter/deepseek/deepseek-v4-flash-0731" },
};
expect(resolveHeartbeatNativeRuntimeMode({
...disabled,
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "opencode_server",
},
})).toEqual(expect.objectContaining({
kind: "native",
reason: "eligible_opt_in",
authorityDecision: expect.objectContaining({ reasonCode: "live_continuation_registered" }),
}));
expect(() => resolveHeartbeatNativeRuntimeMode({
...disabled,
persisted: { runtimeMode: null, runtimeModeReason: null, runtimeModeResolvedAt: null },
})).toThrow(expect.objectContaining({
code: "paperclip_runner_rollout_disabled",
}));
});
it("authorizes ingress from the native runtime decision without a second flag", () => {
const freshNative = resolveHeartbeatNativeRuntimeMode({
...eligible,
persisted: {
runtimeMode: null,
runtimeModeReason: null,
runtimeModeResolvedAt: null,
},
});
const persistedNative = resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
},
});
const directLegacy = resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
agent: { ...eligible.agent, adapterType: "codex_local" },
persisted: {
runtimeMode: null,
runtimeModeReason: null,
runtimeModeResolvedAt: null,
},
});
expect(isRunnerIngressAuthorized(freshNative)).toBe(true);
expect(isRunnerIngressAuthorized(persistedNative)).toBe(true);
expect(isRunnerIngressAuthorized(directLegacy)).toBe(false);
});
it.each(["paused", "terminated", "pending_approval"])(
"refuses persisted native recovery for a %s agent",
(status) => {
expect(() => resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
agent: { ...eligible.agent, status },
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "codex_app_server",
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_agent_ineligible",
}));
},
);
it("fails closed for an unknown persisted driver", () => {
expect(() => resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "unknown_driver",
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_driver_unsupported",
}));
});
it("does not recover a native run through a direct adapter", () => {
expect(() => resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
agent: { ...eligible.agent, adapterType: "codex_local" },
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "codex_app_server",
},
})).toThrow(expect.objectContaining({
code: "paperclip_runner_adapter_binding_mismatch",
}));
});
it("keeps a persisted OpenCode recovery on its immutable driver", () => {
expect(resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "opencode_server",
},
})).toEqual(expect.objectContaining({
profile: { mode: "native", backend: "opencode_server", protocolVersion: 1 },
}));
});
it.each([
"claude_managed_agents_api",
"aws_agentcore_harness_api",
] as const)("keeps a persisted %s recovery on its immutable driver", (driverKind) => {
expect(resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind,
},
})).toEqual(expect.objectContaining({
profile: { mode: "native", backend: driverKind, protocolVersion: 1 },
}));
});
it("keeps a persisted ACPX recovery even when fresh selection is disabled", () => {
expect(resolveHeartbeatNativeRuntimeMode({
...eligible,
enabled: false,
adapterConfig: {
provider: "acpx",
acpxAgent: "pi",
model: "historical",
},
persisted: {
runtimeMode: "native",
runtimeModeReason: "eligible_opt_in",
runtimeModeResolvedAt: new Date(),
driverKind: "acpx_runtime",
},
})).toEqual(expect.objectContaining({
profile: { mode: "native", backend: "acpx_runtime", protocolVersion: 1 },
}));
});
it("rejects an explicit native profile outside the approved boundary", () => {
expect(resolveNativeRuntimeMode({ ...eligible, agent: { ...eligible.agent, adapterType: "claude_local" } }))
.toEqual(expect.objectContaining({ kind: "legacy", reason: "direct_adapter" }));
expect(() => resolveNativeRuntimeMode({ ...eligible, issue: { id: "issue", workMode: "skill_test" } }))
.toThrow(NativeRuntimeEligibilityError);
});
it("admits remote targets only through paperclip_runner", () => {
expect(resolveNativeRuntimeMode({
...eligible,
target: { kind: "remote" },
runtimeConfig: {},
adapterConfig: { provider: "codex" },
agent: { ...eligible.agent, adapterType: "paperclip_runner" },
})).toMatchObject({ kind: "native" });
expect(resolveNativeRuntimeMode({
...eligible,
target: { kind: "remote" },
agent: { ...eligible.agent, adapterType: "codex_local" },
})).toMatchObject({ kind: "legacy", reason: "direct_adapter" });
});
it("allows paperclip_runner to use a transient local workspace for projectless issues", () => {
expect(resolveNativeRuntimeMode({
...eligible,
workspaceId: null,
agent: { ...eligible.agent, adapterType: "paperclip_runner" },
runtimeConfig: {},
adapterConfig: { provider: "codex" },
})).toEqual(expect.objectContaining({ kind: "native" }));
});
it("admits planning only through paperclip_runner", () => {
expect(resolveNativeRuntimeMode({
...eligible,
issue: { id: "plan-issue", workMode: "planning" },
runtimeConfig: {},
adapterConfig: { provider: "codex" },
agent: { ...eligible.agent, adapterType: "paperclip_runner" },
})).toMatchObject({ kind: "native", profile: { backend: "codex_app_server" } });
expect(resolveNativeRuntimeMode({
...eligible,
issue: { id: "plan-issue", workMode: "planning" },
agent: { ...eligible.agent, adapterType: "codex_local" },
})).toEqual(expect.objectContaining({ kind: "legacy", reason: "direct_adapter" }));
});
it("admits ask mode through paperclip_runner while preserving the legacy native boundary", () => {
expect(resolveNativeRuntimeMode({
...eligible,
issue: { id: "ask-issue", workMode: "ask" },
runtimeConfig: {},
adapterConfig: { provider: "codex" },
agent: { ...eligible.agent, adapterType: "paperclip_runner" },
})).toMatchObject({ kind: "native", profile: { backend: "codex_app_server" } });
expect(resolveNativeRuntimeMode({
...eligible,
issue: { id: "ask-issue", workMode: "ask" },
agent: { ...eligible.agent, adapterType: "codex_local" },
})).toEqual(expect.objectContaining({ kind: "legacy", reason: "direct_adapter" }));
});
});
const compatibilityInput = {
persisted: { runtimeMode: "legacy", runtimeModeResolvedAt: null },
enabled: true,
adapterConfig: { provider: "codex" },
agentStatus: "running",
issue: { workMode: "standard" },
executionTarget: { kind: "local" },
} as const;
describe("resolveHeartbeatRuntimeMode compatibility", () => {
it("keeps every direct built-in adapter on the legacy path", () => {
for (const adapterType of BUILTIN_ADAPTER_TYPES) {
if (adapterType === "paperclip_runner") continue;
expect(resolveHeartbeatRuntimeMode({
...compatibilityInput,
adapterType,
})).toEqual({
kind: "legacy",
resolverVersion: "paperclip-runner-v1",
reason: "direct_adapter",
});
}
});
it("preserves the original public result and error contracts", () => {
expect(resolveHeartbeatRuntimeMode({
...compatibilityInput,
adapterType: "paperclip_runner",
})).toEqual({
kind: "native",
resolverVersion: "paperclip-runner-v1",
reason: "explicit_paperclip_runner",
provider: "codex",
});
expect(resolveHeartbeatRuntimeMode({
...compatibilityInput,
enabled: false,
adapterType: "paperclip_runner",
persisted: { runtimeMode: "native", runtimeModeResolvedAt: new Date() },
})).toEqual({
kind: "native",
resolverVersion: "paperclip-runner-v1",
reason: "persisted_native_selection",
provider: "codex",
});
expect(() => resolveHeartbeatRuntimeMode({
...compatibilityInput,
enabled: false,
adapterType: "paperclip_runner",
adapterConfig: { provider: "opencode", model: "opencode/gpt-5" },
})).toThrow(NativeRunnerSelectionError);
});
it("admits native Claude without enabling other ACPX providers", () => {
expect(resolveNativeRuntimeMode({ ...eligible, enabled: false, adapterConfig: { provider: "acpx", acpxAgent: "claude" } })).toMatchObject({ kind: "native", profile: { backend: "acpx_runtime" } });
expect(() => resolveNativeRuntimeMode({ ...eligible, enabled: false, adapterConfig: { provider: "acpx", acpxAgent: "grok" } })).toThrow(expect.objectContaining({ code: "paperclip_runner_rollout_disabled" }));
});
});