Files
PaperClipAI/ui/src/components/EnvVarEditor.tsx
T
Nicky LeachandClaude Opus 4.8 b00271280a Add dynamic secret runtime UI: generate-at-runtime mode, test button, posture labeling
Stage 6 of the Dynamic Secrets epic (PAP-623). Inert behind the
enableDynamicSecrets experimental flag.

UI (ui/src/pages/Secrets.tsx):
- New "Generate at runtime" mode in the Create Secret modal, revealed only
  when enableDynamicSecrets is on. Captures name, key, generator command,
  a single cache TTL, and description; provider is fixed to host-command.
- Test button dry-runs the generator via the resolver and reports
  success/failure clearly without ever showing the produced value.
- Posture labeling (PRD §5): soft (same-UID / local-trusted) vs hard
  (sandboxed), driven by the Stage 5 capability flag and never claiming a
  hard boundary when the flag resolves to soft. §5 explainer covers
  privileged runtime minting, applicable posture, and operator-owned
  generator trust. Surfaced in the create modal and the secret detail tab.
- Lightweight fail-closed affordance for runtime generator failures (§7-2).

Binding UI (ui/src/components/EnvVarEditor.tsx):
- Operator-fixed static ARGV params per binding, revealed when a bound
  secret is dynamic_command. Never agent-supplied.

Backend:
- staticArgv threaded through EnvSecretRefBinding type/validator and the
  env-binding sync path (canonicalize, normalize, syncEnvBindingsForTarget).
- testDynamicCommand service + gated POST /companies/:id/secrets/dynamic-command/test
  route (returns pass/fail + byte length + posture, never the value).
- secretsApi.testDynamicCommand client + dynamicCommand on CreateSecretInput.

Tests: shared validator + server service/binding round-trip. Typecheck clean
across shared/server/ui.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 22:40:14 +00:00

473 lines
17 KiB
TypeScript

import { useEffect, useRef, useState } from "react";
import type { CompanySecret, EnvBinding, SecretVersionSelector } from "@paperclipai/shared";
import { AlertCircle, KeyRound, X } from "lucide-react";
import { cn } from "../lib/utils";
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from "@/components/ui/select";
const inputClass =
"w-full rounded-md border border-border px-2.5 py-1.5 bg-transparent outline-none text-sm font-mono placeholder:text-muted-foreground/40";
// shadcn Select trigger sized to line up with the mono inputs above.
const selectTriggerClass =
"h-[34px] min-h-[34px] rounded-md border-border bg-transparent px-2.5 text-sm font-mono shadow-none";
/** Radix Select forbids empty-string item values; use a sentinel for "unset". */
const SECRET_UNSET = "__unset__";
/** Suggest an env-var-style KEY from a secret name (UPPER_SNAKE). */
function envKeyFromSecretName(name: string): string {
return name
.trim()
.toUpperCase()
.replace(/[^A-Z0-9_]+/g, "_")
.replace(/^_+|_+$/g, "")
.slice(0, 64);
}
type Row = {
key: string;
source: "plain" | "secret";
plainValue: string;
secretId: string;
version: SecretVersionSelector;
// Operator-fixed argv for dynamic (host-command) generators. One entry per
// positional argument; never agent-supplied. Empty for non-dynamic secrets.
staticArgv: string[];
};
function emptyRow(): Row {
return { key: "", source: "plain", plainValue: "", secretId: "", version: "latest", staticArgv: [] };
}
function readStaticArgv(value: unknown): string[] {
if (!Array.isArray(value)) return [];
return value.filter((entry): entry is string => typeof entry === "string");
}
function toRows(rec: Record<string, EnvBinding> | null | undefined): Row[] {
if (!rec || typeof rec !== "object") {
return [emptyRow()];
}
const entries = Object.entries(rec).map(([key, binding]): Row => {
if (typeof binding === "string") {
return { key, source: "plain", plainValue: binding, secretId: "", version: "latest", staticArgv: [] };
}
if (
typeof binding === "object" &&
binding !== null &&
"type" in binding &&
(binding as { type?: unknown }).type === "secret_ref"
) {
const record = binding as { secretId?: unknown; version?: unknown; staticArgv?: unknown };
const version: SecretVersionSelector = typeof record.version === "number"
? record.version
: "latest";
return {
key,
source: "secret",
plainValue: "",
secretId: typeof record.secretId === "string" ? record.secretId : "",
version,
staticArgv: readStaticArgv(record.staticArgv),
};
}
if (
typeof binding === "object" &&
binding !== null &&
"type" in binding &&
(binding as { type?: unknown }).type === "plain"
) {
const record = binding as { value?: unknown };
return {
key,
source: "plain",
plainValue: typeof record.value === "string" ? record.value : "",
secretId: "",
version: "latest",
staticArgv: [],
};
}
return { key, source: "plain", plainValue: "", secretId: "", version: "latest", staticArgv: [] };
});
return [...entries, emptyRow()];
}
export function EnvVarEditor({
value,
secrets,
onCreateSecret,
onChange,
recentlyUsedSecrets,
}: {
value: Record<string, EnvBinding>;
secrets: CompanySecret[];
onCreateSecret: (name: string, value: string) => Promise<CompanySecret>;
onChange: (env: Record<string, EnvBinding> | undefined) => void;
/**
* Optional project-scoped secrets to surface as one-tap "quick bind" chips
* below the editor (§3.4). Already-bound secrets are filtered out.
*/
recentlyUsedSecrets?: CompanySecret[];
}) {
const [rows, setRows] = useState<Row[]>(() => toRows(value));
const [sealError, setSealError] = useState<string | null>(null);
const valueRef = useRef(value);
const emittingRef = useRef(false);
useEffect(() => {
if (emittingRef.current) {
emittingRef.current = false;
valueRef.current = value;
return;
}
if (value !== valueRef.current) {
valueRef.current = value;
setRows(toRows(value));
}
}, [value]);
function emit(nextRows: Row[]) {
const rec: Record<string, EnvBinding> = {};
for (const row of nextRows) {
const key = row.key.trim();
if (!key) continue;
if (row.source === "secret") {
if (row.secretId) {
const isDynamic =
secrets.find((s) => s.id === row.secretId)?.managedMode === "dynamic_command";
const argv = row.staticArgv.filter((arg) => arg.length > 0);
rec[key] = {
type: "secret_ref",
secretId: row.secretId,
version: row.version,
...(isDynamic && argv.length > 0 ? { staticArgv: argv } : {}),
};
} else {
rec[key] = { type: "plain", value: row.plainValue };
}
} else {
rec[key] = { type: "plain", value: row.plainValue };
}
}
emittingRef.current = true;
onChange(Object.keys(rec).length > 0 ? rec : undefined);
}
function updateRow(index: number, patch: Partial<Row>) {
const withPatch: Row[] = rows.map((row, rowIndex) =>
rowIndex === index ? { ...row, ...patch, version: patch.version ?? row.version } : row,
);
if (
withPatch[withPatch.length - 1].key ||
withPatch[withPatch.length - 1].plainValue ||
withPatch[withPatch.length - 1].secretId
) {
withPatch.push(emptyRow());
}
setRows(withPatch);
emit(withPatch);
}
function removeRow(index: number) {
const next = rows.filter((_, rowIndex) => rowIndex !== index);
if (
next.length === 0 ||
next[next.length - 1].key ||
next[next.length - 1].plainValue ||
next[next.length - 1].secretId
) {
next.push(emptyRow());
}
setRows(next);
emit(next);
}
function bindRecentSecret(secret: CompanySecret) {
// Fill the trailing empty row (or append one) with this secret bound.
const next = rows.map((row) => ({ ...row }));
const trailing = next[next.length - 1];
let target: Row;
if (trailing && !trailing.key && !trailing.plainValue && !trailing.secretId) {
target = trailing;
} else {
target = emptyRow();
next.push(target);
}
target.source = "secret";
target.secretId = secret.id;
target.version = "latest";
if (!target.key) target.key = envKeyFromSecretName(secret.name);
next.push(emptyRow());
setRows(next);
emit(next);
}
function defaultSecretName(key: string) {
return key
.trim()
.toLowerCase()
.replace(/[^a-z0-9_]+/g, "_")
.replace(/^_+|_+$/g, "")
.slice(0, 64);
}
async function sealRow(index: number) {
const row = rows[index];
if (!row) return;
const key = row.key.trim();
const plain = row.plainValue;
if (!key || plain.length === 0) return;
const suggested = defaultSecretName(key) || "secret";
const name = window.prompt("Secret name", suggested)?.trim();
if (!name) return;
try {
setSealError(null);
const created = await onCreateSecret(name, plain);
updateRow(index, { source: "secret", secretId: created.id });
} catch (error) {
setSealError(error instanceof Error ? error.message : "Failed to create secret");
}
}
return (
<div className="space-y-1.5">
{rows.map((row, index) => {
const isTrailing =
index === rows.length - 1 &&
!row.key &&
!row.plainValue &&
!row.secretId;
const boundSecret = row.secretId
? secrets.find((s) => s.id === row.secretId)
: undefined;
const isDynamicBinding =
row.source === "secret" && boundSecret?.managedMode === "dynamic_command";
return (
<div key={index} className="space-y-1">
<div className="flex items-center gap-1.5">
<input
className={cn(inputClass, "flex-[2]")}
placeholder="KEY"
value={row.key}
onChange={(event) => updateRow(index, { key: event.target.value })}
/>
<Select
value={row.source}
onValueChange={(next) =>
updateRow(index, {
source: next === "secret" ? "secret" : "plain",
...(next === "plain" ? { secretId: "" } : {}),
})
}
>
<SelectTrigger className={cn(selectTriggerClass, "flex-[1]")} aria-label="Binding mode">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectItem value="plain">Plain</SelectItem>
<SelectItem value="secret">Secret</SelectItem>
</SelectContent>
</Select>
{row.source === "secret" ? (
<>
<Select
value={row.secretId || SECRET_UNSET}
onValueChange={(next) =>
updateRow(index, { secretId: next === SECRET_UNSET ? "" : next })
}
>
<SelectTrigger
aria-label="Secret"
className={cn(
selectTriggerClass,
"flex-[3]",
row.secretId &&
!secrets.some((s) => s.id === row.secretId) &&
"border-destructive text-destructive",
)}
>
<SelectValue placeholder="Select secret..." />
</SelectTrigger>
<SelectContent>
{row.secretId && !secrets.some((s) => s.id === row.secretId) ? (
<SelectItem value={row.secretId}>
Missing ({row.secretId.slice(0, 8)}…)
</SelectItem>
) : null}
{secrets.map((secret) => (
<SelectItem key={secret.id} value={secret.id}>
{secret.name}
{secret.status !== "active" ? ` (${secret.status})` : ""}
</SelectItem>
))}
</SelectContent>
</Select>
<Select
value={row.version === "latest" ? "latest" : String(row.version)}
onValueChange={(raw) =>
updateRow(index, {
version: raw === "latest" ? "latest" : Number.parseInt(raw, 10),
})
}
disabled={!row.secretId}
>
<SelectTrigger className={cn(selectTriggerClass, "flex-[1]")} aria-label="Version">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectItem value="latest">latest</SelectItem>
{(() => {
const selected = secrets.find((s) => s.id === row.secretId);
if (!selected) return null;
return Array.from({ length: Math.max(0, selected.latestVersion) }, (_, idx) => {
const version = selected.latestVersion - idx;
if (version <= 0) return null;
return (
<SelectItem key={version} value={String(version)}>
v{version}
</SelectItem>
);
});
})()}
</SelectContent>
</Select>
<button
type="button"
className="inline-flex items-center rounded-md border border-border px-2 py-0.5 text-xs text-muted-foreground hover:bg-accent/50 transition-colors shrink-0"
onClick={() => sealRow(index)}
disabled={!row.key.trim() || !row.plainValue}
title="Create secret from current plain value"
>
New
</button>
</>
) : (
<>
<input
className={cn(inputClass, "flex-[3]")}
placeholder="value"
value={row.plainValue}
onChange={(event) => updateRow(index, { plainValue: event.target.value })}
/>
<button
type="button"
className="inline-flex items-center rounded-md border border-border px-2 py-0.5 text-xs text-muted-foreground hover:bg-accent/50 transition-colors shrink-0"
onClick={() => sealRow(index)}
disabled={!row.key.trim() || !row.plainValue}
title="Store value as secret and replace with reference"
>
Seal
</button>
</>
)}
{!isTrailing ? (
<button
type="button"
className="shrink-0 p-1 rounded hover:bg-destructive/10 text-muted-foreground hover:text-destructive transition-colors"
onClick={() => removeRow(index)}
>
<X className="h-3.5 w-3.5" />
</button>
) : (
<div className="w-[26px] shrink-0" />
)}
</div>
{isDynamicBinding ? (
<div className="ml-1 rounded-md border border-amber-500/30 bg-amber-500/5 px-2 py-1.5">
<label className="flex items-center gap-1 text-[11px] font-medium text-amber-700 dark:text-amber-300">
<KeyRound className="h-3 w-3" />
Static args for generator (operator-fixed, one per line)
</label>
<textarea
className={cn(inputClass, "mt-1 min-h-[44px] resize-y")}
placeholder={"--repo\nacme/widgets"}
value={row.staticArgv.join("\n")}
onChange={(event) =>
updateRow(index, {
staticArgv: event.target.value.split("\n"),
})
}
/>
<p className="mt-1 text-[10px] text-muted-foreground">
Passed verbatim to <span className="font-mono">{boundSecret?.name}</span> at injection.
Agents can never set or override these.
</p>
</div>
) : null}
</div>
);
})}
{(() => {
const boundIds = new Set(
rows.filter((row) => row.source === "secret" && row.secretId).map((row) => row.secretId),
);
const quick = (recentlyUsedSecrets ?? [])
.filter((secret) => secret.status === "active" && !boundIds.has(secret.id))
.slice(0, 8);
if (quick.length === 0) return null;
return (
<div className="flex flex-wrap items-center gap-1.5 pt-0.5">
<span className="inline-flex items-center gap-1 text-[11px] text-muted-foreground/70">
<KeyRound className="h-3 w-3" />
Recently used:
</span>
{quick.map((secret) => (
<button
key={secret.id}
type="button"
onClick={() => bindRecentSecret(secret)}
className="inline-flex items-center gap-1 rounded-full border border-border px-2 py-0.5 font-mono text-[11px] text-muted-foreground transition-colors hover:bg-accent/50 hover:text-foreground"
title={`Bind ${secret.name}`}
>
+ {secret.name}
</button>
))}
</div>
);
})()}
{sealError && <p className="text-[11px] text-destructive">{sealError}</p>}
{(() => {
const issues: { key: string; reason: string }[] = [];
for (const row of rows) {
if (row.source !== "secret" || !row.secretId) continue;
const secret = secrets.find((s) => s.id === row.secretId);
if (!secret) {
issues.push({ key: row.key.trim() || row.secretId, reason: "missing" });
} else if (secret.status !== "active") {
issues.push({ key: row.key.trim() || secret.name, reason: secret.status });
}
}
if (!issues.length) return null;
return (
<p className="text-[11px] text-amber-700 dark:text-amber-400 inline-flex items-start gap-1">
<AlertCircle className="h-3 w-3 mt-0.5 shrink-0" />
<span>
{issues.length} secret binding{issues.length === 1 ? "" : "s"} need attention:{" "}
{issues.map((issue, idx) => (
<span key={idx} className="font-mono">
{issue.key}
<span className="text-muted-foreground"> ({issue.reason})</span>
{idx < issues.length - 1 ? ", " : ""}
</span>
))}
. Runs will fail until you remap or re-enable.
</span>
</p>
);
})()}
<p className="text-[11px] text-muted-foreground/60">
Set KEY to the env var name the process expects, for example GH_TOKEN. Choose Secret to resolve a stored
value at run start. PAPERCLIP_* variables are injected automatically.
</p>
</div>
);
}