mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 08:22:20 +02:00
## Thinking Path > - Paperclip is the open source control plane for AI-agent companies. > - Operators can hide settings that their users must not change. > - The server shares the effective restrictions with the UI and settings API. > - An explicit list must change whenever a new experimental flag is added. > - This pull request adds a wildcard with named exceptions to the existing setting. > - Core applies the policy to its current catalog, so new flags stay hidden automatically. ## Linked Issues or Issue Description Related: #11823 introduced settings visibility. #13907 added workspace isolation visibility. I searched related PRs and issues and found no duplicate wildcard implementation. **What existing behavior does this improve?** Operator control of experimental setting visibility through `PAPERCLIP_HIDDEN_SETTINGS`. **Subsystem affected** Shared settings policy and its existing server health and mutation consumers. **Current behavior** Operators must name every hidden experimental toggle. A new Core flag can become visible until the operator updates that list. **Proposed behavior** `instance.experimental.*` hides current and future experimental toggles. Entries such as `!instance.experimental.enableEnvironments` leave named controls available. Explicit hidden keys and the hidden parent page take precedence over exceptions. **Reason and benefit** Operators can maintain a short list of allowed controls instead of a second copy of Core's full feature catalog. **Breaking changes** Existing explicit lists and unset configuration keep their behavior. The new syntax is opt-in. Older images ignore it, so operators must retain explicit restrictions until those images are upgraded. Visibility does not change feature values. ## What Changed - Expand the wildcard into concrete catalog keys in the shared parser. - Limit exceptions to known experimental controls and preserve explicit restrictions in either input order. - Test a synthetic future catalog addition, duplicate and invalid entries, API rejection, same-value echoes, and the effective health payload. - Document the syntax and the transition for deployments with mixed image versions. ## Verification - Targeted parser, future-catalog, health, and settings-route tests pass: 95 tests across four files. - `pnpm -r typecheck` passes, including Rust checks, with the installed Cargo directory on PATH. - `pnpm build` passes. - All current-head CI gates pass, including the full test shards, Rust, build, browser E2E, and canary dry run: https://github.com/paperclipai/paperclip/actions/runs/36083292578. One unchanged runtime-exposure cold-start test passed on its first retry. - The full local `pnpm test:run` did not pass on macOS/Node 25: the first server group reported 13,356 passed, 18 failed, and 99 skipped, with six failed files (including two failed suite setups). Failures were in unchanged runtime/company skill cache, chat/email connector fixtures, embedded-Postgres setup, and workspace cleanup tests. A standalone filesystem probe reproduced the read-only-directory rename permission failure. Missing connector fixture paths, database startup failures, and two integration assertions also occurred; the remaining local groups were not reached after this group failed. The corresponding CI lanes all pass. These local failures are not claimed as fixed by this PR. - Browser suites were not run because this changes the shared policy, not UI rendering or browser workflows. Health payload and route tests cover the shared UI/API contract. ## Risks A malformed exception remains hidden and is reported as unknown. Exceptions cannot override an explicit hidden toggle or parent page. Older images ignore wildcard syntax; keep their explicit list during a mixed-version rollout. No schema or feature-value changes are included. ## Model Used OpenAI GPT-6 through Codex, with reasoning, tool use, and code execution. The exact runtime variant and context-window size are not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
213 lines
7.6 KiB
TypeScript
213 lines
7.6 KiB
TypeScript
import { INSTANCE_FEATURE_KEYS, type InstanceFeatureKey } from "./feature-catalog.js";
|
|
|
|
/**
|
|
* Operator-configurable settings visibility.
|
|
*
|
|
* A hosting operator (a managed cloud, an internal shared server) can hide
|
|
* settings surfaces that do not apply to their deployment by setting the
|
|
* `PAPERCLIP_HIDDEN_SETTINGS` environment variable to a comma-separated
|
|
* list of keys from this registry. An experimental wildcard with named
|
|
* exceptions can also hide future controls automatically. Hiding a surface removes it from the UI
|
|
* (nav, routes, page sections). Surfaces backed by instance-level mutation
|
|
* routes are also floored with a 403 carrying
|
|
* `SETTINGS_OPERATOR_MANAGED_ERROR_CODE`: the Access, Plugins, and Adapters
|
|
* pages, every field-backed General section, every experimental toggle
|
|
* (individually or via the whole Experimental page), and the company Import
|
|
* page (whose whole route surface is floored). The other company pages are
|
|
* UI-visibility keys only: their APIs (memberships, invites, secrets,
|
|
* exports) stay live for agents and integrations.
|
|
*
|
|
* Nothing is hidden by default: with the variable unset, UI and API behave
|
|
* exactly as before this mechanism existed.
|
|
*
|
|
* Unknown keys are ignored (with a server-side warning) rather than rejected,
|
|
* so an operator may roll one list across a fleet of mixed app versions: an
|
|
* image that predates a key simply keeps that surface visible instead of
|
|
* refusing to boot.
|
|
*/
|
|
|
|
/**
|
|
* Instance settings pages that can be hidden (nav entry + route). The General
|
|
* page is deliberately not hideable: it is the settings root and the redirect
|
|
* target for hidden pages. Individual General sections are hideable below.
|
|
*/
|
|
export const HIDEABLE_INSTANCE_PAGES = [
|
|
"instance.profile",
|
|
"instance.environments",
|
|
"instance.access",
|
|
"instance.experimental",
|
|
"instance.plugins",
|
|
"instance.adapters",
|
|
] as const;
|
|
|
|
export type HideableInstancePage = (typeof HIDEABLE_INSTANCE_PAGES)[number];
|
|
|
|
/**
|
|
* Company-level settings pages that can be hidden (nav entry + tab + route).
|
|
* The company General page is deliberately not hideable: it is the settings
|
|
* root and the redirect target for hidden pages. `company.import` also floors
|
|
* the import API routes; the rest only hide UI surfaces.
|
|
*/
|
|
export const HIDEABLE_COMPANY_PAGES = [
|
|
"company.members",
|
|
"company.invites",
|
|
"company.secrets",
|
|
"company.export",
|
|
"company.import",
|
|
] as const;
|
|
|
|
export type HideableCompanyPage = (typeof HIDEABLE_COMPANY_PAGES)[number];
|
|
|
|
/**
|
|
* Sub-surfaces of company settings pages that can be hidden individually.
|
|
* UI-visibility keys only: the backing APIs stay live for agents and
|
|
* integrations. Hiding the whole page (`company.secrets`) already removes
|
|
* everything inside it; these keys hide one tab while the page stays up.
|
|
*/
|
|
export const HIDEABLE_COMPANY_SECTIONS = [
|
|
"company.secrets.vaults",
|
|
"company.secrets.proposals",
|
|
] as const;
|
|
|
|
export type HideableCompanySection = (typeof HIDEABLE_COMPANY_SECTIONS)[number];
|
|
|
|
/**
|
|
* Sections of Instance → General that can be hidden. Field-backed sections
|
|
* (their suffix names a general-settings field) also floor writes to that
|
|
* field; `deploymentStatus` and `signOut` are read-only UI with no field.
|
|
*/
|
|
export const HIDEABLE_GENERAL_SECTIONS = [
|
|
"instance.general.deploymentStatus",
|
|
"instance.general.censorUsernameInLogs",
|
|
"instance.general.keyboardShortcuts",
|
|
"instance.general.backupRetention",
|
|
"instance.general.feedbackDataSharingPreference",
|
|
"instance.general.signOut",
|
|
] as const;
|
|
|
|
export type HideableGeneralSection = (typeof HIDEABLE_GENERAL_SECTIONS)[number];
|
|
|
|
/** General sections that are informational UI only, with no settings field. */
|
|
export const UI_ONLY_GENERAL_SECTIONS = [
|
|
"instance.general.deploymentStatus",
|
|
"instance.general.signOut",
|
|
] as const satisfies readonly HideableGeneralSection[];
|
|
|
|
export type HideableExperimentalSetting = `instance.experimental.${InstanceFeatureKey}`;
|
|
|
|
/** The visibility key for an experimental toggle; every boolean flag is hideable. */
|
|
export function experimentalSettingKey(key: InstanceFeatureKey): HideableExperimentalSetting {
|
|
return `instance.experimental.${key}`;
|
|
}
|
|
|
|
/** Workspace policy editors and selectors. UI-only; execution and APIs stay active. */
|
|
export const HIDEABLE_WORKSPACE_SECTIONS = ["workspaces.isolation"] as const;
|
|
export type HideableWorkspaceSection = (typeof HIDEABLE_WORKSPACE_SECTIONS)[number];
|
|
|
|
export type HideableSettingKey =
|
|
| HideableWorkspaceSection
|
|
| HideableInstancePage
|
|
| HideableCompanyPage
|
|
| HideableCompanySection
|
|
| HideableGeneralSection
|
|
| HideableExperimentalSetting;
|
|
|
|
/** Concrete setting keys; the parser also accepts the experimental wildcard and exceptions. */
|
|
export const HIDEABLE_SETTING_KEYS: readonly HideableSettingKey[] = [
|
|
...HIDEABLE_WORKSPACE_SECTIONS,
|
|
...HIDEABLE_INSTANCE_PAGES,
|
|
...HIDEABLE_COMPANY_PAGES,
|
|
...HIDEABLE_COMPANY_SECTIONS,
|
|
...HIDEABLE_GENERAL_SECTIONS,
|
|
...INSTANCE_FEATURE_KEYS.map(experimentalSettingKey),
|
|
];
|
|
|
|
/** Stable 403 code for writes to operator-hidden settings. */
|
|
export const SETTINGS_OPERATOR_MANAGED_ERROR_CODE = "settings_operator_managed";
|
|
|
|
/** Hide current and future experimental controls, with optional !key exceptions. */
|
|
export const EXPERIMENTAL_SETTINGS_WILDCARD = "instance.experimental.*";
|
|
|
|
export interface ParsedHiddenSettings {
|
|
/** Concrete keys, deduplicated; wildcard-derived keys follow in catalog order. */
|
|
hidden: HideableSettingKey[];
|
|
/** Unrecognized entries, for the caller to warn about. */
|
|
unknown: string[];
|
|
}
|
|
|
|
/**
|
|
* Parse operator settings into concrete keys for both the UI and API.
|
|
* `instance.experimental.*` hides every catalog control except entries such as
|
|
* `!instance.experimental.enableEnvironments`. Exceptions only affect the
|
|
* wildcard; an explicit hidden key or hidden parent page always wins.
|
|
*/
|
|
export function parseHiddenSettingsList(raw: string | undefined): ParsedHiddenSettings {
|
|
const hidden: HideableSettingKey[] = [];
|
|
const unknown: string[] = [];
|
|
if (!raw) return { hidden, unknown };
|
|
const known = new Set<string>(HIDEABLE_SETTING_KEYS);
|
|
const seen = new Set<string>();
|
|
const exceptions = new Set<string>();
|
|
let hideExperimental = false;
|
|
for (const part of raw.split(",")) {
|
|
const key = part.trim();
|
|
if (!key || seen.has(key)) continue;
|
|
seen.add(key);
|
|
if (key === EXPERIMENTAL_SETTINGS_WILDCARD) {
|
|
hideExperimental = true;
|
|
} else if (key.startsWith("!instance.experimental.") && known.has(key.slice(1))) {
|
|
exceptions.add(key.slice(1));
|
|
} else if (known.has(key)) {
|
|
hidden.push(key as HideableSettingKey);
|
|
} else {
|
|
unknown.push(key);
|
|
}
|
|
}
|
|
if (hideExperimental) {
|
|
for (const feature of INSTANCE_FEATURE_KEYS) {
|
|
const key = experimentalSettingKey(feature);
|
|
if (!exceptions.has(key) && !seen.has(key)) hidden.push(key);
|
|
}
|
|
}
|
|
return { hidden, unknown };
|
|
}
|
|
|
|
export function hidesInstancePage(
|
|
hidden: ReadonlySet<string>,
|
|
page: HideableInstancePage,
|
|
): boolean {
|
|
return hidden.has(page);
|
|
}
|
|
|
|
export function hidesCompanyPage(
|
|
hidden: ReadonlySet<string>,
|
|
page: HideableCompanyPage,
|
|
): boolean {
|
|
return hidden.has(page);
|
|
}
|
|
|
|
export function hidesCompanySection(
|
|
hidden: ReadonlySet<string>,
|
|
section: HideableCompanySection,
|
|
): boolean {
|
|
return hidden.has(section);
|
|
}
|
|
|
|
export function hidesGeneralSection(
|
|
hidden: ReadonlySet<string>,
|
|
section: HideableGeneralSection,
|
|
): boolean {
|
|
return hidden.has(section);
|
|
}
|
|
|
|
/**
|
|
* Whether a toggle is hidden, either individually or because the whole
|
|
* Experimental page is hidden.
|
|
*/
|
|
export function hidesExperimentalSetting(
|
|
hidden: ReadonlySet<string>,
|
|
key: InstanceFeatureKey,
|
|
): boolean {
|
|
return hidden.has("instance.experimental") || hidden.has(experimentalSettingKey(key));
|
|
}
|