mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-14 08:26:46 +02:00
Devin FoleyandPaperclip
600e552d7b
Attribute optional server and browser Sentry events to their source build. Use validated build commits for Docker and source/npm artifacts, preserve explicit server release overrides, and keep cached browser bundles tied to the commit they loaded. Verify 127 focused tests, server/UI typechecks, Docker and source build stamps, all 53 CI checks, and Greptile 5/5 with no unresolved comments. Co-Authored-By: Paperclip <noreply@paperclip.ing>
45 lines
2.0 KiB
TypeScript
45 lines
2.0 KiB
TypeScript
import { readFileSync } from "node:fs";
|
|
import { fileURLToPath } from "node:url";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import { resolveBrowserBuildCommit } from "./vite-build-commit";
|
|
|
|
describe("browser build attribution", () => {
|
|
const commit = "0123456789abcdef0123456789abcdef01234567";
|
|
|
|
it("uses the checkout commit for source and npm builds", () => {
|
|
expect(resolveBrowserBuildCommit(undefined, () => commit)).toBe(commit);
|
|
});
|
|
|
|
it("uses a supplied commit without requiring git in Docker", () => {
|
|
const readGitCommit = vi.fn(() => "ffffffffffffffffffffffffffffffffffffffff");
|
|
expect(resolveBrowserBuildCommit(commit, readGitCommit)).toBe(commit);
|
|
expect(readGitCommit).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("leaves builds without git or a supplied commit unattributed", () => {
|
|
expect(resolveBrowserBuildCommit(undefined, () => { throw new Error("no git"); })).toBeNull();
|
|
expect(resolveBrowserBuildCommit(undefined, () => "not-a-commit")).toBeNull();
|
|
});
|
|
|
|
it("accepts and normalizes the full source commit supplied by image CI", () => {
|
|
expect(resolveBrowserBuildCommit(" 0123456789ABCDEF0123456789ABCDEF01234567\n"))
|
|
.toBe("0123456789abcdef0123456789abcdef01234567");
|
|
});
|
|
|
|
it.each([undefined, "", "main", "0123456", "https://example.invalid/private-build?token=canary"])(
|
|
"omits an unknown or non-commit value: %s", (value) => {
|
|
expect(resolveBrowserBuildCommit(value)).toBeNull();
|
|
},
|
|
);
|
|
|
|
it("makes the Docker build commit available before building the browser", () => {
|
|
const dockerfile = readFileSync(fileURLToPath(new URL("../../../Dockerfile", import.meta.url)), "utf8");
|
|
const stage = dockerfile.split("FROM runner-build AS build")[1]?.split("FROM base AS production")[0];
|
|
expect(stage).toBeDefined();
|
|
const arg = stage!.indexOf('ARG PAPERCLIP_BUILD_COMMIT=""');
|
|
const browserBuild = stage!.indexOf("RUN pnpm --filter @paperclipai/ui build");
|
|
expect(arg).toBeGreaterThanOrEqual(0);
|
|
expect(browserBuild).toBeGreaterThan(arg);
|
|
});
|
|
});
|