mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-11 14:10:50 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - An instance can turn on the `enableManagedSandboxOnly` feature, which hides the local environment and runs every agent in the platform-managed environment > - That feature already gated the environment pickers, the onboarding wizard, and the server-side run selection, but many other screens still showed absolute paths on the execution host and still let the user pick an execution engine > - On such an instance those controls name a filesystem the user cannot reach; a path written there is stored and then ignored, which reads as a broken control > - This pull request hides the remaining host-path and execution-engine surfaces behind the same feature, adds a server rule that refuses a project-workspace path write while the feature is on, and closes a related route gap in the isolated-workspace pages > - The benefit is that a managed instance shows no host path and no folder picker anywhere, and a write that carries a path now fails with a clear message instead of being silently discarded ## Linked Issues or Issue Description No public issue exists. The description below follows `.github/ISSUE_TEMPLATE/enhancement.yml`. **What existing behavior does this improve?** The `enableManagedSandboxOnly` instance feature, and the UI surfaces that show a host filesystem path: project properties, the new-project dialog, the project workspace and execution workspace detail pages, the workspace and task cards, plugin local folders, and the agent configuration form with its per-adapter fields. It also improves route gating for `enableIsolatedWorkspaces`. **Subsystem affected** Cross-cutting (`ui/` and `server/`). **Current behavior** When `enableManagedSandboxOnly` is on, the local environment disappears from the environment pickers and the server refuses to run an agent on the local host. Everything else stays visible. A user still sees: - the project "Local folder" row, its absolute path, and the Set/Change/Clear buttons - the "Local folder" field and its "Choose" folder picker in the new-project dialog - the "Local path" field and fact row on a project workspace - the "Paths" and "Lifecycle commands" groups on an execution workspace - the working directory on workspace cards, task properties, and runtime service rows - the plugin "Local folders" section - "Working directory (deprecated)", "Command", "Execution engine", "ACP server command", "ACP state directory", and "Agent instructions file" in the agent configuration form A path typed into any of these names a filesystem no agent on the instance uses. The project workspace API also accepts a `cwd` write and stores it. Separately, `/workspaces`, `/execution-workspaces/*`, and `/projects/:projectId/workspaces/:workspaceId` render for anyone who types or bookmarks the URL, even with `enableIsolatedWorkspaces` off. Only the sidebar entry reads that flag. **Proposed behavior** With `enableManagedSandboxOnly` on, none of those surfaces render. A project whose codebase came from a managed checkout keeps its one-line "Paperclip-managed folder." label and shows no path. The non-path controls stay: repo URL, branch, service URL, port, command output, ACP session mode, ACP non-interactive permissions, Codex fast mode, and the sandbox toggles. The project-workspace create and patch routes, and the nested workspace on project create, answer `422` with "This instance runs agents only in the platform-managed environment; local folders are not configurable." when the payload carries a non-null `cwd`. A `cwd: null` write still passes, so an instance that just turned the feature on can clear a stale path. With `enableIsolatedWorkspaces` off, the three workspace route groups redirect to the dashboard. **Reason and benefit** A control that cannot do anything is worse than a missing control: the user fills it in, saves, and gets no error and no effect. The server rule turns that silent no-op into a clear refusal. The route gate stops a feature that an instance has turned off from staying reachable by URL, which is the same standard the Cases, Pipelines, and hidden-settings pages already meet. **Breaking changes** None for a default instance: both flags are off by default for self-hosted and managed instances, so nothing changes unless an operator turns them on. Stored `adapterConfig` values are never cleared, so turning the feature off restores every previous value. ## What Changed - Add `ui/src/hooks/useManagedSandboxOnly.ts`, modelled on `useAppsEnabled`, for components that do not already read the experimental settings. It exposes `hideHostPaths`, which fails closed while the settings query is in flight, so a cold cache never flashes a host path before the policy resolves. Components that keep their own settings read compute the same gate from `isFetched`. - Add `managedSandboxOnly` to `AdapterConfigFieldsProps` and populate it where `AgentConfigForm` builds the adapter field props. Resolve the effective instructions-file gate once as `hideInstructionsFile || hideHostPaths`, so every adapter hides that path field with no per-adapter edit. - Hide under the flag: the project "Local folder" block and its absolute-path edit panel (a managed checkout keeps its label, without the path); the new-project "Local folder" field; the project-workspace "Local path" field and fact row; the execution-workspace "Paths" and "Lifecycle commands" groups; the working directory on the workspace summary card, the task workspace card, the task properties "Folder" row, and the runtime service rows; the plugin "Local folders" section; "Working directory (deprecated)" and "Command" in the agent form; and the per-adapter "Execution engine", "ACP server command", and "ACP state directory" for `claude_local`, `codex_local`, and `gemini_local`. - Drop two working-directory fallbacks that had no gate to read: the close-workspace dialog now falls back to "No additional details", and the reuse-existing workspace label and picker subtitle fall back to a neutral phrase. - Refuse a non-null `cwd` with `422` on `POST /projects/:id/workspaces`, `PATCH /projects/:id/workspaces/:workspaceId`, and the nested workspace on `POST /companies/:companyId/projects`, following the `assertNoAgentHostWorkspaceCommandMutation` precedent on those routes. - Add `IsolatedWorkspacesRouteGate` and wrap the `/workspaces`, `/execution-workspaces/*`, and `/projects/:projectId/workspaces/:workspaceId` routes with it. - Leave the SSH "Remote workspace path" and the workspace file browser alone, with a comment explaining why. ## Verification Automated: - `pnpm --filter @paperclipai/ui exec vitest run` — 479 of 480 files pass (4455 of 4456 tests). The one failure is `OnboardingWizard.test.tsx > renders instead of throwing when the browser denies storage access`, which also fails on `origin/master` and is unrelated to this change. - `pnpm --filter @paperclipai/server exec vitest run project workspace instance-settings` — 45 of 50 files pass. Four files fail on macOS for reasons unrelated to this change: `workspace-instance-cleanup`, `workspace-runtime`, `execution-workspace-runtime-control-conflict`, and `workspace-runtime-exposure` compare `/var/...` against the resolved `/private/var/...` or bind real ports. The same files fail on a clean `master` checkout on the same machine. - `pnpm --filter @paperclipai/ui typecheck` - `tsc --noEmit` in `server/` (after `pnpm --filter @paperclipai/plugin-sdk ensure-build-deps`). The package `typecheck` script also builds the Rust runner, which needs `cargo`; it is not installed on the machine that ran this. New and extended tests: - `ui/src/adapters/managed-sandbox-only-config-fields.test.tsx` — the three adapters drop the execution engine, the ACP paths, the instructions-file path, and every "Choose" button when the flag is on, and keep the non-path controls. - `ui/src/components/AgentConfigForm.render.test.tsx` — flag-on and flag-off renders for the working directory, the command, the engine, the ACP paths, and the resolved adapter field props. - `ui/src/components/ProjectProperties.managed-sandbox.test.tsx`, `ui/src/components/NewProjectDialog.managed-sandbox.test.tsx`, `ui/src/pages/ProjectWorkspaceDetail.test.tsx`, `ui/src/components/ProjectWorkspaceSummaryCard.test.tsx`, `ui/src/components/WorkspaceRuntimeControls.test.tsx`. - `ui/src/components/IsolatedWorkspacesRouteGate.test.tsx` — redirect when off, render when on, and render nothing while the flag query is in flight. - "Still loading" cases for the project properties, the new-project dialog, the workspace summary card, the runtime service rows, and the agent configuration form, each asserting that no host path renders before the policy resolves. - `server/src/__tests__/project-workspace-managed-sandbox-routes.test.ts` — the `422` on all three write paths, the `cwd: null` pass-through, and the flag-off pass-through. Manual check to reproduce: turn on Managed Environment Only in instance experimental settings, then open a project, the new-project dialog, an agent's configuration, and a workspace page. No path, folder icon, or "Choose" button appears. Turn the setting off and each control returns with its stored value. No documentation change was needed. The operator-facing text for both settings lives in the feature catalog entry, which already states the contract this pull request now enforces across the UI. ## Risks - Low. Both flags default to off, so a default instance is unchanged. - The hidden fields are presentation only. No stored `adapterConfig` value is cleared, because an import carries adapter configuration written on another instance and clearing it would break that flow. Turning the setting off shows every previous value again. - The `422` is the one behavior change for an API caller, and only while the setting is on. `cwd: null` still passes so a stale path can be cleared. - The route gate renders nothing until the flag query settles, so an instance with isolated workspaces on never flashes a redirect. An instance with the feature off now redirects a bookmarked workspace URL to the dashboard. - Every host-path guard fails closed while the settings query is in flight, so a default instance shows those controls a moment later than before on a cold load. That is the safe direction: the alternative flashes a path a managed instance must never show. - Two path surfaces stay on purpose, each with a comment: the SSH "Remote workspace path" is a path on the user's own remote host, and the workspace file browser shows workspace-relative paths. The instance Adapters page also keeps its "Local path" install option, since that page is an instance-admin surface the hosting operator can already hide through the hidden-settings mechanism. ## Model Used Claude (Anthropic), Claude Opus, 1M context window, extended thinking, agentic tool use through Claude Code. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
427 lines
16 KiB
TypeScript
427 lines
16 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import type { ComponentProps, ReactNode } from "react";
|
|
import { flushSync } from "react-dom";
|
|
import { createRoot } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import type { ExecutionWorkspace, Issue } from "@paperclipai/shared";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import type { ProjectWorkspaceSummary } from "../lib/project-workspaces-tab";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
import { ProjectWorkspaceSummaryCard } from "./ProjectWorkspaceSummaryCard";
|
|
|
|
const mockInstanceSettingsApi = vi.hoisted(() => ({
|
|
getExperimental: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("@/api/instanceSettings", () => ({
|
|
instanceSettingsApi: mockInstanceSettingsApi,
|
|
}));
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({ children, to, ...props }: ComponentProps<"a"> & { to: string }) => <a href={to} {...props}>{children}</a>,
|
|
}));
|
|
|
|
vi.mock("./IssuesQuicklook", () => ({
|
|
IssuesQuicklook: ({ children }: { children: ReactNode }) => <>{children}</>,
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
/**
|
|
* The card reads the managed-sandbox-only policy through the shared
|
|
* instance-settings query, so every render needs a query client. Renders here
|
|
* are synchronous and the path guard fails closed until the policy resolves, so
|
|
* the cache is primed by default. Pass `null` to leave the policy unresolved.
|
|
*/
|
|
function withQueryClient(node: ReactNode, experimentalSettings: Record<string, unknown> | null = {}) {
|
|
const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
if (experimentalSettings) {
|
|
queryClient.setQueryData(queryKeys.instance.experimentalSettings, experimentalSettings);
|
|
}
|
|
return <QueryClientProvider client={queryClient}>{node}</QueryClientProvider>;
|
|
}
|
|
|
|
function act(callback: () => void | Promise<void>) {
|
|
let result: void | Promise<void> = undefined;
|
|
flushSync(() => {
|
|
result = callback();
|
|
});
|
|
const maybePromise = result as Promise<void> | undefined;
|
|
if (maybePromise !== undefined && typeof maybePromise.then === "function") {
|
|
return maybePromise.then(() => {
|
|
flushSync(() => {});
|
|
});
|
|
}
|
|
return result;
|
|
}
|
|
|
|
function createIssue(overrides: Partial<Issue> = {}): Issue {
|
|
return {
|
|
id: overrides.id ?? "issue-1",
|
|
companyId: overrides.companyId ?? "company-1",
|
|
projectId: overrides.projectId ?? "project-1",
|
|
projectWorkspaceId: overrides.projectWorkspaceId ?? null,
|
|
goalId: overrides.goalId ?? null,
|
|
parentId: overrides.parentId ?? null,
|
|
title: overrides.title ?? "Issue",
|
|
description: overrides.description ?? null,
|
|
status: overrides.status ?? "todo",
|
|
priority: overrides.priority ?? "medium",
|
|
assigneeAgentId: overrides.assigneeAgentId ?? null,
|
|
assigneeUserId: overrides.assigneeUserId ?? null,
|
|
checkoutRunId: overrides.checkoutRunId ?? null,
|
|
executionRunId: overrides.executionRunId ?? null,
|
|
executionAgentNameKey: overrides.executionAgentNameKey ?? null,
|
|
executionLockedAt: overrides.executionLockedAt ?? null,
|
|
createdByAgentId: overrides.createdByAgentId ?? null,
|
|
createdByUserId: overrides.createdByUserId ?? null,
|
|
issueNumber: overrides.issueNumber ?? 1,
|
|
identifier: overrides.identifier ?? "PAP-1",
|
|
requestDepth: overrides.requestDepth ?? 0,
|
|
billingCode: overrides.billingCode ?? null,
|
|
assigneeAdapterOverrides: overrides.assigneeAdapterOverrides ?? null,
|
|
executionWorkspaceId: overrides.executionWorkspaceId ?? null,
|
|
executionWorkspacePreference: overrides.executionWorkspacePreference ?? null,
|
|
executionWorkspaceSettings: overrides.executionWorkspaceSettings ?? null,
|
|
startedAt: overrides.startedAt ?? null,
|
|
completedAt: overrides.completedAt ?? null,
|
|
cancelledAt: overrides.cancelledAt ?? null,
|
|
hiddenAt: overrides.hiddenAt ?? null,
|
|
createdAt: overrides.createdAt ?? new Date("2026-04-12T00:00:00Z"),
|
|
updatedAt: overrides.updatedAt ?? new Date("2026-04-12T00:00:00Z"),
|
|
} as Issue;
|
|
}
|
|
|
|
function createSummary(overrides: Partial<ProjectWorkspaceSummary> = {}): ProjectWorkspaceSummary {
|
|
const issues = overrides.issues ?? [
|
|
createIssue({ id: "issue-1", identifier: "PAP-1364" }),
|
|
createIssue({ id: "issue-2", identifier: "PAP-1367" }),
|
|
createIssue({ id: "issue-3", identifier: "PAP-1362" }),
|
|
createIssue({ id: "issue-4", identifier: "PAP-1363" }),
|
|
createIssue({ id: "issue-5", identifier: "PAP-1340" }),
|
|
];
|
|
return {
|
|
key: overrides.key ?? "execution:workspace-1",
|
|
kind: overrides.kind ?? "execution_workspace",
|
|
workspaceId: overrides.workspaceId ?? "workspace-1",
|
|
workspaceName: overrides.workspaceName ?? "PAP-989-multi-user-implementation",
|
|
cwd: overrides.cwd ?? "/worktrees/PAP-989-multi-user-implementation",
|
|
branchName: overrides.branchName ?? "PAP-989-multi-user-implementation",
|
|
lastUpdatedAt: overrides.lastUpdatedAt ?? new Date("2026-04-12T00:00:00Z"),
|
|
projectWorkspaceId: overrides.projectWorkspaceId ?? "project-workspace-1",
|
|
executionWorkspaceId: overrides.executionWorkspaceId ?? "workspace-1",
|
|
executionWorkspaceStatus: overrides.executionWorkspaceStatus ?? "active",
|
|
serviceCount: overrides.serviceCount ?? 2,
|
|
runningServiceCount: overrides.runningServiceCount ?? 0,
|
|
primaryServiceUrl: overrides.primaryServiceUrl ?? "http://127.0.0.1:62474",
|
|
primaryServiceUrlRunning: overrides.primaryServiceUrlRunning ?? false,
|
|
hasRuntimeConfig: overrides.hasRuntimeConfig ?? true,
|
|
linkedIssueCount: overrides.linkedIssueCount ?? issues.length,
|
|
issues,
|
|
};
|
|
}
|
|
|
|
describe("ProjectWorkspaceSummaryCard", () => {
|
|
let container: HTMLDivElement;
|
|
let writeClipboard: ReturnType<typeof vi.fn>;
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
writeClipboard = vi.fn().mockResolvedValue(undefined);
|
|
Object.defineProperty(navigator, "clipboard", {
|
|
configurable: true,
|
|
value: { writeText: writeClipboard },
|
|
});
|
|
Object.defineProperty(window, "isSecureContext", {
|
|
configurable: true,
|
|
value: true,
|
|
});
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({});
|
|
});
|
|
|
|
afterEach(() => {
|
|
document.body.innerHTML = "";
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("keeps the path row hidden while the policy is still loading", () => {
|
|
// A cold cache resolves the policy to false on the first render. The guard
|
|
// fails closed so a managed instance never flashes the execution-host path.
|
|
const root = createRoot(container);
|
|
act(() => {
|
|
root.render(withQueryClient(
|
|
<ProjectWorkspaceSummaryCard
|
|
projectRef="paperclip-app"
|
|
summary={createSummary()}
|
|
runtimeActionKey={null}
|
|
runtimeActionPending={false}
|
|
onRuntimeAction={() => {}}
|
|
onCloseWorkspace={() => {}}
|
|
/>,
|
|
null,
|
|
));
|
|
});
|
|
|
|
expect(container.textContent).not.toContain("Path");
|
|
expect(container.textContent).toContain("Branch");
|
|
|
|
act(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("keeps the path row hidden when the policy read fails", async () => {
|
|
// A failed settings read leaves the policy unknown, and an unknown policy
|
|
// must not be read as "not managed". React Query reports such a query as
|
|
// fetched with no data, so a guard keyed on "fetched" would show the
|
|
// execution-host path on exactly the managed instance whose settings
|
|
// endpoint is unreachable.
|
|
mockInstanceSettingsApi.getExperimental.mockRejectedValue(new Error("settings unavailable"));
|
|
const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
const root = createRoot(container);
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<ProjectWorkspaceSummaryCard
|
|
projectRef="paperclip-app"
|
|
summary={createSummary()}
|
|
runtimeActionKey={null}
|
|
runtimeActionPending={false}
|
|
onRuntimeAction={() => {}}
|
|
onCloseWorkspace={() => {}}
|
|
/>
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
|
|
// Drive the rejected query all the way to a settled failure, so the
|
|
// assertion below covers the resolved-error case and not merely the
|
|
// in-flight one the loading test already covers.
|
|
for (let attempt = 0; attempt < 50; attempt += 1) {
|
|
if (queryClient.getQueryState(queryKeys.instance.experimentalSettings)?.status === "error") break;
|
|
await act(async () => {
|
|
await new Promise((resolve) => setTimeout(resolve, 10));
|
|
});
|
|
}
|
|
expect(queryClient.getQueryState(queryKeys.instance.experimentalSettings)?.status).toBe("error");
|
|
|
|
expect(container.textContent).not.toContain("Path");
|
|
expect(container.textContent).toContain("Branch");
|
|
|
|
act(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("drops the path row when the instance runs agents only in the platform-managed environment", () => {
|
|
const root = createRoot(container);
|
|
act(() => {
|
|
root.render(withQueryClient(
|
|
<ProjectWorkspaceSummaryCard
|
|
projectRef="paperclip-app"
|
|
summary={createSummary()}
|
|
runtimeActionKey={null}
|
|
runtimeActionPending={false}
|
|
onRuntimeAction={() => {}}
|
|
onCloseWorkspace={() => {}}
|
|
/>,
|
|
{ enableManagedSandboxOnly: true },
|
|
));
|
|
});
|
|
|
|
expect(container.textContent).not.toContain("Path");
|
|
// Branch, service, and linked-task rows describe the workspace, not the host.
|
|
expect(container.textContent).toContain("Branch");
|
|
expect(container.textContent).toContain("Service");
|
|
expect(container.textContent).toContain("Linked tasks");
|
|
|
|
act(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("renders a stacked mobile-friendly summary with metadata labels and compact issue pills", () => {
|
|
const root = createRoot(container);
|
|
act(() => {
|
|
root.render(withQueryClient(
|
|
<ProjectWorkspaceSummaryCard
|
|
projectRef="paperclip-app"
|
|
summary={createSummary()}
|
|
runtimeActionKey={null}
|
|
runtimeActionPending={false}
|
|
onRuntimeAction={() => {}}
|
|
onCloseWorkspace={() => {}}
|
|
/>,
|
|
));
|
|
});
|
|
|
|
expect(container.textContent).toContain("Execution workspace");
|
|
expect(container.textContent).toContain("Branch");
|
|
expect(container.textContent).toContain("Path");
|
|
expect(container.textContent).toContain("Service");
|
|
expect(container.textContent).toContain("Linked tasks");
|
|
expect(container.textContent).toContain("Start services");
|
|
expect(container.textContent).toContain("Close workspace");
|
|
expect(container.textContent).toContain("+1 more");
|
|
|
|
const actions = container.querySelector('[data-testid="workspace-summary-actions"]');
|
|
expect(actions?.className).toContain("flex-col");
|
|
const card = container.firstElementChild;
|
|
expect(card?.className).toContain("rounded-lg");
|
|
expect(card?.className).toContain("border");
|
|
|
|
act(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("uses project workspace routes and omits close controls for project workspaces", () => {
|
|
const runtimeSpy = vi.fn();
|
|
const closeSpy = vi.fn();
|
|
const root = createRoot(container);
|
|
|
|
act(() => {
|
|
root.render(withQueryClient(
|
|
<ProjectWorkspaceSummaryCard
|
|
projectRef="paperclip-app"
|
|
summary={createSummary({
|
|
key: "project:workspace-2",
|
|
kind: "project_workspace",
|
|
executionWorkspaceId: null,
|
|
executionWorkspaceStatus: null,
|
|
hasRuntimeConfig: false,
|
|
issues: [createIssue({ id: "issue-6", identifier: "PAP-1400" })],
|
|
})}
|
|
runtimeActionKey={null}
|
|
runtimeActionPending={false}
|
|
onRuntimeAction={runtimeSpy}
|
|
onCloseWorkspace={closeSpy}
|
|
/>,
|
|
));
|
|
});
|
|
|
|
const titleLink = container.querySelector("a[href='/projects/paperclip-app/workspaces/workspace-1']");
|
|
expect(titleLink).not.toBeNull();
|
|
expect(container.textContent).not.toContain("Close workspace");
|
|
expect(container.textContent).not.toContain("Start services");
|
|
|
|
act(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("shows retry close for cleanup failures", () => {
|
|
const root = createRoot(container);
|
|
|
|
act(() => {
|
|
root.render(withQueryClient(
|
|
<ProjectWorkspaceSummaryCard
|
|
projectRef="paperclip-app"
|
|
summary={createSummary({
|
|
executionWorkspaceStatus: "cleanup_failed" as ExecutionWorkspace["status"],
|
|
})}
|
|
runtimeActionKey={null}
|
|
runtimeActionPending={false}
|
|
onRuntimeAction={() => {}}
|
|
onCloseWorkspace={() => {}}
|
|
/>,
|
|
));
|
|
});
|
|
|
|
expect(container.textContent).toContain("Retry close");
|
|
|
|
act(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("copies branch and path from both text and icon controls with feedback", async () => {
|
|
const root = createRoot(container);
|
|
const summary = createSummary({
|
|
branchName: "PAP-1552-workspace-polish",
|
|
cwd: "/Users/dotta/paperclip/.worktrees/PAP-1552-workspace-polish",
|
|
});
|
|
|
|
await act(async () => {
|
|
root.render(withQueryClient(
|
|
<ProjectWorkspaceSummaryCard
|
|
projectRef="paperclip-app"
|
|
summary={summary}
|
|
runtimeActionKey={null}
|
|
runtimeActionPending={false}
|
|
onRuntimeAction={() => {}}
|
|
onCloseWorkspace={() => {}}
|
|
/>,
|
|
));
|
|
});
|
|
|
|
const branchTextButton = Array.from(container.querySelectorAll("button"))
|
|
.find((button) => button.textContent === summary.branchName);
|
|
const pathTextButton = container.querySelector(`button[title="${summary.cwd}"]`);
|
|
const branchIconButton = container.querySelector('button[aria-label="Copy branch"]');
|
|
const pathIconButton = container.querySelector('button[aria-label="Copy path"]');
|
|
|
|
expect(branchTextButton).not.toBeNull();
|
|
expect(pathTextButton).not.toBeNull();
|
|
expect(branchIconButton).not.toBeNull();
|
|
expect(pathIconButton).not.toBeNull();
|
|
|
|
await act(async () => {
|
|
branchTextButton!.click();
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
expect(writeClipboard).toHaveBeenLastCalledWith(summary.branchName);
|
|
expect(branchTextButton?.nextElementSibling?.className).toContain("opacity-100");
|
|
|
|
await act(async () => {
|
|
pathTextButton!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
expect(writeClipboard).toHaveBeenLastCalledWith(summary.cwd);
|
|
expect(pathTextButton?.nextElementSibling?.className).toContain("opacity-100");
|
|
|
|
await act(async () => {
|
|
branchIconButton!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
pathIconButton!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
expect(writeClipboard).toHaveBeenCalledWith(summary.branchName);
|
|
expect(writeClipboard).toHaveBeenCalledWith(summary.cwd);
|
|
|
|
act(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
it("colors live service urls green", () => {
|
|
const root = createRoot(container);
|
|
|
|
act(() => {
|
|
root.render(withQueryClient(
|
|
<ProjectWorkspaceSummaryCard
|
|
projectRef="paperclip-app"
|
|
summary={createSummary({
|
|
primaryServiceUrl: "http://127.0.0.1:62475",
|
|
primaryServiceUrlRunning: true,
|
|
runningServiceCount: 1,
|
|
})}
|
|
runtimeActionKey={null}
|
|
runtimeActionPending={false}
|
|
onRuntimeAction={() => {}}
|
|
onCloseWorkspace={() => {}}
|
|
/>,
|
|
));
|
|
});
|
|
|
|
const serviceLink = container.querySelector("a[href='http://127.0.0.1:62475']");
|
|
expect(serviceLink?.className).toContain("text-emerald");
|
|
|
|
act(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
});
|