mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-16 14:40:49 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Managed worktree services run isolated Paperclip instances with cloned databases. > - A reachable service was reported as ready even when its database, runtime identity, or login path was not usable. > - The first candidate added verified database seeding and managed repair in #11665. > - This pull request consolidates that candidate with signed login handoff and a complete readiness contract. > - Post-QA fixes close five defects in repair identity, repair responses, UI retry, seed journal handling, and seed-source trust. > - The benefit is a workspace that either opens safely or reports one accurate recovery action. ## Linked Issues or Issue Description No public GitHub issue exists for this work, so the problem is described here. **What happened** Managed workspace URLs could return HTTP 200 and report ready while login failed. QA also found cases where repair used the wrong instance identity, returned a generic error, left the UI stuck, rejected a safe journal lag, or trusted a mutable workspace manifest. **Expected behavior** Opening a ready workspace signs the board user in to the correct isolated instance. Provisioning and repair use a registered source and report a structured recovery state. **Actual behavior** Entry depended on a password copied into the clone. Several failure paths could publish stale readiness, hide the repair precondition, or trust state that the workspace could modify. **Additional context** This pull request includes the commits first published in #11665. That pull request keeps the original base head for review history. This consolidated pull request is the merge candidate. Related open readiness work includes #11575 and #11621. ## What Changed - Adds a short-lived, signed, single-use login ticket. It binds the user, workspace, instance, and runtime origin. - Exchanges the ticket through Better Auth. It creates the session and cookie through the supported adapter path. - Adds protected workspace readiness fields for the database, clone data, login handoff, seed phase, and runtime identity. - Fails readiness closed when the guest has no company or execution-workspace binding. - Binds ticket issuance to the exact cloned user and active company membership selected for the handoff. - Verifies every current active board identity through the exact-user handoff before publication or reuse. - Gates managed runtime publication on the readiness contract and the recorded worktree instance identity. - Refreshes runtime work products from the live runtime row after a port change. - Adds one workspace access card with ready, degraded, repairing, and failed states. - Uses the runtime response identity for repair. It returns structured repair precondition errors. - Lets a valid source journal lag converge during provisioning. - Binds seed and repair manifests to a source registered outside the agent-writable worktree. - Clears recovered UI errors so a successful retry can open the workspace. - Makes runtime tests register canonical sources and avoid ports owned by live host listeners. - Keeps Vitest on source suites when compiled `dist` trees exist. - Isolates CLI and adapter tests from ambient AWS and runtime API environment variables. - Preserves a 404 response for cross-company workspace ID lookups before runtime authorization. - Makes concurrent single-flight coverage independent of path-canonicalization scheduling order. ## Verification The following checks passed on the integrated head: ```sh pnpm -r typecheck pnpm build pnpm check:token-gates pnpm --filter @paperclipai/db check:migrations ``` - The server source lane passed 420 files and 4,953 tests. Five tests were skipped. - The CLI lane passed 57 files and 385 tests. - The database lane passed 26 files and 97 tests. - The shared package passed 58 files and 506 tests. - The adapter utility lane passed 640 tests. Four tests were skipped. - The Claude adapter passed 220 tests. One test was skipped. - The Codex adapter passed 323 tests. - The OpenClaw adapter passed 13 tests. - The OpenCode adapter passed 42 tests. - The plugin SDK passed 45 tests. - The workspace runtime suite passed 124 tests. - The caller-scoped readiness and handoff suite passed 52 tests. - The workspace provisioning shell suite passed 7 tests. - The runtime exposure suite passed 17 tests while live host mappings occupied fixed test ports. - `git diff --check` passed and the worktree is clean. The serialized route lane will run in GitHub CI with its normal shards. No deployment or active-workspace migration was performed. ## Risks - This is a medium-risk authentication and runtime-readiness change. - The login ticket uses exact origin, workspace, instance, and user binding. It has a short expiry and a one-time nonce. - Runtime publication is stricter. A real readiness, identity, per-user handoff, or control-plane database disagreement now blocks publication. - This pull request supersedes #11665 as the merge candidate. Close #11665 after this pull request merges. - No new database migration is included. The lockfile and workflow files are unchanged. - Deployment and active-workspace migration are intentionally outside this pull request. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Claude Opus 5 (`claude-opus-5[1m]`), 1M context, extended thinking, tool use, and code execution produced the main candidate. OpenAI GPT-5 (`gpt-5`) through Codex, with agentic reasoning, tool use, and code execution, integrated the post-QA fixes and hardened the test gates. The Codex context-window size was not exposed. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
318 lines
12 KiB
TypeScript
318 lines
12 KiB
TypeScript
import { and, eq } from "drizzle-orm";
|
|
import type { Db } from "@paperclipai/db";
|
|
import { executionWorkspaceRuntimeLeases, heartbeatRuns, issues } from "@paperclipai/db";
|
|
import { conflict } from "../errors.js";
|
|
|
|
type ExecutionWorkspaceRuntimeLeaseRow = typeof executionWorkspaceRuntimeLeases.$inferSelect;
|
|
type LeaseTx = Parameters<Parameters<Db["transaction"]>[0]>[0];
|
|
|
|
/**
|
|
* Issue statuses that keep an issue eligible to drive workspace runtime controls.
|
|
* Shared with the runtime authorization path so "still authorized" and "still owns
|
|
* the lease" cannot drift apart.
|
|
*/
|
|
export const WORKSPACE_RUNTIME_ELIGIBLE_ISSUE_STATUSES: readonly string[] = [
|
|
"backlog",
|
|
"todo",
|
|
"in_progress",
|
|
"in_review",
|
|
"blocked",
|
|
];
|
|
|
|
const TERMINAL_HEARTBEAT_RUN_STATUSES = new Set([
|
|
"succeeded",
|
|
"interrupted",
|
|
"failed",
|
|
"cancelled",
|
|
"timed_out",
|
|
]);
|
|
|
|
/** Runtime control actions that mutate the workspace and therefore need the lease. */
|
|
export const LEASED_WORKSPACE_RUNTIME_ACTIONS: readonly string[] = ["start", "stop", "restart", "repair"];
|
|
|
|
/**
|
|
* Upper bound on how long a lease survives without the owner touching it. Recovery
|
|
* from a stale owner is otherwise driven by owner eligibility, which is cheaper and
|
|
* more precise; the TTL only bounds the cases eligibility cannot see (for example an
|
|
* agent-scoped owner with no run or issue identity).
|
|
*/
|
|
export const WORKSPACE_RUNTIME_LEASE_TTL_MS = 30 * 60 * 1000;
|
|
|
|
export type WorkspaceRuntimeLeaseOwner = {
|
|
actorType: string;
|
|
agentId?: string | null;
|
|
runId?: string | null;
|
|
issueId?: string | null;
|
|
};
|
|
|
|
export type WorkspaceRuntimeLeaseStaleReason =
|
|
| "lease_expired"
|
|
| "owner_issue_missing"
|
|
| "owner_issue_hidden"
|
|
| "owner_issue_terminal"
|
|
| "owner_run_missing"
|
|
| "owner_run_terminal";
|
|
|
|
export type WorkspaceRuntimeLeaseClaim = {
|
|
outcome: "created" | "renewed" | "reclaimed" | "bypassed";
|
|
ownerKey: string | null;
|
|
lease: ExecutionWorkspaceRuntimeLeaseRow | null;
|
|
reclaimedFrom: { ownerKey: string; reason: WorkspaceRuntimeLeaseStaleReason } | null;
|
|
};
|
|
|
|
/**
|
|
* Durable owner identity for a lease. The controlling issue is preferred because a
|
|
* canary lane outlives any single heartbeat run; runs and bare agent keys are only
|
|
* used when no issue is in scope.
|
|
*/
|
|
export function buildWorkspaceRuntimeLeaseOwnerKey(owner: WorkspaceRuntimeLeaseOwner): string | null {
|
|
if (owner.issueId) return `issue:${owner.issueId}`;
|
|
if (owner.runId) return `run:${owner.runId}`;
|
|
if (owner.agentId) return `agent:${owner.agentId}`;
|
|
return null;
|
|
}
|
|
|
|
function parseOwnerKey(ownerKey: string): { kind: "issue" | "run" | "agent"; id: string } | null {
|
|
const separator = ownerKey.indexOf(":");
|
|
if (separator <= 0) return null;
|
|
const kind = ownerKey.slice(0, separator);
|
|
const id = ownerKey.slice(separator + 1);
|
|
if (!id) return null;
|
|
if (kind !== "issue" && kind !== "run" && kind !== "agent") return null;
|
|
return { kind, id };
|
|
}
|
|
|
|
async function evaluateStaleOwner(
|
|
tx: LeaseTx,
|
|
lease: ExecutionWorkspaceRuntimeLeaseRow,
|
|
now: Date,
|
|
): Promise<WorkspaceRuntimeLeaseStaleReason | null> {
|
|
if (lease.expiresAt.getTime() <= now.getTime()) return "lease_expired";
|
|
|
|
const owner = parseOwnerKey(lease.ownerKey);
|
|
if (owner?.kind === "issue") {
|
|
const ownerIssue = await tx
|
|
.select({ status: issues.status, hiddenAt: issues.hiddenAt })
|
|
.from(issues)
|
|
.where(and(eq(issues.id, owner.id), eq(issues.companyId, lease.companyId)))
|
|
.then((rows) => rows[0] ?? null);
|
|
if (!ownerIssue) return "owner_issue_missing";
|
|
if (ownerIssue.hiddenAt) return "owner_issue_hidden";
|
|
if (!WORKSPACE_RUNTIME_ELIGIBLE_ISSUE_STATUSES.includes(ownerIssue.status)) return "owner_issue_terminal";
|
|
return null;
|
|
}
|
|
|
|
if (owner?.kind === "run") {
|
|
const ownerRun = await tx
|
|
.select({ status: heartbeatRuns.status })
|
|
.from(heartbeatRuns)
|
|
.where(and(eq(heartbeatRuns.id, owner.id), eq(heartbeatRuns.companyId, lease.companyId)))
|
|
.then((rows) => rows[0] ?? null);
|
|
if (!ownerRun) return "owner_run_missing";
|
|
if (TERMINAL_HEARTBEAT_RUN_STATUSES.has(ownerRun.status)) return "owner_run_terminal";
|
|
return null;
|
|
}
|
|
|
|
// Agent-scoped and unparseable owners have no lifecycle to inspect, so the TTL
|
|
// checked above is their only recovery path.
|
|
return null;
|
|
}
|
|
|
|
function throwLeaseConflict(input: {
|
|
lease: ExecutionWorkspaceRuntimeLeaseRow;
|
|
requestedAction: string;
|
|
requestedOwnerKey: string;
|
|
}): never {
|
|
const { lease } = input;
|
|
throw conflict(
|
|
"Another issue run holds the exclusive runtime lease for this execution workspace.",
|
|
{
|
|
code: "workspace_runtime_lease_conflict",
|
|
executionWorkspaceId: lease.executionWorkspaceId,
|
|
requestedAction: input.requestedAction,
|
|
requestedOwnerKey: input.requestedOwnerKey,
|
|
ownerKey: lease.ownerKey,
|
|
ownerIssueId: lease.ownerIssueId,
|
|
ownerRunId: lease.ownerRunId,
|
|
ownerAgentId: lease.ownerAgentId,
|
|
lastAction: lease.lastAction,
|
|
claimedAt: lease.claimedAt.toISOString(),
|
|
renewedAt: lease.renewedAt.toISOString(),
|
|
expiresAt: lease.expiresAt.toISOString(),
|
|
remediation:
|
|
"Do not retry against this execution workspace. Wait for the owning issue to reach a terminal status, ask its owner to release the workspace, or wait for the lease to expire, then retry.",
|
|
},
|
|
);
|
|
}
|
|
|
|
export function workspaceRuntimeLeaseService(db: Db) {
|
|
return {
|
|
async get(executionWorkspaceId: string) {
|
|
return await db
|
|
.select()
|
|
.from(executionWorkspaceRuntimeLeases)
|
|
.where(eq(executionWorkspaceRuntimeLeases.executionWorkspaceId, executionWorkspaceId))
|
|
.then((rows) => rows[0] ?? null);
|
|
},
|
|
|
|
/**
|
|
* Atomically claim (or renew, or reclaim from a stale owner) the exclusive runtime
|
|
* lease for an execution workspace. Cross-process exclusivity comes from the unique
|
|
* constraint on execution_workspace_id plus a `SELECT ... FOR UPDATE` on the existing
|
|
* row, so competing claims serialize in the database rather than in one process.
|
|
*
|
|
* Board/operator actors bypass the lease entirely: they keep unconditional control
|
|
* and never take the lane away from an agent run.
|
|
*/
|
|
async claim(input: {
|
|
companyId: string;
|
|
executionWorkspaceId: string;
|
|
action: string;
|
|
owner: WorkspaceRuntimeLeaseOwner;
|
|
now?: Date;
|
|
ttlMs?: number;
|
|
}): Promise<WorkspaceRuntimeLeaseClaim> {
|
|
if (input.owner.actorType !== "agent") {
|
|
return { outcome: "bypassed", ownerKey: null, lease: null, reclaimedFrom: null };
|
|
}
|
|
|
|
const ownerKey = buildWorkspaceRuntimeLeaseOwnerKey(input.owner);
|
|
if (!ownerKey) {
|
|
return { outcome: "bypassed", ownerKey: null, lease: null, reclaimedFrom: null };
|
|
}
|
|
|
|
const now = input.now ?? new Date();
|
|
const expiresAt = new Date(now.getTime() + (input.ttlMs ?? WORKSPACE_RUNTIME_LEASE_TTL_MS));
|
|
const ownerColumns = {
|
|
ownerKey,
|
|
ownerIssueId: input.owner.issueId ?? null,
|
|
ownerRunId: input.owner.runId ?? null,
|
|
ownerAgentId: input.owner.agentId ?? null,
|
|
};
|
|
|
|
return await db.transaction(async (tx) => {
|
|
const created = await tx
|
|
.insert(executionWorkspaceRuntimeLeases)
|
|
.values({
|
|
companyId: input.companyId,
|
|
executionWorkspaceId: input.executionWorkspaceId,
|
|
...ownerColumns,
|
|
lastAction: input.action,
|
|
claimedAt: now,
|
|
renewedAt: now,
|
|
expiresAt,
|
|
createdAt: now,
|
|
updatedAt: now,
|
|
})
|
|
.onConflictDoNothing({ target: executionWorkspaceRuntimeLeases.executionWorkspaceId })
|
|
.returning()
|
|
.then((rows) => rows[0] ?? null);
|
|
if (created) {
|
|
return { outcome: "created" as const, ownerKey, lease: created, reclaimedFrom: null };
|
|
}
|
|
|
|
// The insert above conflicted, so a row exists (and, if a competing claim was
|
|
// mid-flight, the conflict already waited for it to commit). Lock it before
|
|
// deciding whether this caller may take or keep the lane.
|
|
const current = await tx
|
|
.select()
|
|
.from(executionWorkspaceRuntimeLeases)
|
|
.where(eq(executionWorkspaceRuntimeLeases.executionWorkspaceId, input.executionWorkspaceId))
|
|
.for("update")
|
|
.then((rows) => rows[0] ?? null);
|
|
if (!current) {
|
|
// The holder released between the conflict and the lock; the caller can retry
|
|
// immediately rather than mutating a workspace it does not own.
|
|
throw conflict("The execution workspace runtime lease changed while it was being claimed.", {
|
|
code: "workspace_runtime_lease_contended",
|
|
executionWorkspaceId: input.executionWorkspaceId,
|
|
requestedAction: input.action,
|
|
remediation: "Retry the runtime control request.",
|
|
});
|
|
}
|
|
|
|
if (current.ownerKey === ownerKey) {
|
|
const renewed = await tx
|
|
.update(executionWorkspaceRuntimeLeases)
|
|
.set({
|
|
...ownerColumns,
|
|
lastAction: input.action,
|
|
renewedAt: now,
|
|
expiresAt,
|
|
updatedAt: now,
|
|
})
|
|
.where(eq(executionWorkspaceRuntimeLeases.id, current.id))
|
|
.returning()
|
|
.then((rows) => rows[0] ?? current);
|
|
return { outcome: "renewed" as const, ownerKey, lease: renewed, reclaimedFrom: null };
|
|
}
|
|
|
|
const staleReason = await evaluateStaleOwner(tx, current, now);
|
|
if (!staleReason) {
|
|
throwLeaseConflict({ lease: current, requestedAction: input.action, requestedOwnerKey: ownerKey });
|
|
}
|
|
|
|
const reclaimed = await tx
|
|
.update(executionWorkspaceRuntimeLeases)
|
|
.set({
|
|
companyId: input.companyId,
|
|
...ownerColumns,
|
|
lastAction: input.action,
|
|
claimedAt: now,
|
|
renewedAt: now,
|
|
expiresAt,
|
|
updatedAt: now,
|
|
metadata: {
|
|
reclaimedFromOwnerKey: current.ownerKey,
|
|
reclaimReason: staleReason,
|
|
reclaimedAt: now.toISOString(),
|
|
},
|
|
})
|
|
.where(eq(executionWorkspaceRuntimeLeases.id, current.id))
|
|
.returning()
|
|
.then((rows) => rows[0] ?? null);
|
|
if (!reclaimed) {
|
|
throwLeaseConflict({ lease: current, requestedAction: input.action, requestedOwnerKey: ownerKey });
|
|
}
|
|
|
|
return {
|
|
outcome: "reclaimed" as const,
|
|
ownerKey,
|
|
lease: reclaimed,
|
|
reclaimedFrom: { ownerKey: current.ownerKey, reason: staleReason },
|
|
};
|
|
});
|
|
},
|
|
|
|
/**
|
|
* Give up the lane. `force` is for operator/lifecycle paths (workspace archive);
|
|
* owner-scoped releases only remove a lease the caller actually holds.
|
|
*/
|
|
async release(input: {
|
|
executionWorkspaceId: string;
|
|
owner?: WorkspaceRuntimeLeaseOwner;
|
|
force?: boolean;
|
|
}): Promise<{ released: boolean; ownerKey: string | null }> {
|
|
const ownerKey = input.owner ? buildWorkspaceRuntimeLeaseOwnerKey(input.owner) : null;
|
|
if (!input.force && !ownerKey) return { released: false, ownerKey: null };
|
|
|
|
const condition = input.force
|
|
? eq(executionWorkspaceRuntimeLeases.executionWorkspaceId, input.executionWorkspaceId)
|
|
: and(
|
|
eq(executionWorkspaceRuntimeLeases.executionWorkspaceId, input.executionWorkspaceId),
|
|
eq(executionWorkspaceRuntimeLeases.ownerKey, ownerKey!),
|
|
);
|
|
|
|
const deleted = await db
|
|
.delete(executionWorkspaceRuntimeLeases)
|
|
.where(condition)
|
|
.returning({ ownerKey: executionWorkspaceRuntimeLeases.ownerKey })
|
|
.then((rows) => rows[0] ?? null);
|
|
|
|
return { released: Boolean(deleted), ownerKey: deleted?.ownerKey ?? null };
|
|
},
|
|
};
|
|
}
|
|
|
|
export type WorkspaceRuntimeLeaseService = ReturnType<typeof workspaceRuntimeLeaseService>;
|