Files
PaperClipAI/ui/src/components/SidebarRecentTasks.test.tsx
T
DottaandPaperclip 5b750fdf25 feat(ui): add foldable sidebar subtasks with bounded refreshes (#21649)
## Thinking Path

> - Paperclip helps people manage AI agents for work.
> - The sidebar helps people return to recent tasks.
> - Recent parents need foldable child tasks.
> - Busy companies must not refresh every child group for unrelated
work.
> - Exact unread counts must preserve personal reads and task access.
> - This pull request adds child groups and bounds their refresh work.
> - People can scan subtasks without repeated background requests.

## Linked Issues or Issue Description

**Subsystem affected**

Task navigation in the standard and Classic sidebars.

**Problem or motivation**

Recent parent tasks did not show their subtasks. The first
implementation refreshed every previously viewed group. One unrelated
update caused 52 child-page requests and one summary request after
viewing 50 groups. Exact child counts also repeated privacy and unread
checks per child.

**Proposed solution**

Show direct subtasks with independent folding and ten-row pages. Refresh
affected groups and summary batches. Stop offscreen reads. Bound
child-request concurrency. Aggregate viewer facts once and preserve the
existing inbox unread rule.

**Roadmap alignment**

This extends existing task navigation. The existing feature PR is reused
for its performance repair. No new PR duplicates it.

## What Changed

- Add shared parent groups to both sidebar layouts. Preserve Classic row
actions and active-child visibility.
- Keep unread state personal to each task. Folding and paging do not
mark tasks read. Counts include readable children beyond ten.
- Target live refreshes with authorized current and previous parent IDs.
Reuse parent metadata from the narrow run-binding read. Resolve fallback
lookups once per delivery batch. Keep the previous summary fallback for
older servers.
- Limit child requests to three at a time. Cancel active and queued
reads when groups leave the viewport.
- Discard extra cached pages on Show less and collapse.
- Compute exact navigation counts in one SQL statement. Materialize
readable candidate IDs once. Use indexed participation sources and
conservative unread candidates before the shared inbox rule.
- Skip recursive privacy walks for standalone open tasks without a
project. Keep the recursive rule for all restricted or inherited shapes
and all delegated principals.
- Add request-count, cancellation, reparenting, read-receipt,
inbox-parity and privacy regressions. Include a disposable PostgreSQL
benchmark.
- Update product and API documentation. Retain the production Storybook
states.

## Verification

- Published head: `4148861437c1b6b635479ad92509dbc71155a232`. Its tree
matches local `04be9d66d481d9bcd1c4d6158acf063a1e65ac7e`:
`a23533e93d3d155918f0254d296a7fd2f0c7c12f`.
- Rebased on master `ca23330c69b1f2b25bdadfcbda68317db97deaef`. Remote
publication preserves prior feature commits.
- The request regression failed before the fix and passes after it. An
unrelated event now sends zero child requests. Current servers also
avoid the unrelated summary request. Old-server events keep one summary
fallback.
- A relevant update after Show less reads one page. Reparenting
refreshes two affected groups. Offscreen reads stay at zero and resume
once on return. Active and queued cancellation tests pass.
- The same synthetic authenticated HTTP workload with 50,000 read
children improved from 767 ms to 92.84 ms median. Five warm samples per
case. The all-unread case improved from 463.85 to 351.65 ms. Untouched
children improved from 208.01 to 131.09 ms. The old-receipt case
improved from 799.70 to 245.80 ms. These local measurements are not a
production capacity guarantee.
- Focused PostgreSQL routes, inbox-parity, privacy and WebSocket tests
passed: 38 tests.
- All 325 affected UI tests passed. All 38 focused PostgreSQL, privacy
and WebSocket tests passed. UI typecheck and low-memory server
declaration checks passed.
- All 41 Chromium Storybook checks passed. They cover 20 states in both
themes and keyboard, folding, paging and unread behavior. They use
production components with HTTP fixtures.
- Both new review findings failed as regressions before their fixes and
pass afterward. Explicit child reads include waiting external
conversations. Deleting a child publishes a separate parent-authorized
update without deleted-child content. Both review threads are resolved.
- `pnpm verify --explain` returned exit 2 because product documentation
requires broader CI. [The prior CI
run](https://github.com/paperclipai/paperclip/actions/runs/43711489306)
found type errors in the new test fixtures. The same errors failed
locally. The fixture fix passes `node
server/scripts/typecheck-layers.mjs --layer test-tree-0` and all 21
issue summary route tests. Production code is unchanged. That CI run
then found a live-delivery read regression. The existing test failed
locally with eight statements against its six-statement budget. A new
PostgreSQL regression also found three parent lookups for two same-batch
calls. Run delivery now reuses parent metadata from its narrow
run-binding query. Fallback lookups resolve to one promise. Both
regressions pass without increasing the budgets. All 74 targeted route,
WebSocket and privacy tests pass. The affected below, above and
test-tree-0 typecheck layers pass. [CI attempt
2](https://github.com/paperclipai/paperclip/actions/runs/43715541480/attempts/2)
passes on the published head. All 62 check runs are terminal and clean:
57 succeeded, two were neutral and three were skipped. Typecheck, build,
policy, all general and serialized server suites, E2E and the [final
verify
gate](https://github.com/paperclipai/paperclip/actions/runs/43715541480/job/132829783231)
pass. The separate security status passes. Attempt 1's server shard 7/12
reached its 20-minute job limit without a test verdict. One retry of
that job passed without a source change. [Greptile completed
successfully on this
head](https://github.com/paperclipai/paperclip/runs/132816163906) with a
[5/5
score](https://github.com/paperclipai/paperclip/pull/21649#issuecomment-6883916606).
All five review threads are resolved. The final CI gate is complete.
- A full local Storybook build exceeded available memory while server
typechecking ran. Browser verification uses the current-source
development server. Rebuilding stale Runner and SDK declarations
resolved the initial server check errors. The first browser attempt
lacked Chromium; all checks passed after installation.
- Reproduce the database measurements with `pnpm --filter
@paperclipai/server exec tsx scripts/benchmark-sidebar-subtasks.ts`.
- Extra local shard diagnosis ran 164 suites. Under this shell's `0077`
creation mask, 157 suites passed and three had fixture permission or
timing failures. Rerunning those three with `0022` resolved the
permission failures. The remaining ten cases passed with one worker: two
workspace cases and eight archive cases. The eight archive cases also
passed on the pre-performance-fix revision, whose archive source is
identical. The broad local shard is not claimed as one passing
execution. The same-head CI retry supplies complete final CI coverage.
- Nothing is merged or deployed.

## Risks

- Exact counts still grow with the readable hierarchy and comment
history. The change reduces repeated work; it does not cap or
approximate counts.
- A relevant summary batch can contain several recent parents. Older
servers retain a broader summary fallback until upgraded.
- Live delivery adds bounded, permission-checked parent lookups. Short
delivery-window reuse limits repeated reads.
- The authorization fast path applies only to open tasks with no privacy
parent and no project. Restricted cases retain the shared predicate.
- No migration is required.

## Model Used

OpenAI Codex, based on GPT-6. Used code execution, native GitHub tools,
PostgreSQL and Chromium verification.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either linked a public issue or described the issue in this
PR
- [x] I have not referenced internal or instance-local Paperclip issues
or links
- [x] My branch name describes the change and contains no internal issue
id
- [x] I have run focused tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation
- [x] I have considered and documented risks
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open findings
- [x] I will address all review comments before requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-15 08:51:04 -06:00

601 lines
22 KiB
TypeScript

// @vitest-environment jsdom
import { act, type ReactNode } from "react";
import { createRoot, type Root } from "react-dom/client";
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { TooltipProvider } from "@/components/ui/tooltip";
import { SidebarRecentTasks } from "./SidebarRecentTasks";
import {
getRecentTasksStorageKey,
readRecentTasks,
recordRecentTask,
pruneRecentTasks,
} from "@/lib/recent-tasks";
import { queryKeys } from "@/lib/queryKeys";
const mockAuthApi = vi.hoisted(() => ({ getSession: vi.fn() }));
const mockAgentsApi = vi.hoisted(() => ({ wakeup: vi.fn() }));
const mockIssuesApi = vi.hoisted(() => ({
get: vi.fn(),
summaries: vi.fn(),
listCompact: vi.fn(async (_company: string, _filters?: { parentId?: string }) => [] as unknown[]),
update: vi.fn(),
archiveFromInbox: vi.fn(),
getTreeControlState: vi.fn(),
createTreeHold: vi.fn(),
releaseTreeHold: vi.fn(),
chatBootstrap: vi.fn(async () => ({ items: [] })),
}));
vi.mock("@/api/agents", () => ({ agentsApi: mockAgentsApi }));
vi.mock("@/api/auth", () => ({ authApi: mockAuthApi }));
vi.mock("@/api/issues", () => ({ issuesApi: mockIssuesApi }));
vi.mock("@/lib/router", () => ({
useLocation: () => ({ pathname: "/PAP/issues" }),
NavLink: ({ children, to, className, ...props }: {
children: ReactNode;
to: string;
className?: string | ((state: { isActive: boolean }) => string);
}) => (
<a
href={to}
className={typeof className === "function" ? className({ isActive: false }) : className}
{...props}
>
{children}
</a>
),
}));
vi.mock("@/context/SidebarContext", () => ({
useSidebar: () => ({
collapsed: false,
peeking: false,
isMobile: false,
setSidebarOpen: vi.fn(),
}),
}));
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
describe("SidebarRecentTasks", () => {
let container: HTMLDivElement;
let root: Root;
beforeEach(() => {
window.localStorage.clear();
Object.values(mockAgentsApi).forEach((mock) => mock.mockReset());
Object.values(mockIssuesApi).forEach((mock) => mock.mockReset());
mockIssuesApi.summaries.mockImplementation(async (_company: string, ids: string[]) => {
const rows = await Promise.all(ids.map(id => mockIssuesApi.get.getMockImplementation()?.(id)));
return rows.filter(row => row && !row.hiddenAt);
});
container = document.createElement("div");
document.body.appendChild(container);
root = createRoot(container);
mockAuthApi.getSession.mockResolvedValue({
session: { id: "session-1", userId: "user-1" },
user: { id: "user-1", name: "Board", email: "board@example.test", image: null },
});
});
afterEach(() => {
act(() => root.unmount());
container.remove();
vi.clearAllMocks();
vi.useRealTimers();
});
async function render() {
const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
await act(async () => {
root.render(
<QueryClientProvider client={queryClient}>
<TooltipProvider>
<SidebarRecentTasks companyId="company-1" liveIssueIds={new Set(["issue-1"])} />
</TooltipProvider>
</QueryClientProvider>,
);
});
await act(async () => {
for (let index = 0; index < 5; index += 1) {
await Promise.resolve();
await new Promise((resolve) => window.setTimeout(resolve, 0));
}
});
return queryClient;
}
async function openActions(taskTitle: string) {
const actions = container.querySelector<HTMLButtonElement>(
`button[aria-label="More actions for ${taskTitle}"]`,
);
await act(async () => {
actions?.dispatchEvent(new PointerEvent("pointerdown", { bubbles: true }));
await Promise.resolve();
});
}
function menuItem(label: string) {
return Array.from(document.body.querySelectorAll<HTMLElement>('[role="menuitem"]'))
.find((item) => item.textContent?.trim() === label);
}
function setInputValue(input: HTMLInputElement, value: string) {
const setter = Object.getOwnPropertyDescriptor(HTMLInputElement.prototype, "value")?.set;
setter?.call(input, value);
input.dispatchEvent(new Event("input", { bubbles: true }));
}
it("hides the section when there are no recent tasks", async () => {
await render();
expect(container.textContent).not.toContain("Recent Tasks");
expect(container.textContent).not.toContain("Open or create a task");
});
it("keeps actions on both parent and nested child rows", async () => {
const parent = { id: "parent", companyId: "company-1", title: "Parent", identifier: "PAP-1", status: "todo" as const, updatedAt: new Date(1), subtaskCount: 1 };
recordRecentTask(parent, "user-1");
mockIssuesApi.summaries.mockResolvedValue([parent]);
mockIssuesApi.listCompact.mockResolvedValue([{ id: "child", companyId: "company-1", parentId: "parent", title: "Child", identifier: "PAP-2", status: "todo" }] as never);
await render();
expect(container.querySelector('[aria-label="More actions for Parent"]')).not.toBeNull();
expect(container.querySelector('[aria-label="More actions for Child"]')).not.toBeNull();
await openActions("Child");
expect(menuItem("Rename")).toBeDefined();
expect(menuItem("Archive")).toBeDefined();
expect(menuItem("Pause/Restart")).toBeDefined();
});
it("shows every task once in a four-level recent chain", async () => {
const tasks = ["a", "b", "c", "d"].map((id, index) => ({
id, companyId: "company-1", identifier: `TASK-${id}`, title: `Task ${id}`, status: "todo" as const, updatedAt: new Date(index + 1),
parentId: index ? ["a", "b", "c"][index - 1] : null, subtaskCount: index < 3 ? 1 : 0,
}));
tasks.forEach(task => recordRecentTask(task, "user-1"));
mockIssuesApi.summaries.mockResolvedValue(tasks);
mockIssuesApi.listCompact.mockImplementation(async (_company, filters) => tasks.filter(task => task.parentId === filters?.parentId));
await render();
expect(container.querySelectorAll("a")).toHaveLength(4);
for (const id of ["a", "b", "c", "d"]) expect(container.querySelectorAll(`a[href="/issues/TASK-${id}"]`)).toHaveLength(1);
});
it("renders refreshed task text and live state without shifting for a status icon", async () => {
recordRecentTask({
id: "issue-1",
companyId: "company-1",
title: "Initial title",
identifier: "PAP-1",
status: "todo",
updatedAt: new Date(1),
}, "user-1");
mockIssuesApi.get.mockResolvedValue({
id: "issue-1",
companyId: "company-1",
title: "Refreshed title",
identifier: "PAP-1",
status: "in_progress",
hiddenAt: null,
updatedAt: new Date(2),
});
const queryClient = await render();
await act(async () => {
for (let index = 0; index < 5; index += 1) {
await Promise.resolve();
await new Promise((resolve) => window.setTimeout(resolve, 0));
}
});
const link = container.querySelector('a[href="/issues/PAP-1"]');
expect(mockIssuesApi.get).not.toHaveBeenCalled();
expect(mockIssuesApi.summaries).toHaveBeenCalledTimes(1);
expect(queryClient.getQueryData(["issues", "detail", "issue-1"])).toBeUndefined();
expect(link?.textContent).toContain("Refreshed title");
expect(link?.textContent).toContain("1 live");
expect(link?.querySelector('[aria-label="In Progress"]')).toBeNull();
expect(link?.querySelector('[data-slot="recent-task-icon-spacer"]')).toBeNull();
expect(link?.querySelector('[data-slot="sidebar-nav-icon"]')).toBeNull();
expect(link?.firstElementChild?.textContent).toBe("Refreshed title");
const actions = container.querySelector<HTMLButtonElement>(
'button[aria-label="More actions for Refreshed title"]',
);
expect(actions).not.toBeNull();
expect(actions?.className).toContain("opacity-0");
});
it("keeps rows stable during alternating activity and applies the final order after quiet", async () => {
const tasks = [1, 2, 3].map((id) => ({
id: `issue-${id}`,
companyId: "company-1",
title: `Task ${id}`,
identifier: `PAP-${id}`,
status: "done" as const,
hiddenAt: null,
projectId: null,
updatedAt: new Date(id),
}));
tasks.forEach((task) => recordRecentTask(task, "user-1"));
mockIssuesApi.get.mockImplementation(async (id: string) => tasks.find((task) => task.id === id));
const queryClient = await render();
const order = () => Array.from(container.querySelectorAll("a")).map((link) => link.getAttribute("href"));
// Links open the identifier route the task page settles on.
const originalOrder = ["/issues/PAP-3", "/issues/PAP-2", "/issues/PAP-1"];
expect(order()).toEqual(originalOrder);
vi.useFakeTimers();
for (let index = 0; index < 6; index += 1) {
const task = tasks[index % 2]!;
await act(async () => {
queryClient.setQueryData(queryKeys.issues.detail(task.id), {
...task, title: `Updated ${task.id}`, updatedAt: new Date(100 + index),
});
await vi.advanceTimersByTimeAsync(0);
});
await act(async () => { await vi.advanceTimersByTimeAsync(500); });
expect(order()).toEqual(originalOrder);
expect(container.textContent).toContain(`Updated ${task.id}`);
}
await act(async () => { await vi.advanceTimersByTimeAsync(499); });
expect(order()).toEqual(originalOrder);
await act(async () => { await vi.advanceTimersByTimeAsync(1); });
expect(order()).toEqual(["/issues/PAP-2", "/issues/PAP-1", "/issues/PAP-3"]);
expect(mockIssuesApi.get).not.toHaveBeenCalled();
expect(mockIssuesApi.summaries).toHaveBeenCalledTimes(1);
queryClient.clear();
});
it("adds and removes tasks immediately while an activity reorder is pending", async () => {
const task = (id: string, recordedAt: number) => ({
id, companyId: "company-1", title: id, identifier: id,
status: "todo" as const, updatedAt: new Date(recordedAt),
});
recordRecentTask(task("first", 1), "user-1");
recordRecentTask(task("second", 2), "user-1");
mockIssuesApi.get.mockImplementation(async (id: string) => task(id, 0));
const queryClient = await render();
vi.useFakeTimers();
act(() => recordRecentTask(task("first", 3), "user-1"));
expect(container.querySelector("a")?.getAttribute("href")).toBe("/issues/second");
await act(async () => {
recordRecentTask(task("new", 4), "user-1");
await vi.advanceTimersByTimeAsync(0);
});
expect(container.querySelector("a")?.getAttribute("href")).toBe("/issues/new");
act(() => pruneRecentTasks(getRecentTasksStorageKey("company-1", "user-1"), "company-1", new Set(["second"])));
expect(container.querySelector('a[href="/issues/second"]')).toBeNull();
await act(async () => { await vi.advanceTimersByTimeAsync(2_000); });
expect(container.querySelector('a[href="/issues/second"]')).toBeNull();
queryClient.clear();
});
it("opens the compact task actions menu from the ellipsis button", async () => {
recordRecentTask({
id: "issue-1",
companyId: "company-1",
title: "Menu task",
identifier: "PAP-1",
status: "todo",
updatedAt: new Date(1),
}, "user-1");
mockIssuesApi.get.mockResolvedValue({
id: "issue-1",
companyId: "company-1",
title: "Menu task",
identifier: "PAP-1",
status: "todo",
hiddenAt: null,
updatedAt: new Date(1),
});
await render();
await openActions("Menu task");
const menu = document.body.querySelector('[data-slot="dropdown-menu-content"]');
expect(menu?.textContent).toContain("Rename");
expect(menu?.textContent).toContain("Archive");
expect(menu?.textContent).toContain("Pause/Restart");
});
it("keeps an idle Slack conversation in recent history and labels it Idle", async () => {
const issue = {
id: "issue-1", companyId: "company-1", title: "Slack conversation", identifier: "PAP-1",
status: "in_review" as const, externalConversationState: "waiting" as const,
updatedAt: new Date(1), hiddenAt: null,
};
recordRecentTask(issue, "user-1");
mockIssuesApi.get.mockResolvedValue(issue);
await render();
expect(container.textContent).toContain("Slack conversation");
expect(container.textContent).toContain("Idle");
});
it("archives a task from the inbox without hiding or removing the recent task", async () => {
const issue = {
id: "issue-1",
companyId: "company-1",
title: "Archive me",
identifier: "PAP-1",
status: "todo" as const,
hiddenAt: null,
updatedAt: new Date(1),
};
recordRecentTask(issue, "user-1");
mockIssuesApi.get.mockResolvedValue(issue);
mockIssuesApi.archiveFromInbox.mockResolvedValue({
id: issue.id,
archivedAt: new Date(2),
});
await render();
await openActions("Archive me");
await act(async () => {
menuItem("Archive")?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
await Promise.resolve();
await new Promise((resolve) => window.setTimeout(resolve, 0));
});
expect(mockIssuesApi.archiveFromInbox).toHaveBeenCalledWith("issue-1");
expect(mockIssuesApi.update).not.toHaveBeenCalled();
expect(container.textContent).toContain("Recent Tasks");
expect(container.querySelector('a[href="/issues/PAP-1"]')?.textContent).toContain(
"Archive me",
);
expect(readRecentTasks(
getRecentTasksStorageKey("company-1", "user-1"),
"company-1",
)).toHaveLength(1);
});
it("refreshes task activity after a rename", async () => {
const issue = {
id: "issue-1",
companyId: "company-1",
title: "Old title",
identifier: "PAP-1",
status: "todo" as const,
hiddenAt: null,
updatedAt: new Date(1),
};
const renamedIssue = { ...issue, title: "New title", updatedAt: new Date(2) };
recordRecentTask(issue, "user-1");
mockIssuesApi.get.mockResolvedValue(issue);
mockIssuesApi.update.mockResolvedValue(renamedIssue);
const queryClient = await render();
const invalidateQueries = vi.spyOn(queryClient, "invalidateQueries");
await openActions("Old title");
await act(async () => {
menuItem("Rename")?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
await Promise.resolve();
});
const input = document.body.querySelector<HTMLInputElement>('input[aria-label="Task name"]');
expect(input).not.toBeNull();
await act(async () => {
setInputValue(input!, "New title");
await Promise.resolve();
});
await act(async () => {
input?.closest("form")?.dispatchEvent(new SubmitEvent("submit", { bubbles: true, cancelable: true }));
await Promise.resolve();
await new Promise((resolve) => window.setTimeout(resolve, 0));
});
expect(mockIssuesApi.update).toHaveBeenCalledWith("issue-1", { title: "New title" });
expect(invalidateQueries).toHaveBeenCalledWith({
queryKey: queryKeys.issues.activity("issue-1"),
});
});
it("pauses a running task or restarts its active pause hold", async () => {
const issue = {
id: "issue-1",
companyId: "company-1",
title: "Toggle work",
identifier: "PAP-1",
status: "in_progress" as const,
assigneeAgentId: "agent-1",
hiddenAt: null,
updatedAt: new Date(1),
};
recordRecentTask(issue, "user-1");
mockIssuesApi.get.mockResolvedValue(issue);
mockIssuesApi.getTreeControlState
.mockResolvedValueOnce({ activePauseHold: null })
.mockResolvedValueOnce({
activePauseHold: {
holdId: "hold-1",
rootIssueId: "issue-1",
issueId: "issue-1",
isRoot: true,
mode: "pause",
reason: null,
releasePolicy: { strategy: "manual" },
},
});
mockIssuesApi.createTreeHold.mockResolvedValue({ hold: {}, preview: {} });
mockIssuesApi.releaseTreeHold.mockResolvedValue({});
mockAgentsApi.wakeup.mockResolvedValue({ id: "run-1" });
await render();
await openActions("Toggle work");
await act(async () => {
menuItem("Pause/Restart")?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
await Promise.resolve();
await new Promise((resolve) => window.setTimeout(resolve, 0));
});
expect(mockIssuesApi.createTreeHold).toHaveBeenCalledWith("issue-1", {
mode: "pause",
reason: "Paused from Recent Tasks.",
releasePolicy: { strategy: "manual" },
});
await openActions("Toggle work");
await act(async () => {
menuItem("Pause/Restart")?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
await Promise.resolve();
await new Promise((resolve) => window.setTimeout(resolve, 0));
});
expect(mockIssuesApi.releaseTreeHold).toHaveBeenCalledWith("issue-1", "hold-1", {
reason: "Restarted from Recent Tasks.",
});
expect(mockAgentsApi.wakeup).toHaveBeenCalledWith(
"agent-1",
{
source: "assignment",
triggerDetail: "manual",
reason: "recent_task_restart",
payload: { issueId: "issue-1" },
},
"company-1",
);
});
it("retries only the wake after a remount when restart releases the hold before wakeup fails", async () => {
const issue = {
id: "issue-1",
companyId: "company-1",
title: "Retry restart",
identifier: "PAP-1",
status: "in_progress" as const,
assigneeAgentId: "agent-1",
hiddenAt: null,
updatedAt: new Date(1),
};
recordRecentTask(issue, "user-1");
mockIssuesApi.get.mockResolvedValue(issue);
mockIssuesApi.getTreeControlState
.mockResolvedValueOnce({
activePauseHold: {
holdId: "hold-1",
rootIssueId: "issue-1",
issueId: "issue-1",
isRoot: true,
mode: "pause",
reason: null,
releasePolicy: { strategy: "manual" },
},
})
.mockResolvedValueOnce({ activePauseHold: null });
mockIssuesApi.releaseTreeHold.mockResolvedValue({});
mockAgentsApi.wakeup
.mockRejectedValueOnce(new Error("Wake failed"))
.mockResolvedValueOnce({ id: "run-1" });
await render();
await openActions("Retry restart");
await act(async () => {
menuItem("Pause/Restart")?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
await Promise.resolve();
await new Promise((resolve) => window.setTimeout(resolve, 0));
});
await act(async () => root.unmount());
root = createRoot(container);
await render();
await openActions("Retry restart");
await act(async () => {
menuItem("Pause/Restart")?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
await Promise.resolve();
await new Promise((resolve) => window.setTimeout(resolve, 0));
});
expect(mockIssuesApi.releaseTreeHold).toHaveBeenCalledTimes(1);
expect(mockIssuesApi.createTreeHold).not.toHaveBeenCalled();
expect(mockAgentsApi.wakeup).toHaveBeenCalledTimes(2);
expect(mockAgentsApi.wakeup).toHaveBeenLastCalledWith(
"agent-1",
{
source: "assignment",
triggerDetail: "manual",
reason: "recent_task_restart_retry",
payload: { issueId: "issue-1" },
},
"company-1",
);
});
it("synchronizes recent tasks written by another tab", async () => {
mockIssuesApi.get.mockImplementation(() => new Promise(() => {}));
await render();
const storageKey = getRecentTasksStorageKey("company-1", "user-1");
const entries = [{
id: "issue-2",
companyId: "company-1",
title: "Cross-tab task",
identifier: "PAP-2",
status: "todo" as const,
recordedAt: 2,
}];
await act(async () => {
window.localStorage.setItem(storageKey, JSON.stringify(entries));
window.dispatchEvent(new StorageEvent("storage", { key: storageKey }));
await Promise.resolve();
});
expect(container.querySelector('a[href="/issues/PAP-2"]')?.textContent).toContain("Cross-tab task");
});
it("preserves pending restart wake retries from before the snapshot storage migration", async () => {
const issue = {
id: "issue-1", companyId: "company-1", title: "Retry after upgrade", identifier: "PAP-1",
status: "in_progress" as const, assigneeAgentId: "agent-1", hiddenAt: null, updatedAt: new Date(1),
};
window.localStorage.setItem("paperclip.recentTasks:company-1:user-1", JSON.stringify([{ ...issue, recordedAt: 1 }]));
window.localStorage.setItem("paperclip.recentTasks:company-1:user-1:restart-wake-retry", JSON.stringify([issue.id]));
mockIssuesApi.get.mockResolvedValue(issue);
mockIssuesApi.getTreeControlState.mockResolvedValue({ activePauseHold: null });
mockAgentsApi.wakeup.mockResolvedValue({ id: "run-1" });
await render();
await openActions("Retry after upgrade");
await act(async () => {
menuItem("Pause/Restart")?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
await Promise.resolve();
await new Promise((resolve) => window.setTimeout(resolve, 0));
});
expect(mockIssuesApi.createTreeHold).not.toHaveBeenCalled();
expect(mockIssuesApi.releaseTreeHold).not.toHaveBeenCalled();
expect(mockAgentsApi.wakeup).toHaveBeenCalledWith("agent-1", expect.objectContaining({
reason: "recent_task_restart_retry",
}), "company-1");
expect(window.localStorage.getItem("paperclip.recentTasks:company-1:user-1:restart-wake-retry")).toBeNull();
});
it("prunes tasks that become hidden", async () => {
recordRecentTask({
id: "issue-hidden",
companyId: "company-1",
title: "Hidden task",
identifier: "PAP-3",
status: "todo",
updatedAt: new Date(3),
}, "user-1");
mockIssuesApi.get.mockResolvedValue({
id: "issue-hidden",
companyId: "company-1",
title: "Hidden task",
identifier: "PAP-3",
status: "todo",
hiddenAt: new Date(),
updatedAt: new Date(4),
});
await render();
await act(async () => {
await Promise.resolve();
await new Promise((resolve) => window.setTimeout(resolve, 0));
});
expect(container.querySelector('a[href="/issues/PAP-3"]')).toBeNull();
expect(readRecentTasks(
getRecentTasksStorageKey("company-1", "user-1"),
"company-1",
)).toEqual([]);
});
});