mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-02 16:58:52 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Routines create tasks that people need to inspect and manage. > - The routines list sends its View all runs link to Audit. > - Tasks already supports routine origin filters in its API, but the page has no control for them. > - This pull request adds a Routine tasks checkbox and links to that selection. > - People can inspect routine work in the normal task list, search, and board views. ## Linked Issues or Issue Description **What existing behavior does this improve?** The routines list link and the Tasks filters. **Current behavior** View all runs opens Audit. People cannot select routine-created tasks in the Tasks filter menu. **Proposed behavior** View all tasks opens `/issues?view=all&originKind=routine_execution`. Routine tasks is selected. People can toggle or clear it from Tasks. **Reason and benefit** People can use normal task controls to inspect work created by routines. The filter includes manually started routine runs. It excludes manual tasks and other automatic work. **Breaking changes** The routines list link changes its label and destination. No API, schema, authorization, or routine execution contract changes. ## What Changed - Add Routine tasks under Visibility in the current, streamlined, and legacy Tasks filters. Keep Live runs only in the same group and use Show agent-created tasks with proper capitalization where that control is available. - Keep the selection in the URL through reload, search, task navigation, and checkbox changes. - Apply the existing API origin filter before pagination. Include routine tasks even when other automatic tasks are hidden. - Keep source filtering in the shared task filter module and collection owners. Reuse the existing company-scoped issue-list contract. Hide the live-run control in the design sandbox, which does not load live-run IDs. - Update regression coverage, product docs, feature/access maps, and the toolbar preview. ## Verification - All 58 final-head checks are complete with no failures for `f46c2e409b20fa372d166f4721601a0471894fb0`, including successful `ci / verify` and `ci / e2e` gates. Greptile and Paperclip Review rate this commit 5/5 with no actionable findings or unresolved review threads. [CI run](https://github.com/paperclipai/paperclip/actions/runs/41078093110). - Local checks pass: full repo typecheck/build for the feature, UI typecheck/build after the final refinements, token gates, feature-map checks, and Storybook catalog generation. - Regression coverage exercises both real list implementations, filter grouping and selection, search and all board columns, URL/pagination state, and mixed pending-decision batches. The Visibility update passed all 89 relevant tests across separate runs. The final sandbox correction passes all 10 filter-menu tests, including three cases that reproduced the bug before the fix. The earlier broad UI run passed 10,043 tests across 845 files. - Browser proof used the actual local app with disposable PostgreSQL data: three tasks created through the routine-run API and one manual task. Followed View all tasks; verified the selected Routine tasks checkbox under Visibility, toggling, reload, search, and board view. Checked current, streamlined, and legacy filter presentations. Screenshots show the link, routine-only results, and requested capitalization/grouping. - Failure accounting: the initial broad UI run found two preference expectations that needed the new false default; those were corrected before the full UI pass. Scrolling tests hit five-second timeouts in combined runs and passed in isolated reruns without timeout changes. A duplicate full local UI run was stopped after the earlier final-commit CI UI lanes passed, with no failures reported in that stopped run. - Full local `pnpm test:run` could not complete because native PostgreSQL initialization exhausted the host semaphore pool. A direct initdb probe confirmed `could not create semaphores: No space left on device`. Browser verification used a disposable container; no host settings or other workspace processes were changed. - Review found that the newly exposed live-run control could empty the design sandbox, which has no live-run IDs. The sandbox now disables that unsupported control; its regression test failed before the fix and passes after it. ## Risks - Low risk. The change uses the existing routine origin and read permissions. A routine task remains automatic work, including when a person starts it manually. - The routine checkbox is exposed only on the Tasks collection. Other filter consumers retain their controls and normalize the new field to false. - Routine histories and Audit run links inside routine details keep their current behavior. ## Model Used - OpenAI GPT-6, through Codex, assisted with implementation and verification. The exact runtime model ID and context window are not exposed in this session. Capabilities used: repository editing, command execution, tests, and browser interaction. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
368 lines
15 KiB
TypeScript
368 lines
15 KiB
TypeScript
import { useShowAgentCreatedTasks } from "../hooks/useShowAgentCreatedTasks";
|
|
import { useCoordinatorWorkspaceEnabled } from "../hooks/useCoordinatorWorkspaceEnabled";
|
|
import { CoordinatorTasks } from "./CoordinatorTasks";
|
|
import { useDesignSandbox } from "../context/DesignSandboxContext";
|
|
import { DesignSandboxTasks } from "./DesignSandboxTasks";
|
|
import { useEffect, useMemo, useCallback, useRef, useState } from "react";
|
|
import type { ReactNode } from "react";
|
|
import { Navigate, useLocation, useNavigate, useSearchParams } from "@/lib/router";
|
|
import { useInfiniteQuery, useQuery } from "@tanstack/react-query";
|
|
import { issuesApi } from "../api/issues";
|
|
import { agentsApi } from "../api/agents";
|
|
import { projectsApi } from "../api/projects";
|
|
import { heartbeatsApi } from "../api/heartbeats";
|
|
import { useCompany } from "../context/CompanyContext";
|
|
import { useBreadcrumbs } from "../context/BreadcrumbContext";
|
|
import { collectLiveIssueIds } from "../lib/liveIssueIds";
|
|
import { usePublishSharedQueryData, useSharedPollingQuery } from "@/hooks/useSharedPolling";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
import { createIssueDetailLocationState } from "../lib/issueDetailBreadcrumb";
|
|
import { EmptyState } from "../components/EmptyState";
|
|
import { IssuesList } from "../components/IssuesList";
|
|
import { TaskViewsMenu } from "../components/TaskViewsMenu";
|
|
import { Button } from "@/components/ui/button";
|
|
import { CircleDot, Plus } from "lucide-react";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import { useStreamlinedUiEnabled } from "../hooks/useStreamlinedUiEnabled";
|
|
import { useCombinedInboxTasksEnabled } from "../hooks/useCombinedInboxTasksEnabled";
|
|
import { useDialogActions } from "../context/DialogContext";
|
|
import { useInboxBadge } from "../hooks/useInboxBadge";
|
|
import { Inbox } from "./Inbox";
|
|
import {
|
|
ORGANIZATION_SCOPED_PARAMS,
|
|
TASK_VIEW_PARAM,
|
|
loadLastTaskView,
|
|
normalizeTaskViewKey,
|
|
resolveInitialTaskView,
|
|
saveLastTaskView,
|
|
taskView,
|
|
type TaskViewKey,
|
|
} from "../lib/task-views";
|
|
import { useUpdateIssueMutation } from "../hooks/useUpdateIssueMutation";
|
|
|
|
const WORKSPACE_FILTER_ISSUE_LIMIT = 1000;
|
|
const ISSUES_PAGE_SIZE = 100;
|
|
export const ISSUES_ROW_PRESENTATION = "task" as const;
|
|
export const ISSUES_TOOLBAR_PRESENTATION = "collection" as const;
|
|
|
|
export function resolveIssuesPresentation(streamlinedUiEnabled: boolean) {
|
|
return streamlinedUiEnabled
|
|
? { rowPresentation: ISSUES_ROW_PRESENTATION, toolbarPresentation: ISSUES_TOOLBAR_PRESENTATION }
|
|
: { rowPresentation: "legacy" as const, toolbarPresentation: "legacy" as const };
|
|
}
|
|
|
|
export function getNextIssuesPageOffset(
|
|
loadedPageSize: number,
|
|
currentOffset: number,
|
|
pageSize: number = ISSUES_PAGE_SIZE,
|
|
): number | undefined {
|
|
return loadedPageSize >= pageSize ? currentOffset + pageSize : undefined;
|
|
}
|
|
|
|
export function mergeIssuePagesStable<T extends { id: string }>(pages: T[][]): T[] {
|
|
const seenIssueIds = new Set<string>();
|
|
const merged: T[] = [];
|
|
|
|
for (const page of pages) {
|
|
for (const issue of page) {
|
|
if (seenIssueIds.has(issue.id)) continue;
|
|
seenIssueIds.add(issue.id);
|
|
merged.push(issue);
|
|
}
|
|
}
|
|
|
|
return merged;
|
|
}
|
|
|
|
export function buildIssuesSearchUrl(currentHref: string, search: string): string | null {
|
|
const url = new URL(currentHref);
|
|
const currentSearch = url.searchParams.get("q") ?? "";
|
|
if (currentSearch === search) return null;
|
|
|
|
if (search.length > 0) {
|
|
url.searchParams.set("q", search);
|
|
} else {
|
|
url.searchParams.delete("q");
|
|
}
|
|
|
|
return `${url.pathname}${url.search}${url.hash}`;
|
|
}
|
|
|
|
/**
|
|
* Tasks — the single task surface after PAP-670 merged Inbox into it.
|
|
*
|
|
* This component only resolves `?view=` to a view and hands off: My-work views
|
|
* render the inbox list, organization views render the task collection. Both
|
|
* get the same Views control in their toolbar, so the switch reads as one page.
|
|
*/
|
|
export function Issues() {
|
|
const designSandbox = useDesignSandbox();
|
|
const { enabled: streamlinedUiEnabled } = useStreamlinedUiEnabled();
|
|
const { enabled: combinedInboxTasksEnabled } = useCombinedInboxTasksEnabled();
|
|
const { enabled: coordinatorEnabled } = useCoordinatorWorkspaceEnabled();
|
|
const [params] = useSearchParams();
|
|
const location = useLocation();
|
|
const requestedView = normalizeTaskViewKey(params.get(TASK_VIEW_PARAM));
|
|
const organizationScoped = [...ORGANIZATION_SCOPED_PARAMS, "workspaceId"].some(param => params.getAll(param).some(Boolean));
|
|
// Saved merged-Inbox URLs retain their original surface inside Coordinator.
|
|
// Its effective Combined Inbox setting is off, so these routes do not loop.
|
|
if (!designSandbox && coordinatorEnabled && !organizationScoped && requestedView && taskView(requestedView).surface === "inbox") {
|
|
const next = new URLSearchParams(params); next.delete(TASK_VIEW_PARAM);
|
|
const search = next.toString();
|
|
return <Navigate to={`/inbox/${taskView(requestedView).inboxTab}${search ? `?${search}` : ""}${location.hash}`} replace />;
|
|
}
|
|
// The merged surface is Combined Inbox + Task List only. With the flag off, and always in
|
|
// the legacy shell, Tasks is the plain task list and Inbox keeps its pages.
|
|
return designSandbox ? <DesignSandboxTasks /> : coordinatorEnabled ? <CoordinatorTasks /> : streamlinedUiEnabled && combinedInboxTasksEnabled ? <StreamlinedTasks /> : <OrganizationIssues />;
|
|
}
|
|
|
|
function StreamlinedTasks() {
|
|
const navigate = useNavigate();
|
|
const [searchParams, setSearchParams] = useSearchParams();
|
|
const { selectedCompanyId } = useCompany();
|
|
const { openNewIssue } = useDialogActions();
|
|
const inboxBadge = useInboxBadge(selectedCompanyId);
|
|
|
|
const requestedView = searchParams.get(TASK_VIEW_PARAM);
|
|
const hasOrganizationScopedParam = ORGANIZATION_SCOPED_PARAMS.some(
|
|
(param) => (searchParams.get(param) ?? "").length > 0,
|
|
);
|
|
// Read the stored view once per mount so a later write can't yank the view
|
|
// out from under the user mid-session.
|
|
const [lastUsedView] = useState<TaskViewKey>(() => loadLastTaskView());
|
|
const view = resolveInitialTaskView(requestedView, hasOrganizationScopedParam, lastUsedView);
|
|
const definition = taskView(view);
|
|
|
|
// Make the resolved view addressable without dropping the params that
|
|
// brought the user here — and correct a requested view that was overridden
|
|
// (an inbox view carrying an organization filter opens All tasks).
|
|
useEffect(() => {
|
|
if (normalizeTaskViewKey(requestedView) === view) return;
|
|
setSearchParams((current) => {
|
|
const next = new URLSearchParams(current);
|
|
next.set(TASK_VIEW_PARAM, view);
|
|
return next;
|
|
}, { replace: true });
|
|
}, [requestedView, view, setSearchParams]);
|
|
|
|
const selectView = useCallback((next: TaskViewKey) => {
|
|
saveLastTaskView(next);
|
|
// A view switch starts clean: the previous view's search and filters are
|
|
// its own, not the new view's.
|
|
navigate(`/issues?${TASK_VIEW_PARAM}=${next}`);
|
|
}, [navigate]);
|
|
|
|
const viewsMenu = (
|
|
<TaskViewsMenu value={view} onChange={selectView} badgeCount={inboxBadge.inbox} />
|
|
);
|
|
|
|
if (definition.surface === "inbox") {
|
|
return (
|
|
<Inbox
|
|
tab={definition.inboxTab}
|
|
surfaceLabel="Tasks"
|
|
toolbarContext={(
|
|
<div className="flex min-w-0 items-center gap-2">
|
|
{viewsMenu}
|
|
<Button size="sm" variant="outline" aria-label="New Task" onClick={() => openNewIssue()}>
|
|
<Plus className="h-4 w-4 sm:mr-1" />
|
|
<span className="hidden sm:inline">New Task</span>
|
|
</Button>
|
|
</div>
|
|
)}
|
|
/>
|
|
);
|
|
}
|
|
|
|
return <OrganizationIssues toolbarContext={viewsMenu} initialStatuses={definition.statuses} />;
|
|
}
|
|
|
|
function OrganizationIssues({
|
|
toolbarContext,
|
|
initialStatuses,
|
|
}: { toolbarContext?: ReactNode; initialStatuses?: string[] } = {}) {
|
|
const { enabled: streamlinedUiEnabled } = useStreamlinedUiEnabled();
|
|
const issuesPresentation = resolveIssuesPresentation(streamlinedUiEnabled);
|
|
const { selectedCompanyId } = useCompany();
|
|
const { setBreadcrumbs } = useBreadcrumbs();
|
|
const location = useLocation();
|
|
const [searchParams, setSearchParams] = useSearchParams();
|
|
const fetchNextPageInFlightRef = useRef(false);
|
|
|
|
const urlSearch = searchParams.get("q") ?? "";
|
|
const [searchOverride, setSearchOverride] = useState<{ search: string; locationSearch: string } | null>(null);
|
|
const syncedSearch = useMemo(() => {
|
|
if (typeof window !== "undefined" && searchOverride?.locationSearch === window.location.search) {
|
|
return searchOverride.search;
|
|
}
|
|
return urlSearch;
|
|
}, [searchOverride, urlSearch, location.search]);
|
|
const showAgentCreatedTasks = useShowAgentCreatedTasks(selectedCompanyId, "paperclip:issues-view");
|
|
const routineTasksOnly = searchParams.get("originKind") === "routine_execution";
|
|
const includeAgentCreatedTasks = showAgentCreatedTasks || routineTasksOnly;
|
|
const originKind = routineTasksOnly ? "routine_execution" : undefined;
|
|
const handleRoutineTasksOnlyChange = useCallback((checked: boolean) => {
|
|
setSearchParams(current => {
|
|
const next = new URLSearchParams(current);
|
|
if (syncedSearch) next.set("q", syncedSearch);
|
|
else next.delete("q");
|
|
if (checked) next.set("originKind", "routine_execution");
|
|
else next.delete("originKind");
|
|
return next;
|
|
}, { replace: true });
|
|
}, [setSearchParams, syncedSearch]);
|
|
const participantAgentId = searchParams.get("participantAgentId") ?? undefined;
|
|
const initialWorkspaces = searchParams.getAll("workspace").filter((workspaceId) => workspaceId.length > 0);
|
|
const workspaceIdFilter = initialWorkspaces.length === 1 ? initialWorkspaces[0] : undefined;
|
|
const handleSearchChange = useCallback((search: string) => {
|
|
const nextUrl = buildIssuesSearchUrl(window.location.href, search);
|
|
if (!nextUrl) {
|
|
setSearchOverride(null);
|
|
return;
|
|
}
|
|
window.history.replaceState(window.history.state, "", nextUrl);
|
|
setSearchOverride({ search, locationSearch: window.location.search });
|
|
}, []);
|
|
|
|
const { data: agents } = useQuery({
|
|
queryKey: queryKeys.agents.list(selectedCompanyId!),
|
|
queryFn: () => agentsApi.list(selectedCompanyId!),
|
|
enabled: !!selectedCompanyId,
|
|
});
|
|
|
|
const { data: projects } = useQuery({
|
|
queryKey: queryKeys.projects.list(selectedCompanyId!, { includeArchived: true }),
|
|
queryFn: () => projectsApi.list(selectedCompanyId!, { includeArchived: true }),
|
|
enabled: !!selectedCompanyId,
|
|
});
|
|
|
|
const liveRunsQueryKey = queryKeys.liveRuns(selectedCompanyId!);
|
|
const sharedLiveRuns = useSharedPollingQuery({
|
|
companyId: selectedCompanyId,
|
|
resourceKey: "live-runs",
|
|
queryKey: liveRunsQueryKey,
|
|
enabled: !!selectedCompanyId,
|
|
// Event-sourced via LiveUpdatesProvider (GitHub issue 9627); no interval poll needed.
|
|
refetchInterval: false,
|
|
leaderOnly: true,
|
|
});
|
|
const { data: liveRuns, dataUpdatedAt: liveRunsUpdatedAt } = useQuery({
|
|
queryKey: liveRunsQueryKey,
|
|
queryFn: () => heartbeatsApi.liveRunsForCompany(selectedCompanyId!),
|
|
enabled: sharedLiveRuns.enabled,
|
|
refetchInterval: sharedLiveRuns.refetchInterval,
|
|
});
|
|
usePublishSharedQueryData(sharedLiveRuns, liveRuns, liveRunsUpdatedAt);
|
|
|
|
const issueLinkState = useMemo(
|
|
() =>
|
|
createIssueDetailLocationState(
|
|
"Tasks",
|
|
`${location.pathname}${location.search}${location.hash}`,
|
|
"issues",
|
|
),
|
|
[location.pathname, location.search, location.hash],
|
|
);
|
|
|
|
useEffect(() => {
|
|
setBreadcrumbs([{ label: "Tasks" }]);
|
|
}, [setBreadcrumbs]);
|
|
|
|
const issuePageSize = workspaceIdFilter ? WORKSPACE_FILTER_ISSUE_LIMIT : ISSUES_PAGE_SIZE;
|
|
|
|
const {
|
|
data: issuePages,
|
|
isLoading,
|
|
isFetchingNextPage,
|
|
error,
|
|
hasNextPage,
|
|
fetchNextPage,
|
|
} = useInfiniteQuery({
|
|
queryKey: [
|
|
...queryKeys.issues.list(selectedCompanyId!),
|
|
"participant-agent",
|
|
participantAgentId ?? "__all__",
|
|
"workspace",
|
|
workspaceIdFilter ?? "__all__",
|
|
streamlinedUiEnabled ? "index" : "compact",
|
|
"with-routine-executions",
|
|
includeAgentCreatedTasks,
|
|
originKind,
|
|
"infinite",
|
|
issuePageSize,
|
|
],
|
|
queryFn: ({ pageParam, signal }) => issuesApi.listCompact(selectedCompanyId!, {
|
|
projection: streamlinedUiEnabled ? "index" : undefined,
|
|
participantAgentId,
|
|
workspaceId: workspaceIdFilter,
|
|
includeRoutineExecutions: true,
|
|
includeAgentCreatedTasks,
|
|
originKind,
|
|
limit: issuePageSize,
|
|
offset: pageParam,
|
|
sortField: "updated",
|
|
sortDir: "desc",
|
|
}, { signal }),
|
|
initialPageParam: 0,
|
|
getNextPageParam: (lastPage, _allPages, lastPageParam) =>
|
|
getNextIssuesPageOffset(lastPage.length, lastPageParam, issuePageSize),
|
|
enabled: !!selectedCompanyId,
|
|
placeholderData: (previousData) => previousData,
|
|
});
|
|
|
|
const issues = useMemo(() => mergeIssuePagesStable(issuePages?.pages ?? []) as Issue[], [issuePages]);
|
|
const liveIssueIds = useMemo(() => collectLiveIssueIds(liveRuns, issues), [issues, liveRuns]);
|
|
const hasMoreServerIssues = syncedSearch.trim().length === 0
|
|
&& hasNextPage === true;
|
|
const loadMoreServerIssues = useCallback(() => {
|
|
if (!hasNextPage || isFetchingNextPage || fetchNextPageInFlightRef.current) return;
|
|
fetchNextPageInFlightRef.current = true;
|
|
void fetchNextPage({ cancelRefetch: false }).finally(() => {
|
|
fetchNextPageInFlightRef.current = false;
|
|
});
|
|
}, [fetchNextPage, hasNextPage, isFetchingNextPage]);
|
|
|
|
// Optimistic, rolls back with a readable toast, and resends after an outage.
|
|
const updateIssue = useUpdateIssueMutation({ companyId: selectedCompanyId });
|
|
|
|
if (!selectedCompanyId) {
|
|
return (
|
|
<EmptyState
|
|
icon={CircleDot}
|
|
message={streamlinedUiEnabled
|
|
? "Select an organization to view tasks."
|
|
: "Select a company to view tasks."}
|
|
/>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<IssuesList
|
|
issues={issues ?? []}
|
|
isLoading={isLoading}
|
|
isLoadingMoreIssues={isFetchingNextPage}
|
|
error={error as Error | null}
|
|
agents={agents}
|
|
projects={projects}
|
|
liveIssueIds={liveIssueIds}
|
|
viewStateKey="paperclip:issues-view"
|
|
rowPresentation={issuesPresentation.rowPresentation}
|
|
toolbarPresentation={issuesPresentation.toolbarPresentation}
|
|
issueLinkState={issueLinkState}
|
|
initialAssignees={searchParams.get("assignee") ? [searchParams.get("assignee")!] : undefined}
|
|
initialWorkspaces={initialWorkspaces.length > 0 ? initialWorkspaces : undefined}
|
|
initialStatuses={initialStatuses}
|
|
toolbarContext={toolbarContext}
|
|
initialSearch={syncedSearch}
|
|
onSearchChange={handleSearchChange}
|
|
enableAgentCreatedVisibilityFilter
|
|
routineTasksOnly={routineTasksOnly}
|
|
onRoutineTasksOnlyChange={handleRoutineTasksOnlyChange}
|
|
hasMoreIssues={hasMoreServerIssues}
|
|
onLoadMoreIssues={loadMoreServerIssues}
|
|
onUpdateIssue={(id, data) => updateIssue.mutate({ id, data })}
|
|
searchFilters={participantAgentId || workspaceIdFilter || originKind ? { participantAgentId, workspaceId: workspaceIdFilter, originKind } : undefined}
|
|
/>
|
|
);
|
|
}
|