mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 07:12:00 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
105 lines
4.4 KiB
TypeScript
105 lines
4.4 KiB
TypeScript
import path from "node:path";
|
|
import { defineConfig } from "@playwright/test";
|
|
import {
|
|
runnerE2EWebServerCommand,
|
|
runnerE2EWebServerGracefulShutdown,
|
|
} from "./web-server-command.js";
|
|
|
|
function required(name: string) {
|
|
const value = process.env[name]?.trim();
|
|
if (!value) throw new Error(`${name} is required`);
|
|
return value;
|
|
}
|
|
|
|
const port = Number(required("PAPERCLIP_RUNNER_E2E_PORT"));
|
|
const temporaryRoot = required("PAPERCLIP_RUNNER_E2E_TEMP_ROOT");
|
|
const privateDir = required("PAPERCLIP_RUNNER_E2E_PRIVATE_DIR");
|
|
const paperclipHome = required("PAPERCLIP_HOME");
|
|
const configPath = required("PAPERCLIP_CONFIG");
|
|
const baseURL = `http://127.0.0.1:${port}`;
|
|
const playwrightChannel = process.env.PAPERCLIP_PLAYWRIGHT_CHANNEL?.trim();
|
|
const chromiumExecutable =
|
|
process.env.PAPERCLIP_RUNNER_E2E_CHROMIUM_EXECUTABLE?.trim();
|
|
if (playwrightChannel && chromiumExecutable) {
|
|
throw new Error(
|
|
"PAPERCLIP_PLAYWRIGHT_CHANNEL and PAPERCLIP_RUNNER_E2E_CHROMIUM_EXECUTABLE are mutually exclusive",
|
|
);
|
|
}
|
|
if (chromiumExecutable && !path.isAbsolute(chromiumExecutable)) {
|
|
throw new Error(
|
|
"PAPERCLIP_RUNNER_E2E_CHROMIUM_EXECUTABLE must be an absolute path",
|
|
);
|
|
}
|
|
required("PAPERCLIP_INSTANCE_ID");
|
|
required("PAPERCLIP_AGENT_JWT_SECRET");
|
|
required("PAPERCLIP_DECISION_SIGNING_SECRET");
|
|
required("PAPERCLIP_TOOL_ACTION_SIGNING_SECRET");
|
|
required("BETTER_AUTH_SECRET");
|
|
if (
|
|
!paperclipHome.startsWith(`${temporaryRoot}${path.sep}`) ||
|
|
!configPath.startsWith(`${temporaryRoot}${path.sep}`)
|
|
) {
|
|
throw new Error("Paperclip server paths escape the isolated temporary root");
|
|
}
|
|
const repositoryRoot = path.resolve(import.meta.dirname, "../..");
|
|
|
|
export default defineConfig({
|
|
testDir: ".",
|
|
testMatch: process.env.PAPERCLIP_RUNNER_E2E_INSTALLED_STARTUP_ONLY === "1" ? "installed-startup.spec.ts" : "runner.spec.ts",
|
|
timeout: Number(process.env.PAPERCLIP_RUNNER_E2E_TEST_TIMEOUT_MS ?? 600_000),
|
|
expect: { timeout: 30_000 },
|
|
fullyParallel: false,
|
|
workers: 1,
|
|
retries: 0,
|
|
use: {
|
|
baseURL,
|
|
browserName: "chromium",
|
|
...(playwrightChannel ? { channel: playwrightChannel } : {}),
|
|
...(chromiumExecutable
|
|
? { launchOptions: { executablePath: chromiumExecutable } }
|
|
: {}),
|
|
headless: true,
|
|
actionTimeout: 30_000,
|
|
navigationTimeout: 30_000,
|
|
screenshot: process.env.PAPERCLIP_RUNNER_E2E_PUBLIC_MCP === "1" ? "off" : "only-on-failure",
|
|
// Keep DOM snapshots and network, but not the trace's own screencast: a
|
|
// long chat attempt with a live run indicator streamed thousands of JPEG
|
|
// frames (incompressible), pushing failure evidence past the 256 MB private
|
|
// allowance so no evidence survived. The retained failure video still
|
|
// records the visual timeline.
|
|
trace: process.env.PAPERCLIP_RUNNER_E2E_PUBLIC_MCP === "1" ? "off" : { mode: "retain-on-failure", screenshots: false },
|
|
// A developer-supplied system Chromium keeps the local smoke loop
|
|
// installation-free; CI's managed browser retains failure video as usual.
|
|
video: chromiumExecutable || process.env.PAPERCLIP_RUNNER_E2E_PUBLIC_MCP === "1" ? "off" : "retain-on-failure",
|
|
},
|
|
webServer: {
|
|
// Do not put an env object here: Playwright serializes webServer config in
|
|
// blob reports. The wrapper inherits the test process and strips provider
|
|
// keys before spawning the real Paperclip process.
|
|
command: runnerE2EWebServerCommand(repositoryRoot),
|
|
gracefulShutdown: { ...runnerE2EWebServerGracefulShutdown,
|
|
...(JSON.parse(process.env.PAPERCLIP_RUNNER_E2E_EXECUTION_IDS ?? "[]").some((id: string) => id.startsWith("rolling-web-deployment.")) ? { timeout: 105_000 } : {}),
|
|
},
|
|
url: `${baseURL}/api/health`,
|
|
reuseExistingServer: false,
|
|
// Fresh databases apply the complete migration history before health is ready.
|
|
timeout: 300_000,
|
|
stdout: "pipe",
|
|
stderr: "pipe",
|
|
},
|
|
outputDir: path.join(privateDir, "playwright-output"),
|
|
reporter: process.env.PAPERCLIP_RUNNER_E2E_PRIVATE_PREFLIGHT && process.env.PAPERCLIP_CHAT_COMPLETION_TESTOPS === "v1" ? [
|
|
["list"],
|
|
["json", { outputFile: path.join(privateDir, "framework-report.json") }],
|
|
["junit", { outputFile: path.join(privateDir, "junit.xml") }],
|
|
] : [
|
|
["list"],
|
|
["blob", { outputDir: path.join(privateDir, "blob-report") }],
|
|
["junit", { outputFile: path.join(privateDir, "junit.xml") }],
|
|
[
|
|
"html",
|
|
{ open: "never", outputFolder: path.join(privateDir, "html-report") },
|
|
],
|
|
],
|
|
});
|