mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-03 01:27:09 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Its web server also owns controller admission and user commands. > - A rolling deployment starts a replacement before the old server exits. > - Shared database state alone does not preserve local agent files, browser chunks, or in-process commands. > - This pull request adds an opt-in ephemeral server contract and a local overlap test. > - The benefit is a web server that can relinquish traffic and local files without losing acknowledged work. ## Linked Issues or Issue Description Refs #18403, #18327, #18335, #18341. **Current behavior** The control-plane web server still has local agent-file authority and local command targets. A new container can miss saved bytes or send a command to the wrong process. An existing browser tab also needs chunks from its original build. **Proposed behavior** Eligible servers share only PostgreSQL, object storage and stable secrets. A replacement waits for readiness. The old server drains admitted requests, keeps owner commands available through handoff, and releases controller leases. Explicit maintenance adopts existing files before the volume is removed. **Reason and benefit** This is the application prerequisite for rolling app-only deployments. Schema migrations and permanent multi-replica operation are outside this change. ## What Changed - Store agent-file manifests in PostgreSQL and immutable bytes in S3. Treat local roots as disposable projections. Preserve existing permission checks and edit conflicts. - Add an explicit migration, eligibility and object-retention command to the production runtime bundle. - Add `/api/ready`, admitted-request drain, browser restart signaling and retained immutable UI chunks. - Carry transaction-aware work hints across controllers during handoff and active execution. Keep listeners closed when idle. - Deliver durable Stop and runtime responses to the execution owner. Recheck request lifecycle and access before response dispatch. - Reject local-only configuration in ephemeral mode. Keep the feature disabled for existing installations by default. - Add an isolated PostgreSQL/S3/proxy/browser deployment harness with independent server homes and retained failure evidence. ## Verification - All CI checks pass on `ce17b95019d3cf1cabd357d19b6d37f96782cc5c`: workspace typecheck, build, Runner checks, server/general tests and browser shards. Greptile reviewed the runtime changes at 5/5 with all findings resolved; the final commit updates maps and the plan. - Local targeted checks passed: coordinator 27; Stop/recovery 33; PostgreSQL command delivery 6; route/workspace regressions 8; bootstrap Stop 1; restart recovery 75. PostgreSQL command tests simulate the provider edge. - Local browser proof passed 91 reads and 19 saves; reconnect took 1,013ms. The tab opened Audit from S3 after deletion of A's whole home/build. This uses compiled workspace code and local-trusted auth, not released containers or live agents. - Local workspace typecheck/build passed; current server and runtime bundle passed. The earlier broad local suite was stopped after three hours and is not a passing receipt. Its retained failures and isolated reruns are documented in the plan. - Stacked #18526 adds stricter graceful-exit proof, an unready replacement control, live Runner qualification and a Stop handoff correction. Hosted enablement remains gated on those results and Cloud #1096. No hosted stack has been enabled. ## Risks - Apply migration 0422 before enabling the feature. Existing data must pass each owner's migration and eligibility checks. Do not discard a volume based on a single migration page. - Durable manifests remain authoritative after the opt-in is disabled. Rolling back to a binary that ignores them is unsupported. - Cold directory restoration and complete shutdown timing still need qualification before enabling a hosted stack. - Retained UI assets must cover the supported browser and rollback window. Cleanup is explicit; no new idle maintenance polling is introduced. - This change does not claim production zero downtime or authorize a fleet-wide enablement. ## Model Used OpenAI Codex, GPT-6 family. The exact serving model ID and context-window limit are not exposed in this session. Used reasoning, code editing, shell execution and browser automation. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
185 lines
10 KiB
TypeScript
185 lines
10 KiB
TypeScript
import { createHash, randomUUID } from "node:crypto";
|
|
import fs from "node:fs/promises";
|
|
import { constants } from "node:fs";
|
|
import path from "node:path";
|
|
import { pipeline } from "node:stream/promises";
|
|
import { Transform } from "node:stream";
|
|
import { and, eq } from "drizzle-orm";
|
|
import { agentFileRoots, type Db, type DurableAgentFileEntry } from "@paperclipai/db";
|
|
import { HttpError } from "../errors.js";
|
|
import { getStorageService } from "../storage/index.js";
|
|
import { assertInstructionPathSafe, instructionPath } from "./agent-instruction-files.js";
|
|
import { cachedAgentFileManifest } from "./agent-file-checkpoints.js";
|
|
import { AgentFileLimitError, MAX_AGENT_DIRECTORY_BYTES, MAX_AGENT_DIRECTORY_ENTRIES, MAX_AGENT_FILE_BYTES } from "./agent-file-store.js";
|
|
|
|
type Tx = Parameters<Parameters<Db["transaction"]>[0]>[0];
|
|
type Owner = { companyId: string; id: string; createdAt: Date };
|
|
type Head = typeof agentFileRoots.$inferSelect;
|
|
const where = (owner: Owner) => and(eq(agentFileRoots.companyId, owner.companyId), eq(agentFileRoots.agentId, owner.id));
|
|
const marker = (root: string) => path.join(path.dirname(root), "file-sync", "durable-generation");
|
|
const adoptionReceipt = (root: string) => path.join(path.dirname(root), "file-sync", "durable-adoption.json");
|
|
export const durableAgentFilesEnabled = () => process.env.PAPERCLIP_DURABLE_AGENT_FILES === "true";
|
|
|
|
/** A newly created agent has no legacy files to import. Commit its empty
|
|
* authority with the agent row, before any API can acknowledge file mutations. */
|
|
export async function initializeDurableAgentFiles(tx: Db, owner: { companyId: string; id: string }) {
|
|
if (!durableAgentFilesEnabled()) return;
|
|
storage();
|
|
await tx.insert(agentFileRoots).values({ companyId: owner.companyId, agentId: owner.id,
|
|
generation: randomUUID(), entries: [] }).onConflictDoNothing();
|
|
}
|
|
|
|
function storage() {
|
|
const service = getStorageService();
|
|
if (service.provider !== "s3") throw new HttpError(503, "Durable agent files require shared object storage");
|
|
return service;
|
|
}
|
|
|
|
/** Call before changing a projection: a failed write must not leave a valid cache marker. */
|
|
export async function invalidateAgentFileProjection(root: string) {
|
|
await fs.rm(marker(root), { force: true });
|
|
}
|
|
async function mark(root: string, generation: string) {
|
|
await atomicPrivateWrite(marker(root), generation);
|
|
}
|
|
async function atomicPrivateWrite(filename: string, contents: string) {
|
|
await fs.mkdir(path.dirname(filename), { recursive: true, mode: 0o700 });
|
|
const temporary = `${filename}.${randomUUID()}`;
|
|
try {
|
|
await fs.writeFile(temporary, contents, { mode: 0o600 });
|
|
await fs.rename(temporary, filename);
|
|
} finally { await fs.rm(temporary, { force: true }); }
|
|
}
|
|
|
|
/** Under the agent row lock. A durable head remains authoritative even after
|
|
* the opt-in is removed; silently falling back would lose acknowledged writes. */
|
|
export async function restoreDurableAgentFiles(tx: Tx, owner: Owner, root: string): Promise<boolean> {
|
|
let [head] = await tx.select().from(agentFileRoots).where(where(owner));
|
|
if (!head) {
|
|
const filename = await assertInstructionPathSafe(path.dirname(adoptionReceipt(root)), path.basename(adoptionReceipt(root)));
|
|
const contents = await fs.readFile(filename, "utf8").catch((error: NodeJS.ErrnoException) => {
|
|
if (error.code === "ENOENT") return null;
|
|
throw error;
|
|
});
|
|
if (contents !== null) {
|
|
const receipt = JSON.parse(contents) as { version: number; agentCreatedAt: string; head: Head };
|
|
if (receipt.version !== 1 || receipt.head.companyId !== owner.companyId || receipt.head.agentId !== owner.id
|
|
|| receipt.agentCreatedAt !== owner.createdAt.toISOString() || !Array.isArray(receipt.head.entries)) {
|
|
throw new Error("Agent file adoption receipt does not match its owner");
|
|
}
|
|
// A first save can roll back the head after changing local files. Replay
|
|
// only the pre-mutation manifest whose immutable bytes were uploaded,
|
|
// never adopt the now-dirty directory as fresh legacy input.
|
|
[head] = await tx.insert(agentFileRoots).values({ companyId: owner.companyId, agentId: owner.id,
|
|
generation: receipt.head.generation, entries: receipt.head.entries }).returning();
|
|
await invalidateAgentFileProjection(root);
|
|
}
|
|
}
|
|
if (!head) return false;
|
|
const service = storage();
|
|
const generation = await fs.readFile(marker(root), "utf8").catch((error: NodeJS.ErrnoException) => {
|
|
if (error.code === "ENOENT") return null;
|
|
throw error;
|
|
});
|
|
if (generation === head.generation && await fs.stat(root).then(s => s.isDirectory()).catch(() => false)) return true;
|
|
const temporary = path.join(path.dirname(root), `.agent-files-${randomUUID()}`);
|
|
await fs.mkdir(temporary, { recursive: true, mode: 0o700 });
|
|
const signal = AbortSignal.timeout(30_000);
|
|
try {
|
|
// Complete and verify the replacement before discarding an older projection.
|
|
for (const entry of head.entries) {
|
|
signal.throwIfAborted();
|
|
const relative = instructionPath(entry.path);
|
|
if (entry.kind === "dir") {
|
|
await assertInstructionPathSafe(temporary, `${relative}/.path-check`);
|
|
await fs.mkdir(path.join(temporary, relative), { recursive: true, mode: 0o700 }); continue;
|
|
}
|
|
const filename = await assertInstructionPathSafe(temporary, relative);
|
|
await fs.mkdir(path.dirname(filename), { recursive: true, mode: 0o700 });
|
|
const handle = await fs.open(filename, constants.O_WRONLY | constants.O_CREAT | constants.O_EXCL, entry.mode & 0o777);
|
|
try {
|
|
const hash = createHash("sha256");
|
|
let size = 0;
|
|
if (entry.objectKey !== null) {
|
|
const object = await service.getObject(owner.companyId, entry.objectKey, { signal });
|
|
await pipeline(object.stream, new Transform({ transform(chunk: Buffer, _encoding, callback) {
|
|
size += chunk.length;
|
|
if (size > entry.size) return callback(new Error("Agent file exceeds its committed size"));
|
|
hash.update(chunk); callback(null, chunk);
|
|
} }), handle.createWriteStream(), { signal });
|
|
}
|
|
if (size !== entry.size || hash.digest("hex") !== entry.sha256) throw new Error("Agent file does not match its committed digest");
|
|
} finally { await handle.close(); }
|
|
}
|
|
await invalidateAgentFileProjection(root);
|
|
await fs.rm(root, { recursive: true, force: true });
|
|
await fs.rename(temporary, root);
|
|
await mark(root, head.generation);
|
|
return true;
|
|
} finally { await fs.rm(temporary, { recursive: true, force: true }); }
|
|
}
|
|
|
|
/** Publish immutable bytes before the database head. A failed/uncertain database
|
|
* commit never removes uploaded bytes that may have become authoritative. */
|
|
export async function persistDurableAgentFiles(tx: Tx, owner: Owner, root: string, importingLegacy = false) {
|
|
const [previous] = await tx.select().from(agentFileRoots).where(where(owner));
|
|
if (!previous && !durableAgentFilesEnabled()) return;
|
|
const service = storage();
|
|
const manifest = await cachedAgentFileManifest(root);
|
|
if (!importingLegacy) {
|
|
if (manifest.entries.length > MAX_AGENT_DIRECTORY_ENTRIES) throw new AgentFileLimitError("Agent directory exceeds the 100,000-entry limit (files and folders)");
|
|
let total = 0;
|
|
for (const [relative, entry] of manifest.entries) if (entry.kind === "file") {
|
|
if (entry.size! > MAX_AGENT_FILE_BYTES) throw new AgentFileLimitError(`Agent file "${relative}" exceeds the 256 MiB per-file limit`);
|
|
total += entry.size!;
|
|
}
|
|
if (total > MAX_AGENT_DIRECTORY_BYTES) throw new AgentFileLimitError("Agent directory exceeds the 2 GiB total storage limit");
|
|
}
|
|
const before = new Map(previous?.entries.map(entry => [entry.path, entry]));
|
|
const entries: DurableAgentFileEntry[] = [];
|
|
const signal = AbortSignal.timeout(30_000);
|
|
for (const [relative, entry] of manifest.entries) {
|
|
signal.throwIfAborted();
|
|
if (entry.kind === "dir") { entries.push({ path: relative, kind: "dir" }); continue; }
|
|
if (entry.kind !== "file") throw new Error("Agent files cannot contain symbolic links");
|
|
if (entry.size === undefined || entry.mode === undefined || !entry.hash) throw new Error("Agent file metadata is incomplete");
|
|
const old = before.get(relative);
|
|
let objectKey = old?.kind === "file" && old.sha256 === entry.hash && old.size === entry.size ? old.objectKey : null;
|
|
if (!objectKey && entry.size !== 0) {
|
|
const filename = await assertInstructionPathSafe(root, relative);
|
|
const handle = await fs.open(filename, constants.O_RDONLY | constants.O_NOFOLLOW);
|
|
const source = handle.createReadStream();
|
|
const hash = createHash("sha256");
|
|
let size = 0;
|
|
const body = new Transform({ transform(chunk: Buffer, _encoding, callback) {
|
|
size += chunk.length;
|
|
if (size > entry.size!) return callback(new Error("Agent file changed during upload"));
|
|
hash.update(chunk); callback(null, chunk);
|
|
}, flush(callback) {
|
|
callback(size === entry.size && hash.digest("hex") === entry.hash ? null : new Error("Agent file changed during upload"));
|
|
} });
|
|
try {
|
|
const [result] = await Promise.all([service.putFile({ companyId: owner.companyId, namespace: `agent-files/${owner.id}`,
|
|
originalFilename: null, contentType: "application/octet-stream", body,
|
|
byteSize: entry.size, sha256: entry.hash, signal }), pipeline(source, body, { signal })]);
|
|
objectKey = result.objectKey;
|
|
} finally { source.destroy(); body.destroy(); await handle.close(); }
|
|
}
|
|
entries.push({ path: relative, kind: "file", mode: entry.mode, size: entry.size, sha256: entry.hash, objectKey });
|
|
}
|
|
if (previous && JSON.stringify(previous.entries) === JSON.stringify(entries)) {
|
|
await mark(root, previous.generation);
|
|
return;
|
|
}
|
|
const generation = randomUUID();
|
|
if (!previous) {
|
|
// This is a retry receipt for the one-time local import, not serving
|
|
// authority. Once committed, Postgres and S3 suffice without this file.
|
|
await atomicPrivateWrite(adoptionReceipt(root), JSON.stringify({ version: 1, agentCreatedAt: owner.createdAt.toISOString(),
|
|
head: { companyId: owner.companyId, agentId: owner.id, generation, entries } }));
|
|
}
|
|
await tx.insert(agentFileRoots).values({ companyId: owner.companyId, agentId: owner.id, generation, entries })
|
|
.onConflictDoUpdate({ target: [agentFileRoots.companyId, agentFileRoots.agentId], set: { generation, entries, updatedAt: new Date() } });
|
|
await mark(root, generation);
|
|
}
|