mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-18 23:08:26 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Each pull request runs the Paperclip CI gates. A pull request from a fork runs them on GitHub-hosted `ubuntu-latest` runners. > - GitHub now routes some `ubuntu-latest` jobs to the `ubuntu-26.04` image. On that image `ci / Verify Paperclip Runner (static checks)` fails for each pull request, with no relation to the change under test. > - The cause is a test fixture. Two tests copy `/bin/sleep` as a stand-in for the daemon. On that image `/bin/sleep` is a multicall binary that does not run from a copy with another name. > - #21787 starts the copy with the process name `sleep`. The copy still exits with status 1 on that image, so the two tests still fail there. > - This pull request makes the two tests copy a standalone `sleep` binary on such an image. > - The benefit is that `ci / verify` shows the state of the change again on each runner image. ## Linked Issues or Issue Description Refs #21787 and #21792. #21792 fixed the sandbox test that failed on the same image, so this pull request no longer changes that test. #21787 changed the runner staging tests, but two of them still fail on the `ubuntu-26.04` image. Refs #21688 and #21692, which show the failure. **What happened?** `ci / Verify Paperclip Runner (static checks)` fails when the job runs on the `ubuntu-26.04` runner image. Two tests in `packages/paperclip-runner/scripts/stage-runner-binary.test.mjs` fail: "atomically publishes while the previous executable is running" and "a source rebuild selects fresh dev bytes while preserving release binaries and their manifest". The same job passes on the `ubuntu-24.04` image and on the self-hosted fleet. **Expected behavior** The check gives the same result on each runner image. **Steps to reproduce** 1. Start an `ubuntu:26.04` container. 2. Run `cmp /bin/sleep /bin/echo`. The files are the same. Each is the Rust coreutils multicall binary. 3. Run `cp /bin/sleep /tmp/paperclip-runnerd && /tmp/paperclip-runnerd 30`. The output is `coreutils: unknown program 'paperclip-runnerd'` and the status is 1. 4. Run the test file from `master` in that container with Node 24. The two tests fail. **Operating system** The `ubuntu-26.04` GitHub-hosted runner image, version 20261111.196.1. ## What Changed - `packages/paperclip-runner/scripts/stage-runner-binary.test.mjs`: add `standaloneSleep`. On Linux, when `/bin/sleep` and `/bin/echo` have the same bytes, the two tests copy `/usr/bin/gnusleep` as the stand-in for the daemon. On each other system the tests use `/bin/sleep` as before. No product code changes. No workflow file changes. The branch no longer changes `runner-bridge-tools.test.ts`. ## Verification Tested revision: the head commit of this branch. - `node --test scripts/stage-runner-binary.test.mjs` in `packages/paperclip-runner`, in an `ubuntu:26.04` container with Node 24: the version from `master` fails the two tests. This version passes them. - The same command in an `ubuntu:24.04` container with Node 24: the two tests pass. - The same command on macOS: 9 of 9 tests passed. - In the two containers one other test, "a build without release daemons still compiles the Runner binary", fails because `pnpm` is not installed there. It passes on macOS. - An earlier revision of this branch, before the merge with `master`, passed `ci / Verify Paperclip Runner (static checks)` on the `ubuntu-26.04` image. ## Risks - Low risk. The change is in one test file. - The tests use `/usr/bin/gnusleep` only when the standard file is a multicall binary. If an image has a multicall binary and does not have the GNU file, the two tests fail with a missing file error, which names the cause. ## Model Used - Claude Fable 5.2 (`claude-fable-5-2`), through Claude Code, with tool use and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>