mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-08 01:57:31 +01:00
## Thinking Path > - Paperclip lets people manage agent work through the board. > - The board reads task, agent, settings, plugin, and run data from the server. > - A deploy can interrupt those reads after content is already visible. > - Local error branches can replace that content with an error or show raw codes. > - This pull request moves the remaining reads to the shared recovery behavior. > - The query-error guard prevents new local error patterns from returning. ## Linked Issues or Issue Description **What happened?** Loaded lists, settings, task panels, and manual reads could clear their content or show errors during a server restart. Some reads also disabled the shared retry policy. **Expected behavior** Keep loaded content during a temporary failure. Show the shared connection banner. Retry reads after recovery. Replace content after a real access denial or missing resource, with readable copy. **Steps to reproduce** Open a task, settings page, or run log. Return 503 with `tenant_app_unavailable` from the API. Restore the API and check that content refreshes. Repeat with 403 and 404 to check the failure state. Related merged work: Refs #15754, Refs #15772, Refs #17960. This change covers remaining reads and enforcement. Browser persistence and the outage browser suite follow separately. ## What Changed - Repair an existing PostgreSQL deadline fixture at UTC boundaries. A daily cap defers a heartbeat until both its original interval and the next UTC day allow it. Keep the counted run in its seeded day and cover noon, just before midnight and the first second after midnight with explicit clocks and real PostgreSQL. Production scheduling is unchanged. - Integrate the saved list, settings, shell, task, and manual-read recovery changes against current master. Preserve the current task, Inbox, and run-log structure. - Add `useResilientFetch` for component-local reads. Preserve loaded data, cancel stale requests, and retry through the shared connectivity policy. Keep browser and pairing capabilities in memory. - Retain run log chunks across stream changes and catch up after recovery without duplicate chunks or stalled requests. - Keep genuine authorization and missing-resource failures visible. Translate known single-word codes such as `forbidden`. Show known skills and disconnected-app failures before sibling loading states. Keep Retry bound to its failed request. - Make the query-error guard enforce by default and run it in the CI policy job. Document the narrow exceptions and the read recovery contract. - Invalidate pending OAuth discovery when the operator leaves setup or its context changes. Keep reserved-popup cleanup bound to the current attempt. ## Verification - Current read head `09d1db29dea` is merge-ready: all 59 check runs are completed (54 successful, three skipped, two neutral), the legacy Snyk status is successful, and both required `ci / verify` and `ci / e2e` gates pass. Greptile Apex reviewed this exact head at 5/5 with no unresolved threads; the branch has no merge conflicts. The current CI run is `41748339602`. - Current read head `09d1db29dea` includes master `683fa4725e9`. The latest change touches only the existing server deadline test fixture. Application source remains the previously verified `86376fa751e` revision: all 60 affected skills/disconnected-app tests and both application UI typechecks passed, along with token gates and the enforcing query-error guard. Those UI suites were not repeated for this test-only repair. - The fixture repair passes all seven deadline integration cases and the complete server typecheck, including the server test layer. The old assertion deterministically fails at 23:59:06.888 UTC; its one-second-old run also fails the first-second-of-day probe. The corrected fixture passes noon and both midnight probes. The permanent three-case coverage uses seeded 2099 clocks. - Twelve new regressions fail against the previous implementation. Both skills variants and disconnected-app pages show either request's 403 or 429 while the sibling pauses or remains fetching. Permission failures stay visible. Retry stays usable for its failed request and recovers independently. An initial test-fixture query-key typo was corrected before the passing run. The finding is replied to and resolved. Greptile reviewed prior application revision `86376fa751e` at 5/5 with no new actionable findings or unresolved threads. The current test-only head has now received its own Apex 5/5 review with no unresolved threads, and its CI is successful as recorded above. - The preceding OAuth fix passed all 237 setup tests on both application branches. Its ten regressions prove that Back, Cancel, unmount, or context changes retire initial discovery without creating a connection, caching old identities, navigating an abandoned popup, or closing a newer attempt. - Earlier master integration `e992f770339` passed all 309 tests across eight affected Slack, recovery, retry, submission and task files, plus UI typecheck, token gates, enforcing query-error scan and seven guard tests. The integration preserves Slack workspace reconnect and shared recovery, readable execution errors, source-inspection company scoping, and current submission behavior. Newly inherited retained-file recovery controls keep cached data through transient failures and hide it after definitive denial. - The preceding cache head `97c0bc3966f` passed 1,038 focused cache/write/editor/account/task/API tests. All 22 built-UI outage/write/loading cases passed in 4.7 minutes on exact browser head `b7deaaee5da`, with strict checking of all three specs. The latest skills/app rendering fix is covered by its affected component suites; those broader cases were not repeated for this separate read path. - Historical broader UI, CLI and build results and unresolved aggregate server/DB/adapter failures remain in the PR discussion. Interrupted CI runs were audited and recorded separately; they are not counted as passes. Controlled local outages do not prove hosted authentication or a real Cloud restart/deploy. Real hosted acceptance remains required after merge and deployment. Commands for the latest fix: ```sh pnpm --filter @paperclipai/ui exec vitest run src/pages/CompanySkills.test.tsx src/pages/apps/AppNotConnected.test.tsx pnpm --filter @paperclipai/ui typecheck pnpm check:token-gates node scripts/check-query-error-rendering.mjs --enforce --summary ``` ## Risks This migration touches many read surfaces. The main risks are initial loading, request cancellation, retained authorization state, and run-log paging. The tests cover those states. There are no server, schema, dependency, or API contract changes. The follow-up browser suite and hosted deploy acceptance are required before release acceptance. Recovered commits retain their original authors. If squash-merging, preserve `Co-Authored-By: Bender (Fable) <bender@agents.paperclip.ing>` and the Paperclip trailer. ## Model Used OpenAI `gpt-6.1-sol` through Codex, with xhigh reasoning effort, tool use, and code execution. The context window size is not exposed. Saved source commits keep their original authorship. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have described the issue in-PR following the bug report template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal ticket id - [x] The affected local tests pass; broader limitations are recorded above - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: devinfoley <139239+devinfoley@users.noreply.github.com> Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Bender (Fable) <bender@agents.paperclip.ing> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
988 lines
38 KiB
TypeScript
988 lines
38 KiB
TypeScript
import { TaskVoiceLauncher } from "@/components/voice/TaskVoiceLauncher";
|
||
import { useCallback, useEffect, useRef, useState } from "react";
|
||
import { useQuery, useQueryClient } from "@tanstack/react-query";
|
||
import { ExternalLink, Paperclip, Radio } from "lucide-react";
|
||
import type {
|
||
ChatPublicationState,
|
||
ChatFileTransferPhase,
|
||
IssueAttachment,
|
||
} from "@paperclipai/shared";
|
||
import {
|
||
chatEndpointsApi,
|
||
type ChatProvider,
|
||
type ChatPublicationSummary,
|
||
type ExternalChannelBindingSummary,
|
||
} from "@/api/chatEndpoints";
|
||
import { Button } from "@/components/ui/button";
|
||
import { Checkbox } from "@/components/ui/checkbox";
|
||
import { Textarea } from "@/components/ui/textarea";
|
||
import { useToast } from "@/context/ToastContext";
|
||
import { Link } from "@/lib/router";
|
||
import { cn } from "@/lib/utils";
|
||
import { queryKeys } from "@/lib/queryKeys";
|
||
import { useChatConnectorsEnabled, chatProviderVisible } from "@/hooks/useChatConnectorsEnabled";
|
||
import { issuesApi } from "@/api/issues";
|
||
import { describeError } from "@/api/errors";
|
||
import { classifySendFailure, type SendOutcome } from "@/lib/pending-send";
|
||
import { useAutoResend } from "@/hooks/useDurableSubmit";
|
||
import { useDraftOwner, useDraftOwnerReader } from "@/hooks/useDraftOwner";
|
||
import { useAccountBoundMutation } from "@/hooks/useAccountBoundMutation";
|
||
import { retryTransientOnly } from "@/lib/query-client";
|
||
import { useQueryView } from "@/components/QueryView";
|
||
import {
|
||
boardSendDraftKey,
|
||
clearBoardSendDraft,
|
||
canDismissBoardSendBatch,
|
||
readBoardSendDraft,
|
||
readBoardSendRejection,
|
||
writeBoardSendDraft,
|
||
type BoardSendRejection,
|
||
type RetainedBoardSend,
|
||
} from "./board-send-draft";
|
||
|
||
import { LegacyBoardSendNotice } from "./LegacyBoardSendNotice";
|
||
|
||
const providerNames: Record<ChatProvider, string> = {
|
||
speko: "Speko",
|
||
slack: "Slack",
|
||
github: "GitHub",
|
||
discord: "Discord",
|
||
"microsoft-teams": "Microsoft Teams",
|
||
telegram: "Telegram",
|
||
agentmail: "AgentMail",
|
||
"imessage-photon": "iMessage Photon",
|
||
};
|
||
|
||
type PublicationFeedback = {
|
||
title: string;
|
||
body: string;
|
||
tone: "info" | "success" | "warn" | "error";
|
||
};
|
||
|
||
const publicationFeedback: Record<ChatPublicationState, PublicationFeedback> = {
|
||
awaiting_consent: {
|
||
title: "Waiting for file consent",
|
||
body: "The recipient must accept the file card in Microsoft Teams. The file is not delivered yet; this send identity is kept while Paperclip waits.",
|
||
tone: "info",
|
||
},
|
||
published: {
|
||
title: "Sent to channel",
|
||
body: "The board update was published to the connected conversation.",
|
||
tone: "success",
|
||
},
|
||
pending: {
|
||
title: "Queued for channel",
|
||
body: "Delivery is still pending. Your draft is kept until Paperclip confirms publication.",
|
||
tone: "info",
|
||
},
|
||
streaming: {
|
||
title: "Publishing to channel",
|
||
body: "Delivery is still in progress. Your draft is kept until Paperclip confirms publication.",
|
||
tone: "info",
|
||
},
|
||
retry: {
|
||
title: "Delivery retry scheduled",
|
||
body: "Paperclip will retry this publication. Your draft and retry identity are kept.",
|
||
tone: "warn",
|
||
},
|
||
delivery_unknown: {
|
||
title: "Delivery not confirmed",
|
||
body: "The provider may have accepted this update. Resolve it in Activity before trying again to avoid a duplicate.",
|
||
tone: "warn",
|
||
},
|
||
failed: {
|
||
title: "Channel delivery failed",
|
||
body: "Your draft is kept. Open Activity to retry this same publication safely.",
|
||
tone: "error",
|
||
},
|
||
cancelled: {
|
||
title: "Channel delivery cancelled",
|
||
body: "Your draft is kept. Some parts may already have been published; check Activity before starting a new send.",
|
||
tone: "info",
|
||
},
|
||
};
|
||
|
||
const filePhaseLabels: Record<ChatFileTransferPhase, string> = {
|
||
consent_pending: "Consent card queued",
|
||
consent_sending: "Sending consent card",
|
||
consent_unknown: "Consent card delivery not confirmed",
|
||
awaiting_consent: "Awaiting consent",
|
||
upload_pending: "Upload queued",
|
||
uploading: "Uploading file",
|
||
upload_unknown: "File upload not confirmed",
|
||
file_info_pending: "File notification queued",
|
||
file_info_sending: "Sending file notification",
|
||
file_info_unknown: "File notification not confirmed",
|
||
delivered: "Delivered",
|
||
declined: "Declined",
|
||
expired: "Consent expired",
|
||
cancelled: "Cancelled; remote bytes may remain",
|
||
conflict: "File delivery needs review",
|
||
};
|
||
|
||
export function useIssueChatBinding(companyId: string, issueId: string) {
|
||
const { enabled, githubEnabled } = useChatConnectorsEnabled();
|
||
const queryEnabled = (enabled || githubEnabled) && Boolean(companyId && issueId) && !issueId.startsWith("chat:");
|
||
const query = useQuery({
|
||
queryKey: ["issue-chat-binding", companyId, issueId],
|
||
queryFn: () => chatEndpointsApi.getIssueBinding(issueId),
|
||
enabled: queryEnabled,
|
||
});
|
||
return {
|
||
binding: queryEnabled && chatProviderVisible(query.data?.provider, enabled, githubEnabled) ? (query.data ?? null) : null,
|
||
isLoading: queryEnabled && query.isLoading,
|
||
};
|
||
}
|
||
|
||
type ConnectedTaskProps = {
|
||
className?: string;
|
||
attachments?: IssueAttachment[];
|
||
companyId: string;
|
||
issueId: string;
|
||
issueCacheRefs?: string[];
|
||
assigneeAgentId?: string | null;
|
||
};
|
||
|
||
export function ExternallyConnectedTaskBanner(props: ConnectedTaskProps) {
|
||
const { binding } = useIssueChatBinding(props.companyId, props.issueId);
|
||
const draftOwner = useDraftOwner();
|
||
return <>
|
||
{draftOwner !== undefined && binding && binding.provider !== "speko" && binding.provider !== "agentmail" && <ConnectedTaskComposer
|
||
key={boardSendDraftKey(props.companyId, props.issueId, binding.endpointId, binding.conversationId, draftOwner)}
|
||
{...props}
|
||
binding={binding}
|
||
draftOwner={draftOwner}
|
||
/>}
|
||
<TaskVoiceLauncher companyId={props.companyId} issueId={props.issueId} agentId={props.assigneeAgentId} boundEndpointId={binding?.provider === "speko" ? binding.endpointId : undefined} />
|
||
</>;
|
||
}
|
||
|
||
function ConnectedTaskComposer({
|
||
className,
|
||
attachments = [],
|
||
companyId,
|
||
issueId,
|
||
issueCacheRefs,
|
||
binding,
|
||
draftOwner,
|
||
}: ConnectedTaskProps & { binding: ExternalChannelBindingSummary; draftOwner: string }) {
|
||
const readOwner = useDraftOwnerReader();
|
||
const { pushToast } = useToast();
|
||
const queryClient = useQueryClient();
|
||
const [composing, setComposing] = useState(false);
|
||
const [body, setBody] = useState("");
|
||
const [selectedAttachmentIds, setSelectedAttachmentIds] = useState<string[]>(
|
||
[],
|
||
);
|
||
const [publication, setPublication] = useState<ChatPublicationSummary | null>(
|
||
null,
|
||
);
|
||
const idempotencyKey = useRef<string | null>(null);
|
||
const retainedSend = useRef<RetainedBoardSend | null>(null);
|
||
const retainedScopeKey = useRef<string | null>(null);
|
||
const [unconfirmedRequest, setUnconfirmedRequest] = useState(false);
|
||
const [rejection, setRejection] = useState<BoardSendRejection | null>(null);
|
||
const [excludedAttachmentIds, setExcludedAttachmentIds] = useState<string[]>(
|
||
[],
|
||
);
|
||
const [selectionNotice, setSelectionNotice] = useState(false);
|
||
const [storageError, setStorageError] = useState<string | null>(null);
|
||
const [unownedRequest, setUnownedRequest] = useState(false);
|
||
const fileInput = useRef<HTMLInputElement>(null);
|
||
const uploadInFlight = useRef(false);
|
||
const mounted = useRef(true);
|
||
const [uploading, setUploading] = useState(false);
|
||
const [uploadError, setUploadError] = useState<string | null>(null);
|
||
const [uploadedAttachments, setUploadedAttachments] = useState<
|
||
IssueAttachment[]
|
||
>([]);
|
||
useEffect(() => {
|
||
mounted.current = true;
|
||
return () => {
|
||
mounted.current = false;
|
||
};
|
||
}, []);
|
||
const storageKey = binding
|
||
? boardSendDraftKey(
|
||
companyId,
|
||
issueId,
|
||
binding.endpointId,
|
||
binding.conversationId,
|
||
draftOwner,
|
||
)
|
||
: null;
|
||
const legacyStorageKey = boardSendDraftKey(companyId, issueId, binding.endpointId, binding.conversationId);
|
||
const loadedStorageKey = useRef<string | null>(null);
|
||
useEffect(() => {
|
||
if (!storageKey || loadedStorageKey.current === storageKey) return;
|
||
loadedStorageKey.current = storageKey;
|
||
try {
|
||
if (sessionStorage.getItem(legacyStorageKey) !== null) {
|
||
setUnownedRequest(true);
|
||
setStorageError("An earlier update has an unknown sender. Open Activity to check its delivery before starting a new update.");
|
||
setComposing(true);
|
||
return;
|
||
}
|
||
const saved = readBoardSendDraft(storageKey);
|
||
retainedScopeKey.current = storageKey;
|
||
retainedSend.current = saved;
|
||
idempotencyKey.current = saved?.idempotencyKey ?? null;
|
||
setBody(saved?.body ?? "");
|
||
setSelectedAttachmentIds(saved?.attachmentIds ?? []);
|
||
setPublication(saved?.publication ?? null);
|
||
setUnconfirmedRequest(
|
||
Boolean(saved && !saved.publication && !saved.rejection),
|
||
);
|
||
setRejection(saved?.rejection ?? null);
|
||
setComposing(Boolean(saved));
|
||
setStorageError(null);
|
||
} catch {
|
||
setStorageError(
|
||
"Saved delivery identity could not be read. Check Activity and restore browser storage before starting another send.",
|
||
);
|
||
setComposing(true);
|
||
}
|
||
}, [legacyStorageKey, storageKey, unownedRequest]);
|
||
const deliveryScopeReady = Boolean(
|
||
storageKey &&
|
||
loadedStorageKey.current === storageKey &&
|
||
retainedScopeKey.current === storageKey,
|
||
);
|
||
const invalidateTask = useCallback(() => {
|
||
for (const ref of new Set([issueId, ...(issueCacheRefs ?? [])])) {
|
||
for (const queryKey of [
|
||
queryKeys.issues.comments(ref),
|
||
queryKeys.issues.attachments(ref),
|
||
queryKeys.issues.detail(ref),
|
||
queryKeys.issues.activity(ref),
|
||
]) {
|
||
void queryClient.invalidateQueries({ queryKey });
|
||
}
|
||
}
|
||
}, [issueId, issueCacheRefs, queryClient]);
|
||
const finishPublication = useCallback(() => {
|
||
if (storageKey) {
|
||
try {
|
||
clearBoardSendDraft(storageKey);
|
||
} catch {
|
||
/* The retained anchor remains safe to recheck after reload. */
|
||
}
|
||
}
|
||
retainedSend.current = null;
|
||
setUnconfirmedRequest(false);
|
||
setRejection(null);
|
||
setSelectionNotice(false);
|
||
setPublication(null);
|
||
idempotencyKey.current = null;
|
||
setBody("");
|
||
setSelectedAttachmentIds([]);
|
||
setUploadedAttachments([]);
|
||
setUploadError(null);
|
||
setComposing(false);
|
||
invalidateTask();
|
||
pushToast(publicationFeedback.published);
|
||
}, [invalidateTask, pushToast, storageKey]);
|
||
// Keep the first returned ID as the anchor. A batch's blocking row may
|
||
// change as text and files finish; no read is allowed to submit another send.
|
||
const publicationStatus = useQuery({
|
||
queryKey: [
|
||
"chat-publication-batch",
|
||
draftOwner,
|
||
companyId,
|
||
binding?.endpointId,
|
||
binding?.conversationId,
|
||
publication?.id,
|
||
],
|
||
queryFn: () =>
|
||
chatEndpointsApi.getPublicationBatchStatus(
|
||
binding!.endpointId,
|
||
binding!.conversationId,
|
||
publication!.id,
|
||
),
|
||
enabled: deliveryScopeReady && Boolean(publication),
|
||
staleTime: 0,
|
||
refetchInterval: 2_000,
|
||
refetchIntervalInBackground: false,
|
||
retry: retryTransientOnly(0),
|
||
});
|
||
// Read publication status through the shared view: the receipt render uses
|
||
// the cached batch during transient refetch failures,and a no-data failure
|
||
// drops into readable copy.
|
||
const publicationStatusView = useQueryView(publicationStatus);
|
||
useEffect(() => {
|
||
const batch = publicationStatus.data;
|
||
if (
|
||
publication &&
|
||
batch &&
|
||
batch.total > 0 &&
|
||
batch.published === batch.total &&
|
||
batch.publication.state === "published"
|
||
) {
|
||
finishPublication();
|
||
}
|
||
}, [publication, publicationStatus.data, finishPublication]);
|
||
const publish = useAccountBoundMutation({
|
||
mutationFn: (input: {
|
||
attachmentIds: string[];
|
||
body: string;
|
||
idempotencyKey: string;
|
||
endpointId: string;
|
||
conversationId: string;
|
||
}) => {
|
||
if (readOwner() !== draftOwner) throw new DOMException("Your account changed. Reopen this task to send from your current account.", "AbortError");
|
||
return chatEndpointsApi.publishBoardMessage(
|
||
input.endpointId,
|
||
input.conversationId,
|
||
input.body,
|
||
input.idempotencyKey,
|
||
input.attachmentIds,
|
||
);
|
||
},
|
||
onSuccess: (result) => {
|
||
invalidateTask();
|
||
const feedback = publicationFeedback[result.state];
|
||
setPublication(result.state === "published" ? null : result);
|
||
if (result.state === "published") {
|
||
finishPublication();
|
||
return;
|
||
}
|
||
setUnconfirmedRequest(false);
|
||
if (storageKey && retainedSend.current) {
|
||
retainedSend.current = {
|
||
...retainedSend.current,
|
||
publication: {
|
||
id: result.id,
|
||
state: result.state,
|
||
attempts: result.attempts,
|
||
},
|
||
};
|
||
try {
|
||
writeBoardSendDraft(storageKey, retainedSend.current);
|
||
} catch {
|
||
// The pre-POST payload/key is already persisted. It remains a safe,
|
||
// explicit same-request retry when the publication ID cannot be saved.
|
||
}
|
||
}
|
||
pushToast({
|
||
...feedback,
|
||
action: {
|
||
label: "View activity",
|
||
href: `/apps/chat/${binding!.endpointId}/activity`,
|
||
},
|
||
});
|
||
},
|
||
onError: (error, request) => {
|
||
const rejected = readBoardSendRejection(error, request);
|
||
if (rejected && retainedSend.current && storageKey) {
|
||
const saved = { ...retainedSend.current, rejection: rejected };
|
||
try {
|
||
// Keep the negative receipt through reload before offering a new key.
|
||
writeBoardSendDraft(storageKey, saved);
|
||
} catch {
|
||
setStorageError(
|
||
"The rejected send could not be saved. Restore browser storage, then retry this same request to recover its receipt.",
|
||
);
|
||
return;
|
||
}
|
||
retainedSend.current = saved;
|
||
setRejection(rejected);
|
||
setUnconfirmedRequest(false);
|
||
invalidateTask();
|
||
pushToast({
|
||
title: "Update was not sent",
|
||
body: "A selected file already belongs to another comment. Edit the rejected send to correct the selection.",
|
||
tone: "error",
|
||
});
|
||
return;
|
||
}
|
||
// Outages and lost receipts resend on their own with the same request
|
||
// identity; the inline notice covers them.
|
||
if (classifySendFailure(error) === "pending") return;
|
||
pushToast({
|
||
title: "Couldn't confirm channel delivery",
|
||
body: `${describeError(error).body} Your draft is kept; retrying here reuses the same request identity.`,
|
||
tone: "error",
|
||
});
|
||
},
|
||
});
|
||
// A send that failed with an outage or a lost receipt in this session
|
||
// resends with its saved key; the server returns the original publication
|
||
// instead of queueing another message. A send restored after reload has an
|
||
// unknown outcome and waits for an explicit retry.
|
||
const resendWaiting = Boolean(
|
||
deliveryScopeReady &&
|
||
unconfirmedRequest &&
|
||
retainedSend.current &&
|
||
!rejection &&
|
||
!publication &&
|
||
!storageError &&
|
||
publish.status === "error" &&
|
||
classifySendFailure(publish.error) === "pending",
|
||
);
|
||
const autoResend = useAutoResend({
|
||
sourceId: `board-send:${storageKey ?? issueId}`,
|
||
active: resendWaiting,
|
||
resend: async (): Promise<SendOutcome> => {
|
||
const input = retainedSend.current;
|
||
if (!input || readOwner() !== draftOwner) return "rejected";
|
||
try {
|
||
await publish.mutateAsync({
|
||
...input,
|
||
endpointId: binding.endpointId,
|
||
conversationId: binding.conversationId,
|
||
});
|
||
return "sent";
|
||
} catch (error) {
|
||
return classifySendFailure(error);
|
||
}
|
||
},
|
||
});
|
||
// Automatic resends gave up while online; only Resend now tries again.
|
||
const resendStalled = resendWaiting && autoResend.stalled && !autoResend.resending;
|
||
const uploadDisabled = Boolean(
|
||
retainedSend.current ||
|
||
publication ||
|
||
publish.isPending ||
|
||
publish.isError ||
|
||
unconfirmedRequest ||
|
||
storageError ||
|
||
!deliveryScopeReady ||
|
||
uploading,
|
||
);
|
||
async function uploadFile(file: File) {
|
||
if (uploadDisabled || uploadInFlight.current || retainedSend.current)
|
||
return;
|
||
uploadInFlight.current = true;
|
||
setUploading(true);
|
||
setUploadError(null);
|
||
try {
|
||
const attachment = await issuesApi.uploadAttachment(
|
||
companyId,
|
||
issueId,
|
||
file,
|
||
);
|
||
if (!mounted.current) return;
|
||
setUploadedAttachments((current) => [...current, attachment]);
|
||
setSelectedAttachmentIds((current) => [...current, attachment.id]);
|
||
idempotencyKey.current = null;
|
||
} catch (error) {
|
||
if (mounted.current) {
|
||
setUploadError(
|
||
`${describeError(error).body} No channel message was sent. Check task files before retrying the upload.`,
|
||
);
|
||
}
|
||
} finally {
|
||
uploadInFlight.current = false;
|
||
if (mounted.current) setUploading(false);
|
||
// An interrupted response may still have stored the file on this task.
|
||
invalidateTask();
|
||
}
|
||
}
|
||
// Keep newly uploaded files usable before the task refetch completes. Once
|
||
// present, server metadata wins (especially a file bound to a sent comment).
|
||
const taskAttachments = [
|
||
...new Map(
|
||
[...uploadedAttachments, ...attachments].map((attachment) => [
|
||
attachment.id,
|
||
attachment,
|
||
]),
|
||
).values(),
|
||
];
|
||
useEffect(() => {
|
||
// Metadata may arrive after this file was selected but before Send. Never
|
||
// silently keep a now-hidden selection, and never rewrite a retained send.
|
||
if (retainedSend.current) return;
|
||
const newlyBound = attachments
|
||
.filter((file) => file.issueCommentId !== null)
|
||
.map((file) => file.id);
|
||
if (!selectedAttachmentIds.some((id) => newlyBound.includes(id))) return;
|
||
setSelectedAttachmentIds((current) =>
|
||
current.filter((id) => !newlyBound.includes(id)),
|
||
);
|
||
setSelectionNotice(true);
|
||
idempotencyKey.current = null;
|
||
}, [attachments, selectedAttachmentIds]);
|
||
const showingRetainedFiles = Boolean(retainedSend.current);
|
||
// Comment binding removes files from new-send eligibility, not from the
|
||
// immutable receipt for the current send. Saved names survive reload while
|
||
// task metadata is loading (or a selected attachment has since been removed).
|
||
const visibleAttachments = retainedSend.current
|
||
? retainedSend.current.attachmentIds.map((id) => ({
|
||
id,
|
||
originalFilename:
|
||
retainedSend.current?.attachmentNames?.find((file) => file.id === id)
|
||
?.name ??
|
||
taskAttachments.find((attachment) => attachment.id === id)
|
||
?.originalFilename ??
|
||
"Selected task file (details unavailable)",
|
||
}))
|
||
: taskAttachments.filter(
|
||
(attachment) =>
|
||
attachment.issueCommentId === null &&
|
||
!excludedAttachmentIds.includes(attachment.id),
|
||
);
|
||
const currentPublication = publicationStatus.data?.publication ?? publication;
|
||
const batch = publicationStatus.data;
|
||
const dismissible =
|
||
Boolean(publicationStatus.data) &&
|
||
!publicationStatus.isFetching &&
|
||
canDismissBoardSendBatch(batch);
|
||
const mixedTerminal =
|
||
canDismissBoardSendBatch(batch) && batch!.published < batch!.total;
|
||
const currentFeedback = mixedTerminal
|
||
? {
|
||
title: "Delivery settled with mixed outcomes",
|
||
body: "Not every part was confirmed delivered. Review the outcomes below; dismissing this receipt does not resend anything.",
|
||
tone: "info" as const,
|
||
}
|
||
: currentPublication?.state === "cancelled" &&
|
||
(batch?.awaitingConsent ?? 0) > 0
|
||
? {
|
||
title: "Waiting for remaining file consent",
|
||
body: "Some parts have settled. The remaining file cards still need the recipient's response; this send stays locked until the whole batch is resolved.",
|
||
tone: "info" as const,
|
||
}
|
||
: currentPublication
|
||
? publicationFeedback[currentPublication.state]
|
||
: null;
|
||
const activityPath = `/apps/chat/${binding.endpointId}/activity`;
|
||
return (
|
||
<section
|
||
aria-label="External conversation"
|
||
className={cn("task-context-notice space-y-3", className)}
|
||
>
|
||
<div className="flex flex-wrap items-center gap-3">
|
||
<div className="flex min-w-0 flex-1 basis-64 items-center gap-3">
|
||
<Radio className="h-4 w-4 shrink-0 text-muted-foreground" />
|
||
<div className="min-w-0 flex-1">
|
||
<p className="font-medium">
|
||
Connected to {providerNames[binding.provider]}
|
||
</p>
|
||
<p className="truncate text-xs text-muted-foreground">
|
||
{binding.externalLabel} · {binding.provider === "slack"
|
||
? "Messages you send here and agent replies are also posted to Slack."
|
||
: "Agent assignment is fixed for this external task."}
|
||
</p>
|
||
</div>
|
||
</div>
|
||
<div className="flex min-w-0 flex-wrap items-center gap-2">
|
||
{binding.externalUrl && (
|
||
<Button asChild size="sm" variant="outline">
|
||
<a href={binding.externalUrl} target="_blank" rel="noreferrer">
|
||
Open {providerNames[binding.provider]} <ExternalLink />
|
||
</a>
|
||
</Button>
|
||
)}
|
||
<Button
|
||
size="sm"
|
||
variant="outline"
|
||
onClick={() => setComposing((value) => !value)}
|
||
>
|
||
Send to channel
|
||
</Button>
|
||
<Button asChild size="sm" variant="ghost">
|
||
<Link to={`/apps/chat/${binding.endpointId}/conversations`}>
|
||
Connection
|
||
</Link>
|
||
</Button>
|
||
</div>
|
||
</div>
|
||
{composing && (
|
||
<div className="space-y-2 border-t border-border pt-3">
|
||
<label
|
||
className="text-xs font-medium"
|
||
htmlFor="external-board-update"
|
||
>
|
||
Board update
|
||
</label>
|
||
<Textarea
|
||
id="external-board-update"
|
||
value={body}
|
||
disabled={
|
||
Boolean(publication) ||
|
||
Boolean(rejection) ||
|
||
publish.isError ||
|
||
unconfirmedRequest ||
|
||
Boolean(storageError) ||
|
||
!deliveryScopeReady
|
||
}
|
||
onChange={(event) => {
|
||
setBody(event.target.value);
|
||
idempotencyKey.current = null;
|
||
publish.reset();
|
||
}}
|
||
placeholder="Write only what should be visible in the provider conversation."
|
||
/>
|
||
{selectedAttachmentIds.length > 0 && !body.trim() && (
|
||
<p className="text-xs text-muted-foreground">
|
||
Add a message to send with your files.
|
||
</p>
|
||
)}
|
||
<div className="flex flex-wrap items-center gap-2">
|
||
<input
|
||
ref={fileInput}
|
||
type="file"
|
||
className="hidden"
|
||
aria-label="Attach file to channel update"
|
||
disabled={uploadDisabled}
|
||
onChange={(event) => {
|
||
const file = event.target.files?.[0];
|
||
event.target.value = "";
|
||
if (file) void uploadFile(file);
|
||
}}
|
||
/>
|
||
<Button
|
||
type="button"
|
||
size="sm"
|
||
variant="outline"
|
||
disabled={uploadDisabled}
|
||
onClick={() => fileInput.current?.click()}
|
||
>
|
||
<Paperclip />
|
||
{uploading ? "Uploading…" : "Attach file"}
|
||
</Button>
|
||
<p className="text-xs text-muted-foreground">
|
||
Files stay on this task until you send them to the channel.
|
||
</p>
|
||
</div>
|
||
{uploadError && (
|
||
<p role="alert" className="text-xs text-destructive">
|
||
{uploadError}
|
||
</p>
|
||
)}
|
||
{selectionNotice && (
|
||
<p role="status" className="text-xs text-muted-foreground">
|
||
A file already attached to another comment was removed from this
|
||
selection. Attach a new copy or share the task link; your message
|
||
is unchanged.
|
||
</p>
|
||
)}
|
||
{visibleAttachments.length > 0 && (
|
||
<fieldset
|
||
className="space-y-2 rounded-md border border-border bg-background p-3"
|
||
disabled={
|
||
showingRetainedFiles ||
|
||
Boolean(publication) ||
|
||
publish.isError ||
|
||
unconfirmedRequest ||
|
||
Boolean(storageError) ||
|
||
!deliveryScopeReady
|
||
}
|
||
>
|
||
<legend className="px-1 text-xs font-medium">
|
||
{showingRetainedFiles
|
||
? "Files in this send"
|
||
: "Include task files"}
|
||
</legend>
|
||
<p className="text-xs text-muted-foreground">
|
||
{binding.provider === "github"
|
||
? "GitHub Apps cannot upload file bytes in comments. Checked files stay on the Paperclip task; GitHub receives an authenticated task link when this Board has a public URL, or a private-task notice otherwise."
|
||
: binding.provider === "microsoft-teams" &&
|
||
!showingRetainedFiles
|
||
? "In personal Teams chats, recipients accept each file before upload. Channels and group chats receive supported images directly; other files stay on the task, with a task link or private-task notice."
|
||
: showingRetainedFiles
|
||
? "These are the files selected for this send. Selection is locked until delivery is resolved."
|
||
: "Only checked files will be published to the external conversation."}
|
||
</p>
|
||
<div className="space-y-2">
|
||
{visibleAttachments.map((attachment) => {
|
||
const label =
|
||
attachment.originalFilename ?? "Unnamed attachment";
|
||
return (
|
||
<label
|
||
className="flex items-center gap-2 text-xs"
|
||
key={attachment.id}
|
||
>
|
||
<Checkbox
|
||
disabled={showingRetainedFiles}
|
||
checked={selectedAttachmentIds.includes(attachment.id)}
|
||
onCheckedChange={(checked) => {
|
||
setSelectedAttachmentIds((current) =>
|
||
checked === true
|
||
? [...current, attachment.id]
|
||
: current.filter((id) => id !== attachment.id),
|
||
);
|
||
idempotencyKey.current = null;
|
||
publish.reset();
|
||
}}
|
||
/>
|
||
<Paperclip className="h-3.5 w-3.5 text-muted-foreground" />
|
||
<span className="truncate">{label}</span>
|
||
</label>
|
||
);
|
||
})}
|
||
</div>
|
||
</fieldset>
|
||
)}
|
||
{storageError && (
|
||
<p role="alert" className="text-xs text-destructive">
|
||
{storageError}{" "}
|
||
<Link className="underline underline-offset-4" to={activityPath}>Open Activity</Link>
|
||
</p>
|
||
)}
|
||
{unownedRequest && <LegacyBoardSendNotice onDiscard={() => {
|
||
if (readOwner() !== draftOwner) return;
|
||
try { clearBoardSendDraft(legacyStorageKey); }
|
||
catch {
|
||
setStorageError("Saved delivery record could not be discarded. Restore browser storage, then try again.");
|
||
return;
|
||
}
|
||
loadedStorageKey.current = null;
|
||
setUnownedRequest(false);
|
||
setStorageError(null);
|
||
}} />}
|
||
{rejection && (
|
||
<div
|
||
role="alert"
|
||
className="space-y-1 rounded-md border border-border bg-background p-3 text-xs"
|
||
>
|
||
<p className="font-medium">Update was not sent</p>
|
||
<p className="text-muted-foreground">
|
||
A selected file already belongs to another comment. This request
|
||
was rejected before any channel message was queued. Your exact
|
||
draft is kept.
|
||
</p>
|
||
<Button
|
||
size="sm"
|
||
variant="outline"
|
||
disabled={Boolean(storageError)}
|
||
onClick={() => {
|
||
if (!storageKey || !retainedSend.current?.rejection) return;
|
||
try {
|
||
clearBoardSendDraft(storageKey);
|
||
} catch {
|
||
setStorageError(
|
||
"Saved rejection could not be cleared. Restore browser storage before editing this send.",
|
||
);
|
||
return;
|
||
}
|
||
const invalidIds =
|
||
retainedSend.current.rejection.attachmentIds;
|
||
setExcludedAttachmentIds((current) => [
|
||
...new Set([...current, ...invalidIds]),
|
||
]);
|
||
setSelectedAttachmentIds((current) =>
|
||
current.filter((id) => !invalidIds.includes(id)),
|
||
);
|
||
setUploadedAttachments((current) =>
|
||
current.filter((file) => !invalidIds.includes(file.id)),
|
||
);
|
||
retainedSend.current = null;
|
||
idempotencyKey.current = null;
|
||
setRejection(null);
|
||
setUnconfirmedRequest(false);
|
||
setSelectionNotice(true);
|
||
publish.reset();
|
||
}}
|
||
>
|
||
Edit rejected send
|
||
</Button>
|
||
</div>
|
||
)}
|
||
{!rejection &&
|
||
(publish.isError || unconfirmedRequest) &&
|
||
// An automatic resend keeps the waiting notice up while it runs.
|
||
(!publish.isPending || autoResend.resending) &&
|
||
!publication && (
|
||
<div
|
||
role="alert"
|
||
className="space-y-1 rounded-md border border-border bg-background p-3 text-xs"
|
||
>
|
||
<p className="font-medium">
|
||
{resendStalled
|
||
? "Couldn’t send this update yet."
|
||
: resendWaiting || autoResend.resending
|
||
? "Sending when reconnected…"
|
||
: "Delivery result not confirmed"}
|
||
</p>
|
||
<p className="text-muted-foreground">
|
||
{resendStalled
|
||
? "Your exact draft and request identity are kept. Automatic resends stopped; choose Resend now to try again without creating a duplicate."
|
||
: resendWaiting || autoResend.resending
|
||
? "Your exact draft and request identity are kept. It resends on its own without creating a duplicate."
|
||
: "Your exact draft and request identity are kept. Retry safely to learn the authoritative publication state without creating a duplicate."}
|
||
</p>
|
||
<Link
|
||
className="inline-block font-medium underline underline-offset-4"
|
||
to={activityPath}
|
||
>
|
||
Open Activity
|
||
</Link>
|
||
</div>
|
||
)}
|
||
{publication && currentPublication && currentFeedback && (
|
||
<div
|
||
role={
|
||
currentPublication.state === "failed" ||
|
||
currentPublication.state === "delivery_unknown"
|
||
? "alert"
|
||
: "status"
|
||
}
|
||
className="space-y-1 rounded-md border border-border bg-background p-3 text-xs"
|
||
>
|
||
<p className="font-medium">{currentFeedback.title}</p>
|
||
<p className="text-muted-foreground">{currentFeedback.body}</p>
|
||
{batch && (
|
||
<p className="text-muted-foreground">
|
||
{batch.declined !== undefined &&
|
||
batch.expired !== undefined &&
|
||
batch.cancelled !== undefined &&
|
||
batch.awaitingConsent !== undefined
|
||
? [
|
||
`${batch.published} published`,
|
||
...(batch.awaitingConsent
|
||
? [`${batch.awaitingConsent} awaiting consent`]
|
||
: []),
|
||
...(batch.declined
|
||
? [`${batch.declined} declined`]
|
||
: []),
|
||
...(batch.expired ? [`${batch.expired} expired`] : []),
|
||
...(batch.cancelled
|
||
? [`${batch.cancelled} cancelled`]
|
||
: []),
|
||
].join(" · ")
|
||
: `${batch.published} of ${batch.total} parts published.`}
|
||
</p>
|
||
)}
|
||
{batch?.parts?.some((part) => part.fileTransfer) && (
|
||
<ul
|
||
className="space-y-1 text-muted-foreground"
|
||
aria-label="File delivery outcomes"
|
||
>
|
||
{batch.parts
|
||
.filter((part) => part.fileTransfer)
|
||
.map((part) => (
|
||
<li key={part.id}>
|
||
{part.fileTransfer!.filename} —{" "}
|
||
{filePhaseLabels[part.fileTransfer!.phase]}
|
||
</li>
|
||
))}
|
||
</ul>
|
||
)}
|
||
{publicationStatusView.kind === "error" && (
|
||
<p role="alert" className="text-muted-foreground">
|
||
Delivery status could not be refreshed. Your draft is kept;
|
||
Paperclip will check again without sending another update.
|
||
</p>
|
||
)}
|
||
{currentPublication.redactedError && (
|
||
<p className="text-muted-foreground">
|
||
Provider detail: {currentPublication.redactedError}
|
||
</p>
|
||
)}
|
||
<Link
|
||
className="inline-block font-medium underline underline-offset-4"
|
||
to={activityPath}
|
||
>
|
||
Open Activity
|
||
</Link>
|
||
{dismissible && (
|
||
<Button
|
||
className="ml-3"
|
||
size="sm"
|
||
variant="ghost"
|
||
onClick={() => {
|
||
if (storageKey) {
|
||
try {
|
||
clearBoardSendDraft(storageKey);
|
||
} catch {
|
||
setStorageError(
|
||
"Saved delivery identity could not be cleared. Restore browser storage before starting another send.",
|
||
);
|
||
return;
|
||
}
|
||
}
|
||
setStorageError(null);
|
||
retainedSend.current = null;
|
||
setUnconfirmedRequest(false);
|
||
setPublication(null);
|
||
setBody("");
|
||
setSelectedAttachmentIds([]);
|
||
setUploadedAttachments([]);
|
||
setUploadError(null);
|
||
idempotencyKey.current = null;
|
||
publish.reset();
|
||
}}
|
||
>
|
||
Dismiss delivery receipt
|
||
</Button>
|
||
)}
|
||
</div>
|
||
)}
|
||
<div className="flex items-center justify-between gap-3">
|
||
<p className="text-xs text-muted-foreground">
|
||
{binding.provider === "slack"
|
||
? "Your message is posted to Slack with your name and starts the agent."
|
||
: "Ordinary board comments remain Paperclip-only."}
|
||
</p>
|
||
<Button
|
||
size="sm"
|
||
disabled={
|
||
!body.trim() ||
|
||
publish.isPending ||
|
||
uploading ||
|
||
Boolean(publication) ||
|
||
Boolean(rejection) ||
|
||
Boolean(storageError) ||
|
||
!deliveryScopeReady
|
||
}
|
||
onClick={() => {
|
||
if (
|
||
uploadInFlight.current ||
|
||
readOwner() !== draftOwner ||
|
||
!storageKey ||
|
||
loadedStorageKey.current !== storageKey ||
|
||
retainedScopeKey.current !== storageKey
|
||
)
|
||
return;
|
||
if (resendWaiting) {
|
||
// Same saved request; also restarts the automatic resends.
|
||
autoResend.resendNow();
|
||
return;
|
||
}
|
||
idempotencyKey.current ??= crypto.randomUUID();
|
||
const input = retainedSend.current ?? {
|
||
attachmentIds: selectedAttachmentIds,
|
||
attachmentNames: selectedAttachmentIds.map((id) => ({
|
||
id,
|
||
name:
|
||
taskAttachments.find((attachment) => attachment.id === id)
|
||
?.originalFilename ?? "Unnamed attachment",
|
||
})),
|
||
body: body.trim(),
|
||
idempotencyKey: idempotencyKey.current,
|
||
publication: null,
|
||
};
|
||
try {
|
||
if (!storageKey) throw new Error("Missing delivery scope");
|
||
writeBoardSendDraft(storageKey, input);
|
||
} catch {
|
||
setStorageError(
|
||
"Browser storage could not preserve this delivery identity. No update was sent. Restore browser storage, then reload to try again.",
|
||
);
|
||
return;
|
||
}
|
||
retainedSend.current = input;
|
||
setUnconfirmedRequest(true);
|
||
publish.mutate({
|
||
...input,
|
||
endpointId: binding.endpointId,
|
||
conversationId: binding.conversationId,
|
||
});
|
||
}}
|
||
>
|
||
{publish.isPending
|
||
? "Sending…"
|
||
: resendWaiting
|
||
? "Resend now"
|
||
: !rejection && (publish.isError || unconfirmedRequest)
|
||
? "Retry safely"
|
||
: "Send to channel"}
|
||
</Button>
|
||
</div>
|
||
</div>
|
||
)}
|
||
</section>
|
||
);
|
||
}
|