mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-29 12:59:13 +01:00
## Thinking Path > - Paperclip is the open source control plane people use to coordinate AI agents, issues, approvals, comments, and work products. > - The involved subsystem is issue context: markdown links, issue properties, related work, lists, filters, inbox/sidebar status, and plugin-provided external context. > - The gap is that URLs to external systems currently remain mostly plain links, so humans and agents must manually open them to understand status, identity, and liveness. > - This matters because external work objects such as GitHub issues and pull requests are part of the operational state of a Paperclip company. > - The implementation keeps core provider-neutral: shared contracts, storage, sync, routes, and UI surfaces live in core while providers can contribute detection and status resolution. > - This pull request adds the external object reference foundation, GitHub provider support, issue-surface rendering, filters, sidebar/list/inbox signals, and test/story coverage. > - The benefit is that linked external work becomes inspectable Paperclip context without hardcoding every provider directly into the UI. ## Linked Issues or Issue Description No public GitHub issue exists for this work. Feature request: - Problem: URLs in Paperclip issues, comments, documents, and related surfaces do not expose provider status or object identity inline. - Proposed behavior: detect supported external object URLs, persist normalized references, refresh provider status, and render concise status-aware links across issue surfaces. - Users affected: board users, agents, and maintainers who triage issues containing external work links. - Acceptance: external object references are company-scoped, provider-extensible, visible in key issue surfaces, filterable where relevant, and covered by focused shared/server/UI tests. Related PR search: - No open duplicate PRs found for `external object references`. - Closed related prior attempt: #4556. ## What Changed - Added shared external-object contracts, validators, status/liveness helpers, and plugin protocol declarations. - Added database schema and additive migrations for external objects, source mentions, and display metadata. - Added server services/routes for detecting, syncing, summarizing, refreshing, and resolving external objects across issues, documents, comments, projects, and plugins. - Added a GitHub external-object provider plus plugin SDK authoring docs. - Wired UI presentation across markdown links, comments, issue chat, documents, properties, related work, issue rows, filters, inbox/sidebar badges, and Storybook stories. - Rebasing cleanup: moved the branch onto current `master`, repaired stale worktree provision config, hardened environment-sensitive tests/mocks, and removed committed screenshot artifacts from the PR branch to keep the reviewable file set below tool limits. ## Verification - `pnpm exec vitest run packages/shared/src/external-objects.test.ts server/src/__tests__/external-object-routes.test.ts server/src/__tests__/external-objects-service.test.ts ui/src/components/ExternalObjectPill.test.tsx ui/src/lib/external-objects.test.ts` passed after rebasing: 5 files, 56 tests. - Historical branch verification before this PR creation included `pnpm test:run`, `pnpm -r typecheck`, and `pnpm build`; this PR body does not claim those were rerun after the final rebase. ## Risks - Medium: this adds a new cross-surface sync path on issue/document/comment writes. The implementation uses safe sync wrappers so external-object failures warn instead of blocking core mutations. - Medium: the migrations introduce new tables and indexes. They are additive and company-scoped. - Medium: provider-specific URL parsing can miss or misclassify edge cases. Shared canonicalization tests and provider tests cover current GitHub shapes. - Low: UI badge/filter behavior could add visual noise for object-heavy issues; component tests and Storybook stories cover the intended surfaces. > Roadmap checked: `ROADMAP.md` references the plugin system as the current extension path and does not list a duplicate core feature. Related long-range docs discuss external references, work products, preview URLs, and plugin extension points; this PR implements the scoped external-object reference foundation. ## Model Used OpenAI Codex, GPT-5 coding-agent runtime, with shell and GitHub CLI tool use. Reasoning mode: medium. Exact deployed runtime model ID and context window were not exposed in the environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
383 lines
13 KiB
TypeScript
383 lines
13 KiB
TypeScript
/**
|
|
* `definePlugin` — the top-level helper for authoring a Paperclip plugin.
|
|
*
|
|
* Plugin authors call `definePlugin()` and export the result as the default
|
|
* export from their worker entrypoint. The host imports the worker module,
|
|
* calls `setup()` with a `PluginContext`, and from that point the plugin
|
|
* responds to events, jobs, webhooks, and UI requests through the context.
|
|
*
|
|
* @see PLUGIN_SPEC.md §14.1 — Example SDK Shape
|
|
*
|
|
* @example
|
|
* ```ts
|
|
* // dist/worker.ts
|
|
* import { definePlugin } from "@paperclipai/plugin-sdk";
|
|
*
|
|
* export default definePlugin({
|
|
* async setup(ctx) {
|
|
* ctx.logger.info("Linear sync plugin starting");
|
|
*
|
|
* // Subscribe to events
|
|
* ctx.events.on("issue.created", async (event) => {
|
|
* const config = await ctx.config.get();
|
|
* await ctx.http.fetch(`https://api.linear.app/...`, {
|
|
* method: "POST",
|
|
* headers: { Authorization: `Bearer ${await ctx.secrets.resolve(config.apiKeyRef as string)}` },
|
|
* body: JSON.stringify({ title: event.payload.title }),
|
|
* });
|
|
* });
|
|
*
|
|
* // Register a job handler
|
|
* ctx.jobs.register("full-sync", async (job) => {
|
|
* ctx.logger.info("Running full-sync job", { runId: job.runId });
|
|
* // ... sync logic
|
|
* });
|
|
*
|
|
* // Register data for the UI
|
|
* ctx.data.register("sync-health", async ({ companyId }) => {
|
|
* const state = await ctx.state.get({
|
|
* scopeKind: "company",
|
|
* scopeId: String(companyId),
|
|
* stateKey: "last-sync",
|
|
* });
|
|
* return { lastSync: state };
|
|
* });
|
|
* },
|
|
* });
|
|
* ```
|
|
*/
|
|
|
|
import type { PluginContext } from "./types.js";
|
|
import type {
|
|
PluginEnvironmentAcquireLeaseParams,
|
|
PluginEnvironmentDestroyLeaseParams,
|
|
PluginEnvironmentExecuteParams,
|
|
PluginEnvironmentExecuteResult,
|
|
PluginEnvironmentLease,
|
|
PluginEnvironmentProbeParams,
|
|
PluginEnvironmentProbeResult,
|
|
PluginEnvironmentRealizeWorkspaceParams,
|
|
PluginEnvironmentRealizeWorkspaceResult,
|
|
PluginEnvironmentReleaseLeaseParams,
|
|
PluginEnvironmentResumeLeaseParams,
|
|
PluginEnvironmentValidateConfigParams,
|
|
PluginEnvironmentValidationResult,
|
|
DetectExternalObjectsParams,
|
|
DetectExternalObjectsResult,
|
|
ResolveExternalObjectParams,
|
|
PluginExternalObjectResolveResult,
|
|
RefreshExternalObjectsParams,
|
|
RefreshExternalObjectsResult,
|
|
} from "./protocol.js";
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Health check result
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Optional plugin-reported diagnostics returned from the `health()` RPC method.
|
|
*
|
|
* @see PLUGIN_SPEC.md §13.2 — `health`
|
|
*/
|
|
export interface PluginHealthDiagnostics {
|
|
/** Machine-readable status: `"ok"` | `"degraded"` | `"error"`. */
|
|
status: "ok" | "degraded" | "error";
|
|
/** Human-readable description of the current health state. */
|
|
message?: string;
|
|
/** Plugin-reported key-value diagnostics (e.g. connection status, queue depth). */
|
|
details?: Record<string, unknown>;
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Config validation result
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Result returned from the `validateConfig()` RPC method.
|
|
*
|
|
* @see PLUGIN_SPEC.md §13.3 — `validateConfig`
|
|
*/
|
|
export interface PluginConfigValidationResult {
|
|
/** Whether the config is valid. */
|
|
ok: boolean;
|
|
/** Non-fatal warnings about the config. */
|
|
warnings?: string[];
|
|
/** Validation errors (populated when `ok` is `false`). */
|
|
errors?: string[];
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Webhook handler input
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Input received by the plugin worker's `handleWebhook` handler.
|
|
*
|
|
* @see PLUGIN_SPEC.md §13.7 — `handleWebhook`
|
|
*/
|
|
export interface PluginWebhookInput {
|
|
/** Endpoint key matching the manifest declaration. */
|
|
endpointKey: string;
|
|
/** Inbound request headers. */
|
|
headers: Record<string, string | string[]>;
|
|
/** Raw request body as a UTF-8 string. */
|
|
rawBody: string;
|
|
/** Parsed JSON body (if applicable and parseable). */
|
|
parsedBody?: unknown;
|
|
/** Unique request identifier for idempotency checks. */
|
|
requestId: string;
|
|
}
|
|
|
|
export interface PluginApiRequestInput {
|
|
routeKey: string;
|
|
method: string;
|
|
path: string;
|
|
params: Record<string, string>;
|
|
query: Record<string, string | string[]>;
|
|
body: unknown;
|
|
actor: {
|
|
actorType: "user" | "agent";
|
|
actorId: string;
|
|
agentId?: string | null;
|
|
userId?: string | null;
|
|
runId?: string | null;
|
|
};
|
|
companyId: string;
|
|
headers: Record<string, string>;
|
|
}
|
|
|
|
export interface PluginApiResponse {
|
|
status?: number;
|
|
headers?: Record<string, string>;
|
|
body?: unknown;
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Plugin definition
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/**
|
|
* The plugin definition shape passed to `definePlugin()`.
|
|
*
|
|
* The only required field is `setup`, which receives the `PluginContext` and
|
|
* is where the plugin registers its handlers (events, jobs, data, actions,
|
|
* tools, etc.).
|
|
*
|
|
* All other lifecycle hooks are optional. If a hook is not implemented the
|
|
* host applies default behaviour (e.g. restarting the worker on config change
|
|
* instead of calling `onConfigChanged`).
|
|
*
|
|
* @see PLUGIN_SPEC.md §13 — Host-Worker Protocol
|
|
*/
|
|
export interface PluginDefinition {
|
|
/**
|
|
* Called once when the plugin worker starts up, after `initialize` completes.
|
|
*
|
|
* This is where the plugin registers all its handlers: event subscriptions,
|
|
* job handlers, data/action handlers, and tool registrations. Registration
|
|
* must be synchronous after `setup` resolves — do not register handlers
|
|
* inside async callbacks that may resolve after `setup` returns.
|
|
*
|
|
* @param ctx - The full plugin context provided by the host
|
|
*/
|
|
setup(ctx: PluginContext): Promise<void>;
|
|
|
|
/**
|
|
* Called when the host wants to know if the plugin is healthy.
|
|
*
|
|
* The host polls this on a regular interval and surfaces the result in the
|
|
* plugin health dashboard. If not implemented, the host infers health from
|
|
* worker process liveness.
|
|
*
|
|
* @see PLUGIN_SPEC.md §13.2 — `health`
|
|
*/
|
|
onHealth?(): Promise<PluginHealthDiagnostics>;
|
|
|
|
/**
|
|
* Called when the operator updates the plugin's instance configuration at
|
|
* runtime, without restarting the worker.
|
|
*
|
|
* If not implemented, the host restarts the worker to apply the new config.
|
|
*
|
|
* @param newConfig - The newly resolved configuration
|
|
* @see PLUGIN_SPEC.md §13.4 — `configChanged`
|
|
*/
|
|
onConfigChanged?(newConfig: Record<string, unknown>): Promise<void>;
|
|
|
|
/**
|
|
* Called when the host is about to shut down the plugin worker.
|
|
*
|
|
* The worker has at most 10 seconds (configurable via plugin config) to
|
|
* finish in-flight work and resolve this promise. After the deadline the
|
|
* host sends SIGTERM, then SIGKILL.
|
|
*
|
|
* @see PLUGIN_SPEC.md §12.5 — Graceful Shutdown Policy
|
|
*/
|
|
onShutdown?(): Promise<void>;
|
|
|
|
/**
|
|
* Called to validate the current plugin configuration.
|
|
*
|
|
* The host calls this:
|
|
* - after the plugin starts (to surface config errors immediately)
|
|
* - after the operator saves a new config (to validate before persisting)
|
|
* - via the "Test Connection" button in the settings UI
|
|
*
|
|
* @param config - The configuration to validate
|
|
* @see PLUGIN_SPEC.md §13.3 — `validateConfig`
|
|
*/
|
|
onValidateConfig?(config: Record<string, unknown>): Promise<PluginConfigValidationResult>;
|
|
|
|
/**
|
|
* Called to handle an inbound webhook delivery.
|
|
*
|
|
* The host routes `POST /api/plugins/:pluginId/webhooks/:endpointKey` to
|
|
* this handler. The plugin is responsible for signature verification using
|
|
* a resolved secret ref.
|
|
*
|
|
* If not implemented but webhooks are declared in the manifest, the host
|
|
* returns HTTP 501 for webhook deliveries.
|
|
*
|
|
* @param input - Webhook delivery metadata and payload
|
|
* @see PLUGIN_SPEC.md §13.7 — `handleWebhook`
|
|
*/
|
|
onWebhook?(input: PluginWebhookInput): Promise<void>;
|
|
|
|
/**
|
|
* Called for manifest-declared scoped JSON API routes under
|
|
* `/api/plugins/:pluginId/api/*` after the host has enforced auth, company
|
|
* access, capabilities, and checkout policy.
|
|
*/
|
|
onApiRequest?(input: PluginApiRequestInput): Promise<PluginApiResponse>;
|
|
|
|
/**
|
|
* Called when Paperclip scans issue/comment/document content and asks this
|
|
* plugin whether any sanitized URL candidates belong to its external object
|
|
* providers. The host has already stripped URL userinfo, query strings, and
|
|
* fragments unless provider-safe identity components were explicitly hashed.
|
|
*
|
|
* Requires `external.objects.detect`.
|
|
*/
|
|
onDetectExternalObjects?(
|
|
params: DetectExternalObjectsParams,
|
|
): Promise<DetectExternalObjectsResult>;
|
|
|
|
/**
|
|
* Called when Paperclip needs the current normalized status for one external
|
|
* object owned by a manifest-declared provider.
|
|
*
|
|
* Requires `external.objects.read`.
|
|
*/
|
|
onResolveExternalObject?(
|
|
params: ResolveExternalObjectParams,
|
|
): Promise<PluginExternalObjectResolveResult>;
|
|
|
|
/**
|
|
* Optional batch resolver used by providers that can refresh many objects
|
|
* more efficiently than individual `onResolveExternalObject` calls.
|
|
*
|
|
* Requires `external.objects.refresh`.
|
|
*/
|
|
onRefreshExternalObjects?(
|
|
params: RefreshExternalObjectsParams,
|
|
): Promise<RefreshExternalObjectsResult>;
|
|
|
|
/**
|
|
* Called to validate provider-specific configuration for a plugin-hosted
|
|
* environment driver.
|
|
*/
|
|
onEnvironmentValidateConfig?(
|
|
params: PluginEnvironmentValidateConfigParams,
|
|
): Promise<PluginEnvironmentValidationResult>;
|
|
|
|
/** Called to test reachability or readiness of a plugin-hosted environment. */
|
|
onEnvironmentProbe?(
|
|
params: PluginEnvironmentProbeParams,
|
|
): Promise<PluginEnvironmentProbeResult>;
|
|
|
|
/** Called before a run starts to acquire a provider lease. */
|
|
onEnvironmentAcquireLease?(
|
|
params: PluginEnvironmentAcquireLeaseParams,
|
|
): Promise<PluginEnvironmentLease>;
|
|
|
|
/** Called to reconnect to a previously acquired provider lease. */
|
|
onEnvironmentResumeLease?(
|
|
params: PluginEnvironmentResumeLeaseParams,
|
|
): Promise<PluginEnvironmentLease>;
|
|
|
|
/** Called when a run finishes and the provider lease can be released. */
|
|
onEnvironmentReleaseLease?(
|
|
params: PluginEnvironmentReleaseLeaseParams,
|
|
): Promise<void>;
|
|
|
|
/** Called when the host needs to force-destroy provider state. */
|
|
onEnvironmentDestroyLease?(
|
|
params: PluginEnvironmentDestroyLeaseParams,
|
|
): Promise<void>;
|
|
|
|
/** Called to materialize the run workspace inside the provider lease. */
|
|
onEnvironmentRealizeWorkspace?(
|
|
params: PluginEnvironmentRealizeWorkspaceParams,
|
|
): Promise<PluginEnvironmentRealizeWorkspaceResult>;
|
|
|
|
/** Called to execute a command inside the provider lease. */
|
|
onEnvironmentExecute?(
|
|
params: PluginEnvironmentExecuteParams,
|
|
): Promise<PluginEnvironmentExecuteResult>;
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// PaperclipPlugin — the sealed object returned by definePlugin()
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/**
|
|
* The sealed plugin object returned by `definePlugin()`.
|
|
*
|
|
* Plugin authors export this as the default export from their worker
|
|
* entrypoint. The host imports it and calls the lifecycle methods.
|
|
*
|
|
* @see PLUGIN_SPEC.md §14 — SDK Surface
|
|
*/
|
|
export interface PaperclipPlugin {
|
|
/** The original plugin definition passed to `definePlugin()`. */
|
|
readonly definition: PluginDefinition;
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// definePlugin — top-level factory
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Define a Paperclip plugin.
|
|
*
|
|
* Call this function in your worker entrypoint and export the result as the
|
|
* default export. The host will import the module and call lifecycle methods
|
|
* on the returned object.
|
|
*
|
|
* @param definition - Plugin lifecycle handlers
|
|
* @returns A sealed `PaperclipPlugin` object for the host to consume
|
|
*
|
|
* @example
|
|
* ```ts
|
|
* import { definePlugin } from "@paperclipai/plugin-sdk";
|
|
*
|
|
* export default definePlugin({
|
|
* async setup(ctx) {
|
|
* ctx.logger.info("Plugin started");
|
|
* ctx.events.on("issue.created", async (event) => {
|
|
* // handle event
|
|
* });
|
|
* },
|
|
*
|
|
* async onHealth() {
|
|
* return { status: "ok" };
|
|
* },
|
|
* });
|
|
* ```
|
|
*
|
|
* @see PLUGIN_SPEC.md §14.1 — Example SDK Shape
|
|
*/
|
|
export function definePlugin(definition: PluginDefinition): PaperclipPlugin {
|
|
return Object.freeze({ definition });
|
|
}
|