Files
PaperClipAI/server/src/__tests__/chat-interaction-publications.test.ts
T
DottaandPaperclip 889947c238 feat: add experimental native chat connectors (#13038)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - People also ask agents for work in their existing chat tools.
> - Each external conversation needs one task and a current authorized
source.
> - Retries, Stop, and provider failures must not duplicate work or
expose private data.
> - The first chat PR establishes the opt-in provider and data
contracts.
> - This PR adds experimental channel integration and its durable
control plane.
> - Users can request work from connected channels and inspect delivery
in Paperclip.

## Linked Issues or Issue Description

Refs #13100 and #13092. This is the second of exactly two chat PRs.
Foundation #13100 is merged and changed 143 files. Runner prerequisite
#13092 is also merged. This PR changes 400 files against master, below
the 500-file review limit. It contains no wireframe images or HTML
galleries.

## What Changed

- Add native Slack, GitHub, Microsoft Teams, Telegram, and Discord chat
connections. Keep chat disabled unless the operator enables experimental
chat connectors. Preserve the production GitHub tool connection and its
normal setup path.
- Bind each provider bot identity to one immutable Paperclip agent. Bind
each admitted external conversation to one task. Paperclip owns tasks,
runs, permissions, and audit records.
- Add durable admission, per-conversation queues, questions, task
controls, progress, final replies, images, files, and delivery receipts.
Board comments remain internal unless explicitly sent to the channel.
- Check current identity, provider reach, resource access, credentials,
runtime generation, and exact source before provider effects. Keep
private responses private. Never send raw reasoning, private logs,
credentials, or tool arguments.
- Hold uncertain sends for explicit audited resolution. Make Board
Send-to-channel atomic and idempotent. Keep reconnect and setup
credentials in Paperclip secret storage.
- Preserve current native-runner authority across retries, lost
acknowledgements, and recovery. Keep immutable input and completion
contracts separate from newer user input. Receipt reconciliation cannot
launch a provider.
- Reconcile chat close/new ordering and provider-effect lock order.
Audit resource access changes in the same transaction. Submit only the
selected resource from each UI toggle so stale pages cannot undo
unrelated access changes.
- Drain Codex stdout before certifying process exit. Bound the drain
with the existing shutdown grace. Preserve observed terminal authority
without treating an undrained process as successful or reusable.
- Incorporate master `018ca5da` with its ACP Stop, mobile task layout,
runner packaging, and official lock changes. Preserve dedicated
chat-answer continuations in both directions when ordinary queued
comments are adopted after Stop.
- Fence late adapter readiness behind an earlier Stop for the same run.
Preserve verified cleanup for registered adapters. Handle single Stop,
agent pause, duplicate Stops, and failure release without creating a
false cancellation receipt.
- Incorporate master's `6dd48cad4` wake-queue extraction. Preserve exact
failed-chat retry authorization and lineage, retired question-source
suppression, and the block on generic recovery that would discard the
admitted source. Fresh deferred input retains its separate promotion
path.
- Incorporate master `2a05b5ed3` and its queue-admission extraction,
simplified transaction ports, and separate runner CI job. Preserve exact
durable receipts, actor separation, and dedicated-answer isolation
through the new module. A failed receipt insert rolls back the
accompanying deferred-wake merge.

## Verification

Current head: `afe19299d06253cb628eb398e91d1200ea9f412a`, incorporating
master `2a05b5ed3457ea33efd6895520447d1d97fe98d8`. The conflicts are
resolved. This successor fixes two test-harness boundaries exposed by
CI: per-case route-module preparation and actual durable-save completion
before intentional runner termination. Production code and all existing
test/turn deadlines are unchanged. [Exact-head Greptile
review](https://github.com/paperclipai/paperclip/pull/13038#issuecomment-5587250594)
is **5/5**, completed September 10 at 13:20:55 UTC, with no actionable
findings or open review threads. [Fresh exact-head
CI](https://github.com/paperclipai/paperclip/actions/runs/34481724341)
passes **all 24 jobs**, including Build and both required aggregates.
Normal exact-head guarded merge was attempted and rejected by the
remaining branch approval policy: CODEOWNER review is required and no
human approval is present. Normal **squash auto-merge is enabled** as of
September 10 at 13:36:26 UTC. Requested CODEOWNERS have been notified;
no approval bypass or self-approval was used. Earlier-head results below
remain historical evidence, not qualification of this successor.

- Final exact-head Linux evidence: 995/995 chat integration cases; 36/36
agent-skills routes; 35/35 runner live-session cases, including real
process kill/resume; 1948 runner Vitest cases with three existing
benchmark/platform guards; 870/870 API-authority cases; and 104 browser
cases with four existing optional skips. Rust, conformance/replay, full
repository build, typecheck, canary, all server/workspace shards, and
both required aggregates pass with normal CI concurrency. Earlier failed
attempts remain recorded below.

- Latest test-only qualification: 141/141
route/permissions/authentication cases pass in separate cold forks, with
plain server types and independent review clear. The real-runner suite
passes 35/35, with plain runner types and independent review clear. A
controlled premature-save acknowledgement fails as expected; matching
ownership/effect/process evidence, rejected saves, real turn outcome,
test abort, and pre-kill liveness are covered. No local reproduction of
the original CI scheduling failure is claimed. The preceding [CI
run](https://github.com/paperclipai/paperclip/actions/runs/34479680858)
passes 21/24 jobs, including all 995 Linux chat cases and browser
aggregate (104 passed, four existing optional skips); only Build, the
skills serialized shard, and the required verification aggregate fail.
Its exact-head Greptile review was 5/5. Both failed job logs are
retained.

- Final fixture qualification: all eight focused Discord cases and all
995 chat integration cases pass. The exact modal statement/PID is
observed before taking the real connection lock; the test then proves
its actual blocking relationship before mutation. Original SQL
execution, provider behavior, negative assertions, and 1s/15s timeouts
remain unchanged. Independent review is clear and test/production hashes
remain frozen. The preceding [CI
attempt](https://github.com/paperclipai/paperclip/actions/runs/34477184777)
passed 22 jobs, including Build/runner, typecheck, canary, all other
test shards, and browser aggregate (104 passed, four existing optional
skips); the two fixture failures and failed verification aggregate
remain recorded, not relabeled as a pass.

- Current queue-module composition: 308/308 recovery/batching/queue/Stop
tests; 995/995 full chat integration; 89/89 module tests, including real
PostgreSQL receipt-insert rollback; 24/24 workflow/module-boundary
tests; plain server and UI types. All four actual local process/ACP
browser paths pass in 1.4 minutes. Fresh databases, no skips or retries,
stable reviewed source hashes. The initial boundary failure is retained;
its no-op service wrapper was removed without changing recovery context
or weakening the check. An exploratory standalone test-directory
typecheck fails because its new upstream transformation config is not a
standalone typechecking project; standard CI/build does not invoke it,
and no configuration was weakened to suppress those diagnostics.

- The preceding head `e02a63d462ce5d47433b0aeb632bb6fd20aab1ba` passed
[all 24 CI
jobs](https://github.com/paperclipai/paperclip/actions/runs/34436462958)
and exact-head Greptile review at 5/5. Required CODEOWNER review
prevented its normal merge before master advanced again.

- Final extracted-module composition: 307/307 recovery, batching, queue
and Stop-control tests; 995/995 full chat integration; 49/49 module
tests including eight PostgreSQL adapter cases; and 19/19 issue-update
tests. Plain server types pass. All four actual local process/ACP
browser paths pass in 1.3 minutes. Fresh databases, no skips or retries
in these cohorts, frozen source hashes, and independent review clear.

- The preceding head `3e4e1c1c` passes [all PR CI
jobs](https://github.com/paperclipai/paperclip/actions/runs/34415826820),
including Build and required `ci / verify` and `ci / e2e`. Both the
original Rust failure and the previously load-sensitive lineage fixture
pass with unchanged Linux concurrency. Master advanced afterward and
required this reconciliation.
- Final master composition: 448/448 focused UI tests, 186/186 adapter
tests, 24/24 queue/control tests, and 11/11 packaging tests. Plain UI,
server, shared, and adapter types pass. Token gates and diff checks
pass. Independent server and UI reviews are clear.
- Stop-registration regression: both real-service cases fail against
exact `a95` source and pass with the fix. The full corrected
recovery/control suite passes 265/265. Duplicate-owner and failed-Stop
controls also pass. Plain server types pass. The readiness barrier
prevents provider startup without adding an acknowledgment to an already
terminal run.
- Final qualification strengthens terminal-field equality and repeats
both affected cases successfully on a fresh database. All four actual
local process/ACP browser paths pass again in 1.3 minutes, without skips
or retries. The final screenshot shows Cancelled, a paused subtree,
retained input, and no error toast.
- Two new actual-service regressions fail before the merge fix. They
prove that queued-comment adoption could consume a dedicated chat answer
or add unrelated input to that answer. The fixed four-case cohort
passes, including ordinary upstream continuation and adapter Stop
controls. Full recovery passes 257/257. All four actual local
process/ACP Stop browser flows pass in 1.4 minutes, without skips or
retries, on a fresh database.
- The unchanged runner artifact was qualified with 171/171 transport
tests, 870/870 API-authority tests, conformance 1/1, and replay 11/11.
Six controlled reader tests prove the exit/drain repair. Its local
serial Rust workspace passed 546 top-level cases plus two invoked
helpers; the later passing Linux CI supplies default-concurrency
evidence.
- Prior exact-source full chat integration passes 995/995. Settings
regressions cover concurrent stale pages, 501 destinations, pending
state, rejected updates, and explicit retry. These deterministic tests
do not prove live provider behavior.
- Retained failed attempts and their causes are in the [qualification
log](https://github.com/paperclipai/paperclip/blob/afe19299d06253cb628eb398e91d1200ea9f412a/doc/plans/chat-adapters/2026-09-08-chat-queue-and-webhook-repair.md).
The first merge adapter run timed out while macOS slept for 290 seconds.
Its unchanged repeat passed with a temporary sleep guard. No assertion,
deadline, or CI gate was weakened.

Review commands include `pnpm --filter @paperclipai/server exec vitest
run src/__tests__/heartbeat-process-recovery.test.ts
src/__tests__/issue-queued-comments-routes.test.ts` and `pnpm exec
playwright test --config tests/e2e/playwright.config.ts
tests/e2e/acp-stop-continuation.spec.ts`. Database suites require fresh
disposable databases. See the [browser
runbook](https://github.com/paperclipai/paperclip/blob/afe19299d06253cb628eb398e91d1200ea9f412a/doc/plans/chat-adapters/2026-09-04-chat-adapters-browser-e2e-runbook.md)
for provider setup and separate live acceptance steps.

## Risks

- This remains experimental. Deterministic tests and bounded live
evidence do not establish every provider feature, tenant, permission
layout, or media shape. Teams work-tenant qualification is still open.
- Failed and uncertain provider effects remain visible and can require
operator action. A transport receipt does not prove recipient
visibility.
- Native controller and runner artifacts must remain compatible.
Preserve lease ownership, terminal authority, source binding, and
quarantine during future changes.
- Access and audit rows commit together, but activity notifications
remain best-effort. This is not a new durable event outbox.
- The PR operation does not deploy a live server, replace its runner, or
change provider permissions. Remaining live qualification is documented
in the [temporary
handoff](https://github.com/paperclipai/paperclip/blob/afe19299d06253cb628eb398e91d1200ea9f412a/doc/plans/chat-adapters/2026-09-08-open-qualification-followups.md).

## Model Used

OpenAI Codex assisted with implementation, tool execution, testing, and
review. The work records `gpt-6-astra` assistance. The environment does
not report a context-window size. No private reasoning traces are
included.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-09-10 10:06:45 -05:00

1248 lines
40 KiB
TypeScript

import { randomUUID } from "node:crypto";
import { and, eq, sql } from "drizzle-orm";
import { afterAll, beforeAll, describe, expect, it } from "vitest";
import {
agents,
chatActions,
chatConversations,
chatEndpoints,
chatPublications,
companies,
createDb,
documentRevisions,
documents,
heartbeatRuns,
issueComments,
issueDocuments,
issueThreadInteractions,
issues,
toolApplications,
toolConnections,
} from "@paperclipai/db";
import type { ChatProvider } from "@paperclipai/shared";
import { enqueueTerminalIssueInteractionChatPublications } from "../services/chat-interaction-publications.js";
import { issueThreadInteractionService } from "../services/issue-thread-interactions.js";
import {
getEmbeddedPostgresTestSupport,
startEmbeddedPostgresTestDatabase,
} from "./helpers/embedded-postgres.js";
const embeddedPostgresSupport = await getEmbeddedPostgresTestSupport();
const describeEmbeddedPostgres = embeddedPostgresSupport.supported
? describe
: describe.skip;
describeEmbeddedPostgres(
"terminal native chat interaction publications",
() => {
let db!: ReturnType<typeof createDb>;
let tempDb: Awaited<
ReturnType<typeof startEmbeddedPostgresTestDatabase>
> | null = null;
const previousPublicUrl = process.env.PAPERCLIP_PUBLIC_URL;
beforeAll(async () => {
process.env.PAPERCLIP_PUBLIC_URL = "https://paperclip.example";
tempDb = await startEmbeddedPostgresTestDatabase(
"paperclip-terminal-chat-interaction-",
);
db = createDb(tempDb.connectionString);
}, 20_000);
afterAll(async () => {
if (previousPublicUrl === undefined)
delete process.env.PAPERCLIP_PUBLIC_URL;
else process.env.PAPERCLIP_PUBLIC_URL = previousPublicUrl;
await tempDb?.cleanup();
});
async function seedBoundIssue(
providers: ChatProvider[] = ["slack", "telegram"],
) {
const companyId = randomUUID();
const agentId = randomUUID();
const issueId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: `Terminal chat ${companyId}`,
issuePrefix: `TC${companyId.replaceAll("-", "").slice(0, 6).toUpperCase()}`,
});
await db.insert(agents).values({
id: agentId,
companyId,
name: "Native chat agent",
role: "operator",
status: "idle",
adapterType: "paperclip_runner",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
});
await db.insert(issues).values({
id: issueId,
companyId,
title: "Resolve the native provider card",
status: "in_progress",
priority: "medium",
assigneeAgentId: agentId,
});
const endpointIds: Record<string, string> = {};
for (const provider of providers) {
const applicationId = randomUUID();
const connectionId = randomUUID();
const endpointId = randomUUID();
endpointIds[provider] = endpointId;
await db.insert(toolApplications).values({
id: applicationId,
companyId,
applicationKey: `chat:${provider}:${endpointId}`,
name: `${provider} ${endpointId}`,
type: "chat",
status: "active",
});
await db.insert(toolConnections).values({
id: connectionId,
companyId,
applicationId,
name: `${provider} channel`,
uid: `chat-${provider}-${endpointId}`,
connectionPurpose: "channel",
transport: "chat_sdk",
status: "active",
enabled: true,
});
await db.insert(chatEndpoints).values({
id: endpointId,
companyId,
connectionId,
provider,
publicId: randomUUID(),
assignedAgentId: agentId,
status: "active",
capabilities: {
threads: true,
directMessages: true,
nativeStreaming: false,
messageEdits: true,
messageDeletes: false,
reactions: true,
files: true,
cards: true,
actions: true,
modals: provider !== "telegram",
slashCommands: true,
ephemeralMessages: provider === "slack",
proactiveDirectMessages: true,
},
});
await db.insert(chatConversations).values({
companyId,
endpointId,
issueId,
externalConversationId: `${provider}-conversation`,
externalThreadId: `${provider}:thread:${issueId}`,
externalLabel: `${provider} thread`,
state: "active",
});
}
return { agentId, companyId, endpointIds, issueId };
}
async function markInteractionCardsPublished(
companyId: string,
interactionId: string,
) {
const originals = await db
.select()
.from(chatPublications)
.where(
and(
eq(chatPublications.companyId, companyId),
eq(
sql<string>`${chatPublications.payload}->>'interactionId'`,
interactionId,
),
),
);
for (const original of originals) {
await db
.update(chatPublications)
.set({
state: "published",
providerMessageId: `provider-${original.endpointId}`,
})
.where(eq(chatPublications.id, original.id));
}
return originals;
}
async function publicationsForInteraction(
companyId: string,
interactionId: string,
) {
return db
.select()
.from(chatPublications)
.where(
and(
eq(chatPublications.companyId, companyId),
eq(
sql<string>`${chatPublications.payload}->>'interactionId'`,
interactionId,
),
),
);
}
function interceptAfterFirstSelect(
afterSelect: () => Promise<void>,
): Parameters<typeof enqueueTerminalIssueInteractionChatPublications>[0] {
let intercepted = false;
const wrapQuery = (query: any): any =>
new Proxy(query, {
get(target, property) {
if (property === "then") {
return (onFulfilled: unknown, onRejected: unknown) =>
Promise.resolve(target)
.then(async (value) => {
if (!intercepted) {
intercepted = true;
await afterSelect();
}
return value;
})
.then(onFulfilled as never, onRejected as never);
}
const member = Reflect.get(target, property, target);
return typeof member === "function"
? (...args: unknown[]) =>
wrapQuery(Reflect.apply(member, target, args))
: member;
},
});
return {
select: ((...args: unknown[]) =>
wrapQuery(Reflect.apply(db.select, db, args))) as typeof db.select,
insert: db.insert.bind(db),
update: db.update.bind(db),
};
}
it("publishes prompts only for the endpoint's verified immutable agent", async () => {
const fixture = await seedBoundIssue();
const service = issueThreadInteractionService(db);
const foreignAgentId = randomUUID();
await db.insert(agents).values({
id: foreignAgentId,
companyId: fixture.companyId,
name: "Foreign agent",
role: "operator",
status: "idle",
adapterType: "paperclip_runner",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
});
const foreignRunId = randomUUID();
await db.insert(heartbeatRuns).values({
id: foreignRunId,
companyId: fixture.companyId,
agentId: foreignAgentId,
status: "succeeded",
});
const question = {
kind: "ask_user_questions" as const,
payload: {
version: 1 as const,
questions: [
{
id: "priority",
prompt: "Which priority?",
selectionMode: "single" as const,
allowOther: false,
options: [{ id: "high", label: "High" }],
},
],
},
};
const userAuthored = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
question,
{ userId: "board-user" },
);
const foreignAuthored = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
question,
{ agentId: foreignAgentId },
);
const mismatchedRun = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{ ...question, sourceRunId: foreignRunId },
{ agentId: fixture.agentId },
);
await expect(
publicationsForInteraction(fixture.companyId, userAuthored.id),
).resolves.toEqual([]);
await expect(
publicationsForInteraction(fixture.companyId, foreignAuthored.id),
).resolves.toEqual([]);
await expect(
publicationsForInteraction(fixture.companyId, mismatchedRun.id),
).resolves.toEqual([]);
const assignedAgent = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
question,
{ agentId: fixture.agentId },
);
const publications = await publicationsForInteraction(
fixture.companyId,
assignedAgent.id,
);
expect(publications).toHaveLength(2);
expect(
publications.every(
(row) =>
row.idempotencyKey ===
`interaction:${assignedAgent.id}:${row.endpointId}`,
),
).toBe(true);
});
it("keeps unsupported governance interactions authoritative in Paperclip", async () => {
const fixture = await seedBoundIssue();
const interaction = await issueThreadInteractionService(db).create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "request_checkbox_confirmation",
payload: {
version: 1,
prompt: "Choose deployment regions",
options: [{ id: "us", label: "US" }],
},
},
{ agentId: fixture.agentId },
);
await expect(
publicationsForInteraction(fixture.companyId, interaction.id),
).resolves.toEqual([]);
});
it("settles a card when the dispatcher claims it between the read and cancellation CAS", async () => {
const fixture = await seedBoundIssue(["slack"]);
const service = issueThreadInteractionService(db);
const interaction = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "ask_user_questions",
continuationPolicy: "wake_assignee",
payload: {
version: 1,
questions: [
{
id: "priority",
prompt: "Which priority?",
selectionMode: "single",
allowOther: false,
options: [{ id: "high", label: "High" }],
},
],
},
},
{ agentId: fixture.agentId },
);
const [original] = await publicationsForInteraction(
fixture.companyId,
interaction.id,
);
if (!original) throw new Error("Expected an original publication");
await db
.update(issueThreadInteractions)
.set({
status: "answered",
result: {
version: 1,
answers: [{ questionId: "priority", optionIds: ["high"] }],
summaryMarkdown: null,
},
resolvedByUserId: "board-user",
resolvedAt: new Date(),
updatedAt: new Date(),
})
.where(eq(issueThreadInteractions.id, interaction.id));
const answered = await service.getById(interaction.id);
if (!answered) throw new Error("Expected an answered interaction");
const raceDb = interceptAfterFirstSelect(async () => {
const claimed = await db
.update(chatPublications)
.set({ state: "streaming", updatedAt: new Date() })
.where(
and(
eq(chatPublications.id, original.id),
eq(chatPublications.state, "pending"),
),
)
.returning({ id: chatPublications.id });
expect(claimed).toEqual([{ id: original.id }]);
});
await enqueueTerminalIssueInteractionChatPublications(raceDb, answered);
await expect(
db
.select({ state: chatPublications.state })
.from(chatPublications)
.where(eq(chatPublications.id, original.id)),
).resolves.toEqual([{ state: "streaming" }]);
const publications = await publicationsForInteraction(
fixture.companyId,
interaction.id,
);
expect(publications).toEqual(
expect.arrayContaining([
expect.objectContaining({
idempotencyKey: `interaction-resolution:${interaction.id}:${fixture.endpointIds.slack}`,
state: "pending",
payload: expect.objectContaining({ text: "Answered: High." }),
}),
]),
);
});
it("settles an ambiguously delivered link-only card after an operator marks it delivered", async () => {
const fixture = await seedBoundIssue(["github"]);
const service = issueThreadInteractionService(db);
const interaction = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "request_confirmation",
continuationPolicy: "wake_assignee",
payload: { version: 1, prompt: "Ship the GitHub release?" },
},
{ agentId: fixture.agentId },
);
const [original] = await publicationsForInteraction(
fixture.companyId,
interaction.id,
);
if (!original) throw new Error("Expected a GitHub link-only card");
await db
.update(chatPublications)
.set({ state: "published", providerMessageId: null })
.where(eq(chatPublications.id, original.id));
await service.acceptInteraction(
{
id: fixture.issueId,
companyId: fixture.companyId,
projectId: null,
goalId: null,
},
interaction.id,
{},
{ userId: "board-user" },
);
await expect(
db
.select({
idempotencyKey: chatPublications.idempotencyKey,
payload: chatPublications.payload,
state: chatPublications.state,
})
.from(chatPublications)
.where(
eq(
chatPublications.idempotencyKey,
`interaction-resolution:${interaction.id}:${fixture.endpointIds.github}`,
),
),
).resolves.toEqual([
{
idempotencyKey: `interaction-resolution:${interaction.id}:${fixture.endpointIds.github}`,
payload: expect.objectContaining({
interactionId: interaction.id,
text: "Accepted.",
}),
state: "pending",
},
]);
});
it("settles form answers without claiming a surface or exposing free text", async () => {
const fixture = await seedBoundIssue();
const service = issueThreadInteractionService(db);
const interaction = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "ask_user_questions",
payload: {
version: 1,
questions: [
{
id: "choice",
prompt: "Choose a tree",
selectionMode: "single",
allowOther: false,
options: [{ id: "cedar", label: "Cedar" }],
},
{
id: "label",
prompt: "Enter a label",
selectionMode: "single",
allowOther: true,
options: [
{ id: "text", label: "Write a label", freeText: true },
],
},
],
},
},
{ agentId: fixture.agentId },
);
await markInteractionCardsPublished(fixture.companyId, interaction.id);
await service.answerQuestions(
{ id: fixture.issueId, companyId: fixture.companyId },
interaction.id,
{
answers: [
{ questionId: "choice", optionIds: ["cedar"] },
{
questionId: "label",
optionIds: [],
otherText: "private free-text label",
},
],
},
{ userId: "board-user" },
);
const settlements = (
await publicationsForInteraction(fixture.companyId, interaction.id)
).filter((row) => row.state === "pending");
expect(settlements).toHaveLength(2);
for (const settlement of settlements) {
expect(settlement.payload).toMatchObject({
text: "Answered.",
card: { kind: "question", body: "Answered." },
});
expect(settlement.payload.card?.actions ?? []).toHaveLength(0);
expect(JSON.stringify(settlement.payload)).not.toContain(
"private free-text label",
);
expect(JSON.stringify(settlement.payload)).not.toContain(
"Answered in Paperclip",
);
}
});
it("settles UI answers and skips on every provider-native card with no live actions", async () => {
const fixture = await seedBoundIssue();
const service = issueThreadInteractionService(db);
const questionInput = {
kind: "ask_user_questions" as const,
payload: {
version: 1 as const,
questions: [
{
id: "priority",
prompt: "Which priority?",
selectionMode: "single" as const,
allowOther: false,
options: [
{ id: "high", label: "High" },
{ id: "normal", label: "Normal" },
],
},
],
},
};
const answeredQuestion = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
questionInput,
{ agentId: fixture.agentId },
);
expect(
await markInteractionCardsPublished(
fixture.companyId,
answeredQuestion.id,
),
).toHaveLength(2);
const answered = await service.answerQuestions(
{ id: fixture.issueId, companyId: fixture.companyId },
answeredQuestion.id,
{ answers: [{ questionId: "priority", optionIds: ["high"] }] },
{ userId: "board-user" },
);
const answeredSettlements = await db
.select()
.from(chatPublications)
.where(
and(
eq(chatPublications.companyId, fixture.companyId),
eq(
sql<string>`${chatPublications.payload}->>'interactionId'`,
answeredQuestion.id,
),
eq(chatPublications.state, "pending"),
),
);
expect(answeredSettlements).toHaveLength(2);
expect(answeredSettlements).toEqual(
expect.arrayContaining(
Object.values(fixture.endpointIds).map((endpointId) =>
expect.objectContaining({
endpointId,
idempotencyKey: `interaction-resolution:${answeredQuestion.id}:${endpointId}`,
payload: expect.objectContaining({
text: "Answered: High.",
card: expect.objectContaining({
kind: "question",
title: "Which priority?",
body: "Answered: High.",
}),
}),
}),
),
),
);
expect(
answeredSettlements.every(
(row) => (row.payload.card?.actions ?? []).length === 0,
),
).toBe(true);
await expect(
enqueueTerminalIssueInteractionChatPublications(db, answered),
).resolves.toEqual([]);
await expect(
db
.select({ status: chatActions.status })
.from(chatActions)
.where(
eq(
sql<string>`${chatActions.payload}->>'interactionId'`,
answeredQuestion.id,
),
),
).resolves.toEqual([
{ status: "expired" },
{ status: "expired" },
{ status: "expired" },
{ status: "expired" },
]);
const skippedQuestion = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
questionInput,
{ agentId: fixture.agentId },
);
await markInteractionCardsPublished(
fixture.companyId,
skippedQuestion.id,
);
await service.skipInteraction(
{
id: fixture.issueId,
companyId: fixture.companyId,
status: "in_progress",
},
skippedQuestion.id,
{},
{ userId: "board-user" },
);
const skippedSettlements = await db
.select()
.from(chatPublications)
.where(
and(
eq(chatPublications.companyId, fixture.companyId),
eq(
sql<string>`${chatPublications.payload}->>'interactionId'`,
skippedQuestion.id,
),
eq(chatPublications.state, "pending"),
),
);
expect(skippedSettlements).toHaveLength(2);
expect(
skippedSettlements.every(
(row) => row.payload.card?.body === "Skipped in Paperclip.",
),
).toBe(true);
expect(
skippedSettlements.every(
(row) => (row.payload.card?.actions ?? []).length === 0,
),
).toBe(true);
await expect(
db
.select({ id: chatActions.id })
.from(chatActions)
.where(
and(
eq(chatActions.kind, "interaction_wakeup"),
eq(
sql<string>`${chatActions.payload}->>'interactionId'`,
skippedQuestion.id,
),
),
),
).resolves.toEqual([]);
});
it("settles native and link-only confirmation cards without inventing controls", async () => {
const fixture = await seedBoundIssue();
const service = issueThreadInteractionService(db);
for (const outcome of ["accept", "reject"] as const) {
const interaction = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "request_confirmation",
continuationPolicy: "wake_assignee",
payload: { version: 1, prompt: `Should we ${outcome}?` },
},
{ agentId: fixture.agentId },
);
const originals = await markInteractionCardsPublished(
fixture.companyId,
interaction.id,
);
expect(originals).toHaveLength(2);
expect(
originals.find((row) => row.endpointId === fixture.endpointIds.slack)
?.payload.card?.actions,
).toEqual([
expect.objectContaining({ type: "link", label: "Open in Paperclip" }),
]);
expect(
originals.find(
(row) => row.endpointId === fixture.endpointIds.telegram,
)?.payload.card?.actions,
).toEqual([
expect.objectContaining({ type: "callback" }),
expect.objectContaining({ type: "callback" }),
]);
if (outcome === "accept") {
await service.acceptInteraction(
{
id: fixture.issueId,
companyId: fixture.companyId,
projectId: null,
goalId: null,
},
interaction.id,
{},
{ userId: "board-user" },
);
} else {
await service.rejectInteraction(
{ id: fixture.issueId, companyId: fixture.companyId },
interaction.id,
{},
{ userId: "board-user" },
);
}
const settlements = await db
.select()
.from(chatPublications)
.where(
and(
eq(chatPublications.companyId, fixture.companyId),
eq(
sql<string>`${chatPublications.payload}->>'interactionId'`,
interaction.id,
),
eq(chatPublications.state, "pending"),
),
);
expect(settlements).toHaveLength(2);
expect(settlements).toEqual(
expect.arrayContaining(
Object.values(fixture.endpointIds).map((endpointId) =>
expect.objectContaining({
endpointId,
idempotencyKey: `interaction-resolution:${interaction.id}:${endpointId}`,
payload: expect.objectContaining({
text: outcome === "accept" ? "Accepted." : "Rejected.",
card: expect.objectContaining({
kind: "confirmation",
title: `Should we ${outcome}?`,
body: outcome === "accept" ? "Accepted" : "Rejected",
}),
}),
}),
),
),
);
expect(
settlements.every(
(settlement) =>
(settlement.payload.card?.actions ?? []).length === 0,
),
).toBe(true);
await expect(
db
.select({
kind: chatActions.kind,
payload: chatActions.payload,
status: chatActions.status,
})
.from(chatActions)
.where(
and(
eq(chatActions.kind, "interaction_wakeup"),
eq(
sql<string>`${chatActions.payload}->>'interactionId'`,
interaction.id,
),
),
),
).resolves.toEqual([
{
kind: "interaction_wakeup",
payload: expect.objectContaining({
agentId: fixture.agentId,
interactionId: interaction.id,
interactionStatus: outcome === "accept" ? "accepted" : "rejected",
issueId: fixture.issueId,
requestedByActorId: "board-user",
requestedByActorType: "user",
}),
status: "issued",
},
]);
}
});
it("expires both modal action tokens when a form-backed question is answered", async () => {
const fixture = await seedBoundIssue(["slack"]);
const service = issueThreadInteractionService(db);
const interaction = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "ask_user_questions",
continuationPolicy: "wake_assignee",
payload: {
version: 1,
questions: [
{
id: "priority",
prompt: "Which priority?",
selectionMode: "single",
allowOther: false,
options: [{ id: "high", label: "High" }],
},
{
id: "owner",
prompt: "Who owns it?",
selectionMode: "single",
allowOther: false,
options: [{ id: "agent", label: "Agent" }],
},
],
},
},
{ agentId: fixture.agentId },
);
await markInteractionCardsPublished(fixture.companyId, interaction.id);
await service.answerQuestions(
{ id: fixture.issueId, companyId: fixture.companyId },
interaction.id,
{
answers: [
{ questionId: "priority", optionIds: ["high"] },
{ questionId: "owner", optionIds: ["agent"] },
],
},
{ userId: "board-user" },
);
const actions = await db
.select({ kind: chatActions.kind, status: chatActions.status })
.from(chatActions)
.where(
eq(
sql<string>`${chatActions.payload}->>'interactionId'`,
interaction.id,
),
);
expect(actions).toEqual(
expect.arrayContaining([
{ kind: "question_form_open", status: "expired" },
{ kind: "question_form_submit", status: "expired" },
]),
);
expect(actions).toHaveLength(2);
});
it("cancels unsent native and link-only cards instead of publishing stale prompts", async () => {
const fixture = await seedBoundIssue();
const service = issueThreadInteractionService(db);
const interaction = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "request_confirmation",
payload: { version: 1, prompt: "Proceed?" },
},
{ agentId: fixture.agentId },
);
await service.acceptInteraction(
{
id: fixture.issueId,
companyId: fixture.companyId,
projectId: null,
goalId: null,
},
interaction.id,
{},
{ userId: "board-user" },
);
const publications = await db
.select()
.from(chatPublications)
.where(
and(
eq(chatPublications.companyId, fixture.companyId),
eq(
sql<string>`${chatPublications.payload}->>'interactionId'`,
interaction.id,
),
),
);
expect(publications).toHaveLength(2);
expect(publications).toEqual(
expect.arrayContaining(
Object.values(fixture.endpointIds).map((endpointId) =>
expect.objectContaining({
endpointId,
idempotencyKey: `interaction:${interaction.id}:${endpointId}`,
state: "cancelled",
redactedError:
"Interaction was resolved before provider publication",
}),
),
),
);
expect(
publications.some((row) =>
row.payload.card?.actions?.some((action) => action.type === "link"),
),
).toBe(true);
});
it("settles visible question cards when a newer interaction supersedes them", async () => {
const fixture = await seedBoundIssue();
const service = issueThreadInteractionService(db);
const input = {
kind: "ask_user_questions" as const,
payload: {
version: 1 as const,
questions: [
{
id: "priority",
prompt: "Which priority?",
selectionMode: "single" as const,
allowOther: false,
options: [{ id: "high", label: "High" }],
},
],
},
};
const original = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
input,
{ agentId: fixture.agentId },
);
await markInteractionCardsPublished(fixture.companyId, original.id);
const replacement = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
input,
{ agentId: fixture.agentId },
);
await expect(service.getById(original.id)).resolves.toMatchObject({
status: "expired",
result: {
expirationReason: "superseded_by_newer_interaction",
supersededByInteractionId: replacement.id,
},
});
const publications = await db
.select()
.from(chatPublications)
.where(
and(
eq(chatPublications.companyId, fixture.companyId),
eq(
sql<string>`${chatPublications.payload}->>'interactionId'`,
original.id,
),
),
);
const settlements = publications.filter((row) =>
row.idempotencyKey.startsWith("interaction-resolution:"),
);
expect(settlements).toHaveLength(2);
expect(
settlements.every(
(row) =>
row.state === "pending" &&
row.payload.text === "Expired: replaced by a newer request." &&
row.payload.card?.body === "Expired: replaced by a newer request" &&
(row.payload.card.actions ?? []).length === 0,
),
).toBe(true);
});
it("settles live and historical human-comment supersessions", async () => {
const fixture = await seedBoundIssue();
const service = issueThreadInteractionService(db);
const confirmation = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "request_confirmation",
payload: { version: 1, prompt: "Proceed with the release?" },
},
{ agentId: fixture.agentId },
);
await markInteractionCardsPublished(fixture.companyId, confirmation.id);
const liveCommentId = randomUUID();
await service.expireRequestConfirmationsSupersededByComment(
{ id: fixture.issueId, companyId: fixture.companyId },
{
id: liveCommentId,
authorUserId: "board-user",
createdByRunId: null,
createdAt: new Date(Date.now() + 1_000),
},
{ userId: "board-user" },
);
const liveSettlements = await db
.select()
.from(chatPublications)
.where(
eq(
chatPublications.idempotencyKey,
`interaction-resolution:${confirmation.id}:${fixture.endpointIds.telegram}`,
),
);
expect(liveSettlements).toEqual([
expect.objectContaining({
payload: expect.objectContaining({
text: "Expired: superseded by a newer reply.",
card: expect.objectContaining({
body: "Expired: superseded by a newer reply",
}),
}),
}),
]);
expect(liveSettlements[0]?.payload.card?.actions ?? []).toHaveLength(0);
const question = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "ask_user_questions",
payload: {
version: 1,
questions: [
{
id: "priority",
prompt: "Which priority?",
selectionMode: "single",
allowOther: false,
options: [{ id: "high", label: "High" }],
},
],
},
},
{ agentId: fixture.agentId },
);
await markInteractionCardsPublished(fixture.companyId, question.id);
const questionCreatedAt = new Date("2026-09-05T12:00:00.000Z");
await db
.update(issueThreadInteractions)
.set({ createdAt: questionCreatedAt, updatedAt: questionCreatedAt })
.where(eq(issueThreadInteractions.id, question.id));
await db.insert(issueComments).values({
id: randomUUID(),
companyId: fixture.companyId,
issueId: fixture.issueId,
authorUserId: "board-user",
authorType: "user",
body: "Use the high-priority path.",
createdAt: new Date("2026-09-05T12:01:00.000Z"),
updatedAt: new Date("2026-09-05T12:01:00.000Z"),
});
await service.expireRequestConfirmationsSupersededByHistoricalComments({
id: fixture.issueId,
companyId: fixture.companyId,
});
const historicalSettlements = await db
.select()
.from(chatPublications)
.where(
and(
eq(chatPublications.companyId, fixture.companyId),
eq(
sql<string>`${chatPublications.payload}->>'interactionId'`,
question.id,
),
eq(chatPublications.state, "pending"),
),
);
expect(historicalSettlements).toHaveLength(2);
expect(
historicalSettlements.every(
(row) =>
row.payload.card?.body === "Expired: superseded by a newer reply" &&
(row.payload.card.actions ?? []).length === 0,
),
).toBe(true);
});
it("cancels stale-target prompts and settles terminal-issue expirations", async () => {
const fixture = await seedBoundIssue();
const service = issueThreadInteractionService(db);
const documentId = randomUUID();
const revisionId = randomUUID();
const nextRevisionId = randomUUID();
await db.insert(documents).values({
id: documentId,
companyId: fixture.companyId,
title: "Plan",
format: "markdown",
latestBody: "v1",
latestRevisionId: revisionId,
latestRevisionNumber: 1,
});
await db.insert(issueDocuments).values({
companyId: fixture.companyId,
issueId: fixture.issueId,
documentId,
key: "plan",
});
await db.insert(documentRevisions).values({
id: revisionId,
companyId: fixture.companyId,
documentId,
revisionNumber: 1,
title: "Plan",
format: "markdown",
body: "v1",
});
const confirmation = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "request_confirmation",
payload: {
version: 1,
prompt: "Apply this plan?",
target: {
type: "issue_document",
issueId: fixture.issueId,
documentId,
key: "plan",
revisionId,
revisionNumber: 1,
},
},
},
{ agentId: fixture.agentId },
);
await service.expireStaleRequestConfirmationsForIssueDocument(
{ id: fixture.issueId, companyId: fixture.companyId },
{
id: documentId,
key: "plan",
latestRevisionId: nextRevisionId,
latestRevisionNumber: 2,
},
{ userId: "board-user" },
);
const stalePublications = await db
.select()
.from(chatPublications)
.where(
and(
eq(chatPublications.companyId, fixture.companyId),
eq(
sql<string>`${chatPublications.payload}->>'interactionId'`,
confirmation.id,
),
),
);
expect(stalePublications).toHaveLength(2);
expect(
stalePublications.every(
(row) =>
row.state === "cancelled" &&
row.redactedError ===
"Interaction was resolved before provider publication",
),
).toBe(true);
const question = await service.create(
{ id: fixture.issueId, companyId: fixture.companyId },
{
kind: "ask_user_questions",
payload: {
version: 1,
questions: [
{
id: "priority",
prompt: "Which priority?",
selectionMode: "single",
allowOther: false,
options: [{ id: "high", label: "High" }],
},
],
},
},
{ agentId: fixture.agentId },
);
await markInteractionCardsPublished(fixture.companyId, question.id);
await service.expirePendingInteractionsForTerminalIssue(
{
id: fixture.issueId,
companyId: fixture.companyId,
status: "done",
},
{ userId: "board-user" },
);
const closedSettlements = await db
.select()
.from(chatPublications)
.where(
and(
eq(chatPublications.companyId, fixture.companyId),
eq(
sql<string>`${chatPublications.payload}->>'interactionId'`,
question.id,
),
eq(chatPublications.state, "pending"),
),
);
expect(closedSettlements).toHaveLength(2);
expect(
closedSettlements.every(
(row) =>
row.payload.text === "Expired: task is closed." &&
row.payload.card?.body === "Expired: task is closed" &&
(row.payload.card.actions ?? []).length === 0,
),
).toBe(true);
});
},
);