mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-11 14:10:50 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Governed MCP access spans contracts, runtime enforcement, adapters, UI surfaces, and operator verification > - The parity reference PR #9534 is too large for effective automated or human review > - The feature therefore needs a linear stack whose individual diffs stay below the 100-file review limit > - This pull request is split 5/8 and focuses on remaining adapters, CLI, plugin examples, and deployment packaging > - The benefit is a standalone, testable review boundary while preserving byte-for-byte parity at the top of the stack ## Linked Issues or Issue Description - Related parity reference: #9534 - Problem: The backend runtime needs packaging, CLI propagation, worktree provisioning, release manifests, and remaining adapter/plugin consumers. - Proposed solution: Adds the remaining runtime/deployment integration after compile-required contracts and concrete MCP injection moved into lower server levels. - Alternatives considered: keeping #9534 as one 403-file review, or rewriting the feature to manufacture seams; both were rejected in favor of path extraction plus compile-driven boundary moves. - Roadmap alignment: this advances the existing governed MCP/tool-access work already represented by #9534; it does not introduce a separate roadmap initiative. - Stack position: base branch is `pap10341-split/04-server-runtime-wiring`. - Merge policy: merge bottom-up, in order, only after the complete eight-PR stack has been reviewed and the top-of-stack parity gate remains empty. - Requested review: QA for CLI, packaging, and worktree behavior; Greptile on every PR. ## What Changed - Adds the remaining runtime/deployment integration after compile-required contracts and concrete MCP injection moved into lower server levels. - Keeps this PR below 100 changed files and independently typecheckable. - Preserves the final tree from #9534 when combined with the other seven stack levels. ## Verification - `pnpm typecheck` - Focused CLI Vitest run — 4 files, 49 tests passed ## Risks - Packaging omissions could make the feature work in source but fail in Docker, worktrees, or release assembly. - Stack risk: merging out of order can expose incomplete layers; mitigate by following the documented bottom-up merge policy. - Parity risk: later edits to an intermediate branch can drift from #9534; mitigate by re-running the empty top-of-stack diff before merge. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context window; medium reasoning with repository, shell, Git, GitHub CLI, and code-execution tools enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] Internal references are omitted except the execution-plan link explicitly required for this coordinated split stack - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge ## Stack Coordination - Internal execution plan: [PAP-13874](/PAP/issues/PAP-13874#document-plan) - Parity reference: #9534 - Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563 - Merge bottom-up only after full-stack review and an empty parity diff at #9563. --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
162 lines
6.2 KiB
TypeScript
162 lines
6.2 KiB
TypeScript
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { Command } from "commander";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { registerGoalCommands } from "../commands/client/goal.js";
|
|
import { registerProjectCommands } from "../commands/client/project.js";
|
|
|
|
const COMPANY_ID = "22222222-2222-4222-8222-222222222222";
|
|
const PROJECT_ID = "33333333-3333-4333-8333-333333333333";
|
|
const GOAL_ID = "44444444-4444-4444-8444-444444444444";
|
|
|
|
function createProgram(): Command {
|
|
const program = new Command();
|
|
program.exitOverride();
|
|
program.configureOutput({
|
|
writeOut: () => {},
|
|
writeErr: () => {},
|
|
});
|
|
registerProjectCommands(program);
|
|
registerGoalCommands(program);
|
|
return program;
|
|
}
|
|
|
|
describe("project and goal commands", () => {
|
|
beforeEach(() => {
|
|
vi.restoreAllMocks();
|
|
delete process.env.PAPERCLIP_API_KEY;
|
|
delete process.env.PAPERCLIP_API_URL;
|
|
delete process.env.PAPERCLIP_COMPANY_ID;
|
|
process.env.PAPERCLIP_CONTEXT = path.join(fs.mkdtempSync(path.join(os.tmpdir(), "paperclip-project-goal-")), "context.json");
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
delete process.env.PAPERCLIP_CONTEXT;
|
|
});
|
|
|
|
it("creates and updates projects with shared schemas", async () => {
|
|
const fetchMock = vi
|
|
.fn()
|
|
.mockResolvedValueOnce(new Response(JSON.stringify({
|
|
id: PROJECT_ID,
|
|
companyId: COMPANY_ID,
|
|
name: "Launch Site",
|
|
status: "planned",
|
|
goalIds: [GOAL_ID],
|
|
}), { status: 201 }))
|
|
.mockResolvedValueOnce(new Response(JSON.stringify({
|
|
id: PROJECT_ID,
|
|
companyId: COMPANY_ID,
|
|
name: "Launch Site",
|
|
status: "in_progress",
|
|
goalIds: [GOAL_ID],
|
|
}), { status: 200 }));
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
vi.spyOn(console, "log").mockImplementation(() => {});
|
|
|
|
await createProgram().parseAsync([
|
|
"project", "create",
|
|
"--api-base", "http://localhost:3100",
|
|
"--api-key", "board-token",
|
|
"--company-id", COMPANY_ID,
|
|
"--name", "Launch Site",
|
|
"--status", "planned",
|
|
"--goal-ids", GOAL_ID,
|
|
], { from: "user" });
|
|
|
|
await createProgram().parseAsync([
|
|
"project", "update", PROJECT_ID,
|
|
"--api-base", "http://localhost:3100",
|
|
"--api-key", "board-token",
|
|
"--status", "in_progress",
|
|
], { from: "user" });
|
|
|
|
expect(fetchMock.mock.calls[0]?.[0]).toBe(`http://localhost:3100/api/companies/${COMPANY_ID}/projects`);
|
|
expect(JSON.parse(String(fetchMock.mock.calls[0]?.[1]?.body))).toMatchObject({
|
|
name: "Launch Site",
|
|
status: "planned",
|
|
goalIds: [GOAL_ID],
|
|
});
|
|
expect(fetchMock.mock.calls[1]?.[0]).toBe(`http://localhost:3100/api/projects/${PROJECT_ID}`);
|
|
expect(fetchMock.mock.calls[1]?.[1]?.method).toBe("PATCH");
|
|
});
|
|
|
|
it("lists and deletes projects", async () => {
|
|
const fetchMock = vi
|
|
.fn()
|
|
.mockResolvedValueOnce(new Response(JSON.stringify([{ id: PROJECT_ID, companyId: COMPANY_ID, name: "Launch Site", status: "planned", goalIds: [] }]), { status: 200 }))
|
|
.mockResolvedValueOnce(new Response(JSON.stringify({ id: PROJECT_ID, companyId: COMPANY_ID, name: "Launch Site" }), { status: 200 }));
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
vi.spyOn(console, "log").mockImplementation(() => {});
|
|
|
|
await createProgram().parseAsync([
|
|
"project", "list",
|
|
"--api-base", "http://localhost:3100",
|
|
"--api-key", "board-token",
|
|
"--company-id", COMPANY_ID,
|
|
], { from: "user" });
|
|
|
|
await createProgram().parseAsync([
|
|
"project", "delete", PROJECT_ID,
|
|
"--api-base", "http://localhost:3100",
|
|
"--api-key", "board-token",
|
|
"--yes",
|
|
], { from: "user" });
|
|
|
|
expect(fetchMock.mock.calls[0]?.[0]).toBe(`http://localhost:3100/api/companies/${COMPANY_ID}/projects`);
|
|
expect(fetchMock.mock.calls[1]?.[0]).toBe(`http://localhost:3100/api/projects/${PROJECT_ID}`);
|
|
expect(fetchMock.mock.calls[1]?.[1]?.method).toBe("DELETE");
|
|
});
|
|
|
|
it("creates, updates, lists, and deletes goals", async () => {
|
|
const fetchMock = vi
|
|
.fn()
|
|
.mockResolvedValueOnce(new Response(JSON.stringify({ id: GOAL_ID, companyId: COMPANY_ID, title: "Grow", level: "company", status: "active" }), { status: 201 }))
|
|
.mockResolvedValueOnce(new Response(JSON.stringify({ id: GOAL_ID, companyId: COMPANY_ID, title: "Grow faster", level: "company", status: "active" }), { status: 200 }))
|
|
.mockResolvedValueOnce(new Response(JSON.stringify([{ id: GOAL_ID, companyId: COMPANY_ID, title: "Grow faster", level: "company", status: "active" }]), { status: 200 }))
|
|
.mockResolvedValueOnce(new Response(JSON.stringify({ id: GOAL_ID, companyId: COMPANY_ID, title: "Grow faster" }), { status: 200 }));
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
vi.spyOn(console, "log").mockImplementation(() => {});
|
|
|
|
await createProgram().parseAsync([
|
|
"goal", "create",
|
|
"--api-base", "http://localhost:3100",
|
|
"--api-key", "board-token",
|
|
"--company-id", COMPANY_ID,
|
|
"--title", "Grow",
|
|
"--level", "company",
|
|
"--status", "active",
|
|
], { from: "user" });
|
|
|
|
await createProgram().parseAsync([
|
|
"goal", "update", GOAL_ID,
|
|
"--api-base", "http://localhost:3100",
|
|
"--api-key", "board-token",
|
|
"--title", "Grow faster",
|
|
], { from: "user" });
|
|
|
|
await createProgram().parseAsync([
|
|
"goal", "list",
|
|
"--api-base", "http://localhost:3100",
|
|
"--api-key", "board-token",
|
|
"--company-id", COMPANY_ID,
|
|
], { from: "user" });
|
|
|
|
await createProgram().parseAsync([
|
|
"goal", "delete", GOAL_ID,
|
|
"--api-base", "http://localhost:3100",
|
|
"--api-key", "board-token",
|
|
"--yes",
|
|
], { from: "user" });
|
|
|
|
expect(fetchMock.mock.calls[0]?.[0]).toBe(`http://localhost:3100/api/companies/${COMPANY_ID}/goals`);
|
|
expect(fetchMock.mock.calls[1]?.[0]).toBe(`http://localhost:3100/api/goals/${GOAL_ID}`);
|
|
expect(fetchMock.mock.calls[1]?.[1]?.method).toBe("PATCH");
|
|
expect(fetchMock.mock.calls[2]?.[0]).toBe(`http://localhost:3100/api/companies/${COMPANY_ID}/goals`);
|
|
expect(fetchMock.mock.calls[3]?.[0]).toBe(`http://localhost:3100/api/goals/${GOAL_ID}`);
|
|
expect(fetchMock.mock.calls[3]?.[1]?.method).toBe("DELETE");
|
|
});
|
|
});
|