mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-06 14:02:36 +01:00
## Thinking Path > - Paperclip manages agent work through tasks, projects, and routines. > - Daily QA must exercise the staging app through normal browser and API surfaces. > - A schedule must create real work and retain its result and history. > - Pausing that schedule must prevent the next invocation. > - The routine journey in #18652 passed in QA, while its separate completion journey has not passed. > - This PR delivers the routine test independently and preserves its measured flow and assertions. ## Linked Issues or Issue Description Refs: #18652. This is the routine-only delivery from that PR. The original completion implementation and its failed attempts remain on #18652. ## What Changed - Add the target-independent `routine-scheduled-run` journey with one native run and seven required checks. - Start from the measured routine source `ac4efb7c6f4782ea806661683c656fd2b4cc3189`. Keep its request, seven success assertions, one native-run limit, and 65-second pause check. - Bound each observed GET by the original remaining journey deadline. Preserve the normal API timeout for other callers. Keep the original routine error if final trigger disabling also fails, save a closed secondary receipt, and fail an otherwise successful journey when disabling fails. - Narrow the shared output-reader type to its one-argument GET capability without changing its runtime code. - Register only this case in the catalog, types, feature associations, dispatcher, and definition hash. Keep the strict catalog expectation in sync. - Retain the real Routines component controls and the existing project-flow coverage for the shared browser helper. - Document resource cleanup and the 65-second pause observation. Preserve the current routine map content. ## Verification - The original source passed [QA staging run 41567574185](https://pages.paperclip.ing/evals-qa-smoke-41567574185-1/). TestOps launch 1657 / result 3431 maps to case 718. All seven checks and five phases passed. One scheduler-bound native run, saved output attribution, the full pause window, and cleanup were verified. - Current source `8f62137f130f59fd3e39276e3d60185ddff24517` passed [fresh QA staging run 41582706162](https://pages.paperclip.ing/evals-qa-smoke-41582706162-1/) against Core `09162fe893b464dd2ccdafd14bd3ef1611202a86`. TestOps launch 1855. All seven checks, five phases, and all three workflow jobs passed. The run used one scheduler-bound native turn and observed 65.352 seconds after pause and completion. Canonical evidence collection and normal cleanup completed, with no active operations and the owned agent terminal. - This fresh pass covers the reviewed deadline and failure-reporting changes in the current source. The earlier ac4 pass and the byte-preserving b940 extraction remain historical records under their original conditions; neither failed attempts nor prior source conditions are regraded. - Causal controls: six assertions failed on the old behavior, then all 62 focused controls passed after the repair. Local: 834 related support tests, 41 shared chat/output-reader tests, and 26 unchanged real component controls passed. Runner E2E typecheck, recursive typecheck, build, maps, token gates, and `git diff --check` passed. The temporary output-reader type mismatch exposed by typecheck was corrected by narrowing the capability type. - The first restricted build/typecheck invocations failed because local tsx IPC was denied. A restricted support run also lacked the report CLI output. The same source passed with normal owned local IPC allowed; the original logs remain retained. - The original head's hosted e2e shard 2/8 failed at the unchanged mobile preference frame-count test: expected more than five frames, observed five. The cause is unknown. Its original log remains retained; it is not labeled a proven flake. No CI rerun was requested. - Current-head full CI run 41580423918, attempt 1, passed. The fresh review is 5/5 with zero unresolved threads. The broad local suite was not repeated. The earlier full local run recorded in #18643 had four failures and did not reach 164 serialized groups; this PR does not claim an all-local pass. - Prior failed routine attempts remain recorded. They exposed composer focus, collapsed schedule controls, pending browser events, and Markdown serialization problems. The measured later pass does not regrade those attempts. ## Risks - The shared browser-event helper also serves task creation and project creation. Its regression tests and existing consumers remain included. - The staging pass qualifies the captured source and configuration. The coordinator retains source merging, daily pinning, and plan selection. - The repository test and the unpassed completion test are not registered by this PR. ## Model Used OpenAI GPT-6 through Codex, with tool use and code execution. The exact deployment ID and context window are not exposed by this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes: #` / `Refs: #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub issue/PR references) --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
74 lines
4.4 KiB
TypeScript
74 lines
4.4 KiB
TypeScript
import { mkdtemp, readFile, rm } from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import { enableRoutineScheduleTrigger, routineUiStep, withRoutineTriggerCleanup } from "./routine-schedule-flow.js";
|
|
import { JourneyError } from "./types.js";
|
|
|
|
describe("routine trigger cleanup failure reporting", () => {
|
|
it.each([false, true])("retains the original grade with a secondary disable failure (primary=%s)", async primary => {
|
|
const directory = await mkdtemp(path.join(os.tmpdir(), "routine-cleanup-"));
|
|
const original = new JourneyError("failed", "routine_result_attributed");
|
|
const patch = vi.fn().mockRejectedValue(new Error("private URL and form data"));
|
|
try {
|
|
const result = withRoutineTriggerCleanup({ api: { patch }, triggerRoute: "/api/routine-triggers/owned", directory,
|
|
run: async () => { if (primary) throw original; return "completed"; } });
|
|
if (primary) await expect(result).rejects.toBe(original);
|
|
else await expect(result).rejects.toMatchObject({ outcome: "failed", code: "routine_trigger_disable_failed" });
|
|
const receipt = JSON.parse(await readFile(path.join(directory, "scheduled-routine-cleanup-failure.json"), "utf8"));
|
|
expect(receipt).toMatchObject({ code: "routine_trigger_disable_failed", primaryFailurePreserved: primary });
|
|
expect(JSON.stringify(receipt)).not.toMatch(/private|form data/);
|
|
expect(patch).toHaveBeenCalledExactlyOnceWith("/api/routine-triggers/owned", { enabled: false });
|
|
} finally { await rm(directory, { recursive: true, force: true }); }
|
|
});
|
|
it("keeps the successful outcome when disabling the exact trigger succeeds", async () => {
|
|
const patch = vi.fn().mockResolvedValue({ enabled: false });
|
|
expect(await withRoutineTriggerCleanup({ api: { patch }, triggerRoute: "/api/routine-triggers/owned", directory: "/unused",
|
|
run: async () => "completed" })).toBe("completed");
|
|
expect(patch).toHaveBeenCalledExactlyOnceWith("/api/routine-triggers/owned", { enabled: false });
|
|
});
|
|
});
|
|
|
|
describe("routine UI failure evidence", () => {
|
|
it("retains a closed step code without browser messages or form values", async () => {
|
|
const error = await routineUiStep("select_project", async () => {
|
|
throw new Error("Timeout at https://private.example/?token=secret with form value private-project");
|
|
}).catch(value => value);
|
|
expect(error).toBeInstanceOf(JourneyError);
|
|
expect(error).toMatchObject({ outcome: "failed", code: "routine_select_project_failed", message: "routine_select_project_failed" });
|
|
expect(JSON.stringify(error)).not.toMatch(/private|token|secret/);
|
|
});
|
|
it("keeps a semantic journey failure instead of replacing its evidence code", async () => {
|
|
const original = new JourneyError("failed", "routine_schedule_enable_failed");
|
|
await expect(routineUiStep("enable_trigger", async () => { throw original; })).rejects.toBe(original);
|
|
});
|
|
it("returns the original successful browser response without replaying the action", async () => {
|
|
let count = 0;
|
|
const response = { status: 201 };
|
|
expect(await routineUiStep("submit", async () => { count += 1; return response; })).toBe(response);
|
|
expect(count).toBe(1);
|
|
});
|
|
});
|
|
|
|
|
|
describe("schedule trigger controls", () => {
|
|
it("opens the collapsed schedule editor before its single enable action", async () => {
|
|
let expanded = false, clicks = 0, resolveResponse!: (value: any) => void;
|
|
const response = { status: () => 200 };
|
|
const pending = new Promise<any>(resolve => { resolveResponse = resolve; });
|
|
const schedule = { getByRole: (_role: string, options: { name: string }) => ({ click: async () => {
|
|
if (options.name === "Edit schedule") { expanded = true; return; }
|
|
if (options.name !== "Enable trigger" || !expanded) throw new Error("schedule control is not rendered");
|
|
clicks += 1;
|
|
resolveResponse(response);
|
|
} }) };
|
|
const page = { getByRole: (role: string, options: { name: string }) => {
|
|
if (role === "region" && options.name === "Schedule trigger") return schedule;
|
|
return schedule.getByRole(role, options);
|
|
}, waitForResponse: () => pending } as unknown as Parameters<typeof enableRoutineScheduleTrigger>[0];
|
|
expect(await enableRoutineScheduleTrigger(page, "/api/routine-triggers/owned-trigger")).toBe(response);
|
|
expect(expanded).toBe(true);
|
|
expect(clicks).toBe(1);
|
|
});
|
|
});
|