mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-08 11:23:40 +01:00
## Thinking Path > - Paperclip uses real Product E2E journeys to verify agent work. > - The trusted TestOps controller must bind the reviewed source and retain inspectable evidence. > - The last uniform attempt exposed bounded observation and evidence-retention defects. Its original outcomes remain unchanged. > - The reviewed successor corrects those boundaries with the original model, requests, counts, and clocks. > - Its private framework report stores canonical attachments once. The controller must validate and restore those references before normal reporting. > - This PR ports that reader support and pins the qualified source in one infrastructure change. It does not merge the full catalog or its core repair PRs. ## Linked Issues or Issue Description Refs #19127, #19083, #19086, #19084, #19093, #19095, #19100, #19112. **What happened?** The last uniform attempt retained real failed outcomes. It also lost the multipart-question original when evidence packaging exceeded its unchanged physical byte allowance. Review found independent boundaries in skill navigation, announcement observation, timeline attribution, hire history, credential questions, and team visibility. **Expected behavior** The next run must execute the same ten requests against one reviewed source. The controller must retain complete original evidence, validate private attachment references, and report the actual outcome. Historical failures and missing-original UNKNOWN grades must remain unchanged. **Steps to reproduce** Use the focused source controls linked above. The private framework control uses a real failed Playwright test and a 140 MiB attachment. Legacy duplicate carriers hit the old cap. Canonical original evidence passes both seals and strict archive restoration. The controller restores derived files and the existing TestOps exporter preserves the failed result. **Paperclip version/commit** Qualified candidate: `155dd1bc1c4b85ae107f6a0cd429720caa281367`. The controller port is based on current master. The full candidate catalog stays on its own immutable branch. **Deployment mode** Existing AWS/TestOps job 100, plan 102, branch master. This PR does not dispatch a run. ## What Changed - Pin the published qualified source and its exact launcher and descriptor fixtures. - Preserve current manifest history. Update twelve declaration fields across eleven cases: oracle versions and skill source-file provenance only. Preserve all 244 identities, 242 canonical declarations, queries, setup, human/native counts, clocks, profile, model, retry policy, and global cap of 8. - Port the exact source-owned compact framework helper and private-transfer reader. Keep the three existing required source/controller protocol helpers byte-identical. - Validate both sealed inventories before restoring registered attachments into the derived selected report tree. Verify exact bytes and hashes. Preserve seals and unregistered evidence. - Keep deep JSON, decoded-body, sensitive-key, path, and original/final status checks. Plain-text bodies and registered plain files fail closed if existing diagnostic redaction would change them; JSON remains under structured inspection. Keep all existing physical byte, entry, ZIP, time, privacy, and archive bounds. - Preserve registered clean metadata and attachment bytes. Reject content that needs privacy redaction instead of silently rewriting immutable evidence. ## Verification - 131 existing Node pin, selection, admission, adapter, reconciliation, and security controls pass. The explicit new target assertion and drift negatives remain active. - 86 current-controller controls pass. They cover legacy reports, privacy and static assets, canonical reference guards, both seals, strict archive restoration, derived files, the actual report normalizer, and the actual TestOps/Allure exporter. The original failed result stays failed; screenshot and trace hashes resolve. - Actual P1 controls reject both an unknown password in a decoded plain-text body and an unknown command token in a registered text file. Parent code fails both controls; corrected code passes. The composed source passes 87 affected controls, fresh server declarations, and full E2E typechecking. The old cfe head completed all 49 CI jobs without adverse conclusions, but its review found this real privacy defect. That CI result is not credited to this successor. - The existing report-lock preflight returns already-reviewed at `60f4c06bca47af3ab9d74281f2ef2e1ff559d566b862ba51c2fbe6c8e5bac35b`. - The existing source SDK guard confirms 506 registered inputs, unchanged registry `efa70621e9fb42aa185f7ee616a1a726aa3eccb367e67e28817cedf26ef2ade8`, and unchanged runtime pins. No registry renewal or SDK build was needed. - Source launcher SHA-256: `2b9a6953ee51f0ea0dbbd475b0491d9a6c39a1d6835eeaa912e0dbb7cf987724`. Descriptor SHA-256: `e026d5c000102f8d50397dc59055d187388304f91dbca9a6ccfbe747004cd16d`. - No model call, evaluation dispatch, evidence download, reporting retry, core merge, or permission change was performed. Full current-head CI and review are pending. Separate source PR failures remain disclosed; local controls do not establish universal source CI readiness. - Seven cases have verified passing historical attempts. A uniform passing ten-case run remains unverified. The old lost multipart-question original remains UNKNOWN. ## Risks This changes a trusted evidence reader and the source selected for future measurements. The new helper is included in the controller import closure. Compact references require matching originals; missing, foreign, changed, unsafe, or redaction-required evidence fails closed. Legacy reporter formats remain valid. A single canonical evidence set can still exceed a bound. Current-head CI and material review must pass before normal protected merge. Actual AWS/TestOps evidence remains required afterward. ## Model Used OpenAI `gpt-6.1-sol`, with reasoning, code editing, and tool use. The host does not expose the context-window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
319 lines
13 KiB
TypeScript
319 lines
13 KiB
TypeScript
import { PRIVATE_FRAMEWORK_REPORT, validatePrivateFrameworkReport, inspectPrivateFrameworkMetadata } from "./private-framework-report.js";
|
|
import { spawn } from "node:child_process";
|
|
import {
|
|
mkdir,
|
|
readFile,
|
|
readdir,
|
|
rm,
|
|
writeFile,
|
|
copyFile,
|
|
lstat,
|
|
} from "node:fs/promises";
|
|
import path from "node:path";
|
|
import type { RunnerE2EResult } from "./types.js";
|
|
import { assertRunnerE2EResultsPath } from "./results-root.js";
|
|
import {
|
|
assertSecretFree,
|
|
findSecretLeak,
|
|
findSecretLeakInJsonValues,
|
|
redactText,
|
|
sanitizeJson,
|
|
normalizedSecrets,
|
|
} from "./redaction.js";
|
|
|
|
import { assertPrivateCellDirectories, cellTraceAsset, readPrivateCellTraceAsset, type PrivateCellEvidenceOwner } from "./manual-private-report-assets.js";
|
|
|
|
const TEXT_EXTENSIONS = new Set([
|
|
".json",
|
|
".xml",
|
|
".html",
|
|
".css",
|
|
".js",
|
|
".txt",
|
|
".log",
|
|
".md",
|
|
]);
|
|
const BINARY_EXTENSIONS = new Set([".png", ".webm"]);
|
|
const ACTIVE_CONTENT_EXTENSIONS = new Set([".svg"]);
|
|
const ALLOWED_DIRECTORIES = new Set([
|
|
"snapshots",
|
|
"playwright-output",
|
|
"blob-report",
|
|
"html-report",
|
|
]);
|
|
const ALLOWED_ROOT_FILES = new Set([
|
|
"result.json",
|
|
"final-state.png",
|
|
"failure.png",
|
|
"tool-review-pending.png",
|
|
"decision-pending.png",
|
|
|
|
"first-task-response.png",
|
|
"chat-plan-draft.png",
|
|
"chat-plan-revised.png",
|
|
"server.log",
|
|
"playwright.log",
|
|
"junit.xml",
|
|
]);
|
|
const REQUIRED_PASS_FILES = [
|
|
"final-state.png",
|
|
"result.json",
|
|
"junit.xml",
|
|
path.join("html-report", "index.html"),
|
|
path.join("snapshots", "fixtures.json"),
|
|
path.join("snapshots", "api-state.json"),
|
|
] as const;
|
|
|
|
export function isStandardEvidenceFile(relative: string) {
|
|
const extension = path.extname(relative).toLowerCase();
|
|
return isStandardEvidencePath(relative) && (TEXT_EXTENSIONS.has(extension) || BINARY_EXTENSIONS.has(extension)
|
|
|| extension === ".zip");
|
|
}
|
|
|
|
export interface EvidencePackageResult {
|
|
files: string[];
|
|
leaks: Array<{ file: string; reason: string }>;
|
|
missing: string[];
|
|
}
|
|
|
|
async function walk(root: string, relative = "", privateStandardOnly = false): Promise<string[]> {
|
|
const directory = path.join(root, relative);
|
|
const entries = await readdir(directory, { withFileTypes: true }).catch(
|
|
() => [],
|
|
);
|
|
const files: string[] = [];
|
|
for (const entry of entries) {
|
|
const next = path.join(relative, entry.name);
|
|
// Installed preparation may leave a large, deliberately excluded staging
|
|
// tree. Never enumerate it for private standard-evidence packaging.
|
|
if (privateStandardOnly && !relative && !isStandardEvidencePath(entry.isDirectory() ? path.join(next, "placeholder") : next)) continue;
|
|
if (entry.isDirectory()) files.push(...(await walk(root, next, privateStandardOnly)));
|
|
else if (entry.isFile()) files.push(next);
|
|
}
|
|
return files;
|
|
}
|
|
|
|
export function isStandardEvidencePath(relative: string) {
|
|
const segments = relative.split(path.sep);
|
|
if (segments.length === 1)
|
|
return (
|
|
ALLOWED_ROOT_FILES.has(relative) ||
|
|
/^(?:plan|question)-[a-z0-9-]+\.png$/.test(relative)
|
|
);
|
|
return ALLOWED_DIRECTORIES.has(segments[0]);
|
|
}
|
|
|
|
async function inspectZip(source: string, secrets: readonly string[]) {
|
|
// Failure traces can exceed Node's child-process output buffer. Stream the
|
|
// expanded archive through the exact-value scanner with enough overlap to
|
|
// detect a credential split across stdout chunks, without retaining the
|
|
// archive in memory or weakening fail-closed evidence publication.
|
|
const overlap = Math.max(
|
|
256,
|
|
...secrets.map((secret) => Buffer.byteLength(secret, "utf8") + 16),
|
|
);
|
|
return new Promise<string | null>((resolve) => {
|
|
const unzip = spawn("unzip", ["-p", source], {
|
|
stdio: ["ignore", "pipe", "pipe"],
|
|
});
|
|
let carry = Buffer.alloc(0);
|
|
let leak: string | null = null;
|
|
let spawnError: Error | null = null;
|
|
|
|
unzip.stdout.on("data", (chunk: Buffer) => {
|
|
if (leak) return;
|
|
const data = Buffer.concat([carry, chunk]);
|
|
leak = findSecretLeak(data, secrets, { includeShapes: false });
|
|
carry = data.subarray(Math.max(0, data.length - overlap));
|
|
if (leak) unzip.kill();
|
|
});
|
|
// Drain diagnostics so a noisy unzip cannot block. Error text is withheld
|
|
// because archive paths and contents belong to private attempt evidence.
|
|
unzip.stderr.resume();
|
|
unzip.on("error", (error) => {
|
|
spawnError = error;
|
|
});
|
|
unzip.on("close", (code) => {
|
|
if (leak) return resolve(leak);
|
|
if (spawnError) {
|
|
return resolve(`zip could not be inspected: ${spawnError.message}`);
|
|
}
|
|
return resolve(
|
|
code === 0
|
|
? null
|
|
: `zip could not be inspected: unzip exited with code ${String(code)}`,
|
|
);
|
|
});
|
|
});
|
|
}
|
|
|
|
export async function packageEvidence(input: {
|
|
privateDir: string;
|
|
uploadDir: string;
|
|
secrets: readonly string[];
|
|
expectPassScreenshot: boolean;
|
|
privateCell?: { owner: PrivateCellEvidenceOwner; layout: "original" | "final-wrapper" };
|
|
}): Promise<EvidencePackageResult> {
|
|
if (input.privateCell && !["original", "final-wrapper"].includes(input.privateCell.layout)) throw new Error("Invalid private cell packaging layout");
|
|
if (input.privateCell) await assertPrivateCellDirectories(input.privateCell.owner, input.privateDir, input.uploadDir);
|
|
await rm(input.uploadDir, { recursive: true, force: true });
|
|
await mkdir(input.uploadDir, { recursive: true });
|
|
const files: string[] = [];
|
|
const leaks: EvidencePackageResult["leaks"] = [];
|
|
const available = await walk(input.privateDir, "", Boolean(input.privateCell));
|
|
const standard = available.filter(isStandardEvidencePath);
|
|
|
|
if (input.privateCell && standard.length > 4096) throw new Error("Private cell evidence exceeds entry allowance");
|
|
const privateSecrets = input.privateCell ? normalizedSecrets(input.secrets).flatMap(value => [value, encodeURIComponent(value), Buffer.from(value).toString("base64"), Buffer.from(value).toString("base64url")]) : [];
|
|
const compact = input.privateCell?.layout === "original" && standard.includes(PRIVATE_FRAMEWORK_REPORT)
|
|
? await validatePrivateFrameworkReport(input.privateDir) : undefined;
|
|
const registeredAttachments = new Set(compact?.attachments.map(row => row.path) ?? []);
|
|
let privateBytes = 0;
|
|
for (const relative of standard) {
|
|
const source = path.join(input.privateDir, relative);
|
|
const extension = path.extname(relative).toLowerCase();
|
|
const destination = path.join(input.uploadDir, relative);
|
|
if (input.privateCell) {
|
|
assertSecretFree(relative, privateSecrets, "private cell evidence path");
|
|
const metadata = await lstat(source);
|
|
if (!metadata.isFile() || metadata.isSymbolicLink() || metadata.size > 256 * 1024 * 1024 - privateBytes)
|
|
throw new Error("Private cell evidence exceeds byte allowance");
|
|
privateBytes += metadata.size;
|
|
if (!Number.isSafeInteger(privateBytes)) throw new Error("Invalid private cell evidence byte accounting");
|
|
const asset = cellTraceAsset(relative, input.privateCell.owner, input.privateCell.layout);
|
|
if (asset.reserved) {
|
|
const bytes = await readPrivateCellTraceAsset({ ...input.privateCell, relative, file: source, remaining: metadata.size, secrets: input.secrets });
|
|
await mkdir(path.dirname(destination), { recursive: true, mode: 0o700 });
|
|
await writeFile(destination, bytes!, { mode: 0o600 }); files.push(relative); continue;
|
|
}
|
|
if (!isStandardEvidenceFile(relative)) throw new Error("Unsupported private cell evidence carrier");
|
|
}
|
|
await mkdir(path.dirname(destination), { recursive: true });
|
|
if (ACTIVE_CONTENT_EXTENSIONS.has(extension)) {
|
|
// SVG can execute script when opened directly from an artifact. Keep the
|
|
// source in the disposable private attempt directory, but never admit it
|
|
// to the sanitized CI artifact.
|
|
continue;
|
|
} else if (TEXT_EXTENSIONS.has(extension)) {
|
|
const raw = await readFile(source, "utf8");
|
|
if (input.privateCell && inspectPrivateFrameworkMetadata(relative.split(path.sep).join("/"), raw, input.secrets)) {
|
|
assertSecretFree(raw, input.secrets, "private framework metadata");
|
|
await copyFile(source, destination); files.push(relative); continue;
|
|
}
|
|
const parsed = extension === ".json" ? JSON.parse(raw) : null;
|
|
const leak =
|
|
extension === ".json"
|
|
? findSecretLeakInJsonValues(parsed, input.secrets)
|
|
: findSecretLeak(raw, input.secrets);
|
|
if (leak) leaks.push({ file: relative, reason: leak });
|
|
if (registeredAttachments.has(relative.split(path.sep).join("/"))) {
|
|
if (extension === ".json" ? JSON.stringify(sanitizeJson(parsed, input.secrets)) !== JSON.stringify(parsed) : redactText(raw, input.secrets) !== raw) throw new Error("Private framework attachment requires redaction");
|
|
if (!leak) { await copyFile(source, destination); files.push(relative); }
|
|
continue;
|
|
}
|
|
// Redacting an already serialized JSON string can change escape
|
|
// boundaries around shell commands. Sanitize parsed values instead so
|
|
// uploaded snapshots stay valid JSON.
|
|
const safe =
|
|
extension === ".json"
|
|
? `${JSON.stringify(sanitizeJson(parsed, input.secrets), null, 2)}\n`
|
|
: redactText(raw, input.secrets);
|
|
if (extension === ".json") {
|
|
const safeLeak = findSecretLeakInJsonValues(
|
|
JSON.parse(safe),
|
|
input.secrets,
|
|
);
|
|
if (safeLeak)
|
|
throw new Error(`Secret leak in ${relative}: ${safeLeak}`);
|
|
} else {
|
|
assertSecretFree(safe, input.secrets, relative);
|
|
}
|
|
await writeFile(destination, safe, "utf8");
|
|
files.push(relative);
|
|
} else if (extension === ".zip") {
|
|
const leak = await inspectZip(source, input.secrets);
|
|
if (leak) {
|
|
leaks.push({ file: relative, reason: leak });
|
|
continue;
|
|
}
|
|
await copyFile(source, destination);
|
|
files.push(relative);
|
|
} else if (BINARY_EXTENSIONS.has(extension)) {
|
|
// This raw-byte scan catches embedded plaintext credentials, but cannot
|
|
// inspect rendered pixels. Provider/UI raster and video files remain in
|
|
// the access-controlled CI artifact. The public publisher creates its
|
|
// own synthetic summary image from fixed labels and numeric/status data.
|
|
const raw = await readFile(source);
|
|
const leak = findSecretLeak(raw, input.secrets);
|
|
if (leak) {
|
|
leaks.push({ file: relative, reason: leak });
|
|
continue;
|
|
}
|
|
await copyFile(source, destination);
|
|
files.push(relative);
|
|
}
|
|
}
|
|
|
|
const missing = input.expectPassScreenshot
|
|
? [
|
|
...REQUIRED_PASS_FILES.filter((required) => !files.includes(required) && !(compact && required === path.join("html-report", "index.html"))),
|
|
...(compact || files.some(
|
|
(file) =>
|
|
file.startsWith(`blob-report${path.sep}`) && file.endsWith(".zip"),
|
|
)
|
|
? []
|
|
: [path.join("blob-report", "*.zip")]),
|
|
]
|
|
: [];
|
|
const manifest = {
|
|
schema: "paperclip.runner-e2e.evidence/v1",
|
|
files: [...files].sort(),
|
|
leaks,
|
|
missing,
|
|
};
|
|
const manifestText = `${JSON.stringify(sanitizeJson(manifest, input.secrets), null, 2)}\n`;
|
|
const manifestLeak = findSecretLeakInJsonValues(
|
|
JSON.parse(manifestText),
|
|
input.secrets,
|
|
);
|
|
if (manifestLeak)
|
|
throw new Error(`Secret leak in evidence-manifest.json: ${manifestLeak}`);
|
|
await writeFile(
|
|
path.join(input.uploadDir, "evidence-manifest.json"),
|
|
manifestText,
|
|
"utf8",
|
|
);
|
|
files.push("evidence-manifest.json");
|
|
return { files, leaks, missing };
|
|
}
|
|
|
|
export async function publishRunnerE2EAttemptEvidence(input: {
|
|
result: RunnerE2EResult;
|
|
privateDir: string;
|
|
uploadDir: string;
|
|
resultsRoot: string;
|
|
secrets: readonly string[];
|
|
}): Promise<RunnerE2EResult> {
|
|
let result = input.result;
|
|
const resultPath = path.join(input.privateDir, "result.json");
|
|
const writeResult = () => writeFile(resultPath,
|
|
`${JSON.stringify(sanitizeJson(result, input.secrets), null, 2)}\n`, "utf8");
|
|
await assertRunnerE2EResultsPath(input.resultsRoot, input.uploadDir);
|
|
await writeResult();
|
|
const evidence = await packageEvidence({ ...input, expectPassScreenshot: result.status === "passed" });
|
|
if (evidence.leaks.length > 0 || evidence.missing.length > 0) {
|
|
result = {
|
|
...result,
|
|
status: "failed",
|
|
failureClass: evidence.leaks.length > 0 ? "secret_leak" : "permanent_infrastructure",
|
|
error: evidence.leaks.length > 0
|
|
? `Secret leak rejected from evidence: ${evidence.leaks.map(leak => leak.file).join(", ")}`
|
|
: `Required evidence missing: ${evidence.missing.join(", ")}`,
|
|
};
|
|
await writeResult();
|
|
await assertRunnerE2EResultsPath(input.resultsRoot, input.uploadDir);
|
|
await packageEvidence({ ...input, expectPassScreenshot: false });
|
|
}
|
|
return result;
|
|
}
|