mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-25 02:26:12 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The feature map describes product areas and verification entry points. > - Storybook has 223 story suites that show production components, proposals, and retained history. > - The parent PR maps those suites to features, but their folders and sidebar still use unrelated groups. > - This pull request puts the existing suites under feature folders and uses the feature map's names and order in the sidebar. > - Explicit meta IDs preserve existing story links while the titles change. > - Contributors can find stories through the same product structure without losing examples. ## Linked Issues or Issue Description Refs #16046. This is the requested follow-up. Parent #16046 is merged. This PR now targets master, with its single follow-up commit rebased onto the parent squash merge. The Storybook implementation is unchanged by that rebase. Related open Storybook PRs were checked; this change organizes existing suites and adds no product capability. ## What Changed - Move all 223 story files into folders named for their primary feature area. Keep useful scenario groups below the feature's sidebar label. - Order the sidebar by the eight feature-map sections. Put Overview first and shared Foundations last. Leave areas with no stories out of the sidebar. - Move 19 support files into `ui/storybook/support/` and update relative imports and active documentation. - Preserve all 2,210 story IDs and the single docs ID through explicit CSF meta IDs. Keep all entry names and story exports. - Record stable IDs and sidebar titles in the downstream catalog. Validate feature folders, title prefixes, and IDs. Update the maintenance skill and review evidence. ## Verification - Storybook build passed. Built index comparison against parent `75bd3c977cd828d5222823850339e8204f40eb47` found the same 2,211 entries, IDs, and names. - UI typecheck passed (`ui/node_modules/.bin/tsc -b` from `ui`, invoked as `./node_modules/.bin/tsc -b`). - UI Vitest project: 728 files and 8,176 tests passed. - Catalog checker and its nine tests passed. Feature-map checks, token gates, and the maintenance-skill validator passed. - Chromium: nine existing play cases and one render case reached `storyFinished: success` with no page exceptions. The guide rendered, sidebar sections followed map order, and a search for `steering/queue` opened its preserved story link. - Source comparison found only meta title/ID changes, rebased relative references, and updated fixture path text in story files. - To inspect: build Storybook, start `node scripts/serve-storybook-static.mjs --port 6136`, and open the Overview guide. Expand feature folders and use existing story links. - The complete repository suite was not repeated for this organization change. The parent records a backend timeout that passed in isolation, without a complete broad-suite pass. Visual comparisons remain blocked by the unpublished empty baseline. The separate fixture-server story was not run. ## Risks - Open branches that add stories under old paths will need to choose a feature folder and update the catalog. Cross-feature suites have one primary home and retain related capability references. - Sidebar paths change; story and docs IDs remain stable. Automated references to source paths may need the new location. - This is one requested follow-up with 258 changed files, mostly moves. It exceeds the usual review-size guideline because splitting it would leave the sidebar and folder convention partly migrated. - Browser verification samples ten stories, not all 2,210. Existing production/prototype classifications and review gaps remain unchanged. - Required CI gates and a 5/5 review passed on the original head. Fresh checks and review are running for the rebased head. Catalog validation and all nine checker tests passed after rebase; UI, map, skill, and checker contents are identical to the original reviewed head. ## Model Used - OpenAI Codex, GPT-6. The exact runtime model ID and context-window size are not exposed in this session. Used reasoning, repository inspection, code execution, and local browser automation. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
120 lines
3.6 KiB
TypeScript
120 lines
3.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
import { act } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import { MemoryRouter } from "react-router-dom";
|
|
import { expect, it, vi } from "vitest";
|
|
import { updateFastResponseSchema } from "@paperclipai/shared";
|
|
import { FastResponseSettingsView } from "./FastResponseSettings";
|
|
import { choices } from "../../../storybook/support/decision-models/fixtures";
|
|
vi.mock("@/context/CompanyContext", () => ({
|
|
useCompany: () => ({ selectedCompanyId: "company-storybook" }),
|
|
}));
|
|
(
|
|
globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }
|
|
).IS_REACT_ACT_ENVIRONMENT = true;
|
|
it("saves only API settings and keeps the draft across unchanged query refetches", async () => {
|
|
const container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
const root = createRoot(container),
|
|
onSave = vi.fn();
|
|
const settings = {
|
|
companyId: "company-storybook",
|
|
enabled: false,
|
|
connectionId: null,
|
|
grantId: null,
|
|
provider: null,
|
|
model: null,
|
|
allowSponsored: false,
|
|
};
|
|
const render = () => (
|
|
<MemoryRouter>
|
|
<FastResponseSettingsView
|
|
settings={{ ...settings }}
|
|
choices={choices}
|
|
onSave={onSave}
|
|
onTest={vi.fn()}
|
|
/>
|
|
</MemoryRouter>
|
|
);
|
|
try {
|
|
await act(async () => root.render(render()));
|
|
await act(async () =>
|
|
[...container.querySelectorAll("button")]
|
|
.find((b) => b.textContent?.includes("Company OpenRouter"))!
|
|
.click(),
|
|
);
|
|
await act(async () => root.render(render()));
|
|
expect(
|
|
container.querySelector<HTMLInputElement>("input[list]")?.value,
|
|
).toBe("openai/gpt-oss-120b");
|
|
await act(async () =>
|
|
[...container.querySelectorAll("button")]
|
|
.find((b) => b.textContent === "Save fast response")!
|
|
.click(),
|
|
);
|
|
const saved = onSave.mock.calls[0][0];
|
|
expect(updateFastResponseSchema.safeParse(saved).success).toBe(true);
|
|
expect(saved).toMatchObject({
|
|
enabled: true,
|
|
allowSponsored: false,
|
|
connectionId: choices[1]!.id,
|
|
});
|
|
expect(saved).not.toHaveProperty("companyId");
|
|
expect(saved).not.toHaveProperty("provider");
|
|
} finally {
|
|
act(() => root.unmount());
|
|
container.remove();
|
|
}
|
|
});
|
|
it("selects a newly created connection and recommends its default model", async () => {
|
|
const container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
const root = createRoot(container),
|
|
onSave = vi.fn(),
|
|
onConnectionChange = vi.fn();
|
|
const settings = {
|
|
companyId: "company-storybook",
|
|
enabled: false,
|
|
connectionId: null,
|
|
grantId: null,
|
|
provider: null,
|
|
model: null,
|
|
allowSponsored: true,
|
|
};
|
|
try {
|
|
await act(async () =>
|
|
root.render(
|
|
<MemoryRouter>
|
|
<FastResponseSettingsView
|
|
settings={settings}
|
|
choices={choices}
|
|
newlyConnectedId={choices[1]!.id}
|
|
onConnectionChange={onConnectionChange}
|
|
onSave={onSave}
|
|
onTest={vi.fn()}
|
|
/>
|
|
</MemoryRouter>,
|
|
),
|
|
);
|
|
expect(
|
|
container.querySelector<HTMLInputElement>("input[list]")?.value,
|
|
).toBe("openai/gpt-oss-120b");
|
|
await act(async () =>
|
|
[...container.querySelectorAll("button")]
|
|
.find((b) => b.textContent === "Save fast response")!
|
|
.click(),
|
|
);
|
|
expect(onSave).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
connectionId: choices[1]!.id,
|
|
enabled: true,
|
|
allowSponsored: true,
|
|
}),
|
|
);
|
|
expect(onConnectionChange).toHaveBeenCalledWith(choices[1]!.id);
|
|
} finally {
|
|
act(() => root.unmount());
|
|
container.remove();
|
|
}
|
|
});
|