mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-31 06:04:11 +01:00
<!-- entire-trail-link-start --> https://entire.com/gh/paperclipai/-/trails/32/changes/paperclip/32 <!-- entire-trail-link-end --> ## Thinking Path > - Paperclip manages AI agents and preserves their work after an interruption. > - Native Stop must confirm termination and save the workspace. > - Task and run views must show the current recovery receipt. > - A new external reply can arrive while that cleanup is pending. > - The reply must return to its original chat owner after cleanup. > - A successful fresh retry also becomes the task’s bound workspace for its next ordinary turn. > - Managed computer updates can invalidate a saved snapshot qualification. > - This pull request fixes those instructions, acknowledgements, handoffs and the existing native-agent Test path. > - The operator can continue with new input while the stopped turn remains preserved. ## Linked Issues or Issue Description **What happened?** Stopped native runs could keep the initial workspace-repair instruction after files were recovered. Native Stop could also leave the shared cancellation state at requested after remote termination was confirmed. A new GitHub reply saved during cleanup could then remain queued because cleanup did not ask its original inbound owner to reconsider the receipt. After a managed snapshot update, an existing native agent could also need qualification while the generic environment Test required instance-admin access. **Expected behavior** Show the current saved-work state. Acknowledge Stop only after exact termination proof. Let an authorized operator use the existing saved-agent Run test to qualify its current computer. After cleanup, recheck the saved reply's current authority and admit it once as new input. Preserve the stopped run and uncertain external effects. **Steps to reproduce** 1. Stop an active native turn before it returns a semantic result. 2. Send a new authorized external reply while cleanup is pending. 3. Let workspace recovery and provider cleanup finish. Inspect the run instruction, Stop acknowledgement and queued reply. Related work: #17594 preserves native processes through controller outages. #17401 addresses a separate bootstrap failure. This pull request does not replace those fixes. ## What Changed - Use the exact run's workspace recovery receipt for task and run guidance, including the Activity ledger. - Retire an obsolete exact-session notice through the existing bounded reconciler. Preserve the separate no-replay hold. - Write the shared native Stop acknowledgement only after the audited Stop intent and every exact remote lease receipt match. - Delegate saved external input to the live inbound owner. Recheck its source, actor, endpoint, principal and conversation generation. Promote the same receipt in the transaction that creates its new run. - Use that owner from the cleanup callback and existing stranded-queue catch-up after a lost callback or restart. A denied source cannot abort other items. - Reuse the current private task directory after a successful fresh retry. Re-read the company/task/workspace binding and validate the canonical stable or attempt namespace without recreating missing files; keep a later fresh retry separate. - Extend the existing agent-scoped qualification owner to native agents. The clean saved-agent Test qualifies its exact computer before runtime testing. Reuse a current proof; require a real probe and verified cleanup for a stale proof. Preserve draft tests and metadata-only external/pool previews. - Update execution semantics, capability maps and the recovery verification recipe. Add a production-page Storybook interaction for the normal native Test. ## Verification - **Red:** persisted recovery states returned stale instructions; an exact terminated native lease left shared Stop requested; the real GitHub subscribed-message fixture left zero successors after cleanup. The controlled baseline restored the previous production source, reproduced the failure, then restored the fixed bytes with matching SHA-256 hashes. - **Green:** 382 durable-chat, native-continuation, Stop and recovery tests pass. The real GitHub/PostgreSQL handoff matrix passes 12/12. It covers callback, application restart, callback/sweep race, valid input behind a deleted source, and denial for unknown stop, wrong allocation, paused endpoint, revoked principal, deleted or changed source, changed conversation generation and foreign scope. Repeated callbacks preserve one receipt, its actor, one successor and the unchanged stopped predecessor. - **Workspace continuation red/green:** the real PostgreSQL preparation flow created a fresh attempt and saved a marker, then rejected the next ordinary turn with the same binding mismatch observed in deployed use. The repaired preparation and filesystem suites pass 86/86: stable and attempt-root reuse, saved-marker preservation, a later clean sibling, changed current bindings, foreign company/task, closed workspace, traversal, missing path and symlink refusal. No task row reset or old-turn replay is used. - **Qualification red/green:** a native saved-agent qualification returned 422, and its normal Test skipped qualification. The repaired path passes 224 qualification/immutable-snapshot/environment tests and 176 UI/upgrade tests. It covers revoked authority, foreign or changed computer, current-proof reuse, failed/missing proof, draft settings, settings changed during the probe, and external/pool previews. On exact current source, the real local Harness / Runtime UI also qualified a newly saved disposable Computer with missing proof through actual Daytona, then completed the actual OpenCode/OpenRouter hello probe using `openrouter/deepseek/deepseek-v4.1-flash-1017`. Supported availability changed from Legacy-only to Paperclip Runner after proof persistence. Qualification and runtime leases both completed normal release/cleanup. The five prior task run IDs were unchanged; no task wake was created. This is macOS source-server/UI with real Linux Daytona and provider services, not a hosted UI claim. Test probes are archived by the existing inspection contract; release does not claim physical deletion. - Full workspace `pnpm -r typecheck`, `pnpm build`, token, map and diff checks pass at `f6450f4739fc8141815b8b7c35fde22a655c5f90`. The broad local `pnpm test:run` passed 24,899 tests and reported one existing nested-clone test timeout at 15 seconds. The complete failing file then passed 21/21 with the normal timeout; the exact case also passed on the pinned earlier baseline. The broad runner stopped before its later groups. No timeout or production workaround was added. Prior head `f6450f4` has 53 successful checks, two conditional Storybook skips and Greptile 5/5 with no inline threads. New workspace-reuse head `fcb13399ec70f92f71bd8250081251dca3f48962` passes workspace typecheck, full build, 86 scoped tests, maps and diff checks; Current-head CI has 53 successful checks and two conditional Storybook skips; Greptile is 5/5 with no inline findings. Deployed ordinary-turn reuse acceptance passed as described below. - **Hosted Stop proof:** the real GitHub issue-mention path used native OpenCode, `openrouter/deepseek/deepseek-v4.1-flash-1017`, Daytona and an exact low-trust task boundary. Normal UI Stop interrupted an active Bash call. Native and shared acknowledgements matched the exact lease. Automatic recovery saved exactly `STARTED\n` (8 bytes), with no finish marker. Reload showed Stopped and saved work recovered. Only the original cancelled run remained. Normal five-minute cleanup completed its exact provider-destruction transition. - **Limits:** the provider buffered command output, so the marker was read after recovery. The approved local provider credential could not inspect the hosted sandbox; its 404 is not deletion proof. Cleanup success comes from the exact lease's platform destruction transition. An earlier hosted stale instruction disappeared after rollout with unchanged raw run/action data; that historical cause remains unexplained. Original incident holds and publication receipts were untouched. - **Hosted handoff proof:** after QA deployed the combined candidate containing `46b2e99`, startup admitted the previously saved GitHub author reply without another comment, Retry or manual action. The new native run used the exact original wake receipt and saved comment. It completed once, committed an external-response wait, preserved the stopped predecessor, emptied the queue and left the task In review. The answer appeared in the original GitHub conversation. Workspace finalization and the exact lease's normal destruction transition succeeded. - **Hosted workspace proof:** on the combined candidate containing `fcb13399`, normal Retry preserved the original authenticated GitHub request and completed a fresh native attempt. One later ordinary same-head author reply then completed in the exact same workspace ID and attempt directory, with no Retry/fresh directive. Its input tree digest matched the Retry's finalized digest; final copyback preserved that digest. The persisted assessment row and all five prior run records were unchanged, exactly one new reply run completed, and the task returned to In review with an empty queue and no live run. Both exact leases completed normal verified destruction. This used real native OpenCode, the exact DeepSeek/OpenRouter model and Daytona, without workspace-row repair or a new remote marker. - **Publication limit:** the workspace audit compares the persisted assessment and run history. The ordinary reply exposed a separate destination-summary fallback that changed the visible GitHub summary despite the preserved assessment row. The publication track is repairing that behavior; this proof does not claim the visible summary was preserved. - **Deployment boundary:** current-head CI/review and hosted same-source Retry/ordinary-workspace reuse acceptance passed. The separate visible-summary publication failure remains owned by the publication track. Combined hosted UI confirmation of the native-agent Test path is coordinated separately. Actual missing-proof UI/provider qualification has passed in the isolated local instance above; prior hosted Stop and same-input handoff proof remains separate. No merge or deployment is performed by this pull request. ## Risks Recovery state and termination receipts must match the exact source run and allocation. Missing or foreign proof keeps the hold. The chat owner must retain the original receipt and actor and recheck current authority. Cleanup cannot grant authority or replay the stopped turn. Existing native ownership, Stop, budget, permission and uncertain-effect guards remain in place. ## Model Used OpenAI GPT-6.1 Sol (`gpt-6.1-sol`) through Codex, with reasoning, repository tools, source editing and test execution. The context-window size is not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass (affected suites and isolated failing file pass; broad timeout retained above) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green (current fcb has 53 successful checks/two conditional Storybook skips) - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
649 lines
23 KiB
TypeScript
649 lines
23 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import type { ComponentProps, ReactNode } from "react";
|
|
import { createRoot, type Root } from "react-dom/client";
|
|
import type { ActivityEvent, Issue, RunLivenessState } from "@paperclipai/shared";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import type { RunForIssue } from "../api/activity";
|
|
import type { ActiveRunForIssue } from "../api/heartbeats";
|
|
import { IssueRunLedgerContent } from "./IssueRunLedger";
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({ children, to, ...props }: { children: ReactNode; to: string } & ComponentProps<"a">) => (
|
|
<a href={to} {...props}>{children}</a>
|
|
),
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
let container: HTMLDivElement;
|
|
let root: Root;
|
|
|
|
beforeEach(() => {
|
|
vi.useFakeTimers();
|
|
vi.setSystemTime(new Date("2026-04-18T20:00:00.000Z"));
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
});
|
|
|
|
afterEach(() => {
|
|
act(() => root.unmount());
|
|
container.remove();
|
|
vi.useRealTimers();
|
|
});
|
|
|
|
function render(ui: ReactNode) {
|
|
act(() => {
|
|
root.render(ui);
|
|
});
|
|
}
|
|
|
|
function createRun(overrides: Partial<RunForIssue> = {}): RunForIssue {
|
|
return {
|
|
runId: "run-00000000",
|
|
status: "succeeded",
|
|
agentId: "agent-1",
|
|
adapterType: "codex_local",
|
|
startedAt: "2026-04-18T19:58:00.000Z",
|
|
finishedAt: "2026-04-18T19:59:00.000Z",
|
|
createdAt: "2026-04-18T19:58:00.000Z",
|
|
invocationSource: "assignment",
|
|
usageJson: null,
|
|
resultJson: null,
|
|
livenessState: "advanced",
|
|
livenessReason: "Run produced concrete action evidence: 2 activity event(s)",
|
|
continuationAttempt: 0,
|
|
lastUsefulActionAt: "2026-04-18T19:59:00.000Z",
|
|
nextAction: null,
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createActivity(overrides: Partial<ActivityEvent> = {}): ActivityEvent {
|
|
return {
|
|
id: "activity-1",
|
|
companyId: "company-1",
|
|
actorType: "system",
|
|
actorId: "system",
|
|
action: "issue.updated",
|
|
entityType: "issue",
|
|
entityId: "issue-1",
|
|
agentId: null,
|
|
runId: null,
|
|
details: null,
|
|
createdAt: new Date("2026-04-18T19:57:00.000Z"),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createIssue(overrides: Partial<Issue> = {}): Issue {
|
|
return {
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Child issue",
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
issueNumber: null,
|
|
identifier: "PAP-1",
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
createdAt: new Date("2026-04-18T19:00:00.000Z"),
|
|
updatedAt: new Date("2026-04-18T19:00:00.000Z"),
|
|
...overrides,
|
|
workMode: overrides.workMode ?? "standard",
|
|
};
|
|
}
|
|
|
|
function createActiveRun(overrides: Partial<ActiveRunForIssue> = {}): ActiveRunForIssue {
|
|
return {
|
|
id: "run-live-1",
|
|
status: "running",
|
|
invocationSource: "assignment",
|
|
triggerDetail: null,
|
|
startedAt: "2026-04-18T19:58:00.000Z",
|
|
finishedAt: null,
|
|
createdAt: "2026-04-18T19:58:00.000Z",
|
|
agentId: "agent-1",
|
|
agentName: "CodexCoder",
|
|
adapterType: "codex_local",
|
|
outputSilence: {
|
|
lastOutputAt: "2026-04-18T19:00:00.000Z",
|
|
lastOutputSeq: 4,
|
|
lastOutputStream: "stdout",
|
|
silenceStartedAt: "2026-04-18T19:30:00.000Z",
|
|
silenceAgeMs: 45 * 60 * 1000,
|
|
level: "critical",
|
|
suspicionThresholdMs: 10 * 60 * 1000,
|
|
criticalThresholdMs: 30 * 60 * 1000,
|
|
snoozedUntil: null,
|
|
evaluationIssueId: "issue-eval-1",
|
|
evaluationIssueIdentifier: "PAP-404",
|
|
evaluationIssueAssigneeAgentId: "agent-owner",
|
|
},
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function renderLedger(props: Partial<ComponentProps<typeof IssueRunLedgerContent>> = {}) {
|
|
render(
|
|
<IssueRunLedgerContent
|
|
runs={props.runs ?? []}
|
|
liveRuns={props.liveRuns}
|
|
activeRun={props.activeRun}
|
|
issueStatus={props.issueStatus ?? "in_progress"}
|
|
childIssues={props.childIssues ?? []}
|
|
agentMap={props.agentMap ?? new Map([["agent-1", { name: "CodexCoder" }]])}
|
|
activityEvents={props.activityEvents}
|
|
renderActivityEvent={props.renderActivityEvent}
|
|
resolveUserLabel={props.resolveUserLabel}
|
|
pendingWatchdogDecision={props.pendingWatchdogDecision}
|
|
canRecordWatchdogDecisions={props.canRecordWatchdogDecisions}
|
|
watchdogDecisionError={props.watchdogDecisionError}
|
|
onWatchdogDecision={props.onWatchdogDecision}
|
|
/>,
|
|
);
|
|
}
|
|
|
|
describe("IssueRunLedger", () => {
|
|
it("renders every liveness state with exhausted continuation context", () => {
|
|
const states: RunLivenessState[] = [
|
|
"advanced",
|
|
"plan_only",
|
|
"empty_response",
|
|
"blocked",
|
|
"failed",
|
|
"completed",
|
|
"needs_followup",
|
|
];
|
|
|
|
renderLedger({
|
|
runs: states.map((state, index) =>
|
|
createRun({
|
|
runId: `run-${index}0000000`,
|
|
createdAt: `2026-04-18T19:5${index}:00.000Z`,
|
|
livenessState: state,
|
|
livenessReason: state === "needs_followup"
|
|
? "Run produced useful output but no concrete action evidence; continuation attempts exhausted"
|
|
: `state ${state}`,
|
|
continuationAttempt: state === "needs_followup" ? 3 : 0,
|
|
}),
|
|
),
|
|
});
|
|
|
|
expect(container.textContent).toContain("Advanced");
|
|
expect(container.textContent).toContain("Plan only");
|
|
expect(container.textContent).toContain("Empty response");
|
|
expect(container.textContent).toContain("Blocked");
|
|
expect(container.textContent).toContain("Failed");
|
|
expect(container.textContent).toContain("Completed");
|
|
expect(container.textContent).toContain("Needs follow-up");
|
|
expect(container.textContent).toContain("Exhausted");
|
|
expect(container.textContent).toContain("Continuation attempt 3");
|
|
});
|
|
|
|
it("renders historical runs without liveness metadata as unavailable", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
livenessState: null,
|
|
livenessReason: null,
|
|
continuationAttempt: undefined,
|
|
lastUsefulActionAt: null,
|
|
nextAction: null,
|
|
resultJson: null,
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("No liveness data");
|
|
expect(container.textContent).toContain("Stop Unavailable");
|
|
expect(container.textContent).toContain("Last useful action Unavailable");
|
|
});
|
|
|
|
it("interleaves run rows and activity rows by timestamp", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-oldest",
|
|
startedAt: "2026-04-18T19:55:00.000Z",
|
|
createdAt: "2026-04-18T19:55:00.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-newest",
|
|
startedAt: "2026-04-18T19:59:00.000Z",
|
|
createdAt: "2026-04-18T19:59:00.000Z",
|
|
}),
|
|
],
|
|
activityEvents: [
|
|
createActivity({
|
|
id: "activity-middle",
|
|
action: "activity-middle",
|
|
createdAt: new Date("2026-04-18T19:57:00.000Z"),
|
|
}),
|
|
],
|
|
renderActivityEvent: (event) => (
|
|
<div data-testid={`activity-${event.id}`}>{event.action}</div>
|
|
),
|
|
});
|
|
|
|
const text = container.textContent ?? "";
|
|
const newestIndex = text.indexOf("run-newe");
|
|
const activityIndex = text.indexOf("activity-middle");
|
|
const oldestIndex = text.indexOf("run-olde");
|
|
|
|
expect(newestIndex).toBeGreaterThanOrEqual(0);
|
|
expect(activityIndex).toBeGreaterThan(newestIndex);
|
|
expect(oldestIndex).toBeGreaterThan(activityIndex);
|
|
});
|
|
|
|
it("shows live runs as pending final checks without missing-data language", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
status: "running",
|
|
finishedAt: null,
|
|
livenessState: null,
|
|
livenessReason: null,
|
|
continuationAttempt: 0,
|
|
lastUsefulActionAt: null,
|
|
nextAction: null,
|
|
resultJson: null,
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("Running now by CodexCoder");
|
|
expect(container.textContent).toContain("Checks after finish");
|
|
expect(container.textContent).toContain("Last useful action No action recorded yet");
|
|
expect(container.textContent).toContain("Stop Still running");
|
|
expect(container.textContent).not.toContain("Liveness pending");
|
|
expect(container.textContent).not.toContain("initial attempt");
|
|
});
|
|
|
|
it("surfaces scheduled retry timing and exhaustion state without opening logs", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-scheduled",
|
|
status: "scheduled_retry",
|
|
finishedAt: null,
|
|
livenessState: null,
|
|
livenessReason: null,
|
|
retryOfRunId: "run-root",
|
|
scheduledRetryAt: "2026-04-18T20:15:00.000Z",
|
|
scheduledRetryAttempt: 2,
|
|
scheduledRetryReason: "transient_failure",
|
|
}),
|
|
createRun({
|
|
runId: "run-exhausted",
|
|
status: "failed",
|
|
createdAt: "2026-04-18T19:57:00.000Z",
|
|
retryOfRunId: "run-root",
|
|
scheduledRetryAttempt: 4,
|
|
scheduledRetryReason: "transient_failure",
|
|
retryExhaustedReason: "Bounded retry exhausted after 4 scheduled attempts; no further automatic retry will be queued",
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("Retry scheduled");
|
|
expect(container.textContent).toContain("Attempt 2");
|
|
expect(container.textContent).toContain("Transient failure");
|
|
expect(container.textContent).toContain("Next retry");
|
|
expect(container.textContent).toContain("Retry exhausted");
|
|
expect(container.textContent).toContain("no further automatic retry will be queued");
|
|
expect(container.textContent).toContain("Manual intervention required");
|
|
});
|
|
|
|
it("labels max-turn stops and continuation retries without confusing them with per-run turns", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-scheduled-continuation",
|
|
status: "scheduled_retry",
|
|
finishedAt: null,
|
|
livenessState: null,
|
|
livenessReason: null,
|
|
retryOfRunId: "run-max-turns",
|
|
scheduledRetryAt: "2026-04-18T20:15:00.000Z",
|
|
scheduledRetryAttempt: 1,
|
|
scheduledRetryReason: "max_turns_continuation",
|
|
}),
|
|
createRun({
|
|
runId: "run-max-turns",
|
|
resultJson: { stopReason: "max_turns_exhausted" },
|
|
createdAt: "2026-04-18T19:57:00.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-continuation-exhausted",
|
|
status: "failed",
|
|
createdAt: "2026-04-18T19:56:00.000Z",
|
|
retryOfRunId: "run-max-turns",
|
|
scheduledRetryAttempt: 3,
|
|
scheduledRetryReason: "max_turns_continuation",
|
|
retryExhaustedReason: "Bounded retry exhausted after 3 scheduled attempts; no further automatic retry will be queued",
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("Continuation scheduled");
|
|
expect(container.textContent).toContain("Max-turn continuation");
|
|
expect(container.textContent).toContain("Next continuation");
|
|
expect(container.textContent).toContain("Stop max turns exhausted");
|
|
expect(container.textContent).toContain("Continuation exhausted");
|
|
});
|
|
|
|
it("shows timeout, cancel, and budget stop reasons without raw logs", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-timeout",
|
|
resultJson: { stopReason: "timeout", timeoutFired: true, effectiveTimeoutSec: 30 },
|
|
}),
|
|
createRun({
|
|
runId: "run-cancel",
|
|
resultJson: { stopReason: "cancelled" },
|
|
createdAt: "2026-04-18T19:57:00.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-budget",
|
|
resultJson: { stopReason: "budget_paused" },
|
|
createdAt: "2026-04-18T19:56:00.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-background-task",
|
|
resultJson: { stopReason: "unmanaged_background_task_stopped" },
|
|
createdAt: "2026-04-18T19:55:30.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-paused",
|
|
resultJson: { stopReason: "paused" },
|
|
createdAt: "2026-04-18T19:55:00.000Z",
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("timeout (30s timeout)");
|
|
expect(container.textContent).toContain("cancelled");
|
|
expect(container.textContent).toContain("budget paused");
|
|
expect(container.textContent).toContain("unmanaged background task stopped");
|
|
expect(container.textContent).toContain("paused by board");
|
|
});
|
|
|
|
it("surfaces active and completed child issue summaries", () => {
|
|
renderLedger({
|
|
childIssues: [
|
|
createIssue({ id: "child-1", identifier: "PAP-2", title: "Implement worker handoff", status: "in_progress" }),
|
|
createIssue({ id: "child-2", identifier: "PAP-3", title: "Verify final report", status: "done" }),
|
|
createIssue({ id: "child-3", identifier: "PAP-4", title: "Cancelled experiment", status: "cancelled" }),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("Child work");
|
|
expect(container.textContent).toContain("1 active, 1 done, 1 cancelled");
|
|
expect(container.textContent).toContain("PAP-2");
|
|
expect(container.textContent).toContain("Implement worker handoff");
|
|
|
|
renderLedger({
|
|
childIssues: [
|
|
createIssue({ id: "child-2", identifier: "PAP-3", title: "Verify final report", status: "done" }),
|
|
createIssue({ id: "child-3", identifier: "PAP-4", title: "Cancelled experiment", status: "cancelled" }),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("all 2 terminal (1 done, 1 cancelled)");
|
|
});
|
|
|
|
it("shows the current execution instruction and clears stale instructions after a recorded successor", () => {
|
|
const execution = {
|
|
phase: "recovery_needed" as const, label: "Stopped", cause: "native_continuation_requires_reconciliation",
|
|
lastConfirmedActivityAt: null, retryAt: null, attempt: 1, maxAttempts: 3,
|
|
recoveryOwner: null, nextAction: "Saved work recovered. Send a message to continue.",
|
|
permittedActions: ["inspect_run"] as const, predecessorRunId: null, successorRunId: null,
|
|
};
|
|
const stopped = createRun({ status: "failed", nextAction: "Repair the retained sandbox.",
|
|
execution: { ...execution, permittedActions: ["inspect_run"] } });
|
|
renderLedger({ runs: [stopped] });
|
|
expect(container.textContent).toContain(execution.nextAction);
|
|
expect(container.textContent).not.toContain("Repair the retained sandbox.");
|
|
renderLedger({ runs: [{ ...stopped, execution: { ...stopped.execution!, phase: "completed",
|
|
label: "Continued in another run", nextAction: null, successorRunId: "successor" } }] });
|
|
expect(container.textContent).not.toContain("Next action:");
|
|
});
|
|
|
|
it("uses wrapping-friendly markup for long next action text", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
nextAction: "Continue investigating this intentionally-long-next-action-token-that-needs-to-wrap-cleanly-on-mobile-and-desktop-without-overlapping-controls.",
|
|
}),
|
|
],
|
|
});
|
|
|
|
const nextAction = [...container.querySelectorAll("span")]
|
|
.find((node) => node.textContent?.includes("intentionally-long-next-action-token"));
|
|
expect(nextAction?.className).toContain("break-words");
|
|
expect(container.textContent).toContain("Next action:");
|
|
});
|
|
|
|
it("shows when older runs are clipped from the ledger", () => {
|
|
renderLedger({
|
|
runs: Array.from({ length: 22 }, (_, index) =>
|
|
createRun({
|
|
runId: `run-${index.toString().padStart(8, "0")}`,
|
|
createdAt: `2026-04-18T19:${String(index).padStart(2, "0")}:00.000Z`,
|
|
}),
|
|
),
|
|
});
|
|
|
|
expect(container.textContent).toContain("2 older items not shown");
|
|
});
|
|
|
|
it("renders legacy evaluation context with watchdog actions and a silence badge", () => {
|
|
const onWatchdogDecision = vi.fn();
|
|
renderLedger({
|
|
runs: [createRun({ runId: "run-live-1", status: "running", finishedAt: null })],
|
|
activeRun: createActiveRun(),
|
|
onWatchdogDecision,
|
|
});
|
|
|
|
expect(container.textContent).toContain("Critical output silence");
|
|
expect(container.textContent).toContain("PAP-404");
|
|
expect(container.textContent).toContain("Critical silence");
|
|
expect(container.textContent).toContain("Paperclip did not create new delegated recovery work");
|
|
const watchdogBanner = Array.from(container.querySelectorAll("p"))
|
|
.find((node) => node.textContent?.includes("Critical output silence"))
|
|
?.closest("div");
|
|
expect(watchdogBanner?.className).toContain("border-red-500/30");
|
|
expect(watchdogBanner?.className).toContain("bg-red-500/10");
|
|
|
|
const continueButton = Array.from(container.querySelectorAll("button")).find(
|
|
(button) => button.textContent?.includes("Continue monitoring"),
|
|
);
|
|
expect(continueButton).not.toBeUndefined();
|
|
act(() => {
|
|
continueButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
expect(onWatchdogDecision).toHaveBeenCalledWith({
|
|
runId: "run-live-1",
|
|
decision: "continue",
|
|
evaluationIssueId: "issue-eval-1",
|
|
});
|
|
});
|
|
|
|
it.each([
|
|
{
|
|
level: "suspicious" as const,
|
|
heading: "Output silence watchdog warning",
|
|
badge: "Output silence",
|
|
},
|
|
{
|
|
level: "critical" as const,
|
|
heading: "Critical output silence",
|
|
badge: "Critical silence",
|
|
},
|
|
])("renders a $level UI-only signal without an evaluation-task link", ({ level, heading, badge }) => {
|
|
const onWatchdogDecision = vi.fn();
|
|
const activeRun = createActiveRun();
|
|
renderLedger({
|
|
runs: [createRun({ runId: activeRun.id, status: "running", finishedAt: null })],
|
|
activeRun: createActiveRun({
|
|
outputSilence: {
|
|
...activeRun.outputSilence!,
|
|
level,
|
|
evaluationIssueId: null,
|
|
evaluationIssueIdentifier: null,
|
|
evaluationIssueAssigneeAgentId: null,
|
|
},
|
|
}),
|
|
onWatchdogDecision,
|
|
});
|
|
|
|
expect(container.textContent).toContain(heading);
|
|
expect(container.textContent).toContain(badge);
|
|
expect(container.textContent).toContain("Paperclip did not create or assign a recovery task");
|
|
expect(container.textContent).not.toContain("PAP-404");
|
|
expect(container.querySelector('a[href^="/issues/"]')).toBeNull();
|
|
expect(container.textContent).toContain("Continue monitoring");
|
|
expect(container.textContent).toContain("Snooze 1h");
|
|
expect(container.textContent).toContain("Mark false positive");
|
|
|
|
const continueButton = Array.from(container.querySelectorAll("button")).find(
|
|
(button) => button.textContent?.includes("Continue monitoring"),
|
|
);
|
|
act(() => {
|
|
continueButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
expect(onWatchdogDecision).toHaveBeenCalledWith({
|
|
runId: "run-live-1",
|
|
decision: "continue",
|
|
evaluationIssueId: null,
|
|
});
|
|
});
|
|
|
|
it("hides watchdog decision actions for known non-owner viewers", () => {
|
|
const onWatchdogDecision = vi.fn();
|
|
renderLedger({
|
|
runs: [createRun({ runId: "run-live-1", status: "running", finishedAt: null })],
|
|
activeRun: createActiveRun(),
|
|
canRecordWatchdogDecisions: false,
|
|
onWatchdogDecision,
|
|
});
|
|
|
|
expect(container.textContent).toContain("Critical output silence");
|
|
expect(container.textContent).toContain("PAP-404");
|
|
expect(container.textContent).not.toContain("Continue monitoring");
|
|
expect(container.textContent).not.toContain("Snooze 1h");
|
|
expect(container.textContent).not.toContain("Mark false positive");
|
|
expect(
|
|
Array.from(container.querySelectorAll("button")).filter((button) =>
|
|
/continue|snooze|false positive/i.test(button.textContent ?? ""),
|
|
),
|
|
).toHaveLength(0);
|
|
expect(onWatchdogDecision).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("surfaces the responsible user a run acts on behalf of", () => {
|
|
renderLedger({
|
|
runs: [createRun({ runId: "run-obo-1", responsibleUserId: "user-2" })],
|
|
resolveUserLabel: (userId) => (userId === "user-2" ? "Ada Lovelace" : null),
|
|
});
|
|
|
|
const chip = container.querySelector('[data-testid="run-on-behalf-of"]');
|
|
expect(chip).not.toBeNull();
|
|
expect(chip?.textContent).toContain("on behalf of");
|
|
expect(chip?.textContent).toContain("Ada Lovelace");
|
|
});
|
|
|
|
it("omits the on-behalf-of chip when the run has no responsible user", () => {
|
|
renderLedger({
|
|
runs: [createRun({ runId: "run-obo-2", responsibleUserId: null })],
|
|
resolveUserLabel: () => "Ada Lovelace",
|
|
});
|
|
|
|
expect(container.querySelector('[data-testid="run-on-behalf-of"]')).toBeNull();
|
|
});
|
|
|
|
it("renders actionable copy for a responsible-user-unauthorized run failure", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-denied-1",
|
|
status: "failed",
|
|
livenessState: "failed",
|
|
responsibleUserId: "user-2",
|
|
errorCode: "RESPONSIBLE_USER_UNAUTHORIZED",
|
|
}),
|
|
],
|
|
resolveUserLabel: () => "Ada Lovelace",
|
|
});
|
|
|
|
const notice = container.querySelector('[data-testid="responsible-user-denial-notice"]');
|
|
expect(notice).not.toBeNull();
|
|
expect(notice?.getAttribute("data-denial-tone")).toBe("unauthorized");
|
|
expect(notice?.textContent).toContain("Ada Lovelace");
|
|
expect(notice?.textContent).toContain("Responsible user not authorized");
|
|
});
|
|
|
|
it("steers the responsible-user-unavailable failure toward marking work blocked", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-denied-2",
|
|
status: "failed",
|
|
livenessState: "failed",
|
|
responsibleUserId: "user-3",
|
|
errorCode: "RESPONSIBLE_USER_UNAVAILABLE",
|
|
}),
|
|
],
|
|
resolveUserLabel: () => "Grace Hopper",
|
|
});
|
|
|
|
const notice = container.querySelector('[data-testid="responsible-user-denial-notice"]');
|
|
expect(notice).not.toBeNull();
|
|
expect(notice?.getAttribute("data-denial-tone")).toBe("unavailable");
|
|
expect(notice?.textContent?.toLowerCase()).toContain("blocked");
|
|
});
|
|
|
|
it("does not render a denial notice for a generic agent failure", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-denied-3",
|
|
status: "failed",
|
|
livenessState: "failed",
|
|
errorCode: "budget_blocked",
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.querySelector('[data-testid="responsible-user-denial-notice"]')).toBeNull();
|
|
});
|
|
});
|