mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:38:22 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
99 lines
4.2 KiB
TypeScript
99 lines
4.2 KiB
TypeScript
import { readDockerDatabaseReceipt, type DockerRun } from "./docker-postgres.js";
|
|
import { isOwnedExternalControllerDatabase } from "./instance-isolation.js";
|
|
import { mkdir, mkdtemp, realpath, readFile, writeFile } from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { paperclipConfigSchema } from "../../packages/shared/src/config-schema.js";
|
|
import { sweepExpiredKeptInstances } from "./instance-retention.js";
|
|
export { keepInstance } from "./instance-retention.js";
|
|
import { reserveRunnerE2EDatabasePort } from "./ports.js";
|
|
|
|
/** Runtime instructions and native filesystem grants must use the same path. */
|
|
export async function createRunnerE2ETemporaryRoot(parent = os.tmpdir()) {
|
|
await sweepExpiredKeptInstances(parent).catch(() => []);
|
|
return await realpath(await mkdtemp(path.join(parent, "paperclip-runner-e2e-")));
|
|
}
|
|
|
|
/** Seed only the disposable fixture. Onboarding preserves this validated config
|
|
* and still creates the normal secrets and database. Restarts keep the same DB.
|
|
*/
|
|
export async function prepareRunnerE2EServerConfig(input: {
|
|
temporaryRoot: string;
|
|
configPath: string;
|
|
serverPort: number;
|
|
dockerReceiptPath?: string;
|
|
dockerRun?: DockerRun;
|
|
}) {
|
|
const docker = input.dockerReceiptPath ? await readDockerDatabaseReceipt(input.dockerReceiptPath, input.temporaryRoot, input.dockerRun) : undefined;
|
|
try {
|
|
const existing = JSON.parse(await readFile(input.configPath, "utf8"));
|
|
const matchesLane = docker ? existing.database?.mode === "postgres" && existing.database.connectionString === docker.connectionString
|
|
: existing.database?.mode === "embedded-postgres" ? !existing.database.connectionString
|
|
// The launcher may already own a disposable external database for this config.
|
|
: existing.database?.mode === "postgres" && await isOwnedExternalControllerDatabase(input.configPath, input.temporaryRoot, existing.database);
|
|
if (!matchesLane) throw new Error("Existing runner database config differs from its explicit owned lane");
|
|
return null;
|
|
} catch (error) {
|
|
if ((error as NodeJS.ErrnoException).code !== "ENOENT") throw error;
|
|
}
|
|
const databaseReservation = docker ? null : await reserveRunnerE2EDatabasePort(input.serverPort);
|
|
try {
|
|
const instanceRoot = path.dirname(input.configPath);
|
|
const config = paperclipConfigSchema.parse({
|
|
$meta: {
|
|
version: 1,
|
|
updatedAt: new Date().toISOString(),
|
|
source: "onboard",
|
|
},
|
|
database: {
|
|
mode: docker ? "postgres" : "embedded-postgres",
|
|
...(docker ? { connectionString: docker.connectionString } : {}),
|
|
embeddedPostgresDataDir: path.join(instanceRoot, "db"),
|
|
embeddedPostgresPort: databaseReservation?.port ?? 54329,
|
|
backup: {
|
|
enabled: false,
|
|
dir: path.join(input.temporaryRoot, "backups"),
|
|
},
|
|
},
|
|
logging: { mode: "file", logDir: path.join(instanceRoot, "logs") },
|
|
server: {
|
|
deploymentMode: "local_trusted",
|
|
exposure: "private",
|
|
bind: "loopback",
|
|
host: "127.0.0.1",
|
|
port: input.serverPort,
|
|
serveUi: true,
|
|
},
|
|
storage: {
|
|
provider: "local_disk",
|
|
localDisk: { baseDir: path.join(input.temporaryRoot, "storage") },
|
|
},
|
|
secrets: {
|
|
provider: "local_encrypted",
|
|
strictMode: true,
|
|
localEncrypted: {
|
|
keyFilePath: path.join(instanceRoot, "secrets", "master.key"),
|
|
},
|
|
},
|
|
});
|
|
await mkdir(instanceRoot, { recursive: true, mode: 0o700 });
|
|
await writeFile(input.configPath, `${JSON.stringify(config, null, 2)}\n`, {
|
|
flag: "wx",
|
|
mode: 0o600,
|
|
});
|
|
return databaseReservation;
|
|
} catch (error) {
|
|
await databaseReservation?.close();
|
|
throw error;
|
|
}
|
|
}
|
|
|
|
/** Supervisor startup: the database lane selected by the launcher decides the config. */
|
|
export async function prepareSupervisorServerConfig(input: {
|
|
temporaryRoot: string; configPath: string; serverPort: number;
|
|
database: { filename?: string }; dockerRun?: DockerRun;
|
|
}) {
|
|
return await prepareRunnerE2EServerConfig({ temporaryRoot: input.temporaryRoot, configPath: input.configPath,
|
|
serverPort: input.serverPort, dockerReceiptPath: input.database.filename, dockerRun: input.dockerRun });
|
|
}
|